coreboot November 2010

coreboot@coreboot.org

48 participants
285 discussions

[commit] r6029 - in trunk/src/mainboard: amd/mahogany_fam10 amd/serengeti_cheetah amd/serengeti_cheetah_fam10 amd/tilapia_fam10 asus/a8n_e asus/a8v-e_se asus/m2v-mx_se asus/m4a785-m gigabyte/ga_276...
by repository service 06 Nov '10

06 Nov '10

Author: uwe Date: Sat Nov 6 01:57:19 2010 New Revision: 6029 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6029 Log: Remove comments that are obsolete since r6028. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/src/mainboard/amd/mahogany_fam10/romstage.c trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c trunk/src/mainboard/amd/serengeti_cheetah/romstage.c trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c trunk/src/mainboard/amd/tilapia_fam10/romstage.c trunk/src/mainboard/asus/a8n_e/romstage.c trunk/src/mainboard/asus/a8v-e_se/romstage.c trunk/src/mainboard/asus/m2v-mx_se/romstage.c trunk/src/mainboard/asus/m4a785-m/romstage.c trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c trunk/src/mainboard/gigabyte/ma785gmt/romstage.c trunk/src/mainboard/gigabyte/ma78gm/romstage.c trunk/src/mainboard/iwill/dk8_htx/romstage.c trunk/src/mainboard/iwill/dk8s2/romstage.c trunk/src/mainboard/iwill/dk8x/romstage.c trunk/src/mainboard/jetway/pa78vm5/romstage.c trunk/src/mainboard/msi/ms7135/romstage.c trunk/src/mainboard/msi/ms9185/romstage.c trunk/src/mainboard/msi/ms9282/romstage.c trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c trunk/src/mainboard/supermicro/h8dme/ap_romstage.c trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c trunk/src/mainboard/tyan/s2891/romstage.c trunk/src/mainboard/tyan/s2912/ap_romstage.c Modified: trunk/src/mainboard/amd/mahogany_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/amd/mahogany_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/amd/mahogany_fam10/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -23,8 +23,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 0 Modified: trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -3,8 +3,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h> Modified: trunk/src/mainboard/amd/serengeti_cheetah/romstage.c ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/amd/serengeti_cheetah/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -1,7 +1,5 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -23,8 +23,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 0 Modified: trunk/src/mainboard/amd/tilapia_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/amd/tilapia_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/amd/tilapia_fam10/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -23,8 +23,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 0 Modified: trunk/src/mainboard/asus/a8n_e/romstage.c ============================================================================== --- trunk/src/mainboard/asus/a8n_e/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/asus/a8n_e/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ /* Used by it8712f_enable_serial(). */ #define SERIAL_DEV PNP_DEV(0x2e, IT8712F_SP1) -/* Used by raminit. */ - #if CONFIG_LOGICAL_CPUS == 1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/asus/a8v-e_se/romstage.c ============================================================================== --- trunk/src/mainboard/asus/a8v-e_se/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/asus/a8v-e_se/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ unsigned int get_sbdn(unsigned bus); -/* Used by raminit. */ - /* Used by init_cpus and fidvid */ #define SET_FIDVID 1 Modified: trunk/src/mainboard/asus/m2v-mx_se/romstage.c ============================================================================== --- trunk/src/mainboard/asus/m2v-mx_se/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/asus/m2v-mx_se/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ unsigned int get_sbdn(unsigned bus); -/* Used by raminit. */ - /* Used by init_cpus and fidvid */ #define SET_FIDVID 1 Modified: trunk/src/mainboard/asus/m4a785-m/romstage.c ============================================================================== --- trunk/src/mainboard/asus/m4a785-m/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/asus/m4a785-m/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -23,8 +23,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 0 Modified: trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -26,8 +26,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h> Modified: trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h> Modified: trunk/src/mainboard/gigabyte/ma785gmt/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ma785gmt/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/gigabyte/ma785gmt/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -23,8 +23,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by init_cpus and fidvid #define SET_FIDVID 1 #define SET_FIDVID_CORE_RANGE 0 Modified: trunk/src/mainboard/gigabyte/ma78gm/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ma78gm/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/gigabyte/ma78gm/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -23,8 +23,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 0 Modified: trunk/src/mainboard/iwill/dk8_htx/romstage.c ============================================================================== --- trunk/src/mainboard/iwill/dk8_htx/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/iwill/dk8_htx/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -1,7 +1,5 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/iwill/dk8s2/romstage.c ============================================================================== --- trunk/src/mainboard/iwill/dk8s2/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/iwill/dk8s2/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -1,7 +1,5 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/iwill/dk8x/romstage.c ============================================================================== --- trunk/src/mainboard/iwill/dk8x/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/iwill/dk8x/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -1,7 +1,5 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/jetway/pa78vm5/romstage.c ============================================================================== --- trunk/src/mainboard/jetway/pa78vm5/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/jetway/pa78vm5/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 0 Modified: trunk/src/mainboard/msi/ms7135/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms7135/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/msi/ms7135/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SERIAL_DEV PNP_DEV(0x4e, W83627THF_SP1) -/* Used by raminit. */ - #if CONFIG_LOGICAL_CPUS == 1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/msi/ms9185/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms9185/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/msi/ms9185/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -25,8 +25,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/msi/ms9282/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms9282/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/msi/ms9282/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - // used by init_cpus and fidvid (disabled until someone tests this) // #define SET_FIDVID 1 #define SET_FIDVID 0 Modified: trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c ============================================================================== --- trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h> Modified: trunk/src/mainboard/supermicro/h8dme/ap_romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8dme/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/supermicro/h8dme/ap_romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h> Modified: trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h> Modified: trunk/src/mainboard/tyan/s2891/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2891/romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/tyan/s2891/romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -1,5 +1,3 @@ -//used by raminit - #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/tyan/s2912/ap_romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2912/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) +++ trunk/src/mainboard/tyan/s2912/ap_romstage.c Sat Nov 6 01:57:19 2010 (r6029) @@ -24,8 +24,6 @@ #define SET_NB_CFG_54 1 -//used by raminit - #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h>

1 0

Re: [coreboot] [PATCH 0/4] Geode GX2 auto DRAM detect patch V2
by Nils 06 Nov '10

06 Nov '10

Hi Uwe, Thanks for the fast review and commit! >Heh, fun. This was a bug anyway (0x2000001d vs. 0x2000201d). Yes. >Thanks, r6009. I took the freedom to do a few more whitespace cleanups. Thanks, i must have overlooked them. >Thanks, r6011 with some small whitespace changes and s/Mhz/MHz/. OK thanks. >Maybe we could make a GX2_PROCESSOR_MHZ_300, GX2_PROCESSOR_MHZ_366 etc. >here, and let each board "select" the correct one in its Kconfig file? This sounds good, i actually thought about something like that but i didn’t quite know how. And because at the moment there are only boards with 366 Mhz so i skipped it. I will study it some more and try to make a patch for it. >I'd personally drop this (also in the LX code), let's just use printk(), >there's no reason to add such a mini-wrapper. I copied it from LX. I will make a patch for that when i find some time. >Shouldn't there be a "while (1)" around the hlt instruction? ?? i don't know should it? The code seems to work, but if it is preferred/needed i will add it. Can you point me to some example code or could you supply some code snipped i can test? Thanks, Nils.

2 2

[PATCH] Define unused DIMM1 to 0xFF on Geode GX2 boards
by Nils 06 Nov '10

06 Nov '10

This patch defines the unused DIMM1 to 0xFF to make it obvious it is a bogus value. Signed-off-by: Nils Jacobs <njacobs8(a)hetnet.nl> This was requested by Myles. This is Abuild and boot tested. Thanks, Nils.

2 2

[PATCH] Add cpu speed selection to Geode GX2 boards
by Nils 06 Nov '10

06 Nov '10

This patch adds Kconfig cpu speed selection to Geode GX2 boards as requested by Uwe. Signed-off-by: Nils Jacobs <njacobs8(a)hetnet.nl> This is Abuild and boot tested. Thanks, Nils.

2 2

[PATCH] Geode GX2 print(k) V2
by Nils 06 Nov '10

06 Nov '10

Remove banner wrapper function and unify print(k). Signed-off-by: Nils Jacobs <njacobs8(a)hetnet.nl> The banner part was requested by Uwe. This is Abuild and boot tested. V2:Also change Assymetirc into Asymmetric thanks to Idwer for spotting. Thanks, Nils.

2 2

[commit] r6028 - in trunk/src: mainboard/amd/dbm690t mainboard/amd/mahogany mainboard/amd/mahogany_fam10 mainboard/amd/pistachio mainboard/amd/serengeti_cheetah mainboard/amd/serengeti_cheetah_fam1...
by repository service 05 Nov '10

05 Nov '10

Author: oxygene Date: Fri Nov 5 23:59:49 2010 New Revision: 6028 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6028 Log: Move QRANK_DIMM_SUPPORT to Kconfig, removing it from romstage.c Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/src/mainboard/amd/dbm690t/Kconfig trunk/src/mainboard/amd/dbm690t/romstage.c trunk/src/mainboard/amd/mahogany/Kconfig trunk/src/mainboard/amd/mahogany/romstage.c trunk/src/mainboard/amd/mahogany_fam10/Kconfig trunk/src/mainboard/amd/mahogany_fam10/romstage.c trunk/src/mainboard/amd/pistachio/Kconfig trunk/src/mainboard/amd/pistachio/romstage.c trunk/src/mainboard/amd/serengeti_cheetah/Kconfig trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c trunk/src/mainboard/amd/serengeti_cheetah/romstage.c trunk/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c trunk/src/mainboard/amd/tilapia_fam10/Kconfig trunk/src/mainboard/amd/tilapia_fam10/romstage.c trunk/src/mainboard/arima/hdama/Kconfig trunk/src/mainboard/arima/hdama/romstage.c trunk/src/mainboard/asrock/939a785gmh/Kconfig trunk/src/mainboard/asrock/939a785gmh/romstage.c trunk/src/mainboard/asus/a8n_e/Kconfig trunk/src/mainboard/asus/a8n_e/romstage.c trunk/src/mainboard/asus/a8v-e_se/Kconfig trunk/src/mainboard/asus/a8v-e_se/romstage.c trunk/src/mainboard/asus/m2v-mx_se/Kconfig trunk/src/mainboard/asus/m2v-mx_se/romstage.c trunk/src/mainboard/asus/m4a785-m/Kconfig trunk/src/mainboard/asus/m4a785-m/romstage.c trunk/src/mainboard/broadcom/blast/Kconfig trunk/src/mainboard/broadcom/blast/romstage.c trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c trunk/src/mainboard/gigabyte/m57sli/Kconfig trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c trunk/src/mainboard/gigabyte/m57sli/romstage.c trunk/src/mainboard/gigabyte/ma785gmt/Kconfig trunk/src/mainboard/gigabyte/ma785gmt/romstage.c trunk/src/mainboard/gigabyte/ma78gm/Kconfig trunk/src/mainboard/gigabyte/ma78gm/romstage.c trunk/src/mainboard/hp/dl145_g1/Kconfig trunk/src/mainboard/hp/dl145_g1/romstage.c trunk/src/mainboard/hp/dl145_g3/Kconfig trunk/src/mainboard/hp/dl145_g3/romstage.c trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c trunk/src/mainboard/ibm/e325/Kconfig trunk/src/mainboard/ibm/e325/romstage.c trunk/src/mainboard/ibm/e326/Kconfig trunk/src/mainboard/ibm/e326/romstage.c trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig trunk/src/mainboard/iei/kino-780am2-fam10/romstage.c trunk/src/mainboard/iwill/dk8_htx/Kconfig trunk/src/mainboard/iwill/dk8_htx/romstage.c trunk/src/mainboard/iwill/dk8s2/Kconfig trunk/src/mainboard/iwill/dk8s2/romstage.c trunk/src/mainboard/iwill/dk8x/Kconfig trunk/src/mainboard/iwill/dk8x/romstage.c trunk/src/mainboard/jetway/pa78vm5/Kconfig trunk/src/mainboard/jetway/pa78vm5/romstage.c trunk/src/mainboard/kontron/kt690/Kconfig trunk/src/mainboard/kontron/kt690/romstage.c trunk/src/mainboard/msi/ms7135/Kconfig trunk/src/mainboard/msi/ms7135/romstage.c trunk/src/mainboard/msi/ms7260/Kconfig trunk/src/mainboard/msi/ms7260/ap_romstage.c trunk/src/mainboard/msi/ms7260/romstage.c trunk/src/mainboard/msi/ms9185/Kconfig trunk/src/mainboard/msi/ms9185/romstage.c trunk/src/mainboard/msi/ms9282/Kconfig trunk/src/mainboard/msi/ms9282/romstage.c trunk/src/mainboard/msi/ms9652_fam10/Kconfig trunk/src/mainboard/msi/ms9652_fam10/romstage.c trunk/src/mainboard/newisys/khepri/Kconfig trunk/src/mainboard/newisys/khepri/romstage.c trunk/src/mainboard/nvidia/l1_2pvv/Kconfig trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c trunk/src/mainboard/nvidia/l1_2pvv/romstage.c trunk/src/mainboard/sunw/ultra40/Kconfig trunk/src/mainboard/sunw/ultra40/romstage.c trunk/src/mainboard/supermicro/h8dme/Kconfig trunk/src/mainboard/supermicro/h8dme/ap_romstage.c trunk/src/mainboard/supermicro/h8dme/romstage.c trunk/src/mainboard/supermicro/h8dmr/Kconfig trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c trunk/src/mainboard/supermicro/h8dmr/romstage.c trunk/src/mainboard/supermicro/h8dmr_fam10/Kconfig trunk/src/mainboard/supermicro/h8dmr_fam10/romstage.c trunk/src/mainboard/supermicro/h8qme_fam10/Kconfig trunk/src/mainboard/supermicro/h8qme_fam10/romstage.c trunk/src/mainboard/technexion/tim5690/Kconfig trunk/src/mainboard/technexion/tim5690/romstage.c trunk/src/mainboard/technexion/tim8690/Kconfig trunk/src/mainboard/technexion/tim8690/romstage.c trunk/src/mainboard/tyan/s2875/Kconfig trunk/src/mainboard/tyan/s2875/romstage.c trunk/src/mainboard/tyan/s2880/Kconfig trunk/src/mainboard/tyan/s2880/romstage.c trunk/src/mainboard/tyan/s2881/Kconfig trunk/src/mainboard/tyan/s2881/romstage.c trunk/src/mainboard/tyan/s2882/Kconfig trunk/src/mainboard/tyan/s2882/romstage.c trunk/src/mainboard/tyan/s2885/Kconfig trunk/src/mainboard/tyan/s2885/romstage.c trunk/src/mainboard/tyan/s2891/Kconfig trunk/src/mainboard/tyan/s2891/romstage.c trunk/src/mainboard/tyan/s2892/Kconfig trunk/src/mainboard/tyan/s2892/romstage.c trunk/src/mainboard/tyan/s2895/Kconfig trunk/src/mainboard/tyan/s2895/romstage.c trunk/src/mainboard/tyan/s2912/Kconfig trunk/src/mainboard/tyan/s2912/ap_romstage.c trunk/src/mainboard/tyan/s2912/romstage.c trunk/src/mainboard/tyan/s2912_fam10/Kconfig trunk/src/mainboard/tyan/s2912_fam10/romstage.c trunk/src/mainboard/tyan/s4880/Kconfig trunk/src/mainboard/tyan/s4880/romstage.c trunk/src/mainboard/tyan/s4882/Kconfig trunk/src/mainboard/tyan/s4882/romstage.c trunk/src/northbridge/amd/amdk8/Kconfig trunk/src/northbridge/amd/amdk8/raminit.c trunk/src/northbridge/amd/amdk8/raminit_f.c Modified: trunk/src/mainboard/amd/dbm690t/Kconfig ============================================================================== --- trunk/src/mainboard/amd/dbm690t/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/dbm690t/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select SB_HT_CHAIN_UNITID_OFFSET_ONLY select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/amd/dbm690t/romstage.c ============================================================================== --- trunk/src/mainboard/amd/dbm690t/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/dbm690t/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -18,7 +18,6 @@ */ #define SET_FIDVID 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/amd/mahogany/Kconfig ============================================================================== --- trunk/src/mainboard/amd/mahogany/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/mahogany/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -24,6 +24,7 @@ select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO select GFXUMA + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/amd/mahogany/romstage.c ============================================================================== --- trunk/src/mainboard/amd/mahogany/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/mahogany/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -18,7 +18,6 @@ */ #define SET_FIDVID 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/amd/mahogany_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/amd/mahogany_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/mahogany_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -28,6 +28,7 @@ select ENABLE_APIC_EXT_ID select TINY_BOOTBLOCK select GFXUMA + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/amd/mahogany_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/amd/mahogany_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/mahogany_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 Modified: trunk/src/mainboard/amd/pistachio/Kconfig ============================================================================== --- trunk/src/mainboard/amd/pistachio/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/pistachio/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/amd/pistachio/romstage.c ============================================================================== --- trunk/src/mainboard/amd/pistachio/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/pistachio/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -18,7 +18,6 @@ */ #define SET_FIDVID 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/amd/serengeti_cheetah/Kconfig ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/serengeti_cheetah/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -25,6 +25,7 @@ select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/serengeti_cheetah/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -4,7 +4,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 Modified: trunk/src/mainboard/amd/serengeti_cheetah/romstage.c ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/serengeti_cheetah/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,7 +1,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -26,6 +26,7 @@ select ENABLE_APIC_EXT_ID select LIFT_BSP_APIC_ID select TINY_BOOTBLOCK + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 Modified: trunk/src/mainboard/amd/tilapia_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/amd/tilapia_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/tilapia_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -28,6 +28,7 @@ select ENABLE_APIC_EXT_ID select TINY_BOOTBLOCK select GFXUMA + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/amd/tilapia_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/amd/tilapia_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/amd/tilapia_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 Modified: trunk/src/mainboard/arima/hdama/Kconfig ============================================================================== --- trunk/src/mainboard/arima/hdama/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/arima/hdama/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -15,6 +15,7 @@ select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select BOARD_ROMSIZE_KB_512 + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/arima/hdama/romstage.c ============================================================================== --- trunk/src/mainboard/arima/hdama/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/arima/hdama/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -67,7 +67,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/resourcemap.c" Modified: trunk/src/mainboard/asrock/939a785gmh/Kconfig ============================================================================== --- trunk/src/mainboard/asrock/939a785gmh/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asrock/939a785gmh/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -24,6 +24,7 @@ select BOARD_ROMSIZE_KB_1024 select GFXUMA select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/asrock/939a785gmh/romstage.c ============================================================================== --- trunk/src/mainboard/asrock/939a785gmh/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asrock/939a785gmh/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -19,7 +19,6 @@ */ #define SET_FIDVID 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/asus/a8n_e/Kconfig ============================================================================== --- trunk/src/mainboard/asus/a8n_e/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/a8n_e/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -17,6 +17,7 @@ select BOARD_ROMSIZE_KB_512 select CK804_USE_NIC select CK804_USE_ACI + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/asus/a8n_e/romstage.c ============================================================================== --- trunk/src/mainboard/asus/a8n_e/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/a8n_e/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SERIAL_DEV PNP_DEV(0x2e, IT8712F_SP1) /* Used by raminit. */ -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS == 1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/asus/a8v-e_se/Kconfig ============================================================================== --- trunk/src/mainboard/asus/a8v-e_se/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/a8v-e_se/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/asus/a8v-e_se/romstage.c ============================================================================== --- trunk/src/mainboard/asus/a8v-e_se/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/a8v-e_se/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ unsigned int get_sbdn(unsigned bus); /* Used by raminit. */ -#define QRANK_DIMM_SUPPORT 1 /* Used by init_cpus and fidvid */ #define SET_FIDVID 1 Modified: trunk/src/mainboard/asus/m2v-mx_se/Kconfig ============================================================================== --- trunk/src/mainboard/asus/m2v-mx_se/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/m2v-mx_se/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -36,6 +36,7 @@ select VGA select TINY_BOOTBLOCK select HAVE_MAINBOARD_RESOURCES + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/asus/m2v-mx_se/romstage.c ============================================================================== --- trunk/src/mainboard/asus/m2v-mx_se/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/m2v-mx_se/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ unsigned int get_sbdn(unsigned bus); /* Used by raminit. */ -#define QRANK_DIMM_SUPPORT 1 /* Used by init_cpus and fidvid */ #define SET_FIDVID 1 Modified: trunk/src/mainboard/asus/m4a785-m/Kconfig ============================================================================== --- trunk/src/mainboard/asus/m4a785-m/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/m4a785-m/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -27,6 +27,7 @@ select ENABLE_APIC_EXT_ID select TINY_BOOTBLOCK select GFXUMA + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/asus/m4a785-m/romstage.c ============================================================================== --- trunk/src/mainboard/asus/m4a785-m/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/asus/m4a785-m/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 Modified: trunk/src/mainboard/broadcom/blast/Kconfig ============================================================================== --- trunk/src/mainboard/broadcom/blast/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/broadcom/blast/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/broadcom/blast/romstage.c ============================================================================== --- trunk/src/mainboard/broadcom/blast/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/broadcom/blast/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,4 +1,3 @@ -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig ============================================================================== --- trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -19,6 +19,7 @@ select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/ga_2761gxdk/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -27,7 +27,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 Modified: trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/ga_2761gxdk/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -23,7 +23,6 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/gigabyte/m57sli/Kconfig ============================================================================== --- trunk/src/mainboard/gigabyte/m57sli/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/m57sli/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -23,6 +23,7 @@ select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/m57sli/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 Modified: trunk/src/mainboard/gigabyte/m57sli/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/m57sli/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/m57sli/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -21,7 +21,6 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/gigabyte/ma785gmt/Kconfig ============================================================================== --- trunk/src/mainboard/gigabyte/ma785gmt/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/ma785gmt/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -28,6 +28,7 @@ select TINY_BOOTBLOCK select GFXUMA select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/gigabyte/ma785gmt/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ma785gmt/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/ma785gmt/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by init_cpus and fidvid #define SET_FIDVID 1 Modified: trunk/src/mainboard/gigabyte/ma78gm/Kconfig ============================================================================== --- trunk/src/mainboard/gigabyte/ma78gm/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/ma78gm/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -28,6 +28,7 @@ select TINY_BOOTBLOCK select GFXUMA select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/gigabyte/ma78gm/romstage.c ============================================================================== --- trunk/src/mainboard/gigabyte/ma78gm/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/gigabyte/ma78gm/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 Modified: trunk/src/mainboard/hp/dl145_g1/Kconfig ============================================================================== --- trunk/src/mainboard/hp/dl145_g1/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/hp/dl145_g1/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_512 # select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/hp/dl145_g1/romstage.c ============================================================================== --- trunk/src/mainboard/hp/dl145_g1/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/hp/dl145_g1/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,4 +1,3 @@ -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/hp/dl145_g3/Kconfig ============================================================================== --- trunk/src/mainboard/hp/dl145_g3/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/hp/dl145_g3/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/hp/dl145_g3/romstage.c ============================================================================== --- trunk/src/mainboard/hp/dl145_g3/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/hp/dl145_g3/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -27,7 +27,6 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -23,6 +23,7 @@ select ENABLE_APIC_EXT_ID select AMDMCT select TINY_BOOTBLOCK + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -28,7 +28,6 @@ #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/ibm/e325/Kconfig ============================================================================== --- trunk/src/mainboard/ibm/e325/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/ibm/e325/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select SB_HT_CHAIN_UNITID_OFFSET_ONLY select WAIT_BEFORE_CPUS_INIT select BOARD_ROMSIZE_KB_512 + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/ibm/e325/romstage.c ============================================================================== --- trunk/src/mainboard/ibm/e325/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/ibm/e325/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -64,7 +64,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "resourcemap.c" Modified: trunk/src/mainboard/ibm/e326/Kconfig ============================================================================== --- trunk/src/mainboard/ibm/e326/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/ibm/e326/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select SB_HT_CHAIN_UNITID_OFFSET_ONLY select WAIT_BEFORE_CPUS_INIT select BOARD_ROMSIZE_KB_512 + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/ibm/e326/romstage.c ============================================================================== --- trunk/src/mainboard/ibm/e326/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/ibm/e326/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -64,7 +64,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "resourcemap.c" Modified: trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig ============================================================================== --- trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -28,6 +28,7 @@ select ENABLE_APIC_EXT_ID select TINY_BOOTBLOCK select GFXUMA + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/iei/kino-780am2-fam10/romstage.c ============================================================================== --- trunk/src/mainboard/iei/kino-780am2-fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iei/kino-780am2-fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 Modified: trunk/src/mainboard/iwill/dk8_htx/Kconfig ============================================================================== --- trunk/src/mainboard/iwill/dk8_htx/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iwill/dk8_htx/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/iwill/dk8_htx/romstage.c ============================================================================== --- trunk/src/mainboard/iwill/dk8_htx/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iwill/dk8_htx/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,7 +1,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/iwill/dk8s2/Kconfig ============================================================================== --- trunk/src/mainboard/iwill/dk8s2/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iwill/dk8s2/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -18,6 +18,7 @@ select ATI_RAGE_XL select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/iwill/dk8s2/romstage.c ============================================================================== --- trunk/src/mainboard/iwill/dk8s2/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iwill/dk8s2/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,7 +1,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/iwill/dk8x/Kconfig ============================================================================== --- trunk/src/mainboard/iwill/dk8x/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iwill/dk8x/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -17,6 +17,7 @@ select WAIT_BEFORE_CPUS_INIT select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/iwill/dk8x/romstage.c ============================================================================== --- trunk/src/mainboard/iwill/dk8x/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/iwill/dk8x/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,7 +1,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/jetway/pa78vm5/Kconfig ============================================================================== --- trunk/src/mainboard/jetway/pa78vm5/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/jetway/pa78vm5/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -28,6 +28,7 @@ select ENABLE_APIC_EXT_ID select TINY_BOOTBLOCK select GFXUMA + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/jetway/pa78vm5/romstage.c ============================================================================== --- trunk/src/mainboard/jetway/pa78vm5/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/jetway/pa78vm5/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht #define FAM10_SCAN_PCI_BUS 0 Modified: trunk/src/mainboard/kontron/kt690/Kconfig ============================================================================== --- trunk/src/mainboard/kontron/kt690/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/kontron/kt690/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -22,6 +22,7 @@ select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/kontron/kt690/romstage.c ============================================================================== --- trunk/src/mainboard/kontron/kt690/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/kontron/kt690/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -19,7 +19,6 @@ */ #define SET_FIDVID 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/msi/ms7135/Kconfig ============================================================================== --- trunk/src/mainboard/msi/ms7135/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms7135/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select BOARD_ROMSIZE_KB_512 select CK804_USE_NIC select CK804_USE_ACI + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/msi/ms7135/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms7135/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms7135/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SERIAL_DEV PNP_DEV(0x4e, W83627THF_SP1) /* Used by raminit. */ -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS == 1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/msi/ms7260/Kconfig ============================================================================== --- trunk/src/mainboard/msi/ms7260/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms7260/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/msi/ms7260/ap_romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms7260/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms7260/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -24,7 +24,6 @@ #define __PRE_RAM__ #define SET_NB_CFG_54 1 /* Used by RAM init. */ -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #include <stdint.h> Modified: trunk/src/mainboard/msi/ms7260/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms7260/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms7260/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ // #define RES_DEBUG 1 #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS == 1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/msi/ms9185/Kconfig ============================================================================== --- trunk/src/mainboard/msi/ms9185/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms9185/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/msi/ms9185/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms9185/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms9185/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -26,7 +26,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 //used by incoherent_ht //#define K8_ALLOCATE_IO_RANGE 1 Modified: trunk/src/mainboard/msi/ms9282/Kconfig ============================================================================== --- trunk/src/mainboard/msi/ms9282/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms9282/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -19,6 +19,7 @@ select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/msi/ms9282/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms9282/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms9282/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 // used by init_cpus and fidvid (disabled until someone tests this) // #define SET_FIDVID 1 Modified: trunk/src/mainboard/msi/ms9652_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/msi/ms9652_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms9652_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -24,6 +24,7 @@ select AMDMCT select TINY_BOOTBLOCK select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/msi/ms9652_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/msi/ms9652_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/msi/ms9652_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -22,7 +22,6 @@ #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/newisys/khepri/Kconfig ============================================================================== --- trunk/src/mainboard/newisys/khepri/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/newisys/khepri/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -15,6 +15,7 @@ select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/newisys/khepri/romstage.c ============================================================================== --- trunk/src/mainboard/newisys/khepri/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/newisys/khepri/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -72,7 +72,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/coherent_ht.c" Modified: trunk/src/mainboard/nvidia/l1_2pvv/Kconfig ============================================================================== --- trunk/src/mainboard/nvidia/l1_2pvv/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/nvidia/l1_2pvv/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -22,6 +22,7 @@ select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c ============================================================================== --- trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/nvidia/l1_2pvv/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 Modified: trunk/src/mainboard/nvidia/l1_2pvv/romstage.c ============================================================================== --- trunk/src/mainboard/nvidia/l1_2pvv/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/nvidia/l1_2pvv/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -21,7 +21,6 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/sunw/ultra40/Kconfig ============================================================================== --- trunk/src/mainboard/sunw/ultra40/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/sunw/ultra40/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select BOARD_ROMSIZE_KB_1024 select CK804_USE_NIC select CK804_USE_ACI + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/sunw/ultra40/romstage.c ============================================================================== --- trunk/src/mainboard/sunw/ultra40/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/sunw/ultra40/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,6 +1,5 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/supermicro/h8dme/Kconfig ============================================================================== --- trunk/src/mainboard/supermicro/h8dme/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dme/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -22,6 +22,7 @@ select LIFT_BSP_APIC_ID select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/supermicro/h8dme/ap_romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8dme/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dme/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 Modified: trunk/src/mainboard/supermicro/h8dme/romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8dme/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dme/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -18,7 +18,6 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/supermicro/h8dmr/Kconfig ============================================================================== --- trunk/src/mainboard/supermicro/h8dmr/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dmr/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select LIFT_BSP_APIC_ID select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dmr/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 Modified: trunk/src/mainboard/supermicro/h8dmr/romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8dmr/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dmr/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -21,7 +21,6 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/supermicro/h8dmr_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/supermicro/h8dmr_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dmr_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -23,6 +23,7 @@ select RAMINIT_SYSINFO select TINY_BOOTBLOCK select ENABLE_APIC_EXT_ID + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/supermicro/h8dmr_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8dmr_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8dmr_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -22,7 +22,6 @@ #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/supermicro/h8qme_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/supermicro/h8qme_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8qme_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -22,6 +22,7 @@ select RAMINIT_SYSINFO select TINY_BOOTBLOCK select ENABLE_APIC_EXT_ID + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/supermicro/h8qme_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/supermicro/h8qme_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/supermicro/h8qme_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -22,7 +22,6 @@ #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/technexion/tim5690/Kconfig ============================================================================== --- trunk/src/mainboard/technexion/tim5690/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/technexion/tim5690/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -22,6 +22,7 @@ select HAVE_MAINBOARD_RESOURCES select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/technexion/tim5690/romstage.c ============================================================================== --- trunk/src/mainboard/technexion/tim5690/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/technexion/tim5690/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -18,7 +18,6 @@ */ #define SET_FIDVID 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/technexion/tim8690/Kconfig ============================================================================== --- trunk/src/mainboard/technexion/tim8690/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/technexion/tim8690/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/technexion/tim8690/romstage.c ============================================================================== --- trunk/src/mainboard/technexion/tim8690/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/technexion/tim8690/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -18,7 +18,6 @@ */ #define SET_FIDVID 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 #endif Modified: trunk/src/mainboard/tyan/s2875/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2875/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2875/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -15,6 +15,7 @@ select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2875/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2875/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2875/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -62,7 +62,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/coherent_ht.c" Modified: trunk/src/mainboard/tyan/s2880/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2880/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2880/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -15,6 +15,7 @@ select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2880/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2880/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2880/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -62,7 +62,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/resourcemap.c" Modified: trunk/src/mainboard/tyan/s2881/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2881/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2881/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -17,6 +17,7 @@ select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY select DRIVERS_SIL_3114 + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2881/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2881/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2881/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,4 +1,3 @@ -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/tyan/s2882/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2882/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2882/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -16,6 +16,7 @@ select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY select DRIVERS_SIL_3114 + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2882/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2882/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2882/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -62,7 +62,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/resourcemap.c" Modified: trunk/src/mainboard/tyan/s2885/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2885/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2885/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -17,6 +17,7 @@ select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2885/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2885/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2885/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -62,7 +62,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/coherent_ht.c" Modified: trunk/src/mainboard/tyan/s2891/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2891/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2891/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -18,6 +18,7 @@ select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2891/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2891/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2891/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,5 +1,4 @@ //used by raminit -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/tyan/s2892/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2892/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2892/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -17,6 +17,7 @@ select SERIAL_CPU_INIT select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2892/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2892/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2892/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,4 +1,3 @@ -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/tyan/s2895/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2895/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2895/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -17,6 +17,7 @@ select SERIAL_CPU_INIT select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2895/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2895/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2895/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -1,6 +1,5 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/tyan/s2912/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2912/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2912/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -21,6 +21,7 @@ select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2912/ap_romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2912/ap_romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2912/ap_romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -25,7 +25,6 @@ #define SET_NB_CFG_54 1 //used by raminit -#define QRANK_DIMM_SUPPORT 1 #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 Modified: trunk/src/mainboard/tyan/s2912/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2912/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2912/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -21,7 +21,6 @@ #define K8_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/tyan/s2912_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s2912_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2912_fam10/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -23,6 +23,7 @@ select AMDMCT select TINY_BOOTBLOCK select MMCONF_SUPPORT_DEFAULT + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s2912_fam10/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s2912_fam10/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s2912_fam10/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -22,7 +22,6 @@ #define FAM10_SCAN_PCI_BUS 0 #define FAM10_ALLOCATE_IO_RANGE 1 -#define QRANK_DIMM_SUPPORT 1 #if CONFIG_LOGICAL_CPUS==1 #define SET_NB_CFG_54 1 Modified: trunk/src/mainboard/tyan/s4880/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s4880/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s4880/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -15,6 +15,7 @@ select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s4880/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s4880/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s4880/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -76,7 +76,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/coherent_ht.c" Modified: trunk/src/mainboard/tyan/s4882/Kconfig ============================================================================== --- trunk/src/mainboard/tyan/s4882/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s4882/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -15,6 +15,7 @@ select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY + select QRANK_DIMM_SUPPORT config MAINBOARD_DIR string Modified: trunk/src/mainboard/tyan/s4882/romstage.c ============================================================================== --- trunk/src/mainboard/tyan/s4882/romstage.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/mainboard/tyan/s4882/romstage.c Fri Nov 5 23:59:49 2010 (r6028) @@ -84,7 +84,6 @@ return smbus_read_byte(device, address); } -#define QRANK_DIMM_SUPPORT 1 #include "northbridge/amd/amdk8/raminit.c" #include "northbridge/amd/amdk8/coherent_ht.c" Modified: trunk/src/northbridge/amd/amdk8/Kconfig ============================================================================== --- trunk/src/northbridge/amd/amdk8/Kconfig Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/northbridge/amd/amdk8/Kconfig Fri Nov 5 23:59:49 2010 (r6028) @@ -49,6 +49,10 @@ bool default n +config QRANK_DIMM_SUPPORT + bool + default n + if K8_REV_F_SUPPORT config DIMM_DDR2 Modified: trunk/src/northbridge/amd/amdk8/raminit.c ============================================================================== --- trunk/src/northbridge/amd/amdk8/raminit.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/northbridge/amd/amdk8/raminit.c Fri Nov 5 23:59:49 2010 (r6028) @@ -18,10 +18,6 @@ # error "CONFIG_RAMTOP must be a power of 2" #endif -#ifndef QRANK_DIMM_SUPPORT -#define QRANK_DIMM_SUPPORT 0 -#endif - void setup_resource_map(const unsigned int *register_values, int max) { int i; @@ -595,7 +591,7 @@ unsigned long side2; unsigned long rows; unsigned long col; -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT unsigned long rank; #endif }; @@ -609,7 +605,7 @@ sz.side2 = 0; sz.rows = 0; sz.col = 0; -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT sz.rank = 0; #endif @@ -653,7 +649,7 @@ if ((value != 2) && (value != 4 )) { goto val_err; } -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT sz.rank = value; #endif @@ -682,7 +678,7 @@ sz.side2 = 0; sz.rows = 0; sz.col = 0; -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT sz.rank = 0; #endif out: @@ -730,7 +726,7 @@ /* Set the appropriate DIMM base address register */ pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+0)<<2), base0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+1)<<2), base1); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz.rank == 4) { pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+4)<<2), base0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1)+5)<<2), base1); @@ -741,7 +737,7 @@ if (base0) { dch = pci_read_config32(ctrl->f2, DRAM_CONFIG_HIGH); dch |= DCH_MEMCLK_EN0 << index; -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz.rank == 4) { dch |= DCH_MEMCLK_EN0 << (index + 2); } @@ -763,7 +759,7 @@ map = pci_read_config32(ctrl->f2, DRAM_BANK_ADDR_MAP); map &= ~(0xf << (index * 4)); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz.rank == 4) { map &= ~(0xf << ( (index + 2) * 4)); } @@ -774,7 +770,7 @@ if (sz.side1 >= (25 +3)) { if (is_cpu_pre_d0()) { map |= (sz.side1 - (25 + 3)) << (index *4); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz.rank == 4) { map |= (sz.side1 - (25 + 3)) << ( (index + 2) * 4); } @@ -782,7 +778,7 @@ } else { map |= cs_map_aa[(sz.rows - 12) * 5 + (sz.col - 8) ] << (index*4); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz.rank == 4) { map |= cs_map_aa[(sz.rows - 12) * 5 + (sz.col - 8) ] << ( (index + 2) * 4); } @@ -1526,7 +1522,7 @@ } #if 0 //down speed for full load 4 rank support -#if QRANK_DIMM_SUPPORT +#if CONFIG_QRANK_DIMM_SUPPORT if (dimm_mask == (3|(3<<DIMM_SOCKETS)) ) { int ranks = 4; for (i = 0; (i < 4) && (ctrl->channel0[i]); i++) { @@ -1793,7 +1789,7 @@ { uint32_t dcl; int value; -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT int rank; #endif int dimm; @@ -1802,7 +1798,7 @@ return -1; } -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT rank = spd_read_byte(ctrl->channel0[i], 5); /* number of physical banks */ if (rank < 0) { return -1; @@ -1810,7 +1806,7 @@ #endif dimm = 1<<(DCL_x4DIMM_SHIFT+i); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (rank==4) { dimm |= 1<<(DCL_x4DIMM_SHIFT+i+2); } Modified: trunk/src/northbridge/amd/amdk8/raminit_f.c ============================================================================== --- trunk/src/northbridge/amd/amdk8/raminit_f.c Fri Nov 5 17:17:46 2010 (r6027) +++ trunk/src/northbridge/amd/amdk8/raminit_f.c Fri Nov 5 23:59:49 2010 (r6028) @@ -32,10 +32,6 @@ #include "option_table.h" #endif -#ifndef QRANK_DIMM_SUPPORT -#define QRANK_DIMM_SUPPORT 0 -#endif - #if CONFIG_DEBUG_RAM_SETUP #define printk_raminit(fmt, arg...) printk(BIOS_DEBUG, fmt, arg) #else @@ -870,7 +866,7 @@ /* Set the appropriate DIMM base address register */ pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 0) << 2), base0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 1) << 2), base1); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz->rank == 4) { pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 4) << 2), base0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 5) << 2), base1); @@ -898,7 +894,7 @@ } else { dword = pci_read_config32(ctrl->f2, DRAM_TIMING_LOW); //Channel A dword &= ~(ClkDis0 >> index); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz->rank == 4) { dword &= ~(ClkDis0 >> (index+2)); } @@ -908,7 +904,7 @@ if (meminfo->is_Width128) { // ChannelA+B dword = pci_read_config32(ctrl->f2, DRAM_CTRL_MISC); dword &= ~(ClkDis0 >> index); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz->rank == 4) { dword &= ~(ClkDis0 >> (index+2)); } @@ -961,7 +957,7 @@ } map = pci_read_config32(ctrl->f2, DRAM_BANK_ADDR_MAP); map &= ~(0xf << (index * 4)); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz->rank == 4) { map &= ~(0xf << ( (index + 2) * 4)); } @@ -972,7 +968,7 @@ unsigned temp_map; temp_map = cs_map_aaa[(sz->bank-2)*3*4 + (sz->rows - 13)*3 + (sz->col - 9) ]; map |= temp_map << (index*4); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (sz->rank == 4) { map |= temp_map << ( (index + 2) * 4); } @@ -1312,7 +1308,7 @@ } else { pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 0) << 2), 0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 1) << 2), 0); -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT if (meminfo->sz[index].rank == 4) { pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 4) << 2), 0); pci_write_config32(ctrl->f2, DRAM_CSBASE + (((index << 1) + 5) << 2), 0); @@ -2194,7 +2190,7 @@ static void set_4RankRDimm(const struct mem_controller *ctrl, const struct mem_param *param, struct mem_info *meminfo) { -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT int value; int i; long dimm_mask = meminfo->dimm_mask; @@ -2234,7 +2230,7 @@ uint32_t mask_single_rank; uint32_t mask_page_1k; int value; -#if QRANK_DIMM_SUPPORT == 1 +#if CONFIG_QRANK_DIMM_SUPPORT int rank; #endif @@ -2267,20 +2263,20 @@ value = spd_read_byte(spd_device, SPD_PRI_WIDTH); - #if QRANK_DIMM_SUPPORT == 1 + #if CONFIG_QRANK_DIMM_SUPPORT rank = meminfo->sz[i].rank; #endif if (value==4) { mask_x4 |= (1<<i); - #if QRANK_DIMM_SUPPORT == 1 + #if CONFIG_QRANK_DIMM_SUPPORT if (rank==4) { mask_x4 |= 1<<(i+2); } #endif } else if (value==16) { mask_x16 |= (1<<i); - #if QRANK_DIMM_SUPPORT == 1 + #if CONFIG_QRANK_DIMM_SUPPORT if (rank==4) { mask_x16 |= 1<<(i+2); }

1 0

[PATCH]Move QRANK_DIMM_SUPPORT to Kconfig
by Patrick Georgi 05 Nov '10

05 Nov '10

Hi, see patch. It might be possible to find a better place to this variable (are "qrank dimms" really a per-board thing?), but for now this should provide absolutely equivalent to the romstage.c defines. Move QRANK_DIMM_SUPPORT to Kconfig, removing it from romstage.c Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>

5 7

build questions
by Flemming Richter Mikkelsen 05 Nov '10

05 Nov '10

Hello. Today I tried to build coreboot for the very first time. I discovered that the debug configs caused some harmless warnings of the type "referenced but not used". Also, I tried scan-build. I never tried this before, and therefore I don't know it limitations. A make generated a list of 60 bugs. Not all of them are real bugs though. It looks like it found that we use math operation on a uninitialized value: File: northbridge/amd/amdfam10/../amdmct/mct/mctndi_d.c Location: line 98, column 6 Description: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage DctSelBaseOffset -= Base; Anyway, the computed value is never used. Would it make sense to remove unused variables? If so, I can try to create a few patches. I think scan-build is almost useless when it generate a list of 60 "bugs".

2 1

[commit] r6027 - in trunk/src/mainboard: amd/dbm690t amd/mahogany amd/mahogany_fam10 amd/tilapia_fam10 asrock/939a785gmh asus/m4a785-m getac/p470 gigabyte/ga_2761gxdk gigabyte/ma785gmt gigabyte/ma7...
by repository service 05 Nov '10

05 Nov '10

Author: oxygene Date: Fri Nov 5 17:17:46 2010 New Revision: 6027 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6027 Log: Various PIRQ/MPTABLE/ACPI Kconfig fixes. - Use HAVE_ACPI_TABLES, HAVE_MP_TABLE, and HAVE_PIRQ_TABLE (instead of GENERATE_*) in the board's Kconfig file, as all other boards do. - Add missing HAVE_ACPI_TABLES/HAVE_MP_TABLE/HAVE_PIRQ_TABLE to boards which have the respective files. The only exception: EPIA-M700 doesn't select ACPI, as it doesn't have dsdt.asl. Added a comment that the user is supposed to run the 'get_dsdt' script and edit Kconfig afterwards. - Fix minor warning/error in src/mainboard/msi/ms9652_fam10/acpi_tables.c, now that the file is actually used. - msi/ms9652_fam10: use #include instead of Include() as we usually do now. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Patrick Georgi <patrick(a)georgi-clan.de> Modified: trunk/src/mainboard/amd/dbm690t/Kconfig trunk/src/mainboard/amd/mahogany/Kconfig trunk/src/mainboard/amd/mahogany_fam10/Kconfig trunk/src/mainboard/amd/tilapia_fam10/Kconfig trunk/src/mainboard/asrock/939a785gmh/Kconfig trunk/src/mainboard/asus/m4a785-m/Kconfig trunk/src/mainboard/getac/p470/Kconfig trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig trunk/src/mainboard/gigabyte/ma785gmt/Kconfig trunk/src/mainboard/gigabyte/ma78gm/Kconfig trunk/src/mainboard/ibase/mb899/Kconfig trunk/src/mainboard/iei/juki-511p/Kconfig trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig trunk/src/mainboard/jetway/pa78vm5/Kconfig trunk/src/mainboard/kontron/986lcd-m/Kconfig trunk/src/mainboard/msi/ms9652_fam10/Kconfig trunk/src/mainboard/msi/ms9652_fam10/acpi_tables.c trunk/src/mainboard/msi/ms9652_fam10/dsdt.asl trunk/src/mainboard/via/epia-m700/Kconfig Modified: trunk/src/mainboard/amd/dbm690t/Kconfig ============================================================================== --- trunk/src/mainboard/amd/dbm690t/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/amd/dbm690t/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -10,9 +10,9 @@ select SOUTHBRIDGE_AMD_SB600 select SUPERIO_ITE_IT8712F select BOARD_HAS_FADT - select GENERATE_ACPI_TABLES - select GENERATE_MP_TABLE - select GENERATE_PIRQ_TABLE + select HAVE_ACPI_TABLES + select HAVE_MP_TABLE + select HAVE_PIRQ_TABLE select HAVE_OPTION_TABLE select HAVE_MAINBOARD_RESOURCES select HAVE_BUS_CONFIG Modified: trunk/src/mainboard/amd/mahogany/Kconfig ============================================================================== --- trunk/src/mainboard/amd/mahogany/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/amd/mahogany/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -11,9 +11,9 @@ select SOUTHBRIDGE_AMD_SB700 select SUPERIO_ITE_IT8718F select BOARD_HAS_FADT - select GENERATE_ACPI_TABLES - select GENERATE_MP_TABLE - select GENERATE_PIRQ_TABLE + select HAVE_ACPI_TABLES + select HAVE_MP_TABLE + select HAVE_PIRQ_TABLE select HAVE_OPTION_TABLE select HAVE_MAINBOARD_RESOURCES select HAVE_BUS_CONFIG Modified: trunk/src/mainboard/amd/mahogany_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/amd/mahogany_fam10/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/amd/mahogany_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -13,8 +13,8 @@ select BOARD_HAS_FADT select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES select CACHE_AS_RAM select HAVE_HARD_RESET @@ -22,7 +22,7 @@ select LIFT_BSP_APIC_ID select SERIAL_CPU_INIT select AMDMCT - select GENERATE_ACPI_TABLES + select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO select ENABLE_APIC_EXT_ID Modified: trunk/src/mainboard/amd/tilapia_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/amd/tilapia_fam10/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/amd/tilapia_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -13,8 +13,8 @@ select BOARD_HAS_FADT select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES select CACHE_AS_RAM select HAVE_HARD_RESET @@ -22,7 +22,7 @@ select LIFT_BSP_APIC_ID select SERIAL_CPU_INIT select AMDMCT - select GENERATE_ACPI_TABLES + select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO select ENABLE_APIC_EXT_ID Modified: trunk/src/mainboard/asrock/939a785gmh/Kconfig ============================================================================== --- trunk/src/mainboard/asrock/939a785gmh/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/asrock/939a785gmh/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -11,9 +11,9 @@ select SOUTHBRIDGE_AMD_SB700 select SUPERIO_WINBOND_W83627DHG select BOARD_HAS_FADT - select GENERATE_ACPI_TABLES - select GENERATE_MP_TABLE - select GENERATE_PIRQ_TABLE + select HAVE_ACPI_TABLES + select HAVE_MP_TABLE + select HAVE_PIRQ_TABLE select HAVE_MAINBOARD_RESOURCES select HAVE_OPTION_TABLE select HAVE_BUS_CONFIG Modified: trunk/src/mainboard/asus/m4a785-m/Kconfig ============================================================================== --- trunk/src/mainboard/asus/m4a785-m/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/asus/m4a785-m/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -13,15 +13,15 @@ select BOARD_HAS_FADT select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID select SERIAL_CPU_INIT select AMDMCT - select GENERATE_ACPI_TABLES + select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO select ENABLE_APIC_EXT_ID Modified: trunk/src/mainboard/getac/p470/Kconfig ============================================================================== --- trunk/src/mainboard/getac/p470/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/getac/p470/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -29,9 +29,9 @@ select SUPERIO_SMSC_FDC37N972 select SUPERIO_SMSC_SIO10N268 select BOARD_HAS_FADT - select GENERATE_ACPI_TABLES - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_ACPI_TABLES + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select HAVE_ACPI_SLIC Modified: trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig ============================================================================== --- trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/gigabyte/ga_2761gxdk/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -12,6 +12,7 @@ select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID Modified: trunk/src/mainboard/gigabyte/ma785gmt/Kconfig ============================================================================== --- trunk/src/mainboard/gigabyte/ma785gmt/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/gigabyte/ma785gmt/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -13,8 +13,8 @@ select BOARD_HAS_FADT select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES select CACHE_AS_RAM select HAVE_HARD_RESET @@ -22,7 +22,7 @@ select LIFT_BSP_APIC_ID select SERIAL_CPU_INIT select AMDMCT - select GENERATE_ACPI_TABLES + select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select ENABLE_APIC_EXT_ID select TINY_BOOTBLOCK Modified: trunk/src/mainboard/gigabyte/ma78gm/Kconfig ============================================================================== --- trunk/src/mainboard/gigabyte/ma78gm/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/gigabyte/ma78gm/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -13,8 +13,8 @@ select BOARD_HAS_FADT select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES select CACHE_AS_RAM select HAVE_HARD_RESET @@ -22,7 +22,7 @@ select LIFT_BSP_APIC_ID select SERIAL_CPU_INIT select AMDMCT - select GENERATE_ACPI_TABLES + select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select ENABLE_APIC_EXT_ID select TINY_BOOTBLOCK Modified: trunk/src/mainboard/ibase/mb899/Kconfig ============================================================================== --- trunk/src/mainboard/ibase/mb899/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/ibase/mb899/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -9,9 +9,9 @@ select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_WINBOND_W83627EHG select BOARD_HAS_FADT - select GENERATE_ACPI_TABLES - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_ACPI_TABLES + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select MMCONF_SUPPORT Modified: trunk/src/mainboard/iei/juki-511p/Kconfig ============================================================================== --- trunk/src/mainboard/iei/juki-511p/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/iei/juki-511p/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -27,6 +27,7 @@ select SUPERIO_WINBOND_W83977F select ROMCC select PIRQ_ROUTE + select HAVE_PIRQ_TABLE select HAVE_OPTION_TABLE select BOARD_ROMSIZE_KB_256 Modified: trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig ============================================================================== --- trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/iei/kino-780am2-fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -13,8 +13,8 @@ select BOARD_HAS_FADT select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES select CACHE_AS_RAM select HAVE_HARD_RESET @@ -22,7 +22,7 @@ select LIFT_BSP_APIC_ID select SERIAL_CPU_INIT select AMDMCT - select GENERATE_ACPI_TABLES + select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO select ENABLE_APIC_EXT_ID Modified: trunk/src/mainboard/jetway/pa78vm5/Kconfig ============================================================================== --- trunk/src/mainboard/jetway/pa78vm5/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/jetway/pa78vm5/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -13,8 +13,8 @@ select BOARD_HAS_FADT select HAVE_BUS_CONFIG select HAVE_OPTION_TABLE - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES select CACHE_AS_RAM select HAVE_HARD_RESET @@ -22,7 +22,7 @@ select LIFT_BSP_APIC_ID select SERIAL_CPU_INIT select AMDMCT - select GENERATE_ACPI_TABLES + select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select RAMINIT_SYSINFO select ENABLE_APIC_EXT_ID Modified: trunk/src/mainboard/kontron/986lcd-m/Kconfig ============================================================================== --- trunk/src/mainboard/kontron/986lcd-m/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/kontron/986lcd-m/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -9,9 +9,9 @@ select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_WINBOND_W83627THG select BOARD_HAS_FADT - select GENERATE_ACPI_TABLES - select GENERATE_PIRQ_TABLE - select GENERATE_MP_TABLE + select HAVE_ACPI_TABLES + select HAVE_PIRQ_TABLE + select HAVE_MP_TABLE select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select MMCONF_SUPPORT Modified: trunk/src/mainboard/msi/ms9652_fam10/Kconfig ============================================================================== --- trunk/src/mainboard/msi/ms9652_fam10/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/msi/ms9652_fam10/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -14,6 +14,7 @@ select HAVE_BUS_CONFIG select HAVE_PIRQ_TABLE select HAVE_MP_TABLE + select HAVE_ACPI_TABLES select CACHE_AS_RAM select HAVE_OPTION_TABLE select HAVE_HARD_RESET Modified: trunk/src/mainboard/msi/ms9652_fam10/acpi_tables.c ============================================================================== --- trunk/src/mainboard/msi/ms9652_fam10/acpi_tables.c Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/msi/ms9652_fam10/acpi_tables.c Fri Nov 5 17:17:46 2010 (r6027) @@ -151,7 +151,7 @@ current += dsdt->length; memcpy(dsdt, &AmlCode, dsdt->length); dsdt->checksum = 0; /* Don't trust iasl to get this right. */ - dsdt->checksum = acpi_checksum(dsdt, dsdt->length); + dsdt->checksum = acpi_checksum((u8 *)dsdt, dsdt->length); printk(BIOS_DEBUG, "ACPI: * DSDT @ %p Length %x\n", dsdt, dsdt->length); printk(BIOS_DEBUG, "ACPI: * FADT\n"); Modified: trunk/src/mainboard/msi/ms9652_fam10/dsdt.asl ============================================================================== --- trunk/src/mainboard/msi/ms9652_fam10/dsdt.asl Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/msi/ms9652_fam10/dsdt.asl Fri Nov 5 17:17:46 2010 (r6027) @@ -23,7 +23,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, "LXBIOS", "LXB-DSDT", 1) { - Include ("../../../../src/northbridge/amd/amdk8/amdk8_util.asl") + #include "../../../../src/northbridge/amd/amdk8/amdk8_util.asl" /* For now only define 2 power states: * - S0 which is fully on Modified: trunk/src/mainboard/via/epia-m700/Kconfig ============================================================================== --- trunk/src/mainboard/via/epia-m700/Kconfig Fri Nov 5 13:44:25 2010 (r6026) +++ trunk/src/mainboard/via/epia-m700/Kconfig Fri Nov 5 17:17:46 2010 (r6027) @@ -7,6 +7,10 @@ select NORTHBRIDGE_VIA_VX800 select SUPERIO_WINBOND_W83697HF select BOARD_HAS_FADT + select HAVE_PIRQ_TABLE + # Note: For ACPI, you need to use the 'get_dsdt' script and uncomment + # the "select HAVE_ACPI_TABLES" line below. + # select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO

1 0

[commit] r6026 - in trunk/src/superio/fintek: f71805f f71859 f71863fg f71889
by repository service 05 Nov '10

05 Nov '10

Author: uwe Date: Fri Nov 5 13:44:25 2010 New Revision: 6026 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6026 Log: Follow-up for r6025, do 0x87 twice in superio.c, too. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/src/superio/fintek/f71805f/superio.c trunk/src/superio/fintek/f71859/superio.c trunk/src/superio/fintek/f71863fg/superio.c trunk/src/superio/fintek/f71889/superio.c Modified: trunk/src/superio/fintek/f71805f/superio.c ============================================================================== --- trunk/src/superio/fintek/f71805f/superio.c Fri Nov 5 08:59:06 2010 (r6025) +++ trunk/src/superio/fintek/f71805f/superio.c Fri Nov 5 13:44:25 2010 (r6026) @@ -30,6 +30,7 @@ static void pnp_enter_conf_state(device_t dev) { outb(0x87, dev->path.pnp.port); + outb(0x87, dev->path.pnp.port); } static void pnp_exit_conf_state(device_t dev) Modified: trunk/src/superio/fintek/f71859/superio.c ============================================================================== --- trunk/src/superio/fintek/f71859/superio.c Fri Nov 5 08:59:06 2010 (r6025) +++ trunk/src/superio/fintek/f71859/superio.c Fri Nov 5 13:44:25 2010 (r6026) @@ -31,6 +31,7 @@ static void pnp_enter_conf_state(device_t dev) { outb(0x87, dev->path.pnp.port); + outb(0x87, dev->path.pnp.port); } static void pnp_exit_conf_state(device_t dev) Modified: trunk/src/superio/fintek/f71863fg/superio.c ============================================================================== --- trunk/src/superio/fintek/f71863fg/superio.c Fri Nov 5 08:59:06 2010 (r6025) +++ trunk/src/superio/fintek/f71863fg/superio.c Fri Nov 5 13:44:25 2010 (r6026) @@ -30,6 +30,7 @@ static void pnp_enter_conf_state(device_t dev) { outb(0x87, dev->path.pnp.port); + outb(0x87, dev->path.pnp.port); } static void pnp_exit_conf_state(device_t dev) Modified: trunk/src/superio/fintek/f71889/superio.c ============================================================================== --- trunk/src/superio/fintek/f71889/superio.c Fri Nov 5 08:59:06 2010 (r6025) +++ trunk/src/superio/fintek/f71889/superio.c Fri Nov 5 13:44:25 2010 (r6026) @@ -30,6 +30,7 @@ static void pnp_enter_conf_state(device_t dev) { outb(0x87, dev->path.pnp.port); + outb(0x87, dev->path.pnp.port); } static void pnp_exit_conf_state(device_t dev)

1 0

← Newer
1
...
21
22
23
24
25
26
27
28
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot November 2010