Hello.
Today I tried to build coreboot for the very first time. I discovered that the debug configs caused some harmless warnings of the type "referenced but not used".
Also, I tried scan-build. I never tried this before, and therefore I don't know it limitations. A make generated a list of 60 bugs. Not all of them are real bugs though.
It looks like it found that we use math operation on a uninitialized value:
File: northbridge/amd/amdfam10/../amdmct/mct/mctndi_d.c Location: line 98, column 6 Description: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage
DctSelBaseOffset -= Base;
Anyway, the computed value is never used.
Would it make sense to remove unused variables? If so, I can try to create a few patches. I think scan-build is almost useless when it generate a list of 60 "bugs".
On Sun, Oct 31, 2010 at 3:04 PM, Flemming Richter Mikkelsen quatrox@member.fsf.org wrote:
Hello.
Today I tried to build coreboot for the very first time. I discovered that the debug configs caused some harmless warnings of the type "referenced but not used".
Also, I tried scan-build. I never tried this before, and therefore I don't know it limitations. A make generated a list of 60 bugs. Not all of them are real bugs though.
It looks like it found that we use math operation on a uninitialized value:
File: northbridge/amd/amdfam10/../amdmct/mct/mctndi_d.c Location: line 98, column 6 Description: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage
DctSelBaseOffset -= Base;
Anyway, the computed value is never used.
Would it make sense to remove unused variables? If so, I can try to create a few patches. I think scan-build is almost useless when it generate a list of 60 "bugs".
Hi and welcome to coreboot!
We are always interested in getting more people submitting patches. Please send yours. We will do our best to review and commit them.
Regard, Marc
-
Flemming Richter Mikkelsen -
Marc Jones