coreboot February 2013

coreboot@coreboot.org

27 participants
790 discussions

New patch to review for coreboot: 7327da5 libpayload: Add a pointer for user data on the USB MSC data structure.
by Stefan Reinauer 26 Feb '13

26 Feb '13

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2513 -gerrit commit 7327da570507836df772695b5b64d30f075e0789 Author: Gabe Black <gabeblack(a)google.com> Date: Thu Nov 1 18:46:05 2012 -0700 libpayload: Add a pointer for user data on the USB MSC data structure. This is so the user of libpayload can attach data to the device which it can retrieve when the device is referred to later, for instance in usbdisk_remove. Otherwise, there's no direct connection from the usbdev_t structure to any bookkeeping in the host firmware. Change-Id: I36fe693b0dcd2098e359c26744e376e73bd3a723 Signed-off-by: Gabe Black <gabeblack(a)google.com> --- payloads/libpayload/include/usb/usbmsc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/payloads/libpayload/include/usb/usbmsc.h b/payloads/libpayload/include/usb/usbmsc.h index fafa6f5..5c3dadc 100644 --- a/payloads/libpayload/include/usb/usbmsc.h +++ b/payloads/libpayload/include/usb/usbmsc.h @@ -36,6 +36,7 @@ typedef struct { endpoint_t *bulk_in; endpoint_t *bulk_out; int usbdisk_created; + void *data; /* For use by consumers of libpayload. */ } usbmsc_inst_t; #define MSC_INST(dev) ((usbmsc_inst_t*)(dev)->data)

1 0

Patch set updated for coreboot: 000ab5c mainboard.c: Name enable_dev function uniformly `mainboard_enable`
by Paul Menzel 25 Feb '13

25 Feb '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2493 -gerrit commit 000ab5ce9821f473a5309d1c59d06944f5c5df87 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Feb 23 21:31:23 2013 +0100 mainboard.c: Name enable_dev function uniformly `mainboard_enable` To reduce the differences between these file name the enabling device function in the directory `src/mainboard` uniformly `mainboard_enable` [1]. Thanks to the awesome help of gnomon and BlastHardcheese in the IRC channel #sed on <irc.freenode.net>. gnomon came up with the following command to do the actual work. $ cd src/mainboard $ for f in */*/mainboard.c ; \ > do src="$(awk '/\.enable_dev = /{v=$NF; sub(/,$/,"",v); print v}' "$f")" ; \ > [[ -z $src ]] && continue ; \ > printf '%s\n' "g/${src}/s/${src}$[,(]$/mainboard_enable\1/p" w | ed -s "$f" ; \ > done `src/mainboard/digitallogic/msm586seg/mainboard.c` and `src/mainboard/technologic/ts5300/mainboard.c` had to be adapted manually as no comma was used separating the struct members. And with the following statement, gnomon is even more likable! My pleasure entirely. Good luck with coreboot; I'm a big fan of the project. [1] http://www.coreboot.org/pipermail/coreboot/2013-February/074548.html Change-Id: Ife9cd0c2d9cc1ed14afc6d40063450553f06a6c6 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/aaeon/pfm-540i_revb/mainboard.c | 4 ++-- src/mainboard/advansus/a785e-i/mainboard.c | 4 ++-- src/mainboard/amd/bimini_fam10/mainboard.c | 4 ++-- src/mainboard/amd/db800/mainboard.c | 4 ++-- src/mainboard/amd/dbm690t/mainboard.c | 4 ++-- src/mainboard/amd/dinar/mainboard.c | 4 ++-- src/mainboard/amd/inagua/mainboard.c | 4 ++-- src/mainboard/amd/mahogany/mainboard.c | 4 ++-- src/mainboard/amd/mahogany_fam10/mainboard.c | 4 ++-- src/mainboard/amd/norwich/mainboard.c | 4 ++-- src/mainboard/amd/parmer/mainboard.c | 4 ++-- src/mainboard/amd/persimmon/mainboard.c | 4 ++-- src/mainboard/amd/pistachio/mainboard.c | 4 ++-- src/mainboard/amd/rumba/mainboard.c | 4 ++-- src/mainboard/amd/south_station/mainboard.c | 4 ++-- src/mainboard/amd/thatcher/mainboard.c | 4 ++-- src/mainboard/amd/tilapia_fam10/mainboard.c | 4 ++-- src/mainboard/amd/torpedo/mainboard.c | 4 ++-- src/mainboard/amd/union_station/mainboard.c | 4 ++-- src/mainboard/artecgroup/dbe61/mainboard.c | 4 ++-- src/mainboard/asrock/939a785gmh/mainboard.c | 4 ++-- src/mainboard/asrock/e350m1/mainboard.c | 4 ++-- src/mainboard/asus/m4a78-em/mainboard.c | 4 ++-- src/mainboard/asus/m4a785-m/mainboard.c | 4 ++-- src/mainboard/asus/m5a88-v/mainboard.c | 4 ++-- src/mainboard/avalue/eax-785e/mainboard.c | 4 ++-- src/mainboard/bachmann/ot200/mainboard.c | 4 ++-- src/mainboard/digitallogic/msm586seg/mainboard.c | 4 ++-- src/mainboard/digitallogic/msm800sev/mainboard.c | 4 ++-- src/mainboard/emulation/qemu-armv7/mainboard.c | 4 ++-- src/mainboard/gigabyte/ma785gm/mainboard.c | 4 ++-- src/mainboard/gigabyte/ma785gmt/mainboard.c | 4 ++-- src/mainboard/gigabyte/ma78gm/mainboard.c | 4 ++-- src/mainboard/iei/kino-780am2-fam10/mainboard.c | 4 ++-- src/mainboard/iei/pm-lx2-800-r10/mainboard.c | 4 ++-- src/mainboard/jetway/pa78vm5/mainboard.c | 4 ++-- src/mainboard/kontron/kt690/mainboard.c | 4 ++-- src/mainboard/lippert/hurricane-lx/mainboard.c | 4 ++-- src/mainboard/lippert/literunner-lx/mainboard.c | 4 ++-- src/mainboard/lippert/roadrunner-lx/mainboard.c | 4 ++-- src/mainboard/lippert/spacerunner-lx/mainboard.c | 4 ++-- src/mainboard/pcengines/alix1c/mainboard.c | 4 ++-- src/mainboard/pcengines/alix2d/mainboard.c | 4 ++-- src/mainboard/siemens/sitemp_g1p1/mainboard.c | 4 ++-- src/mainboard/supermicro/h8qgi/mainboard.c | 4 ++-- src/mainboard/supermicro/h8scm/mainboard.c | 4 ++-- src/mainboard/supermicro/h8scm_fam10/mainboard.c | 4 ++-- src/mainboard/technexion/tim5690/mainboard.c | 4 ++-- src/mainboard/technexion/tim8690/mainboard.c | 4 ++-- src/mainboard/technologic/ts5300/mainboard.c | 4 ++-- src/mainboard/traverse/geos/mainboard.c | 4 ++-- src/mainboard/tyan/s8226/mainboard.c | 4 ++-- src/mainboard/winent/pl6064/mainboard.c | 4 ++-- src/mainboard/wyse/s50/mainboard.c | 4 ++-- 54 files changed, 108 insertions(+), 108 deletions(-) diff --git a/src/mainboard/aaeon/pfm-540i_revb/mainboard.c b/src/mainboard/aaeon/pfm-540i_revb/mainboard.c index ba64b9e..f6906a8 100644 --- a/src/mainboard/aaeon/pfm-540i_revb/mainboard.c +++ b/src/mainboard/aaeon/pfm-540i_revb/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "AAEON PFM-540I_REVB EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/advansus/a785e-i/mainboard.c b/src/mainboard/advansus/a785e-i/mainboard.c index e0f7c3b..0af8ba7 100644 --- a/src/mainboard/advansus/a785e-i/mainboard.c +++ b/src/mainboard/advansus/a785e-i/mainboard.c @@ -73,7 +73,7 @@ u8 is_dev3_present(void) * enable the dedicated function in A785E-I board. * This function called early than rs780_enable. *************************************************/ -static void a785e_i_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard A785E-I Enable. dev=0x%p\n", dev); @@ -82,5 +82,5 @@ static void a785e_i_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = a785e_i_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/bimini_fam10/mainboard.c b/src/mainboard/amd/bimini_fam10/mainboard.c index c9f0732..46b4e21 100644 --- a/src/mainboard/amd/bimini_fam10/mainboard.c +++ b/src/mainboard/amd/bimini_fam10/mainboard.c @@ -123,7 +123,7 @@ static void get_ide_dma66(void) * enable the dedicated function in bimini board. * This function called early than rs780_enable. *************************************************/ -static void bimini_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard BIMINI Enable. dev=0x%p\n", dev); @@ -133,5 +133,5 @@ static void bimini_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = bimini_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/db800/mainboard.c b/src/mainboard/amd/db800/mainboard.c index e34990b..0e19242 100644 --- a/src/mainboard/amd/db800/mainboard.c +++ b/src/mainboard/amd/db800/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "AMD DB800 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/dbm690t/mainboard.c b/src/mainboard/amd/dbm690t/mainboard.c index 39475ce..4355b6b 100644 --- a/src/mainboard/amd/dbm690t/mainboard.c +++ b/src/mainboard/amd/dbm690t/mainboard.c @@ -180,7 +180,7 @@ static void set_thermal_config(void) * enable the dedicated function in dbm690t board. * This function called early than rs690_enable. *************************************************/ -static void dbm690t_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard DBM690T Enable. dev=0x%p\n", dev); @@ -190,5 +190,5 @@ static void dbm690t_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = dbm690t_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/dinar/mainboard.c b/src/mainboard/amd/dinar/mainboard.c index ce9f2ca..df5519b 100644 --- a/src/mainboard/amd/dinar/mainboard.c +++ b/src/mainboard/amd/dinar/mainboard.c @@ -68,11 +68,11 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in dinar board. *************************************************/ -static void dinar_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard Dinar Enable. dev=0x%p\n", dev); } struct chip_operations mainboard_ops = { - .enable_dev = dinar_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/inagua/mainboard.c b/src/mainboard/amd/inagua/mainboard.c index 9a5e00c..2e2edc3 100644 --- a/src/mainboard/amd/inagua/mainboard.c +++ b/src/mainboard/amd/inagua/mainboard.c @@ -73,7 +73,7 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in INAGUA board. *************************************************/ -static void inagua_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -82,5 +82,5 @@ static void inagua_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = inagua_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/mahogany/mainboard.c b/src/mainboard/amd/mahogany/mainboard.c index c8405fc..3ad3602 100644 --- a/src/mainboard/amd/mahogany/mainboard.c +++ b/src/mainboard/amd/mahogany/mainboard.c @@ -97,7 +97,7 @@ u8 is_dev3_present(void) * enable the dedicated function in mahogany board. * This function called early than rs780_enable. *************************************************/ -static void mahogany_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MAHOGANY Enable. dev=0x%p\n", dev); @@ -106,5 +106,5 @@ static void mahogany_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = mahogany_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/mahogany_fam10/mainboard.c b/src/mainboard/amd/mahogany_fam10/mainboard.c index f944bd3..c9e7160 100644 --- a/src/mainboard/amd/mahogany_fam10/mainboard.c +++ b/src/mainboard/amd/mahogany_fam10/mainboard.c @@ -98,7 +98,7 @@ u8 is_dev3_present(void) * enable the dedicated function in mahogany board. * This function called early than rs780_enable. *************************************************/ -static void mahogany_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MAHOGANY Enable. dev=0x%p\n", dev); @@ -107,5 +107,5 @@ static void mahogany_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = mahogany_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/norwich/mainboard.c b/src/mainboard/amd/norwich/mainboard.c index 9002a57..e0e9001 100644 --- a/src/mainboard/amd/norwich/mainboard.c +++ b/src/mainboard/amd/norwich/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "Norwich EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/parmer/mainboard.c b/src/mainboard/amd/parmer/mainboard.c index 7c5dfc0..4b22214 100644 --- a/src/mainboard/amd/parmer/mainboard.c +++ b/src/mainboard/amd/parmer/mainboard.c @@ -32,7 +32,7 @@ /************************************************* * enable the dedicated function in parmer board. *************************************************/ -static void parmer_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); /* @@ -47,5 +47,5 @@ static void parmer_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = parmer_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/persimmon/mainboard.c b/src/mainboard/amd/persimmon/mainboard.c index 5edacd3..2f7cfd1 100644 --- a/src/mainboard/amd/persimmon/mainboard.c +++ b/src/mainboard/amd/persimmon/mainboard.c @@ -53,7 +53,7 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in persimmon board. *************************************************/ -static void persimmon_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -76,5 +76,5 @@ static void persimmon_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = persimmon_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/pistachio/mainboard.c b/src/mainboard/amd/pistachio/mainboard.c index f59e2bc..2b61ace 100644 --- a/src/mainboard/amd/pistachio/mainboard.c +++ b/src/mainboard/amd/pistachio/mainboard.c @@ -250,7 +250,7 @@ static void set_thermal_config(void) * enable the dedicated function in pistachio board. * This function called early than rs690_enable. *************************************************/ -static void pistachio_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard Pistachio Enable. dev=0x%p\n", dev); @@ -259,5 +259,5 @@ static void pistachio_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = pistachio_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/rumba/mainboard.c b/src/mainboard/amd/rumba/mainboard.c index 71d2d68..8c97109 100644 --- a/src/mainboard/amd/rumba/mainboard.c +++ b/src/mainboard/amd/rumba/mainboard.c @@ -27,12 +27,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "AMD RUMBA EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/south_station/mainboard.c b/src/mainboard/amd/south_station/mainboard.c index 5f31e03..b7d8bea 100644 --- a/src/mainboard/amd/south_station/mainboard.c +++ b/src/mainboard/amd/south_station/mainboard.c @@ -75,12 +75,12 @@ static void southstation_led_init(void) /************************************************* * enable the dedicated function in southstation board. *************************************************/ -static void southstation_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); southstation_led_init(); } struct chip_operations mainboard_ops = { - .enable_dev = southstation_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/thatcher/mainboard.c b/src/mainboard/amd/thatcher/mainboard.c index d1c389c..655ff31 100644 --- a/src/mainboard/amd/thatcher/mainboard.c +++ b/src/mainboard/amd/thatcher/mainboard.c @@ -32,7 +32,7 @@ /************************************************* * enable the dedicated function in thatcher board. *************************************************/ -static void thatcher_enable(device_t dev) +static void mainboard_enable(device_t dev) { msr_t msr; @@ -64,5 +64,5 @@ static void thatcher_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = thatcher_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/tilapia_fam10/mainboard.c b/src/mainboard/amd/tilapia_fam10/mainboard.c index 79fdbc2..f9598b9 100644 --- a/src/mainboard/amd/tilapia_fam10/mainboard.c +++ b/src/mainboard/amd/tilapia_fam10/mainboard.c @@ -273,7 +273,7 @@ static void set_thermal_config(void) * enable the dedicated function in tilapia board. * This function called early than rs780_enable. *************************************************/ -static void tilapia_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard TILAPIA Enable. dev=0x%p\n", dev); @@ -284,5 +284,5 @@ static void tilapia_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = tilapia_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/torpedo/mainboard.c b/src/mainboard/amd/torpedo/mainboard.c index d0f3f2b..b7a59a0 100644 --- a/src/mainboard/amd/torpedo/mainboard.c +++ b/src/mainboard/amd/torpedo/mainboard.c @@ -52,11 +52,11 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in torpedo board. *************************************************/ -static void torpedo_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable. dev=0x%p\n", dev); } struct chip_operations mainboard_ops = { - .enable_dev = torpedo_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/union_station/mainboard.c b/src/mainboard/amd/union_station/mainboard.c index 063f9b4..57dfe44 100644 --- a/src/mainboard/amd/union_station/mainboard.c +++ b/src/mainboard/amd/union_station/mainboard.c @@ -49,11 +49,11 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in unionstation board. *************************************************/ -static void unionstation_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = unionstation_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/artecgroup/dbe61/mainboard.c b/src/mainboard/artecgroup/dbe61/mainboard.c index 804b918..3ec3a7e 100644 --- a/src/mainboard/artecgroup/dbe61/mainboard.c +++ b/src/mainboard/artecgroup/dbe61/mainboard.c @@ -46,11 +46,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "ARTECGROUP DBE61 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asrock/939a785gmh/mainboard.c b/src/mainboard/asrock/939a785gmh/mainboard.c index d018696..8939957 100644 --- a/src/mainboard/asrock/939a785gmh/mainboard.c +++ b/src/mainboard/asrock/939a785gmh/mainboard.c @@ -95,7 +95,7 @@ u8 is_dev3_present(void) * enable the dedicated function in mahogany board. * This function called early than rs780_enable. *************************************************/ -static void mb_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard 939A785GMH/128M Enable. dev=0x%p\n", dev); @@ -104,7 +104,7 @@ static void mb_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = mb_enable, + .enable_dev = mainboard_enable, }; /* override the default SATA PHY setup */ diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c index a17778a..2bedff5 100644 --- a/src/mainboard/asrock/e350m1/mainboard.c +++ b/src/mainboard/asrock/e350m1/mainboard.c @@ -48,11 +48,11 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in e350m1 board. *************************************************/ -static void e350m1_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = e350m1_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asus/m4a78-em/mainboard.c b/src/mainboard/asus/m4a78-em/mainboard.c index 9b56277..096d6ba 100644 --- a/src/mainboard/asus/m4a78-em/mainboard.c +++ b/src/mainboard/asus/m4a78-em/mainboard.c @@ -118,7 +118,7 @@ u8 is_dev3_present(void) * enable the dedicated function in this board. * This function called early than rs780_enable. *************************************************/ -static void m4a78em_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard enable. dev=0x%p\n", dev); @@ -128,5 +128,5 @@ static void m4a78em_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = m4a78em_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asus/m4a785-m/mainboard.c b/src/mainboard/asus/m4a785-m/mainboard.c index a0b79fe..a36dce0 100644 --- a/src/mainboard/asus/m4a785-m/mainboard.c +++ b/src/mainboard/asus/m4a785-m/mainboard.c @@ -190,7 +190,7 @@ static void set_thermal_config(void) * enable the dedicated function in this board. * This function called early than rs780_enable. *************************************************/ -static void m4a785m_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard enable. dev=0x%p\n", dev); @@ -200,5 +200,5 @@ static void m4a785m_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = m4a785m_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asus/m5a88-v/mainboard.c b/src/mainboard/asus/m5a88-v/mainboard.c index d1e530f..8a5e8a1 100644 --- a/src/mainboard/asus/m5a88-v/mainboard.c +++ b/src/mainboard/asus/m5a88-v/mainboard.c @@ -73,7 +73,7 @@ u8 is_dev3_present(void) * enable the dedicated function in M5A88-V board. * This function called early than rs780_enable. *************************************************/ -static void m5a88pm_v_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard ASUS M5A88-V Enable. dev=0x%p\n", dev); @@ -83,5 +83,5 @@ static void m5a88pm_v_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = m5a88pm_v_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/avalue/eax-785e/mainboard.c b/src/mainboard/avalue/eax-785e/mainboard.c index 631891f..f812137 100644 --- a/src/mainboard/avalue/eax-785e/mainboard.c +++ b/src/mainboard/avalue/eax-785e/mainboard.c @@ -73,7 +73,7 @@ u8 is_dev3_present(void) * enable the dedicated function in EAX-785E board. * This function called early than rs780_enable. *************************************************/ -static void eax_785e(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -82,5 +82,5 @@ static void eax_785e(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = eax_785e, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/bachmann/ot200/mainboard.c b/src/mainboard/bachmann/ot200/mainboard.c index 2b1fe83..f8aefec 100644 --- a/src/mainboard/bachmann/ot200/mainboard.c +++ b/src/mainboard/bachmann/ot200/mainboard.c @@ -65,11 +65,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "hw revision: %u\n", hw_rev); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/digitallogic/msm586seg/mainboard.c b/src/mainboard/digitallogic/msm586seg/mainboard.c index f2902c8..6cb5f07 100644 --- a/src/mainboard/digitallogic/msm586seg/mainboard.c +++ b/src/mainboard/digitallogic/msm586seg/mainboard.c @@ -31,7 +31,7 @@ static void irqdump(void) /* TODO: finish up mmcr struct in sc520.h, and; - set ADDDECTL (now done in raminit.c in cpu/amd/sc520 */ -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { //volatile struct mmcrpic *pic = MMCRPIC; volatile struct mmcr *mmcr = MMCRDEFAULT; @@ -129,6 +129,6 @@ static void enable_dev(struct device *dev) } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/digitallogic/msm800sev/mainboard.c b/src/mainboard/digitallogic/msm800sev/mainboard.c index 2b2b9fe..b8e3ba1 100644 --- a/src/mainboard/digitallogic/msm800sev/mainboard.c +++ b/src/mainboard/digitallogic/msm800sev/mainboard.c @@ -26,12 +26,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "MSM800SEV EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/emulation/qemu-armv7/mainboard.c b/src/mainboard/emulation/qemu-armv7/mainboard.c index cbc3197..603d00e 100644 --- a/src/mainboard/emulation/qemu-armv7/mainboard.c +++ b/src/mainboard/emulation/qemu-armv7/mainboard.c @@ -16,12 +16,12 @@ #include <console/console.h> #include <device/device.h> -static void enable_dev(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Enable qemu/armv7 device...\n"); } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/gigabyte/ma785gm/mainboard.c b/src/mainboard/gigabyte/ma785gm/mainboard.c index 3ce0db6..5b3a963 100644 --- a/src/mainboard/gigabyte/ma785gm/mainboard.c +++ b/src/mainboard/gigabyte/ma785gm/mainboard.c @@ -134,7 +134,7 @@ static void set_gpio40_gfx(void) * enable the dedicated function in ma785gm board. * This function called early than rs780_enable. *************************************************/ -static void ma785gm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MA785GM-US2H Enable. dev=0x%p\n", dev); @@ -144,5 +144,5 @@ static void ma785gm_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = ma785gm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/gigabyte/ma785gmt/mainboard.c b/src/mainboard/gigabyte/ma785gmt/mainboard.c index 8961bc8..7ed897f 100644 --- a/src/mainboard/gigabyte/ma785gmt/mainboard.c +++ b/src/mainboard/gigabyte/ma785gmt/mainboard.c @@ -244,7 +244,7 @@ static void set_thermal_config(void) * enable the dedicated function in ma785gmt board. * This function called early than rs780_enable. *************************************************/ -static void ma785gmt_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MA785GMT-UD2H Enable. dev=0x%p\n", dev); @@ -255,5 +255,5 @@ static void ma785gmt_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = ma785gmt_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/gigabyte/ma78gm/mainboard.c b/src/mainboard/gigabyte/ma78gm/mainboard.c index 9a8e5dc..5ac2420 100644 --- a/src/mainboard/gigabyte/ma78gm/mainboard.c +++ b/src/mainboard/gigabyte/ma78gm/mainboard.c @@ -71,7 +71,7 @@ u8 is_dev3_present(void) * enable the dedicated function in board. * This function called early than rs780_enable. *************************************************/ -static void ma78gm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MA78GM-US2H Enable. dev=0x%p\n", dev); @@ -80,5 +80,5 @@ static void ma78gm_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = ma78gm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/iei/kino-780am2-fam10/mainboard.c b/src/mainboard/iei/kino-780am2-fam10/mainboard.c index a9458fd..27b0fe4 100644 --- a/src/mainboard/iei/kino-780am2-fam10/mainboard.c +++ b/src/mainboard/iei/kino-780am2-fam10/mainboard.c @@ -53,7 +53,7 @@ u8 is_dev3_present(void) * enable the dedicated function in kino board. * This function called early than rs780_enable. *************************************************/ -static void kino_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard Kino Enable. dev=0x%p\n", dev); @@ -62,5 +62,5 @@ static void kino_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = kino_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/iei/pm-lx2-800-r10/mainboard.c b/src/mainboard/iei/pm-lx2-800-r10/mainboard.c index 9ba687f..4af206b 100644 --- a/src/mainboard/iei/pm-lx2-800-r10/mainboard.c +++ b/src/mainboard/iei/pm-lx2-800-r10/mainboard.c @@ -41,12 +41,12 @@ static void init(struct device *dev) outb(inb(SCH3114_RTR_HWM_DAT) | 0x01, SCH3114_RTR_HWM_DAT); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { CHIP_NAME("IEI PM-LX2-800-R10 Mainboard") - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/jetway/pa78vm5/mainboard.c b/src/mainboard/jetway/pa78vm5/mainboard.c index 3cf1b0d..84f049a 100644 --- a/src/mainboard/jetway/pa78vm5/mainboard.c +++ b/src/mainboard/jetway/pa78vm5/mainboard.c @@ -100,7 +100,7 @@ u8 is_dev3_present(void) * enable the dedicated function in this board. * This function called early than rs780_enable. *************************************************/ -static void pa78vm5_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard PA78VM5 Enable. dev=0x%p\n", dev); @@ -109,5 +109,5 @@ static void pa78vm5_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = pa78vm5_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/kontron/kt690/mainboard.c b/src/mainboard/kontron/kt690/mainboard.c index 189b65c..bc5beee 100644 --- a/src/mainboard/kontron/kt690/mainboard.c +++ b/src/mainboard/kontron/kt690/mainboard.c @@ -180,7 +180,7 @@ static void set_thermal_config(void) * enable the dedicated function in dbm690t board. * This function called early than rs690_enable. *************************************************/ -static void kt690_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard KT690 Enable. dev=0x%p\n", dev); @@ -190,5 +190,5 @@ static void kt690_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = kt690_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/hurricane-lx/mainboard.c b/src/mainboard/lippert/hurricane-lx/mainboard.c index f13e48b..5b9100b 100644 --- a/src/mainboard/lippert/hurricane-lx/mainboard.c +++ b/src/mainboard/lippert/hurricane-lx/mainboard.c @@ -77,11 +77,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT Hurricane-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/literunner-lx/mainboard.c b/src/mainboard/lippert/literunner-lx/mainboard.c index c1b8fc2..c29098f 100644 --- a/src/mainboard/lippert/literunner-lx/mainboard.c +++ b/src/mainboard/lippert/literunner-lx/mainboard.c @@ -81,11 +81,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT LiteRunner-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/roadrunner-lx/mainboard.c b/src/mainboard/lippert/roadrunner-lx/mainboard.c index 22bcf43..93a7970 100644 --- a/src/mainboard/lippert/roadrunner-lx/mainboard.c +++ b/src/mainboard/lippert/roadrunner-lx/mainboard.c @@ -71,11 +71,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT RoadRunner-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/spacerunner-lx/mainboard.c b/src/mainboard/lippert/spacerunner-lx/mainboard.c index e2e6093..6da1485 100644 --- a/src/mainboard/lippert/spacerunner-lx/mainboard.c +++ b/src/mainboard/lippert/spacerunner-lx/mainboard.c @@ -76,11 +76,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT SpaceRunner-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/pcengines/alix1c/mainboard.c b/src/mainboard/pcengines/alix1c/mainboard.c index 7dda79a..95335a7 100644 --- a/src/mainboard/pcengines/alix1c/mainboard.c +++ b/src/mainboard/pcengines/alix1c/mainboard.c @@ -26,12 +26,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "ALIX1.C EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/pcengines/alix2d/mainboard.c b/src/mainboard/pcengines/alix2d/mainboard.c index c60b134..1188a55 100644 --- a/src/mainboard/pcengines/alix2d/mainboard.c +++ b/src/mainboard/pcengines/alix2d/mainboard.c @@ -26,12 +26,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "ALIX.2D EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/siemens/sitemp_g1p1/mainboard.c b/src/mainboard/siemens/sitemp_g1p1/mainboard.c index a73fbd6..466b4a9 100644 --- a/src/mainboard/siemens/sitemp_g1p1/mainboard.c +++ b/src/mainboard/siemens/sitemp_g1p1/mainboard.c @@ -832,7 +832,7 @@ static void init(device_t dev) * enable the dedicated function in sina board. * This function called early than rs690_enable. *************************************************/ -static void enable_dev(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "%s %s[%x/%x] %s\n", @@ -849,5 +849,5 @@ static void enable_dev(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/supermicro/h8qgi/mainboard.c b/src/mainboard/supermicro/h8qgi/mainboard.c index 30695ff..aa855c8 100644 --- a/src/mainboard/supermicro/h8qgi/mainboard.c +++ b/src/mainboard/supermicro/h8qgi/mainboard.c @@ -65,11 +65,11 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in h8qgi board. *************************************************/ -static void h8qgi_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = h8qgi_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/supermicro/h8scm/mainboard.c b/src/mainboard/supermicro/h8scm/mainboard.c index 6c655f5..01edfe0 100644 --- a/src/mainboard/supermicro/h8scm/mainboard.c +++ b/src/mainboard/supermicro/h8scm/mainboard.c @@ -67,7 +67,7 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in h8scm board. *************************************************/ -static void h8scm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } @@ -80,5 +80,5 @@ int add_mainboard_resources(struct lb_memory *mem) #endif struct chip_operations mainboard_ops = { - .enable_dev = h8scm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/supermicro/h8scm_fam10/mainboard.c b/src/mainboard/supermicro/h8scm_fam10/mainboard.c index 5faca50..83b1957 100644 --- a/src/mainboard/supermicro/h8scm_fam10/mainboard.c +++ b/src/mainboard/supermicro/h8scm_fam10/mainboard.c @@ -69,7 +69,7 @@ void set_pcie_dereset(void) * enable the dedicated function in h8scm board. * This function called early than sr5650_enable. *************************************************/ -static void h8scm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard H8SCM Enable. dev=0x%p\n", dev); @@ -92,5 +92,5 @@ static void h8scm_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = h8scm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/technexion/tim5690/mainboard.c b/src/mainboard/technexion/tim5690/mainboard.c index 7974ce9..5be58cd 100644 --- a/src/mainboard/technexion/tim5690/mainboard.c +++ b/src/mainboard/technexion/tim5690/mainboard.c @@ -222,7 +222,7 @@ static void lcd_panel_id(rs690_vbios_regs *vbios_regs, u8 num_id) * enable the dedicated function in tim5690 board. * This function called early than rs690_enable. *************************************************/ -static void tim5690_enable(device_t dev) +static void mainboard_enable(device_t dev) { u16 gpio_base = IT8712F_SIMPLE_IO_BASE; #if CONFIG_VGA_ROM_RUN @@ -257,5 +257,5 @@ void mainboard_post(u8 value) } struct chip_operations mainboard_ops = { - .enable_dev = tim5690_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/technexion/tim8690/mainboard.c b/src/mainboard/technexion/tim8690/mainboard.c index 377cbd7..69788e9 100644 --- a/src/mainboard/technexion/tim8690/mainboard.c +++ b/src/mainboard/technexion/tim8690/mainboard.c @@ -140,7 +140,7 @@ static void set_thermal_config(void) * enable the dedicated function in tim8690 board. * This function called early than rs690_enable. *************************************************/ -static void tim8690_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard tim8690 Enable. dev=0x%p\n", dev); @@ -149,5 +149,5 @@ static void tim8690_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = tim8690_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/technologic/ts5300/mainboard.c b/src/mainboard/technologic/ts5300/mainboard.c index 1b7d023..7a0e2f3 100644 --- a/src/mainboard/technologic/ts5300/mainboard.c +++ b/src/mainboard/technologic/ts5300/mainboard.c @@ -35,7 +35,7 @@ static void irqdump(void) /* TODO: finish up mmcr struct in sc520.h, and; - set ADDDECTL (now done in raminit.c in cpu/amd/sc520 */ -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { volatile struct mmcr *mmcr = MMCRDEFAULT; @@ -143,6 +143,6 @@ static void enable_dev(struct device *dev) } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/traverse/geos/mainboard.c b/src/mainboard/traverse/geos/mainboard.c index 7bcc396..6980cda 100644 --- a/src/mainboard/traverse/geos/mainboard.c +++ b/src/mainboard/traverse/geos/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "Geos EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/tyan/s8226/mainboard.c b/src/mainboard/tyan/s8226/mainboard.c index b0d6b48..d9cacdc 100644 --- a/src/mainboard/tyan/s8226/mainboard.c +++ b/src/mainboard/tyan/s8226/mainboard.c @@ -67,11 +67,11 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in s8226 board. *************************************************/ -static void s8226_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = s8226_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/winent/pl6064/mainboard.c b/src/mainboard/winent/pl6064/mainboard.c index 5fd83ed..1ddc110 100644 --- a/src/mainboard/winent/pl6064/mainboard.c +++ b/src/mainboard/winent/pl6064/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "Win Enterprises PL-6064/65 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/wyse/s50/mainboard.c b/src/mainboard/wyse/s50/mainboard.c index 644a64e..ee92745 100644 --- a/src/mainboard/wyse/s50/mainboard.c +++ b/src/mainboard/wyse/s50/mainboard.c @@ -28,12 +28,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "S50 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, };

2 1

Patch merged into coreboot/master: a96d24d AMD Southbridge: Add RTC init to lpc_init
by gerrit＠coreboot.org 25 Feb '13

25 Feb '13

the following patch was just integrated into master: commit a96d24d672abfd2ce91caa2d762fdce3d67da600 Author: Mike Loptien <mike.loptien(a)se-eng.com> Date: Mon Feb 25 10:41:28 2013 -0700 AMD Southbridge: Add RTC init to lpc_init Adding RTC init code to the Southbridge initialization code in 'lpc_init'. This initializes the RTC so that the Date Alarm register is set to a valid value (0x00) at startup. By setting the Date Alarm register to 0x00, it does not get evaluated along with the seconds, minutes, and hours when running 'fwts s3'. Information about fwts (Firmware Test Suite) can be found here: https://wiki.ubuntu.com/Kernel/Reference/fwts This is the same edit made to the CIMX SB800 titled 'AMD/Persimmon: Add RTC init to CIMX SB800' with commit ID: c4d3d which can be viewed here: http://review.coreboot.org/#/c/2488/ Change-Id: Iddb7a3cbabe736b511cde03d7dc0a4a0b1c7fd90 Signed-off-by: Mike Loptien <mike.loptien(a)se-eng.com> Reviewed-on: http://review.coreboot.org/2510 Reviewed-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) Reviewed-by: Dave Frodin <dave.frodin(a)se-eng.com> Build-Tested: build bot (Jenkins) at Mon Feb 25 19:08:10 2013, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Mon Feb 25 19:05:24 2013, giving +2 Reviewed-By: Martin Roth <martin.roth(a)se-eng.com> at Mon Feb 25 19:02:14 2013, giving +1 Reviewed-By: Dave Frodin <dave.frodin(a)se-eng.com> at Mon Feb 25 19:28:43 2013, giving +2 See http://review.coreboot.org/2510 for details. -gerrit

1 0

Patch merged into coreboot/master: 7675d8a Supermicro H8SCM & H8QGI: Fix printk warnings
by gerrit＠coreboot.org 25 Feb '13

25 Feb '13

the following patch was just integrated into master: commit 7675d8a481c6cbeba418f00f2eb733d904171a41 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Feb 24 15:09:11 2013 -0700 Supermicro H8SCM & H8QGI: Fix printk warnings Changes: - Fix printk warnings for these two platforms by getting rid of the l length specifier and casting to unsigned int. This gets rid of a bunch of warnings like this one: agesawrapper.c:279, GNU Compiler 4 (gcc), Priority: Normal format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'UINT32' [-Wformat] Notes: - This is the same change that was done for Tyan s8226 in change: ddff32eb - http://review.coreboot.org/#/c/2451/ Tyan S8226: Fix printk warnings - I have not tested this change on either of these platforms, I have just compiled it. Change-Id: I46b4c13fde7473cd2a084c7c7cb5c893f1731b02 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/2502 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Build-Tested: build bot (Jenkins) at Sun Feb 24 23:25:56 2013, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Mon Feb 25 19:02:17 2013, giving +2 See http://review.coreboot.org/2502 for details. -gerrit

1 0

Patch merged into coreboot/master: 4f5a433 AMD Southstation: Fix final warning
by gerrit＠coreboot.org 25 Feb '13

25 Feb '13

the following patch was just integrated into master: commit 4f5a433a987faeed2cf21fbfca5d2604ef2d7edb Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Feb 24 14:12:32 2013 -0700 AMD Southstation: Fix final warning Changes: - Add #include of delay.h in mainboard.c to pick up declaration of mdelay function. Notes: - This fixes this warning: mainboard.c:69, GNU Compiler 4 (gcc), Priority: Normal implicit declaration of function 'mdelay' [-Wimplicit-function-declaration] Change-Id: I72f333cd87215a7fc1e62d1d7ee4b2395444b03e Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/2501 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Build-Tested: build bot (Jenkins) at Sun Feb 24 22:31:34 2013, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Mon Feb 25 19:00:52 2013, giving +2 See http://review.coreboot.org/2501 for details. -gerrit

1 0

Patch merged into coreboot/master: 4fc6004 AMD Fam14 boards: Set P_BLK length to 6 for all processors
by gerrit＠coreboot.org 25 Feb '13

25 Feb '13

the following patch was just integrated into master: commit 4fc600442b578e3e79acb221040638ab52f600ed Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Mon Jan 21 18:43:12 2013 +0100 AMD Fam14 boards: Set P_BLK length to 6 for all processors Currently on for example on AMD Persimmon and ASRock E350M1 Linux complains, that the PBLK length is invalid [1]. ACPI: Invalid PBLK length [0] Consequently, frequency scaling might not work correctly, though for these two boards it seems to work according to PowerTOP. Indeed, according to the ACPI specification [2], setting PBlockLength to 0 is only allowed if there is no PBlockAddress. Otherwise it has to be set to 6. 18.5.93 Processor (Declare Processor) […] PBlockAddress provides the system I/O address for the processors register block. Each processor can supply a different such address. PBlockLength is the length of the processor register block, in bytes and is either 0 (for no P_BLK) or 6. With one exception, all processors are required to have the same PBlockLength. The exception is that the boot processor can have a non-zero PBlockLength when all other processors have a zero PBlockLength. It is valid for every processor to have a PBlockLength of 0. And that is exactly what Linux is checking in `drivers/acpi/processor_driver.c` [3]. static int acpi_processor_get_info(struct acpi_device *device) { […] /* * On some boxes several processors use the same processor bus id. * But they are located in different scope. For example: * \_SB.SCK0.CPU0 * \_SB.SCK1.CPU0 * Rename the processor device bus id. And the new bus id will be * generated as the following format: * CPU+CPU ID. */ sprintf(acpi_device_bid(device), "CPU%X", pr->id); ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Processor [%d:%d]\n", pr->id, pr->acpi_id)); if (!object.processor.pblk_address) ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No PBLK (NULL address)\n")); else if (object.processor.pblk_length != 6) printk(KERN_ERR PREFIX "Invalid PBLK length [%d]\n", object.processor.pblk_length); else { pr->throttling.address = object.processor.pblk_address; pr->throttling.duty_offset = acpi_gbl_FADT.duty_offset; pr->throttling.duty_width = acpi_gbl_FADT.duty_width; pr->pblk = object.processor.pblk_address; /* * We don't care about error returns - we just try to mark * these reserved so that nobody else is confused into thinking * that this region might be unused.. * * (In particular, allocating the IO range for Cardbus) */ request_region(pr->throttling.address, 6, "ACPI CPU throttle"); } […] } This issue has proliferated to all AMD based boards so fix it for all of them by setting P_BLK length to 6. The DSDT of for example AMD Parmer and AMD Thatcher also set it to 6 everywhere so this solution is taken instead of setting the P_BLK system I/O base to 0 for all but the first processor which is how it is done for earlier AMD based boards. As note having to set this manually should not be needed and this should be autogenerated as done for most of the Intel boards and the AMD K8 based boards (`src/cpu/amd/model_fxx/powernow_acpi.c`). [1] http://www.coreboot.org/pipermail/coreboot/2013-January/073636.html [2] http://acpi.info/DOWNLOADS/ACPIspec40a.pdf [3] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drive… Tested-by: Paul Menzel <paulepanter(a)users.sourceforge.net> • ASRock E350M1: Tested-by: Paul Menzel <paulepanter(a)users.sourceforge.net> • AMD Persimmon: Tested-by: Martin Roth <martin.roth(a)se-eng.com> Change-Id: Ie79fe4812532d124cc81747c75a4f3d88d00531c Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/2189 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martin.roth(a)se-eng.com> Build-Tested: build bot (Jenkins) at Fri Feb 22 23:16:09 2013, giving +1 See http://review.coreboot.org/2189 for details. -gerrit

1 0

Patch merged into coreboot/master: a48918f Persimmon, Inagua: PCI devs 12.1, 13.1 (USB) don't exist, but 14.6 (GEC) does
by gerrit＠coreboot.org 25 Feb '13

25 Feb '13

the following patch was just integrated into master: commit a48918f75dda6f53ebdeb8c6371b6de6eb601205 Author: Jens Rottmann <JRottmann(a)LiPPERTembedded.de> Date: Wed Feb 20 21:12:37 2013 +0100 Persimmon, Inagua: PCI devs 12.1, 13.1 (USB) don't exist, but 14.6 (GEC) does USB ports 0-4 are handled by PCI devices 12.0 (OHCI) and 12.2 (EHCI). 12.1 simply does not exist, so remove it from devicetree.cb. While at it make the comment more detailed. Likewise for all USB ports. USB device 14.6 is the Broadcom GbE MAC integrated in the Hudson-E1. Add it to devicetree.cb. It's used on Inagua (on), but not on Persimmon (off). Change-Id: Idea27b3390fa4470f2592e79fdd633d5a218b97b Signed-off-by: Jens Rottmann <JRottmann(a)LiPPERTembedded.de> Reviewed-on: http://review.coreboot.org/2463 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-by: Dave Frodin <dave.frodin(a)se-eng.com> Build-Tested: build bot (Jenkins) at Wed Feb 20 22:24:14 2013, giving +1 See http://review.coreboot.org/2463 for details. -gerrit

1 0

New patch to review for coreboot: 2a14e8e AMD Southbridge: Add RTC init to lpc_init
by Mike Loptien 25 Feb '13

25 Feb '13

Mike Loptien (mike.loptien(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2510 -gerrit commit 2a14e8e643564d4762d81b6c0444037842f834d2 Author: Mike Loptien <mike.loptien(a)se-eng.com> Date: Mon Feb 25 10:41:28 2013 -0700 AMD Southbridge: Add RTC init to lpc_init Adding RTC init code to the Southbridge initialization code in 'lpc_init'. This initializes the RTC so that the Date Alarm register is set to a valid value (0x00) at startup. By setting the Date Alarm register to 0x00, it does not get evaluated along with the seconds, minutes, and hours when running 'fwts s3'. Information about fwts (Firmware Test Suite) can be found here: https://wiki.ubuntu.com/Kernel/Reference/fwts This is the same edit made to the CIMX SB800 titled 'AMD/Persimmon: Add RTC init to CIMX SB800' with commit ID: c4d3d which can be viewed here: http://review.coreboot.org/#/c/2488/ Change-Id: Iddb7a3cbabe736b511cde03d7dc0a4a0b1c7fd90 Signed-off-by: Mike Loptien <mike.loptien(a)se-eng.com> --- src/southbridge/amd/agesa/hudson/lpc.c | 7 +++++++ src/southbridge/amd/cimx/sb700/late.c | 7 +++++++ src/southbridge/amd/cimx/sb900/late.c | 7 +++++++ 3 files changed, 21 insertions(+) diff --git a/src/southbridge/amd/agesa/hudson/lpc.c b/src/southbridge/amd/agesa/hudson/lpc.c index 86e937e..aad4eb9 100644 --- a/src/southbridge/amd/agesa/hudson/lpc.c +++ b/src/southbridge/amd/agesa/hudson/lpc.c @@ -69,6 +69,13 @@ static void lpc_init(device_t dev) pci_write_config8(dev, 0xBB, byte); rtc_check_update_cmos_date(RTC_HAS_ALTCENTURY); + + /* Initialize the real time clock. + * The 0 argument tells rtc_init not to + * update CMOS unless it is invalid. + * 1 tells rtc_init to always initialize the CMOS. + */ + rtc_init(0); } static void hudson_lpc_read_resources(device_t dev) diff --git a/src/southbridge/amd/cimx/sb700/late.c b/src/southbridge/amd/cimx/sb700/late.c index be2b8cd..4c5dde9 100644 --- a/src/southbridge/amd/cimx/sb700/late.c +++ b/src/southbridge/amd/cimx/sb700/late.c @@ -79,6 +79,13 @@ static void lpc_init(device_t dev) rtc_check_update_cmos_date(RTC_HAS_ALTCENTURY); + /* Initialize the real time clock. + * The 0 argument tells rtc_init not to + * update CMOS unless it is invalid. + * 1 tells rtc_init to always initialize the CMOS. + */ + rtc_init(0); + printk(BIOS_DEBUG, "SB700 - Late.c - lpc_init - End.\n"); } diff --git a/src/southbridge/amd/cimx/sb900/late.c b/src/southbridge/amd/cimx/sb900/late.c index 85485ed..65cea69 100644 --- a/src/southbridge/amd/cimx/sb900/late.c +++ b/src/southbridge/amd/cimx/sb900/late.c @@ -101,6 +101,13 @@ static void lpc_init(device_t dev) //- hpetInit(sb_config, &(sb_config->BuildParameters)); rtc_check_update_cmos_date(RTC_HAS_ALTCENTURY); + /* Initialize the real time clock. + * The 0 argument tells rtc_init not to + * update CMOS unless it is invalid. + * 1 tells rtc_init to always initialize the CMOS. + */ + rtc_init(0); + printk(BIOS_DEBUG, "SB900 - Late.c - lpc_init - End.\n"); }

1 0

New patch to review for coreboot: dc2395f Revert "AMD S3: Program the flash in a bigger data packet"
by Dave Frodin 25 Feb '13

25 Feb '13

Dave Frodin (dave.frodin(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2509 -gerrit commit dc2395ff85b5573e1a6c918e649ffc0eaaff6683 Author: Dave Frodin <dave.frodin(a)se-eng.com> Date: Mon Feb 25 10:39:48 2013 -0700 Revert "AMD S3: Program the flash in a bigger data packet" This reverts commit ca6e1f6c04c96c435bdbf30a1b88cab0e5be330b. The packet size changes ends up corrupting the flash when booting Persimmon. I did figure out that the maximum number of bytes that can be sent is actually 8 bytes according to the sb800 spec. There must be additional problems beyond that since setting the packet size to 8 still causes problems. Change-Id: Ieb24247cf79e95bb0e548c83601dfddffbf6be59 Signed-off-by: Dave Frodin <dave.frodin(a)se-eng.com> --- src/cpu/amd/agesa/s3_resume.c | 56 ++++++++++++++++++++++++++----------------- 1 file changed, 34 insertions(+), 22 deletions(-) diff --git a/src/cpu/amd/agesa/s3_resume.c b/src/cpu/amd/agesa/s3_resume.c index 278c1da..ee9d7c9 100644 --- a/src/cpu/amd/agesa/s3_resume.c +++ b/src/cpu/amd/agesa/s3_resume.c @@ -178,21 +178,29 @@ void OemAgesaSaveMtrr(void) /* Fixed MTRRs */ msr_data = rdmsr(0x250); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; msr_data = rdmsr(0x258); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; msr_data = rdmsr(0x259); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; for (i = 0x268; i < 0x270; i++) { msr_data = rdmsr(i); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; } /* Disable access to AMD RdDram and WrDram extension bits */ @@ -203,24 +211,32 @@ void OemAgesaSaveMtrr(void) /* Variable MTRRs */ for (i = 0x200; i < 0x210; i++) { msr_data = rdmsr(i); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; } /* SYS_CFG */ msr_data = rdmsr(0xC0010010); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; /* TOM */ msr_data = rdmsr(0xC001001A); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; /* TOM2 */ msr_data = rdmsr(0xC001001D); - flash->write(flash, nvram_pos, 8, &msr_data); - nvram_pos += 8; + flash->write(flash, nvram_pos, 4, &msr_data.lo); + nvram_pos += 4; + flash->write(flash, nvram_pos, 4, &msr_data.hi); + nvram_pos += 4; flash->spi->rw = SPI_WRITE_FLAG; spi_release_bus(flash->spi); @@ -274,17 +290,13 @@ u32 OemAgesaSaveS3Info(S3_DATA_TYPE S3DataType, u32 DataSize, void *Data) flash->erase(flash, S3_DATA_VOLATILE_POS, S3_DATA_VOLATILE_SIZE); } -#ifndef SPI_DATA_PACKET_SIZE -#define SPI_DATA_PACKET_SIZE 0xF -#endif nvram_pos = 0; flash->write(flash, nvram_pos + pos, sizeof(DataSize), &DataSize); - for (nvram_pos = 0; nvram_pos < DataSize - SPI_DATA_PACKET_SIZE; nvram_pos += SPI_DATA_PACKET_SIZE) { + for (nvram_pos = 0; nvram_pos < DataSize; nvram_pos += 4) { data = *(u32 *) (Data + nvram_pos); - flash->write(flash, nvram_pos + pos + 4, SPI_DATA_PACKET_SIZE, (u8 *)(Data + nvram_pos)); + flash->write(flash, nvram_pos + pos + 4, sizeof(u32), (u32 *)(Data + nvram_pos)); } - flash->write(flash, nvram_pos + pos + 4, DataSize % SPI_DATA_PACKET_SIZE, (u8 *)(Data + nvram_pos)); flash->spi->rw = SPI_WRITE_FLAG; spi_release_bus(flash->spi);

1 0

Patch merged into coreboot/master: 12d6024 AMD boards: ACPI DSDT: Use COREBOOT for the OEM Table ID field
by gerrit＠coreboot.org 25 Feb '13

25 Feb '13

the following patch was just integrated into master: commit 12d60247ab071e775cad6dc7fe78c2d7bc9bab45 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Thu Feb 21 15:54:50 2013 +0100 AMD boards: ACPI DSDT: Use COREBOOT for the OEM Table ID field The DSDT header contains the fields OEMID and OEM Table ID. See for example ACPI specification 4.0a [1] 5.2.11.1 Differentiated System Description Table (DSDT) on page 135. There Table 5-16 contains the descriptions. Field Byte Length Byte Offset Description =================================================== OEMID 6 10 OEM ID OEM Table ID 8 16 The manufacture model ID. Currently in coreboot there is no common method what to put in these fields. Mostly Intel based boards populate it with "CORE " ore "COREv4" and AMD based boards populate it with the board vendor and model number, abbreviated appropriately to fit into these fields. On most boards the proprietary vendor BIOS seems to leave these fields – displayed with `sudo dmidecode` under System Information – blank To Be Filled By O.E.M. and fill out the Base Board Information with the board vendor and model name. In [2] Jens Rottmann argues that the this is really just the table ID used for naming it and that »99% of the DSDT code is not board specific«. Both approaches seem to have their advantages, but using the second one, developers often seem to forget to update them (for example AMD Thather). The current situation is at least not optimal. and therefore at least unify the string in the OEM Table ID. If unifying the OEM ID is also a good idea this should be done too. If later on it should be decided that the board vendor and model should be used again, this should be somehow derived from Kconfig. The following command was used for the change [3]. $ git grep -l '\/\* TABLE ID \*\/' | xargs sed -i '/TABLE ID/s/"$[^"]*$"/"COREBOOT"/' This patch is split out from [2]. [1] http://www.acpi.info/spec40a.htm [2] http://review.coreboot.org/#/c/2464/ [3] http://stackoverflow.com/questions/5207838/sed-regex-matching-text-between-… Change-Id: Iec98c615ce37f928abc1b500eff5aa865d772cb2 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/2472 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Build-Tested: build bot (Jenkins) at Thu Feb 21 17:01:23 2013, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Mon Feb 25 18:51:28 2013, giving +2 See http://review.coreboot.org/2472 for details. -gerrit

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
79
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot February 2013