coreboot February 2013

coreboot@coreboot.org

27 participants
790 discussions

Patch set updated for coreboot: 1576f7a AMD Southstation: Fix final warning
by Martin Roth 24 Feb '13

24 Feb '13

Martin Roth (martin.roth(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2501 -gerrit commit 1576f7a049fb1aca2e0e467a5e758e5c6d620bdc Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Feb 24 14:12:32 2013 -0700 AMD Southstation: Fix final warning Changes: - Add #include of delay.h in mainboard.c to pick up declaration of mdelay function. Notes: - This fixes this warning: mainboard.c:69, GNU Compiler 4 (gcc), Priority: Normal implicit declaration of function 'mdelay' [-Wimplicit-function-declaration] Change-Id: I72f333cd87215a7fc1e62d1d7ee4b2395444b03e Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> --- src/mainboard/amd/south_station/mainboard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/amd/south_station/mainboard.c b/src/mainboard/amd/south_station/mainboard.c index 5f31e03..97cb043 100644 --- a/src/mainboard/amd/south_station/mainboard.c +++ b/src/mainboard/amd/south_station/mainboard.c @@ -24,6 +24,7 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> +#include <delay.h> #include "SBPLATFORM.h" /* Platfrom Specific Definitions */

1 0

New patch to review for coreboot: 587d2d4 AMD Southstation: Fix final warning
by Martin Roth 24 Feb '13

24 Feb '13

Martin Roth (martin.roth(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2501 -gerrit commit 587d2d4be54fc1b6f63ff6e05801db1ce1a3e8f0 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Feb 24 14:12:32 2013 -0700 AMD Southstation: Fix final warning Changes: - Add #include of delay.h in mainboard.c to pick up declaration of mdelay function. Change-Id: I72f333cd87215a7fc1e62d1d7ee4b2395444b03e Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> --- src/mainboard/amd/south_station/mainboard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/amd/south_station/mainboard.c b/src/mainboard/amd/south_station/mainboard.c index 5f31e03..97cb043 100644 --- a/src/mainboard/amd/south_station/mainboard.c +++ b/src/mainboard/amd/south_station/mainboard.c @@ -24,6 +24,7 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> +#include <delay.h> #include "SBPLATFORM.h" /* Platfrom Specific Definitions */

1 0

New patch to review for coreboot: db17145 AMD Persimmon: Use SPD read code from F14 wrapper
by Martin Roth 24 Feb '13

24 Feb '13

Martin Roth (martin.roth(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2500 -gerrit commit db17145a5dc5d4d7709a27182c98dfc266af5abd Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Feb 24 12:58:33 2013 -0700 AMD Persimmon: Use SPD read code from F14 wrapper Changes: - Get rid of the persimmon mainboard specific code which has been moved into the wrapper as a platform generic function in change http://review.coreboot.org/#/c/2497/ AMD f14: Add SPD read functions to wrapper code - Move DIMM addresses into devicetree.cb Notes: - The DIMM reads only happen in romstage, so the function is not available in ramstage. Point the read-SPD callback to a generic function in ramstage. - Eliminate the intermediary function that simply calls into another function - just call the SPD-read function directly. Change-Id: I5f017dbb8dee5a09ec19734a6069ff9b71a6ab50 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> --- src/mainboard/amd/persimmon/BiosCallOuts.c | 18 ++-- src/mainboard/amd/persimmon/BiosCallOuts.h | 3 - src/mainboard/amd/persimmon/Makefile.inc | 2 - src/mainboard/amd/persimmon/devicetree.cb | 7 ++ src/mainboard/amd/persimmon/dimmSpd.c | 164 ----------------------------- src/mainboard/amd/persimmon/dimmSpd.h | 63 ----------- 6 files changed, 15 insertions(+), 242 deletions(-) diff --git a/src/mainboard/amd/persimmon/BiosCallOuts.c b/src/mainboard/amd/persimmon/BiosCallOuts.c index 9bad4f4..ca80266 100644 --- a/src/mainboard/amd/persimmon/BiosCallOuts.c +++ b/src/mainboard/amd/persimmon/BiosCallOuts.c @@ -19,10 +19,10 @@ #include "agesawrapper.h" #include "amdlib.h" -#include "dimmSpd.h" #include "BiosCallOuts.h" #include "heapManager.h" #include "SB800.h" +#include <northbridge/amd/agesa/family14/dimmSpd.h> STATIC BIOS_CALLOUT_STRUCT BiosCallouts[] = { @@ -42,9 +42,15 @@ STATIC BIOS_CALLOUT_STRUCT BiosCallouts[] = BiosLocateBuffer }, +#ifdef __PRE_RAM__ {AGESA_READ_SPD, - BiosReadSpd + fam14_ReadSPD }, +#else + {AGESA_READ_SPD, + BiosDefaultRet + }, +#endif {AGESA_READ_SPD_RECOVERY, BiosDefaultRet @@ -425,14 +431,6 @@ AGESA_STATUS BiosReset (UINT32 Func, UINT32 Data, VOID *ConfigPtr) return Status; } -AGESA_STATUS BiosReadSpd (UINT32 Func, UINT32 Data, VOID *ConfigPtr) -{ - AGESA_STATUS Status; - Status = AmdMemoryReadSPD (Func, Data, (AGESA_READ_SPD_PARAMS *)ConfigPtr); - - return Status; -} - AGESA_STATUS BiosDefaultRet (UINT32 Func, UINT32 Data, VOID *ConfigPtr) { return AGESA_UNSUPPORTED; diff --git a/src/mainboard/amd/persimmon/BiosCallOuts.h b/src/mainboard/amd/persimmon/BiosCallOuts.h index 25e5656..18165cf 100644 --- a/src/mainboard/amd/persimmon/BiosCallOuts.h +++ b/src/mainboard/amd/persimmon/BiosCallOuts.h @@ -53,9 +53,6 @@ AGESA_STATUS BiosRunFuncOnAp (UINT32 Func, UINT32 Data, VOID *ConfigPtr); AGESA_STATUS BiosReset (UINT32 Func, UINT32 Data, VOID *ConfigPtr); AGESA_STATUS BiosGetIdsInitData (UINT32 Func, UINT32 Data, VOID *ConfigPtr); -/* AGESA ADVANCED CALLOUTS - MEMORY */ -AGESA_STATUS BiosReadSpd (UINT32 Func,UINT32 Data,VOID *ConfigPtr); - /* BIOS DEFAULT RET */ AGESA_STATUS BiosDefaultRet (UINT32 Func, UINT32 Data, VOID *ConfigPtr); diff --git a/src/mainboard/amd/persimmon/Makefile.inc b/src/mainboard/amd/persimmon/Makefile.inc index 8a72727..0b8651f 100644 --- a/src/mainboard/amd/persimmon/Makefile.inc +++ b/src/mainboard/amd/persimmon/Makefile.inc @@ -26,13 +26,11 @@ endif romstage-y += buildOpts.c romstage-y += agesawrapper.c -romstage-y += dimmSpd.c romstage-y += BiosCallOuts.c romstage-y += PlatformGnbPcie.c ramstage-y += buildOpts.c ramstage-y += agesawrapper.c -ramstage-y += dimmSpd.c ramstage-y += BiosCallOuts.c ramstage-y += PlatformGnbPcie.c diff --git a/src/mainboard/amd/persimmon/devicetree.cb b/src/mainboard/amd/persimmon/devicetree.cb index fce7d10..b232b9b 100644 --- a/src/mainboard/amd/persimmon/devicetree.cb +++ b/src/mainboard/amd/persimmon/devicetree.cb @@ -151,6 +151,13 @@ chip northbridge/amd/agesa/family14/root_complex device pci 18.5 on end device pci 18.6 on end device pci 18.7 on end + + register "spdAddrLookup" = " + { + { {0xA0, 0xA2}, {0x00, 0x00}, }, // socket 0 - Channel 0 & 1 - 8-bit SPD addresses + { {0x00, 0x00}, {0x00, 0x00}, }, // socket 1 - Channel 0 & 1 - 8-bit SPD addresses + }" + end #chip northbridge/amd/agesa/family14 # CPU side of HT root complex end #domain end #northbridge/amd/agesa/family14/root_complex diff --git a/src/mainboard/amd/persimmon/dimmSpd.c b/src/mainboard/amd/persimmon/dimmSpd.c deleted file mode 100644 index a021cc2..0000000 --- a/src/mainboard/amd/persimmon/dimmSpd.c +++ /dev/null @@ -1,164 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -#include "Porting.h" -#include "AGESA.h" -#include "amdlib.h" -#include "OEM.h" /* SMBUS0_BASE_ADDRESS */ - -AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PARAMS *info); -#define DIMENSION(array)(sizeof (array)/ sizeof (array [0])) - -/*#pragma optimize ("", off) // for source level debug -*--------------------------------------------------------------------------- -* -* SPD address table - porting required -*/ - -static const UINT8 spdAddressLookup [2] [2] [4] = // socket, channel, dimm -{ - // socket 0 - { - {0xA0, 0xA2}, // channel 0 dimms - {0x00, 0x00}, // channel 1 dimms - }, - // socket 1 - { - {0x00, 0x00}, // channel 0 dimms - {0x00, 0x00}, // channel 1 dimms - }, -}; - -/*----------------------------------------------------------------------------- - * - * readSmbusByteData - read a single SPD byte from any offset - */ - -static int readSmbusByteData (int iobase, int address, char *buffer, int offset) -{ - unsigned int status; - UINT64 limit; - - address |= 1; // set read bit - - __outbyte (iobase + 0, 0xFF); // clear error status - __outbyte (iobase + 1, 0x1F); // clear error status - __outbyte (iobase + 3, offset); // offset in eeprom - __outbyte (iobase + 4, address); // slave address and read bit - __outbyte (iobase + 2, 0x48); // read byte command - - // time limit to avoid hanging for unexpected error status (should never happen) - limit = __rdtsc () + 2000000000 / 10; - for (;;) { - status = __inbyte (iobase); - if (__rdtsc () > limit) break; - if ((status & 2) == 0) continue; // SMBusInterrupt not set, keep waiting - if ((status & 1) == 1) continue; // HostBusy set, keep waiting - break; - } - - buffer [0] = __inbyte (iobase + 5); - if (status == 2) status = 0; // check for done with no errors - return status; -} - -/*----------------------------------------------------------------------------- - * - * readSmbusByte - read a single SPD byte from the default offset - * this function is faster function readSmbusByteData - */ - -static int readSmbusByte (int iobase, int address, char *buffer) -{ - unsigned int status; - UINT64 limit; - - __outbyte (iobase + 0, 0xFF); // clear error status - __outbyte (iobase + 2, 0x44); // read command - - // time limit to avoid hanging for unexpected error status - limit = __rdtsc () + 2000000000 / 10; - for (;;) { - status = __inbyte (iobase); - if (__rdtsc () > limit) break; - if ((status & 2) == 0) continue; // SMBusInterrupt not set, keep waiting - if ((status & 1) == 1) continue; // HostBusy set, keep waiting - break; - } - - buffer [0] = __inbyte (iobase + 5); - if (status == 2) status = 0; // check for done with no errors - return status; -} - -/*--------------------------------------------------------------------------- - * - * readspd - Read one or more SPD bytes from a DIMM. - * Start with offset zero and read sequentially. - * Optimization relies on autoincrement to avoid - * sending offset for every byte. - * Reads 128 bytes in 7-8 ms at 400 KHz. - */ - -static int readspd (int iobase, int SmbusSlaveAddress, char *buffer, int count) -{ - int index, error; - - /* read the first byte using offset zero */ - error = readSmbusByteData (iobase, SmbusSlaveAddress, buffer, 0); - if (error) return error; - - /* read the remaining bytes using auto-increment for speed */ - for (index = 1; index < count; index++) { - error = readSmbusByte (iobase, SmbusSlaveAddress, &buffer [index]); - if (error) return error; - } - - return 0; -} - -static void writePmReg (int reg, int data) - { - __outbyte (0xCD6, reg); - __outbyte (0xCD7, data); - } - -static void setupFch (int ioBase) -{ - writePmReg (0x2D, ioBase >> 8); - writePmReg (0x2C, ioBase | 1); - writePmReg (0x29, 0x80); - writePmReg (0x28, 0x61); - __outbyte (ioBase + 0x0E, 66000000 / 400000 / 4); // set SMBus clock to 400 KHz -} - -AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PARAMS *info) -{ - int spdAddress, ioBase; - - if (info->SocketId >= DIMENSION (spdAddressLookup )) return AGESA_ERROR; - if (info->MemChannelId >= DIMENSION (spdAddressLookup[0] )) return AGESA_ERROR; - if (info->DimmId >= DIMENSION (spdAddressLookup[0][0])) return AGESA_ERROR; - - spdAddress = spdAddressLookup [info->SocketId] [info->MemChannelId] [info->DimmId]; - if (spdAddress == 0) return AGESA_ERROR; - ioBase = SMBUS0_BASE_ADDRESS; - setupFch (ioBase); - return readspd (ioBase, spdAddress, (void *) info->Buffer, 128); -} diff --git a/src/mainboard/amd/persimmon/dimmSpd.h b/src/mainboard/amd/persimmon/dimmSpd.h deleted file mode 100644 index caaefbe..0000000 --- a/src/mainboard/amd/persimmon/dimmSpd.h +++ /dev/null @@ -1,63 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -/*---------------------------------------------------------------------------------------- - * M O D U L E S U S E D - *---------------------------------------------------------------------------------------- - */ - -#ifndef _DIMMSPD_H_ -#define _DIMMSPD_H_ - -#include "Porting.h" -#include "AGESA.h" - -/*---------------------------------------------------------------------------------------- - * D E F I N I T I O N S A N D M A C R O S - *---------------------------------------------------------------------------------------- - */ - -/*---------------------------------------------------------------------------------------- - * T Y P E D E F S A N D S T R U C T U R E S - *---------------------------------------------------------------------------------------- - */ - -/*---------------------------------------------------------------------------------------- - * P R O T O T Y P E S O F L O C A L F U N C T I O N S - *---------------------------------------------------------------------------------------- - */ - -/*---------------------------------------------------------------------------------------- - * E X P O R T E D F U N C T I O N S - *---------------------------------------------------------------------------------------- - */ - -AGESA_STATUS -AmdMemoryReadSPD ( - IN UINT32 Func, - IN UINT32 Data, - IN OUT AGESA_READ_SPD_PARAMS *SpdData - ); - -/*--------------------------------------------------------------------------------------- - * L O C A L F U N C T I O N S - *--------------------------------------------------------------------------------------- - */ - -#endif

1 0

Patch set updated for coreboot: c82736a AMD f14: Add SPD read functions to wrapper code
by Martin Roth 24 Feb '13

24 Feb '13

Martin Roth (martin.roth(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2497 -gerrit commit c82736a2736660daf0dd759ac3e76c03ff956463 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Feb 24 10:46:11 2013 -0700 AMD f14: Add SPD read functions to wrapper code CHANGE: This is the initial step for moving the AMD F14 SB800/HUDSON SPD-read callout out of the mainboard directories and into the vendorcode. The next step is to update the platforms to use this routine in BiosCallouts.c and to delete the code from the mainboard directories. The DIMM addresses should be moved into devicetree.cb. If there are significant differences or reasons that the mainboard needs to override this code, it's perfectly reasonable to keep using the version in the mainboard, but this allows us to remove duplicated code and simplify the mainboard directories. NOTES: This code duplicates what was in persimmon, with changes to use the devicetree.cb structures. The ASF setup was also removed from the persimmon copy (PMIO writes to 0x28 & 0x29) as that's not needed for the SPD access and doesn't make sense to initialize here. It is intended that this file will not be included in ramstage as the DIMM init is all done in romstage. A commit for Persimmon to use this code will follow shortly. This is similar to what was done for Parmer/Thatcher in commit 7fb692bd - http://review.coreboot.org/#/c/2190/ Fam15tn: Move SPD read from mainboards into wrapper Yes, it would make sense to split this into two separate files and move the SMBUS initialization and access into the southbridge wrapper. Maybe that can come next. Change-Id: I1e106d3912c160b0015bf02158d9faba4f578ee3 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> --- src/northbridge/amd/agesa/family14/Makefile.inc | 2 + src/northbridge/amd/agesa/family14/chip.h | 28 ++++ src/northbridge/amd/agesa/family14/dimmSpd.c | 165 ++++++++++++++++++++++++ src/northbridge/amd/agesa/family14/dimmSpd.h | 56 ++++++++ 4 files changed, 251 insertions(+) diff --git a/src/northbridge/amd/agesa/family14/Makefile.inc b/src/northbridge/amd/agesa/family14/Makefile.inc index 8cdd0a0..eacd1f1 100644 --- a/src/northbridge/amd/agesa/family14/Makefile.inc +++ b/src/northbridge/amd/agesa/family14/Makefile.inc @@ -17,4 +17,6 @@ # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA # +romstage-y += dimmSpd.c + ramstage-y += northbridge.c diff --git a/src/northbridge/amd/agesa/family14/chip.h b/src/northbridge/amd/agesa/family14/chip.h new file mode 100644 index 0000000..21f8c94 --- /dev/null +++ b/src/northbridge/amd/agesa/family14/chip.h @@ -0,0 +1,28 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2013 Sage Electronic Engineering, LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef _AGESA_FAM14_CHIP_H_ +#define _AGESA_FAM14_CHIP_H_ + +struct northbridge_amd_agesa_family14_config +{ + u8 spdAddrLookup[2][2][4]; +}; + +#endif diff --git a/src/northbridge/amd/agesa/family14/dimmSpd.c b/src/northbridge/amd/agesa/family14/dimmSpd.c new file mode 100644 index 0000000..f416df5 --- /dev/null +++ b/src/northbridge/amd/agesa/family14/dimmSpd.c @@ -0,0 +1,165 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2011 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <device/pci_def.h> +#include <device/device.h> +#include <stdlib.h> +#include "OEM.h" /* SMBUS0_BASE_ADDRESS */ + +/* warning: Porting.h includes an open #pragma pack(1) */ +#include "Porting.h" +#include "AGESA.h" +#include "amdlib.h" +#include "dimmSpd.h" +#include "chip.h" + +//#pragma optimize ("", off) // for source level debug + +/*----------------------------------------------------------------------------- + * + * readSmbusByteData - read a single SPD byte from any offset + */ + +static int readSmbusByteData (UINT16 iobase, UINT8 address, char *buffer, int offset) +{ + unsigned int status; + UINT64 limit; + + address |= 1; // set read bit + + __outbyte (iobase + 0, 0xFF); // clear error status + __outbyte (iobase + 1, 0x1F); // clear error status + __outbyte (iobase + 3, offset); // offset in eeprom + __outbyte (iobase + 4, address); // slave address and read bit + __outbyte (iobase + 2, 0x48); // read byte command + + // time limit to avoid hanging for unexpected error status (should never happen) + limit = __rdtsc () + 2000000000 / 10; + for (;;) { + status = __inbyte (iobase); + if (__rdtsc () > limit) break; + if ((status & 2) == 0) continue; // SMBusInterrupt not set, keep waiting + if ((status & 1) == 1) continue; // HostBusy set, keep waiting + break; + } + + buffer [0] = __inbyte (iobase + 5); + if (status == 2) // check for done with no errors + status = 0; + return status; +} + +/*----------------------------------------------------------------------------- + * + * readSmbusByte - read a single SPD byte from the default offset + * this function is faster function readSmbusByteData + */ + +static UINT8 readSmbusByte (UINT16 iobase, UINT8 address, char *buffer) +{ + unsigned int status; + UINT64 limit; + + __outbyte (iobase + 0, 0xFF); // clear error status + __outbyte (iobase + 2, 0x44); // read command + + // time limit to avoid hanging for unexpected error status + limit = __rdtsc () + 2000000000 / 10; + for (;;) { + status = __inbyte (iobase); + if (__rdtsc () > limit) break; + if ((status & 2) == 0) continue; // SMBusInterrupt not set, keep waiting + if ((status & 1) == 1) continue; // HostBusy set, keep waiting + break; + } + + buffer [0] = __inbyte (iobase + 5); + if (status == 2) // check for done with no errors + status = 0; + return status; +} + +/*--------------------------------------------------------------------------- + * + * readspd - Read one or more SPD bytes from a DIMM. + * Start with offset zero and read sequentially. + * Optimization relies on autoincrement to avoid + * sending offset for every byte. + * Reads 128 bytes in 7-8 ms at 400 KHz. + */ + +static UINT8 readspd (UINT16 iobase, UINT8 SmbusSlaveAddress, char *buffer, UINT16 count) +{ + UINT16 index; + UINT8 error; + + /* read the first byte using offset zero */ + error = readSmbusByteData (iobase, SmbusSlaveAddress, buffer, 0); + if (error) return error; + + /* read the remaining bytes using auto-increment for speed */ + for (index = 1; index < count; index++) { + error = readSmbusByte (iobase, SmbusSlaveAddress, &buffer [index]); + if (error) return error; + } + + return 0; +} + +static void writePmReg (UINT8 reg, UINT8 data) +{ + __outbyte (0xCD6, reg); + __outbyte (0xCD7, data); +} + +static void setupFch (UINT16 ioBase) +{ + /* set up SMBUS - Set to SMBUS 0 & set base address */ + /* For SB800 to Hudson 3 */ + writePmReg (0x2D, ioBase >> 8); + writePmReg (0x2C, (ioBase & 0xe0) | 1); + __outbyte (ioBase + 0x0E, 66000000 / 400000 / 4); // set SMBus clock to 400 KHz +} + +AGESA_STATUS fam14_ReadSPD (UINT32 unused1, UINT32 unused2, void *infoptr) +{ + UINT8 spdAddress; + UINT16 ioBase = SMBUS0_BASE_ADDRESS; + AGESA_READ_SPD_PARAMS *info = infoptr; + ROMSTAGE_CONST struct device *dev = dev_find_slot(0, PCI_DEVFN(0x18, 2)); + ROMSTAGE_CONST struct northbridge_amd_agesa_family14_config *config = dev->chip_info; + + if ((dev == 0) || (config == 0)) + return AGESA_ERROR; + + if (info->SocketId >= ARRAY_SIZE(config->spdAddrLookup )) + return AGESA_ERROR; + if (info->MemChannelId >= ARRAY_SIZE(config->spdAddrLookup[0] )) + return AGESA_ERROR; + if (info->DimmId >= ARRAY_SIZE(config->spdAddrLookup[0][0])) + return AGESA_ERROR; + + spdAddress = config->spdAddrLookup + [info->SocketId] [info->MemChannelId] [info->DimmId]; + + if (spdAddress == 0) + return AGESA_ERROR; + setupFch (ioBase); + return readspd (ioBase, spdAddress, (void *) info->Buffer, 128); +} diff --git a/src/northbridge/amd/agesa/family14/dimmSpd.h b/src/northbridge/amd/agesa/family14/dimmSpd.h new file mode 100644 index 0000000..cc9edf8 --- /dev/null +++ b/src/northbridge/amd/agesa/family14/dimmSpd.h @@ -0,0 +1,56 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2011 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/*---------------------------------------------------------------------------------------- + * M O D U L E S U S E D + *---------------------------------------------------------------------------------------- + */ + +#ifndef _DIMMSPD_H_ +#define _DIMMSPD_H_ + +/*---------------------------------------------------------------------------------------- + * D E F I N I T I O N S A N D M A C R O S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * T Y P E D E F S A N D S T R U C T U R E S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * P R O T O T Y P E S O F L O C A L F U N C T I O N S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * E X P O R T E D F U N C T I O N S + *---------------------------------------------------------------------------------------- + */ + +AGESA_STATUS +fam14_ReadSPD (IN UINT32 Func, IN UINT32 Data, IN OUT void *SpdData); + +/*--------------------------------------------------------------------------------------- + * L O C A L F U N C T I O N S + *--------------------------------------------------------------------------------------- + */ + +#endif

1 0

Patch set updated for coreboot: 32fd570 Persimmon: Fix warning, enable warnings as errors
by Martin Roth 24 Feb '13

24 Feb '13

Martin Roth (martin.roth(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2494 -gerrit commit 32fd57005cecfe6dc0eab58d2236603eb9409a6e Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sat Feb 23 15:32:11 2013 -0700 Persimmon: Fix warning, enable warnings as errors - Fix redefinition warning for SB_GPIO_REG50 introduced in commit fa8702cf - http://review.coreboot.org/#/c/2446/ Persimmon: adapt PCIe reset code copied from Inagua to actually match Persimmon The warning being fixed is: SB800.h:1491, GNU Compiler 4 (gcc), Priority: Normal "SB_GPIO_REG50" redefined [enabled by default] - Enable warnings as errors so no more warnings will be accidentally committed. Change-Id: Ib443b2bd2067f0b7d5f93f79170899a0f8f61060 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> --- src/mainboard/amd/persimmon/BiosCallOuts.h | 2 -- src/mainboard/amd/persimmon/Kconfig | 4 ---- 2 files changed, 6 deletions(-) diff --git a/src/mainboard/amd/persimmon/BiosCallOuts.h b/src/mainboard/amd/persimmon/BiosCallOuts.h index 25e5656..c4f4f70 100644 --- a/src/mainboard/amd/persimmon/BiosCallOuts.h +++ b/src/mainboard/amd/persimmon/BiosCallOuts.h @@ -70,6 +70,4 @@ AGESA_STATUS BiosHookBeforeExitSelfRefresh (UINT32 Func, UINT32 Data, VOID *Conf /* PCIE slot reset control */ AGESA_STATUS BiosGnbPcieSlotReset (UINT32 Func, UINT32 Data, VOID *ConfigPtr); -#define SB_GPIO_REG50 50 - #endif //_BIOS_CALLOUT_H_ diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig index 55d6b0c..f3f9aa9 100644 --- a/src/mainboard/amd/persimmon/Kconfig +++ b/src/mainboard/amd/persimmon/Kconfig @@ -121,8 +121,4 @@ config DRIVERS_PS2_KEYBOARD bool default n -config WARNINGS_ARE_ERRORS - bool - default n - endif # BOARD_AMD_PERSIMMON

1 0

New patch to review for coreboot: 6a26fdd AMD f14: Add SPD read functions to wrapper code
by Martin Roth 24 Feb '13

24 Feb '13

Martin Roth (martin.roth(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2497 -gerrit commit 6a26fddaee993b51f2d30c406def7bfed0fd9d74 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sun Feb 24 10:46:11 2013 -0700 AMD f14: Add SPD read functions to wrapper code CHANGE: This is the initial step for moving the AMD F14 SB800/HUDSON SPD-read callout out of the mainboard directories and into the vendorcode. The next step is to update the platforms to use this routine in BiosCallouts.c and to delete the code from the mainboard directories. The DIMM addresses should be moved into devicetree.cb. If there are significant differences or reasons that the mainboard needs to override this code, it's perfectly reasonable to keep using the version in the mainboard, but this allows us to remove duplicated code and simplify the mainboard directories. NOTES: This code duplicates what was in persimmon, with changes to use the devicetree.cb structures. The ASF setup was also removed from the persimmon copy (PMIO writes to 0x28 & 0x29) as that's not needed for the SPD access and doesn't make sense to initialize here. It is intended that this file will not be included in ramstage as the DIMM init is all done in romstage. A commit for Persimmon to use this code will follow shortly. This is similar to what was done for Parmer/Thatcher in commit 7fb692bd - http://review.coreboot.org/#/c/2190/ Fam15tn: Move SPD read from mainboards into wrapper Yes, it would make sense to split this into two separate files and move the SMBUS initialization and access into the southbridge wrapper. Maybe that can come next. Change-Id: I1e106d3912c160b0015bf02158d9faba4f578ee3 Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> --- src/northbridge/amd/agesa/family14/Makefile.inc | 2 + src/northbridge/amd/agesa/family14/chip.h | 28 ++++ src/northbridge/amd/agesa/family14/dimmSpd.c | 165 ++++++++++++++++++++++++ src/northbridge/amd/agesa/family14/dimmSpd.h | 56 ++++++++ 4 files changed, 251 insertions(+) diff --git a/src/northbridge/amd/agesa/family14/Makefile.inc b/src/northbridge/amd/agesa/family14/Makefile.inc index 8cdd0a0..eacd1f1 100644 --- a/src/northbridge/amd/agesa/family14/Makefile.inc +++ b/src/northbridge/amd/agesa/family14/Makefile.inc @@ -17,4 +17,6 @@ # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA # +romstage-y += dimmSpd.c + ramstage-y += northbridge.c diff --git a/src/northbridge/amd/agesa/family14/chip.h b/src/northbridge/amd/agesa/family14/chip.h new file mode 100644 index 0000000..21f8c94 --- /dev/null +++ b/src/northbridge/amd/agesa/family14/chip.h @@ -0,0 +1,28 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2013 Sage Electronic Engineering, LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef _AGESA_FAM14_CHIP_H_ +#define _AGESA_FAM14_CHIP_H_ + +struct northbridge_amd_agesa_family14_config +{ + u8 spdAddrLookup[2][2][4]; +}; + +#endif diff --git a/src/northbridge/amd/agesa/family14/dimmSpd.c b/src/northbridge/amd/agesa/family14/dimmSpd.c new file mode 100644 index 0000000..f416df5 --- /dev/null +++ b/src/northbridge/amd/agesa/family14/dimmSpd.c @@ -0,0 +1,165 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2011 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <device/pci_def.h> +#include <device/device.h> +#include <stdlib.h> +#include "OEM.h" /* SMBUS0_BASE_ADDRESS */ + +/* warning: Porting.h includes an open #pragma pack(1) */ +#include "Porting.h" +#include "AGESA.h" +#include "amdlib.h" +#include "dimmSpd.h" +#include "chip.h" + +//#pragma optimize ("", off) // for source level debug + +/*----------------------------------------------------------------------------- + * + * readSmbusByteData - read a single SPD byte from any offset + */ + +static int readSmbusByteData (UINT16 iobase, UINT8 address, char *buffer, int offset) +{ + unsigned int status; + UINT64 limit; + + address |= 1; // set read bit + + __outbyte (iobase + 0, 0xFF); // clear error status + __outbyte (iobase + 1, 0x1F); // clear error status + __outbyte (iobase + 3, offset); // offset in eeprom + __outbyte (iobase + 4, address); // slave address and read bit + __outbyte (iobase + 2, 0x48); // read byte command + + // time limit to avoid hanging for unexpected error status (should never happen) + limit = __rdtsc () + 2000000000 / 10; + for (;;) { + status = __inbyte (iobase); + if (__rdtsc () > limit) break; + if ((status & 2) == 0) continue; // SMBusInterrupt not set, keep waiting + if ((status & 1) == 1) continue; // HostBusy set, keep waiting + break; + } + + buffer [0] = __inbyte (iobase + 5); + if (status == 2) // check for done with no errors + status = 0; + return status; +} + +/*----------------------------------------------------------------------------- + * + * readSmbusByte - read a single SPD byte from the default offset + * this function is faster function readSmbusByteData + */ + +static UINT8 readSmbusByte (UINT16 iobase, UINT8 address, char *buffer) +{ + unsigned int status; + UINT64 limit; + + __outbyte (iobase + 0, 0xFF); // clear error status + __outbyte (iobase + 2, 0x44); // read command + + // time limit to avoid hanging for unexpected error status + limit = __rdtsc () + 2000000000 / 10; + for (;;) { + status = __inbyte (iobase); + if (__rdtsc () > limit) break; + if ((status & 2) == 0) continue; // SMBusInterrupt not set, keep waiting + if ((status & 1) == 1) continue; // HostBusy set, keep waiting + break; + } + + buffer [0] = __inbyte (iobase + 5); + if (status == 2) // check for done with no errors + status = 0; + return status; +} + +/*--------------------------------------------------------------------------- + * + * readspd - Read one or more SPD bytes from a DIMM. + * Start with offset zero and read sequentially. + * Optimization relies on autoincrement to avoid + * sending offset for every byte. + * Reads 128 bytes in 7-8 ms at 400 KHz. + */ + +static UINT8 readspd (UINT16 iobase, UINT8 SmbusSlaveAddress, char *buffer, UINT16 count) +{ + UINT16 index; + UINT8 error; + + /* read the first byte using offset zero */ + error = readSmbusByteData (iobase, SmbusSlaveAddress, buffer, 0); + if (error) return error; + + /* read the remaining bytes using auto-increment for speed */ + for (index = 1; index < count; index++) { + error = readSmbusByte (iobase, SmbusSlaveAddress, &buffer [index]); + if (error) return error; + } + + return 0; +} + +static void writePmReg (UINT8 reg, UINT8 data) +{ + __outbyte (0xCD6, reg); + __outbyte (0xCD7, data); +} + +static void setupFch (UINT16 ioBase) +{ + /* set up SMBUS - Set to SMBUS 0 & set base address */ + /* For SB800 to Hudson 3 */ + writePmReg (0x2D, ioBase >> 8); + writePmReg (0x2C, (ioBase & 0xe0) | 1); + __outbyte (ioBase + 0x0E, 66000000 / 400000 / 4); // set SMBus clock to 400 KHz +} + +AGESA_STATUS fam14_ReadSPD (UINT32 unused1, UINT32 unused2, void *infoptr) +{ + UINT8 spdAddress; + UINT16 ioBase = SMBUS0_BASE_ADDRESS; + AGESA_READ_SPD_PARAMS *info = infoptr; + ROMSTAGE_CONST struct device *dev = dev_find_slot(0, PCI_DEVFN(0x18, 2)); + ROMSTAGE_CONST struct northbridge_amd_agesa_family14_config *config = dev->chip_info; + + if ((dev == 0) || (config == 0)) + return AGESA_ERROR; + + if (info->SocketId >= ARRAY_SIZE(config->spdAddrLookup )) + return AGESA_ERROR; + if (info->MemChannelId >= ARRAY_SIZE(config->spdAddrLookup[0] )) + return AGESA_ERROR; + if (info->DimmId >= ARRAY_SIZE(config->spdAddrLookup[0][0])) + return AGESA_ERROR; + + spdAddress = config->spdAddrLookup + [info->SocketId] [info->MemChannelId] [info->DimmId]; + + if (spdAddress == 0) + return AGESA_ERROR; + setupFch (ioBase); + return readspd (ioBase, spdAddress, (void *) info->Buffer, 128); +} diff --git a/src/northbridge/amd/agesa/family14/dimmSpd.h b/src/northbridge/amd/agesa/family14/dimmSpd.h new file mode 100644 index 0000000..cc9edf8 --- /dev/null +++ b/src/northbridge/amd/agesa/family14/dimmSpd.h @@ -0,0 +1,56 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2011 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/*---------------------------------------------------------------------------------------- + * M O D U L E S U S E D + *---------------------------------------------------------------------------------------- + */ + +#ifndef _DIMMSPD_H_ +#define _DIMMSPD_H_ + +/*---------------------------------------------------------------------------------------- + * D E F I N I T I O N S A N D M A C R O S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * T Y P E D E F S A N D S T R U C T U R E S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * P R O T O T Y P E S O F L O C A L F U N C T I O N S + *---------------------------------------------------------------------------------------- + */ + +/*---------------------------------------------------------------------------------------- + * E X P O R T E D F U N C T I O N S + *---------------------------------------------------------------------------------------- + */ + +AGESA_STATUS +fam14_ReadSPD (IN UINT32 Func, IN UINT32 Data, IN OUT void *SpdData); + +/*--------------------------------------------------------------------------------------- + * L O C A L F U N C T I O N S + *--------------------------------------------------------------------------------------- + */ + +#endif

1 0

Patch merged into coreboot/master: 14c2398 Siemens SITEMP G1P1: mainboard.c: Rename `init` to `mainboard_init`
by gerrit＠coreboot.org 24 Feb '13

24 Feb '13

the following patch was just integrated into master: commit 14c2398ce936da3856ae64e97f976767f3c7669c Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Feb 23 19:33:19 2013 +0100 Siemens SITEMP G1P1: mainboard.c: Rename `init` to `mainboard_init` This is the common way to name that function, so unify that. Change-Id: I8a01051bd304039662894b89eed53ce14dde98b6 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: http://review.coreboot.org/2491 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Sun Feb 24 17:03:07 2013, giving +2 See http://review.coreboot.org/2491 for details. -gerrit

1 0

Patch merged into coreboot/master: e533fda AMD f14 vendorcode: Fix warning
by gerrit＠coreboot.org 24 Feb '13

24 Feb '13

the following patch was just integrated into master: commit e533fdaa5902d228c4db694db390113b437a9777 Author: Martin Roth <martin.roth(a)se-eng.com> Date: Sat Feb 23 16:29:25 2013 -0700 AMD f14 vendorcode: Fix warning Add brackets around initializer in #define for PCIE_DDI_DATA_INITIALIZER to fix the warning: PlatformGnbPcie.c:89, GNU Compiler 4 (gcc), Priority: Normal missing braces around initializer [-Wmissing-braces] This warning happens for Inagua and South Station Change-Id: I7d8f742dd8335b704b0493aa6e9eaebc3cc50b1e Signed-off-by: Martin Roth <martin.roth(a)se-eng.com> Reviewed-on: http://review.coreboot.org/2495 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/2495 for details. -gerrit

1 0

New patch to review for coreboot: b315068 QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable`
by Paul Menzel 24 Feb '13

24 Feb '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2496 -gerrit commit b315068b03892d31fb3284b6ca388b0e7c7c0b13 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sun Feb 24 14:27:03 2013 +0100 QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable` Similar to the discussion on the coreboot list [1] Am Freitag, den 22.02.2013, 02:17 +0100 schrieb Peter Stuge: […] > Function names should try to be descriptive. "enable_dev" is not very > descriptive. I like "mainboard_enable" because it makes output such > as > > printk("%s: foo", __func__); > > useful. rename the function for the northbridge to `northbridge_enable`. [1] http://www.coreboot.org/pipermail/coreboot/2013-February/074549.html Change-Id: I262311ec511e394550330214621b8c37780c1d4e Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/emulation/qemu-x86/northbridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/emulation/qemu-x86/northbridge.c b/src/mainboard/emulation/qemu-x86/northbridge.c index 7c36c0a..3e7fbb9 100644 --- a/src/mainboard/emulation/qemu-x86/northbridge.c +++ b/src/mainboard/emulation/qemu-x86/northbridge.c @@ -135,7 +135,7 @@ static struct device_operations pci_domain_ops = { #endif }; -static void enable_dev(struct device *dev) +static void northbridge_enable(struct device *dev) { /* Set the operations if it is a special bus type */ if (dev->path.type == DEVICE_PATH_DOMAIN) { @@ -146,5 +146,5 @@ static void enable_dev(struct device *dev) struct chip_operations mainboard_emulation_qemu_x86_ops = { CHIP_NAME("QEMU Northbridge") - .enable_dev = enable_dev, + .enable_dev = northbridge_enable, };

1 0

Patch set updated for coreboot: c37e587 mainboard.c: Name enable_dev function uniformly `mainboard_enable`
by Paul Menzel 24 Feb '13

24 Feb '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2493 -gerrit commit c37e587c1a5f564e9f53255bed9fa468158b79ad Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Feb 23 21:31:23 2013 +0100 mainboard.c: Name enable_dev function uniformly `mainboard_enable` To reduce the differences between these file name the enabling device function in the directory `src/mainboard` uniformly `mainboard_enable` [1]. Thanks to the awesome help of gnomon and BlastHardcheese in the IRC channel #sed on <irc.freenode.net>. gnomon came up with the following command to do the actual work. $ cd src/mainboard $ for f in */*/mainboard.c ; \ > do src="$(awk '/\.enable_dev = /{v=$NF; sub(/,$/,"",v); print v}' "$f")" ; \ > [[ -z $src ]] && continue ; \ > printf '%s\n' "g/${src}/s/${src}$[,(]$/mainboard_enable\1/p" w | ed -s "$f" ; \ > done `src/mainboard/digitallogic/msm586seg/mainboard.c` had to be adapted manually as no comma was used separating the struct members. And with the following statement, gnomon is even more likable! My pleasure entirely. Good luck with coreboot; I'm a big fan of the project. [1] http://www.coreboot.org/pipermail/coreboot/2013-February/074548.html Change-Id: Ife9cd0c2d9cc1ed14afc6d40063450553f06a6c6 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/aaeon/pfm-540i_revb/mainboard.c | 4 ++-- src/mainboard/advansus/a785e-i/mainboard.c | 4 ++-- src/mainboard/amd/bimini_fam10/mainboard.c | 4 ++-- src/mainboard/amd/db800/mainboard.c | 4 ++-- src/mainboard/amd/dbm690t/mainboard.c | 4 ++-- src/mainboard/amd/dinar/mainboard.c | 4 ++-- src/mainboard/amd/inagua/mainboard.c | 4 ++-- src/mainboard/amd/mahogany/mainboard.c | 4 ++-- src/mainboard/amd/mahogany_fam10/mainboard.c | 4 ++-- src/mainboard/amd/norwich/mainboard.c | 4 ++-- src/mainboard/amd/parmer/mainboard.c | 4 ++-- src/mainboard/amd/persimmon/mainboard.c | 4 ++-- src/mainboard/amd/pistachio/mainboard.c | 4 ++-- src/mainboard/amd/rumba/mainboard.c | 4 ++-- src/mainboard/amd/south_station/mainboard.c | 4 ++-- src/mainboard/amd/thatcher/mainboard.c | 4 ++-- src/mainboard/amd/tilapia_fam10/mainboard.c | 4 ++-- src/mainboard/amd/torpedo/mainboard.c | 4 ++-- src/mainboard/amd/union_station/mainboard.c | 4 ++-- src/mainboard/artecgroup/dbe61/mainboard.c | 4 ++-- src/mainboard/asrock/939a785gmh/mainboard.c | 4 ++-- src/mainboard/asrock/e350m1/mainboard.c | 4 ++-- src/mainboard/asus/m4a78-em/mainboard.c | 4 ++-- src/mainboard/asus/m4a785-m/mainboard.c | 4 ++-- src/mainboard/asus/m5a88-v/mainboard.c | 4 ++-- src/mainboard/avalue/eax-785e/mainboard.c | 4 ++-- src/mainboard/bachmann/ot200/mainboard.c | 4 ++-- src/mainboard/digitallogic/msm586seg/mainboard.c | 4 ++-- src/mainboard/digitallogic/msm800sev/mainboard.c | 4 ++-- src/mainboard/emulation/qemu-armv7/mainboard.c | 4 ++-- src/mainboard/gigabyte/ma785gm/mainboard.c | 4 ++-- src/mainboard/gigabyte/ma785gmt/mainboard.c | 4 ++-- src/mainboard/gigabyte/ma78gm/mainboard.c | 4 ++-- src/mainboard/iei/kino-780am2-fam10/mainboard.c | 4 ++-- src/mainboard/iei/pm-lx2-800-r10/mainboard.c | 4 ++-- src/mainboard/jetway/pa78vm5/mainboard.c | 4 ++-- src/mainboard/kontron/kt690/mainboard.c | 4 ++-- src/mainboard/lippert/hurricane-lx/mainboard.c | 4 ++-- src/mainboard/lippert/literunner-lx/mainboard.c | 4 ++-- src/mainboard/lippert/roadrunner-lx/mainboard.c | 4 ++-- src/mainboard/lippert/spacerunner-lx/mainboard.c | 4 ++-- src/mainboard/pcengines/alix1c/mainboard.c | 4 ++-- src/mainboard/pcengines/alix2d/mainboard.c | 4 ++-- src/mainboard/siemens/sitemp_g1p1/mainboard.c | 4 ++-- src/mainboard/supermicro/h8qgi/mainboard.c | 4 ++-- src/mainboard/supermicro/h8scm/mainboard.c | 4 ++-- src/mainboard/supermicro/h8scm_fam10/mainboard.c | 4 ++-- src/mainboard/technexion/tim5690/mainboard.c | 4 ++-- src/mainboard/technexion/tim8690/mainboard.c | 4 ++-- src/mainboard/technologic/ts5300/mainboard.c | 2 +- src/mainboard/traverse/geos/mainboard.c | 4 ++-- src/mainboard/tyan/s8226/mainboard.c | 4 ++-- src/mainboard/winent/pl6064/mainboard.c | 4 ++-- src/mainboard/wyse/s50/mainboard.c | 4 ++-- 54 files changed, 107 insertions(+), 107 deletions(-) diff --git a/src/mainboard/aaeon/pfm-540i_revb/mainboard.c b/src/mainboard/aaeon/pfm-540i_revb/mainboard.c index ba64b9e..f6906a8 100644 --- a/src/mainboard/aaeon/pfm-540i_revb/mainboard.c +++ b/src/mainboard/aaeon/pfm-540i_revb/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "AAEON PFM-540I_REVB EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/advansus/a785e-i/mainboard.c b/src/mainboard/advansus/a785e-i/mainboard.c index e0f7c3b..0af8ba7 100644 --- a/src/mainboard/advansus/a785e-i/mainboard.c +++ b/src/mainboard/advansus/a785e-i/mainboard.c @@ -73,7 +73,7 @@ u8 is_dev3_present(void) * enable the dedicated function in A785E-I board. * This function called early than rs780_enable. *************************************************/ -static void a785e_i_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard A785E-I Enable. dev=0x%p\n", dev); @@ -82,5 +82,5 @@ static void a785e_i_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = a785e_i_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/bimini_fam10/mainboard.c b/src/mainboard/amd/bimini_fam10/mainboard.c index c9f0732..46b4e21 100644 --- a/src/mainboard/amd/bimini_fam10/mainboard.c +++ b/src/mainboard/amd/bimini_fam10/mainboard.c @@ -123,7 +123,7 @@ static void get_ide_dma66(void) * enable the dedicated function in bimini board. * This function called early than rs780_enable. *************************************************/ -static void bimini_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard BIMINI Enable. dev=0x%p\n", dev); @@ -133,5 +133,5 @@ static void bimini_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = bimini_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/db800/mainboard.c b/src/mainboard/amd/db800/mainboard.c index e34990b..0e19242 100644 --- a/src/mainboard/amd/db800/mainboard.c +++ b/src/mainboard/amd/db800/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "AMD DB800 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/dbm690t/mainboard.c b/src/mainboard/amd/dbm690t/mainboard.c index 39475ce..4355b6b 100644 --- a/src/mainboard/amd/dbm690t/mainboard.c +++ b/src/mainboard/amd/dbm690t/mainboard.c @@ -180,7 +180,7 @@ static void set_thermal_config(void) * enable the dedicated function in dbm690t board. * This function called early than rs690_enable. *************************************************/ -static void dbm690t_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard DBM690T Enable. dev=0x%p\n", dev); @@ -190,5 +190,5 @@ static void dbm690t_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = dbm690t_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/dinar/mainboard.c b/src/mainboard/amd/dinar/mainboard.c index ce9f2ca..df5519b 100644 --- a/src/mainboard/amd/dinar/mainboard.c +++ b/src/mainboard/amd/dinar/mainboard.c @@ -68,11 +68,11 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in dinar board. *************************************************/ -static void dinar_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard Dinar Enable. dev=0x%p\n", dev); } struct chip_operations mainboard_ops = { - .enable_dev = dinar_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/inagua/mainboard.c b/src/mainboard/amd/inagua/mainboard.c index 9a5e00c..2e2edc3 100644 --- a/src/mainboard/amd/inagua/mainboard.c +++ b/src/mainboard/amd/inagua/mainboard.c @@ -73,7 +73,7 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in INAGUA board. *************************************************/ -static void inagua_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -82,5 +82,5 @@ static void inagua_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = inagua_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/mahogany/mainboard.c b/src/mainboard/amd/mahogany/mainboard.c index c8405fc..3ad3602 100644 --- a/src/mainboard/amd/mahogany/mainboard.c +++ b/src/mainboard/amd/mahogany/mainboard.c @@ -97,7 +97,7 @@ u8 is_dev3_present(void) * enable the dedicated function in mahogany board. * This function called early than rs780_enable. *************************************************/ -static void mahogany_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MAHOGANY Enable. dev=0x%p\n", dev); @@ -106,5 +106,5 @@ static void mahogany_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = mahogany_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/mahogany_fam10/mainboard.c b/src/mainboard/amd/mahogany_fam10/mainboard.c index f944bd3..c9e7160 100644 --- a/src/mainboard/amd/mahogany_fam10/mainboard.c +++ b/src/mainboard/amd/mahogany_fam10/mainboard.c @@ -98,7 +98,7 @@ u8 is_dev3_present(void) * enable the dedicated function in mahogany board. * This function called early than rs780_enable. *************************************************/ -static void mahogany_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MAHOGANY Enable. dev=0x%p\n", dev); @@ -107,5 +107,5 @@ static void mahogany_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = mahogany_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/norwich/mainboard.c b/src/mainboard/amd/norwich/mainboard.c index 9002a57..e0e9001 100644 --- a/src/mainboard/amd/norwich/mainboard.c +++ b/src/mainboard/amd/norwich/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "Norwich EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/parmer/mainboard.c b/src/mainboard/amd/parmer/mainboard.c index 7c5dfc0..4b22214 100644 --- a/src/mainboard/amd/parmer/mainboard.c +++ b/src/mainboard/amd/parmer/mainboard.c @@ -32,7 +32,7 @@ /************************************************* * enable the dedicated function in parmer board. *************************************************/ -static void parmer_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); /* @@ -47,5 +47,5 @@ static void parmer_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = parmer_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/persimmon/mainboard.c b/src/mainboard/amd/persimmon/mainboard.c index 5edacd3..2f7cfd1 100644 --- a/src/mainboard/amd/persimmon/mainboard.c +++ b/src/mainboard/amd/persimmon/mainboard.c @@ -53,7 +53,7 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in persimmon board. *************************************************/ -static void persimmon_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -76,5 +76,5 @@ static void persimmon_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = persimmon_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/pistachio/mainboard.c b/src/mainboard/amd/pistachio/mainboard.c index f59e2bc..2b61ace 100644 --- a/src/mainboard/amd/pistachio/mainboard.c +++ b/src/mainboard/amd/pistachio/mainboard.c @@ -250,7 +250,7 @@ static void set_thermal_config(void) * enable the dedicated function in pistachio board. * This function called early than rs690_enable. *************************************************/ -static void pistachio_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard Pistachio Enable. dev=0x%p\n", dev); @@ -259,5 +259,5 @@ static void pistachio_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = pistachio_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/rumba/mainboard.c b/src/mainboard/amd/rumba/mainboard.c index 71d2d68..8c97109 100644 --- a/src/mainboard/amd/rumba/mainboard.c +++ b/src/mainboard/amd/rumba/mainboard.c @@ -27,12 +27,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "AMD RUMBA EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/south_station/mainboard.c b/src/mainboard/amd/south_station/mainboard.c index 5f31e03..b7d8bea 100644 --- a/src/mainboard/amd/south_station/mainboard.c +++ b/src/mainboard/amd/south_station/mainboard.c @@ -75,12 +75,12 @@ static void southstation_led_init(void) /************************************************* * enable the dedicated function in southstation board. *************************************************/ -static void southstation_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); southstation_led_init(); } struct chip_operations mainboard_ops = { - .enable_dev = southstation_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/thatcher/mainboard.c b/src/mainboard/amd/thatcher/mainboard.c index d1c389c..655ff31 100644 --- a/src/mainboard/amd/thatcher/mainboard.c +++ b/src/mainboard/amd/thatcher/mainboard.c @@ -32,7 +32,7 @@ /************************************************* * enable the dedicated function in thatcher board. *************************************************/ -static void thatcher_enable(device_t dev) +static void mainboard_enable(device_t dev) { msr_t msr; @@ -64,5 +64,5 @@ static void thatcher_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = thatcher_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/tilapia_fam10/mainboard.c b/src/mainboard/amd/tilapia_fam10/mainboard.c index 79fdbc2..f9598b9 100644 --- a/src/mainboard/amd/tilapia_fam10/mainboard.c +++ b/src/mainboard/amd/tilapia_fam10/mainboard.c @@ -273,7 +273,7 @@ static void set_thermal_config(void) * enable the dedicated function in tilapia board. * This function called early than rs780_enable. *************************************************/ -static void tilapia_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard TILAPIA Enable. dev=0x%p\n", dev); @@ -284,5 +284,5 @@ static void tilapia_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = tilapia_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/torpedo/mainboard.c b/src/mainboard/amd/torpedo/mainboard.c index d0f3f2b..b7a59a0 100644 --- a/src/mainboard/amd/torpedo/mainboard.c +++ b/src/mainboard/amd/torpedo/mainboard.c @@ -52,11 +52,11 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in torpedo board. *************************************************/ -static void torpedo_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable. dev=0x%p\n", dev); } struct chip_operations mainboard_ops = { - .enable_dev = torpedo_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/union_station/mainboard.c b/src/mainboard/amd/union_station/mainboard.c index 063f9b4..57dfe44 100644 --- a/src/mainboard/amd/union_station/mainboard.c +++ b/src/mainboard/amd/union_station/mainboard.c @@ -49,11 +49,11 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in unionstation board. *************************************************/ -static void unionstation_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = unionstation_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/artecgroup/dbe61/mainboard.c b/src/mainboard/artecgroup/dbe61/mainboard.c index 804b918..3ec3a7e 100644 --- a/src/mainboard/artecgroup/dbe61/mainboard.c +++ b/src/mainboard/artecgroup/dbe61/mainboard.c @@ -46,11 +46,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "ARTECGROUP DBE61 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asrock/939a785gmh/mainboard.c b/src/mainboard/asrock/939a785gmh/mainboard.c index d018696..8939957 100644 --- a/src/mainboard/asrock/939a785gmh/mainboard.c +++ b/src/mainboard/asrock/939a785gmh/mainboard.c @@ -95,7 +95,7 @@ u8 is_dev3_present(void) * enable the dedicated function in mahogany board. * This function called early than rs780_enable. *************************************************/ -static void mb_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard 939A785GMH/128M Enable. dev=0x%p\n", dev); @@ -104,7 +104,7 @@ static void mb_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = mb_enable, + .enable_dev = mainboard_enable, }; /* override the default SATA PHY setup */ diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c index a17778a..2bedff5 100644 --- a/src/mainboard/asrock/e350m1/mainboard.c +++ b/src/mainboard/asrock/e350m1/mainboard.c @@ -48,11 +48,11 @@ void set_pcie_dereset(void) /************************************************* * enable the dedicated function in e350m1 board. *************************************************/ -static void e350m1_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = e350m1_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asus/m4a78-em/mainboard.c b/src/mainboard/asus/m4a78-em/mainboard.c index 9b56277..096d6ba 100644 --- a/src/mainboard/asus/m4a78-em/mainboard.c +++ b/src/mainboard/asus/m4a78-em/mainboard.c @@ -118,7 +118,7 @@ u8 is_dev3_present(void) * enable the dedicated function in this board. * This function called early than rs780_enable. *************************************************/ -static void m4a78em_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard enable. dev=0x%p\n", dev); @@ -128,5 +128,5 @@ static void m4a78em_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = m4a78em_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asus/m4a785-m/mainboard.c b/src/mainboard/asus/m4a785-m/mainboard.c index a0b79fe..a36dce0 100644 --- a/src/mainboard/asus/m4a785-m/mainboard.c +++ b/src/mainboard/asus/m4a785-m/mainboard.c @@ -190,7 +190,7 @@ static void set_thermal_config(void) * enable the dedicated function in this board. * This function called early than rs780_enable. *************************************************/ -static void m4a785m_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard enable. dev=0x%p\n", dev); @@ -200,5 +200,5 @@ static void m4a785m_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = m4a785m_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/asus/m5a88-v/mainboard.c b/src/mainboard/asus/m5a88-v/mainboard.c index d1e530f..8a5e8a1 100644 --- a/src/mainboard/asus/m5a88-v/mainboard.c +++ b/src/mainboard/asus/m5a88-v/mainboard.c @@ -73,7 +73,7 @@ u8 is_dev3_present(void) * enable the dedicated function in M5A88-V board. * This function called early than rs780_enable. *************************************************/ -static void m5a88pm_v_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard ASUS M5A88-V Enable. dev=0x%p\n", dev); @@ -83,5 +83,5 @@ static void m5a88pm_v_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = m5a88pm_v_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/avalue/eax-785e/mainboard.c b/src/mainboard/avalue/eax-785e/mainboard.c index 631891f..f812137 100644 --- a/src/mainboard/avalue/eax-785e/mainboard.c +++ b/src/mainboard/avalue/eax-785e/mainboard.c @@ -73,7 +73,7 @@ u8 is_dev3_present(void) * enable the dedicated function in EAX-785E board. * This function called early than rs780_enable. *************************************************/ -static void eax_785e(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -82,5 +82,5 @@ static void eax_785e(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = eax_785e, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/bachmann/ot200/mainboard.c b/src/mainboard/bachmann/ot200/mainboard.c index 2b1fe83..f8aefec 100644 --- a/src/mainboard/bachmann/ot200/mainboard.c +++ b/src/mainboard/bachmann/ot200/mainboard.c @@ -65,11 +65,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "hw revision: %u\n", hw_rev); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/digitallogic/msm586seg/mainboard.c b/src/mainboard/digitallogic/msm586seg/mainboard.c index f2902c8..6cb5f07 100644 --- a/src/mainboard/digitallogic/msm586seg/mainboard.c +++ b/src/mainboard/digitallogic/msm586seg/mainboard.c @@ -31,7 +31,7 @@ static void irqdump(void) /* TODO: finish up mmcr struct in sc520.h, and; - set ADDDECTL (now done in raminit.c in cpu/amd/sc520 */ -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { //volatile struct mmcrpic *pic = MMCRPIC; volatile struct mmcr *mmcr = MMCRDEFAULT; @@ -129,6 +129,6 @@ static void enable_dev(struct device *dev) } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/digitallogic/msm800sev/mainboard.c b/src/mainboard/digitallogic/msm800sev/mainboard.c index 2b2b9fe..b8e3ba1 100644 --- a/src/mainboard/digitallogic/msm800sev/mainboard.c +++ b/src/mainboard/digitallogic/msm800sev/mainboard.c @@ -26,12 +26,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "MSM800SEV EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/emulation/qemu-armv7/mainboard.c b/src/mainboard/emulation/qemu-armv7/mainboard.c index cbc3197..603d00e 100644 --- a/src/mainboard/emulation/qemu-armv7/mainboard.c +++ b/src/mainboard/emulation/qemu-armv7/mainboard.c @@ -16,12 +16,12 @@ #include <console/console.h> #include <device/device.h> -static void enable_dev(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Enable qemu/armv7 device...\n"); } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/gigabyte/ma785gm/mainboard.c b/src/mainboard/gigabyte/ma785gm/mainboard.c index 3ce0db6..5b3a963 100644 --- a/src/mainboard/gigabyte/ma785gm/mainboard.c +++ b/src/mainboard/gigabyte/ma785gm/mainboard.c @@ -134,7 +134,7 @@ static void set_gpio40_gfx(void) * enable the dedicated function in ma785gm board. * This function called early than rs780_enable. *************************************************/ -static void ma785gm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MA785GM-US2H Enable. dev=0x%p\n", dev); @@ -144,5 +144,5 @@ static void ma785gm_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = ma785gm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/gigabyte/ma785gmt/mainboard.c b/src/mainboard/gigabyte/ma785gmt/mainboard.c index 8961bc8..7ed897f 100644 --- a/src/mainboard/gigabyte/ma785gmt/mainboard.c +++ b/src/mainboard/gigabyte/ma785gmt/mainboard.c @@ -244,7 +244,7 @@ static void set_thermal_config(void) * enable the dedicated function in ma785gmt board. * This function called early than rs780_enable. *************************************************/ -static void ma785gmt_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MA785GMT-UD2H Enable. dev=0x%p\n", dev); @@ -255,5 +255,5 @@ static void ma785gmt_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = ma785gmt_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/gigabyte/ma78gm/mainboard.c b/src/mainboard/gigabyte/ma78gm/mainboard.c index 9a8e5dc..5ac2420 100644 --- a/src/mainboard/gigabyte/ma78gm/mainboard.c +++ b/src/mainboard/gigabyte/ma78gm/mainboard.c @@ -71,7 +71,7 @@ u8 is_dev3_present(void) * enable the dedicated function in board. * This function called early than rs780_enable. *************************************************/ -static void ma78gm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard MA78GM-US2H Enable. dev=0x%p\n", dev); @@ -80,5 +80,5 @@ static void ma78gm_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = ma78gm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/iei/kino-780am2-fam10/mainboard.c b/src/mainboard/iei/kino-780am2-fam10/mainboard.c index a9458fd..27b0fe4 100644 --- a/src/mainboard/iei/kino-780am2-fam10/mainboard.c +++ b/src/mainboard/iei/kino-780am2-fam10/mainboard.c @@ -53,7 +53,7 @@ u8 is_dev3_present(void) * enable the dedicated function in kino board. * This function called early than rs780_enable. *************************************************/ -static void kino_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard Kino Enable. dev=0x%p\n", dev); @@ -62,5 +62,5 @@ static void kino_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = kino_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/iei/pm-lx2-800-r10/mainboard.c b/src/mainboard/iei/pm-lx2-800-r10/mainboard.c index 9ba687f..4af206b 100644 --- a/src/mainboard/iei/pm-lx2-800-r10/mainboard.c +++ b/src/mainboard/iei/pm-lx2-800-r10/mainboard.c @@ -41,12 +41,12 @@ static void init(struct device *dev) outb(inb(SCH3114_RTR_HWM_DAT) | 0x01, SCH3114_RTR_HWM_DAT); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { CHIP_NAME("IEI PM-LX2-800-R10 Mainboard") - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/jetway/pa78vm5/mainboard.c b/src/mainboard/jetway/pa78vm5/mainboard.c index 3cf1b0d..84f049a 100644 --- a/src/mainboard/jetway/pa78vm5/mainboard.c +++ b/src/mainboard/jetway/pa78vm5/mainboard.c @@ -100,7 +100,7 @@ u8 is_dev3_present(void) * enable the dedicated function in this board. * This function called early than rs780_enable. *************************************************/ -static void pa78vm5_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard PA78VM5 Enable. dev=0x%p\n", dev); @@ -109,5 +109,5 @@ static void pa78vm5_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = pa78vm5_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/kontron/kt690/mainboard.c b/src/mainboard/kontron/kt690/mainboard.c index 189b65c..bc5beee 100644 --- a/src/mainboard/kontron/kt690/mainboard.c +++ b/src/mainboard/kontron/kt690/mainboard.c @@ -180,7 +180,7 @@ static void set_thermal_config(void) * enable the dedicated function in dbm690t board. * This function called early than rs690_enable. *************************************************/ -static void kt690_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard KT690 Enable. dev=0x%p\n", dev); @@ -190,5 +190,5 @@ static void kt690_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = kt690_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/hurricane-lx/mainboard.c b/src/mainboard/lippert/hurricane-lx/mainboard.c index f13e48b..5b9100b 100644 --- a/src/mainboard/lippert/hurricane-lx/mainboard.c +++ b/src/mainboard/lippert/hurricane-lx/mainboard.c @@ -77,11 +77,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT Hurricane-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/literunner-lx/mainboard.c b/src/mainboard/lippert/literunner-lx/mainboard.c index c1b8fc2..c29098f 100644 --- a/src/mainboard/lippert/literunner-lx/mainboard.c +++ b/src/mainboard/lippert/literunner-lx/mainboard.c @@ -81,11 +81,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT LiteRunner-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/roadrunner-lx/mainboard.c b/src/mainboard/lippert/roadrunner-lx/mainboard.c index 22bcf43..93a7970 100644 --- a/src/mainboard/lippert/roadrunner-lx/mainboard.c +++ b/src/mainboard/lippert/roadrunner-lx/mainboard.c @@ -71,11 +71,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT RoadRunner-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/lippert/spacerunner-lx/mainboard.c b/src/mainboard/lippert/spacerunner-lx/mainboard.c index e2e6093..6da1485 100644 --- a/src/mainboard/lippert/spacerunner-lx/mainboard.c +++ b/src/mainboard/lippert/spacerunner-lx/mainboard.c @@ -76,11 +76,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "LiPPERT SpaceRunner-LX EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/pcengines/alix1c/mainboard.c b/src/mainboard/pcengines/alix1c/mainboard.c index 7dda79a..95335a7 100644 --- a/src/mainboard/pcengines/alix1c/mainboard.c +++ b/src/mainboard/pcengines/alix1c/mainboard.c @@ -26,12 +26,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "ALIX1.C EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/pcengines/alix2d/mainboard.c b/src/mainboard/pcengines/alix2d/mainboard.c index c60b134..1188a55 100644 --- a/src/mainboard/pcengines/alix2d/mainboard.c +++ b/src/mainboard/pcengines/alix2d/mainboard.c @@ -26,12 +26,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "ALIX.2D EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/siemens/sitemp_g1p1/mainboard.c b/src/mainboard/siemens/sitemp_g1p1/mainboard.c index a73fbd6..466b4a9 100644 --- a/src/mainboard/siemens/sitemp_g1p1/mainboard.c +++ b/src/mainboard/siemens/sitemp_g1p1/mainboard.c @@ -832,7 +832,7 @@ static void init(device_t dev) * enable the dedicated function in sina board. * This function called early than rs690_enable. *************************************************/ -static void enable_dev(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "%s %s[%x/%x] %s\n", @@ -849,5 +849,5 @@ static void enable_dev(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/supermicro/h8qgi/mainboard.c b/src/mainboard/supermicro/h8qgi/mainboard.c index 30695ff..aa855c8 100644 --- a/src/mainboard/supermicro/h8qgi/mainboard.c +++ b/src/mainboard/supermicro/h8qgi/mainboard.c @@ -65,11 +65,11 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in h8qgi board. *************************************************/ -static void h8qgi_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = h8qgi_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/supermicro/h8scm/mainboard.c b/src/mainboard/supermicro/h8scm/mainboard.c index 6c655f5..01edfe0 100644 --- a/src/mainboard/supermicro/h8scm/mainboard.c +++ b/src/mainboard/supermicro/h8scm/mainboard.c @@ -67,7 +67,7 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in h8scm board. *************************************************/ -static void h8scm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } @@ -80,5 +80,5 @@ int add_mainboard_resources(struct lb_memory *mem) #endif struct chip_operations mainboard_ops = { - .enable_dev = h8scm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/supermicro/h8scm_fam10/mainboard.c b/src/mainboard/supermicro/h8scm_fam10/mainboard.c index 5faca50..83b1957 100644 --- a/src/mainboard/supermicro/h8scm_fam10/mainboard.c +++ b/src/mainboard/supermicro/h8scm_fam10/mainboard.c @@ -69,7 +69,7 @@ void set_pcie_dereset(void) * enable the dedicated function in h8scm board. * This function called early than sr5650_enable. *************************************************/ -static void h8scm_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard H8SCM Enable. dev=0x%p\n", dev); @@ -92,5 +92,5 @@ static void h8scm_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = h8scm_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/technexion/tim5690/mainboard.c b/src/mainboard/technexion/tim5690/mainboard.c index 7974ce9..5be58cd 100644 --- a/src/mainboard/technexion/tim5690/mainboard.c +++ b/src/mainboard/technexion/tim5690/mainboard.c @@ -222,7 +222,7 @@ static void lcd_panel_id(rs690_vbios_regs *vbios_regs, u8 num_id) * enable the dedicated function in tim5690 board. * This function called early than rs690_enable. *************************************************/ -static void tim5690_enable(device_t dev) +static void mainboard_enable(device_t dev) { u16 gpio_base = IT8712F_SIMPLE_IO_BASE; #if CONFIG_VGA_ROM_RUN @@ -257,5 +257,5 @@ void mainboard_post(u8 value) } struct chip_operations mainboard_ops = { - .enable_dev = tim5690_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/technexion/tim8690/mainboard.c b/src/mainboard/technexion/tim8690/mainboard.c index 377cbd7..69788e9 100644 --- a/src/mainboard/technexion/tim8690/mainboard.c +++ b/src/mainboard/technexion/tim8690/mainboard.c @@ -140,7 +140,7 @@ static void set_thermal_config(void) * enable the dedicated function in tim8690 board. * This function called early than rs690_enable. *************************************************/ -static void tim8690_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard tim8690 Enable. dev=0x%p\n", dev); @@ -149,5 +149,5 @@ static void tim8690_enable(device_t dev) } struct chip_operations mainboard_ops = { - .enable_dev = tim8690_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/technologic/ts5300/mainboard.c b/src/mainboard/technologic/ts5300/mainboard.c index 1b7d023..c28cc4a 100644 --- a/src/mainboard/technologic/ts5300/mainboard.c +++ b/src/mainboard/technologic/ts5300/mainboard.c @@ -35,7 +35,7 @@ static void irqdump(void) /* TODO: finish up mmcr struct in sc520.h, and; - set ADDDECTL (now done in raminit.c in cpu/amd/sc520 */ -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { volatile struct mmcr *mmcr = MMCRDEFAULT; diff --git a/src/mainboard/traverse/geos/mainboard.c b/src/mainboard/traverse/geos/mainboard.c index 7bcc396..6980cda 100644 --- a/src/mainboard/traverse/geos/mainboard.c +++ b/src/mainboard/traverse/geos/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "Geos EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/tyan/s8226/mainboard.c b/src/mainboard/tyan/s8226/mainboard.c index b0d6b48..d9cacdc 100644 --- a/src/mainboard/tyan/s8226/mainboard.c +++ b/src/mainboard/tyan/s8226/mainboard.c @@ -67,11 +67,11 @@ void set_pcie_dereset(void *nbconfig) /************************************************* * enable the dedicated function in s8226 board. *************************************************/ -static void s8226_enable(device_t dev) +static void mainboard_enable(device_t dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); } struct chip_operations mainboard_ops = { - .enable_dev = s8226_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/winent/pl6064/mainboard.c b/src/mainboard/winent/pl6064/mainboard.c index 5fd83ed..1ddc110 100644 --- a/src/mainboard/winent/pl6064/mainboard.c +++ b/src/mainboard/winent/pl6064/mainboard.c @@ -26,11 +26,11 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "Win Enterprises PL-6064/65 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/wyse/s50/mainboard.c b/src/mainboard/wyse/s50/mainboard.c index 644a64e..ee92745 100644 --- a/src/mainboard/wyse/s50/mainboard.c +++ b/src/mainboard/wyse/s50/mainboard.c @@ -28,12 +28,12 @@ static void init(struct device *dev) printk(BIOS_DEBUG, "S50 EXIT %s\n", __func__); } -static void enable_dev(struct device *dev) +static void mainboard_enable(struct device *dev) { dev->ops->init = init; } struct chip_operations mainboard_ops = { - .enable_dev = enable_dev, + .enable_dev = mainboard_enable, };

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
79
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot February 2013