the following patch was just integrated into master:
commit f3eb6a951e47d12511cb50fb33a69b6d63bc96b7
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Sun Oct 7 14:56:22 2012 +0200
Fix typo in mPGA603 socket
Change-Id: I7a49d5fc13fb605a47c3c1662758ebd5935e7780
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Sun Oct 7 21:48:37 2012, giving +2
See http://review.coreboot.org/1564 for details.
-gerrit
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1539
-gerrit
commit b68f2bc158d91dbc60305c3d9375dff53a7ff4f4
Author: Patrick Georgi <patrick.georgi(a)secunet.com>
Date: Mon Sep 24 20:47:03 2012 +0200
libpayload: CMOS access was implemented in a backward way
Instead of having the highlevel functions make use of the lowlevel
functions, it implemented the lowlevel stuff in terms of highlevel.
Change-Id: I530bfe3cbc6f57a6294d86fbf1739e06467a2318
Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com>
---
payloads/libpayload/drivers/options.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c
index 7122464..d3ec137 100644
--- a/payloads/libpayload/drivers/options.c
+++ b/payloads/libpayload/drivers/options.c
@@ -158,13 +158,11 @@ static struct cb_cmos_entries *lookup_cmos_entry(struct cb_cmos_option_table *op
int len = name ? strnlen(name, CMOS_MAX_NAME_LENGTH) : 0;
/* cmos entries are located right after the option table */
-
- for ( cmos_entry = (struct cb_cmos_entries*)((unsigned char *)option_table + option_table->header_length);
- cmos_entry->tag == CB_TAG_OPTION;
- cmos_entry = (struct cb_cmos_entries*)((unsigned char *)cmos_entry + cmos_entry->size)) {
- if (memcmp((const char*)cmos_entry->name, name, len))
- continue;
- return cmos_entry;
+ cmos_entry = first_cmos_entry(option_table);
+ while (cmos_entry) {
+ if (memcmp((const char*)cmos_entry->name, name, len) == 0)
+ return cmos_entry;
+ cmos_entry = next_cmos_entry(cmos_entry);
}
printf("ERROR: No such CMOS option (%s)\n", name);
@@ -173,7 +171,7 @@ static struct cb_cmos_entries *lookup_cmos_entry(struct cb_cmos_option_table *op
struct cb_cmos_entries *first_cmos_entry(struct cb_cmos_option_table *option_table)
{
- return lookup_cmos_entry(option_table, NULL);
+ return (struct cb_cmos_entries*)((unsigned char *)option_table + option_table->header_length);
}
struct cb_cmos_entries *next_cmos_entry(struct cb_cmos_entries *cmos_entry)
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1565
-gerrit
commit f66a0861572e198bffa8a31af56871044ea81781
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Sun Oct 7 14:57:15 2012 +0200
Take care of NULL chip_ops->name
Change-Id: I62b1c497d23ec2241efb963e7834728085824016
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
src/arch/x86/boot/smbios.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/arch/x86/boot/smbios.c b/src/arch/x86/boot/smbios.c
index 8877f60..a171707 100644
--- a/src/arch/x86/boot/smbios.c
+++ b/src/arch/x86/boot/smbios.c
@@ -278,7 +278,8 @@ static int smbios_walk_device_tree(device_t tree, int *handle, unsigned long *cu
int len = 0;
for(dev = tree; dev; dev = dev->next) {
- printk(BIOS_INFO, "%s (%s)\n", dev_path(dev), dev->chip_ops ? dev->chip_ops->name : "");
+ printk(BIOS_INFO, "%s (%s)\n", dev_path(dev),
+ (dev->chip_ops && dev->chip_ops->name) ? dev->chip_ops->name : "");
if (dev->ops && dev->ops->get_smbios_data)
len += dev->ops->get_smbios_data(dev, handle, current);
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1563
-gerrit
commit 6e7892abf007fd9981449b9ec2f0f5980eab1850
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sun Oct 7 15:05:42 2012 +0200
abuild: allow building with no payload
Change-Id: I167f0bb57bb40f0426182c0abe868bdad58eb120
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/abuild/abuild | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 04b8e05..e625ee5 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -160,6 +160,8 @@ function create_config
exit 1
fi
printf "Using payload $PAYLOAD\n"
+ elif [ "$payloads" = "none" ]; then
+ PAYLOAD=none
fi
mkdir -p ${build_dir}
@@ -179,7 +181,9 @@ function create_config
grep "select[\t ]*ARCH" src/mainboard/$VENDOR/$MAINBOARD/Kconfig | \
sed "s,^.*\(ARCH_.*\)[^A-Z0-9_]*,CONFIG_\1=y," >> ${build_dir}/config.build
echo "CONFIG_MAINBOARD_DIR=\"$VENDOR/$MAINBOARD\"" >> ${build_dir}/config.build
- if [ "$PAYLOAD" != "/dev/null" ]; then
+ if [ "$PAYLOAD" = "none" ]; then
+ echo "CONFIG_PAYLOAD_NONE=y" >> ${build_dir}/config.build
+ elif [ "$PAYLOAD" != "/dev/null" ]; then
echo "# CONFIG_PAYLOAD_NONE is not set" >> ${build_dir}/config.build
echo "# CONFIG_PAYLOAD_SEABIOS is not set" >> ${build_dir}/config.build
echo "CONFIG_PAYLOAD_ELF=y" >> ${build_dir}/config.build
the following patch was just integrated into master:
commit 349f6614d89f7b0ff68c2057cd43953a74753b8f
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Fri Aug 24 21:54:10 2012 +0300
Remove chip.h files without config structure
Also deletes files not included in build:
src/southbridge/amd/cimx/sb700/chip_name.c
src/southbridge/amd/cimx/sb800/chip_name.c
src/southbridge/amd/cimx/sb900/chip_name.c
Change-Id: I2068e3859157b758ccea0ca91fa47d09a8639361
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
See http://review.coreboot.org/1473 for details.
-gerrit
the following patch was just integrated into master:
commit 33fc183e24db943bff249bca42cb8946e84ffd4a
Author: Kostr <aladyshev(a)nicevt.ru>
Date: Sat Oct 6 13:27:58 2012 +0400
Revert order in VGA device choice
Before change "Simplify VGA card discovery"
(http://review.coreboot.org/#/c/1255/)
coreboot was setting up VGA for the last found VGA device.
After this change it setting up VGA for the first found.
This change broke compatibility to my Supermicro H8QGI board.
Revert order back to old to save compatibility for this board
(and maybe any other boards)
Change-Id: Id5f2be60f95298059651c26133806e2694ff60aa
Signed-off-by: Kostr <aladyshev(a)nicevt.ru>
Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Sun Oct 7 07:24:57 2012, giving +2
See http://review.coreboot.org/1561 for details.
-gerrit