on 27/09/2012 01:01 Bernhard Urban said the following:
> hey Andriy,
>
> thanks for your patch! please submit it via gerrit, see
> http://www.coreboot.org/Git
It seems that the patch got committed while I was waiting for a weekend to come
to set up myself with gerrit. Which I did anyways :-)
Thank you very much!
>
> On Wed, Sep 26, 2012 at 10:49 PM, Andriy Gapon <avg(a)freebsd.org> wrote:
>>
>> Guys,
>>
>> It's been quite a while since I worked with any coreboot tools.
>> I see that a lot has changed...
>> I am posting a trivial FreeBSD-related patch here, but I am ready to follow the
>> proper way if you give me a kick towards it :-)
>> Thank you!
>>
>> diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile
>> index 41625d3..2388f4e 100644
>> --- a/util/superiotool/Makefile
>> +++ b/util/superiotool/Makefile
>> @@ -41,7 +41,7 @@ LIBS = -framework IOKit -framework DirectHW -lpci -lz
>> endif
>> ifeq ($(OS_ARCH), FreeBSD)
>> CFLAGS = -O2 -Wall -Werror -Wstrict-prototypes -Wundef -Wstrict-aliasing \
>> - -Werror-implicit-function-declaration -ansi $(SVNDEF) \
>> + -Werror-implicit-function-declaration -ansi $(VERSION) \
>> -I/usr/local/include
>> LDFLAGS += -L/usr/local/lib
>> LIBS = -lz
>>
>> --
>> Andriy Gapon
>>
>>
>> --
>> coreboot mailing list: coreboot(a)coreboot.org
>> http://www.coreboot.org/mailman/listinfo/coreboot
--
Andriy Gapon
Aladyshev Konstantin (kostr(a)list.ru) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1561
-gerrit
commit 33fc183e24db943bff249bca42cb8946e84ffd4a
Author: Kostr <aladyshev(a)nicevt.ru>
Date: Sat Oct 6 13:27:58 2012 +0400
Revert order in VGA device choice
Before change "Simplify VGA card discovery"
(http://review.coreboot.org/#/c/1255/)
coreboot was setting up VGA for the last found VGA device.
After this change it setting up VGA for the first found.
This change broke compatibility to my Supermicro H8QGI board.
Revert order back to old to save compatibility for this board
(and maybe any other boards)
Change-Id: Id5f2be60f95298059651c26133806e2694ff60aa
Signed-off-by: Kostr <aladyshev(a)nicevt.ru>
---
src/devices/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/devices/device.c b/src/devices/device.c
index 6b1902d..f021c9b 100644
--- a/src/devices/device.c
+++ b/src/devices/device.c
@@ -732,7 +732,7 @@ static void set_vga_bridge_bits(void)
if (dev->on_mainboard) {
vga_onboard = dev;
- } else if (!vga) {
+ } else {
vga = dev;
}
the following patch was just integrated into master:
commit 18ae0cc9515987ce5725185f6b7f99fd0d9a3a2b
Author: Kostr <aladyshev(a)nicevt.ru>
Date: Wed Sep 26 22:11:20 2012 +0400
Mainboard: Fix IO-HUB link number in Dinar mainboard
According to file "northbridge.c" in family 15h code
IO-HUB should be placed on link_lsit[0] in devicetree.cb.
This hack in "northbridge.c" was made to satisfy both f10 and f15 cpu's.
Change-Id: I4754235bd38239460347b0dc4a82cd4e58ae7cd0
Signed-off-by: Kostr <aladyshev(a)nicevt.ru>
Build-Tested: build bot (Jenkins) at Wed Sep 26 20:53:59 2012, giving +1
See http://review.coreboot.org/1540 for details.
-gerrit
the following patch was just integrated into master:
commit cedbdcdae7f045dc2b69da8b224298f70254db35
Author: Zheng Bao <fishbaozi(a)gmail.com>
Date: Fri Sep 28 20:14:38 2012 +0800
lint: Get absolute path in compare_output
The classes in $(top)/Makefile uses $(abspath) to get the path.
The $(abspath) can not resolve symlink. If the coreboot is located
in a symlink directory, the run_printall produces the absolute
path while the $PWD just produces the path with symlink. Use
`pwd -P` to get the abs path.
Change-Id: Icf6b364d030c14a9c78991767b17dafc701baf3c
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
Build-Tested: build bot (Jenkins) at Fri Sep 28 13:09:30 2012, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Thu Oct 4 22:37:17 2012, giving +2
See http://review.coreboot.org/1551 for details.
-gerrit
the following patch was just integrated into master:
commit 508fd0158780293264c0ad879b6b34d3c6cd686f
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Fri Aug 17 15:57:36 2012 +0200
Provide access to smaller registers in eregs
This is in preparation for sharing interrupt handlers
between YABEL and x86emu.
Change-Id: Iff92c1d899b8ada20972731944341805a49b6326
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Build-Tested: build bot (Jenkins) at Fri Oct 5 20:46:43 2012, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Fri Oct 5 22:05:42 2012, giving +2
See http://review.coreboot.org/1560 for details.
-gerrit
the following patch was just integrated into master:
commit 06e13f36b86b27f20569f71403f95a359f2931b1
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sun Sep 23 18:41:03 2012 +0200
Use mainboard_interrupt_handlers everywhere
The previous commit provides a mainboard_interrupt_handlers
implementation YABEL with identical semantics to the
x86emu one, so let's use it in both cases.
This eliminates the need for the int15_install()
indirection, so let's drop that, too.
Generated using the following coccinelle patch and
manual cleanups (empty #if/#endif):
@@
type T;
identifier FUNCARR;
expression INT, HANDLER;
@@
-typedef T yabel_handleIntFunc;
-extern yabel_handleIntFunc FUNCARR[256];
-FUNCARR[INT] = HANDLER;
+mainboard_interrupt_handlers(INT, &HANDLER);
@@
@@
-void int15_install(void)
-{
-mainboard_interrupt_handlers(0x15, &int15_handler);
-}
@@
@@
-void int15_install(void)
-{
-mainboard_interrupt_handlers(0x15, &int15_handler); ... mainboard_interrupt_handlers(0x15, &int15_handler);
-}
@@
@@
-int15_install();
+mainboard_interrupt_handlers(0x15, &int15_handler);
Change-Id: I70fd780d7ebf1564a2ff7d7148411673f6de113c
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Build-Tested: build bot (Jenkins) at Fri Oct 5 20:32:50 2012, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Fri Oct 5 22:04:52 2012, giving +2
See http://review.coreboot.org/1559 for details.
-gerrit
the following patch was just integrated into master:
commit 6ad96a0dcb78119b2faeb821976247642bef0a7d
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Thu Aug 16 15:39:35 2012 +0200
YABEL: Common API to register interrupt handlers
Provide (mostly) the same API for registering
interrupt handlers as with x86emu.
Change-Id: I1364b08d9043039550786a1758508ae088813aa3
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Build-Tested: build bot (Jenkins) at Fri Oct 5 20:15:21 2012, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Fri Oct 5 22:02:59 2012, giving +2
See http://review.coreboot.org/1558 for details.
-gerrit
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1558
-gerrit
commit 6ad96a0dcb78119b2faeb821976247642bef0a7d
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Thu Aug 16 15:39:35 2012 +0200
YABEL: Common API to register interrupt handlers
Provide (mostly) the same API for registering
interrupt handlers as with x86emu.
Change-Id: I1364b08d9043039550786a1758508ae088813aa3
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
src/devices/oprom/yabel/biosemu.c | 6 ++++++
src/devices/oprom/yabel/biosemu.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/devices/oprom/yabel/biosemu.c b/src/devices/oprom/yabel/biosemu.c
index 8d77959..2a2ca31 100644
--- a/src/devices/oprom/yabel/biosemu.c
+++ b/src/devices/oprom/yabel/biosemu.c
@@ -44,6 +44,12 @@ static X86EMU_pioFuncs my_pio_funcs = {
/* interrupt function override array (see biosemu.h) */
yabel_handleIntFunc yabel_intFuncArray[256];
+void
+mainboard_interrupt_handlers(int interrupt, yabel_handleIntFunc func)
+{
+ yabel_intFuncArray[interrupt] = func;
+}
+
/* main entry into YABEL biosemu, arguments are:
* *biosmem = pointer to virtual memory
* biosmem_size = size of the virtual memory
diff --git a/src/devices/oprom/yabel/biosemu.h b/src/devices/oprom/yabel/biosemu.h
index 39cc0a9..4f5c4aa 100644
--- a/src/devices/oprom/yabel/biosemu.h
+++ b/src/devices/oprom/yabel/biosemu.h
@@ -45,6 +45,7 @@
* the function pointer is NULL */
typedef int (* yabel_handleIntFunc)(void);
extern yabel_handleIntFunc yabel_intFuncArray[256];
+void mainboard_interrupt_handlers(int, yabel_handleIntFunc);
struct device;