coreboot January 2012

coreboot@coreboot.org

40 participants
302 discussions

Patch set updated for coreboot: 7c356b3 ACPI: mark empty get_cst_entries() weak
by Patrick Georgi 07 Jan '12

07 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/496 -gerrit commit 7c356b38ef762b2187f7f81e7c990d8409fadd14 Author: Sven Schnelle <svens(a)stackframe.org> Date: Fri Dec 23 10:29:09 2011 +0100 ACPI: mark empty get_cst_entries() weak This function prevents the linker from choosing the right get_cst_entries(), preventing writing the _CST tables. Change-Id: I4bc0168aee110171faeaa081f217dfd1536bb821 Signed-off-by: Sven Schnelle <svens(a)stackframe.org> Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/cpu/intel/speedstep/acpi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c index 8f32e4f..00c4ae9 100644 --- a/src/cpu/intel/speedstep/acpi.c +++ b/src/cpu/intel/speedstep/acpi.c @@ -62,7 +62,7 @@ static int get_fsb(void) return 200; } -int get_cst_entries(struct cst_entry **entries __attribute__((unused))) +int __attribute__((weak)) get_cst_entries(struct cst_entry **entries __attribute__((unused))) { return 0; }

1 0

Patch merged into coreboot/master: 08f0b18 Eliminate magic numbers
by gerrit＠coreboot.org 07 Jan '12

07 Jan '12

the following patch was just integrated into master: commit 08f0b180fe0d7a29a9f4608d536dcc2ce268a7f1 Author: Philip Prindeville <philipp(a)redfish-solutions.com> Date: Fri Dec 23 18:45:33 2011 -0700 Eliminate magic numbers Use sizeof() on vendor and part# rather than explicit memory length. Change-Id: I2b7e0e4a8df6448d027cc61867382f161eb990d3 Signed-off-by: Philip Prindeville <philipp(a)redfish-solutions.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Sat Jan 7 11:50:15 2012, giving +2 See http://review.coreboot.org/504 for details. -gerrit

1 0

Patch merged into coreboot/master: 9f1890a Cleanup access to vendor/part # info
by gerrit＠coreboot.org 07 Jan '12

07 Jan '12

the following patch was just integrated into master: commit 9f1890a5a3ee76dee75f5c356166c0c6b513b7a3 Author: Philip Prindeville <philipp(a)redfish-solutions.com> Date: Sat Dec 24 22:12:37 2011 -0700 Cleanup access to vendor/part # info Instead of macros to access MAINBOARD record, use convenience functions. Store pointers to MAINBOARD and HEADER for use outside of CB code. Change-Id: I074e3a0df7d25726cbd942538bfdc5a63dd17e12 Signed-off-by: Philip Prindeville <philipp(a)redfish-solutions.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Sat Jan 7 11:49:56 2012, giving +2 See http://review.coreboot.org/502 for details. -gerrit

1 0

Patch merged into coreboot/master: a96e8b2 Update geode GX2 tree to match LX.
by gerrit＠coreboot.org 07 Jan '12

07 Jan '12

the following patch was just integrated into master: commit a96e8b2fffb58aa393ad0455f29df8737e2adbcf Author: Nils Jacobs <njacobs8(a)adsltotaal.nl> Date: Fri Dec 30 23:00:11 2011 +0100 Update geode GX2 tree to match LX. Change-Id: I5b99c531e44ea09990b9da0b97213fb7945f34ee Signed-off-by: Nils Jacobs <njacobs8(a)adsltotaal.nl> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Sat Jan 7 11:46:49 2012, giving +2 See http://review.coreboot.org/512 for details. -gerrit

1 0

New patch to review for coreboot: 9faab44 adm1027: add return statement
by Vikram Narayanan 07 Jan '12

07 Jan '12

Vikram Narayanan (vikram186(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/522 -gerrit commit 9faab4477efb6d0102c9854dcc1ecd3f1cac6421 Author: Vikram Narayanan <vikram186(a)gmail.com> Date: Sat Jan 7 16:04:46 2012 +0530 adm1027: add return statement Adds a missing return statment which will stop misleading the users Change-Id: I53741f1136b396e9493ce959b54efc00c9b09764 Signed-off-by: Vikram Narayanan <vikram186(a)gmail.com> --- src/drivers/i2c/adm1027/adm1027.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/drivers/i2c/adm1027/adm1027.c b/src/drivers/i2c/adm1027/adm1027.c index 516a889..e97ec69 100644 --- a/src/drivers/i2c/adm1027/adm1027.c +++ b/src/drivers/i2c/adm1027/adm1027.c @@ -35,6 +35,7 @@ static void adm1027_enable_monitoring(device_t dev) result = smbus_read_byte(dev, ADM1027_REG_CONFIG1); if (!(result & CFG1_STRT)) { printk(BIOS_DEBUG, "ADM1027: monitoring would not enable\n"); + return; } printk(BIOS_DEBUG, "ADM1027: monitoring enabled\n"); }

1 0

Patch set updated for coreboot: 9f1890a Cleanup access to vendor/part # info
by Patrick Georgi 07 Jan '12

07 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/502 -gerrit commit 9f1890a5a3ee76dee75f5c356166c0c6b513b7a3 Author: Philip Prindeville <philipp(a)redfish-solutions.com> Date: Sat Dec 24 22:12:37 2011 -0700 Cleanup access to vendor/part # info Instead of macros to access MAINBOARD record, use convenience functions. Store pointers to MAINBOARD and HEADER for use outside of CB code. Change-Id: I074e3a0df7d25726cbd942538bfdc5a63dd17e12 Signed-off-by: Philip Prindeville <philipp(a)redfish-solutions.com> --- payloads/coreinfo/coreboot_module.c | 4 ++-- payloads/libpayload/arch/i386/coreboot.c | 5 +++++ payloads/libpayload/include/coreboot_tables.h | 16 ++++++++++------ payloads/libpayload/include/sysinfo.h | 3 +++ 4 files changed, 20 insertions(+), 8 deletions(-) diff --git a/payloads/coreinfo/coreboot_module.c b/payloads/coreinfo/coreboot_module.c index 7289366..d33ea9e 100644 --- a/payloads/coreinfo/coreboot_module.c +++ b/payloads/coreinfo/coreboot_module.c @@ -142,8 +142,8 @@ static void parse_mainboard(unsigned char *ptr) { struct cb_mainboard *mb = (struct cb_mainboard *)ptr; - strncpy(cb_info.vendor, (const char *)MB_VENDOR_STRING(mb), 31); - strncpy(cb_info.part, (const char *)MB_PART_STRING(mb), 31); + strncpy(cb_info.vendor, cb_mb_vendor_part(mb), 31); + strncpy(cb_info.part, cb_mb_part_string(mb), 31); } static void parse_strings(unsigned char *ptr) diff --git a/payloads/libpayload/arch/i386/coreboot.c b/payloads/libpayload/arch/i386/coreboot.c index 709f8ae..06acc17 100644 --- a/payloads/libpayload/arch/i386/coreboot.c +++ b/payloads/libpayload/arch/i386/coreboot.c @@ -137,6 +137,8 @@ static int cb_parse_header(void *addr, int len, struct sysinfo_t *info) header->table_bytes) != header->table_checksum) return -1; + info->header = header; + /* Now, walk the tables. */ ptr += header->header_bytes; @@ -173,6 +175,9 @@ static int cb_parse_header(void *addr, int len, struct sysinfo_t *info) cb_parse_framebuffer(ptr, info); break; #endif + case CB_TAG_MAINBOARD: + info->mainboard = (struct cb_mainboard *)ptr; + break; } ptr += rec->size; diff --git a/payloads/libpayload/include/coreboot_tables.h b/payloads/libpayload/include/coreboot_tables.h index e362d06..c68ccc9 100644 --- a/payloads/libpayload/include/coreboot_tables.h +++ b/payloads/libpayload/include/coreboot_tables.h @@ -228,6 +228,16 @@ static inline u16 cb_checksum(const void *ptr, unsigned len) return ipchksum(ptr, len); } +static inline const char *cb_mb_vendor_string(const struct cb_mainboard *cbm) +{ + return (char *)(cbm->strings + cbm->vendor_idx); +} + +static inline const char *cb_mb_part_string(const struct cb_mainboard *cbm) +{ + return (char *)(cbm->strings + cbm->part_number_idx); +} + /* Helpful macros */ #define MEM_RANGE_COUNT(_rec) \ @@ -237,10 +247,4 @@ static inline u16 cb_checksum(const void *ptr, unsigned len) (void *)(((u8 *) (_rec)) + sizeof(*(_rec)) \ + (sizeof((_rec)->map[0]) * (_idx))) -#define MB_VENDOR_STRING(_mb) \ - (((unsigned char *) ((_mb)->strings)) + (_mb)->vendor_idx) - -#define MB_PART_STRING(_mb) \ - (((unsigned char *) ((_mb)->strings)) + (_mb)->part_number_idx) - #endif diff --git a/payloads/libpayload/include/sysinfo.h b/payloads/libpayload/include/sysinfo.h index c1d2002..778dfe9 100644 --- a/payloads/libpayload/include/sysinfo.h +++ b/payloads/libpayload/include/sysinfo.h @@ -56,6 +56,9 @@ struct sysinfo_t { struct cb_framebuffer *framebuffer; unsigned long *mbtable; /** Pointer to the multiboot table */ + + struct cb_header *header; + struct cb_mainboard *mainboard; }; extern struct sysinfo_t lib_sysinfo;

1 0

Patch set updated for coreboot: 08f0b18 Eliminate magic numbers
by Patrick Georgi 07 Jan '12

07 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/504 -gerrit commit 08f0b180fe0d7a29a9f4608d536dcc2ce268a7f1 Author: Philip Prindeville <philipp(a)redfish-solutions.com> Date: Fri Dec 23 18:45:33 2011 -0700 Eliminate magic numbers Use sizeof() on vendor and part# rather than explicit memory length. Change-Id: I2b7e0e4a8df6448d027cc61867382f161eb990d3 Signed-off-by: Philip Prindeville <philipp(a)redfish-solutions.com> --- payloads/coreinfo/coreboot_module.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/payloads/coreinfo/coreboot_module.c b/payloads/coreinfo/coreboot_module.c index d33ea9e..77a4bb2 100644 --- a/payloads/coreinfo/coreboot_module.c +++ b/payloads/coreinfo/coreboot_module.c @@ -142,8 +142,8 @@ static void parse_mainboard(unsigned char *ptr) { struct cb_mainboard *mb = (struct cb_mainboard *)ptr; - strncpy(cb_info.vendor, cb_mb_vendor_part(mb), 31); - strncpy(cb_info.part, cb_mb_part_string(mb), 31); + strncpy(cb_info.vendor, cb_mb_vendor_part(mb), sizeof(cb_info.vendor) - 1); + strncpy(cb_info.part, cb_mb_part_string(mb), sizeof(cb_info.part) - 1); } static void parse_strings(unsigned char *ptr)

1 0

Re: [coreboot] tiny bootblock problem
by Nils 06 Jan '12

06 Jan '12

Patrick Georgi wrote: >> Correct me if i'm wrong but Geode GX2/LX doesn't have MTRRs. >> Cache is setup via MSR registers. >MTRR is usually configured via MSR (0x200 to 0x210, specifically). Not >sure if Geode does it the same way, but MSR doesn't mean "no MTRR". See attachment for part of page 494 of the GX2 databook.:) Philip Prindeville wrote: >Caching is bits 30:29 of CR0. There are actually a lot more MSR registers for defining cache regions. Thanks, Nils.

2 1

Re: [coreboot] tiny bootblock problem
by Nils 06 Jan '12

06 Jan '12

Patrick Georgi: >> Is that a caching problem introduced by tiny bootblock? >> What is needed to get it right? >Probably MTRRs. With tinybootblock, these are set at slightly >different times. >GX2 uses Cache-As-RAM, right? That affects MTRRs, too (as CAR is a >"special" MTRR setup) Correct me if i'm wrong but Geode GX2/LX doesn't have MTRRs. Cache is setup via MSR registers. So all that MTRR stuf in tiny bootblok/coreboot is useless to Geode. Which regions are used for tiny bootblock that need caching? If no one beets me i will investigate this further after SeaBIOS Geode VGA is ready. Philip Prindeville wrote: >Also, the Alix 6F2 doesn't have a keyboard controller... is there a way >to turn off the i8042 stuff? Those i8042 warning at the beginning before warm reset comes from SeaBIOS. There is a SeaBIOS kconfig option to turn off the ps2 controller. Greetings, Nils.

4 3

Patch set updated for coreboot: f922ea5 alix2: add support for alix6
by Philip Prindeville 06 Jan '12

06 Jan '12

Philip Prindeville (pprindeville(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/521 -gerrit commit f922ea58e916be60c163a1d83616314d4acfea56 Author: Philip Prindeville <philipp(a)redfish-solutions.com> Date: Fri Jan 6 11:54:23 2012 -0700 alix2: add support for alix6 The Alix6 is very similar to the alix2, differing in having 1 mini-PCIe slot (USB 2.0 only), an RFKILL GPIO line going to that slot, and 1 or 2 SIM sockets. Change-Id: I19e4e756966e60bb0310c19286654d3d579b8850 Signed-off-by: Philip Prindeville <philipp(a)redfish-solutions.com> --- src/mainboard/pcengines/Kconfig | 2 ++ src/mainboard/pcengines/alix2d/Kconfig | 9 ++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/mainboard/pcengines/Kconfig b/src/mainboard/pcengines/Kconfig index d5d7008..d8a0201 100644 --- a/src/mainboard/pcengines/Kconfig +++ b/src/mainboard/pcengines/Kconfig @@ -7,6 +7,8 @@ config BOARD_PCENGINES_ALIX1C bool "ALIX.1C" config BOARD_PCENGINES_ALIX2D bool "ALIX.2D2 or 2D3" +config BOARD_PCENGINES_ALIX6 + bool "ALIX.6" endchoice diff --git a/src/mainboard/pcengines/alix2d/Kconfig b/src/mainboard/pcengines/alix2d/Kconfig index ea02adf..5036dcb 100644 --- a/src/mainboard/pcengines/alix2d/Kconfig +++ b/src/mainboard/pcengines/alix2d/Kconfig @@ -1,4 +1,4 @@ -if BOARD_PCENGINES_ALIX2D +if BOARD_PCENGINES_ALIX2D || BOARD_PCENGINES_ALIX6 config BOARD_SPECIFIC_OPTIONS # dummy def_bool y @@ -12,6 +12,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_512 select POWER_BUTTON_FORCE_DISABLE select CONSOLE_SERIAL_38400 + select GEODE_VSA + select GEODE_VSA_FILE config MAINBOARD_DIR string @@ -19,10 +21,11 @@ config MAINBOARD_DIR config MAINBOARD_PART_NUMBER string - default "ALIX.2D" + default "ALIX.2D" if BOARD_PCENGINES_ALIX2D + default "ALIX.6" if BOARD_PCENGINES_ALIX6 config IRQ_SLOT_COUNT int default 7 -endif # BOARD_PCENGINES_ALIX2D +endif # BOARD_PCENGINES_ALIX2D || BOARD_PCENGINES_ALIX6

1 0

← Newer
1
...
23
24
25
26
27
28
29
30
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2012