coreboot March 2012

coreboot@coreboot.org

58 participants
718 discussions

New patch to review for coreboot: b845313 malloc: size is unsigned, don't test for size < 0
by Patrick Georgi 11 Mar '12

11 Mar '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/780 -gerrit commit b84531374751d8679d28657935ed3860a4b3851f Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Mar 11 19:30:36 2012 +0100 malloc: size is unsigned, don't test for size < 0 clang complains Change-Id: Ifadf73cf377c0d1808e20731803e01101bad7e1d Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/lib/malloc.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/lib/malloc.c b/src/lib/malloc.c index 3cedc8f..c10750d 100644 --- a/src/lib/malloc.c +++ b/src/lib/malloc.c @@ -17,10 +17,6 @@ void *malloc(size_t size) MALLOCDBG("%s Enter, size %ld, free_mem_ptr %p\n", __func__, size, free_mem_ptr); - /* Checking arguments */ - if (size < 0) - die("Error! malloc: size < 0"); - /* Overzealous linker check */ if (free_mem_ptr <= 0) die("Error! malloc: Free_mem_ptr <= 0");

1 0

New patch to review for coreboot: 862ca8e Use search path when building dependencies
by Patrick Georgi 11 Mar '12

11 Mar '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/779 -gerrit commit 862ca8e2de77e08ddbf52e8abb68f6dcc67a6df6 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Mar 11 19:29:46 2012 +0100 Use search path when building dependencies clang is more picky on that. Change-Id: Iaa8472beb6e275c39037d11e1a72dbb80d46424b Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/arch/x86/Makefile.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 624b510..4f76bd0 100755 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -326,7 +326,7 @@ $(obj)/mainboard/$(MAINBOARDDIR)/bootblock.s: $(obj)/bootblock/bootblock.S $(obj $(obj)/mainboard/$(MAINBOARDDIR)/bootblock.inc: $(src)/arch/x86/init/$(subst ",,$(CONFIG_BOOTBLOCK_SOURCE)) $(objutil)/romcc/romcc $(OPTION_TABLE_H) @printf " ROMCC $(subst $(obj)/,,$(@))\n" - $(CC) -MM -MT$(obj)/mainboard/$(MAINBOARDDIR)/bootblock.inc \ + $(CC) $(INCLUDES) -MM -MT$(obj)/mainboard/$(MAINBOARDDIR)/bootblock.inc \ $< > $(obj)/mainboard/$(MAINBOARDDIR)/bootblock.inc.d $(ROMCC) -c -S $(bootblock_romccflags) $(ROMCCFLAGS) -I. $(INCLUDES) $< -o $@

1 0

Re: [coreboot] separate mailling list for gerrit mails?
by Paul Menzel 11 Mar '12

11 Mar '12

Dear coreboot folks, Am Sonntag, den 11.03.2012, 18:47 +0100 schrieb Bernhard Urban: > I'm fine with the current setting. me too. Subscribers should be fine because they can use filters. The Mailman archive would be the only problem regarding the overview. Either way, we should wait a bit more if the patch submissions increase. Last two(?) weeks were an exceptions regarding the Gerrit traffic. > Talking about gerrit: I think it would be nice to have an additional > diff to the previous patchset in those "Patch Set updated..." mails. > Is this easily doable? I second that. That would be great. Additionally I would also like to see the review comments forwarded to the list. Thanks, Paul

1 0

OT: how to burn commercial BIOS image into new chip?
by Jonathan Sturges 11 Mar '12

11 Mar '12

Hi list, Question for everyone. I have a system, System A, that is very similar to System B. System A comes with a WinCE BIOS, but I have a binary Award BIOS image from System B that I wish to test on System A. The flash parts from both systems are the same size. Is there some secret to burning a binary BIOS image file into a new, blank flash chip? I burned the image to a chip, but the system does nothing when powered on. What am I missing? thanks!

1 0

Re: [coreboot] separate mailling list for gerrit mails?
by Bernhard Urban 11 Mar '12

11 Mar '12

hi, I'm fine with the current setting. Talking about gerrit: I think it would be nice to have an additional diff to the previous patchset in those "Patch Set updated..." mails. Is this easily doable? regards, bernhard On Sun, Mar 11, 2012 at 12:17 AM, Gregg Levine <gregg.drwho8(a)gmail.com> wrote: > On Sat, Mar 10, 2012 at 3:04 PM, Patrick Georgi <patrick(a)georgi-clan.de> wrote: >> Hi, >> >> this came up on IRC again, but I think the issue requires wider discussion: >> Several people asked if gerrit mails can be moved to a separate mailing >> list to reduce the "mechanic" noise. >> >> We're highly flexible there, so we can keep it like it is, reduce the >> number of mail types, send different types to different lists, ... >> >> One proposal was to move all gerrit mail to coreboot-gerrit@ or so. >> A variant of that could be to move all gerrit mail to coreboot-gerrit@ >> except for the "change merged to master" mails, so people have an easier >> overview on what happens in our main branch. >> >> So asking generally: Do you like it the way it is, or do you think it >> should change, and how? >> >> >> Patrick >> >> -- >> coreboot mailing list: coreboot(a)coreboot.org >> http://www.coreboot.org/mailman/listinfo/coreboot > > Hello! > No problems here. It actually does not matter to me. > ----- > Gregg C Levine gregg.drwho8(a)gmail.com > "This signature fought the Time Wars, time and again." > > -- > coreboot mailing list: coreboot(a)coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot

1 0

Patch merged into coreboot/master: c088e19 mainboard/aopen/Kconfig: remove extra whitespace
by gerrit＠coreboot.org 11 Mar '12

11 Mar '12

the following patch was just integrated into master: commit c088e191cb670bf31f5f92ac718103cadfdc2aa7 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Fri Mar 9 23:03:01 2012 +0100 mainboard/aopen/Kconfig: remove extra whitespace Change-Id: I69ee67c35113d98e034bdccf5d00e8452d3d9bd2 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Build-Tested: build bot (Jenkins) at Sat Mar 10 06:32:17 2012, giving +1 Reviewed-By: Rudolf Marek <r.marek(a)assembler.cz> at Sun Mar 11 17:50:27 2012, giving +2 See http://review.coreboot.org/778 for details. -gerrit

1 0

Re: [coreboot] [SeaBIOS] Linux-ready Firmware Kit
by Gleb Natapov 11 Mar '12

11 Mar '12

On Sun, Mar 11, 2012 at 04:28:38PM +0100, Fred . wrote: > Linux-ready Firmware Development Kit r3 segfaults under QEMU 0.14.1 > (Ubuntu 11.10 Oneiric) during the SUN duplicate test at 30% with the > message: > Segmentation fault (core dumped) plugins//acpicompile.exe 2>. > What about more recent qemu? 1.0? > On Tue, Mar 6, 2012 at 4:04 AM, Peter Stuge <peter(a)stuge.se> wrote: > > Fred . wrote: > >> Intel provides a Linux-ready Firmware Kit > > > > This is well-known in the community since many years. > > > > If you want to contribute then please *USE* the software and either > > just report results, or even better send fixes for any problems which > > are found. > > > > As you know, you can do limited testing completely using software. > > > > > > //Peter > > > > _______________________________________________ > > SeaBIOS mailing list > > SeaBIOS(a)seabios.org > > http://www.seabios.org/mailman/listinfo/seabios > > _______________________________________________ > SeaBIOS mailing list > SeaBIOS(a)seabios.org > http://www.seabios.org/mailman/listinfo/seabios -- Gleb.

1 0

Re: [coreboot] Linux-ready Firmware Kit
by Peter Stuge 11 Mar '12

11 Mar '12

Fred . wrote: > Intel provides a Linux-ready Firmware Kit This is well-known in the community since many years. If you want to contribute then please *USE* the software and either just report results, or even better send fixes for any problems which are found. As you know, you can do limited testing completely using software. //Peter

2 1

Patch set updated for coreboot: 7086a90 abuild: Build boards in parallel if possible
by Patrick Georgi 11 Mar '12

11 Mar '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/409 -gerrit commit 7086a908076b3dae6016058eaaebf214d18b2c5b Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat Nov 5 14:44:41 2011 +0100 abuild: Build boards in parallel if possible Determine if xargs -P works. If yes, use that to build multiple boards in parallel, instead of relying on make -j X, when doing a full abuild run (instead of single boards). make -j X isn't able to make use of several cores at various serialization points in our build process, so this change results in a >25% speed up for a full abuild run in my tests. Change-Id: Id484a4211c84a3a24115278e0fbe92345f346596 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile.inc | 2 + util/abuild/abuild | 69 ++++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 55 insertions(+), 16 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 86a072a..6ae1c74 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -251,3 +251,5 @@ crosstools: clean-for-update crossgcc-clean: clean-for-update $(MAKE) -C util/crossgcc clean +tools: $(objutil)/kconfig/conf $(objutil)/cbfstool/cbfstool $(objutil)/options/build_opt_tbl $(objutil)/romcc/romcc $(objutil)/sconfig/sconfig + diff --git a/util/abuild/abuild b/util/abuild/abuild index 74d2908..51cf554 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -563,6 +563,9 @@ test -f util/sconfig/sconfig.l && ROOT=$( pwd ) test -f ../util/sconfig/sconfig.l && ROOT=$( cd ..; pwd ) test "$ROOT" = "" && ROOT=$( cd ../..; pwd ) +# command line for xargs parallelization. Thus overwrite -c X +cmdline="$* -c 1" + # parse parameters.. try to find out whether we're running GNU getopt getoptbrand="`getopt -V`" if [ "${getoptbrand:0:6}" == "getopt" ]; then @@ -607,8 +610,44 @@ while true ; do esac done +USE_XARGS=0 if [ "$cpus" != "1" ]; then - export MAKEFLAGS="-j $cpus" + if [ "$target" = "" ]; then + # Test if xargs supports the non-standard -P flag + echo | xargs -P 0$cpus -n 1 echo 2>/dev/null >/dev/null && USE_XARGS=1 + fi +fi + +if [ "$USE_XARGS" = "0" ]; then +export MAKEFLAGS="-j $cpus" +build_all_targets() +{ + for VENDOR in $( vendors ); do + for MAINBOARD in $( mainboards $VENDOR ); do + build_target $VENDOR $MAINBOARD + test_target $VENDOR $MAINBOARD + remove_target $VENDOR $MAINBOARD + done + done +} +else +# Limit to 32 parallel builds for now. +# Thrashing all caches because we run +# 160 abuilds in parallel is no fun. +if [ "$cpus" = "" ]; then + cpus=32 +fi +build_all_targets() +{ + # seed shared utils + make -j $cpus obj=coreboot-builds/temp objutil=coreboot-builds/sharedutils tools + rm -rf coreboot-builds/temp + for VENDOR in $( vendors ); do + for MAINBOARD in $( mainboards $VENDOR ); do + echo $VENDOR/$MAINBOARD + done + done | xargs -P 0$cpus -n 1 $0 $cmdline -t +} fi # /path/to/freebios2/ @@ -629,23 +668,21 @@ if [ "$target" != "" ]; then CONFIG=`printf $target|cut -f3 -d/` if [ ! -r $ROOT/src/mainboard/$target ]; then printf "No such target: $target\n" - xml '</abuild>' - junit '</testsuite>' - exit 1 + failed=1 + else + build_target $VENDOR $MAINBOARD $CONFIG + test_target $VENDOR $MAINBOARD + test "$mode" != "text" && cat $TARGET/${VENDOR}_${MAINBOARD}/abuild.xml >> $REAL_XMLFILE + XMLFILE=$REAL_XMLFILE fi - build_target $VENDOR $MAINBOARD $CONFIG - test_target $VENDOR $MAINBOARD - test "$mode" != "text" && cat $TARGET/${VENDOR}_${MAINBOARD}/abuild.xml >> $REAL_XMLFILE - XMLFILE=$REAL_XMLFILE else - # build all boards per default - for VENDOR in $( vendors ); do - for MAINBOARD in $( mainboards $VENDOR ); do - build_target $VENDOR $MAINBOARD - test_target $VENDOR $MAINBOARD - remove_target $VENDOR $MAINBOARD - done - done + build_all_targets + rm -f $REAL_XMLFILE + xml '<?xml version="1.0" encoding="utf-8"?>' + xml '<abuild>' + + junit '<?xml version="1.0" encoding="utf-8"?>' + junit '<testsuite>' if [ "$mode" != "text" ]; then for xmlfile in $TARGET/*_*/abuild.xml; do cat $xmlfile >> $REAL_XMLFILE

1 0

Set top box update
by Gregg Levine 11 Mar '12

11 Mar '12

Hello! Amazon tells me that there are now two people selling their Akimbo boxes. Perhaps I'll definitely buy one. And Joe here is the linked page which contains a reference to the STB kit from Intel: http://cerberus.teamhackaday.com/?p=3 It turns out that it comes up right below the description for the device. It seems the only thing nonstandard about it is the crappy BIOS that Akimbo insisted on. ----- Gregg C Levine gregg.drwho8(a)gmail.com "This signature fought the Time Wars, time and again."

2 2

← Newer
1
...
30
31
32
33
34
35
36
...
72
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot March 2012