the following patch was just integrated into master:
commit 221274e7533b5b7c0ca772eb899492129d7c23a0
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Sun Aug 14 13:52:03 2011 -0700
Increase size of the coreboot table area
Packing a device tree into the coreboot table can easily make
the table exceed the current limit of 8KB. However, right now
there is no error handling in place to catch that case.
Increase the maximum memory usable for all tables from 64KB to
128KB and increase the maximum coreboot table size from 8KB
to 32KB.
Change-Id: I2025bf070d0adb276c1cd610aa8402b50bdf2525
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Build-Tested: build bot (Jenkins) at Fri Mar 9 05:24:30 2012, giving +1
See http://review.coreboot.org/704 for details.
-gerrit
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/409
-gerrit
commit 89323d9f59044c9036f7ea96c7394606ee3f298e
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Nov 5 14:44:41 2011 +0100
abuild: Build boards in parallel if possible
Determine if xargs -P works. If yes, use that to build multiple
boards in parallel, instead of relying on make -j X, when doing
a full abuild run (instead of single boards).
make -j X isn't able to make use of several cores at various
serialization points in our build process, so this change results
in a >25% speed up for a full abuild run in my tests.
Change-Id: Id484a4211c84a3a24115278e0fbe92345f346596
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/abuild/abuild | 68 +++++++++++++++++++++++++++++++++++++++------------
1 files changed, 52 insertions(+), 16 deletions(-)
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 74d2908..83e84bf 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -563,6 +563,9 @@ test -f util/sconfig/sconfig.l && ROOT=$( pwd )
test -f ../util/sconfig/sconfig.l && ROOT=$( cd ..; pwd )
test "$ROOT" = "" && ROOT=$( cd ../..; pwd )
+# command line for xargs parallelization. Thus overwrite -c X
+cmdline="$* -c 1"
+
# parse parameters.. try to find out whether we're running GNU getopt
getoptbrand="`getopt -V`"
if [ "${getoptbrand:0:6}" == "getopt" ]; then
@@ -607,8 +610,43 @@ while true ; do
esac
done
+USE_XARGS=0
if [ "$cpus" != "1" ]; then
- export MAKEFLAGS="-j $cpus"
+ if [ "$target" = "" ]; then
+ # Test if xargs supports the non-standard -P flag
+ echo | xargs -P 0$cpus -n 1 echo 2>/dev/null >/dev/null && USE_XARGS=1
+ fi
+fi
+
+if [ "$USE_XARGS" = "0" ]; then
+export MAKEFLAGS="-j $cpus"
+build_all_targets()
+{
+ for VENDOR in $( vendors ); do
+ for MAINBOARD in $( mainboards $VENDOR ); do
+ build_target $VENDOR $MAINBOARD
+ test_target $VENDOR $MAINBOARD
+ remove_target $VENDOR $MAINBOARD
+ done
+ done
+}
+else
+# Limit to 32 parallel builds for now.
+# Thrashing all caches because we run
+# 160 abuilds in parallel is no fun.
+if [ "$cpus" = "" ]; then
+ cpus=32
+fi
+build_all_targets()
+{
+ # seed shared utils
+ MAKEFLAGS="-j $cpus" $0 $cmdline -t emulation/qemu-x86
+ for VENDOR in $( vendors ); do
+ for MAINBOARD in $( mainboards $VENDOR ); do
+ echo $VENDOR/$MAINBOARD
+ done
+ done | xargs -P 0$cpus -n 1 $0 $cmdline -t
+}
fi
# /path/to/freebios2/
@@ -629,23 +667,21 @@ if [ "$target" != "" ]; then
CONFIG=`printf $target|cut -f3 -d/`
if [ ! -r $ROOT/src/mainboard/$target ]; then
printf "No such target: $target\n"
- xml '</abuild>'
- junit '</testsuite>'
- exit 1
+ failed=1
+ else
+ build_target $VENDOR $MAINBOARD $CONFIG
+ test_target $VENDOR $MAINBOARD
+ test "$mode" != "text" && cat $TARGET/${VENDOR}_${MAINBOARD}/abuild.xml >> $REAL_XMLFILE
+ XMLFILE=$REAL_XMLFILE
fi
- build_target $VENDOR $MAINBOARD $CONFIG
- test_target $VENDOR $MAINBOARD
- test "$mode" != "text" && cat $TARGET/${VENDOR}_${MAINBOARD}/abuild.xml >> $REAL_XMLFILE
- XMLFILE=$REAL_XMLFILE
else
- # build all boards per default
- for VENDOR in $( vendors ); do
- for MAINBOARD in $( mainboards $VENDOR ); do
- build_target $VENDOR $MAINBOARD
- test_target $VENDOR $MAINBOARD
- remove_target $VENDOR $MAINBOARD
- done
- done
+ build_all_targets
+ rm -f $REAL_XMLFILE
+ xml '<?xml version="1.0" encoding="utf-8"?>'
+ xml '<abuild>'
+
+ junit '<?xml version="1.0" encoding="utf-8"?>'
+ junit '<testsuite>'
if [ "$mode" != "text" ]; then
for xmlfile in $TARGET/*_*/abuild.xml; do
cat $xmlfile >> $REAL_XMLFILE
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/778
-gerrit
commit c088e191cb670bf31f5f92ac718103cadfdc2aa7
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Fri Mar 9 23:03:01 2012 +0100
mainboard/aopen/Kconfig: remove extra whitespace
Change-Id: I69ee67c35113d98e034bdccf5d00e8452d3d9bd2
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
src/mainboard/aopen/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mainboard/aopen/Kconfig b/src/mainboard/aopen/Kconfig
index 5b5497c..b0fc66b 100644
--- a/src/mainboard/aopen/Kconfig
+++ b/src/mainboard/aopen/Kconfig
@@ -13,5 +13,5 @@ source "src/mainboard/aopen/dxplplusu/Kconfig"
config MAINBOARD_VENDOR
string
default "AOpen"
-
+
endif # VENDOR_AOPEN
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/777
-gerrit
commit 1b6872f126f99e82c26fb67bb09478f9fa7747e6
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Fri Mar 9 23:02:09 2012 +0100
Portability improvement
Makefile.inc uses $( ) syntax on the shell. That's isn't as universal
as one would like.
Change-Id: I9a8fd511eef7fefc1458d5bae2cd7ef5475b7392
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
Makefile.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index d36d15f..86a072a 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -225,7 +225,7 @@ lint lint-stable:
grep "^# DESCR:" $$script | sed "s,.*DESCR: *,," ; \
echo ========; \
$$script > $$LINTLOG; \
- if [ `echo $$( wc -l $$LINTLOG ) | cut -d' ' -f1` -eq 0 ]; then \
+ if [ `cat $$LINTLOG | wc -l` -eq 0 ]; then \
printf "success\n\n"; \
else \
echo test failed: ; \
the following patch was just integrated into master:
commit f61c4fa336157f9e91a777062192ccf23466258a
Author: Duncan Laurie <dlaurie(a)chromium.org>
Date: Mon Aug 15 16:35:10 2011 -0700
Fix compilation when USE_OPTION_TABLE is not defined.
Change-Id: Id622e4e96b6c8e87b00a96c324a0b4dbfac3391d
Signed-off-by: Duncan Laurie <dlaurie(a)google.com>
Build-Tested: build bot (Jenkins) at Fri Mar 9 07:29:14 2012, giving +1
See http://review.coreboot.org/702 for details.
-gerrit
the following patch was just integrated into master:
commit 243cdc7b487ecf0356b8e1a64efb0552a2df5f8c
Author: Vadim Bendebury <vbendeb(a)chromium.org>
Date: Tue Aug 16 11:44:35 2011 -0700
Fix coreboot table size calculations.
The code when reporting the coreboot table size did not account
for the last added table record. This change fixes the problem.
. rebuild coreboot, program it on the target, restart it
. look for 'Wrote coreboot table at:' in the console log
. observe the adequate table size reported
$ grep 'Wrote coreboot table:' /tmp/cb.log
Wrote coreboot table at: 00000500, 0x10 bytes, checksum c06f
Wrote coreboot table at: 7f6fc000, 0x1a73 bytes, checksum 3e45
$
Change-Id: Ic55501a4ae06fab2bcda9aea58e362325f2edccf
Signed-off-by: Vadim Bendebury <vbendeb(a)chromium.org>
Build-Tested: build bot (Jenkins) at Fri Mar 9 07:42:28 2012, giving +1
See http://review.coreboot.org/703 for details.
-gerrit
the following patch was just integrated into master:
commit 1fe424a1a1b1bb7da9392a1d9da598a55b8ae586
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Mon Aug 15 11:26:35 2011 -0700
Clean up use of CONFIG_ variables in coreboot_table.c
CONFIG_ variables are used inconsistently within the file
src/arch/x86/boot/coreboot_table.c. #ifdef will do the wrong
thing if the option is disabled. #if (CONFIG_FOO == 1) is
not needed.
Change-Id: Ifcac6ceac5fb34b931281beae500023597b3533b
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Build-Tested: build bot (Jenkins) at Fri Mar 9 07:53:29 2012, giving +1
See http://review.coreboot.org/701 for details.
-gerrit
the following patch was just integrated into master:
commit 73ac02c0ba8fbecde36aa5cbaff4a92dd428b5ea
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Thu Aug 11 14:51:31 2011 -0700
Fix dependency problem for uart8250.c as well
If you build in parallel, option_table.h will occasionally not be there yet
and the build will fail.
Change-Id: I828956ab2e05c48d20c2f7c55616cc8fa19e1227
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Fri Mar 9 08:23:31 2012, giving +2
See http://review.coreboot.org/698 for details.
-gerrit
the following patch was just integrated into master:
commit 45899e3e5bd9bccce3edcb68c84fda209b72168b
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Fri Jul 29 15:34:14 2011 -0700
Fix compilation with CONFIG_USE_OPTION_TABLE enabled
Change-Id: I6c5d973442bc1770702180a8964f1bf6ed6062ed
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Build-Tested: build bot (Jenkins) at Fri Mar 9 08:17:05 2012, giving +1
See http://review.coreboot.org/696 for details.
-gerrit