coreboot February 2012

coreboot@coreboot.org

34 participants
348 discussions

Re: [coreboot] How to port core boot
by Peter Stuge 07 Feb '12

07 Feb '12

ali hagigat wrote: > The managers of this project even do not accept their own mistakes. > Now FILO can not be compiled and when i report it as the README of the > filo is saying, the manager emails me and tells me that you are not a > programmer!! I'm not a manager. I'm a contributor in an open source project. I never said that you are not a programmer, but it does seem like very basic programming concepts and practises are foreign to you. You encountered a compile time error and reported a problem citing the instructions for run time errors. It is clear from the instructions that they apply only to run time errors. > I thought i would be encouraged for that by a thank you. Create a patch to fix the problem. You sent a compiler error message and and a very simple question "what is the problem" when the error message you sent already describes the problem perfectly. If you instead fix a problem that you discover, and push a perfect commit to Gerrit, you can be sure that you will improve your reputation, and quite likely also generate some gratitude. But ultimately, it is not the task of anyone in the coreboot community to encourage you to contribute. You need to be contributing because you want to, or everyone will just suffer. If you do not want to contribute that is perfectly fine too. It would be unfortunate that the project has to cope without your skills, but I guess it will work out somehow in the end. > When i ask a question nobody talks about the details of the logic > behind that except one person, Kyösti Mälkki. The logic is obvious already from reading debug messages, and besides that you even have access to the source code. coreboot sets up RAM, decompresses ramstage into RAM, and jumps. As many have pointed out already, the jump does not fail if RAM is OK. > Hey folks, what is going on here? If you are a master of Coreboot > why we have unrelated simple answers? Because of too basic questions. //Peter

1 0

Re: [coreboot] How to port core boot
by ron minnich 07 Feb '12

07 Feb '12

Ali, you've changed ram setup code. Ram setup is probably the single hardest thing to get right. It can take a year. You need to let people see your code before any one can help you. It's very common for a new port to pass a ram test and fail in actual use. Just about everyone who has done a port has been in this situation. But, all that said, you need to let people see your ram code or we can not help you. ron

1 0

Re: [coreboot] How to port core boot
by Rudolf Marek 07 Feb '12

07 Feb '12

Hi, > DRAM range verified. Well the check is quite simple maybe it works for simple cases and fails for real usage. I guess you need to port something like http://pyropus.ca/software/memtester/ to ROMCC to romstage and try again. All it sounds like raminit problem. Also I don't like couple of things btw. You never showed any of your code. You only ask sometimes too simple question without bothering too much with them. Please try hard before asking and try to learn new stuff. You have chosen quite difficult area, maybe you should try some simpler stuff first to get in touch better with C and common toolchains and after that get back here in here. Thanks Rudolf > Done. > Loading image. > Searching for fallback/coreboot_ram > Check fallback/romstage > Check fallback/coreboot_ram > Stage: loading fallback/coreboot_ram @ 0x100000 (180224 bytes), entry @ 0x100000 > Stage: done loading. > Jumping to image. > > > On Tue, Feb 7, 2012 at 3:07 AM, Rudolf Marek<r.marek(a)assembler.cz> wrote: >>> Seems there is a case or two of possible infinite while() loops within >>> the uart8250 serial console code. This is a wild guess, but the uart >> >> >> Yeah I dont like that too. Maybe worth to do a timeout? Or Loop count? It is >> always better to boot than to have perfect serial output ;) >> >> But in this case I would think memory is not 100% OK. Worth to check if >> 1M->3M is OK (this is where coreboot ramstage goes) >> >> Thanks >> Rudolf >> >> >> -- >> coreboot mailing list: coreboot(a)coreboot.org >> http://www.coreboot.org/mailman/listinfo/coreboot

2 1

Re: [coreboot] How to port core boot
by Sven Schnelle 07 Feb '12

07 Feb '12

On 02/07/2012 04:21 PM, ali hagigat wrote: > This time i do ram_check between 1M to 3M, here is the serial port output: > > coreboot-4.0-1959-g950f20a-dirty Tue Feb 7 18:39:18 IRST 2012 starting... > Testing DRAM : 00100000 - 00900000 > DRAM fill: 0x00100000-0x00900000 > 00900000 > DRAM filled > DRAM verify: 0x00100000-0x00900000 > 00900000 > DRAM range verified. > Done. > Loading image. > Searching for fallback/coreboot_ram > Check fallback/romstage > Check fallback/coreboot_ram > Stage: loading fallback/coreboot_ram @ 0x100000 (180224 bytes), entry @ 0x100000 > Stage: done loading. > Jumping to image. > > I only changed sdram_enable() and some commented function calls and > there is no payload. How these changes can effect Coreboot? > > My guess is that the problem occurs inside this function: > cbfs_and_run_core > > It is located in: > ~/bios/coreboot/src/arch/x86/lib/cbfs_and_run.c > > When it wants to do a jump inside cbfs_and_run_core(), the processor > halts some how. I'd bet your RAM setup isn't working. In almost all cases i have seen coreboot hanging it was caused by non working RAM. You should test all available RAM, not only parts of it. And that ram_check() succeeds, doesn't mean that your RAM setup is working properly. It just means that nothing obvious is wrong. Regards Sven

1 0

Re: [coreboot] How to port core boot
by Peter Stuge 07 Feb '12

07 Feb '12

ali hagigat wrote: > Stage: loading fallback/coreboot_ram @ 0x100000 (180224 bytes), entry @ 0x100000 > Stage: done loading. > Jumping to image. .. > When it wants to do a jump inside cbfs_and_run_core(), the processor > halts some how. RAM is not initialized correctly. //Peter

2 1

Re: [coreboot] How to port core boot
by Kyösti Mälkki 07 Feb '12

07 Feb '12

On Mon, 2012-02-06 at 19:17 +0330, ali hagigat wrote: > I can verify that by the assembly code i have. writing to any memory > location and reading that. Also I tested it by ram_check() > in Coreboot. Both are correct. > > The last post codes are 0x39, 0x80 and Coreboot seems to stop! > Hi 0x80 seems like a reasonable POST from the very beginning of stage coreboot_ram. Continue your work with src/boot/hardwaremain.c; figure out whether you only lose serial communication or if the execution actually halts. Seems there is a case or two of possible infinite while() loops within the uart8250 serial console code. This is a wild guess, but the uart could end up in a bad state if transmit buffers are non-empty while divisors are programmed etc. Maybe raise the speed to more common and tested 115200. Regards, KM

3 3

Re: [coreboot] How to port core boot
by Kyösti Mälkki 07 Feb '12

07 Feb '12

On Tue, 2012-02-07 at 18:08 +0330, ali hagigat wrote: > Thank you, Kyösti, for the reply. I tested the modified Coreboot by > 115200 Buad rate, again the same message(latest post code seems to be > 0x11)(modified Coreboot contains sdram_enable() changed and some > fuction calls was commented out in romstage.c and i am using > build/coreboot.rom as the final image on ROM chip): > > coreboot-4.0-1959-g950f20a-dirty Tue Feb 7 17:40:50 IRST 2012 starting... > Testing DRAM : 02000000 - 10000000 > DRAM fill: 0x02000000-0x10000000 > 10000000 > DRAM filled > DRAM verify: 0x02000000-0x10000000 > 10000000 > DRAM range verified. > Done. > Loading image. > Searching for fallback/coreboot_ram > Check fallback/romstage > Check fallback/coreboot_ram > Stage: loading fallback/coreboot_ram @ 0x100000 (180224 bytes), entry @ 0x100000 > lzma: Decoding error = 1 > FATAL: Essential component is missing. Your ram_check() still does not cover 1M-3M range. Failure to decompress coreboot_ram (lzma decoding error) screams a problem with initialising RAM. KM

2 1

Re: [coreboot] I can not add FILO as a payload
by Peter Stuge 07 Feb '12

07 Feb '12

ali hagigat wrote: > cd payloads/libpayload/ > /root/bios/coreboot/payloads/libpayload> make defconfig > /root/bios/coreboot/payloads/libpayload> make > /root/bios/coreboot/payloads/libpayload> make DESTDIR=../filo/build install > /root/bios/coreboot/payloads/libpayload> cd ../filo > /root/bios/coreboot/payloads/filo> make menuconfig So far so good. > /root/bios/coreboot/payloads/filo> make .. > CC build/fs/cbfs.o > /root/bios/coreboot/payloads/filo/fs/cbfs.c:113:20: error: conflicting types for 'cbfs_find_file' > /root/bios/coreboot/payloads/filo/build/libpayload/include/cbfs_core.h:175:7: note: previous declaration of 'cbfs_find_file' was here > make: *** [/root/bios/coreboot/payloads/filo/build/fs/cbfs.o] Error 1 .. > What caused the problem then? Look more closely at the error message. It is actually a very clear error message. Then you look at the source code pointed to by the error message. This process is the *very first* problem resolution process that *every* programmer in this world encounters. It is amazing that you seem to not know it. :\ FILO is probably not quite up to date with the latest libpayload API, so you now have an opportunity to fix this and make FILO better for everyone. //Peter

2 1

I can not add FILO as a payload
by ali hagigat 07 Feb '12

07 Feb '12

I want to add FILO as a payload. There are some errors. I got the Coreboot source by : git clone http://review.coreboot.org/p/coreboot Then inside the project I had: /root/bios/coreboot/payloads/libpayload, /root/bios/coreboot/payloads/filo I executed the some steps according to the following file: /root/bios/coreboot/payloads/filo/README cd payloads/libpayload/ /root/bios/coreboot/payloads/libpayload> make defconfig /root/bios/coreboot/payloads/libpayload> make /root/bios/coreboot/payloads/libpayload> make DESTDIR=../filo/build install /root/bios/coreboot/payloads/libpayload> cd ../filo /root/bios/coreboot/payloads/filo> make menuconfig /root/bios/coreboot/payloads/filo> make Found Libpayload /root/bios/coreboot/payloads/filo/build/libpayload/lib/libpayload.a. CC build/i386/context.o CC build/i386/segment.o CC build/i386/timer.o CC build/i386/sys_info.o CC build/i386/linux_load.o CC build/main/filo.o CC build/main/strtox.o CC build/main/elfload.o CC build/main/ipchecksum.o CC build/main/grub/grub.o CC build/main/grub/builtins.o CC build/main/grub/cmdline.o CC build/main/grub/char_io.o CC build/main/grub/completions.o CC build/main/grub/md5.o CC build/fs/blockdev.o CC build/fs/vfs.o CC build/fs/eltorito.o CC build/fs/fsys_ext2fs.o CC build/fs/fsys_fat.o CC build/fs/fsys_reiserfs.o CC build/fs/fsys_iso9660.o CC build/fs/fsys_cbfs.o CC build/fs/cbfs.o /root/bios/coreboot/payloads/filo/fs/cbfs.c:113:20: error: conflicting types for 'cbfs_find_file' /root/bios/coreboot/payloads/filo/build/libpayload/include/cbfs_core.h:175:7: note: previous declaration of 'cbfs_find_file' was here make: *** [/root/bios/coreboot/payloads/filo/build/fs/cbfs.o] Error 1 I am copying the .config files of filo and lipayload: /root/bios/coreboot/payloads/filo> cat .config # # Automatically generated make config: don't edit # FILO version: 0.6.0 # Tue Feb 7 17:12:41 2012 # CONFIG_TARGET_I386=y # # Interface Options # CONFIG_USE_GRUB=y CONFIG_PROMPT="filo" CONFIG_MENULST_FILE="hda3:/boot/filo/menu.lst" CONFIG_MENULST_TIMEOUT=0 CONFIG_USE_MD5_PASSWORDS=y # CONFIG_ISOLINUX_PARSER is not set # # Drivers # CONFIG_IDE_DISK=y CONFIG_IDE_DISK_POLL_DELAY=0 # CONFIG_SLOW_SATA is not set # CONFIG_PCMCIA_CF is not set CONFIG_USB_DISK=y # CONFIG_FLASH_DISK is not set CONFIG_SUPPORT_PCI=y # CONFIG_PCI_BRUTE_SCAN is not set # CONFIG_SUPPORT_SOUND is not set # # Filesystems # CONFIG_FSYS_EXT2FS=y CONFIG_FSYS_FAT=y # CONFIG_FSYS_JFS is not set # CONFIG_FSYS_MINIX is not set CONFIG_FSYS_REISERFS=y # CONFIG_FSYS_XFS is not set CONFIG_FSYS_ISO9660=y CONFIG_ELTORITO=y # CONFIG_FSYS_CRAMFS is not set # CONFIG_FSYS_SQUASHFS is not set CONFIG_FSYS_CBFS=y # # Loaders # CONFIG_LINUX_LOADER=y # CONFIG_WINCE_LOADER is not set # CONFIG_ARTEC_BOOT is not set # # Debugging & Experimental # # CONFIG_EXPERIMENTAL is not set # CONFIG_DEBUG_ALL is not set # CONFIG_DEBUG_ELFBOOT is not set # CONFIG_DEBUG_SEGMENT is not set # CONFIG_DEBUG_SYS_INFO is not set # CONFIG_DEBUG_BLOCKDEV is not set # CONFIG_DEBUG_VFS is not set # CONFIG_DEBUG_FSYS_EXT2FS is not set # CONFIG_DEBUG_PCI is not set # CONFIG_DEBUG_LINUXLOAD is not set # CONFIG_DEBUG_IDE is not set # CONFIG_DEBUG_USB is not set # CONFIG_DEBUG_ELTORITO is not set CONFIG_DEVELOPER_TOOLS=y /root/bios/coreboot/payloads/libpayload> cat ./.config # # Automatically generated make config: don't edit # libpayload version: 0.2.0 # Tue Feb 7 17:08:09 2012 # # # Generic Options # # CONFIG_EXPERIMENTAL is not set # CONFIG_OBSOLETE is not set # CONFIG_DEVELOPER is not set # # Architecture Options # CONFIG_TARGET_I386=y # CONFIG_TARGET_POWERPC is not set # CONFIG_MEMMAP_RAM_ONLY is not set # CONFIG_MULTIBOOT is not set # # Standard Libraries # CONFIG_LIBC=y CONFIG_CURSES=y # CONFIG_TINYCURSES is not set CONFIG_PDCURSES=y CONFIG_CBFS=y CONFIG_LZMA=y # # Console Options # CONFIG_SERIAL_CONSOLE=y CONFIG_SERIAL_IOBASE=0x3f8 # CONFIG_SERIAL_SET_SPEED is not set # CONFIG_SERIAL_ACS_FALLBACK is not set CONFIG_VIDEO_CONSOLE=y CONFIG_VGA_VIDEO_CONSOLE=y # CONFIG_GEODELX_VIDEO_CONSOLE is not set CONFIG_COREBOOT_VIDEO_CONSOLE=y CONFIG_PC_KEYBOARD=y CONFIG_PC_KEYBOARD_LAYOUT_US=y # CONFIG_PC_KEYBOARD_LAYOUT_DE is not set # # Drivers # CONFIG_PCI=y CONFIG_NVRAM=y # CONFIG_RTC_PORT_EXTENDED_VIA is not set CONFIG_SPEAKER=y CONFIG_USB=y CONFIG_USB_UHCI=y CONFIG_USB_OHCI=y CONFIG_USB_EHCI=y CONFIG_USB_XHCI=y CONFIG_USB_HID=y CONFIG_USB_HUB=y CONFIG_USB_MSC=y What caused the problem then?

1 0

Patch set updated for coreboot: 3b31dca Delete hard-coded driver includes
by Kyösti Mälkki 07 Feb '12

07 Feb '12

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/610 -gerrit commit 3b31dcaa10f1db54a1a2b15728011a47e789353f Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Tue Feb 7 14:59:07 2012 +0200 Delete hard-coded driver includes Driver components are conditionally included in the build using the Kconfig options. Change-Id: I05417ee263a5b82e947600482dfb68f7a3f52d58 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/mainboard/amd/serengeti_cheetah/Kconfig | 5 +++-- src/mainboard/amd/serengeti_cheetah/Makefile.inc | 1 - src/mainboard/amd/serengeti_cheetah_fam10/Kconfig | 1 + .../amd/serengeti_cheetah_fam10/Makefile.inc | 1 - src/mainboard/broadcom/blast/Kconfig | 1 + src/mainboard/broadcom/blast/Makefile.inc | 1 - src/mainboard/hp/dl145_g1/Kconfig | 1 + src/mainboard/hp/dl145_g1/Makefile.inc | 1 - src/mainboard/msi/ms9282/Kconfig | 2 ++ src/mainboard/msi/ms9282/Makefile.inc | 4 ---- src/mainboard/supermicro/h8dme/Kconfig | 1 + src/mainboard/supermicro/h8dme/Makefile.inc | 2 -- src/mainboard/supermicro/x6dhe_g/Makefile.inc | 1 - src/mainboard/supermicro/x6dhe_g2/Makefile.inc | 1 - src/mainboard/tyan/s2881/Kconfig | 1 + src/mainboard/tyan/s2881/Makefile.inc | 1 - src/mainboard/tyan/s2892/Kconfig | 1 + src/mainboard/tyan/s2892/Makefile.inc | 2 -- 18 files changed, 11 insertions(+), 17 deletions(-) diff --git a/src/mainboard/amd/serengeti_cheetah/Kconfig b/src/mainboard/amd/serengeti_cheetah/Kconfig index fcdeb49..5cd07c6 100644 --- a/src/mainboard/amd/serengeti_cheetah/Kconfig +++ b/src/mainboard/amd/serengeti_cheetah/Kconfig @@ -3,8 +3,8 @@ if BOARD_AMD_SERENGETI_CHEETAH config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select ARCH_X86 - select SOUTHBRIDGE_AMD_AMD8132 - select SOUTHBRIDGE_AMD_AMD8151 + select SOUTHBRIDGE_AMD_AMD8132 + select SOUTHBRIDGE_AMD_AMD8151 select CPU_AMD_SOCKET_F select DIMM_DDR2 select DIMM_REGISTERED @@ -27,6 +27,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO select QRANK_DIMM_SUPPORT + select DRIVERS_I2C_I2CMUX config MAINBOARD_DIR string diff --git a/src/mainboard/amd/serengeti_cheetah/Makefile.inc b/src/mainboard/amd/serengeti_cheetah/Makefile.inc index b8cdba5..1ba662e 100644 --- a/src/mainboard/amd/serengeti_cheetah/Makefile.inc +++ b/src/mainboard/amd/serengeti_cheetah/Makefile.inc @@ -17,4 +17,3 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -ramstage-y += ../../../drivers/i2c/i2cmux/i2cmux.c diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig b/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig index feecdec..df71444 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig +++ b/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig @@ -25,6 +25,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select ENABLE_APIC_EXT_ID select LIFT_BSP_APIC_ID select QRANK_DIMM_SUPPORT + select DRIVERS_I2C_I2CMUX2 config MAINBOARD_DIR string diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/Makefile.inc b/src/mainboard/amd/serengeti_cheetah_fam10/Makefile.inc index 70b429d..1ba662e 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/Makefile.inc +++ b/src/mainboard/amd/serengeti_cheetah_fam10/Makefile.inc @@ -17,4 +17,3 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -ramstage-y += ../../../drivers/i2c/i2cmux2/i2cmux2.c diff --git a/src/mainboard/broadcom/blast/Kconfig b/src/mainboard/broadcom/blast/Kconfig index 4bad57d..b2f923d 100644 --- a/src/mainboard/broadcom/blast/Kconfig +++ b/src/mainboard/broadcom/blast/Kconfig @@ -17,6 +17,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_512 select SB_HT_CHAIN_UNITID_OFFSET_ONLY select QRANK_DIMM_SUPPORT + select DRIVERS_I2C_I2CMUX2 config MAINBOARD_DIR string diff --git a/src/mainboard/broadcom/blast/Makefile.inc b/src/mainboard/broadcom/blast/Makefile.inc index 9e76151..77fa6eb 100644 --- a/src/mainboard/broadcom/blast/Makefile.inc +++ b/src/mainboard/broadcom/blast/Makefile.inc @@ -1,4 +1,3 @@ # Needed by irq_tables and mptable and acpi_tables. -ramstage-y += ../../../drivers/i2c/i2cmux2/i2cmux2.c diff --git a/src/mainboard/hp/dl145_g1/Kconfig b/src/mainboard/hp/dl145_g1/Kconfig index ebd7ffd..d2de8a2 100644 --- a/src/mainboard/hp/dl145_g1/Kconfig +++ b/src/mainboard/hp/dl145_g1/Kconfig @@ -18,6 +18,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select RAMINIT_SYSINFO # select SB_HT_CHAIN_UNITID_OFFSET_ONLY select QRANK_DIMM_SUPPORT + select DRIVERS_I2C_I2CMUX config MAINBOARD_DIR string diff --git a/src/mainboard/hp/dl145_g1/Makefile.inc b/src/mainboard/hp/dl145_g1/Makefile.inc index d3097a1..e69de29 100644 --- a/src/mainboard/hp/dl145_g1/Makefile.inc +++ b/src/mainboard/hp/dl145_g1/Makefile.inc @@ -1 +0,0 @@ -ramstage-y += ../../../drivers/i2c/i2cmux/i2cmux.c \ No newline at end of file diff --git a/src/mainboard/msi/ms9282/Kconfig b/src/mainboard/msi/ms9282/Kconfig index 3ccc3f9..9e8cf4e 100644 --- a/src/mainboard/msi/ms9282/Kconfig +++ b/src/mainboard/msi/ms9282/Kconfig @@ -19,6 +19,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO select QRANK_DIMM_SUPPORT + select DRIVERS_I2C_ADM1027 + select DRIVERS_I2C_I2CMUX2 config MAINBOARD_DIR string diff --git a/src/mainboard/msi/ms9282/Makefile.inc b/src/mainboard/msi/ms9282/Makefile.inc index e8d9af1..1ba662e 100644 --- a/src/mainboard/msi/ms9282/Makefile.inc +++ b/src/mainboard/msi/ms9282/Makefile.inc @@ -17,7 +17,3 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -# FIXME drivers should be selected through Kconfig -ramstage-y += ../../../drivers/i2c/i2cmux2/i2cmux2.c -ramstage-y += ../../../drivers/i2c/adm1027/adm1027.c - diff --git a/src/mainboard/supermicro/h8dme/Kconfig b/src/mainboard/supermicro/h8dme/Kconfig index ce49a47..376b81a 100644 --- a/src/mainboard/supermicro/h8dme/Kconfig +++ b/src/mainboard/supermicro/h8dme/Kconfig @@ -24,6 +24,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select QRANK_DIMM_SUPPORT select K8_ALLOCATE_IO_RANGE select SET_FIDVID + select DRIVERS_I2C_I2CMUX2 config MAINBOARD_DIR string diff --git a/src/mainboard/supermicro/h8dme/Makefile.inc b/src/mainboard/supermicro/h8dme/Makefile.inc index 765096d..71baa03 100644 --- a/src/mainboard/supermicro/h8dme/Makefile.inc +++ b/src/mainboard/supermicro/h8dme/Makefile.inc @@ -17,6 +17,4 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -ramstage-y += ../../../drivers/i2c/i2cmux2/i2cmux2.c - # Needed by irq_tables and mptable and acpi_tables. diff --git a/src/mainboard/supermicro/x6dhe_g/Makefile.inc b/src/mainboard/supermicro/x6dhe_g/Makefile.inc index 30eacbd..495602d 100644 --- a/src/mainboard/supermicro/x6dhe_g/Makefile.inc +++ b/src/mainboard/supermicro/x6dhe_g/Makefile.inc @@ -19,4 +19,3 @@ ## ROMCCFLAGS=-mcpu=p4 -O2 -ramstage-y += ../../../drivers/generic/debug/debug_dev.c diff --git a/src/mainboard/supermicro/x6dhe_g2/Makefile.inc b/src/mainboard/supermicro/x6dhe_g2/Makefile.inc index 30eacbd..495602d 100644 --- a/src/mainboard/supermicro/x6dhe_g2/Makefile.inc +++ b/src/mainboard/supermicro/x6dhe_g2/Makefile.inc @@ -19,4 +19,3 @@ ## ROMCCFLAGS=-mcpu=p4 -O2 -ramstage-y += ../../../drivers/generic/debug/debug_dev.c diff --git a/src/mainboard/tyan/s2881/Kconfig b/src/mainboard/tyan/s2881/Kconfig index fd5fca8..0073ebb 100644 --- a/src/mainboard/tyan/s2881/Kconfig +++ b/src/mainboard/tyan/s2881/Kconfig @@ -18,6 +18,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select SB_HT_CHAIN_UNITID_OFFSET_ONLY select DRIVERS_SIL_3114 select QRANK_DIMM_SUPPORT + select DRIVERS_I2C_ADT7463 config MAINBOARD_DIR string diff --git a/src/mainboard/tyan/s2881/Makefile.inc b/src/mainboard/tyan/s2881/Makefile.inc index 1de4a6c..e69de29 100644 --- a/src/mainboard/tyan/s2881/Makefile.inc +++ b/src/mainboard/tyan/s2881/Makefile.inc @@ -1 +0,0 @@ -ramstage-y += ../../../drivers/i2c/adt7463/adt7463.c diff --git a/src/mainboard/tyan/s2892/Kconfig b/src/mainboard/tyan/s2892/Kconfig index 88703f3..d58f5ab 100644 --- a/src/mainboard/tyan/s2892/Kconfig +++ b/src/mainboard/tyan/s2892/Kconfig @@ -18,6 +18,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 select QRANK_DIMM_SUPPORT + select DRIVERS_I2C_ADM1027 config MAINBOARD_DIR string diff --git a/src/mainboard/tyan/s2892/Makefile.inc b/src/mainboard/tyan/s2892/Makefile.inc index c371ad0..e69de29 100644 --- a/src/mainboard/tyan/s2892/Makefile.inc +++ b/src/mainboard/tyan/s2892/Makefile.inc @@ -1,2 +0,0 @@ - -ramstage-y += ../../../drivers/i2c/adm1027/adm1027.c

1 0

← Newer
1
...
23
24
25
26
27
28
29
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot February 2012