coreboot January 2012

coreboot@coreboot.org

40 participants
302 discussions

Patch merged into coreboot/master: f74ca42 pci_ops_mmconf: Move conditional compilation to Makefile
by gerrit＠coreboot.org 26 Jan '12

26 Jan '12

the following patch was just integrated into master: commit f74ca42fc8462f791fdb2866919625a8f6459e1d Author: Vikram Narayanan <vikram186(a)gmail.com> Date: Tue Jan 24 20:22:20 2012 +0530 pci_ops_mmconf: Move conditional compilation to Makefile Moved the conditional compilation out of the source file Change-Id: Ic4045006f39d70f4a0bc37d1bd5e073ed8477c68 Signed-off-by: Vikram Narayanan <vikram186(a)gmail.com> Build-Tested: build bot (Jenkins) at Thu Jan 26 07:51:49 2012, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Thu Jan 26 22:15:18 2012, giving +2 See http://review.coreboot.org/578 for details. -gerrit

1 0

New patch to review for coreboot: babb2da libpayload: Add iterators for CMOS variables
by Patrick Georgi 26 Jan '12

26 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/587 -gerrit commit babb2da4b6ad509c69c20ca11de5f8c1fa89a8e3 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Mon Jan 16 15:39:57 2012 +0100 libpayload: Add iterators for CMOS variables Provide functions that pick the first CMOS variable defined in the cmos layout, and from there, the next one. Change-Id: Ie98146de7f6273089fc6fc0b232a4b94337cf8a3 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/drivers/options.c | 14 ++++++++++++++ payloads/libpayload/include/libpayload.h | 2 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index c4e9d16..90fefe0 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -171,6 +171,20 @@ static struct cb_cmos_entries *lookup_cmos_entry(struct cb_cmos_option_table *op return NULL; } +struct cb_cmos_entries *first_cmos_entry(struct cb_cmos_option_table *option_table) +{ + return lookup_cmos_entry(option_table, ""); +} + +struct cb_cmos_entries *next_cmos_entry(struct cb_cmos_entries *cmos_entry) +{ + struct cb_cmos_entries *next = (struct cb_cmos_entries*)((unsigned char *)cmos_entry + cmos_entry->size); + if (next->tag == CB_TAG_OPTION) + return next; + else + return NULL; +} + /* Either value or text must be NULL. Returns the field that matches "the other" for a given config_id */ static struct cb_cmos_enums *lookup_cmos_enum_core(struct cb_cmos_option_table *option_table, int config_id, u8 *value, char *text) { diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 488ad48..53d6672 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -206,6 +206,8 @@ struct cb_cmos_option_table *get_system_option_table(void); int options_checksum_valid(const struct nvram_accessor *nvram); void fix_options_checksum_with(const struct nvram_accessor *nvram); void fix_options_checksum(void); +struct cb_cmos_entries *first_cmos_entry(struct cb_cmos_option_table *option_table); +struct cb_cmos_entries *next_cmos_entry(struct cb_cmos_entries *cur); int get_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *dest, char *name); int get_option_from(struct cb_cmos_option_table *option_table, void *dest, char *name); int get_option(void *dest, char *name);

1 0

New patch to review for coreboot: 0191c0d libpayload: Expose options_checksum_valid
by Patrick Georgi 26 Jan '12

26 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/586 -gerrit commit 0191c0d84803e45481c36b1f30e481c7d42105d0 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Mon Jan 16 15:03:11 2012 +0100 libpayload: Expose options_checksum_valid options_checksum_valid can be used as a fast test to identify invalid CMOS data by checking the checksum. Change-Id: I44635d4c5d389579ad82435907ba8658e1bd44bb Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/drivers/options.c | 2 +- payloads/libpayload/include/libpayload.h | 1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index b9ec698..c4e9d16 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -57,7 +57,7 @@ struct cb_cmos_option_table *get_system_option_table() return phys_to_virt(lib_sysinfo.option_table); } -static int options_checksum_valid(const struct nvram_accessor *nvram) +int options_checksum_valid(const struct nvram_accessor *nvram) { int i; int range_start = lib_sysinfo.cmos_range_start / 8; diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index dd98404..488ad48 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -203,6 +203,7 @@ extern u8 *mem_accessor_base; extern struct nvram_accessor *use_nvram, *use_mem; struct cb_cmos_option_table *get_system_option_table(void); +int options_checksum_valid(const struct nvram_accessor *nvram); void fix_options_checksum_with(const struct nvram_accessor *nvram); void fix_options_checksum(void); int get_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *dest, char *name);

1 0

New patch to review for coreboot: fe1a7a7 libpayload: Provide interpretation of CMOS data structures
by Patrick Georgi 26 Jan '12

26 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/585 -gerrit commit fe1a7a7d6013b87e42f974bc4ac6185552e80b74 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Mon Jan 16 13:47:33 2012 +0100 libpayload: Provide interpretation of CMOS data structures Add new functions that allow using string based key/value access to CMOS, including support for enums. Change-Id: Ibe238eff4c5230e5f61004c88221cd34393873aa Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/drivers/options.c | 103 ++++++++++++++++++++++++++++++ payloads/libpayload/include/libpayload.h | 2 + 2 files changed, 105 insertions(+), 0 deletions(-) diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index d393e49..b9ec698 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -171,6 +171,42 @@ static struct cb_cmos_entries *lookup_cmos_entry(struct cb_cmos_option_table *op return NULL; } +/* Either value or text must be NULL. Returns the field that matches "the other" for a given config_id */ +static struct cb_cmos_enums *lookup_cmos_enum_core(struct cb_cmos_option_table *option_table, int config_id, u8 *value, char *text) +{ + struct cb_cmos_entries *cmos_entry; + int len = strnlen(text, CMOS_MAX_TEXT_LENGTH); + + /* cmos entries are located right after the option table. Skip them */ + cmos_entry = (struct cb_cmos_entries*)((unsigned char *)option_table + option_table->header_length); + while (cmos_entry->tag == CB_TAG_OPTION) + cmos_entry = (struct cb_cmos_entries*)((unsigned char *)cmos_entry + cmos_entry->size); + + /* cmos enums are located after cmos entries. */ + struct cb_cmos_enums *cmos_enum; + for ( cmos_enum = (struct cb_cmos_enums*)cmos_entry; + cmos_enum->tag == CB_TAG_OPTION_ENUM; + cmos_enum = (struct cb_cmos_enums*)((unsigned char *)cmos_enum + cmos_enum->size)) { + if ((cmos_enum->config_id == config_id) + && ((value == NULL) || (cmos_enum->value == *value)) + && ((text == NULL) || (memcmp((const char*)cmos_enum->text, text, len)))) { + return cmos_enum; + } + } + + return NULL; +} + +static struct cb_cmos_enums *lookup_cmos_enum_by_value(struct cb_cmos_option_table *option_table, int config_id, u8 *value) +{ + return lookup_cmos_enum_core(option_table, config_id, value, NULL); +} + +static struct cb_cmos_enums *lookup_cmos_enum_by_label(struct cb_cmos_option_table *option_table, int config_id, char *label) +{ + return lookup_cmos_enum_core(option_table, config_id, NULL, label); +} + int get_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *dest, char *name) { struct cb_cmos_entries *cmos_entry = lookup_cmos_entry(option_table, name); @@ -211,3 +247,70 @@ int set_option(void *value, char *name) { return set_option_with(use_nvram, get_system_option_table(), value, name); } + +int get_option_as_string(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, char **dest, char *name) +{ + void *raw; + struct cb_cmos_entries *cmos_entry = lookup_cmos_entry(option_table, name); + if (!cmos_entry) + return 1; + int cmos_length = (cmos_entry->length+7)/8; + + /* extra byte to ensure 0-terminated strings */ + raw = malloc(cmos_length+1); + memset(raw, 0, cmos_length+1); + + int ret = get_option_with(nvram, option_table, raw, name); + + struct cb_cmos_enums *cmos_enum; + switch (cmos_entry->config) { + case 'h': + /* only works on little endian. + 26 bytes is enough for a 64bit value in decimal */ + *dest = malloc(26); + sprintf(*dest, "%ull", *(u64*)raw); + break; + case 's': + *dest = strdup(raw); + break; + case 'e': + cmos_enum = lookup_cmos_enum_by_value(option_table, cmos_entry->config_id, (u8*)raw); + *dest = strdup((const char*)cmos_enum->text); + break; + default: /* fail */ + return 1; + } + free(raw); + return ret; +} + +int set_option_from_string(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, char *value, char *name) +{ + void *raw; + struct cb_cmos_entries *cmos_entry = lookup_cmos_entry(option_table, name); + if (!cmos_entry) + return 1; + + struct cb_cmos_enums *cmos_enum; + switch (cmos_entry->config) { + case 'h': + /* only works on little endian */ + raw = malloc(8); + *(u64*)raw = strtoull(value, NULL, 0); + break; + case 's': + raw = strdup(value); + break; + case 'e': + cmos_enum = lookup_cmos_enum_by_label(option_table, cmos_entry->config_id, value); + raw = malloc(sizeof(u32)); + *(u32*)raw = cmos_enum->value; + break; + default: /* fail */ + return 1; + } + + int ret = set_option_with(nvram, option_table, raw, name); + free(raw); + return ret; +} diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 308d95c..dd98404 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -210,6 +210,8 @@ int get_option_from(struct cb_cmos_option_table *option_table, void *dest, char int get_option(void *dest, char *name); int set_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *value, char *name); int set_option(void *value, char *name); +int get_option_as_string(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, char **dest, char *name); +int set_option_from_string(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, char *value, char *name); /** * @defgroup console Console functions

1 0

New patch to review for coreboot: 3a9ba82 libpayload: Add access to CMOS images in memory space
by Patrick Georgi 26 Jan '12

26 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/584 -gerrit commit 3a9ba82c5246941d2576ba09ac63cff5929e7740 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Mon Jan 16 10:59:27 2012 +0100 libpayload: Add access to CMOS images in memory space Provide access to CMOS images in RAM or CBFS, such as cmos.defaults Change-Id: Ifa70dea6206d94c0c271caf9ae1152fc76b5d51a Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/drivers/options.c | 17 +++++++++++++++++ payloads/libpayload/include/libpayload.h | 3 ++- 2 files changed, 19 insertions(+), 1 deletions(-) diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index 1c2facc..d393e49 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -30,11 +30,28 @@ #include <libpayload.h> #include <coreboot_tables.h> +u8 *mem_accessor_base; + +static u8 mem_read(u8 reg) +{ + return mem_accessor_base[reg]; +} + +static void mem_write(u8 val, u8 reg) +{ + mem_accessor_base[reg] = val; +} + struct nvram_accessor *use_nvram = &(struct nvram_accessor) { nvram_read, nvram_write }; +struct nvram_accessor *use_mem = &(struct nvram_accessor) { + mem_read, + mem_write +}; + struct cb_cmos_option_table *get_system_option_table() { return phys_to_virt(lib_sysinfo.option_table); diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 91156e5..308d95c 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -199,7 +199,8 @@ struct nvram_accessor { void (*write)(u8 val, u8 reg); }; -extern struct nvram_accessor *use_nvram; +extern u8 *mem_accessor_base; +extern struct nvram_accessor *use_nvram, *use_mem; struct cb_cmos_option_table *get_system_option_table(void); void fix_options_checksum_with(const struct nvram_accessor *nvram);

1 0

New patch to review for coreboot: d8ba9b8 libpayload: Refactor highlevel CMOS access
by Patrick Georgi 26 Jan '12

26 Jan '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/583 -gerrit commit d8ba9b8c8bef6d696bef5ee06ebbd883c471d00b Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Mon Jan 16 10:14:24 2012 +0100 libpayload: Refactor highlevel CMOS access This will allow using libpayload functions to access CMOS data in template files in RAM or CBFS. Change-Id: I323ed625e657cbdc1fae8c279a82ee578e83ad00 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/drivers/options.c | 68 ++++++++++++++++++++---------- payloads/libpayload/include/libpayload.h | 11 +++++ 2 files changed, 56 insertions(+), 23 deletions(-) diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index e3f0847..1c2facc 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -30,7 +30,17 @@ #include <libpayload.h> #include <coreboot_tables.h> -static int options_checksum_valid(void) +struct nvram_accessor *use_nvram = &(struct nvram_accessor) { + nvram_read, + nvram_write +}; + +struct cb_cmos_option_table *get_system_option_table() +{ + return phys_to_virt(lib_sysinfo.option_table); +} + +static int options_checksum_valid(const struct nvram_accessor *nvram) { int i; int range_start = lib_sysinfo.cmos_range_start / 8; @@ -39,15 +49,15 @@ static int options_checksum_valid(void) u16 checksum = 0, checksum_old; for(i = range_start; i <= range_end; i++) { - checksum += nvram_read(i); + checksum += nvram->read(i); } - checksum_old = ((nvram_read(checksum_location)<<8) | nvram_read(checksum_location+1)); + checksum_old = ((nvram->read(checksum_location)<<8) | nvram->read(checksum_location+1)); return (checksum_old == checksum); } -void fix_options_checksum(void) +void fix_options_checksum_with(const struct nvram_accessor *nvram) { int i; int range_start = lib_sysinfo.cmos_range_start / 8; @@ -56,14 +66,19 @@ void fix_options_checksum(void) u16 checksum = 0; for(i = range_start; i <= range_end; i++) { - checksum += nvram_read(i); + checksum += nvram->read(i); } - nvram_write((checksum >> 8), checksum_location); - nvram_write((checksum & 0xff), checksum_location + 1); + nvram->write((checksum >> 8), checksum_location); + nvram->write((checksum & 0xff), checksum_location + 1); } -static int get_cmos_value(u32 bitnum, u32 len, void *valptr) +void fix_options_checksum() +{ + fix_options_checksum_with(use_nvram); +} + +static int get_cmos_value(const struct nvram_accessor *nvram, u32 bitnum, u32 len, void *valptr) { u8 *value = (u8 *)valptr; int offs = 0; @@ -76,7 +91,7 @@ static int get_cmos_value(u32 bitnum, u32 len, void *valptr) /* Handle single byte or less */ if(len <= 8) { - reg8 = nvram_read(addr); + reg8 = nvram->read(addr); reg8 >>= bit; value[0] = reg8 & ((1 << len) -1); return 0; @@ -85,13 +100,13 @@ static int get_cmos_value(u32 bitnum, u32 len, void *valptr) /* When handling more than a byte, copy whole bytes */ while (len > 0) { len -= 8; - value[offs++]=nvram_read(addr++); + value[offs++]=nvram->read(addr++); } return 0; } -static int set_cmos_value(u32 bitnum, u32 len, void *valptr) +static int set_cmos_value(const struct nvram_accessor *nvram, u32 bitnum, u32 len, void *valptr) { u8 *value = (u8 *)valptr; int offs = 0; @@ -104,17 +119,17 @@ static int set_cmos_value(u32 bitnum, u32 len, void *valptr) /* Handle single byte or less */ if (len <= 8) { - reg8 = nvram_read(addr); + reg8 = nvram->read(addr); reg8 &= ~(((1 << len) - 1) << bit); reg8 |= (value[0] & ((1 << len) - 1)) << bit; - nvram_write(reg8, addr); + nvram->write(reg8, addr); return 0; } /* When handling more than a byte, copy whole bytes */ while (len > 0) { len -= 8; - nvram_write(value[offs++], addr++); + nvram->write(value[offs++], addr++); } return 0; @@ -139,14 +154,14 @@ static struct cb_cmos_entries *lookup_cmos_entry(struct cb_cmos_option_table *op return NULL; } -int get_option_from(struct cb_cmos_option_table *option_table, void *dest, char *name) +int get_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *dest, char *name) { struct cb_cmos_entries *cmos_entry = lookup_cmos_entry(option_table, name); if (cmos_entry) { - if(get_cmos_value(cmos_entry->bit, cmos_entry->length, dest)) + if(get_cmos_value(nvram, cmos_entry->bit, cmos_entry->length, dest)) return 1; - if(!options_checksum_valid()) + if(!options_checksum_valid(nvram)) return 1; return 0; @@ -154,21 +169,28 @@ int get_option_from(struct cb_cmos_option_table *option_table, void *dest, char return 1; } +int get_option_from(struct cb_cmos_option_table *option_table, void *dest, char *name) +{ + return get_option_with(use_nvram, option_table, dest, name); +} + int get_option(void *dest, char *name) { - struct cb_cmos_option_table *option_table = phys_to_virt(lib_sysinfo.option_table); - return get_option_from(option_table, dest, name); + return get_option_from(get_system_option_table(), dest, name); } -int set_option(void *value, char *name) +int set_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *value, char *name) { - struct cb_cmos_option_table *option_table = phys_to_virt(lib_sysinfo.option_table); struct cb_cmos_entries *cmos_entry = lookup_cmos_entry(option_table, name); if (cmos_entry) { - set_cmos_value(cmos_entry->bit, cmos_entry->length, value); - fix_options_checksum(); + set_cmos_value(nvram, cmos_entry->bit, cmos_entry->length, value); + fix_options_checksum_with(nvram); return 0; } return 1; } +int set_option(void *value, char *name) +{ + return set_option_with(use_nvram, get_system_option_table(), value, name); +} diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index d9f7d21..91156e5 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -194,9 +194,20 @@ void video_console_set_cursor(unsigned int cursorx, unsigned int cursory); /** @} */ /* drivers/option.c */ +struct nvram_accessor { + u8 (*read)(u8 reg); + void (*write)(u8 val, u8 reg); +}; + +extern struct nvram_accessor *use_nvram; + +struct cb_cmos_option_table *get_system_option_table(void); +void fix_options_checksum_with(const struct nvram_accessor *nvram); void fix_options_checksum(void); +int get_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *dest, char *name); int get_option_from(struct cb_cmos_option_table *option_table, void *dest, char *name); int get_option(void *dest, char *name); +int set_option_with(const struct nvram_accessor *nvram, struct cb_cmos_option_table *option_table, void *value, char *name); int set_option(void *value, char *name); /**

1 0

Patch merged into coreboot/master: 7c8cf66 libpayload: Allow using CBFS functions on images in RAM
by gerrit＠coreboot.org 26 Jan '12

26 Jan '12

the following patch was just integrated into master: commit 7c8cf667e1f1eb785d6bcf1a94b346c1a5cc00d5 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Tue Jan 17 15:52:05 2012 +0100 libpayload: Allow using CBFS functions on images in RAM Two new functions allow switching the CBFS functions from using RAM or ROM, with ROM as default. Change-Id: I04d67ad622d25c5728ae9a63f5b8a3dc9bbacce6 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> See http://review.coreboot.org/550 for details. -gerrit

1 0

Patch merged into coreboot/master: 30a4932 AGESA F15: AMD family15 AGESA code
by gerrit＠coreboot.org 26 Jan '12

26 Jan '12

the following patch was just integrated into master: commit 30a493289ad120f0556c7b8d167e9a09470d1929 Author: Kerry Sheh <shekairui(a)gmail.com> Date: Fri Jan 20 13:57:48 2012 +0800 AGESA F15: AMD family15 AGESA code AMD AGESA code to support Orochi platform family15 model 00-0fh processores, AMD C32, G34, and AM3r2 Sockets are supported. Change-Id: If79392c104ace25f7e01db794fa205f47746bcad Signed-off-by: Kerry Sheh <kerry.she(a)amd.com> Signed-off-by: Kerry Sheh <shekairui(a)gmail.com> See http://review.coreboot.org/554 for details. -gerrit

1 0

Patch merged into coreboot/master: 1734252 dumpmmcr: Fix compilation warnings in printf
by gerrit＠coreboot.org 26 Jan '12

26 Jan '12

the following patch was just integrated into master: commit 1734252df27612b8b5acf4fb28a52e5505e26c9a Author: Vikram Narayanan <vikram186(a)gmail.com> Date: Wed Jan 25 17:44:20 2012 +0530 dumpmmcr: Fix compilation warnings in printf cf., `man 3 printf` Change-Id: Ib78937a3e1c1eecf884bde0860594cbdb574f1fe Signed-off-by: Vikram Narayanan <vikram186(a)gmail.com> Build-Tested: build bot (Jenkins) at Thu Jan 26 09:57:42 2012, giving +1 Reviewed-By: Peter Stuge <peter(a)stuge.se> at Thu Jan 26 09:49:54 2012, giving +2 See http://review.coreboot.org/582 for details. -gerrit

1 0

New patch to review for coreboot: 42dc925 dumpmmcr: fixed compilation warnings
by Vikram Narayanan 26 Jan '12

26 Jan '12

Vikram Narayanan (vikram186(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/582 -gerrit commit 42dc925d2d86524e57ef29eef1b130e4f0e9d7a3 Author: Vikram Narayanan <vikram186(a)gmail.com> Date: Wed Jan 25 17:44:20 2012 +0530 dumpmmcr: fixed compilation warnings Fixes compilation warnings in printf Change-Id: Ib78937a3e1c1eecf884bde0860594cbdb574f1fe Signed-off-by: Vikram Narayanan <vikram186(a)gmail.com> --- util/dumpmmcr/dumpmmcr.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/util/dumpmmcr/dumpmmcr.c b/util/dumpmmcr/dumpmmcr.c index 4e1e4e7..a92068a 100644 --- a/util/dumpmmcr/dumpmmcr.c +++ b/util/dumpmmcr/dumpmmcr.c @@ -52,8 +52,8 @@ int print_mmcr(struct mmcr *mmcr) printf("eccsta is 0x%x\n", val(mmcr, memregs.eccsta)); printf("ckbpos is 0x%x\n", val(mmcr, memregs.eccckbpos)); printf("cktest is 0x%x\n", val(mmcr, memregs.ecccktest)); - printf("sbadd is 0x%x\n", val(mmcr, memregs.eccsbadd)); - printf("mbadd is 0x%x\n", val(mmcr, memregs.eccmbadd)); + printf("sbadd is 0x%lx\n", val(mmcr, memregs.eccsbadd)); + printf("mbadd is 0x%lx\n", val(mmcr, memregs.eccmbadd)); printf("\n"); printf("dbctl is 0x%x\n", val(mmcr, dbctl.dbctl)); @@ -69,20 +69,20 @@ int print_mmcr(struct mmcr *mmcr) printf("hbtgtirqsta is 0x%x\n", val(mmcr, hostbridge.tgtirqsta)); printf("hbmstirqctl is 0x%x\n", val(mmcr, hostbridge.mstirqctl)); printf("hbmstirqsta is 0x%x\n", val(mmcr, hostbridge.mstirqsta)); - printf("mstintadd is 0x%x\n", val(mmcr, hostbridge.mstintadd)); + printf("mstintadd is 0x%lx\n", val(mmcr, hostbridge.mstintadd)); printf("\n"); printf("sysarbctl is 0x%x\n", val(mmcr, sysarb.ctl)); printf("pciarbsta is 0x%x\n", val(mmcr, sysarb.sta)); printf("sysarbmenb is 0x%x\n", val(mmcr, sysarb.menb)); - printf("arbprictl is 0x%x\n", val(mmcr, sysarb.prictl)); + printf("arbprictl is 0x%lx\n", val(mmcr, sysarb.prictl)); printf("\n"); printf("adddecctl is 0x%x\n", val(mmcr, sysmap.adddecctl)); printf("wpvsta is 0x%x\n", val(mmcr, sysmap.wpvsta)); for (i=0; i<16; i++) - printf("par %d is 0x%x\n", i, val(mmcr, sysmap.par[i])); + printf("par %d is 0x%lx\n", i, val(mmcr, sysmap.par[i])); printf("\n"); printf("gpecho is 0x%x\n", val(mmcr, gpctl.gpecho));

3 2

← Newer
1
...
5
6
7
8
9
10
11
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2012