New patch to review for coreboot: 42dc925 dumpmmcr: fixed compilation warnings

[Vikram Narayanan]

Vikram Narayanan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/582

-gerrit

commit 42dc925d2d86524e57ef29eef1b130e4f0e9d7a3
Author: Vikram Narayanan <[e-mail]>
Date:   Wed Jan 25 17:44:20 2012 +0530

    dumpmmcr: fixed compilation warnings
    
    Fixes compilation warnings in printf
    
    Change-Id: Ib78937a3e1c1eecf884bde0860594cbdb574f1fe
    Signed-off-by: Vikram Narayanan <[e-mail]>
---
 util/dumpmmcr/dumpmmcr.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/util/dumpmmcr/dumpmmcr.c b/util/dumpmmcr/dumpmmcr.c
index 4e1e4e7..a92068a 100644
--- a/util/dumpmmcr/dumpmmcr.c
+++ b/util/dumpmmcr/dumpmmcr.c
@@ -52,8 +52,8 @@ int print_mmcr(struct mmcr *mmcr)
 	printf("eccsta is 0x%x\n", val(mmcr, memregs.eccsta));
 	printf("ckbpos is 0x%x\n", val(mmcr, memregs.eccckbpos));
 	printf("cktest is 0x%x\n", val(mmcr, memregs.ecccktest));
-	printf("sbadd is 0x%x\n", val(mmcr, memregs.eccsbadd));
-	printf("mbadd is 0x%x\n", val(mmcr, memregs.eccmbadd));
+	printf("sbadd is 0x%lx\n", val(mmcr, memregs.eccsbadd));
+	printf("mbadd is 0x%lx\n", val(mmcr, memregs.eccmbadd));
 
 	printf("\n");
 	printf("dbctl is 0x%x\n", val(mmcr, dbctl.dbctl));
@@ -69,20 +69,20 @@ int print_mmcr(struct mmcr *mmcr)
 	printf("hbtgtirqsta is 0x%x\n",  val(mmcr, hostbridge.tgtirqsta));
 	printf("hbmstirqctl is 0x%x\n",  val(mmcr, hostbridge.mstirqctl));
 	printf("hbmstirqsta is 0x%x\n",  val(mmcr, hostbridge.mstirqsta));
-	printf("mstintadd is 0x%x\n",  val(mmcr, hostbridge.mstintadd));
+	printf("mstintadd is 0x%lx\n",  val(mmcr, hostbridge.mstintadd));
 
 
 	printf("\n");
 	printf("sysarbctl is 0x%x\n", val(mmcr, sysarb.ctl));
 	printf("pciarbsta is 0x%x\n", val(mmcr, sysarb.sta));
 	printf("sysarbmenb is 0x%x\n", val(mmcr, sysarb.menb));
-	printf("arbprictl is 0x%x\n", val(mmcr, sysarb.prictl));
+	printf("arbprictl is 0x%lx\n", val(mmcr, sysarb.prictl));
 
 	printf("\n");
 	printf("adddecctl is 0x%x\n", val(mmcr, sysmap.adddecctl));
 	printf("wpvsta is 0x%x\n", val(mmcr, sysmap.wpvsta));
 	for (i=0; i<16; i++)
-		printf("par %d is 0x%x\n", i, val(mmcr, sysmap.par[i]));
+		printf("par %d is 0x%lx\n", i, val(mmcr, sysmap.par[i]));
 
 	printf("\n");
 	printf("gpecho is 0x%x\n", val(mmcr, gpctl.gpecho));

New patch to review for coreboot: 42dc925 dumpmmcr: fixed compilation warnings

[Paul Menzel]

Dear Vikram,


thank you for your work and the patch.

Am Donnerstag, den 26.01.2012, 07:42 +0100 schrieb Vikram Narayanan:
> Vikram Narayanan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/582
>
> -gerrit
>
> commit 42dc925d2d86524e57ef29eef1b130e4f0e9d7a3
> Author: Vikram Narayanan <[e-mail]>
> Date:   Wed Jan 25 17:44:20 2012 +0530
>
> dumpmmcr: fixed compilation warnings
>
> Fixes compilation warnings in printf

instead of almost duplicating the commit summary in the body could you
merge both and maybe paste the warning into the commit message.

    dumpmmcr: Fix compilation warnings in printf

    • cf. `man 3 printf`

You should be able to use `git commit --amend` to update the commit
message. That would be awesome.
> Change-Id: Ib78937a3e1c1eecf884bde0860594cbdb574f1fe
>     Signed-off-by: Vikram Narayanan <[e-mail]>
> ---
>  util/dumpmmcr/dumpmmcr.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

[…]


Thanks,

Paul

New patch to review for coreboot: 42dc925 dumpmmcr: fixed compilation warnings

[Vikram Narayanan]

Hello Paul,

On 26-Jan-12 1:33 PM, Paul Menzel wrote:
> Dear Vikram,
>
> thank you for your work and the patch.
>
> Am Donnerstag, den 26.01.2012, 07:42 +0100 schrieb Vikram Narayanan:

[snip]
> instead of almost duplicating the commit summary in the body could you
> merge both and maybe paste the warning into the commit message.
>
> dumpmmcr: Fix compilation warnings in printf
>
> • cf. `man 3 printf`
>
> You should be able to use `git commit --amend` to update the commit
> message. That would be awesome.

Done. Uploaded the new patch. Thanks for your comments.

Thanks,
Vikram
> Thanks,
>
> Paul