coreboot January 2011

coreboot@coreboot.org

65 participants
299 discussions

[commit] r6267 - trunk/util/nvramtool
by repository service 18 Jan '11

18 Jan '11

Author: oxygene Date: Tue Jan 18 13:14:08 2011 New Revision: 6267 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6267 Log: Remove overengineering, part 1/many Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Patrick Georgi <patrick.georgi(a)secunet.com> Modified: trunk/util/nvramtool/hexdump.c trunk/util/nvramtool/hexdump.h trunk/util/nvramtool/lbtable.c trunk/util/nvramtool/nvramtool.c Modified: trunk/util/nvramtool/hexdump.c ============================================================================== --- trunk/util/nvramtool/hexdump.c Tue Jan 18 13:12:47 2011 (r6266) +++ trunk/util/nvramtool/hexdump.c Tue Jan 18 13:14:08 2011 (r6267) @@ -46,8 +46,7 @@ static void addrprint(FILE * outfile, uint64_t address, int width); static void hexprint(FILE * outfile, unsigned char byte); static void charprint(FILE * outfile, unsigned char byte, - unsigned char nonprintable, - is_printable_fn_t is_printable_fn); + unsigned char nonprintable); /*-------------------------------------------------------------------------- * hexdump @@ -70,17 +69,11 @@ { int bytes_left, index, i; const unsigned char *p; - is_printable_fn_t is_printable_fn; /* Quietly return if the caller asks us to do something unreasonable. */ if ((format->bytes_per_line <= 0) || (bytes < 0)) return; - is_printable_fn = format->is_printable_fn; - - if (is_printable_fn == NULL) - is_printable_fn = default_is_printable_fn; - p = (const unsigned char *)mem; index = 0; @@ -112,8 +105,7 @@ /* display the bytes as characters */ for (i = 0; i < format->bytes_per_line; i++) - charprint(outfile, p[index++], format->nonprintable, - is_printable_fn); + charprint(outfile, p[index++], format->nonprintable); fprintf(outfile, "\n"); } @@ -148,8 +140,7 @@ /* display bytes for last line as characters */ for (i = 0; i < bytes_left; i++) - charprint(outfile, p[index++], format->nonprintable, - is_printable_fn); + charprint(outfile, p[index++], format->nonprintable); /* pad the rest of the character area with spaces */ for (; i < format->bytes_per_line; i++) @@ -159,25 +150,6 @@ } /*-------------------------------------------------------------------------- - * default_is_printable_fn - * - * Determine whether the input character is printable. The proper behavior - * for this type of function may be system-dependent. This function takes a - * conservative approach. If it is not adequate for your purposes, you can - * write your own. - * - * parameters: - * c: the input character - * - * return value: - * Return 1 if the input character is printable. Otherwise return 0. - *--------------------------------------------------------------------------*/ -int default_is_printable_fn(unsigned char c) -{ - return (c >= 0x20) && (c <= 0x7e); -} - -/*-------------------------------------------------------------------------- * addrprint * * Display an address as a hexadecimal number. @@ -245,12 +217,9 @@ * byte: the byte to display * nonprintable: a substitute character to display if the byte * represents a nonprintable character - * is_printable_fn: a function that returns a boolean value indicating - * whether a given character is printable *--------------------------------------------------------------------------*/ static void charprint(FILE * outfile, unsigned char byte, - unsigned char nonprintable, - is_printable_fn_t is_printable_fn) + unsigned char nonprintable) { - fprintf(outfile, "%c", is_printable_fn(byte) ? byte : nonprintable); + fprintf(outfile, "%c", ((byte >= 0x20) && (byte <= 0x7e)) ? byte : nonprintable); } Modified: trunk/util/nvramtool/hexdump.h ============================================================================== --- trunk/util/nvramtool/hexdump.h Tue Jan 18 13:12:47 2011 (r6266) +++ trunk/util/nvramtool/hexdump.h Tue Jan 18 13:14:08 2011 (r6267) @@ -48,8 +48,6 @@ #include <sys/types.h> #include <stdio.h> -typedef int (*is_printable_fn_t) (unsigned char c); - /*-------------------------------------------------------------------------- * hexdump_format_t * @@ -75,11 +73,6 @@ * characters. It serves as a separator. * nonprintable: This is a substitute character to display in place * of nonprintable characters. - * is_printable_fn: This is a user-supplied function that takes a byte - * value as input and returns a boolean value - * indicating whether the corresponding character is - * printable. A value of NULL will cause - * default_is_printable_fn to be used. *--------------------------------------------------------------------------*/ typedef struct { int bytes_per_line; @@ -89,7 +82,6 @@ const char *sep2; const char *sep3; unsigned char nonprintable; - is_printable_fn_t is_printable_fn; } hexdump_format_t; /*-------------------------------------------------------------------------- @@ -111,20 +103,4 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start, FILE * outfile, const hexdump_format_t * format); -/*-------------------------------------------------------------------------- - * default_is_printable_fn - * - * Determine whether the input character is printable. The proper behavior - * for this type of function may be system-dependent. This function appears - * to work well on a Linux system. However, if it is not adequate for your - * purposes, you can write your own. - * - * parameters: - * c: the input character - * - * return value: - * Return 1 if the input character is printable. Otherwise return 0. - *--------------------------------------------------------------------------*/ -int default_is_printable_fn(unsigned char c); - #endif /* _HEXDUMP_H */ Modified: trunk/util/nvramtool/lbtable.c ============================================================================== --- trunk/util/nvramtool/lbtable.c Tue Jan 18 13:12:47 2011 (r6266) +++ trunk/util/nvramtool/lbtable.c Tue Jan 18 13:14:08 2011 (r6267) @@ -234,7 +234,7 @@ static const struct cmos_option_table *cmos_table = NULL; static const hexdump_format_t format = - { 12, 4, " ", " | ", " ", " | ", '.', NULL }; + { 12, 4, " ", " | ", " ", " | ", '.' }; /**************************************************************************** * vtophys Modified: trunk/util/nvramtool/nvramtool.c ============================================================================== --- trunk/util/nvramtool/nvramtool.c Tue Jan 18 13:12:47 2011 (r6266) +++ trunk/util/nvramtool/nvramtool.c Tue Jan 18 13:14:08 2011 (r6267) @@ -85,7 +85,7 @@ }; static const hexdump_format_t cmos_dump_format = - { 16, 2, "", " | ", " ", " | ", '.', NULL }; + { 16, 2, "", " | ", " ", " | ", '.' }; /**************************************************************************** * main

1 0

[commit] r6266 - trunk/util/nvramtool
by repository service 18 Jan '11

18 Jan '11

Author: oxygene Date: Tue Jan 18 13:12:47 2011 New Revision: 6266 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6266 Log: Eliminate strict aliasing related warnings. Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Stefan Reinauer <stepan(a)coreboot.org> Modified: trunk/util/nvramtool/coreboot_tables.h trunk/util/nvramtool/lbtable.c Modified: trunk/util/nvramtool/coreboot_tables.h ============================================================================== --- trunk/util/nvramtool/coreboot_tables.h Tue Jan 18 10:36:44 2011 (r6265) +++ trunk/util/nvramtool/coreboot_tables.h Tue Jan 18 13:12:47 2011 (r6266) @@ -74,7 +74,10 @@ } struct lb_header { - uint8_t signature[4]; /* LBIO */ + union { + uint8_t signature[4]; /* LBIO */ + uint32_t signature32; + }; uint32_t header_bytes; uint32_t header_checksum; uint32_t table_bytes; Modified: trunk/util/nvramtool/lbtable.c ============================================================================== --- trunk/util/nvramtool/lbtable.c Tue Jan 18 10:36:44 2011 (r6265) +++ trunk/util/nvramtool/lbtable.c Tue Jan 18 13:12:47 2011 (r6266) @@ -360,7 +360,7 @@ " table_bytes: 0x%x (decimal: %d)\n" " table_checksum: 0x%x (decimal: %d)\n" " table_entries: 0x%x (decimal: %d)\n\n", - vtophys(lbtable), *((uint32_t *) lbtable->signature), + vtophys(lbtable), lbtable->signature32, lbtable->signature[0], lbtable->signature[1], lbtable->signature[2], lbtable->signature[3], lbtable->header_bytes, lbtable->header_bytes, @@ -483,14 +483,14 @@ int *bad_header_count, int *bad_table_count) { - static const char signature[] = { 'L', 'B', 'I', 'O' }; + static const char signature[4] = { 'L', 'B', 'I', 'O' }; const struct lb_header *table; const struct lb_forward *forward; const uint32_t *p; uint32_t sig; assert(end >= start); - sig = (*((const uint32_t *)signature)); + memcpy(&sig, signature, sizeof(sig)); table = NULL; *bad_header_count = 0; *bad_table_count = 0;

1 0

build service results for r6264
by repository service 18 Jan '11

18 Jan '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "zbao" checked in revision 6264 to the coreboot repository. This caused the following changes: Change Log: remove the code which is not ready to release. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Zheng Bao <zheng.bao(a)amd.com> Build Log: Configuration of a-trend:atc-6220 has been fixed Configuration of a-trend:atc-6240 has been fixed Configuration of abit:be6-ii_v2_0 has been fixed Configuration of advantech:pcm-5820 has been fixed Configuration of amd:db800 has been fixed Configuration of amd:dbm690t has been fixed Configuration of amd:mahogany has been fixed Configuration of amd:mahogany_fam10 has been fixed Configuration of amd:norwich has been fixed Configuration of amd:pistachio has been fixed Configuration of amd:rumba has been fixed Configuration of amd:serengeti_cheetah has been fixed Configuration of amd:serengeti_cheetah_fam10 has been fixed Configuration of amd:tilapia_fam10 has been fixed Configuration of arima:hdama has been fixed Configuration of artecgroup:dbe61 has been fixed Configuration of asi:mb_5blgp has been fixed Configuration of asi:mb_5blmp has been fixed Configuration of asrock:939a785gmh has been fixed Configuration of asus:a8n_e has been fixed Configuration of asus:a8v-e_deluxe has been fixed Configuration of asus:a8v-e_se has been fixed Configuration of asus:m2n-e has been fixed Configuration of asus:m2v has been fixed Configuration of asus:m2v-mx_se has been fixed Configuration of asus:m4a78-em has been fixed Configuration of asus:m4a785-m has been fixed Configuration of asus:mew-am has been fixed Configuration of asus:mew-vm has been fixed Configuration of asus:p2b has been fixed Configuration of asus:p2b-d has been fixed Configuration of asus:p2b-ds has been fixed Configuration of asus:p2b-f has been fixed Configuration of asus:p2b-ls has been fixed Configuration of asus:p3b-f has been fixed Configuration of axus:tc320 has been fixed Configuration of azza:pt-6ibd has been fixed Configuration of bcom:winnet100 has been fixed Configuration of bcom:winnetp680 has been fixed Configuration of biostar:m6tba has been fixed Configuration of broadcom:blast has been fixed Configuration of compaq:deskpro_en_sff_p600 has been fixed Configuration of dell:s1850 has been fixed Configuration of digitallogic:adl855pc has been fixed Configuration of digitallogic:msm586seg has been fixed Configuration of digitallogic:msm800sev has been fixed Configuration of eaglelion:5bcm has been fixed Configuration of ecs:p6iwp-fe has been fixed Configuration of emulation:qemu-x86 has been fixed Configuration of getac:p470 has been fixed Configuration of gigabyte:ga-6bxc has been fixed Configuration of gigabyte:ga-6bxe has been fixed Configuration of gigabyte:ga_2761gxdk has been fixed Configuration of gigabyte:m57sli has been fixed Configuration of gigabyte:ma785gmt has been fixed Configuration of gigabyte:ma78gm has been fixed Configuration of hp:dl145_g1 has been fixed Configuration of hp:dl145_g3 has been fixed Configuration of hp:dl165_g6_fam10 has been fixed Configuration of hp:e_vectra_p2706t has been fixed Configuration of ibase:mb899 has been fixed Configuration of ibm:e325 has been fixed Configuration of ibm:e326 has been fixed Configuration of iei:juki-511p has been fixed Configuration of iei:kino-780am2-fam10 has been fixed Configuration of iei:nova4899r has been fixed Configuration of iei:pcisa-lx-800-r10 has been fixed Configuration of intel:d810e2cb has been fixed Configuration of intel:d945gclf has been fixed Configuration of intel:eagleheights has been fixed Configuration of intel:jarrell has been fixed Configuration of intel:mtarvon has been fixed Configuration of intel:truxton has been fixed Configuration of intel:xe7501devkit has been fixed Configuration of iwave:iWRainbowG6 has been fixed Configuration of iwill:dk8_htx has been fixed Configuration of iwill:dk8s2 has been fixed Configuration of iwill:dk8x has been fixed Configuration of jetway:j7f24 has been fixed Configuration of jetway:pa78vm5 has been fixed Configuration of kontron:986lcd-m has been fixed Configuration of kontron:kt690 has been fixed Configuration of lanner:em8510 has been fixed Configuration of lippert:frontrunner has been fixed Configuration of lippert:hurricane-lx has been fixed Configuration of lippert:literunner-lx has been fixed Configuration of lippert:roadrunner-lx has been fixed Configuration of lippert:spacerunner-lx has been fixed Configuration of mitac:6513wu has been fixed Configuration of msi:ms6119 has been fixed Configuration of msi:ms6147 has been fixed Configuration of msi:ms6156 has been fixed Configuration of msi:ms6178 has been fixed Configuration of msi:ms7135 has been fixed Configuration of msi:ms7260 has been fixed Configuration of msi:ms9185 has been fixed Configuration of msi:ms9282 has been fixed Configuration of msi:ms9652_fam10 has been fixed Configuration of nec:powermate2000 has been fixed Configuration of newisys:khepri has been fixed Configuration of nokia:ip530 has been fixed Configuration of nvidia:l1_2pvv has been fixed Configuration of pcengines:alix1c has been fixed Configuration of pcengines:alix2d has been fixed Configuration of rca:rm4100 has been fixed Configuration of roda:rk886ex has been fixed Configuration of soyo:sy-6ba-plus-iii has been fixed Configuration of sunw:ultra40 has been fixed Configuration of supermicro:h8dme has been fixed Configuration of supermicro:h8dmr has been fixed Configuration of supermicro:h8dmr_fam10 has been fixed Configuration of supermicro:h8qme_fam10 has been fixed Configuration of supermicro:x6dai_g has been fixed Configuration of supermicro:x6dhe_g has been fixed Configuration of supermicro:x6dhe_g2 has been fixed Configuration of supermicro:x6dhr_ig has been fixed Configuration of supermicro:x6dhr_ig2 has been fixed Configuration of technexion:tim5690 has been fixed Configuration of technexion:tim8690 has been fixed Configuration of technologic:ts5300 has been fixed Configuration of televideo:tc7020 has been fixed Configuration of thomson:ip1000 has been fixed Configuration of traverse:geos has been fixed Configuration of tyan:s1846 has been fixed Configuration of tyan:s2735 has been fixed Configuration of tyan:s2850 has been fixed Configuration of tyan:s2875 has been fixed Configuration of tyan:s2880 has been fixed Configuration of tyan:s2881 has been fixed Configuration of tyan:s2882 has been fixed Configuration of tyan:s2885 has been fixed Configuration of tyan:s2891 has been fixed Configuration of tyan:s2892 has been fixed Configuration of tyan:s2895 has been fixed Configuration of tyan:s2912 has been fixed Configuration of tyan:s2912_fam10 has been fixed Configuration of tyan:s4880 has been fixed Configuration of tyan:s4882 has been fixed Configuration of via:epia has been fixed Configuration of via:epia-cn has been fixed Configuration of via:epia-m has been fixed Configuration of via:epia-m700 has been fixed Configuration of via:epia-n has been fixed Configuration of via:pc2500e has been fixed Configuration of via:vt8454c has been fixed Configuration of winent:pl6064 has been fixed Configuration of wyse:s50 has been fixed If something broke during this checkin please be a pain in zbao's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

build service results for r6263
by repository service 18 Jan '11

18 Jan '11

1 0

build service results for r6262
by repository service 18 Jan '11

18 Jan '11

1 0

build service results for r6261
by repository service 18 Jan '11

18 Jan '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "zbao" checked in revision 6261 to the coreboot repository. This caused the following changes: Change Log: remove the code which is not ready to release. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Zheng Bao <zheng.bao(a)amd.com> Build Log: Compilation of amd:bimini_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6261&device=bimini_fam10&v… If something broke during this checkin please be a pain in zbao's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[commit] r6265 - trunk
by repository service 18 Jan '11

18 Jan '11

Author: zbao Date: Tue Jan 18 10:36:44 2011 New Revision: 6265 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6265 Log: remove the code which is not ready to release. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Zheng Bao <zheng.bao(a)amd.com> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Jan 18 10:34:31 2011 (r6264) +++ trunk/Makefile Tue Jan 18 10:36:44 2011 (r6265) @@ -126,7 +126,6 @@ BUILD-y := src/lib src/boot src/console src/devices src/southbridge src/northbridge src/superio src/drivers BUILD-y += util/cbfstool util/sconfig BUILD-$(CONFIG_ARCH_X86) += src/pc80 -BUILD-y += src/vendorcode ifneq ($(CONFIG_LOCALVERSION),"") COREBOOT_EXTRA_VERSION := -$(call strip_quotes,$(CONFIG_LOCALVERSION))

1 0

[commit] r6264 - in trunk/src: mainboard/amd southbridge/amd
by repository service 18 Jan '11

18 Jan '11

Author: zbao Date: Tue Jan 18 10:34:31 2011 New Revision: 6264 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6264 Log: remove the code which is not ready to release. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Zheng Bao <zheng.bao(a)amd.com> Modified: trunk/src/mainboard/amd/Kconfig trunk/src/southbridge/amd/Kconfig trunk/src/southbridge/amd/Makefile.inc Modified: trunk/src/mainboard/amd/Kconfig ============================================================================== --- trunk/src/mainboard/amd/Kconfig Tue Jan 18 10:32:15 2011 (r6263) +++ trunk/src/mainboard/amd/Kconfig Tue Jan 18 10:34:31 2011 (r6264) @@ -23,8 +23,6 @@ bool "Serengeti Cheetah (Fam10)" config BOARD_AMD_TILAPIA_FAM10 bool "Tilapia (Fam10)" -config BOARD_AMD_BIMINI_FAM10 - bool "Bimini (Fam10)" endchoice @@ -38,7 +36,6 @@ source "src/mainboard/amd/serengeti_cheetah/Kconfig" source "src/mainboard/amd/serengeti_cheetah_fam10/Kconfig" source "src/mainboard/amd/tilapia_fam10/Kconfig" -source "src/mainboard/amd/bimini_fam10/Kconfig" config MAINBOARD_VENDOR string Modified: trunk/src/southbridge/amd/Kconfig ============================================================================== --- trunk/src/southbridge/amd/Kconfig Tue Jan 18 10:32:15 2011 (r6263) +++ trunk/src/southbridge/amd/Kconfig Tue Jan 18 10:34:31 2011 (r6264) @@ -10,4 +10,3 @@ source src/southbridge/amd/sb600/Kconfig source src/southbridge/amd/rs780/Kconfig source src/southbridge/amd/sb700/Kconfig -source src/southbridge/amd/cimx_wrapper/Kconfig Modified: trunk/src/southbridge/amd/Makefile.inc ============================================================================== --- trunk/src/southbridge/amd/Makefile.inc Tue Jan 18 10:32:15 2011 (r6263) +++ trunk/src/southbridge/amd/Makefile.inc Tue Jan 18 10:34:31 2011 (r6264) @@ -9,5 +9,4 @@ subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CS5530) += cs5530 subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CS5535) += cs5535 subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CS5536) += cs5536 -subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_WRAPPER) += cimx_wrapper

1 0

[commit] r6263 - trunk/src/southbridge/amd/cimx_wrapper
by repository service 18 Jan '11

18 Jan '11

Author: zbao Date: Tue Jan 18 10:32:15 2011 New Revision: 6263 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6263 Log: remove the code which is not ready to release. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Zheng Bao <zheng.bao(a)amd.com> Deleted: trunk/src/southbridge/amd/cimx_wrapper/

1 0

[commit] r6262 - trunk/src/mainboard/amd/bimini_fam10
by repository service 18 Jan '11

18 Jan '11

Author: zbao Date: Tue Jan 18 10:31:29 2011 New Revision: 6262 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6262 Log: remove the code which is not ready to release. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Zheng Bao <zheng.bao(a)amd.com> Deleted: trunk/src/mainboard/amd/bimini_fam10/

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2011