coreboot November 2009

coreboot@coreboot.org

55 participants
232 discussions

[PATCH 11/11] Write CPU entries at the right place.
by Magnus Christensson 12 Nov '09

12 Nov '09

Signed-off-by: Magnus Christensson <mch(a)virtutech.com> --- src/mptable.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mptable.c b/src/mptable.c index 5b308ec..391fe5a 100644 --- a/src/mptable.c +++ b/src/mptable.c @@ -62,7 +62,7 @@ mptable_init(void) struct mpt_cpu *cpus = (void*)&config[1]; int i, actual_cpu_count; for (i = 0, actual_cpu_count = 0; i < MaxCountCPUs; i++) { - struct mpt_cpu *cpu = &cpus[i]; + struct mpt_cpu *cpu = &cpus[actual_cpu_count]; int log_cpus = (ebx >> 16) & 0xff; log_cpus = 1UL << fls(log_cpus - 1); /* round up to power of 2 */ -- 1.6.2.5 --------------090606030602040601020704--

1 0

building error of family 10 code (in Kconfig)
by Zheng Bao 12 Nov '09

12 Nov '09

It is just me, or anyone has the building error like this. I don't that error when I buildtarget. It only happens when I make menuconfig. /home/baozheng/x86/coreboot-org/src/cpu/amd/model_10xxx/fidvid.c:42: warning: 'print_debug_fv_64' defined but not used CC lib/cbfs.o LINK coreboot /usr/bin/ld: section .id [00000001000eff61 -> 00000001000eff7f] overlaps section .rom [00000001000e0000 -> 00000001000f07cf] /usr/bin/ld: /home/baozheng/x86/coreboot-org/build/coreboot: section .id vma 0xeff61 overlaps previous sections /usr/bin/ld: /home/baozheng/x86/coreboot-org/build/coreboot: section .romstrap vma 0xeffa0 overlaps previous sections /usr/bin/ld: /home/baozheng/x86/coreboot-org/build/coreboot: section .text vma 0xf07d0 overlaps previous sections collect2: ld returned 1 exit status make: *** [/home/baozheng/x86/coreboot-org/build/coreboot] Error 1 _________________________________________________________________ Keep your friends updated―even when you’re not signed in. http://www.microsoft.com/middleeast/windows/windowslive/see-it-in-action/so…

2 1

[commit] r4937 - trunk/src/arch/i386/boot
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: myles Date: 2009-11-12 14:48:39 +0100 (Thu, 12 Nov 2009) New Revision: 4937 Modified: trunk/src/arch/i386/boot/coreboot_table.c Log: Get rid of the ugly warning the right way. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Modified: trunk/src/arch/i386/boot/coreboot_table.c =================================================================== --- trunk/src/arch/i386/boot/coreboot_table.c 2009-11-11 23:59:19 UTC (rev 4936) +++ trunk/src/arch/i386/boot/coreboot_table.c 2009-11-12 13:48:39 UTC (rev 4937) @@ -485,11 +485,9 @@ #if (CONFIG_HAVE_OPTION_TABLE == 1) { - struct lb_record *rec_dest, *rec_src; - /* Write the option config table... */ - rec_dest = lb_new_record(head); - rec_src = (struct lb_record *)(void *)&option_table; - memcpy(rec_dest, rec_src, rec_src->size); + struct lb_record *rec_dest = lb_new_record(head); + /* Copy the option config table, it's already a lb_record... */ + memcpy(rec_dest, &option_table, option_table.size); /* Create cmos checksum entry in coreboot table */ lb_cmos_checksum(head); }

1 0

Coreboot bug?
by Myles Watson 12 Nov '09

12 Nov '09

src/arch/i386/boot/coreboot_table.c: In function 'write_coreboot_table': src/arch/i386/boot/coreboot_table.c:492: warning: dereferencing pointer 'rec_src' does break strict-aliasing rules src/arch/i386/boot/coreboot_table.c:491: note: initialized from here #if (CONFIG_HAVE_OPTION_TABLE == 1) { struct lb_record *rec_dest, *rec_src; /* Write the option config table... */ rec_dest = lb_new_record(head); rec_src = (struct lb_record *)(void *)&option_table; memcpy(rec_dest, rec_src, rec_src->size); /* Create cmos checksum entry in coreboot table */ lb_cmos_checksum(head); } #endif from option_table.c: unsigned char option_table[] = { 0xc8,0x00,0x00,0x00,0x88,0x04,0x00,0x00,0x0c,0x00, ... from src/include/boot/coreboot_tables.h: struct lb_record { uint32_t tag; /* tag ID */ uint32_t size; /* size of record (in bytes) */ }; Why are we casting it as a lb_record * then using that size field in the copy? Thanks, Myles

4 25

Stack corruption problem with SeaBIOS/gPXE under QEMU
by Naphtali Sprei 12 Nov '09

12 Nov '09

Hi, I've found a problem with the usage of SeaBIOS/gPXE in Qemu. The scenario is when failing to boot from network and falling back to booting from hard-disk (-boot nc). The cause of the problem is that both SeaBIOS and gPXE (in it's installation phase) uses same stack area, 0x7c00. The gPXE code corrupts the SeaBIOS stack, so when gPXE returns to SeaBIOS chaos occurs. Output: "qemu: fatal: Trying to execute code outside RAM or ROM at 0x00000000eb300000" A simple hack/patch (attached) solves this problem, but a proper patch expected from the SeaBIOS guys. Enjoy, Naphtali Patch against current SeaBIOS git Signed-off-by: Naphtali Sprei <nsprei(a)redhat.com> --- src/arch/i386/prefix/pxeprefix.S | 2 +- src/arch/i386/prefix/romprefix.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arch/i386/prefix/pxeprefix.S b/src/arch/i386/prefix/pxeprefix.S index b541e4b..11dd45d 100644 --- a/src/arch/i386/prefix/pxeprefix.S +++ b/src/arch/i386/prefix/pxeprefix.S @@ -47,7 +47,7 @@ FILE_LICENCE ( GPL2_OR_LATER ) /* Set up stack just below 0x7c00 */ xorw %ax, %ax movw %ax, %ss - movl $0x7c00, %esp + movl $0x7a00, %esp /* Clear direction flag, for the sake of sanity */ cld /* Print welcome message */ diff --git a/src/arch/i386/prefix/romprefix.S b/src/arch/i386/prefix/romprefix.S index cb474e8..93f3f17 100644 --- a/src/arch/i386/prefix/romprefix.S +++ b/src/arch/i386/prefix/romprefix.S @@ -587,7 +587,7 @@ exec: /* Set %ds = %cs */ /* Obtain a reasonably-sized temporary stack */ xorw %ax, %ax movw %ax, %ss - movw $0x7c00, %sp + movw $0x7a00, %sp /* Install gPXE */ movl image_source, %esi -- 1.6.3.3

1 0

[commit] r4936 - trunk/src/arch/i386/boot
by svn＠coreboot.org 11 Nov '09

11 Nov '09

Author: myles Date: 2009-11-12 00:59:19 +0100 (Thu, 12 Nov 2009) New Revision: 4936 Modified: trunk/src/arch/i386/boot/coreboot_table.c Log: Revert my too-hasty commit. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/src/arch/i386/boot/coreboot_table.c =================================================================== --- trunk/src/arch/i386/boot/coreboot_table.c 2009-11-11 23:32:36 UTC (rev 4935) +++ trunk/src/arch/i386/boot/coreboot_table.c 2009-11-11 23:59:19 UTC (rev 4936) @@ -485,10 +485,11 @@ #if (CONFIG_HAVE_OPTION_TABLE == 1) { - struct lb_record *rec_dest; - /* Copy the option config table, it's already a lb_record... */ + struct lb_record *rec_dest, *rec_src; + /* Write the option config table... */ rec_dest = lb_new_record(head); - memcpy(rec_dest, &option_table, sizeof(option_table)); + rec_src = (struct lb_record *)(void *)&option_table; + memcpy(rec_dest, rec_src, rec_src->size); /* Create cmos checksum entry in coreboot table */ lb_cmos_checksum(head); }

1 0

[commit] r4935 - trunk/src/arch/i386/boot
by svn＠coreboot.org 11 Nov '09

11 Nov '09

Author: myles Date: 2009-11-12 00:32:36 +0100 (Thu, 12 Nov 2009) New Revision: 4935 Modified: trunk/src/arch/i386/boot/coreboot_table.c Log: Silence an ugly-looking warning. Two casts were not enough, so just don't cast it. Trust the option_table generator to get the length correct. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/src/arch/i386/boot/coreboot_table.c =================================================================== --- trunk/src/arch/i386/boot/coreboot_table.c 2009-11-11 21:32:23 UTC (rev 4934) +++ trunk/src/arch/i386/boot/coreboot_table.c 2009-11-11 23:32:36 UTC (rev 4935) @@ -485,11 +485,10 @@ #if (CONFIG_HAVE_OPTION_TABLE == 1) { - struct lb_record *rec_dest, *rec_src; - /* Write the option config table... */ + struct lb_record *rec_dest; + /* Copy the option config table, it's already a lb_record... */ rec_dest = lb_new_record(head); - rec_src = (struct lb_record *)(void *)&option_table; - memcpy(rec_dest, rec_src, rec_src->size); + memcpy(rec_dest, &option_table, sizeof(option_table)); /* Create cmos checksum entry in coreboot table */ lb_cmos_checksum(head); }

1 0

[commit] r4934 - in trunk: src/arch/i386 util/cbfstool util/newconfig
by svn＠coreboot.org 11 Nov '09

11 Nov '09

Author: oxygene Date: 2009-11-11 21:32:23 +0000 (Wed, 11 Nov 2009) New Revision: 4934 Modified: trunk/src/arch/i386/Kconfig trunk/src/arch/i386/Makefile.inc trunk/util/cbfstool/cbfstool.c trunk/util/newconfig/config.g Log: Rework bootblock size handling: - don't pretend to create a bootblock as large as the ROM in Kconfig (it's 64k at most) - don't pretend to accept a bootblocksize value in cbfstool create (it ignored it) - patch up the build systems to keep it working Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/src/arch/i386/Kconfig =================================================================== --- trunk/src/arch/i386/Kconfig 2009-11-11 19:31:53 UTC (rev 4933) +++ trunk/src/arch/i386/Kconfig 2009-11-11 21:32:23 UTC (rev 4934) @@ -20,12 +20,7 @@ config ROMBASE hex - default 0xffc00000 if COREBOOT_ROMSIZE_KB_4096 - default 0xffe00000 if COREBOOT_ROMSIZE_KB_2048 - default 0xfff00000 if COREBOOT_ROMSIZE_KB_1024 - default 0xfff80000 if COREBOOT_ROMSIZE_KB_512 - default 0xfffc0000 if COREBOOT_ROMSIZE_KB_256 - default 0xfffe0000 if COREBOOT_ROMSIZE_KB_128 + default 0xffff0000 config ROM_IMAGE_SIZE hex Modified: trunk/src/arch/i386/Makefile.inc =================================================================== --- trunk/src/arch/i386/Makefile.inc 2009-11-11 19:31:53 UTC (rev 4933) +++ trunk/src/arch/i386/Makefile.inc 2009-11-11 21:32:23 UTC (rev 4934) @@ -8,14 +8,13 @@ obj-$(CONFIG_HAVE_OPTION_TABLE) += ../../option_table.o ifdef POST_EVALUATION -BOOTBLOCK_SIZE=65536 ####################################################################### # Build the final rom image $(obj)/coreboot.rom: $(obj)/coreboot.bootblock $(obj)/coreboot_ram $(CBFSTOOL) rm -f $@ - $(CBFSTOOL) $@ create $(shell expr 1024 \* $(CONFIG_COREBOOT_ROMSIZE_KB)) $(BOOTBLOCK_SIZE) $(obj)/coreboot.bootblock + $(CBFSTOOL) $@ create $(shell expr 1024 \* $(CONFIG_COREBOOT_ROMSIZE_KB)) $(obj)/coreboot.bootblock if [ -f fallback/coreboot_apc ]; \ then \ $(CBFSTOOL) $@ add-stage fallback/coreboot_apc fallback/coreboot_apc $(CBFS_COMPRESS_FLAG); \ Modified: trunk/util/cbfstool/cbfstool.c =================================================================== --- trunk/util/cbfstool/cbfstool.c 2009-11-11 19:31:53 UTC (rev 4933) +++ trunk/util/cbfstool/cbfstool.c 2009-11-11 21:32:23 UTC (rev 4934) @@ -187,18 +187,17 @@ { char *romname = argv[1]; char *cmd = argv[2]; - if (argc < 6) { + if (argc < 5) { printf("not enough arguments to 'create'.\n"); return 1; } uint32_t size = strtoul(argv[3], NULL, 0); - /* ignore bootblock size. we use whatever we get and won't allocate any larger */ - char *bootblock = argv[5]; + char *bootblock = argv[4]; uint32_t align = 0; - if (argc > 6) - align = strtoul(argv[6], NULL, 0); + if (argc > 5) + align = strtoul(argv[5], NULL, 0); return create_cbfs_image(romname, size, bootblock, align); } @@ -255,7 +254,7 @@ "add FILE NAME TYPE [base address] Add a component\n" "add-payload FILE NAME [COMP] [base] Add a payload to the ROM\n" "add-stage FILE NAME [COMP] [base] Add a stage to the ROM\n" - "create SIZE BSIZE BOOTBLOCK [ALIGN] Create a ROM file\n" + "create SIZE BOOTBLOCK [ALIGN] Create a ROM file\n" "locate FILE NAME ALIGN Find a place for a file of that size\n" "print Show the contents of the ROM\n"); } Modified: trunk/util/newconfig/config.g =================================================================== --- trunk/util/newconfig/config.g 2009-11-11 19:31:53 UTC (rev 4933) +++ trunk/util/newconfig/config.g 2009-11-11 21:32:23 UTC (rev 4934) @@ -2295,8 +2295,8 @@ for j in i.roms: file.write(" %s/coreboot.rom " % j) file.write("> %s.bootblock\n\n" %i.name) - file.write("\t./cbfs/cbfstool %s create %s %s %s.bootblock\n" - %(i.name, romsize, bootblocksize, i.name)) + file.write("\t./cbfs/cbfstool %s create %s %s.bootblock\n" + %(i.name, romsize, i.name)) for j in pciroms: file.write("\t./cbfs/cbfstool %s add %s pci%04x,%04x.rom optionrom\n" % (i.name, j.name, j.pci_vid, j.pci_did)) for j in i.roms:

1 0

Ubiquiti embedded boards and Atheros chipset
by Chao, Shane (Contr) 11 Nov '09

11 Nov '09

Peter, If I want to port coreboot to Atheros chipset, can you please point me to a general direction on getting started? Thanks, Shane

1 0

[commit] r4933 - trunk/src/lib
by svn＠coreboot.org 11 Nov '09

11 Nov '09

Author: oxygene Date: 2009-11-11 19:31:53 +0000 (Wed, 11 Nov 2009) New Revision: 4933 Modified: trunk/src/lib/cbfs.c Log: Help track down enable_rom issues in CBFS. If the magic looks like unmapped memory, point to the wiki page with more information. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/src/lib/cbfs.c =================================================================== --- trunk/src/lib/cbfs.c 2009-11-10 22:17:15 UTC (rev 4932) +++ trunk/src/lib/cbfs.c 2009-11-11 19:31:53 UTC (rev 4933) @@ -66,6 +66,10 @@ printk_spew("magic is %08x\n", ntohl(header->magic)); if (ntohl(header->magic) != CBFS_HEADER_MAGIC) { printk_err("ERROR: No valid CBFS header found!\n"); + if (header->magic == 0xffffffff) { + printk_err("Maybe the ROM isn't entirely mapped yet?\n" + "See (and report to) http://www.coreboot.org/Infrastructure_Projects#CBFS\n"); + } return NULL; }

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot November 2009