coreboot November 2009

coreboot@coreboot.org

55 participants
232 discussions

[commit] r4943 - trunk/src/cpu/amd/socket_AM2r2
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: zbao Date: 2009-11-13 07:43:33 +0100 (Fri, 13 Nov 2009) New Revision: 4943 Modified: trunk/src/cpu/amd/socket_AM2r2/Kconfig Log: Complete the Kconfig of socket_AM2r2. This patch is from socket_F_1207, even though the fam10 can not be "make menuconfig"ed currently. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/src/cpu/amd/socket_AM2r2/Kconfig =================================================================== --- trunk/src/cpu/amd/socket_AM2r2/Kconfig 2009-11-12 20:06:32 UTC (rev 4942) +++ trunk/src/cpu/amd/socket_AM2r2/Kconfig 2009-11-13 06:43:33 UTC (rev 4943) @@ -2,6 +2,7 @@ bool select CPU_AMD_MODEL_10XXX select HT3_SUPPORT + select PCI_IO_CFG_EXT config CPU_SOCKET_TYPE hex @@ -14,3 +15,32 @@ default 0x0104 depends on CPU_AMD_SOCKET_AM2R2 +config EXT_RT_TBL_SUPPORT + bool + default n + depends on CPU_AMD_SOCKET_AM2R2 + +config EXT_CONF_SUPPORT + bool + default n + depends on CPU_AMD_SOCKET_AM2R2 + +config CBB + hex + default 0x0 + depends on CPU_AMD_SOCKET_AM2R2 + +config CDB + hex + default 0x18 + depends on CPU_AMD_SOCKET_AM2R2 + +config XIP_ROM_BASE + hex + default 0xfff80000 + depends on CPU_AMD_SOCKET_AM2R2 + +config XIP_ROM_SIZE + hex + default 0x80000 + depends on CPU_AMD_SOCKET_AM2R2

1 0

[PATCH] Kconfig of socket_AM2r2
by Bao, Zheng 12 Nov '09

12 Nov '09

This patch is from socket_F_1207. I need this to make my 780/700 board building, even though the fam10 can not be "make menuconfig"(ed) currently. Zheng ________________________________________ From: coreboot-bounces(a)coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Zheng Bao Sent: Sunday, November 08, 2009 11:58 AM To: coreboot(a)coreboot.org Subject: [coreboot] [PATCH] Kconfig of socket_AM2r2 Complete the Kconfig of socket_AM2r2. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Index: src/cpu/amd/socket_AM2r2/Kconfig =================================================================== --- src/cpu/amd/socket_AM2r2/Kconfig (revision 4914) +++ src/cpu/amd/socket_AM2r2/Kconfig (working copy) @@ -2,6 +2,7 @@ bool select CPU_AMD_MODEL_10XXX select HT3_SUPPORT + select PCI_IO_CFG_EXT config CPU_SOCKET_TYPE hex @@ -14,3 +15,32 @@ default 0x0104 depends on CPU_AMD_SOCKET_AM2R2 +config EXT_RT_TBL_SUPPORT + bool + default n + depends on CPU_AMD_SOCKET_AM2R2 + +config EXT_CONF_SUPPORT + bool + default n + depends on CPU_AMD_SOCKET_AM2R2 + +config CBB + hex + default 0x0 + depends on CPU_AMD_SOCKET_AM2R2 + +config CDB + hex + default 0x18 + depends on CPU_AMD_SOCKET_AM2R2 + +config XIP_ROM_BASE + hex + default 0xfff80000 + depends on CPU_AMD_SOCKET_AM2R2 + +config XIP_ROM_SIZE + hex + default 0x80000 + depends on CPU_AMD_SOCKET_AM2R2 ________________________________________ Windows Live: Keep your friends up to date with what you do online. -- coreboot mailing list: coreboot(a)coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

2 1

[BuildROM] r277 - in buildrom-devel: config/payloads packages/kernel scripts
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: myles Date: 2009-11-13 00:08:34 +0100 (Fri, 13 Nov 2009) New Revision: 277 Modified: buildrom-devel/config/payloads/Config.in buildrom-devel/config/payloads/kernel.conf buildrom-devel/config/payloads/lab.conf buildrom-devel/packages/kernel/kernel.inc buildrom-devel/scripts/Makefile.kernel buildrom-devel/scripts/Makefile.lab Log: Clean up command line for LAB. Add kernel-refresh target. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: buildrom-devel/config/payloads/Config.in =================================================================== --- buildrom-devel/config/payloads/Config.in 2009-09-25 19:55:13 UTC (rev 276) +++ buildrom-devel/config/payloads/Config.in 2009-11-12 23:08:34 UTC (rev 277) @@ -143,6 +143,12 @@ help Say 'Y' here to include the busybox tools +config LAB_CMDLINE + string "Kernel command line for LAB" + default "console=tty0 earlyprintk=serial,ttyS0,115200,keep rdinit=/linuxrc" + help + Specify the kernel command line to use for the kernel. This is + passed to mkelfimage when the kernel is built. endmenu menu "Memtest86 Configuration" Modified: buildrom-devel/config/payloads/kernel.conf =================================================================== --- buildrom-devel/config/payloads/kernel.conf 2009-09-25 19:55:13 UTC (rev 276) +++ buildrom-devel/config/payloads/kernel.conf 2009-11-12 23:08:34 UTC (rev 277) @@ -4,10 +4,6 @@ PAYLOAD_BUILD=scripts/Makefile.kernel -### Payload specific configuration - -COMMAND_LINE=$(CONFIG_CMDLINE) - ########################################### # You shouldn't change anything under this point ########################################### Modified: buildrom-devel/config/payloads/lab.conf =================================================================== --- buildrom-devel/config/payloads/lab.conf 2009-09-25 19:55:13 UTC (rev 276) +++ buildrom-devel/config/payloads/lab.conf 2009-11-12 23:08:34 UTC (rev 277) @@ -6,9 +6,6 @@ ### Payload specific configuration -# Specify the default command line for the image -COMMAND_LINE=console=tty0 console=ttyS0,115200 rdinit=/linuxrc - # This is the version string printed during boot. ifeq ($(CONFIG_PLATFORM_OLPC),y) Modified: buildrom-devel/packages/kernel/kernel.inc =================================================================== --- buildrom-devel/packages/kernel/kernel.inc 2009-09-25 19:55:13 UTC (rev 276) +++ buildrom-devel/packages/kernel/kernel.inc 2009-11-12 23:08:34 UTC (rev 277) @@ -87,6 +87,11 @@ generic-kernel: $(OUTPUT_DIR)/bzImage $(OUTPUT_DIR)/vmlinux $(KERNEL_STAMP_DIR)/.headers +kernel-refresh: + @ echo "Refreshing kernel..." + @ touch $(KERNEL_SRC_DIR)/.config + @ $(MAKE) payload + generic-kernel-clean: @ echo "Cleaning kernel..." @ rm -f $(KERNEL_STAMP_DIR)/.headers Modified: buildrom-devel/scripts/Makefile.kernel =================================================================== --- buildrom-devel/scripts/Makefile.kernel 2009-09-25 19:55:13 UTC (rev 276) +++ buildrom-devel/scripts/Makefile.kernel 2009-11-12 23:08:34 UTC (rev 277) @@ -4,7 +4,7 @@ @ echo "Building the ELF payload..." @ rm -f $@ @ $(STAGING_DIR)/sbin/mkelfImage --type bzImage-i386 \ - --command-line=$(COMMAND_LINE) $(OUTPUT_DIR)/bzImage $@ + --command-line=$(CONFIG_CMDLINE) $(OUTPUT_DIR)/bzImage $@ @ chmod 0644 $@ $(OUTPUT_DIR)/kernel-payload.elf.lzma: $(OUTPUT_DIR)/kernel-payload.elf Modified: buildrom-devel/scripts/Makefile.lab =================================================================== --- buildrom-devel/scripts/Makefile.lab 2009-09-25 19:55:13 UTC (rev 276) +++ buildrom-devel/scripts/Makefile.lab 2009-11-12 23:08:34 UTC (rev 277) @@ -7,21 +7,21 @@ @ echo "Cleaning up shared libraries..." - find $(INITRD_DIR) -type f -perm +100 -exec file -rNF '' {} \; | \ + @ find $(INITRD_DIR) -type f -perm +100 -exec file -rNF '' {} \; | \ awk ' /executable.*dynamically/ { print $$1}' > $(INITRD_DIR)/.list - (cd $(INITRD_DIR); export CFLAGS="$(CROSS_CFLAGS)"; \ + @ (cd $(INITRD_DIR); export CFLAGS="$(CROSS_CFLAGS)"; \ python $(BIN_DIR)/mklibs.py \ --root $(STAGING_DIR) -d ./ `cat $(INITRD_DIR)/.list` > /dev/null) - rm -f $(INITRD_DIR)/.list + @ rm -f $(INITRD_DIR)/.list - echo "BUILDROM LAB $(ROM_VERSION)" > $(INITRD_DIR)/buildrom-version - echo -n "Build timestamp: " >> $(INITRD_DIR)/buildrom-version - date "+%Y%m%d %H:%M:%S" >> $(INITRD_DIR)/buildrom-version + @ echo "BUILDROM LAB $(ROM_VERSION)" > $(INITRD_DIR)/buildrom-version + @ echo -n "Build timestamp: " >> $(INITRD_DIR)/buildrom-version + @ date "+%Y%m%d %H:%M:%S" >> $(INITRD_DIR)/buildrom-version - echo "Building the initrd..." - install -d $(OUTPUT_DIR) - cd $(INITRD_DIR); find . | cpio -o -H newc 2> /dev/null > $@ + @ echo "Building the initrd..." + @ install -d $(OUTPUT_DIR) + @ cd $(INITRD_DIR); find . | cpio -o -H newc 2> /dev/null > $@ $(OUTPUT_DIR)/initrd: $(OUTPUT_DIR)/initrd.uncompressed @ gzip -9 -c -n $< > $@ @@ -29,7 +29,7 @@ $(OUTPUT_DIR)/lab-payload-uncompressed.elf: $(OUTPUT_DIR)/initrd.uncompressed @ echo "Building the uncompressed ELF payload..." @ rm -f $@ - @ $(STAGING_DIR)/sbin/mkelfImage --command-line="$(COMMAND_LINE)" \ + @ $(STAGING_DIR)/sbin/mkelfImage --command-line=$(CONFIG_LAB_CMDLINE) \ --ramdisk=$(OUTPUT_DIR)/initrd.uncompressed \ $(OUTPUT_DIR)/vmlinux $@ @ chmod 0644 $@ @@ -37,7 +37,7 @@ $(OUTPUT_DIR)/lab-payload.elf: $(OUTPUT_DIR)/initrd @ echo "Building the ELF payload..." @ rm -f $@ - @ $(STAGING_DIR)/sbin/mkelfImage --command-line="$(COMMAND_LINE)" \ + @ $(STAGING_DIR)/sbin/mkelfImage --command-line=$(CONFIG_LAB_CMDLINE) \ --ramdisk=$(OUTPUT_DIR)/initrd $(OUTPUT_DIR)/vmlinux $@ @ chmod 0644 $@ @ $(BIN_DIR)/checkrom.sh $@

1 0

[commit] r4942 - trunk/util/cbfstool
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: uwe Date: 2009-11-12 21:06:32 +0100 (Thu, 12 Nov 2009) New Revision: 4942 Modified: trunk/util/cbfstool/common.c Log: Cosmetics (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/util/cbfstool/common.c =================================================================== --- trunk/util/cbfstool/common.c 2009-11-12 17:46:59 UTC (rev 4941) +++ trunk/util/cbfstool/common.c 2009-11-12 20:06:32 UTC (rev 4942) @@ -250,7 +250,7 @@ ntohl(thisfile->offset), align); } printf("Could not add the file to CBFS, it's probably too big.\n"); - printf("File size %d bytes (%dK).\n", contentsize, contentsize/1024); + printf("File size: %d bytes (%d KB).\n", contentsize, contentsize/1024); return 1; }

1 0

Re: [coreboot] [commit] r4939 - in trunk: . src src/arch/i386/boot src/arch/i386/include/arch/smp src/console src/cpu/emulation/qemu-x86 src/devices src/include/smp src/lib src/mainboard/emulation/qemu-x86 util/x86emu
by Peter Stuge 12 Nov '09

12 Nov '09

svn(a)coreboot.org wrote: > +++ trunk/src/include/smp/spinlock.h 2009-11-12 16:38:03 UTC (rev 4939) .. > -/* Most GCC versions have a nasty bug with empty initializers */ > -#if (__GNUC__ > 2) Maybe add #if __GNUC__ < 3 #error Sorry, at least gcc-3 is needed to build coreboot. #endif ? //Peter

3 2

[commit] r4941 - trunk/util/cbfstool
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: myles Date: 2009-11-12 18:46:59 +0100 (Thu, 12 Nov 2009) New Revision: 4941 Modified: trunk/util/cbfstool/common.c Log: Print size of file on cbfs_add_file failure. The size of the file after compression is nice to know. Trivial Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/util/cbfstool/common.c =================================================================== --- trunk/util/cbfstool/common.c 2009-11-12 17:25:16 UTC (rev 4940) +++ trunk/util/cbfstool/common.c 2009-11-12 17:46:59 UTC (rev 4941) @@ -250,6 +250,7 @@ ntohl(thisfile->offset), align); } printf("Could not add the file to CBFS, it's probably too big.\n"); + printf("File size %d bytes (%dK).\n", contentsize, contentsize/1024); return 1; }

1 0

[commit] r4940 - trunk/src/arch/i386
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: oxygene Date: 2009-11-12 18:25:16 +0100 (Thu, 12 Nov 2009) New Revision: 4940 Modified: trunk/src/arch/i386/Kconfig Log: Adapt ROM_IMAGE_SIZE, too. ROMBASE should probably be defined by ROM_IMAGE_SIZE (so ROM_IMAGE_SIZE + ROMBASE - 4GB == 0), but that's for another patch. Should fix the issues created by the bootblock cleanup patch. Build tested on kontron/986lcd-m, trivial change. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Modified: trunk/src/arch/i386/Kconfig =================================================================== --- trunk/src/arch/i386/Kconfig 2009-11-12 16:38:03 UTC (rev 4939) +++ trunk/src/arch/i386/Kconfig 2009-11-12 17:25:16 UTC (rev 4940) @@ -24,12 +24,7 @@ config ROM_IMAGE_SIZE hex - default 0x400000 if COREBOOT_ROMSIZE_KB_4096 - default 0x200000 if COREBOOT_ROMSIZE_KB_2048 - default 0x100000 if COREBOOT_ROMSIZE_KB_1024 - default 0x80000 if COREBOOT_ROMSIZE_KB_512 - default 0x40000 if COREBOOT_ROMSIZE_KB_256 - default 0x20000 if COREBOOT_ROMSIZE_KB_128 + default 0x10000 config RAMBASE hex

1 0

[commit] r4939 - in trunk: . src src/arch/i386/boot src/arch/i386/include/arch/smp src/console src/cpu/emulation/qemu-x86 src/devices src/include/smp src/lib src/mainboard/emulation/qemu-x86 util/x86emu
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: myles Date: 2009-11-12 17:38:03 +0100 (Thu, 12 Nov 2009) New Revision: 4939 Modified: trunk/Makefile trunk/src/Kconfig trunk/src/arch/i386/boot/coreboot_table.c trunk/src/arch/i386/include/arch/smp/spinlock.h trunk/src/console/printk.c trunk/src/console/vsprintf.c trunk/src/cpu/emulation/qemu-x86/northbridge.c trunk/src/devices/device.c trunk/src/include/smp/spinlock.h trunk/src/lib/cbmem.c trunk/src/mainboard/emulation/qemu-x86/Kconfig trunk/util/x86emu/x86.c Log: Add CONFIG_WARNINGS_ARE_ERRORS and set it for qemu. Remove all remaining warnings from qemu. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Modified: trunk/Makefile =================================================================== --- trunk/Makefile 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/Makefile 2009-11-12 16:38:03 UTC (rev 4939) @@ -247,6 +247,9 @@ CFLAGS += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS += -Wwrite-strings -Wredundant-decls -Wno-trigraphs CFLAGS += -Wstrict-aliasing -Wshadow +ifeq ($(CONFIG_WARNINGS_ARE_ERRORS),y) +CFLAGS += -Werror +endif CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CBFS_COMPRESS_FLAG:=l Modified: trunk/src/Kconfig =================================================================== --- trunk/src/Kconfig 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/Kconfig 2009-11-12 16:38:03 UTC (rev 4939) @@ -463,3 +463,7 @@ config ENABLE_APIC_EXT_ID bool default n + +config WARNINGS_ARE_ERRORS + bool + default n Modified: trunk/src/arch/i386/boot/coreboot_table.c =================================================================== --- trunk/src/arch/i386/boot/coreboot_table.c 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/arch/i386/boot/coreboot_table.c 2009-11-12 16:38:03 UTC (rev 4939) @@ -65,11 +65,13 @@ return rec; } +#if 0 static struct lb_record *lb_next_record(struct lb_record *rec) { rec = (void *)(((char *)rec) + rec->size); return rec; } +#endif static struct lb_record *lb_new_record(struct lb_header *header) { @@ -218,6 +220,7 @@ } +#if CONFIG_WRITE_HIGH_TABLES == 1 static struct lb_forward *lb_forward(struct lb_header *header, struct lb_header *next_header) { struct lb_record *rec; @@ -229,6 +232,7 @@ forward->forward = (uint64_t)(unsigned long)next_header; return forward; } +#endif void lb_memory_range(struct lb_memory *mem, uint32_t type, uint64_t start, uint64_t size) Modified: trunk/src/arch/i386/include/arch/smp/spinlock.h =================================================================== --- trunk/src/arch/i386/include/arch/smp/spinlock.h 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/arch/i386/include/arch/smp/spinlock.h 2009-11-12 16:38:03 UTC (rev 4939) @@ -11,6 +11,7 @@ #define SPIN_LOCK_UNLOCKED (spinlock_t) { 1 } +#define DECLARE_SPIN_LOCK(x) static spinlock_t x = SPIN_LOCK_UNLOCKED; /* * Simple spin lock operations. There are two variants, one clears IRQ's Modified: trunk/src/console/printk.c =================================================================== --- trunk/src/console/printk.c 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/console/printk.c 2009-11-12 16:38:03 UTC (rev 4939) @@ -23,7 +23,7 @@ int minimum_console_loglevel = MINIMUM_CONSOLE_LOGLEVEL; int default_console_loglevel = CONFIG_DEFAULT_CONSOLE_LOGLEVEL; -static spinlock_t console_lock = SPIN_LOCK_UNLOCKED; +DECLARE_SPIN_LOCK(console_lock) int do_printk(int msg_level, const char *fmt, ...) { Modified: trunk/src/console/vsprintf.c =================================================================== --- trunk/src/console/vsprintf.c 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/console/vsprintf.c 2009-11-12 16:38:03 UTC (rev 4939) @@ -24,7 +24,7 @@ #include <smp/spinlock.h> #include <console/vtxprintf.h> -static spinlock_t vsprintf_lock = SPIN_LOCK_UNLOCKED; +DECLARE_SPIN_LOCK(vsprintf_lock) static char *str_buf; Modified: trunk/src/cpu/emulation/qemu-x86/northbridge.c =================================================================== --- trunk/src/cpu/emulation/qemu-x86/northbridge.c 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/cpu/emulation/qemu-x86/northbridge.c 2009-11-12 16:38:03 UTC (rev 4939) @@ -8,6 +8,7 @@ #include <bitops.h> #include "chip.h" #include "northbridge.h" +#include <delay.h> static void ram_resource(device_t dev, unsigned long index, unsigned long basek, unsigned long sizek) @@ -157,9 +158,9 @@ .enable_dev = enable_dev, }; -void udelay(int usecs) +void udelay(unsigned usecs) { - int i; + unsigned i; for(i = 0; i < usecs; i++) inb(0x80); } Modified: trunk/src/devices/device.c =================================================================== --- trunk/src/devices/device.c 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/devices/device.c 2009-11-12 16:38:03 UTC (rev 4939) @@ -58,7 +58,9 @@ * * @see device_path */ -static spinlock_t dev_lock = SPIN_LOCK_UNLOCKED; + +DECLARE_SPIN_LOCK(dev_lock) + device_t alloc_dev(struct bus *parent, struct device_path *path) { device_t dev, child; Modified: trunk/src/include/smp/spinlock.h =================================================================== --- trunk/src/include/smp/spinlock.h 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/include/smp/spinlock.h 2009-11-12 16:38:03 UTC (rev 4939) @@ -5,15 +5,7 @@ #include <arch/smp/spinlock.h> #else /* !CONFIG_SMP */ -/* Most GCC versions have a nasty bug with empty initializers */ -#if (__GNUC__ > 2) -typedef struct { } spinlock_t; -#define SPIN_LOCK_UNLOCKED (spinlock_t) { } -#else -typedef struct { int gcc_is_buggy; } spinlock_t; -#define SPIN_LOCK_UNLOCKED (spinlock_t) { 0 } -#endif - +#define DECLARE_SPIN_LOCK(x) #define barrier() do {} while(0) #define spin_is_locked(lock) 0 #define spin_unlock_wait(lock) do {} while(0) Modified: trunk/src/lib/cbmem.c =================================================================== --- trunk/src/lib/cbmem.c 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/lib/cbmem.c 2009-11-12 16:38:03 UTC (rev 4939) @@ -35,9 +35,6 @@ #define MAX_CBMEM_ENTRIES 16 #define CBMEM_MAGIC 0x434f5245 -static void *cbmem_base; -static int cbmem_size; - struct cbmem_entry { u32 magic; u32 id; @@ -151,7 +148,7 @@ cbmem_toc[0].base += size; cbmem_toc[0].size -= size; - return (void *)cbmem_toc[i].base; + return (void *)(u32)cbmem_toc[i].base; } void *cbmem_find(u32 id) Modified: trunk/src/mainboard/emulation/qemu-x86/Kconfig =================================================================== --- trunk/src/mainboard/emulation/qemu-x86/Kconfig 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/src/mainboard/emulation/qemu-x86/Kconfig 2009-11-12 16:38:03 UTC (rev 4939) @@ -5,6 +5,7 @@ select CPU_EMULATION_QEMU_X86 select HAVE_PIRQ_TABLE select BOARD_ROMSIZE_KB_256 + select WARNINGS_ARE_ERRORS config MAINBOARD_DIR string Modified: trunk/util/x86emu/x86.c =================================================================== --- trunk/util/x86emu/x86.c 2009-11-12 16:20:04 UTC (rev 4938) +++ trunk/util/x86emu/x86.c 2009-11-12 16:38:03 UTC (rev 4939) @@ -126,7 +126,7 @@ void run_bios(struct device *dev, unsigned long addr) { /* clear vga bios data area */ - memset(0x400, 0, 0x200); + memset((void *)0x400, 0, 0x200); /* Set up C interrupt handlers */ setup_interrupt_handlers();

1 0

[PATCH] No warnings for qemu build
by Myles Watson 12 Nov '09

12 Nov '09

I think we should be pushing down the number of warnings in our code with the goal of being able to use -Werror for all of our boards. It's possible that we should add -Wno-unused-function, since there are lots of those warnings that would be hard to avoid, but it would help us keep our size down if we don't ignore that warning. The attached patch adds a Kconfig variable WARNINGS_ARE_ERRORS and sets it for qemu. I think the changes all make sense except for casting a cbmem_entry.base to u32 before void* in cbmem.c. The problem is that it is a very large can of worms to do it right and still allow 64-bit pointers in a cbmem entry. Stefan: - Do we need cbmem entries above 4GB? - Can we use void* for base instead of u64? I like the idea of using pointers for pointers. - What's the "right" way? Other changes: - include delay.h and make the prototype match in emulation/northbridge.c - remove unused cbmem_base and cbmem_size variables - cast 0x400 to a (void*) before passing it to memset - conditionally define lb_forward since it is only used with high_tables - add a DECLARE_SPIN_LOCK macro to avoid unused spin locks - remove unneeded gcc workaround once there are no unused spin locks Abuild tested. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Thanks, Myles Removed warnings: src/lib/cbmem.c: In function 'cbmem_add': src/lib/cbmem.c:154: warning: cast to pointer from integer of different size src/lib/cbmem.c: At top level: src/lib/cbmem.c:38: warning: 'cbmem_base' defined but not used src/lib/cbmem.c:39: warning: 'cbmem_size' defined but not used src/console/printk.c:26: warning: 'console_lock' defined but not used src/console/vsprintf.c:27: warning: 'vsprintf_lock' defined but not used src/devices/device.c:61: warning: 'dev_lock' defined but not used util/x86emu/x86.c: In function 'run_bios': util/x86emu/x86.c:129: warning: passing argument 1 of 'memset' makes pointer from integer without a cast /home/myles/try/buildrom-devel/work/coreboot/svn/src/include/string.h:9: note: expected 'void *' but argument is of type 'int' src/arch/i386/boot/coreboot_table.c:68: warning: 'lb_next_record' defined but not used src/arch/i386/boot/coreboot_table.c:221: warning: 'lb_forward' defined but not used src/cpu/emulation/qemu-x86/northbridge.c:160: warning: no previous prototype for 'udelay'

2 2

[commit] r4938 - trunk/util/romcc
by svn＠coreboot.org 12 Nov '09

12 Nov '09

Author: myles Date: 2009-11-12 17:20:04 +0100 (Thu, 12 Nov 2009) New Revision: 4938 Modified: trunk/util/romcc/romcc.c Log: Trivial debug print format string fix for romcc. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/util/romcc/romcc.c =================================================================== --- trunk/util/romcc/romcc.c 2009-11-12 13:48:39 UTC (rev 4937) +++ trunk/util/romcc/romcc.c 2009-11-12 16:20:04 UTC (rev 4938) @@ -21096,7 +21096,7 @@ fblock = lnode->fblock; if (state->compiler->debug & DEBUG_SCC_TRANSFORM) { - fprintf(state->errout, "sedge: %5d (%5d -> %5d)\n", + fprintf(state->errout, "sedge: %5ld (%5d -> %5d)\n", sedge - scc.ssa_edges, sedge->src->def->id, sedge->dst->def->id);

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot November 2009