coreboot January 2008

coreboot@coreboot.org

79 participants
347 discussions

[LinuxBIOS] [RFC] Macros vs. functions for better readability
by Carl-Daniel Hailfinger 07 Jan '08

07 Jan '08

Hi, it seems we sometimes have lots of repetitive code sequences which could be simplified by use of macros or functions. For a really shining example see Torsten Duwe's recent patch titled "beautify m57sli mptable.c". Cut-and-paste errors can happen and eliminating repetitive code reduces the risk of such errors. Besides that, having code with shorter lines through factoring out open-coded functions makes understanding the code easier. How do we factor out such code? I prefer macros for simple function wrappers and functions for multiline sequences. Comments? Regards, Carl-Daniel

4 5

[LinuxBIOS] [PATCH] document the GPIO setup of A8V-E and fix power sequencing for suspend
by Rudolf Marek 06 Jan '08

06 Jan '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, Attached patch documents the GPIO setup of the board (check board wiki page) and fixes the W83627EHF settings for suspend. Signed-off-by: Rudolf Marek <r.marek(a)assembler.cz> Thanks, Rudolf -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHgB3n3J9wPJqZRNURAqEWAJ9xjgUJLuOu4+71eUIx+XR37lPyRQCgyy/o /GF966Lx1IMR4yLm+p3Y9rA= =YGr3 -----END PGP SIGNATURE-----

2 2

[LinuxBIOS] r3034 build service
by LinuxBIOS information 06 Jan '08

06 Jan '08

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "duwe" checked in revision 3034 to the LinuxBIOS source repository and caused the following changes: Change Log: Since a VGA console and the need to run any option ROMs are rather independent, lift the implicit (broken) assumption that CONSOLE_VGA would also run the ROMs, and transfer it to a new config option VGA_ROM_RUN. This change is minimally intrusive, because all board configs that previously assumed CONSOLE_VGA would also run the ROMs didn't compile, they had to also specify PCI_ROM_RUN. Based on patches by Ron Minnich (fix the compile) and Luc Verhaegen (separate ROM_RUN from VGA console). Signed-off-by: Torsten Duwe <duwe(a)lst.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Luc Verhaegen <libv(a)skynet.be> Build Log: Compilation of amd:serengeti_cheetah_fam10 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=3034&device=serengeti_che… If something broke during this checkin please be a pain in duwe's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

Re: [LinuxBIOS] r3034 - in trunk/LinuxBIOSv2/src: config devices
by Peter Stuge 06 Jan '08

06 Jan '08

On Sun, Jan 06, 2008 at 02:10:54AM +0100, svn(a)openbios.org wrote: > Author: duwe > Date: 2008-01-06 02:10:54 +0100 (Sun, 06 Jan 2008) > New Revision: 3034 What about all the boards that this affects? //Peter

2 2

[LinuxBIOS] RESEND: patch: fix the problem with CONFIG_CONSOLE_VGA not pulling in the emulator
by ron minnich 06 Jan '08

06 Jan '08

This is a resend from yesterday, I am hoping for an ack :-) ron

5 15

[LinuxBIOS] r3034 - in trunk/LinuxBIOSv2/src: config devices
by svn＠openbios.org 06 Jan '08

06 Jan '08

Author: duwe Date: 2008-01-06 02:10:54 +0100 (Sun, 06 Jan 2008) New Revision: 3034 Modified: trunk/LinuxBIOSv2/src/config/Options.lb trunk/LinuxBIOSv2/src/devices/Config.lb trunk/LinuxBIOSv2/src/devices/pci_device.c Log: Since a VGA console and the need to run any option ROMs are rather independent, lift the implicit (broken) assumption that CONSOLE_VGA would also run the ROMs, and transfer it to a new config option VGA_ROM_RUN. This change is minimally intrusive, because all board configs that previously assumed CONSOLE_VGA would also run the ROMs didn't compile, they had to also specify PCI_ROM_RUN. Based on patches by Ron Minnich (fix the compile) and Luc Verhaegen (separate ROM_RUN from VGA console). Signed-off-by: Torsten Duwe <duwe(a)lst.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Luc Verhaegen <libv(a)skynet.be> Modified: trunk/LinuxBIOSv2/src/config/Options.lb =================================================================== --- trunk/LinuxBIOSv2/src/config/Options.lb 2008-01-04 17:22:44 UTC (rev 3033) +++ trunk/LinuxBIOSv2/src/config/Options.lb 2008-01-06 01:10:54 UTC (rev 3034) @@ -415,7 +415,7 @@ define CONFIG_CONSOLE_VGA default 0 export always - comment "Log messages to VGA" + comment "Log messages to any VGA-compatible device (may require *_ROM_RUN to bring up)" end define CONFIG_CONSOLE_VGA_MULTI default 0 @@ -1027,10 +1027,16 @@ comment "CPU hardware address lines num, for AMD K8 could be 40, and AMD family 10 could be 48" end +define CONFIG_VGA_ROM_RUN + default 0 + export always + comment "Init x86 ROMs on VGA-class PCI devices" +end + define CONFIG_PCI_ROM_RUN default 0 export always - comment "Init PCI device option rom" + comment "Init x86 ROMs on all PCI devices" end define CONFIG_PCI_64BIT_PREF_MEM Modified: trunk/LinuxBIOSv2/src/devices/Config.lb =================================================================== --- trunk/LinuxBIOSv2/src/devices/Config.lb 2008-01-04 17:22:44 UTC (rev 3033) +++ trunk/LinuxBIOSv2/src/devices/Config.lb 2008-01-06 01:10:54 UTC (rev 3034) @@ -1,4 +1,5 @@ uses CONFIG_PCI_ROM_RUN +uses CONFIG_VGA_ROM_RUN object device.o object root_device.o object device_util.o @@ -15,4 +16,9 @@ if CONFIG_PCI_ROM_RUN object pci_rom.o dir emulator +else +if CONFIG_VGA_ROM_RUN + object pci_rom.o + dir emulator end +end Modified: trunk/LinuxBIOSv2/src/devices/pci_device.c =================================================================== --- trunk/LinuxBIOSv2/src/devices/pci_device.c 2008-01-04 17:22:44 UTC (rev 3033) +++ trunk/LinuxBIOSv2/src/devices/pci_device.c 2008-01-06 01:10:54 UTC (rev 3034) @@ -643,16 +643,14 @@ ((device & 0xffff) << 16) | (vendor & 0xffff)); } +/** default handler: only runs the relevant pci bios. */ void pci_dev_init(struct device *dev) { -#if CONFIG_CONSOLE_VGA == 1 - extern int vga_inited; -#endif -#if CONFIG_PCI_ROM_RUN == 1 || CONFIG_CONSOLE_VGA == 1 +#if CONFIG_PCI_ROM_RUN == 1 || CONFIG_VGA_ROM_RUN == 1 struct rom_header *rom, *ram; #if CONFIG_PCI_ROM_RUN != 1 - /* We want to execute VGA option ROMs when CONFIG_CONSOLE_VGA + /* We want to execute VGA option ROMs when CONFIG_VGA_ROM_RUN * is set but CONFIG_PCI_ROM_RUN is not. In this case we skip * all other option ROM types. */ @@ -671,14 +669,13 @@ run_bios(dev, ram); #if CONFIG_CONSOLE_VGA == 1 - /* vga_inited is a trigger of the VGA console code. - * - * Only set it if we enabled VGA console, and if we - * just initialized a VGA card. - */ - vga_inited|=dev->class==PCI_CLASS_DISPLAY_VGA; -#endif -#endif + /* vga_inited is a trigger of the VGA console code. */ + if (dev->class == PCI_CLASS_DISPLAY_VGA) { + extern int vga_inited; + vga_inited = 1; + } +#endif /* CONFIG_CONSOLE_VGA */ +#endif /* CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN */ } /** Default device operation for PCI devices */

1 0

[LinuxBIOS] empty payload
by ron minnich 06 Jan '08

06 Jan '08

I'm writing an 'empty' payload for testing. It will do nothing but POST and send out chars in a tight loop. I am wondering about making it part of v3 tree. Just make an emptypayload directory. This would make testing easier. I don't know, comments? ron

4 3

[LinuxBIOS] patch a trivial error in stage1.c
by ron minnich 05 Jan '08

05 Jan '08

attached ron

3 2

[LinuxBIOS] v3: FIRST PAYLOAD RUN!
by ron minnich 05 Jan '08

05 Jan '08

I just ran the first actual payload on the alix1c with v3. I must admit, to my embarassment, that it was a RET instruction, but you have to start somewhere, right? It's a start. ron

2 1

[LinuxBIOS] r548 - LinuxBIOSv3/arch/x86
by svn＠openbios.org 05 Jan '08

05 Jan '08

Author: hailfinger Date: 2008-01-05 02:35:57 +0100 (Sat, 05 Jan 2008) New Revision: 548 Modified: LinuxBIOSv3/arch/x86/stage1.c Log: Fix a simple error in stage1.c (missing else). Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: LinuxBIOSv3/arch/x86/stage1.c =================================================================== --- LinuxBIOSv3/arch/x86/stage1.c 2008-01-05 01:33:28 UTC (rev 547) +++ LinuxBIOSv3/arch/x86/stage1.c 2008-01-05 01:35:57 UTC (rev 548) @@ -176,9 +176,9 @@ entry = load_file_segments(&archive, "normal/payload"); if (entry != (void*)-1) run_address(entry); + else + die("FATAL: No usable payload found.\n"); - die("FATAL: No usable payload found.\n"); - die ("FATAL: Last stage returned to LinuxBIOS.\n"); }

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2008