coreboot January 2008

coreboot@coreboot.org

79 participants
347 discussions

[LinuxBIOS] r551 - LinuxBIOSv3/arch/x86
by svn＠openbios.org 10 Jan '08

10 Jan '08

Author: hailfinger Date: 2008-01-10 00:09:23 +0100 (Thu, 10 Jan 2008) New Revision: 551 Modified: LinuxBIOSv3/arch/x86/stage0_i586.S Log: This patch is an attempt at introducing 4k CAR size granularity for the generic x86 code. For the old supported CAR sizes, the newly generated code is equivalent, so it should be a no-brainer. The patch is identical (except one build fix) to what was committed in r3038 to v2. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Marc Jones <marc.jones(a)amd.com> Modified: LinuxBIOSv3/arch/x86/stage0_i586.S =================================================================== --- LinuxBIOSv3/arch/x86/stage0_i586.S 2008-01-09 18:27:49 UTC (rev 550) +++ LinuxBIOSv3/arch/x86/stage0_i586.S 2008-01-09 23:09:23 UTC (rev 551) @@ -301,38 +301,59 @@ jmp clear_fixed_var_mtrr clear_fixed_var_mtrr_out: -#if CacheSize == 0x10000 - /* enable caching for 64K using fixed mtrr */ +/* 0x06 is the WB IO type for a given 4k segment. + * segs is the number of 4k segments in the area of the particular + * register we want to use for CAR. + * reg is the register where the IO type should be stored. + */ +.macro extractmask segs, reg +.if \segs <= 0 + /* The xorl here is superfluous because at the point of first execution + * of this macro, %eax and %edx are cleared. Later invocations of this + * macro will have a monotonically increasing segs parameter. + */ + xorl \reg, \reg +.elseif \segs == 1 + movl $0x06000000, \reg +.elseif \segs == 2 + movl $0x06060000, \reg +.elseif \segs == 3 + movl $0x06060600, \reg +.elseif \segs >= 4 + movl $0x06060606, \reg +.endif +.endm + +/* size is the cache size in bytes we want to use for CAR. + * windowoffset is the 32k-aligned window into CAR size + */ +.macro simplemask carsize, windowoffset + extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax + extractmask (((\carsize - \windowoffset) / 0x1000)), %edx +.endm + +#if CacheSize > 0x10000 +#error Invalid CAR size, must be at most 64k. +#endif +#if CacheSize < 0x1000 +#error Invalid CAR size, must be at least 4k. This is a processor limitation. +#endif +#if (CacheSize & (0x1000 - 1)) +#error Invalid CAR size, is not a multiple of 4k. This is a processor limitation. +#endif + +#if CacheSize > 0x8000 + /* enable caching for 32K-64K using fixed mtrr */ movl $0x268, %ecx /* fix4k_c0000*/ - movl $0x06060606, %eax /* WB IO type */ - movl %eax, %edx + simplemask CacheSize, 0x8000 wrmsr - movl $0x269, %ecx - wrmsr #endif -#if CacheSize == 0x8000 - /* enable caching for 32K using fixed mtrr */ + /* enable caching for 0-32K using fixed mtrr */ movl $0x269, %ecx /* fix4k_c8000*/ - movl $0x06060606, %eax /* WB IO type */ - movl %eax, %edx + simplemask CacheSize, 0 wrmsr -#endif - /* enable caching for 16K/8K/4K using fixed mtrr */ - movl $0x269, %ecx /* fix4k_cc000*/ -#if CacheSize == 0x4000 - movl $0x06060606, %edx /* WB IO type */ -#endif -#if CacheSize == 0x2000 - movl $0x06060000, %edx /* WB IO type */ -#endif -#if CacheSize == 0x1000 - movl $0x06000000, %edx /* WB IO type */ -#endif - xorl %eax, %eax - wrmsr - #if defined(CONFIG_XIP_ROM_SIZE) && defined(CONFIG_XIP_ROM_BASE) /* enable write base caching so we can do execute in place * on the flash rom.

1 0

[LinuxBIOS] r550 - LinuxBIOSv3/lib
by svn＠openbios.org 09 Jan '08

09 Jan '08

Author: mjones Date: 2008-01-09 19:27:49 +0100 (Wed, 09 Jan 2008) New Revision: 550 Modified: LinuxBIOSv3/lib/console.c Log: Add hlt() back into the die() function and update the comments. Signed-off-by: Marc Jones <marc.jones(a)amd.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: LinuxBIOSv3/lib/console.c =================================================================== --- LinuxBIOSv3/lib/console.c 2008-01-07 16:34:34 UTC (rev 549) +++ LinuxBIOSv3/lib/console.c 2008-01-09 18:27:49 UTC (rev 550) @@ -83,30 +83,37 @@ } /** - * Halt and loop due to a fatal error. - * There have been several iterations of this function. + * Halt and loop due to a fatal error. + * There have been several iterations of this function. * The first simply did a hlt(). Doing a hlt() can make jtag debugging - * very difficult as one can not break into a hlt instruction on some CPUs. - * Second was to do a console_tx_byte of a NULL character. - * A number of concerns were raised about doing this idea. - * Third idea was to do an inb from port 0x80, the POST port. That design - * makes us very CPU-specific. + * very difficult as one can not break into a hlt instruction on some CPUs. + * Second was to do a console_tx_byte of a NULL character. + * A number of concerns were raised about doing this idea. + * Third idea was to do an inb from port 0x80, the POST port. That design + * makes us very CPU-specific. * The fourth idea was just POSTING the same - * code over and over. That would erase the most recent POST code, - * hindering diagnosis. + * code over and over. That would erase the most recent POST code, + * hindering diagnosis. * - * For now, for lack of a good alternative, - * we will continue to call console_tx_byte. We call with a NULL since - * it will clear any FIFOs in the path and won't clutter up the output, - * since NULL doesn't print a visible character on most terminal - * emulators. + * For now, for lack of a better alternative, + * we will call console_tx_byte ten times and then halt. + * Some CPU JTAG debbuggers might have problems but it is the right thing + * to do. We call with a NULL since it will clear any FIFOs in the path and + * won't clutter up the output, since NULL doesn't print a visible character + * on most terminal emulators. * * @param str A string to print for the error * */ void die(const char *str) { + int i; + printk(BIOS_EMERG, str); - while (1) - console_tx_byte(0, (void *)0); + + while (1) { + for (i = 0; i < 10; i++) + console_tx_byte(0, (void *)0); + hlt(); + } }

1 0

[LinuxBIOS] r3041 build service
by LinuxBIOS information 09 Jan '08

09 Jan '08

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "hailfinger" checked in revision 3041 to the LinuxBIOS source repository and caused the following changes: Change Log: Use macros to improve readability of the device-to-pin IRQ assignments in GA-2761GXDK mptables.c. Thanks to Torsten Duwe for initial code. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: 蔡明耀 (Morgan Tsai) <my_tsai(a)sis.com> Build Log: Compilation of amd:serengeti_cheetah_fam10 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=3041&device=serengeti_che… If something broke during this checkin please be a pain in hailfinger's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

Re: [LinuxBIOS] r3041 - trunk/LinuxBIOSv2/src/mainboard/gigabyte/ga_2761gxdk
by Carl-Daniel Hailfinger 09 Jan '08

09 Jan '08

On 09.01.2008 12:37, svn(a)openbios.org wrote: > Author: hailfinger > Date: 2008-01-09 12:37:58 +0100 (Wed, 09 Jan 2008) > New Revision: 3041 > > Acked-by: ?\232?\148?\161?\230?\152?\142?\232?\128?\128 (Morgan Tsai) <my_tsai(a)sis.com> > It seems our subversion changelog mailing setup has problems handling UTF-8 contents in commit messages. svn log gives me the correct message: [...] Acked-by: 蔡明耀 (Morgan Tsai) <my_tsai(a)sis.com> [...] Regards, Carl-Daniel

1 0

[LinuxBIOS] r3041 - trunk/LinuxBIOSv2/src/mainboard/gigabyte/ga_2761gxdk
by svn＠openbios.org 09 Jan '08

09 Jan '08

Author: hailfinger Date: 2008-01-09 12:37:58 +0100 (Wed, 09 Jan 2008) New Revision: 3041 Modified: trunk/LinuxBIOSv2/src/mainboard/gigabyte/ga_2761gxdk/mptable.c Log: Use macros to improve readability of the device-to-pin IRQ assignments in GA-2761GXDK mptables.c. Thanks to Torsten Duwe for initial code. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: ?\232?\148?\161?\230?\152?\142?\232?\128?\128 (Morgan Tsai) <my_tsai(a)sis.com> Modified: trunk/LinuxBIOSv2/src/mainboard/gigabyte/ga_2761gxdk/mptable.c =================================================================== --- trunk/LinuxBIOSv2/src/mainboard/gigabyte/ga_2761gxdk/mptable.c 2008-01-08 19:14:16 UTC (rev 3040) +++ trunk/LinuxBIOSv2/src/mainboard/gigabyte/ga_2761gxdk/mptable.c 2008-01-09 11:37:58 UTC (rev 3041) @@ -100,44 +100,52 @@ } } -/*I/O Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN# -*/ smp_write_intsrc(mc, mp_ExtINT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x0, apicid_sis966, 0x0); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x1, apicid_sis966, 0x1); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x0, apicid_sis966, 0x2); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x3, apicid_sis966, 0x3); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x4, apicid_sis966, 0x4); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x6, apicid_sis966, 0x6); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x7, apicid_sis966, 0x7); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x8, apicid_sis966, 0x8); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0xc, apicid_sis966, 0xc); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0xd, apicid_sis966, 0xd); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0xe, apicid_sis966, 0xe); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0xf, apicid_sis966, 0xf); + /* I/O Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN# */ + smp_write_intsrc(mc, mp_ExtINT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, 0x0, apicid_sis966, 0x0); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+1)<<2)|1, apicid_sis966, 0xa); +/* ISA ints are edge-triggered, and usually originate from the ISA bus, + * or its remainings. + */ +#define ISA_INT(intr, pin)\ + smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, bus_isa, (intr), apicid_sis966,(pin)) - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+2)<<2)|0, apicid_sis966, 0x16); // 22 + ISA_INT(0x1, 0x1); + ISA_INT(0x0, 0x2); + ISA_INT(0x3, 0x3); + ISA_INT(0x4, 0x4); + ISA_INT(0x6, 0x6); + ISA_INT(0x7, 0x7); + ISA_INT(0x8, 0x8); + ISA_INT(0xc, 0xc); + ISA_INT(0xd, 0xd); + ISA_INT(0xe, 0xe); + ISA_INT(0xf, 0xf); - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+2)<<2)|1, apicid_sis966, 0x17); // 23 +/* PCI interrupts are level triggered, and are + * associated with a specific bus/device/function tuple. + */ +#define PCI_INT(bus, dev, fn, pin) \ + smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[bus], (((dev)<<2)|(fn)), apicid_sis966, (pin)) - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+6)<<2)|1, apicid_sis966, 0x17); // 23 + PCI_INT(0, sbdn+1, 1, 0xa); + PCI_INT(0, sbdn+2, 0, 0x16); // 22 + PCI_INT(0, sbdn+2, 1, 0x17); // 23 + PCI_INT(0, sbdn+6, 1, 0x17); // 23 + PCI_INT(0, sbdn+5, 0, 0x14); // 20 + PCI_INT(0, sbdn+5, 1, 0x17); // 23 + PCI_INT(0, sbdn+5, 2, 0x15); // 21 + PCI_INT(0, sbdn+8, 0, 0x16); // 22 - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+5)<<2)|0, apicid_sis966, 0x14); // 20 - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+5)<<2)|1, apicid_sis966, 0x17); // 23 - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+5)<<2)|2, apicid_sis966, 0x15); // 21 - - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[0], ((sbdn+8)<<2)|0, apicid_sis966, 0x16); // 22 - for(j=7; j>=2; j--) { if(!bus_sis966[j]) continue; for(i=0;i<4;i++) { - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[j], (0x00<<2)|i, apicid_sis966, 0x10 + (2+j+i+4-sbdn%4)%4); + PCI_INT(j, 0x00, i, 0x10 + (2+j+i+4-sbdn%4)%4); } } for(j=0; j<2; j++) for(i=0;i<4;i++) { - smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_sis966[1], ((0x06+j)<<2)|i, apicid_sis966, 0x10 + (2+i+j)%4); + PCI_INT(1, 0x06+j, i, 0x10 + (2+i+j)%4); } /*Local Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN#*/

1 0

[LinuxBIOS] IRQ and interrupts
by Feng, Libo 09 Jan '08

09 Jan '08

Hi, all, I am confused again by IRQ and Interrupts. In my system, there is a plug-in Broadcom network board(5715). With lspci -v, I get the message as below: 08:04.0 Ethernet controller: Broadcom Corporation: Unknown device 1678 (rev a3) Subsystem: Broadcom Corporation: Unknown device 1678 Flags: bus master, 66Mhz, medium devsel, latency 64, IRQ 201 Memory at ff5d0000 (64-bit, non-prefetchable) [size=64K] Memory at ff5c0000 (64-bit, non-prefetchable) [size=64K] Capabilities: [40] PCI-X non-bridge device. Capabilities: [48] Power Management version 2 Capabilities: [50] Vital Product Data Capabilities: [58] Message Signalled Interrupts: 64bit+ Queue=0/3 Enable- 08:04.1 Ethernet controller: Broadcom Corporation: Unknown device 1678 (rev a3) Subsystem: Broadcom Corporation: Unknown device 1678 Flags: bus master, 66Mhz, medium devsel, latency 64, IRQ 201 Memory at ff5f0000 (64-bit, non-prefetchable) [size=64K] Memory at ff5e0000 (64-bit, non-prefetchable) [size=64K] Capabilities: [40] PCI-X non-bridge device. Capabilities: [48] Power Management version 2 Capabilities: [50] Vital Product Data Capabilities: [58] Message Signalled Interrupts: 64bit+ Queue=0/3 Enable- With lspci -xxx, I get the message as below: 08:04.0 Ethernet controller: Broadcom Corporation: Unknown device 1678 (rev a3) 00: e4 14 78 16 16 01 b0 02 a3 00 00 02 10 40 80 00 10: 04 00 5d ff 00 00 00 00 04 00 5c ff 00 00 00 00 20: 00 00 00 00 00 00 00 00 00 00 00 00 e4 14 78 16 30: 00 00 00 00 40 00 00 00 00 00 00 00 09 01 40 00 40: 07 48 02 00 20 08 43 04 01 50 02 c0 00 20 00 64 50: 03 58 0c 00 00 10 40 04 05 00 86 00 a8 00 41 b8 60: 10 0c b1 4e 32 c0 00 00 00 00 03 90 00 00 00 00 70: 0a 12 00 00 c7 00 00 00 50 00 00 00 00 00 00 00 80: 00 00 00 00 00 00 00 00 c0 00 00 00 fe d0 08 00 90: 01 4f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 08:04.1 Ethernet controller: Broadcom Corporation: Unknown device 1678 (rev a3) 00: e4 14 78 16 16 01 b0 02 a3 00 00 02 10 40 80 00 10: 04 00 5f ff 00 00 00 00 04 00 5e ff 00 00 00 00 20: 00 00 00 00 00 00 00 00 00 00 00 00 e4 14 78 16 30: 00 00 00 00 40 00 00 00 00 00 00 00 09 02 40 00 40: 07 48 02 00 21 08 43 04 01 50 02 c0 00 20 00 64 50: 03 58 90 00 08 00 91 22 05 00 86 00 18 5a 82 31 60: 84 10 8e 10 8a 2f 00 00 00 00 03 90 00 00 00 00 70: 0a 12 00 00 c7 00 00 00 50 00 00 00 00 00 00 00 80: 00 00 00 00 00 00 00 00 c0 00 00 00 fe d0 08 00 90: 01 4f 00 08 00 00 00 00 00 00 00 00 00 00 00 00 a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 04 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Lspci -v tells me the IRQ is 201, however, lspci -xxx tells me the IRQ is 09(offset 0x3c). My understanding is wrong or something else. Help me out. Best Regards 丰立波 Feng Libo @ AMD Ext: 20906 Mobile Phone: 13683249071 Office Phone: 0086-010-62801406

1 0

[LinuxBIOS] [PATCH] remove duplicated microcode updates for some Intel processors
by Carl-Daniel Hailfinger 09 Jan '08

09 Jan '08

The following mainboards had a file named microcode_updates.c in their mainboard directories, but the code was not referenced anywhere. intel/jarrell dell/s1850 supermicro/x6dhr_ig2 supermicro/x6dhr_ig supermicro/x6dhe_g2 supermicro/x6dhe_g Besides that, the contents of these files were either duplicates of src/cpu/intel/model_f3x/microcode_M1DF340E.h or src/cpu/intel/model_f3x/microcode_M1DF3413.h. To apply this removal, execute svn remove for the following files: src/mainboard/supermicro/x6dhe_g/microcode_updates.c src/mainboard/supermicro/x6dhe_g2/microcode_updates.c src/mainboard/supermicro/x6dhr_ig/microcode_updates.c src/mainboard/supermicro/x6dhr_ig2/microcode_updates.c src/mainboard/dell/s1850/microcode_updates.c src/mainboard/intel/jarrell/microcode_updates.c Abuild tested, as expected no failures. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> No patch attached because a pure removal patch sized 148 kB is a bit too large to be sent without a need for code review.

4 9

[LinuxBIOS] r3040 build service
by LinuxBIOS information 08 Jan '08

08 Jan '08

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "hailfinger" checked in revision 3040 to the LinuxBIOS source repository and caused the following changes: Change Log: Fix compilation of Tyan S2735 which was broken by accident in r3038. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Build Log: Compilation of amd:serengeti_cheetah_fam10 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=3040&device=serengeti_che… Compilation of tyan:s2735 has been fixed If something broke during this checkin please be a pain in hailfinger's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

[LinuxBIOS] r3040 - trunk/LinuxBIOSv2/src/cpu/x86/car
by svn＠openbios.org 08 Jan '08

08 Jan '08

Author: hailfinger Date: 2008-01-08 20:14:16 +0100 (Tue, 08 Jan 2008) New Revision: 3040 Modified: trunk/LinuxBIOSv2/src/cpu/x86/car/cache_as_ram.inc Log: Fix compilation of Tyan S2735 which was broken by accident in r3038. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/LinuxBIOSv2/src/cpu/x86/car/cache_as_ram.inc =================================================================== --- trunk/LinuxBIOSv2/src/cpu/x86/car/cache_as_ram.inc 2008-01-08 17:28:35 UTC (rev 3039) +++ trunk/LinuxBIOSv2/src/cpu/x86/car/cache_as_ram.inc 2008-01-08 19:14:16 UTC (rev 3040) @@ -158,8 +158,8 @@ * windowoffset is the 32k-aligned window into CAR size */ .macro simplemask carsize, windowoffset - simplemask_helper (((\carsize - \windowoffset) / 0x1000) - 4), %eax - simplemask_helper (((\carsize - \windowoffset) / 0x1000)), %edx + extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax + extractmask (((\carsize - \windowoffset) / 0x1000)), %edx .endm #if CacheSize > 0x10000

1 0

[LinuxBIOS] r3039 build service
by LinuxBIOS information 08 Jan '08

08 Jan '08

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "hailfinger" checked in revision 3039 to the LinuxBIOS source repository and caused the following changes: Change Log: Remove some DOS line endings accidentially introduced in r3014. No code lines affected, so svn blame will not be messed up. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Build Log: Compilation of amd:serengeti_cheetah_fam10 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=3039&device=serengeti_che… Compilation of tyan:s2735 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=3039&device=s2735&vendor=… If something broke during this checkin please be a pain in hailfinger's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

← Newer
1
...
26
27
28
29
30
31
32
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2008