coreboot March 2015

coreboot@coreboot.org

62 participants
166 discussions

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 06 Mar '15

06 Mar '15

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 30 new defect(s) introduced to coreboot found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 30 defect(s) ** CID 1287080: (FORWARD_NULL) /src/vendorcode/amd/agesa/f14/Proc/CPU/S3.c: 542 in SaveConditionalMsrDevice() /src/vendorcode/amd/agesa/f12/Proc/… [View More]CPU/S3.c: 548 in SaveConditionalMsrDevice() /src/vendorcode/amd/agesa/f15/Proc/CPU/S3.c: 548 in SaveConditionalMsrDevice() /src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice() /src/vendorcode/amd/agesa/f16kb/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice() ________________________________________________________________________________________________________ *** CID 1287080: (FORWARD_NULL) /src/vendorcode/amd/agesa/f14/Proc/CPU/S3.c: 542 in SaveConditionalMsrDevice() 536 if (CallPoint == INIT_RESUME) { 537 MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 538 } else { 539 S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 540 } 541 >>> CID 1287080: (FORWARD_NULL) >>> Dereferencing null pointer "RegisterHdr". 542 for (i = 0; i < RegisterHdr->NumRegisters; i++) { 543 if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) && 544 ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) { 545 if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) { 546 LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader); 547 } else { /src/vendorcode/amd/agesa/f12/Proc/CPU/S3.c: 548 in SaveConditionalMsrDevice() 542 if (CallPoint == INIT_RESUME) { 543 MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 544 } else { 545 S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 546 } 547 >>> CID 1287080: (FORWARD_NULL) >>> Dereferencing null pointer "RegisterHdr". 548 for (i = 0; i < RegisterHdr->NumRegisters; i++) { 549 if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) && 550 ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) { 551 if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) { 552 LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader); 553 } else { /src/vendorcode/amd/agesa/f15/Proc/CPU/S3.c: 548 in SaveConditionalMsrDevice() 542 if (CallPoint == INIT_RESUME) { 543 MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 544 } else { 545 S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 546 } 547 >>> CID 1287080: (FORWARD_NULL) >>> Dereferencing null pointer "RegisterHdr". 548 for (i = 0; i < RegisterHdr->NumRegisters; i++) { 549 if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) && 550 ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) { 551 if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) { 552 LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader); 553 } else { /src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice() 541 if (CallPoint == INIT_RESUME) { 542 MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 543 } else { 544 S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 545 } 546 >>> CID 1287080: (FORWARD_NULL) >>> Dereferencing null pointer "RegisterHdr". 547 for (i = 0; i < RegisterHdr->NumRegisters; i++) { 548 if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) && 549 ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) { 550 if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) { 551 LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader); 552 } else { /src/vendorcode/amd/agesa/f16kb/Proc/CPU/S3.c: 547 in SaveConditionalMsrDevice() 541 if (CallPoint == INIT_RESUME) { 542 MemFS3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 543 } else { 544 S3GetCMsrDeviceRegisterList (Device, &RegisterHdr, StdHeader); 545 } 546 >>> CID 1287080: (FORWARD_NULL) >>> Dereferencing null pointer "RegisterHdr". 547 for (i = 0; i < RegisterHdr->NumRegisters; i++) { 548 if (((Device->Mask1 & RegisterHdr->RegisterList[i].Mask1) != 0) && 549 ((Device->Mask2 & RegisterHdr->RegisterList[i].Mask2) != 0)) { 550 if (RegisterHdr->RegisterList[i].Type.SpecialCaseFlag == 0) { 551 LibAmdMsrRead (RegisterHdr->RegisterList[i].Address, (UINT64 *) *OrMask, StdHeader); 552 } else { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/1016?tab=overview To manage Coverity Scan email notifications for "coreboot(a)coreboot.org", click https://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.org&… . [View Less]

1 0

[GSoC-2015] Interested in Participating - Discussing Ideas
by Varad Gautam 06 Mar '15

06 Mar '15

Hi, I would like to participate in Google Summer of Code 2015 with coreboot to work on one of the following ideas: - Enable coreboot + Tianocore over an ARM board: The Ideas page mentions something similar [1], but I think the hardware details are to be finalized. I worked on adding BeagleBone Black support to Tianocore during GSoC-2014 with Linaro, and so have some experience with JTAG, ARM bringup and bootloaders. Which mainboard would be the intended target? I have a HiKey board (… [View More]

2 1

coreboot GSoC 2015
by Marc Jones 05 Mar '15

05 Mar '15

coreboot has been accepted as a GSoC project . Woot! Please see the following announcement: http://blogs.coreboot.org/blog/2015/03/02/coreboot-gsoc-2015/ Interested students and mentors should visit the coreboot GSoC page: http://www.coreboot.org/GSoC Regards, Marc

1 0

Re: [coreboot] Long license headers (ANGER WARNING)
by ron minnich 04 Mar '15

04 Mar '15

> > Does this count as common sense? http://review.coreboot.org/#/c/8602/

1 0

Re: [coreboot] Long license headers (ANGER WARNING)
by Julius Werner 04 Mar '15

04 Mar '15

> Section 1 of the GPLv2 contains: "keep intact all the notices that refer to this License". Yes, but that only applies to verbatim copies. Section 2 explicitly allows you to distribute modified versions (and isn't incorporation into a larger code body always a modification?) as long as the whole is licensed under the terms of the GPL. The GPLv3 is much clearer on this, saying 'The work must carry prominent notices stating that it is released under this License [...]. This requirement … [View More]

1 0

Re: [coreboot] Long license headers (ANGER WARNING)
by ron minnich 04 Mar '15

04 Mar '15

> > http://review.coreboot.org/#/c/8602/ > If this works I'll update the wiki. ron

1 0

Re: [coreboot] Long license headers (ANGER WARNING)
by Patrick Georgi 04 Mar '15

04 Mar '15

2015-03-04 18:32 GMT+01:00 ron minnich <rminnich(a)gmail.com>: > Peter, per Patrick's note here, and discussions I've had with people who > actually are real lawyers, who earn their money doing IP licensing, I think > you are quite wrong. We should not change the license text in the files > *unless it is done in consultation with the copyright holders*. There are things we can do, before "perfect" kills "good" again: Decide how we want it done in the future, and formalize that … [View More]

1 0

Re: [coreboot] Long license headers (ANGER WARNING)
by ron minnich 04 Mar '15

04 Mar '15

On Wed, Mar 4, 2015 at 6:10 AM Patrick Georgi via coreboot < coreboot(a)coreboot.org> wrote: > 2015-03-04 14:58 GMT+01:00 Peter Stuge <peter(a)stuge.se>: > > I haven't gotten the impression that anyone is suggesting to remove > > or even change any copyright notices. > > > > Copyright documents authorship (like git does too) but says nothing > > about licensing terms. > Section 1 of the GPLv2 contains: "keep intact all the notices that > refer … [View More]

1 0

Re: [coreboot] Long license headers (ANGER WARNING)
by Peter Stuge 04 Mar '15

04 Mar '15

ron minnich wrote: > > IANAL (I'm not giving legal advice, yada yada), but I don't think that is > > how this works. Companies you don't work for can't force you to do X or > > prevent you to do Y with their files. > > Copyright statements are pretty complicated, and I am not sure you are > right. I am afraid I can't take your advice ;-) > > You can change the code. But the copyright statement is pretty clear > that you can't remove the copyright. … [View More]

2 1

Re: [coreboot] Long license headers (ANGER WARNING)
by ron minnich 04 Mar '15

04 Mar '15

On Tue, Mar 3, 2015 at 7:32 PM Julius Werner <jwerner(a)chromium.org> wrote: > > > IANAL (I'm not giving legal advice, yada yada), but I don't think that is > how this works. Companies you don't work for can't force you to do X or > prevent you to do Y with their files. > Copyright statements are pretty complicated, and I am not sure you are right. I am afraid I can't take your advice ;-) You can change the code. But the copyright statement is pretty clear that you can'… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot March 2015