Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2395
-gerrit
commit 2be1ac278c767ffe3326c658fcdaa6f5f18bf668
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Thu Feb 14 14:43:42 2013 -0800
Exynos: Drop unused include files
Change-Id: Ib533938446a289167725f5beda77c2ee5236e8a5
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
---
src/cpu/samsung/exynos5-common/mmc.h | 77 ---------------
src/cpu/samsung/exynos5-common/mshc.h | 170 ---------------------------------
src/cpu/samsung/exynos5250/adc.h | 27 ------
src/cpu/samsung/exynos5250/mmc.h | 27 ------
src/cpu/samsung/exynos5250/mshc.h | 31 ------
src/cpu/samsung/exynos5250/pwm.h | 27 ------
src/cpu/samsung/s5p-common/mmc.h | 73 --------------
src/cpu/samsung/s5p-common/sys_proto.h | 29 ------
8 files changed, 461 deletions(-)
diff --git a/src/cpu/samsung/exynos5-common/mmc.h b/src/cpu/samsung/exynos5-common/mmc.h
deleted file mode 100644
index f607f82..0000000
--- a/src/cpu/samsung/exynos5-common/mmc.h
+++ /dev/null
@@ -1,77 +0,0 @@
-/*
- * (C) Copyright 2009 SAMSUNG Electronics
- * Minkyu Kang <mk7.kang(a)samsung.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
- */
-
-#ifndef __ASM_ARCH_COMMON_MMC_H_
-#define __ASM_ARCH_COMMON_MMC_H_
-
-#ifndef __ASSEMBLER__
-struct s5p_mmc {
- unsigned int sysad;
- unsigned short blksize;
- unsigned short blkcnt;
- unsigned int argument;
- unsigned short trnmod;
- unsigned short cmdreg;
- unsigned int rspreg0;
- unsigned int rspreg1;
- unsigned int rspreg2;
- unsigned int rspreg3;
- unsigned int bdata;
- unsigned int prnsts;
- unsigned char hostctl;
- unsigned char pwrcon;
- unsigned char blkgap;
- unsigned char wakcon;
- unsigned short clkcon;
- unsigned char timeoutcon;
- unsigned char swrst;
- unsigned int norintsts; /* errintsts */
- unsigned int norintstsen; /* errintstsen */
- unsigned int norintsigen; /* errintsigen */
- unsigned short acmd12errsts;
- unsigned char res1[2];
- unsigned int capareg;
- unsigned char res2[4];
- unsigned int maxcurr;
- unsigned char res3[0x34];
- unsigned int control2;
- unsigned int control3;
- unsigned char res4[4];
- unsigned int control4;
- unsigned char res5[0x6e];
- unsigned short hcver;
- unsigned char res6[0xFF00];
-};
-
-struct mmc_host {
- struct s5p_mmc *reg;
- unsigned int version; /* SDHCI spec. version */
- unsigned int clock; /* Current clock (MHz) */
- int dev_index;
-};
-
-#ifdef CONFIG_OF_CONTROL
-int s5p_mmc_init(const void *blob);
-#else
-int s5p_mmc_init(int dev_index, int bus_width);
-#endif
-
-#endif /* __ASSEMBLER__ */
-#endif
diff --git a/src/cpu/samsung/exynos5-common/mshc.h b/src/cpu/samsung/exynos5-common/mshc.h
deleted file mode 100644
index 623492c..0000000
--- a/src/cpu/samsung/exynos5-common/mshc.h
+++ /dev/null
@@ -1,170 +0,0 @@
-/*
- * (C) Copyright 2012 SAMSUNG Electronics
- * Abhilash Kesavan <a.kesavan(a)samsung.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
- */
-#ifndef __ASM_ARCH_COMMON_MSHC_H
-#define __ASM_ARCH_COMMON_MSHC_H
-
-#include <asm/arch/pinmux.h>
-#ifndef __ASSEMBLER__
-struct mshci_host {
- struct s5p_mshci *reg; /* Mapped address */
- unsigned int clock; /* Current clock in MHz */
- enum periph_id peripheral;
-};
-
-struct s5p_mshci {
- unsigned int ctrl;
- unsigned int pwren;
- unsigned int clkdiv;
- unsigned int clksrc;
- unsigned int clkena;
- unsigned int tmout;
- unsigned int ctype;
- unsigned int blksiz;
- unsigned int bytcnt;
- unsigned int intmask;
- unsigned int cmdarg;
- unsigned int cmd;
- unsigned int resp0;
- unsigned int resp1;
- unsigned int resp2;
- unsigned int resp3;
- unsigned int mintsts;
- unsigned int rintsts;
- unsigned int status;
- unsigned int fifoth;
- unsigned int cdetect;
- unsigned int wrtprt;
- unsigned int gpio;
- unsigned int tcbcnt;
- unsigned int tbbcnt;
- unsigned int debnce;
- unsigned int usrid;
- unsigned int verid;
- unsigned int hcon;
- unsigned int uhs_reg;
- unsigned int rst_n;
- unsigned char reserved1[4];
- unsigned int bmod;
- unsigned int pldmnd;
- unsigned int dbaddr;
- unsigned int idsts;
- unsigned int idinten;
- unsigned int dscaddr;
- unsigned int bufaddr;
- unsigned int clksel;
- unsigned char reserved2[460];
- unsigned int cardthrctl;
-};
-
-/*
- * Struct idma
- * Holds the descriptor list
- */
-struct mshci_idmac {
- u32 des0;
- u32 des1;
- u32 des2;
- u32 des3;
-};
-
-/* Control Register Register */
-#define CTRL_RESET (0x1 << 0)
-#define FIFO_RESET (0x1 << 1)
-#define DMA_RESET (0x1 << 2)
-#define DMA_ENABLE (0x1 << 5)
-#define SEND_AS_CCSD (0x1 << 10)
-#define ENABLE_IDMAC (0x1 << 25)
-
-/* Power Enable Register */
-#define POWER_ENABLE (0x1 << 0)
-
-/* Clock Enable Register */
-#define CLK_ENABLE (0x1 << 0)
-#define CLK_DISABLE (0x0 << 0)
-
-/* Timeout Register */
-#define TMOUT_MAX 0xffffffff
-
-/* Card Type Register */
-#define PORT0_CARD_WIDTH1 0
-#define PORT0_CARD_WIDTH4 (0x1 << 0)
-#define PORT0_CARD_WIDTH8 (0x1 << 16)
-
-/* Interrupt Mask Register */
-#define INTMSK_ALL 0xffffffff
-#define INTMSK_RE (0x1 << 1)
-#define INTMSK_CDONE (0x1 << 2)
-#define INTMSK_DTO (0x1 << 3)
-#define INTMSK_DCRC (0x1 << 7)
-#define INTMSK_RTO (0x1 << 8)
-#define INTMSK_DRTO (0x1 << 9)
-#define INTMSK_HTO (0x1 << 10)
-#define INTMSK_FRUN (0x1 << 11)
-#define INTMSK_HLE (0x1 << 12)
-#define INTMSK_SBE (0x1 << 13)
-#define INTMSK_ACD (0x1 << 14)
-#define INTMSK_EBE (0x1 << 15)
-
-/* Command Register */
-#define CMD_RESP_EXP_BIT (0x1 << 6)
-#define CMD_RESP_LENGTH_BIT (0x1 << 7)
-#define CMD_CHECK_CRC_BIT (0x1 << 8)
-#define CMD_DATA_EXP_BIT (0x1 << 9)
-#define CMD_RW_BIT (0x1 << 10)
-#define CMD_SENT_AUTO_STOP_BIT (0x1 << 12)
-#define CMD_WAIT_PRV_DAT_BIT (0x1 << 13)
-#define CMD_SEND_CLK_ONLY (0x1 << 21)
-#define CMD_USE_HOLD_REG (0x1 << 29)
-#define CMD_STRT_BIT (0x1 << 31)
-#define CMD_ONLY_CLK (CMD_STRT_BIT | CMD_SEND_CLK_ONLY | \
- CMD_WAIT_PRV_DAT_BIT)
-
-/* Raw Interrupt Register */
-#define DATA_ERR (INTMSK_EBE | INTMSK_SBE | INTMSK_HLE | \
- INTMSK_FRUN | INTMSK_EBE | INTMSK_DCRC)
-#define DATA_TOUT (INTMSK_HTO | INTMSK_DRTO)
-
-/* Status Register */
-#define DATA_BUSY (0x1 << 9)
-
-/* FIFO Threshold Watermark Register */
-#define TX_WMARK (0xFFF << 0)
-#define RX_WMARK (0xFFF << 16)
-#define MSIZE_MASK (0x7 << 28)
-
-/* DW DMA Mutiple Transaction Size */
-#define MSIZE_8 (2 << 28)
-
-/* Bus Mode Register */
-#define BMOD_IDMAC_RESET (0x1 << 0)
-#define BMOD_IDMAC_FB (0x1 << 1)
-#define BMOD_IDMAC_ENABLE (0x1 << 7)
-
-/* IDMAC bits */
-#define MSHCI_IDMAC_OWN (0x1 << 31)
-#define MSHCI_IDMAC_CH (0x1 << 4)
-#define MSHCI_IDMAC_FS (0x1 << 3)
-#define MSHCI_IDMAC_LD (0x1 << 2)
-
-int s5p_mshci_init(const void *blob);
-
-#endif
-#endif
-
diff --git a/src/cpu/samsung/exynos5250/adc.h b/src/cpu/samsung/exynos5250/adc.h
deleted file mode 100644
index 86fcb88..0000000
--- a/src/cpu/samsung/exynos5250/adc.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * (C) Copyright 2012 Samsung Electronics
- * Minkyu Kang <mk7.kang(a)samsung.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- *
- */
-
-#ifndef __ASM_ARM_ARCH_EXYNOS5_ADC_H__
-#define __ASM_ARM_ARCH_EXYNOS5_ADC_H__
-
-#include <asm/arch-exynos/adc.h>
-
-#endif /* __ASM_ARM_ARCH_EXYNOS5_ADC_H__ */
diff --git a/src/cpu/samsung/exynos5250/mmc.h b/src/cpu/samsung/exynos5250/mmc.h
deleted file mode 100644
index 24acbc1..0000000
--- a/src/cpu/samsung/exynos5250/mmc.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * (C) Copyright 2012 Samsung Electronics
- * Minkyu Kang <mk7.kang(a)samsung.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- *
- */
-
-#ifndef __ASM_ARM_ARCH_EXYNOS5_MMC_H__
-#define __ASM_ARM_ARCH_EXYNOS5_MMC_H__
-
-#include <asm/arch-exynos/mmc.h>
-
-#endif /* __ASM_ARM_ARCH_EXYNOS5_MMC_H__ */
diff --git a/src/cpu/samsung/exynos5250/mshc.h b/src/cpu/samsung/exynos5250/mshc.h
deleted file mode 100644
index d8e3ad0..0000000
--- a/src/cpu/samsung/exynos5250/mshc.h
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * (C) Copyright 2012 Samsung Electronics
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- *
- */
-
-#ifndef __ASM_ARM_ARCH_EXYNOS5_MSHC_H__
-#define __ASM_ARM_ARCH_EXYNOS5_MSHC_H__
-
-#include <asm/arch-exynos/mshc.h>
-
-#define MAX_MSHCI_CLOCK 52000000 /* Max limit for mshc clock is 52MHz */
-#define MIN_MSHCI_CLOCK 400000 /* Lower limit for mshc clock is 400KHz */
-#define COMMAND_TIMEOUT 10000
-#define TIMEOUT_MS 100
-
-#endif /* __ASM_ARM_ARCH_EXYNOS5_MSHC_H__ */
diff --git a/src/cpu/samsung/exynos5250/pwm.h b/src/cpu/samsung/exynos5250/pwm.h
deleted file mode 100644
index e7ae208..0000000
--- a/src/cpu/samsung/exynos5250/pwm.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * (C) Copyright 2012 Samsung Electronics
- * Minkyu Kang <mk7.kang(a)samsung.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- *
- */
-
-#ifndef __ASM_ARM_ARCH_EXYNOS5_PWM_H__
-#define __ASM_ARM_ARCH_EXYNOS5_PWM_H__
-
-#include <asm/arch-exynos/pwm.h>
-
-#endif /* __ASM_ARM_ARCH_EXYNOS5_PWM_H__ */
diff --git a/src/cpu/samsung/s5p-common/mmc.h b/src/cpu/samsung/s5p-common/mmc.h
deleted file mode 100644
index 675666c..0000000
--- a/src/cpu/samsung/s5p-common/mmc.h
+++ /dev/null
@@ -1,73 +0,0 @@
-/*
- * (C) Copyright 2009 SAMSUNG Electronics
- * Minkyu Kang <mk7.kang(a)samsung.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
- */
-
-#ifndef __ASM_ARCH_MMC_H_
-#define __ASM_ARCH_MMC_H_
-
-#ifndef __ASSEMBLER__
-struct s5p_mmc {
- unsigned int sysad;
- unsigned short blksize;
- unsigned short blkcnt;
- unsigned int argument;
- unsigned short trnmod;
- unsigned short cmdreg;
- unsigned int rspreg0;
- unsigned int rspreg1;
- unsigned int rspreg2;
- unsigned int rspreg3;
- unsigned int bdata;
- unsigned int prnsts;
- unsigned char hostctl;
- unsigned char pwrcon;
- unsigned char blkgap;
- unsigned char wakcon;
- unsigned short clkcon;
- unsigned char timeoutcon;
- unsigned char swrst;
- unsigned int norintsts; /* errintsts */
- unsigned int norintstsen; /* errintstsen */
- unsigned int norintsigen; /* errintsigen */
- unsigned short acmd12errsts;
- unsigned char res1[2];
- unsigned int capareg;
- unsigned char res2[4];
- unsigned int maxcurr;
- unsigned char res3[0x34];
- unsigned int control2;
- unsigned int control3;
- unsigned char res4[4];
- unsigned int control4;
- unsigned char res5[0x6e];
- unsigned short hcver;
- unsigned char res6[0xFFF00];
-};
-
-struct mmc_host {
- struct s5p_mmc *reg;
- unsigned int version; /* SDHCI spec. version */
- unsigned int clock; /* Current clock (MHz) */
- int dev_index;
-};
-
-int s5p_mmc_init(int dev_index, int bus_width);
-
-#endif /* __ASSEMBLER__ */
-#endif
diff --git a/src/cpu/samsung/s5p-common/sys_proto.h b/src/cpu/samsung/s5p-common/sys_proto.h
deleted file mode 100644
index 7b83c5a..0000000
--- a/src/cpu/samsung/s5p-common/sys_proto.h
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Copyright (C) 2009 Samsung Electrnoics
- * Minkyu Kang <mk7.kang(a)samsung.com>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-#ifndef _SYS_PROTO_H_
-#define _SYS_PROTO_H_
-
-u32 get_device_type(void);
-
-#endif
the following patch was just integrated into master:
commit f151a81f8b348bb0ec0f65259f1cc9a25880a97f
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Thu Feb 14 13:36:52 2013 -0800
Exynos5250: Drop SHA implementation
We don't need SHA in coreboot.
Change-Id: I1985d5e2c74fac39ff9dcdba4c23bb34fa857ec7
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Reviewed-on: http://review.coreboot.org/2390
Reviewed-by: David Hendricks <dhendrix(a)chromium.org>
Tested-by: build bot (Jenkins)
Build-Tested: build bot (Jenkins) at Thu Feb 14 23:15:11 2013, giving +1
Reviewed-By: David Hendricks <dhendrix(a)chromium.org> at Thu Feb 14 23:10:48 2013, giving +2
See http://review.coreboot.org/2390 for details.
-gerrit
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2392
-gerrit
commit 3f2008b68c75aac5b3b6d39b777f885085031011
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Thu Feb 14 13:39:25 2013 -0800
ARMv7: drop multiboot support
Multiboot is an x86 only thing. Drop support on ARM.
Change-Id: I13fafa464a794206d5450b4a1f23a187967a8338
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
---
src/Kconfig | 1 +
src/arch/armv7/boot/multiboot.c | 77 -----------------------------------------
2 files changed, 1 insertion(+), 77 deletions(-)
diff --git a/src/Kconfig b/src/Kconfig
index 726fa39..4e7957e 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -413,6 +413,7 @@ config WRITE_HIGH_TABLES
config MULTIBOOT
bool "Generate Multiboot tables (for GRUB2)"
default y
+ depends on ARCH_X86
config GENERATE_ACPI_TABLES
prompt "Generate ACPI tables" if HAVE_ACPI_TABLES
diff --git a/src/arch/armv7/boot/multiboot.c b/src/arch/armv7/boot/multiboot.c
deleted file mode 100644
index 4059f27..0000000
--- a/src/arch/armv7/boot/multiboot.c
+++ /dev/null
@@ -1,77 +0,0 @@
-/*
- * support for Multiboot payloads
- *
- * Copyright (C) 2008 Robert Millan
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, see <http://www.gnu.org/licenses/>.
- *
- */
-
-#include <cpu/x86/multiboot.h>
-#include <string.h>
-#include <device/resource.h>
-#include <console/console.h>
-#include <boot/coreboot_tables.h>
-#include <arch/coreboot_tables.h>
-
-struct multiboot_info *mbi = NULL;
-
-unsigned long write_multiboot_info(unsigned long rom_table_end)
-{
- static struct multiboot_mmap_entry *mb_mem;
- struct lb_memory* coreboot_table;
- int entries;
- int i;
-
- mbi = (struct multiboot_info *)rom_table_end;
-
- memset(mbi, 0, sizeof(*mbi));
- rom_table_end += sizeof(*mbi);
-
- mbi->mmap_addr = (u32) rom_table_end;
- mb_mem = (struct multiboot_mmap_entry *)rom_table_end;
-
- /* copy regions from coreboot tables */
- coreboot_table = get_lb_mem();
- entries = (coreboot_table->size - sizeof(*coreboot_table))/sizeof(coreboot_table->map[0]);
-
- if (coreboot_table == NULL || entries < 1) {
- printk(BIOS_INFO, "%s: Cannot find coreboot table.\n", __func__);
- return (unsigned long) mb_mem;
- }
-
- for (i = 0; i < entries; i++) {
- uint64_t entry_start = unpack_lb64(coreboot_table->map[i].start);
- uint64_t entry_size = unpack_lb64(coreboot_table->map[i].size);
- mb_mem->addr = entry_start;
- mb_mem->len = entry_size;
- switch (coreboot_table->map[i].type) {
- case LB_MEM_RAM:
- mb_mem->type = MULTIBOOT_MEMORY_AVAILABLE;
- break;
- default: // anything other than usable RAM
- mb_mem->type = MULTIBOOT_MEMORY_RESERVED;
- break;
- }
- mb_mem->size = sizeof(*mb_mem) - sizeof(mb_mem->size);
- mb_mem++;
- }
-
- mbi->mmap_length = ((u32) mb_mem) - mbi->mmap_addr;
- mbi->flags |= MB_INFO_MEM_MAP;
-
- printk(BIOS_INFO, "Multiboot Information structure has been written.\n");
-
- return (unsigned long)mb_mem;
-}
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2391
-gerrit
commit 2a833793bb87a5ae97edbeff587ae0260460eb96
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Thu Feb 14 13:38:38 2013 -0800
Exynos: Drop duplicate copy of watchdog.h
Change-Id: I4c9bfa9eb7708420dc42c16bc152d761d2bdfee3
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
---
src/cpu/samsung/exynos5-common/watchdog.h | 57 -------------------------------
src/cpu/samsung/exynos5250/watchdog.h | 27 ---------------
src/cpu/samsung/s5p-common/watchdog.h | 5 ++-
3 files changed, 2 insertions(+), 87 deletions(-)
diff --git a/src/cpu/samsung/exynos5-common/watchdog.h b/src/cpu/samsung/exynos5-common/watchdog.h
deleted file mode 100644
index 5b3b651..0000000
--- a/src/cpu/samsung/exynos5-common/watchdog.h
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * Copyright (C) 2011 Samsung Electronics
- * Heungjun Kim <riverful.kim(a)samsung.com>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-#ifndef __ASM_ARM_ARCH_COMMON_WATCHDOG_H_
-#define __ASM_ARM_ARCH_COMMON_WATCHDOG_H_
-
-#define WTCON_RESET_OFFSET 0
-#define WTCON_INTEN_OFFSET 2
-#define WTCON_CLKSEL_OFFSET 3
-#define WTCON_EN_OFFSET 5
-#define WTCON_PRE_OFFSET 8
-
-#define WTCON_CLK_16 0x0
-#define WTCON_CLK_32 0x1
-#define WTCON_CLK_64 0x2
-#define WTCON_CLK_128 0x3
-
-#define WTCON_CLK(x) ((x & 0x3) << WTCON_CLKSEL_OFFSET)
-#define WTCON_PRESCALER(x) ((x) << WTCON_PRE_OFFSET)
-#define WTCON_EN (0x1 << WTCON_EN_OFFSET)
-#define WTCON_RESET (0x1 << WTCON_RESET_OFFSET)
-#define WTCON_INT (0x1 << WTCON_INTEN_OFFSET)
-
-#ifndef __ASSEMBLER__
-struct s5p_watchdog {
- unsigned int wtcon;
- unsigned int wtdat;
- unsigned int wtcnt;
- unsigned int wtclrint;
-};
-
-/* functions */
-void wdt_stop(void);
-void wdt_start(unsigned int timeout);
-#endif /* __ASSEMBLER__ */
-
-#endif
diff --git a/src/cpu/samsung/exynos5250/watchdog.h b/src/cpu/samsung/exynos5250/watchdog.h
deleted file mode 100644
index f35dde4..0000000
--- a/src/cpu/samsung/exynos5250/watchdog.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * (C) Copyright 2012 Samsung Electronics
- * Minkyu Kang <mk7.kang(a)samsung.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- *
- */
-
-#ifndef __ASM_ARM_ARCH_EXYNOS5_WATCHDOG_H__
-#define __ASM_ARM_ARCH_EXYNOS5_WATCHDOG_H__
-
-#include <asm/arch-exynos/watchdog.h>
-
-#endif /* __ASM_ARM_ARCH_EXYNOS5_WATCHDOG_H__ */
diff --git a/src/cpu/samsung/s5p-common/watchdog.h b/src/cpu/samsung/s5p-common/watchdog.h
index 8c8bf0a..5b3b651 100644
--- a/src/cpu/samsung/s5p-common/watchdog.h
+++ b/src/cpu/samsung/s5p-common/watchdog.h
@@ -1,7 +1,6 @@
/*
* Copyright (C) 2011 Samsung Electronics
* Heungjun Kim <riverful.kim(a)samsung.com>
- * Minkyu Kang <mk7.kang(a)samsung.com>
*
* See file CREDITS for list of people who contributed to this
* project.
@@ -22,8 +21,8 @@
* MA 02111-1307 USA
*/
-#ifndef __ASM_ARM_ARCH_WATCHDOG_H_
-#define __ASM_ARM_ARCH_WATCHDOG_H_
+#ifndef __ASM_ARM_ARCH_COMMON_WATCHDOG_H_
+#define __ASM_ARM_ARCH_COMMON_WATCHDOG_H_
#define WTCON_RESET_OFFSET 0
#define WTCON_INTEN_OFFSET 2
the following patch was just integrated into master:
commit c2e8cf56757b72b963753848d46c7932445029d5
Author: Ronald G. Minnich <rminnich(a)gmail.com>
Date: Thu Feb 14 11:32:29 2013 -0800
libpayload; put the ldscript into an arch-dependent directory path
Since it's utterly architecture-dependent, put it in arch/x86.
Avoid the temptation to make yet another directory with just one
file in it. Fix the makefile to pick up the proper arch-dependent script.
Change-Id: I21ea02551a97bdcbc38419714f3b38cf8335c178
Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com>
Reviewed-on: http://review.coreboot.org/2389
Tested-by: build bot (Jenkins)
Reviewed-by: David Hendricks <dhendrix(a)chromium.org>
Build-Tested: build bot (Jenkins) at Thu Feb 14 21:00:13 2013, giving +1
See http://review.coreboot.org/2389 for details.
-gerrit
Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2389
-gerrit
commit 6a90a67d0987975ff68c441837f7b367f91ac2d2
Author: Ronald G. Minnich <rminnich(a)gmail.com>
Date: Thu Feb 14 11:32:29 2013 -0800
libpayload; put the ldscript into an arch-dependent directory path
Since it's utterly architecture-dependent, put it in arch/x86.
Avoid the temptation to make yet another directory with just one
file in it. Fix the makefile to pick up the proper arch-dependent script.
Change-Id: I21ea02551a97bdcbc38419714f3b38cf8335c178
Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com>
---
payloads/libpayload/Makefile.inc | 2 +-
payloads/libpayload/arch/x86/libpayload.ldscript | 92 ++++++++++++++++++++++++
payloads/libpayload/lib/libpayload.ldscript | 92 ------------------------
3 files changed, 93 insertions(+), 93 deletions(-)
diff --git a/payloads/libpayload/Makefile.inc b/payloads/libpayload/Makefile.inc
index 908d0e7..4c434a3 100644
--- a/payloads/libpayload/Makefile.inc
+++ b/payloads/libpayload/Makefile.inc
@@ -97,7 +97,7 @@ install: real-target
for lib in $(library-targets); do \
install -m 644 $$lib $(DESTDIR)/libpayload/lib/; \
done
- install -m 644 lib/libpayload.ldscript $(DESTDIR)/libpayload/lib/
+ install -m 644 arch/$(ARCHDIR-y)/libpayload.ldscript $(DESTDIR)/libpayload/lib/
install -m 755 -d $(DESTDIR)/libpayload/lib/$(ARCHDIR-y)
install -m 644 $(obj)/head.o $(DESTDIR)/libpayload/lib/$(ARCHDIR-y)
printf " INSTALL $(DESTDIR)/libpayload/include\n"
diff --git a/payloads/libpayload/arch/x86/libpayload.ldscript b/payloads/libpayload/arch/x86/libpayload.ldscript
new file mode 100644
index 0000000..3e7d4cc
--- /dev/null
+++ b/payloads/libpayload/arch/x86/libpayload.ldscript
@@ -0,0 +1,92 @@
+/*
+ * This file is part of the libpayload project.
+ *
+ * Copyright (C) 2008 Advanced Micro Devices, Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * 3. The name of the author may not be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ */
+
+BASE_ADDRESS = 0x100000;
+
+OUTPUT_FORMAT(elf32-i386)
+OUTPUT_ARCH(i386)
+
+ENTRY(_entry)
+
+HEAP_SIZE = 2*64*1024;
+STACK_SIZE = 16384;
+
+SECTIONS
+{
+ . = BASE_ADDRESS;
+
+ . = ALIGN(16);
+ _start = .;
+
+ .text : {
+ *(.text._entry)
+ *(.text)
+ *(.text.*)
+ }
+
+ .rodata : {
+ *(.rodata)
+ *(.rodata.*)
+ }
+
+ .data : {
+ *(.data)
+ *(.data.*)
+ }
+
+ _edata = .;
+
+ .bss : {
+ *(.sbss)
+ *(.sbss.*)
+ *(.bss)
+ *(.bss.*)
+ *(COMMON)
+
+ /* Stack and heap */
+
+ . = ALIGN(16);
+ _heap = .;
+ . += HEAP_SIZE;
+ . = ALIGN(16);
+ _eheap = .;
+
+ _estack = .;
+ . += STACK_SIZE;
+ . = ALIGN(16);
+ _stack = .;
+ }
+
+ _end = .;
+
+ /DISCARD/ : {
+ *(.comment)
+ *(.note*)
+ }
+}
diff --git a/payloads/libpayload/lib/libpayload.ldscript b/payloads/libpayload/lib/libpayload.ldscript
deleted file mode 100644
index 3e7d4cc..0000000
--- a/payloads/libpayload/lib/libpayload.ldscript
+++ /dev/null
@@ -1,92 +0,0 @@
-/*
- * This file is part of the libpayload project.
- *
- * Copyright (C) 2008 Advanced Micro Devices, Inc.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- * derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
- */
-
-BASE_ADDRESS = 0x100000;
-
-OUTPUT_FORMAT(elf32-i386)
-OUTPUT_ARCH(i386)
-
-ENTRY(_entry)
-
-HEAP_SIZE = 2*64*1024;
-STACK_SIZE = 16384;
-
-SECTIONS
-{
- . = BASE_ADDRESS;
-
- . = ALIGN(16);
- _start = .;
-
- .text : {
- *(.text._entry)
- *(.text)
- *(.text.*)
- }
-
- .rodata : {
- *(.rodata)
- *(.rodata.*)
- }
-
- .data : {
- *(.data)
- *(.data.*)
- }
-
- _edata = .;
-
- .bss : {
- *(.sbss)
- *(.sbss.*)
- *(.bss)
- *(.bss.*)
- *(COMMON)
-
- /* Stack and heap */
-
- . = ALIGN(16);
- _heap = .;
- . += HEAP_SIZE;
- . = ALIGN(16);
- _eheap = .;
-
- _estack = .;
- . += STACK_SIZE;
- . = ALIGN(16);
- _stack = .;
- }
-
- _end = .;
-
- /DISCARD/ : {
- *(.comment)
- *(.note*)
- }
-}