coreboot January 2013

coreboot@coreboot.org

32 participants
607 discussions

Patch merged into coreboot/master: 2f25d99 ARMv7: drop __ASSEMBLY__
by gerrit＠coreboot.org 04 Jan '13

04 Jan '13

the following patch was just integrated into master: commit 2f25d9963ee6ba57db67a0410fcd932f4be18373 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jan 4 16:29:29 2013 -0800 ARMv7: drop __ASSEMBLY__ We moved to using __ASSEMBLER__ years ago since it is set by as. Change-Id: I60103ba23ebe87be1d0bc63beed0ef5b05eed4f2 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2111 Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Tested-by: build bot (Jenkins) Build-Tested: build bot (Jenkins) at Sat Jan 5 01:37:10 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Sat Jan 5 01:32:46 2013, giving +2 See http://review.coreboot.org/2111 for details. -gerrit

1 0

Patch set updated for coreboot: 1486cb4 armv7: invoke intermediate build rules
by Stefan Reinauer 04 Jan '13

04 Jan '13

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2095 -gerrit commit 1486cb4ae67c7778f7e75b218f1b85a66c9aa2e6 Author: David Hendricks <dhendrix(a)chromium.org> Date: Wed Jan 2 17:48:49 2013 -0800 armv7: invoke intermediate build rules This adds $$(INTERMEDIATE) as a pre-requisite for coreboot.rom on armv7. It is modeled after the $(obj)/coreboot.rom rule for x86. Change-Id: I483a88035fa2288829b6e042e51ef932c8c4f23c Signed-off-by: David Hendricks <dhendrix(a)chromium.org> --- src/arch/armv7/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/armv7/Makefile.inc b/src/arch/armv7/Makefile.inc index d7fbbdf..8176f9a 100644 --- a/src/arch/armv7/Makefile.inc +++ b/src/arch/armv7/Makefile.inc @@ -58,7 +58,7 @@ $(obj)/coreboot.pre1: $(CBFSTOOL) mv $(obj)/coreboot.rom $@ endif -$(obj)/coreboot.rom: $(obj)/coreboot.pre $(objcbfs)/coreboot_ram.elf $(CBFSTOOL) $(call strip_quotes,$(COREBOOT_ROM_DEPENDENCIES)) +$(obj)/coreboot.rom: $(obj)/coreboot.pre $(objcbfs)/coreboot_ram.elf $(CBFSTOOL) $(call strip_quotes,$(COREBOOT_ROM_DEPENDENCIES)) $$(INTERMEDIATE) @printf " CBFS $(subst $(obj)/,,$(@))\n" cp $(obj)/coreboot.pre $@.tmp if [ -f $(objcbfs)/coreboot_ap.elf ]; \

1 0

Patch merged into coreboot/master: 9bcab0c Update 3rdparty mark to latest repository
by gerrit＠coreboot.org 04 Jan '13

04 Jan '13

the following patch was just integrated into master: commit 9bcab0c72bea6188ebf735ce08ba269ef5f9a272 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jan 4 16:04:34 2013 -0800 Update 3rdparty mark to latest repository Change-Id: I59fca4427345c7e677138b944613a1554d5a8331 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2110 Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Tested-by: build bot (Jenkins) Build-Tested: build bot (Jenkins) at Sat Jan 5 01:13:54 2013, giving +1 See http://review.coreboot.org/2110 for details. -gerrit

1 0

New patch to review for coreboot: 6fa27b8 ARMv7: drop __ASSEMBLY__
by Stefan Reinauer 04 Jan '13

04 Jan '13

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2111 -gerrit commit 6fa27b85b7c766d7901e28d5ad014bba499e33b7 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jan 4 16:29:29 2013 -0800 ARMv7: drop __ASSEMBLY__ We moved to using __ASSEMBLER__ years ago since it is set by as. Change-Id: I60103ba23ebe87be1d0bc63beed0ef5b05eed4f2 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/arch/armv7/include/system.h | 2 +- src/arch/armv7/init.S | 1 - src/arch/armv7/start.S | 1 - src/cpu/samsung/exynos5-common/adc.h | 2 +- src/cpu/samsung/exynos5-common/gpio.h | 2 +- src/cpu/samsung/exynos5-common/mmc.h | 4 ++-- src/cpu/samsung/exynos5-common/mshc.h | 2 +- src/cpu/samsung/exynos5-common/pwm.h | 4 ++-- src/cpu/samsung/exynos5-common/spi.h | 4 ++-- src/cpu/samsung/exynos5-common/sromc.h | 4 ++-- src/cpu/samsung/exynos5-common/watchdog.h | 4 ++-- src/cpu/samsung/exynos5250/cpu.h | 2 +- src/cpu/samsung/exynos5250/spi.h | 4 ++-- src/cpu/samsung/s5p-common/clock.h | 2 +- src/cpu/samsung/s5p-common/gpio.h | 2 +- src/cpu/samsung/s5p-common/mmc.h | 4 ++-- src/cpu/samsung/s5p-common/pwm.h | 4 ++-- src/cpu/samsung/s5p-common/sromc.h | 4 ++-- src/cpu/samsung/s5p-common/uart.h | 4 ++-- src/cpu/samsung/s5p-common/watchdog.h | 4 ++-- 20 files changed, 29 insertions(+), 31 deletions(-) diff --git a/src/arch/armv7/include/system.h b/src/arch/armv7/include/system.h index 3e14fdb..c74ce8c 100644 --- a/src/arch/armv7/include/system.h +++ b/src/arch/armv7/include/system.h @@ -60,7 +60,7 @@ #define arch_align_stack(x) (x) -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ static inline unsigned int get_cr(void) { unsigned int val; diff --git a/src/arch/armv7/init.S b/src/arch/armv7/init.S index 033637e..7848581 100644 --- a/src/arch/armv7/init.S +++ b/src/arch/armv7/init.S @@ -29,7 +29,6 @@ * MA 02111-1307 USA */ -#define __ASSEMBLY__ #include <system.h> .globl _start diff --git a/src/arch/armv7/start.S b/src/arch/armv7/start.S index 63cac4b..8af48eb 100644 --- a/src/arch/armv7/start.S +++ b/src/arch/armv7/start.S @@ -29,7 +29,6 @@ * MA 02111-1307 USA */ -#define __ASSEMBLY__ #include <system.h> .globl _start diff --git a/src/cpu/samsung/exynos5-common/adc.h b/src/cpu/samsung/exynos5-common/adc.h index dc905d1..64f4813 100644 --- a/src/cpu/samsung/exynos5-common/adc.h +++ b/src/cpu/samsung/exynos5-common/adc.h @@ -25,7 +25,7 @@ #ifndef __ASM_ARM_ARCH_COMMON_ADC_H_ #define __ASM_ARM_ARCH_COMMON_ADC_H_ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_adc { unsigned int adccon; unsigned int adctsc; diff --git a/src/cpu/samsung/exynos5-common/gpio.h b/src/cpu/samsung/exynos5-common/gpio.h index 37dd678..d291fae 100644 --- a/src/cpu/samsung/exynos5-common/gpio.h +++ b/src/cpu/samsung/exynos5-common/gpio.h @@ -21,7 +21,7 @@ #ifndef __ASM_ARCH_COMMON_GPIO_H #define __ASM_ARCH_COMMON_GPIO_H -#ifndef __ASSEMBLY__ /* FIXME: not needed (i hope)? */ +#ifndef __ASSEMBLER__ /* FIXME: not needed (i hope)? */ #include <cpu/samsung/s5p-common/gpio.h> /* FIXME: s5p's gpio.h and exynos' gpio.h have a lot of conflicting definitions */ diff --git a/src/cpu/samsung/exynos5-common/mmc.h b/src/cpu/samsung/exynos5-common/mmc.h index 4e43589..f607f82 100644 --- a/src/cpu/samsung/exynos5-common/mmc.h +++ b/src/cpu/samsung/exynos5-common/mmc.h @@ -21,7 +21,7 @@ #ifndef __ASM_ARCH_COMMON_MMC_H_ #define __ASM_ARCH_COMMON_MMC_H_ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_mmc { unsigned int sysad; unsigned short blksize; @@ -73,5 +73,5 @@ int s5p_mmc_init(const void *blob); int s5p_mmc_init(int dev_index, int bus_width); #endif -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif diff --git a/src/cpu/samsung/exynos5-common/mshc.h b/src/cpu/samsung/exynos5-common/mshc.h index bdb0a9c..623492c 100644 --- a/src/cpu/samsung/exynos5-common/mshc.h +++ b/src/cpu/samsung/exynos5-common/mshc.h @@ -21,7 +21,7 @@ #define __ASM_ARCH_COMMON_MSHC_H #include <asm/arch/pinmux.h> -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct mshci_host { struct s5p_mshci *reg; /* Mapped address */ unsigned int clock; /* Current clock in MHz */ diff --git a/src/cpu/samsung/exynos5-common/pwm.h b/src/cpu/samsung/exynos5-common/pwm.h index e35d88d..a4e0acf 100644 --- a/src/cpu/samsung/exynos5-common/pwm.h +++ b/src/cpu/samsung/exynos5-common/pwm.h @@ -42,7 +42,7 @@ #define TCON_AUTO_RELOAD(x) (1 << (TCON_OFFSET(x) + 3)) #define TCON4_AUTO_RELOAD (1 << 22) -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_timer { unsigned int tcfg0; unsigned int tcfg1; @@ -63,6 +63,6 @@ struct s5p_timer { unsigned int tcnto4; unsigned int tintcstat; }; -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif diff --git a/src/cpu/samsung/exynos5-common/spi.h b/src/cpu/samsung/exynos5-common/spi.h index 3430ac1..3f36759 100644 --- a/src/cpu/samsung/exynos5-common/spi.h +++ b/src/cpu/samsung/exynos5-common/spi.h @@ -20,7 +20,7 @@ #ifndef __ASM_ARCH_EXYNOS_COMMON_SPI_H_ #define __ASM_ARCH_EXYNOS_COMMON_SPI_H_ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ /* SPI peripheral register map; padded to 64KB */ struct exynos_spi { @@ -85,5 +85,5 @@ struct exynos_spi { #define SPI_RX_BYTE_SWAP (1 << 6) #define SPI_RX_HWORD_SWAP (1 << 7) -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif diff --git a/src/cpu/samsung/exynos5-common/sromc.h b/src/cpu/samsung/exynos5-common/sromc.h index b413373..d4fdae9 100644 --- a/src/cpu/samsung/exynos5-common/sromc.h +++ b/src/cpu/samsung/exynos5-common/sromc.h @@ -38,12 +38,12 @@ #define SROMC_BC_TACP(x) (x << 4) /* page mode access cycle */ #define SROMC_BC_PMC(x) (x << 0) /* normal(1data)page mode configuration */ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_sromc { unsigned int bw; unsigned int bc[4]; }; -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ /* Configure the Band Width and Bank Control Regs for required SROMC Bank */ void s5p_config_sromc(u32 srom_bank, u32 srom_bw_conf, u32 srom_bc_conf); diff --git a/src/cpu/samsung/exynos5-common/watchdog.h b/src/cpu/samsung/exynos5-common/watchdog.h index af98638..5b3b651 100644 --- a/src/cpu/samsung/exynos5-common/watchdog.h +++ b/src/cpu/samsung/exynos5-common/watchdog.h @@ -41,7 +41,7 @@ #define WTCON_RESET (0x1 << WTCON_RESET_OFFSET) #define WTCON_INT (0x1 << WTCON_INTEN_OFFSET) -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_watchdog { unsigned int wtcon; unsigned int wtdat; @@ -52,6 +52,6 @@ struct s5p_watchdog { /* functions */ void wdt_stop(void); void wdt_start(unsigned int timeout); -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif diff --git a/src/cpu/samsung/exynos5250/cpu.h b/src/cpu/samsung/exynos5250/cpu.h index afd985a..f399a42 100644 --- a/src/cpu/samsung/exynos5250/cpu.h +++ b/src/cpu/samsung/exynos5250/cpu.h @@ -79,7 +79,7 @@ /* Distance between each Trust Zone PC register set */ #define TZPC_BASE_OFFSET 0x10000 -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ #define SAMSUNG_BASE(device, base) \ static inline unsigned int samsung_get_base_##device(void) \ diff --git a/src/cpu/samsung/exynos5250/spi.h b/src/cpu/samsung/exynos5250/spi.h index 3430ac1..3f36759 100644 --- a/src/cpu/samsung/exynos5250/spi.h +++ b/src/cpu/samsung/exynos5250/spi.h @@ -20,7 +20,7 @@ #ifndef __ASM_ARCH_EXYNOS_COMMON_SPI_H_ #define __ASM_ARCH_EXYNOS_COMMON_SPI_H_ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ /* SPI peripheral register map; padded to 64KB */ struct exynos_spi { @@ -85,5 +85,5 @@ struct exynos_spi { #define SPI_RX_BYTE_SWAP (1 << 6) #define SPI_RX_HWORD_SWAP (1 << 7) -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif diff --git a/src/cpu/samsung/s5p-common/clock.h b/src/cpu/samsung/s5p-common/clock.h index 7b4eb89..c0cd896 100644 --- a/src/cpu/samsung/s5p-common/clock.h +++ b/src/cpu/samsung/s5p-common/clock.h @@ -23,7 +23,7 @@ #ifndef __ASM_ARM_ARCH_CLOCK_H_ #define __ASM_ARM_ARCH_CLOCK_H_ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5pc100_clock { unsigned int apll_lock; unsigned int mpll_lock; diff --git a/src/cpu/samsung/s5p-common/gpio.h b/src/cpu/samsung/s5p-common/gpio.h index 2522808..d098bc8 100644 --- a/src/cpu/samsung/s5p-common/gpio.h +++ b/src/cpu/samsung/s5p-common/gpio.h @@ -23,7 +23,7 @@ #include <cpu/samsung/s5p-common/cpu.h> /* FIXME: for S5PC110_GPIO_BASE */ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_gpio_bank { unsigned int con; unsigned int dat; diff --git a/src/cpu/samsung/s5p-common/mmc.h b/src/cpu/samsung/s5p-common/mmc.h index adef4ee..675666c 100644 --- a/src/cpu/samsung/s5p-common/mmc.h +++ b/src/cpu/samsung/s5p-common/mmc.h @@ -21,7 +21,7 @@ #ifndef __ASM_ARCH_MMC_H_ #define __ASM_ARCH_MMC_H_ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_mmc { unsigned int sysad; unsigned short blksize; @@ -69,5 +69,5 @@ struct mmc_host { int s5p_mmc_init(int dev_index, int bus_width); -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif diff --git a/src/cpu/samsung/s5p-common/pwm.h b/src/cpu/samsung/s5p-common/pwm.h index 1ac348b..9d9370d 100644 --- a/src/cpu/samsung/s5p-common/pwm.h +++ b/src/cpu/samsung/s5p-common/pwm.h @@ -42,7 +42,7 @@ #define TCON_AUTO_RELOAD(x) (1 << (TCON_OFFSET(x) + 3)) #define TCON4_AUTO_RELOAD (1 << 22) -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_timer { unsigned int tcfg0; unsigned int tcfg1; @@ -63,7 +63,7 @@ struct s5p_timer { unsigned int tcnto4; unsigned int tintcstat; }; -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ /* FIXME(dhendrix): added missing prototypes... */ int pwm_config(int pwm_id, int duty_ns, int period_ns); diff --git a/src/cpu/samsung/s5p-common/sromc.h b/src/cpu/samsung/s5p-common/sromc.h index 3800a8d..fe73b37 100644 --- a/src/cpu/samsung/s5p-common/sromc.h +++ b/src/cpu/samsung/s5p-common/sromc.h @@ -40,12 +40,12 @@ #define SMC_BC_TACP(x) (x << 4) /* 6clk page mode access cycle */ #define SMC_BC_PMC(x) (x << 0) /* normal(1data)page mode configuration */ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_sromc { unsigned int bw; unsigned int bc[6]; }; -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ /* Configure the Band Width and Bank Control Regs for required SROMC Bank */ void s5p_config_sromc(u32 srom_bank, u32 srom_bw_conf, u32 srom_bc_conf); diff --git a/src/cpu/samsung/s5p-common/uart.h b/src/cpu/samsung/s5p-common/uart.h index 1c56739..bf396cc 100644 --- a/src/cpu/samsung/s5p-common/uart.h +++ b/src/cpu/samsung/s5p-common/uart.h @@ -23,7 +23,7 @@ #ifndef __ASM_ARCH_UART_H_ #define __ASM_ARCH_UART_H_ -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ /* baudrate rest value */ union br_rest { unsigned short slot; /* udivslot */ @@ -53,6 +53,6 @@ static inline int s5p_uart_divslot(void) return 1; } -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif diff --git a/src/cpu/samsung/s5p-common/watchdog.h b/src/cpu/samsung/s5p-common/watchdog.h index 0f80ca5..8c8bf0a 100644 --- a/src/cpu/samsung/s5p-common/watchdog.h +++ b/src/cpu/samsung/s5p-common/watchdog.h @@ -42,7 +42,7 @@ #define WTCON_RESET (0x1 << WTCON_RESET_OFFSET) #define WTCON_INT (0x1 << WTCON_INTEN_OFFSET) -#ifndef __ASSEMBLY__ +#ifndef __ASSEMBLER__ struct s5p_watchdog { unsigned int wtcon; unsigned int wtdat; @@ -53,6 +53,6 @@ struct s5p_watchdog { /* functions */ void wdt_stop(void); void wdt_start(unsigned int timeout); -#endif /* __ASSEMBLY__ */ +#endif /* __ASSEMBLER__ */ #endif

1 0

New patch to review for coreboot: fd7e1b9 Update 3rdparty mark to latest repository
by Stefan Reinauer 04 Jan '13

04 Jan '13

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2110 -gerrit commit fd7e1b946ef7b825c2b4f644538663fda19cb805 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jan 4 16:04:34 2013 -0800 Update 3rdparty mark to latest repository Change-Id: I59fca4427345c7e677138b944613a1554d5a8331 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- 3rdparty | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/3rdparty b/3rdparty index 7eb78b1..4c0dcf9 160000 --- a/3rdparty +++ b/3rdparty @@ -1 +1 @@ -Subproject commit 7eb78b1109242653c60cccd741951dcb58f51cec +Subproject commit 4c0dcf96ae73ba31bf9aa689768a5ecd47bac19e

1 0

Re: [coreboot] Feedback On Coreboot: the Solution to the Secure Boot Fiasco
by Andrew Goodbody 04 Jan '13

04 Jan '13

On 03/01/13 18:40, ron minnich wrote: > OK, after further thought, here's my take. > > Two companies have defined a secure boot standard in such a way that > they can closely control what boots on future systems using the one > company's chips. This is a sea change from the original IBM PC design, > which encouraged people to boot anything, and included the > (copyrighted) BIOS listing on paper to further that end. OK, then there was a simple source listing so you could see what the code provided in terms of functionality and then implement that functionality. Now you have the UEFI spec so you can implement the required functionality. There is nothing specific to those companies here. Yes Secure Boot makes it harder to change the OS shipped on any particular machine and bugs or deficiencies may even make it impossible in some cases. But given the goal of only running authorised code then this is inevitable. > The current state is that the software company is becoming the > gatekeeper for what OS will run on systems built using the hardware > company's chips. Their end goal is that the software company becomes > the gatekeeper for what runs on almost *anything* -- not just x86. > Don't believe me? Read about ARM systems and Windows 8. I have yet to see Linux or Android on an iPad. WinRT (not Win8) on ARM is little different, if at all. It will have no effect whatsoever on other tablets. They do not control all ARM tablets and never will. Andrew

2 1

Patch merged into coreboot/master: 6d47cbe ARMv7: drop __KERNEL__
by gerrit＠coreboot.org 04 Jan '13

04 Jan '13

the following patch was just integrated into master: commit 6d47cbe75859eaca4d56dd371d9dee6bd75dd23d Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jan 4 15:02:25 2013 -0800 ARMv7: drop __KERNEL__ It's a bad Linux heritage.. We have no userland in firmware. Change-Id: Ib19e5ba713078ca37514571213d19f418417b964 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2108 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Sat Jan 5 00:10:55 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Sat Jan 5 00:32:13 2013, giving +2 See http://review.coreboot.org/2108 for details. -gerrit

1 0

Re: [coreboot] Feedback On Coreboot: the Solution to the Secure Boot Fiasco
by Andrew Goodbody 04 Jan '13

04 Jan '13

On 02/01/13 19:28, David Hubbard wrote: > Andrew, Ron, what's your take on http://mjg59.dreamwidth.org/20916.html ? > > Specifically: > "This is part of Windows 8's fast boot support - the keyboard may not be > initialised until after the OS has started." OK, the feature is deferred initialisation of USB devices until they are actually needed. Windows 8 is making use of this but it is introduced as part of the UEFI spec 2.3.1c. This is optional to implement it or not, OEM gets to decide. This is in the UEFI spec and can be used by other OSes than Windows eg Grub could use it to speed up loading of Linux. > 4. User is thus *forced* to use Win8's "hold down shift and restart" > feature -- adding another barrier before a user can boot her own OS. > > I think the biggest problem here is that the entire BIOS is made > inaccessible, and only if Windows gives permission can you change that. Well yes and no. 1) PS/2 keyboards are not affected, they are still initialised and available as normal. Many laptop keyboards are implemented as PS/2 devices. 2) There are a number of ways that you can get USB enumerated and keyboards initialised. a) If HDD is not primary boot target b) If primary boot target fails c) If bootloader invokes EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL. ReadKeyStrokeEx() So yes, on a motherboard that implements it, with no PS/2 keyboard, with the HDD as primary boot target and with Win8 installed then you may have to use the Win8 menu to restart into the UEFI settings screens. And yes this can be a small barrier to booting using an alternative method for any reason, not just installing an alternative OS. But quite frankly I have seen some bizarre setup screens on legacy BIOS that made choosing to boot from a USB device an exercise in frustration. So this extra step in the road to booting an alternate OS is not that big a deal. It can at least be documented and is not a hard thing to do at all. Even without this there are some machines that boot so fast it is not easy to press the key to get to the setup screens at the right time, this may actually give a more reliable way to get to the setup screens on those machines. > Regards, > David BTW 1) when you use BIOS above, you actually mean Setup. Setup is an application launched by the BIOS to view or change system settings. The BIOS is not accessible nor inaccessible, it is running as soon as the CPU begins to execute code and will complete its tasks as normal according to those system settings. BTW 2) its UEFI firmware, not BIOS. Just as coreboot is not BIOS. Best wishes, Andrew

2 1

New patch to review for coreboot: 4cfb3d8 ARMv7: drop __KERNEL__
by Stefan Reinauer 04 Jan '13

04 Jan '13

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2108 -gerrit commit 4cfb3d80c413adbc7cfffceba4ab5a44907d45ca Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jan 4 15:02:25 2013 -0800 ARMv7: drop __KERNEL__ It's a bad Linux heritage.. We have no userland in firmware. Change-Id: Ib19e5ba713078ca37514571213d19f418417b964 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/arch/armv7/Makefile.inc | 1 - src/arch/armv7/include/arch/atomic.h | 111 ----------------------------------- src/arch/armv7/include/arch/io.h | 6 -- src/arch/armv7/include/arch/types.h | 7 --- 4 files changed, 125 deletions(-) diff --git a/src/arch/armv7/Makefile.inc b/src/arch/armv7/Makefile.inc index fcb6a17..d7fbbdf 100644 --- a/src/arch/armv7/Makefile.inc +++ b/src/arch/armv7/Makefile.inc @@ -147,7 +147,6 @@ CFLAGS += \ -mthumb-interwork # For various headers imported from Linux -CFLAGS += -D__KERNEL__ CFLAGS += -D__LINUX_ARM_ARCH__=7 crt0s = $(src)/arch/armv7/init.S diff --git a/src/arch/armv7/include/arch/atomic.h b/src/arch/armv7/include/arch/atomic.h deleted file mode 100644 index 5a8954f..0000000 --- a/src/arch/armv7/include/arch/atomic.h +++ /dev/null @@ -1,111 +0,0 @@ -/* - * linux/include/asm-arm/atomic.h - * - * Copyright (c) 1996 Russell King. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * Changelog: - * 27-06-1996 RMK Created - * 13-04-1997 RMK Made functions atomic! - * 07-12-1997 RMK Upgraded for v2.1. - * 26-08-1998 PJB Added #ifdef __KERNEL__ - */ -#ifndef __ASM_ARM_ATOMIC_H -#define __ASM_ARM_ATOMIC_H - -#include <linux/config.h> - -#ifdef CONFIG_SMP -#error SMP not supported -#endif - -typedef struct { volatile int counter; } atomic_t; - -#define ATOMIC_INIT(i) { (i) } - -#include <asm/proc/system.h> - -#define atomic_read(v) ((v)->counter) -#define atomic_set(v,i) (((v)->counter) = (i)) - -static inline void atomic_add(int i, volatile atomic_t *v) -{ - unsigned long flags; - - local_irq_save(flags); - v->counter += i; - local_irq_restore(flags); -} - -static inline void atomic_sub(int i, volatile atomic_t *v) -{ - unsigned long flags; - - local_irq_save(flags); - v->counter -= i; - local_irq_restore(flags); -} - -static inline void atomic_inc(volatile atomic_t *v) -{ - unsigned long flags; - - local_irq_save(flags); - v->counter += 1; - local_irq_restore(flags); -} - -static inline void atomic_dec(volatile atomic_t *v) -{ - unsigned long flags; - - local_irq_save(flags); - v->counter -= 1; - local_irq_restore(flags); -} - -static inline int atomic_dec_and_test(volatile atomic_t *v) -{ - unsigned long flags; - int val; - - local_irq_save(flags); - val = v->counter; - v->counter = val -= 1; - local_irq_restore(flags); - - return val == 0; -} - -static inline int atomic_add_negative(int i, volatile atomic_t *v) -{ - unsigned long flags; - int val; - - local_irq_save(flags); - val = v->counter; - v->counter = val += i; - local_irq_restore(flags); - - return val < 0; -} - -static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) -{ - unsigned long flags; - - local_irq_save(flags); - *addr &= ~mask; - local_irq_restore(flags); -} - -/* Atomic operations are already serializing on ARM */ -#define smp_mb__before_atomic_dec() barrier() -#define smp_mb__after_atomic_dec() barrier() -#define smp_mb__before_atomic_inc() barrier() -#define smp_mb__after_atomic_inc() barrier() - -#endif diff --git a/src/arch/armv7/include/arch/io.h b/src/arch/armv7/include/arch/io.h index 7675a88..3bbd529 100644 --- a/src/arch/armv7/include/arch/io.h +++ b/src/arch/armv7/include/arch/io.h @@ -20,13 +20,8 @@ #ifndef __ASM_ARM_IO_H #define __ASM_ARM_IO_H -#ifdef __KERNEL__ - #include <types.h> #include <arch/byteorder.h> -#if 0 /* XXX###XXX */ -#include <asm/arch/hardware.h> -#endif /* XXX###XXX */ static inline void sync(void) { @@ -423,5 +418,4 @@ out: #define isa_check_signature(io,sig,len) (0) #endif /* __mem_isa */ -#endif /* __KERNEL__ */ #endif /* __ASM_ARM_IO_H */ diff --git a/src/arch/armv7/include/arch/types.h b/src/arch/armv7/include/arch/types.h index 71dc049..be7e76c 100644 --- a/src/arch/armv7/include/arch/types.h +++ b/src/arch/armv7/include/arch/types.h @@ -22,11 +22,6 @@ __extension__ typedef __signed__ long long __s64; __extension__ typedef unsigned long long __u64; #endif -/* - * These aren't exported outside the kernel to avoid name space clashes - */ -#ifdef __KERNEL__ - typedef signed char s8; typedef unsigned char u8; @@ -48,6 +43,4 @@ typedef u32 dma_addr_t; typedef unsigned long phys_addr_t; typedef unsigned long phys_size_t; -#endif /* __KERNEL__ */ - #endif

1 0

Patch merged into coreboot/master: 9da7570 cbfstool: Fix warnings on OS X
by gerrit＠coreboot.org 04 Jan '13

04 Jan '13

the following patch was just integrated into master: commit 9da7570b07abd99123afc0e95a72a6bb0dcbddf5 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Jan 4 13:51:36 2013 -0800 cbfstool: Fix warnings on OS X Most hton and noth functions are already available through the system headers we include on OS X, causing the compiler to warn about duplicate definitions. Change-Id: Id81852dfc028cf0c48155048c54d431436889c0e Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2106 Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Reviewed-by: David Hendricks <dhendrix(a)chromium.org> Tested-by: build bot (Jenkins) Build-Tested: build bot (Jenkins) at Fri Jan 4 23:24:56 2013, giving +1 See http://review.coreboot.org/2106 for details. -gerrit

1 0

← Newer
1
...
49
50
51
52
53
54
55
...
61
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2013