September 2012 - coreboot - mail.coreboot.org

Patch merged into coreboot/master: 58d6b64 Fix disconnect handling on UHCI root ports
by gerrit＠coreboot.org Sept. 21, 2012

Sept. 21, 2012

the following patch was just integrated into master: commit 58d6b64b87620f8dc112243dc4c2337f00dfcd5d Author: Anton Kochkov <anton.kochkov(a)gmail.com> Date: Thu Sep 20 10:22:52 2012 +0200 Fix disconnect handling on UHCI root ports Change-Id: I03b72cd1c6ed0df09c08f2a687d4f17fa3cf6afc Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Build-Tested: build bot (Jenkins) at Fri Sep 21 18:49:38 2012, giving +1 Reviewed-By: Anton Kochkov <anton.kochkov(a)gmail.com> at Fri Sep 21 23:47:05 2012, giving +2 See http://review.coreboot.org/1531 for details. -gerrit

1 0

Patch merged into coreboot/master: 1325fcc UHCI: use proper pointer size
by gerrit＠coreboot.org Sept. 21, 2012

Sept. 21, 2012

the following patch was just integrated into master: commit 1325fcc384a65a803c13aaaea50de46645d525e0 Author: Anton Kochkov <anton.kochkov(a)gmail.com> Date: Thu Sep 20 10:24:01 2012 +0200 UHCI: use proper pointer size We used sizeof(listp*) at a place where sizeof(listp) is more appropriate: While these are pointers, they're part of the UHCI design, and don't depend on ISA details. Change-Id: I4d3cb571c9a407103bc81fc171a8e73b68f7c7a1 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Build-Tested: build bot (Jenkins) at Fri Sep 21 18:35:56 2012, giving +1 Reviewed-By: Anton Kochkov <anton.kochkov(a)gmail.com> at Fri Sep 21 23:46:23 2012, giving +2 See http://review.coreboot.org/1530 for details. -gerrit

1 0

New patch to review for coreboot: afb58bf buildsystem: ensure directory exists before use
by Patrick Georgi Sept. 21, 2012

Sept. 21, 2012

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1532 -gerrit commit afb58bfd0df28c0d59126129322be953d1db6060 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Fri Sep 21 18:11:59 2012 +0200 buildsystem: ensure directory exists before use In some cases we request mktemp to create a temporary file in $(obj)/mainboard/... before it exists. Let's make sure the directory exists Change-Id: I51f0065c30b1f25eb501a6fd5edefb3f4c15d0ab Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.inc b/Makefile.inc index bcf0e6e..a214a86 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -126,7 +126,7 @@ cbfs-files-handler= \ $(eval tmp-cbfs-file:= $($(2)-file))) \ $(if $(tmp-cbfs-method), \ $(eval tmp-old-cbfs-file:=$(tmp-cbfs-file)) \ - $(eval tmp-cbfs-file:=$(shell mktemp $(obj)/mainboard/$(MAINBOARDDIR)/cbfs-file.XXXXXX).out) \ + $(eval tmp-cbfs-file:=$(shell mkdir -p $(obj)/mainboard/$(MAINBOARDDIR); mktemp $(obj)/mainboard/$(MAINBOARDDIR)/cbfs-file.XXXXXX).out) \ $(call cbfs-files-processor-$(tmp-cbfs-method),$(tmp-old-cbfs-file),$(tmp-cbfs-file))) \ $(eval cbfs-files += $(tmp-cbfs-file)|$(2)|$($(2)-type)|$($(2)-compression)|$($(2)-position)) \ $(eval $(2)-name:=) \

1 0

New patch to review for coreboot: 58d6b64 Fix disconnect handling on UHCI root ports
by Patrick Georgi Sept. 21, 2012

Sept. 21, 2012

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1531 -gerrit commit 58d6b64b87620f8dc112243dc4c2337f00dfcd5d Author: Anton Kochkov <anton.kochkov(a)gmail.com> Date: Thu Sep 20 10:22:52 2012 +0200 Fix disconnect handling on UHCI root ports Change-Id: I03b72cd1c6ed0df09c08f2a687d4f17fa3cf6afc Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/drivers/usb/uhci_rh.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/payloads/libpayload/drivers/usb/uhci_rh.c b/payloads/libpayload/drivers/usb/uhci_rh.c index a5661b0..547f064 100644 --- a/payloads/libpayload/drivers/usb/uhci_rh.c +++ b/payloads/libpayload/drivers/usb/uhci_rh.c @@ -81,9 +81,14 @@ static void uhci_rh_disable_port (usbdev_t *dev, int port) { hci_t *controller = dev->controller; - port = PORTSC2; if (port == 1) port = PORTSC1; + else if (port == 2) + port = PORTSC2; + else { + debug("Invalid port %d\n", port); + return; + } uhci_reg_write16(controller, port, uhci_reg_read16(controller, port) & ~4); u16 value;

1 0

New patch to review for coreboot: 1325fcc UHCI: use proper pointer size
by Patrick Georgi Sept. 21, 2012

Sept. 21, 2012

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1530 -gerrit commit 1325fcc384a65a803c13aaaea50de46645d525e0 Author: Anton Kochkov <anton.kochkov(a)gmail.com> Date: Thu Sep 20 10:24:01 2012 +0200 UHCI: use proper pointer size We used sizeof(listp*) at a place where sizeof(listp) is more appropriate: While these are pointers, they're part of the UHCI design, and don't depend on ISA details. Change-Id: I4d3cb571c9a407103bc81fc171a8e73b68f7c7a1 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/drivers/usb/uhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/libpayload/drivers/usb/uhci.c b/payloads/libpayload/drivers/usb/uhci.c index 84b461a..635a8f1 100644 --- a/payloads/libpayload/drivers/usb/uhci.c +++ b/payloads/libpayload/drivers/usb/uhci.c @@ -175,7 +175,7 @@ uhci_init (pcidev_t addr) reg16 &= 0xdf80; pci_write_config16 (controller->bus_address, 0xc0, reg16); - UHCI_INST (controller)->framelistptr = memalign (0x1000, 1024 * sizeof (flistp_t *)); /* 4kb aligned to 4kb */ + UHCI_INST (controller)->framelistptr = memalign (0x1000, 1024 * sizeof (flistp_t)); /* 4kb aligned to 4kb */ if (! UHCI_INST (controller)->framelistptr) fatal("Not enough memory for USB frame list pointer.\n");

1 0

New patch to review for coreboot: cfd7999 AMD hudson: Truncate the float point number to integer
by Zheng Bao Sept. 21, 2012

Sept. 21, 2012

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1529 -gerrit commit cfd79991438949d84fa3b178dd4f3cb64883caf1 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 21 15:04:31 2012 +0800 AMD hudson: Truncate the float point number to integer From awk info: because all numbers in `awk' are floating-point numbers, the result is _not_ rounded to an integer--`3 / 4' has the value 0.75. For some system, the awk command printf("%c", 0.1); produces nothing, instead of 0. We need to convert the floating to integer. int(X) is an awk built-in function. Change-Id: I3470d5f13e7ea59a978d5575a54c0d56368dc78d Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- src/southbridge/amd/agesa/hudson/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc index 014524d..6a47080 100644 --- a/src/southbridge/amd/agesa/hudson/Makefile.inc +++ b/src/southbridge/amd/agesa/hudson/Makefile.inc @@ -58,7 +58,7 @@ $(obj)/hudson_romsig.bin: $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \ $(HUDSON_IMC_POSITION) \ $(HUDSON_GEC_POSITION) \ $(HUDSON_XHCI_POSITION) ; do \ - echo $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 256, $$1/256 % 256, $$1/65536 % 256, $$1/16777216);}'; \ + echo $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 256, int($$1/256) % 256, int($$1/65536) % 256, int($$1/16777216));}'; \ done > $@ ifeq ($(CONFIG_HUDSON_FWM), y)

1 0

starting with coreboot (questions with qemu-kvm: Could not find file 'fallback/payload'. ?)
by cheng renquan Sept. 20, 2012

Sept. 20, 2012

Hi all, I got a Cisco UCS and want to check if anyone had coreboot running on it? or I'd like to port coreboot onto it, to replace the default ami proprietary code; have just started playing with coreboot this week, trying run it with qemu, but have met problems: 1) git clone get a copy of latest coreboot code 2) make menuconfig; use all options default 3) make; building on a CentOS 5.8 failed with some ld seg fault 4) looked up some coreboot wiki entries; tried make crossgcc got build/coreboot.rom successfully; 5) qemu-kvm -L build -bios coreboot.rom -hda /dev/zero -serial stdio failed with "Could not find file 'fallback/payload'." Wrote coreboot table at: 07fe1c00, 0x1e0 bytes, checksum 8f60 coreboot table: 504 bytes. Multiboot Information structure has been written. 0. FREE SPACE 07fe9c00 00016400 1. GDT 07fe0200 00000200 2. IRQ TABLE 07fe0400 00001000 3. SMBIOS 07fe1400 00000800 4. COREBOOT 07fe1c00 00008000 CBFS: Could not find valid CBFS master header at fffcfc39: 4f524243 vs 6c91522d. CBFS: Could not find file 'fallback/payload'. Could not find a payload But actually use cbfstool print shows that it has fallback/payload, I tried menuconfig again to change some options, but still fruitless: 1) tried change ROM size, seems currently only 128KB or 256KB could boot under qemu, other larger ROM with qemu just get blank screen, blank serial output I have a UCS rom file in 16MB, but qemu seems unable to boot with 16MB rom? 2) change payload from SeaBIOS to FILO, the default version 0.6.0 build failed with cbfs_find_file redefinition error, use FILO HEAD could build, but failed with same above "Could not find a payload" $ build/cbfstool build/coreboot.rom print coreboot.rom: 256 kB, bootblocksize 848, romsize 262144, offset 0x0 Alignment: 64 bytes Name Offset Type Size cmos_layout.bin 0x0 cmos layout 1160 fallback/romstage 0x4c0 stage 9817 fallback/coreboot_ram 0x2b80 stage 30314 fallback/payload 0xa240 payload 75417 (empty) 0x1c940 null 144168 $ grep ^CBFS: build/serail-output-3 CBFS: Looking for 'fallback/coreboot_ram' CBFS: found. CBFS: loading stage fallback/coreboot_ram @ 0x100000 (147456 bytes), entry @ 0x100000 CBFS: Looking for 'pci1013,00b8.rom' CBFS: Could not find file 'pci1013,00b8.rom'. CBFS: Could not find valid CBFS master header at fffcfc39: 4f524243 vs 579100c9. CBFS: Could not find file 'pci10ec,8139.rom'. CBFS: Could not find valid CBFS master header at fffcfc39: 4f524243 vs 579100c9. CBFS: Could not find file 'pci1af4,1002.rom'. CBFS: Could not find valid CBFS master header at fffcfc39: 4f524243 vs 579100c9. CBFS: Could not find valid CBFS master header at fffcfc39: 4f524243 vs 579100c9. CBFS: Could not find file 'fallback/payload'.

1 0

Patch merged into coreboot/master: c4f5966 crossgcc: Change the term color back (trivial)
by gerrit＠coreboot.org Sept. 20, 2012

Sept. 20, 2012

the following patch was just integrated into master: commit c4f59669c04fe89f910c2ea79c9377a6e9c4e134 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Thu Sep 20 16:09:51 2012 +0800 crossgcc: Change the term color back (trivial) Change-Id: I6a7852eef32a3440c9d29e45420cb21d2db8c404 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Thu Sep 20 09:25:45 2012, giving +2 See http://review.coreboot.org/1528 for details. -gerrit

1 0

New patch to review for coreboot: c4f5966 crossgcc: Change the term color back (trivial)
by Zheng Bao Sept. 20, 2012

Sept. 20, 2012

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1528 -gerrit commit c4f59669c04fe89f910c2ea79c9377a6e9c4e134 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Thu Sep 20 16:09:51 2012 +0800 crossgcc: Change the term color back (trivial) Change-Id: I6a7852eef32a3440c9d29e45420cb21d2db8c404 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/crossgcc/buildgcc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 415b408..b79c5f6 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -262,7 +262,7 @@ for ARCHIVE in $GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE $LIBELF_ARCHIVE \ wget --no-check-certificate -q $ARCHIVE ) test -f tarballs/$FILE || \ - printf "\n${RED}Failed to download $FILE.${red}\n" + printf "\n${RED}Failed to download $FILE.${NC}\n" test -f tarballs/$FILE || exit 1 printf "\n" done @@ -293,7 +293,7 @@ for PACKAGE in GMP MPFR MPC LIBELF GCC BINUTILS $PYTHON_PACKAGE \ test -r $patch || continue printf " o `basename $patch`\n" $PATCH -s -N -p0 < `echo $patch` || \ - printf "\n${RED}Failed $patch.${red}\n" + printf "\n${RED}Failed $patch.${NC}\n" done ) done

1 0

Patch merged into coreboot/master: 08632f9 cimx sb700: change Platform.h to remove some warnings
by gerrit＠coreboot.org Sept. 19, 2012

Sept. 19, 2012

the following patch was just integrated into master: commit 08632f969856f76a573215028bba187deb5ec0b8 Author: Siyuan Wang <wangsiyuanbuaa(a)gmail.com> Date: Fri Sep 7 19:16:58 2012 +0800 cimx sb700: change Platform.h to remove some warnings TRACE has redefined warnings in src/southbridge/amd/cimx/sb700/Platform.h, so we do some changes to remove such warnings. Change-Id: I24979e08b83434f91a8fa37cd9f16303fa0b298d Signed-off-by: Siyuan Wang <SiYuan.Wang(a)amd.com> Signed-off-by: Siyuan Wang <wangsiyuanbuaa(a)gmail.com> Build-Tested: build bot (Jenkins) at Mon Sep 10 13:43:01 2012, giving +1 Reviewed-By: Marc Jones <marcj303(a)gmail.com> at Tue Sep 11 19:45:37 2012, giving +2 See http://review.coreboot.org/1499 for details. -gerrit

1 0