coreboot September 2012

coreboot@coreboot.org

29 participants
134 discussions

Patch set updated for coreboot: 7fa9070 AMD Hudson: use awk to calulate instead of expr
by Zheng Bao 17 Sep '12

17 Sep '12

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1527 -gerrit commit 7fa90703dd54e85e0104a7e1112bbb9945c062ed Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Mon Sep 17 15:39:44 2012 +0800 AMD Hudson: use awk to calulate instead of expr Command expr in some systems only take 32bit as integer, which value is at 0x7FFFFFFF ~ -0x80000000. Use awk as alternate way to calculate. And some system doesnt take hex value in Makefile, even in awk instruction. Change-Id: Ie35d6a5b96eea4192bd9cab857af4d4dcb37b9ed Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- src/southbridge/amd/agesa/hudson/Makefile.inc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc index 971f731..014524d 100644 --- a/src/southbridge/amd/agesa/hudson/Makefile.inc +++ b/src/southbridge/amd/agesa/hudson/Makefile.inc @@ -24,7 +24,7 @@ HUDSON_FWM_POSITION=$(shell printf %d $(CONFIG_HUDSON_FWM_POSITION)) #assume the cbfs header is less than 128 bytes. ROMSIG_SIZE=16 ifeq ($(CONFIG_HUDSON_XHCI_FWM), y) -HUDSON_XHCI_POSITION=$(shell expr $(HUDSON_FWM_POSITION) + $(ROMSIG_SIZE) + 128) +HUDSON_XHCI_POSITION=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 | awk '{print $$1 + $$2 + $$3}') XHCI_FWM_SIZE=$(word 5,$(shell ls -l $(CONFIG_HUDSON_XHCI_FWM_FILE))) else HUDSON_XHCI_POSITION=0 @@ -32,8 +32,8 @@ XHCI_FWM_SIZE=0 endif ifeq ($(CONFIG_HUDSON_GEC_FWM), y) -HUDSON_GEC_POSITION=$(shell expr $(HUDSON_FWM_POSITION) + $(ROMSIG_SIZE) + 128 \ - + $(XHCI_FWM_SIZE) + 128) +HUDSON_GEC_POSITION=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 \ + $(XHCI_FWM_SIZE) 128 | awk '{print $$1 + $$2 + $$3 + $$4 + $$5}') GEC_FWM_SIZE=$(word 5,$(shell ls -l $(CONFIG_HUDSON_GEC_FWM_FILE))) else HUDSON_GEC_POSITION=0 @@ -41,10 +41,10 @@ GEC_FWM_SIZE=0 endif ifeq ($(CONFIG_HUDSON_IMC_FWM), y) -HUDSON_IMC_POSITION_UNALIGN=$(shell expr $(HUDSON_FWM_POSITION) + $(ROMSIG_SIZE) + 128 \ - + $(XHCI_FWM_SIZE) + 128 \ - + $(GEC_FWM_SIZE) + 128 + 65535) -HUDSON_IMC_POSITION=$(shell expr $(HUDSON_IMC_POSITION_UNALIGN) - $(HUDSON_IMC_POSITION_UNALIGN) % 65536) +HUDSON_IMC_POSITION_UNALIGN=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 \ + $(XHCI_FWM_SIZE) 128 \ + $(GEC_FWM_SIZE) 128 65535 | awk '{print $$1 + $$2 + $$3 + $$4 + $$5 + $$6 + $$7 + $$8}') +HUDSON_IMC_POSITION=$(shell echo $(HUDSON_IMC_POSITION_UNALIGN) | awk '{print $$1 - $$1 % 65536}') else HUDSON_IMC_POSITION=0 endif @@ -58,7 +58,7 @@ $(obj)/hudson_romsig.bin: $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \ $(HUDSON_IMC_POSITION) \ $(HUDSON_GEC_POSITION) \ $(HUDSON_XHCI_POSITION) ; do \ - echo $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 0x100, $$1/0x100 % 0x100, $$1/0x10000 % 0x100, $$1/0x1000000);}'; \ + echo $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 256, $$1/256 % 256, $$1/65536 % 256, $$1/16777216);}'; \ done > $@ ifeq ($(CONFIG_HUDSON_FWM), y)

1 0

New patch to review for coreboot: fdd2a7a AMD Hudson: use awk to calulate instead of expr
by Zheng Bao 17 Sep '12

17 Sep '12

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1527 -gerrit commit fdd2a7a3b7b1811b717d07292693884916395d30 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Mon Sep 17 14:47:30 2012 +0800 AMD Hudson: use awk to calulate instead of expr Command expr in some systems only take 32bit as integer, which value is at 0x7FFFFFFF ~ -0x80000000. Use awk as alternate way to calculate. And some system doesnt take hex value in Makefile, even in awk instruction. Change-Id: Ie35d6a5b96eea4192bd9cab857af4d4dcb37b9ed Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- src/southbridge/amd/agesa/hudson/Makefile.inc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc index 971f731..9fbc2c6 100644 --- a/src/southbridge/amd/agesa/hudson/Makefile.inc +++ b/src/southbridge/amd/agesa/hudson/Makefile.inc @@ -24,7 +24,7 @@ HUDSON_FWM_POSITION=$(shell printf %d $(CONFIG_HUDSON_FWM_POSITION)) #assume the cbfs header is less than 128 bytes. ROMSIG_SIZE=16 ifeq ($(CONFIG_HUDSON_XHCI_FWM), y) -HUDSON_XHCI_POSITION=$(shell expr $(HUDSON_FWM_POSITION) + $(ROMSIG_SIZE) + 128) +HUDSON_XHCI_POSITION=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 | awk '{print $$1 + $$2 + $$3}') XHCI_FWM_SIZE=$(word 5,$(shell ls -l $(CONFIG_HUDSON_XHCI_FWM_FILE))) else HUDSON_XHCI_POSITION=0 @@ -32,8 +32,8 @@ XHCI_FWM_SIZE=0 endif ifeq ($(CONFIG_HUDSON_GEC_FWM), y) -HUDSON_GEC_POSITION=$(shell expr $(HUDSON_FWM_POSITION) + $(ROMSIG_SIZE) + 128 \ - + $(XHCI_FWM_SIZE) + 128) +HUDSON_GEC_POSITION=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 \ + $(XHCI_FWM_SIZE) 128 | awk '{print $$1 + $$2 + $$3 + $$4 + $$5}') GEC_FWM_SIZE=$(word 5,$(shell ls -l $(CONFIG_HUDSON_GEC_FWM_FILE))) else HUDSON_GEC_POSITION=0 @@ -41,10 +41,10 @@ GEC_FWM_SIZE=0 endif ifeq ($(CONFIG_HUDSON_IMC_FWM), y) -HUDSON_IMC_POSITION_UNALIGN=$(shell expr $(HUDSON_FWM_POSITION) + $(ROMSIG_SIZE) + 128 \ - + $(XHCI_FWM_SIZE) + 128 \ - + $(GEC_FWM_SIZE) + 128 + 65535) -HUDSON_IMC_POSITION=$(shell expr $(HUDSON_IMC_POSITION_UNALIGN) - $(HUDSON_IMC_POSITION_UNALIGN) % 65536) +HUDSON_IMC_POSITION_UNALIGN=$(shell echo $(HUDSON_FWM_POSITION) $(ROMSIG_SIZE) 128 \ + $(XHCI_FWM_SIZE) 128 \ + $(GEC_FWM_SIZE) 128 65535 | awk '{print $$1 + $$2 + $$3 + $$4 + $$5 + $$6 + $$7 + $$8}') +HUDSON_IMC_POSITION=$(shell echo $(HUDSON_IMC_POSITION_UNALIGN) | awk '{print $$1 - $$1 % 65536}') else HUDSON_IMC_POSITION=0 endif @@ -58,7 +58,7 @@ $(obj)/hudson_romsig.bin: $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \ $(HUDSON_IMC_POSITION) \ $(HUDSON_GEC_POSITION) \ $(HUDSON_XHCI_POSITION) ; do \ - echo $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 0x100, $$1/0x100 % 0x100, $$1/0x10000 % 0x100, $$1/0x1000000);}'; \ + echo $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 256, $$1/256 % 256, $$1/65536 % 256, $$1/1677216);}'; \ done > $@ ifeq ($(CONFIG_HUDSON_FWM), y)

1 0

New patch to review for coreboot: 5799bcf lint: Dont highlight the matching text in grep
by Zheng Bao 17 Sep '12

17 Sep '12

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1526 -gerrit commit 5799bcf3571f806df780163a1c37d6b9c261a918 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Mon Sep 17 13:15:49 2012 +0800 lint: Dont highlight the matching text in grep Sometimes we like to make grep auto-highlight the match text by setting the alias or the GREP_COLORS. This will make the compare_output in lint-002 catch the difference between 2 strings which text are same but color are different. Override the color option. Change-Id: Ia257214fe5149e084e8eac3fb551a494eaa46ae6 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/lint/lint-stable-002-build-dir-handling | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling index d5295d2..688c16c 100755 --- a/util/lint/lint-stable-002-build-dir-handling +++ b/util/lint/lint-stable-002-build-dir-handling @@ -37,7 +37,7 @@ $MAKE CONFIG_USE_BLOBS=n CONFIG_CCACHE=n CONFIG_SCANBUILD_ENABLE=n NOMKDIR=1 \ DOTCONFIG=$TMPCONFIG obj=$1 printall | \ sed -e "s,^ *,," -e "s,^r.mstage-objs:=,," \ -e "s,mainboard/[^/]*/[^/]*/,.../,g" | \ - tr " " "\n" | grep "/static.*\.[co]" | sort | \ + tr " " "\n" | grep --color=never "/static.*\.[co]" | sort | \ tr '\012\015' ' ' | sed -e "s, *, ,g" -e "s, *$,," }

1 0

Support for a desired Motherboard
by Goto＠habmalnefrage.de 16 Sep '12

16 Sep '12

Hallo, I am interested in buying a new motherboard: "ASUS Sabertooth 990FX" or "Gigabyte GA-990FXA-UD7" and wanted to use coreboot on it. In the released supported boards-List is none of them mentioned. Are there any further plans for one of the boards? Peter

2 1

Re: [coreboot] New laptop: Lenovo ThinkPad X230 tablet, with dumps to go with it
by Peter Stuge 16 Sep '12

16 Sep '12

Keith Hui wrote: > At this point I'm mostly interested in just identifying the flash chip > without disassembling the laptop, although I'm ready for that if > necessary. Try: flashrom -p internal:force=laptop_I_want_a_brick flashrom is overly defensive on Thinkpads, where the Renesas EC always has it's own flash. > However, I do need to find a USB-based chip programmer that can do > parallel, FWH and SPI. No such thing in cheap. You can get a GALEP-5, which supports an incredible range of devices, but which also costs >= 600 USD. I want to make an open hardware+firmware design, but so far I haven't made it beyond the USB protocol. http://git.stuge.se/?p=qiprog.git //Peter

2 1

Re: [coreboot] New laptop: Lenovo ThinkPad X230 tablet, with dumps to go with it
by Keith Hui 16 Sep '12

16 Sep '12

Thanks Idwer for your response. I downloaded most public datasheets available for the CPU and the PCH (it was called 7 Series). At this point I'm mostly interested in just identifying the flash chip without disassembling the laptop, although I'm ready for that if necessary. However, I do need to find a USB-based chip programmer that can do parallel, FWH and SPI. I still have to get a spare SPI flash chip and port coreboot to my Asus AMD board. For some reason I killed by home-built Willem PCB3B trying to convert it to PCB4-something to use newer version of its software. On Sat, Sep 15, 2012 at 7:10 AM, Idwer Vollering <vidwer(a)gmail.com> wrote: > CC: flashrom(a)flashrom.org > > 2012/9/15 Keith Hui <buurin(a)gmail.com>: >> Hi all, >> >> I'm back. With a new laptop. >> >> I'm now rocking a Lenovo x230 tablet, dual-booting Windows 7 and >> Fuduntu, both 64-bit. Knowing the last time I contributed to coreboot >> it was the good old 440BX when life was much simpler, it could be a >> while before I can get up to speed again, so I'll for now just put >> forth the obligatory lspci/superiotool dump to give any interested >> parties a heads-up of what support needs to be programmed for. >> >> Another interesting thing is it does UEFI. >> >> Below is output of flashrom 0.9.6.1. I cannot get it to identify the >> flash chip. lspci and superiotool dumps are attached. > > This thread mentions that it runs QM77: > http://forums.lenovo.com/t5/X-Series-Tablet-ThinkPad-Laptops/X230-Tablet-Ch… > >> >> # /usr/src/flashrom-0.9.6.1/flashrom -V -p internal >> flashrom v0.9.6.1-r1564 on Linux 3.4.9-1.fu2012.x86_64 (x86_64) >> flashrom is free software, get the source code at http://www.flashrom.org >> >> flashrom was built with libpci 3.1.7, GCC 4.6.3 20120306 (Red Hat >> 4.6.3-2), little endian >> Command line (3 args): /usr/src/flashrom-0.9.6.1/flashrom -V -p internal >> Calibrating delay loop... OS timer resolution is 1 usecs, 3243M loops >> per second, 10 myus = 10 us, 100 myus = 119 us, 1000 myus = 1026 us, >> 10000 myus = 10097 us, 4 myus = 4 us, OK. >> Initializing internal programmer >> No coreboot table found. >> DMI string system-manufacturer: "LENOVO" >> DMI string system-product-name: "3434CTO" >> DMI string system-version: "ThinkPad X230 Tablet" >> DMI string baseboard-manufacturer: "LENOVO" >> DMI string baseboard-product-name: "3434CTO" >> DMI string baseboard-version: "Not Available" >> DMI string chassis-type: "Notebook" >> Laptop detected via DMI. >> W836xx enter config mode worked or we were already in config mode. >> W836xx leave config mode had no effect. >> Active config mode, unknown reg 0x20 ID: 00. >> Please send the output of "flashrom -V" to >> flashrom(a)flashrom.org with W836xx: your board name: flashrom -V >> as the subject to help us finish support for your Super I/O. Thanks. >> ======================================================================== >> WARNING! You seem to be running flashrom on an unsupported laptop. >> Laptops, notebooks and netbooks are difficult to support and we >> recommend to use the vendor flashing utility. The embedded controller >> (EC) in these machines often interacts badly with flashing. >> See http://www.flashrom.org/Laptops for details. > > Also, see the "Laptops" section in flashrom's man page. > >> >> If flash is shared with the EC, erase is guaranteed to brick your laptop >> and write may brick your laptop. >> Read and probe may irritate your EC and cause fan failure, backlight >> failure and sudden poweroff. >> You have been warned. >> ======================================================================== >> Aborting. >> Error: Programmer initialization failed. > > You'll want to do a little investigation on which external programmer > [1] suits your needs. > > [1] http://flashrom.org/Supported_programmers

1 0

Re: [coreboot] New laptop: Lenovo ThinkPad X230 tablet, with dumps to go with it
by Idwer Vollering 15 Sep '12

15 Sep '12

CC: flashrom(a)flashrom.org 2012/9/15 Keith Hui <buurin(a)gmail.com>: > Hi all, > > I'm back. With a new laptop. > > I'm now rocking a Lenovo x230 tablet, dual-booting Windows 7 and > Fuduntu, both 64-bit. Knowing the last time I contributed to coreboot > it was the good old 440BX when life was much simpler, it could be a > while before I can get up to speed again, so I'll for now just put > forth the obligatory lspci/superiotool dump to give any interested > parties a heads-up of what support needs to be programmed for. > > Another interesting thing is it does UEFI. > > Below is output of flashrom 0.9.6.1. I cannot get it to identify the > flash chip. lspci and superiotool dumps are attached. This thread mentions that it runs QM77: http://forums.lenovo.com/t5/X-Series-Tablet-ThinkPad-Laptops/X230-Tablet-Ch… > > # /usr/src/flashrom-0.9.6.1/flashrom -V -p internal > flashrom v0.9.6.1-r1564 on Linux 3.4.9-1.fu2012.x86_64 (x86_64) > flashrom is free software, get the source code at http://www.flashrom.org > > flashrom was built with libpci 3.1.7, GCC 4.6.3 20120306 (Red Hat > 4.6.3-2), little endian > Command line (3 args): /usr/src/flashrom-0.9.6.1/flashrom -V -p internal > Calibrating delay loop... OS timer resolution is 1 usecs, 3243M loops > per second, 10 myus = 10 us, 100 myus = 119 us, 1000 myus = 1026 us, > 10000 myus = 10097 us, 4 myus = 4 us, OK. > Initializing internal programmer > No coreboot table found. > DMI string system-manufacturer: "LENOVO" > DMI string system-product-name: "3434CTO" > DMI string system-version: "ThinkPad X230 Tablet" > DMI string baseboard-manufacturer: "LENOVO" > DMI string baseboard-product-name: "3434CTO" > DMI string baseboard-version: "Not Available" > DMI string chassis-type: "Notebook" > Laptop detected via DMI. > W836xx enter config mode worked or we were already in config mode. > W836xx leave config mode had no effect. > Active config mode, unknown reg 0x20 ID: 00. > Please send the output of "flashrom -V" to > flashrom(a)flashrom.org with W836xx: your board name: flashrom -V > as the subject to help us finish support for your Super I/O. Thanks. > ======================================================================== > WARNING! You seem to be running flashrom on an unsupported laptop. > Laptops, notebooks and netbooks are difficult to support and we > recommend to use the vendor flashing utility. The embedded controller > (EC) in these machines often interacts badly with flashing. > See http://www.flashrom.org/Laptops for details. Also, see the "Laptops" section in flashrom's man page. > > If flash is shared with the EC, erase is guaranteed to brick your laptop > and write may brick your laptop. > Read and probe may irritate your EC and cause fan failure, backlight > failure and sudden poweroff. > You have been warned. > ======================================================================== > Aborting. > Error: Programmer initialization failed. You'll want to do a little investigation on which external programmer [1] suits your needs. [1] http://flashrom.org/Supported_programmers

1 0

New laptop: Lenovo ThinkPad X230 tablet, with dumps to go with it
by Keith Hui 15 Sep '12

15 Sep '12

Hi all, I'm back. With a new laptop. I'm now rocking a Lenovo x230 tablet, dual-booting Windows 7 and Fuduntu, both 64-bit. Knowing the last time I contributed to coreboot it was the good old 440BX when life was much simpler, it could be a while before I can get up to speed again, so I'll for now just put forth the obligatory lspci/superiotool dump to give any interested parties a heads-up of what support needs to be programmed for. Another interesting thing is it does UEFI. Below is output of flashrom 0.9.6.1. I cannot get it to identify the flash chip. lspci and superiotool dumps are attached. # /usr/src/flashrom-0.9.6.1/flashrom -V -p internal flashrom v0.9.6.1-r1564 on Linux 3.4.9-1.fu2012.x86_64 (x86_64) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.1.7, GCC 4.6.3 20120306 (Red Hat 4.6.3-2), little endian Command line (3 args): /usr/src/flashrom-0.9.6.1/flashrom -V -p internal Calibrating delay loop... OS timer resolution is 1 usecs, 3243M loops per second, 10 myus = 10 us, 100 myus = 119 us, 1000 myus = 1026 us, 10000 myus = 10097 us, 4 myus = 4 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "LENOVO" DMI string system-product-name: "3434CTO" DMI string system-version: "ThinkPad X230 Tablet" DMI string baseboard-manufacturer: "LENOVO" DMI string baseboard-product-name: "3434CTO" DMI string baseboard-version: "Not Available" DMI string chassis-type: "Notebook" Laptop detected via DMI. W836xx enter config mode worked or we were already in config mode. W836xx leave config mode had no effect. Active config mode, unknown reg 0x20 ID: 00. Please send the output of "flashrom -V" to flashrom(a)flashrom.org with W836xx: your board name: flashrom -V as the subject to help us finish support for your Super I/O. Thanks. ======================================================================== WARNING! You seem to be running flashrom on an unsupported laptop. Laptops, notebooks and netbooks are difficult to support and we recommend to use the vendor flashing utility. The embedded controller (EC) in these machines often interacts badly with flashing. See http://www.flashrom.org/Laptops for details. If flash is shared with the EC, erase is guaranteed to brick your laptop and write may brick your laptop. Read and probe may irritate your EC and cause fan failure, backlight failure and sudden poweroff. You have been warned. ======================================================================== Aborting. Error: Programmer initialization failed.

1 0

New patch to review for coreboot: 71110d7 Add i2c eeprom to device tree
by Christian Gmeiner 14 Sep '12

14 Sep '12

Christian Gmeiner (christian.gmeiner(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1511 -gerrit commit 71110d764cdfc035c894561ea1f25d887923951a Author: Christian Gmeiner <christian.gmeiner(a)gmail.com> Date: Fri Sep 14 16:28:44 2012 +0200 Add i2c eeprom to device tree This eeprom is used to store some device relevant informations like hardware revision. Change-Id: I32bda9d5412bc5a96da0edb5ef0b6d1ba4caa2d8 Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> --- src/mainboard/bachmann/ot200/devicetree.cb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mainboard/bachmann/ot200/devicetree.cb b/src/mainboard/bachmann/ot200/devicetree.cb index 92c973d..4a065cb 100644 --- a/src/mainboard/bachmann/ot200/devicetree.cb +++ b/src/mainboard/bachmann/ot200/devicetree.cb @@ -19,7 +19,11 @@ chip northbridge/amd/lx register "com2_irq" = "3" register "unwanted_vpci[0]" = "0" # End of list has a zero device pci 4.0 on end # Ethernet 0 - device pci f.0 on end # ISA Bridge + device pci f.0 on # ISA Bridge + chip drivers/generic/generic # eeprom + device i2c 52 on end + end + end device pci f.2 on end # IDE Controller device pci f.3 on end # Audio device pci f.4 on end # OHCI

1 0

New patch to review for coreboot: b26658a Set SMBIOS mainboard version based on i2c eeprom
by Christian Gmeiner 14 Sep '12

14 Sep '12

Christian Gmeiner (christian.gmeiner(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1512 -gerrit commit b26658aa0e3116ff29ef6d801ea2da9065e953c3 Author: Christian Gmeiner <christian.gmeiner(a)gmail.com> Date: Fri Sep 14 16:29:10 2012 +0200 Set SMBIOS mainboard version based on i2c eeprom In the field there are different hardware revisions and some of them have problems with UDMA as a resistor is missing. We can detect this situation in coreboot and e.g. the linux kernel can take this knowledge and disable UDMA. Change-Id: Ib75cad7acedbc1dc65378bb9bfc3f353cbe21427 Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> --- src/mainboard/bachmann/ot200/mainboard.c | 52 ++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/src/mainboard/bachmann/ot200/mainboard.c b/src/mainboard/bachmann/ot200/mainboard.c index 76b3c53..74555b6 100644 --- a/src/mainboard/bachmann/ot200/mainboard.c +++ b/src/mainboard/bachmann/ot200/mainboard.c @@ -18,7 +18,59 @@ */ #include <device/device.h> +#include <device/smbus.h> +#include <smbios.h> +#include <console/console.h> + +/* overwrite a weak function to fill SMBIOS table with a custom value */ +static u8 hw_rev = 0; +static char mb_rev_str[2] = { '0' }; + +const char *smbios_mainboard_version(void) +{ + /* UDMA is not working on all supported devices */ + if (hw_rev < 113) { + mb_rev_str[0] = '1'; + } else { + mb_rev_str[0] = '2'; + } + + return mb_rev_str; +} + +static void init(struct device *dev) +{ + unsigned int i; + u32 chksum = 0; + char block[20]; + device_t eeprom_dev = dev_find_slot_on_smbus(1, 0x52); + + if (eeprom_dev == 0) { + printk(BIOS_WARNING, "eeprom not found\n"); + return; + } + + /* read the whole block and check if checksum is okay */ + for (i = 0; i < 20; i++) { + block[i] = smbus_read_byte(eeprom_dev, i); + chksum += block[i]; + } + + if (chksum != 0) { + printk(BIOS_WARNING, "wrong checksum: 0x%0x\n", chksum); + } + + hw_rev = block[5]; + + printk(BIOS_DEBUG, "hw revision: %u\n", hw_rev); +} + +static void enable_dev(struct device *dev) +{ + dev->ops->init = init; +} struct chip_operations mainboard_ops = { CHIP_NAME(CONFIG_MAINBOARD_VENDOR " " CONFIG_MAINBOARD_PART_NUMBER) + .enable_dev = enable_dev, };

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2012