September 2012 - coreboot - mail.coreboot.org

Patch merged into coreboot/master: 454ab9e nvramtool: uname in NetBSD doesnt take "-o"
by gerrit＠coreboot.org Sept. 28, 2012

Sept. 28, 2012

the following patch was just integrated into master: commit 454ab9e057e49d4031bbe478b3cdcc1847edfda0 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 16:02:35 2012 +0800 nvramtool: uname in NetBSD doesnt take "-o" see the Netbsd manual: http://netbsd.gw.com/cgi-bin/man-cgi?uname++NetBSD-current Error output needs to be redirected. Change-Id: I1853a0162e14be0ee9d7971466499af6c72b2427 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Fri Sep 28 14:50:01 2012, giving +2 See http://review.coreboot.org/1545 for details. -gerrit

1 0

Patch merged into coreboot/master: 855bb95 libpayload: fix fetching integers from CMOS as string
by gerrit＠coreboot.org Sept. 28, 2012

Sept. 28, 2012

the following patch was just integrated into master: commit 855bb95ca1ca00957de044f9f4362c6cd054cf9a Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Wed Sep 26 15:11:48 2012 +0200 libpayload: fix fetching integers from CMOS as string %ull -> %llu Change-Id: I330f681d713be7eb444870f81330cf6e9869a4fa Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> See http://review.coreboot.org/1542 for details. -gerrit

1 0

Patch merged into coreboot/master: 078f22e nvramtool: Require no hw access for integrated Makefile
by gerrit＠coreboot.org Sept. 28, 2012

Sept. 28, 2012

the following patch was just integrated into master: commit 078f22ea8bd365c3152a32e72052cccfa60c155b Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 15:58:05 2012 +0800 nvramtool: Require no hw access for integrated Makefile The Makefile.inc is integraged into coreboot Makefile. It doesn't need to access to HW like cmos. It doesn't include cmos-hw-unix.c, which is only for individual tools running seperatedly. Change-Id: Ib00b5c3da63acb4120cb23eb7d661c5bc75d7c86 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Fri Sep 28 14:49:21 2012, giving +2 See http://review.coreboot.org/1544 for details. -gerrit

1 0

Patch merged into coreboot/master: 46ff37f AMD Hudson: Printf the high address as unsigned integer
by gerrit＠coreboot.org Sept. 28, 2012

Sept. 28, 2012

the following patch was just integrated into master: commit 46ff37f6f24541e36956a63681cada0869d4fa08 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 16:10:01 2012 +0800 AMD Hudson: Printf the high address as unsigned integer Some 32 bit machines print integer higher than 0x80000000 as negative number. Change-Id: Ieb512ed2a7499ce7e91e45e4075d4f119780b57d Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Fri Sep 28 14:48:57 2012, giving +2 See http://review.coreboot.org/1547 for details. -gerrit

1 0

Patch merged into coreboot/master: 75d10ab lint: Add template for mktemp to meet BSD requirements
by gerrit＠coreboot.org Sept. 28, 2012

Sept. 28, 2012

the following patch was just integrated into master: commit 75d10ab599bd8e01932b6a40bf11b9e7dfbf469d Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 19:38:37 2012 +0800 lint: Add template for mktemp to meet BSD requirements Change-Id: I86cecf6aee1fcb682cb32bd0f03e014fd1afe594 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Fri Sep 28 14:46:37 2012, giving +2 See http://review.coreboot.org/1549 for details. -gerrit

1 0

Patch merged into coreboot/master: b5b93c5 libpayload: Don't leave temporary files behind
by gerrit＠coreboot.org Sept. 28, 2012

Sept. 28, 2012

the following patch was just integrated into master: commit b5b93c582db9fca1e893d5d582a3366ac8cf5ff4 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Wed Sep 26 15:26:05 2012 +0200 libpayload: Don't leave temporary files behind For some reason the rm -f didn't quite work on my system, but sending gcc output to /dev/null does. Change-Id: I7ece9aa9abe564bbc646ae53df1d3cd0c5aa84a2 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Build-Tested: build bot (Jenkins) at Thu Sep 27 13:18:56 2012, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Fri Sep 28 03:54:50 2012, giving +2 Reviewed-By: Anton Kochkov <anton.kochkov(a)gmail.com> at Fri Sep 28 13:43:31 2012, giving +2 See http://review.coreboot.org/1543 for details. -gerrit

1 0

New patch to review for coreboot: cedbdcd lint: Get absolute path in compare_output
by Zheng Bao Sept. 28, 2012

Sept. 28, 2012

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1551 -gerrit commit cedbdcdae7f045dc2b69da8b224298f70254db35 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 20:14:38 2012 +0800 lint: Get absolute path in compare_output The classes in $(top)/Makefile uses $(abspath) to get the path. The $(abspath) can not resolve symlink. If the coreboot is located in a symlink directory, the run_printall produces the absolute path while the $PWD just produces the path with symlink. Use `pwd -P` to get the abs path. Change-Id: Icf6b364d030c14a9c78991767b17dafc701baf3c Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/lint/lint-stable-002-build-dir-handling | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling index 9350907..ca61a35 100755 --- a/util/lint/lint-stable-002-build-dir-handling +++ b/util/lint/lint-stable-002-build-dir-handling @@ -58,7 +58,8 @@ rm -f $TMPCONFIG $MAKE DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null # look up parent directory -PARENTDIR=`dirname $PWD` +CURRENTDIR=`pwd -P` +PARENTDIR=`dirname $CURRENTDIR` compare_output "`run_printall build`" "build/.../static.c build/.../static.c build/.../static.ramstage.o build/.../static.romstage.o" compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/obj/.../static.c $PARENTDIR/obj/.../static.ramstage.o $PARENTDIR/obj/.../static.romstage.o"

1 0

New patch to review for coreboot: 75d10ab lint: Add template for mktemp to meet BSD requirements
by Zheng Bao Sept. 28, 2012

Sept. 28, 2012

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1549 -gerrit commit 75d10ab599bd8e01932b6a40bf11b9e7dfbf469d Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 19:38:37 2012 +0800 lint: Add template for mktemp to meet BSD requirements Change-Id: I86cecf6aee1fcb682cb32bd0f03e014fd1afe594 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- Makefile.inc | 2 +- util/lint/lint-001-no-global-config-in-romstage | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 24b3c34..63c0403 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -272,7 +272,7 @@ update: dongle.py -c /dev/term/1 $(obj)/coreboot.rom EOF lint lint-stable: - FAILED=0; LINTLOG=`mktemp`; \ + FAILED=0; LINTLOG=`mktemp .tmpconfig.lintXXXXX`; \ for script in util/lint/$@-*; do \ echo; echo `basename $$script`; \ grep "^# DESCR:" $$script | sed "s,.*DESCR: *,," ; \ diff --git a/util/lint/lint-001-no-global-config-in-romstage b/util/lint/lint-001-no-global-config-in-romstage index 0c6f403..4b1d317 100755 --- a/util/lint/lint-001-no-global-config-in-romstage +++ b/util/lint/lint-001-no-global-config-in-romstage @@ -19,7 +19,7 @@ # DESCR: Check that no symbol #defined in any romstage.c is used elsewhere DEFINES=`grep "#define" src/mainboard/*/*/romstage.c |sed 's,.*#define[\t ]$[^\t ]*$[\t ].*,\1,' | grep -v "(" | sort -u` -SCANBUCKET=`mktemp` +SCANBUCKET=`mktemp .tmpconfig.lint001XXXXX` LC_ALL=C export LC_ALL find src -name .svn -type d -prune -o -name mainboard -type d -prune -o -name examples -type d -prune -o -type f -exec sed -nf `dirname $0`/remccoms3.sed {} + > $SCANBUCKET

1 0

New patch to review for coreboot: f2bb3c7 lint: Stop searching when one GNUmake is found
by Zheng Bao Sept. 28, 2012

Sept. 28, 2012

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1550 -gerrit commit f2bb3c7142612b41919f999974d1352309bcf8e5 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 20:13:19 2012 +0800 lint: Stop searching when one GNUmake is found After make 3.81 is copied to /usr/local/bin, the old make 3.80, which doesn't work for coreboot, will replace $MAKE with gnumake. That is not we want. Change-Id: I87fbe95c70228a22f2c233ff071df29639b63726 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/lint/lint-stable-002-build-dir-handling | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling index 6ab1bb9..9350907 100755 --- a/util/lint/lint-stable-002-build-dir-handling +++ b/util/lint/lint-stable-002-build-dir-handling @@ -42,9 +42,10 @@ $MAKE CONFIG_USE_BLOBS=n CONFIG_CCACHE=n CONFIG_SCANBUILD_ENABLE=n NOMKDIR=1 \ } # find GNU make +MAKE= search_make make -search_make gmake -search_make gnumake +[ -z $MAKE ] && search_make gmake +[ -z $MAKE ] && search_make gnumake if [ "$MAKE" = "" ]; then echo Could not identify GNU make

1 0

New patch to review for coreboot: 46ff37f AMD Hudson: Printf the high address as unsigned integer
by Zheng Bao Sept. 28, 2012

Sept. 28, 2012

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1547 -gerrit commit 46ff37f6f24541e36956a63681cada0869d4fa08 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Fri Sep 28 16:10:01 2012 +0800 AMD Hudson: Printf the high address as unsigned integer Some 32 bit machines print integer higher than 0x80000000 as negative number. Change-Id: Ieb512ed2a7499ce7e91e45e4075d4f119780b57d Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- src/southbridge/amd/agesa/hudson/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc index 6a47080..4bd1523 100644 --- a/src/southbridge/amd/agesa/hudson/Makefile.inc +++ b/src/southbridge/amd/agesa/hudson/Makefile.inc @@ -19,7 +19,7 @@ ramstage-$(CONFIG_HAVE_ACPI_RESUME) += spi.c # |0x55AA55AA |EC ROM Address |GEC ROM Address |USB3 ROM | # +-----------+---------------+----------------+------------+ # EC ROM should be 64K aligned. -HUDSON_FWM_POSITION=$(shell printf %d $(CONFIG_HUDSON_FWM_POSITION)) +HUDSON_FWM_POSITION=$(shell printf %u $(CONFIG_HUDSON_FWM_POSITION)) #assume the cbfs header is less than 128 bytes. ROMSIG_SIZE=16

1 0