coreboot August 2012

coreboot@coreboot.org

30 participants
321 discussions

Patch merged into coreboot/master: 13a2dfa AMD hudson: Call the rtc update if needed.
by gerrit＠coreboot.org 02 Aug '12

02 Aug '12

the following patch was just integrated into master: commit 13a2dfaa787e56cc159dbbf98c55cafa575177eb Author: zbao <fishbaozi(a)gmail.com> Date: Thu Aug 2 19:03:44 2012 +0800 AMD hudson: Call the rtc update if needed. Parmer and thather hang at windows 7 booting process. Setting the valid date in CMOS can fix that. Change-Id: I5e427cfb42430ebebdb4c1e48bd25860c0fec45f Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: zbao <fishbaozi(a)gmail.com> Build-Tested: build bot (Jenkins) at Thu Aug 2 12:43:38 2012, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Thu Aug 2 18:03:35 2012, giving +2 See http://review.coreboot.org/1390 for details. -gerrit

1 0

Patch merged into coreboot/master: d102e6b AMD Thatcher Board based on trinity
by gerrit＠coreboot.org 02 Aug '12

02 Aug '12

the following patch was just integrated into master: commit d102e6b120fb2e4910da565ab293add8d332ab25 Author: zbao <fishbaozi(a)gmail.com> Date: Thu Aug 2 18:36:36 2012 +0800 AMD Thatcher Board based on trinity Thatcher features: Family 15 trinity FP2. Hudson. close to Parmer. This board and parmer both need to revert the change http://review.coreboot.org/#/c/1359/, and add thatcher's own chip.h,otherwise the mainboard_enable can not be called. Change-Id: I54e1cfca845fbcea1d3aad5eff08d760d0d215c9 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: zbao <fishbaozi(a)gmail.com> Build-Tested: build bot (Jenkins) at Thu Aug 2 11:17:12 2012, giving +1 See http://review.coreboot.org/1382 for details. -gerrit

1 0

Patch merged into coreboot/master: a408915 x86emu: fix jump_near_IMM to handle DATA: flag correctly
by gerrit＠coreboot.org 02 Aug '12

02 Aug '12

the following patch was just integrated into master: commit a408915a1c9d323a0735778ab72a0842b82c9df5 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Thu Jul 26 15:48:17 2012 -0700 x86emu: fix jump_near_IMM to handle DATA: flag correctly Before (data flag ignored -> broken): 66 DATA: e944f1 JMP 1ff6 After (fixed): 66 DATA: e944f1ffff JMP 00001ff8 This subtle difference in the length of decoded instruction meant that the VBE call jumped to the routine setting AX=0x14F (VBE Failed) instead of the routine that set AX=0x4F (VBE success). The ability to run the same code in vm86 significantly aided the debugging of this issue. Those X.org developers who would like to drop vm86 better take special care towards _all_ vesa bugs, as those will expose further issues. Imported from: http://cgit.freedesktop.org/xorg/xserver/commit/hw/xfree86/x86emu?id=cc2c73… Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Change-Id: Id08ead9b17468cf19ede45508e5dcc50e45b5acf Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Tested-by: Luc Verhaegen <libv(a)skynet.be> Reviewed-by: Adam Jackson <ajax(a)redhat.com> Signed-off-by: Keith Packard <keithp(a)keithp.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Thu Aug 2 14:43:12 2012, giving +2 See http://review.coreboot.org/1365 for details. -gerrit

1 0

Patch merged into coreboot/master: 0af8543 x86emu: Fix more mis-decoding of the data prefix
by gerrit＠coreboot.org 02 Aug '12

02 Aug '12

the following patch was just integrated into master: commit 0af854397bdeb4412803ac46a2edefcfec1e17a5 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Thu Jul 26 16:25:53 2012 -0700 x86emu: Fix more mis-decoding of the data prefix cc2c73ddcb4370a7c3ad439cda4da825156c26c9's three-cent titanium tax doesn't go too far enough. Fix the rest of the call and jmp instructions to handle the data prefix correctly. Reference: Intel 64 and IA-32 Architectures Software Developer's Manual Volume 2A: Instruction Set Reference, A-M http://www.intel.com/Assets/PDF/manual/253666.pdf Imported from: http://cgit.freedesktop.org/xorg/xserver/commit/hw/xfree86/x86emu?id=bb18f2… Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Change-Id: I83e6245d9748ee86722cfb7d8ac65258c35c013c Reviewed-by: Julien Cristau <jcristau(a)debian.org> Signed-off-by: Adam Jackson <ajax(a)redhat.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Thu Aug 2 14:42:40 2012, giving +2 See http://review.coreboot.org/1366 for details. -gerrit

1 0

New patch to review for coreboot: c7a0c39 Technexion TIM5690: drop add_mainboard_resources()
by Kyösti Mälkki 02 Aug '12

02 Aug '12

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1396 -gerrit commit c7a0c3964bbef9eedf6ff9cd3004c2b5ddce437b Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Aug 2 09:44:14 2012 +0300 Technexion TIM5690: drop add_mainboard_resources() Move the POST display to take place just before entering the payload, a bit later than before. Change-Id: Ie1d1ff24dc6c1640e25681be7dc5740943c7f112 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/mainboard/technexion/tim5690/Kconfig | 1 - src/mainboard/technexion/tim5690/mainboard.c | 3 +-- 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/mainboard/technexion/tim5690/Kconfig b/src/mainboard/technexion/tim5690/Kconfig index 404ddfe..172b478 100644 --- a/src/mainboard/technexion/tim5690/Kconfig +++ b/src/mainboard/technexion/tim5690/Kconfig @@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select SB_HT_CHAIN_UNITID_OFFSET_ONLY select HAVE_ACPI_TABLES select GFXUMA - select HAVE_MAINBOARD_RESOURCES select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO select QRANK_DIMM_SUPPORT diff --git a/src/mainboard/technexion/tim5690/mainboard.c b/src/mainboard/technexion/tim5690/mainboard.c index 2975e86..48de84e 100644 --- a/src/mainboard/technexion/tim5690/mainboard.c +++ b/src/mainboard/technexion/tim5690/mainboard.c @@ -244,10 +244,9 @@ static void tim5690_enable(device_t dev) set_thermal_config(); } -int add_mainboard_resources(struct lb_memory *mem) +void mainboard_coreboot_completed(void) { technexion_post_code(LED_MESSAGE_FINISH); - return 0; } struct chip_operations mainboard_ops = {

1 0

New patch to review for coreboot: af46000 Add a notifier just before entering payload
by Kyösti Mälkki 02 Aug '12

02 Aug '12

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1395 -gerrit commit af46000277c86642890af68262110a5e153f9be8 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Aug 2 09:46:54 2012 +0300 Add a notifier just before entering payload Mainboard code may want to update POST display / LEDs / play fanfare once it has succesfully loaded the payload. Change-Id: I6abd3ce883f07d09a0c7ddec745f388e95b8a7e9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/boot/hardwaremain.c | 3 +++ src/include/device/device.h | 1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/boot/hardwaremain.c b/src/boot/hardwaremain.c index bb7f264..57a01f0 100644 --- a/src/boot/hardwaremain.c +++ b/src/boot/hardwaremain.c @@ -150,6 +150,9 @@ void hardwaremain(int boot_complete) if (! payload) die("Could not find a payload\n"); + if (mainboard_coreboot_completed) + mainboard_coreboot_completed(); + printk(BIOS_DEBUG, "Got a payload\n"); /* Before we go off to run the payload, see if * we stayed within our bounds. diff --git a/src/include/device/device.h b/src/include/device/device.h index eaf84c6..ceae6aa 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -123,6 +123,7 @@ void dev_configure(void); void dev_enable(void); void dev_initialize(void); void dev_optimize(void); +void __attribute__((weak)) mainboard_coreboot_completed(void); /* Generic device helper functions */ int reset_bus(struct bus *bus);

1 0

New patch to review for coreboot: 33c63a5 Siemens SiteMP: drop add_mainboard_resources()
by Kyösti Mälkki 02 Aug '12

02 Aug '12

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1394 -gerrit commit 33c63a50343c97963cd0111818619b1f00e43298 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Aug 2 09:44:03 2012 +0300 Siemens SiteMP: drop add_mainboard_resources() Use of lb_add_memory_region() is reduntant with the MMCONF resource being set as reserved. Change-Id: I747ea34823692b6966b2e50d22aea1fb89c73c25 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/mainboard/siemens/sitemp_g1p1/Kconfig | 1 - src/mainboard/siemens/sitemp_g1p1/mainboard.c | 20 -------------------- 2 files changed, 0 insertions(+), 21 deletions(-) diff --git a/src/mainboard/siemens/sitemp_g1p1/Kconfig b/src/mainboard/siemens/sitemp_g1p1/Kconfig index b2cae03..dc761cf 100644 --- a/src/mainboard/siemens/sitemp_g1p1/Kconfig +++ b/src/mainboard/siemens/sitemp_g1p1/Kconfig @@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_MP_TABLE select HAVE_PIRQ_TABLE select HAVE_OPTION_TABLE - select HAVE_MAINBOARD_RESOURCES select HAVE_BUS_CONFIG select SB_HT_CHAIN_UNITID_OFFSET_ONLY select BOARD_ROMSIZE_KB_1024 diff --git a/src/mainboard/siemens/sitemp_g1p1/mainboard.c b/src/mainboard/siemens/sitemp_g1p1/mainboard.c index 905d23f..5053efa 100644 --- a/src/mainboard/siemens/sitemp_g1p1/mainboard.c +++ b/src/mainboard/siemens/sitemp_g1p1/mainboard.c @@ -856,26 +856,6 @@ static void enable_dev(device_t dev) dev->ops->init = init; // rest of mainboard init later } - /** - * @brief - * - * @param - */ - -int add_mainboard_resources(struct lb_memory *mem) -{ - device_t dev; - struct resource *res; - - dev = dev_find_slot(0, PCI_DEVFN(0,0)); - res = probe_resource(dev, 0x1C); - if( res ) { - printk(BIOS_INFO, "mmconf: base=%0llx size=%0llx\n", res->base, res->size); - lb_add_memory_range(mem, LB_MEM_RESERVED, res->base, res->size); - } - return 0; -} - struct chip_operations mainboard_ops = { CHIP_NAME(CONFIG_MAINBOARD_PART_NUMBER) .enable_dev = enable_dev,

1 0

New patch to review for coreboot: 5d8056e AMD RS690: mark MMCONF resource as reserved MEM
by Kyösti Mälkki 02 Aug '12

02 Aug '12

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1393 -gerrit commit 5d8056e1359675071eeb5e3c922423c63ead5d17 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Aug 2 09:46:38 2012 +0300 AMD RS690: mark MMCONF resource as reserved MEM Use IORESOURCE_RESERVE to exclude the region from system RAM table. Change-Id: I61b51022165e1304a41554f67af75b3089d892af Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/southbridge/amd/rs690/ht.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/southbridge/amd/rs690/ht.c b/src/southbridge/amd/rs690/ht.c index 9eb47bb..e3145f7 100644 --- a/src/southbridge/amd/rs690/ht.c +++ b/src/southbridge/amd/rs690/ht.c @@ -103,7 +103,8 @@ static void ht_dev_read_resources(device_t dev) res->align = log2(res->size); res->gran = log2(res->size); res->limit = 0xffffffffffffffffULL; /* 64bit */ - res->flags = IORESOURCE_FIXED | IORESOURCE_MEM | IORESOURCE_PCI64 | IORESOURCE_ASSIGNED; + res->flags = IORESOURCE_FIXED | IORESOURCE_MEM | IORESOURCE_PCI64 | + IORESOURCE_ASSIGNED | IORESOURCE_RESERVE; compact_resources(dev); #endif

1 0

New patch to review for coreboot: ea09f9b VIA Epia-N: drop add_mainboard_resources()
by Kyösti Mälkki 02 Aug '12

02 Aug '12

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1392 -gerrit commit ea09f9b62ad0fe5f0a40e1bf6c76fd411c6794fa Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Aug 2 09:43:48 2012 +0300 VIA Epia-N: drop add_mainboard_resources() The board had HAVE_MAINBOARD_RESOURCES=0 so this was never called. Drop unnecessary includes too. Change-Id: Ia7bddf29a16966c052b5cabbb47029299e6dbd12 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/mainboard/via/epia-n/mainboard.c | 19 ------------------- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/src/mainboard/via/epia-n/mainboard.c b/src/mainboard/via/epia-n/mainboard.c index 0dfbd3c..528e891 100644 --- a/src/mainboard/via/epia-n/mainboard.c +++ b/src/mainboard/via/epia-n/mainboard.c @@ -20,25 +20,6 @@ */ #include <device/device.h> -#include <device/pci.h> -#include <device/pci_ids.h> -#include <boot/tables.h> -#include <arch/ioapic.h> -#include <southbridge/via/vt8237r/vt8237r.h> -#include <cpu/x86/lapic_def.h> - -int add_mainboard_resources(struct lb_memory *mem) -{ -#if CONFIG_IOAPIC - lb_add_memory_range(mem, LB_MEM_RESERVED, - IO_APIC_ADDR, 0x1000); - lb_add_memory_range(mem, LB_MEM_RESERVED, - LOCAL_APIC_ADDR, 0x1000); - lb_add_memory_range(mem, LB_MEM_RESERVED, - 0xFFFF0000ULL, 0x10000); -#endif - return 0; -} struct chip_operations mainboard_ops = { CHIP_NAME("VIA EPIA-N Mainboard")

1 0

Patch merged into coreboot/master: 3dc036b Remove uma_memory_base from build if no GFXUMA
by gerrit＠coreboot.org 02 Aug '12

02 Aug '12

the following patch was just integrated into master: commit 3dc036bd59e0534a41d6c1f81d0c2f3a4b0ab6bf Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Wed Aug 1 08:05:22 2012 +0300 Remove uma_memory_base from build if no GFXUMA This patch validates the previous "drop uma_memory_base" patches; there are no more references to uma_memory_base when GFXUMA is not selected. Change-Id: I735b5e765b0c5cb4af1b4a7470cfe1af2bda7d38 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Build-Tested: build bot (Jenkins) at Wed Aug 1 08:51:18 2012, giving +1 Reviewed-By: Anton Kochkov <anton.kochkov(a)gmail.com> at Thu Aug 2 13:11:23 2012, giving +2 See http://review.coreboot.org/1385 for details. -gerrit

1 0

← Newer
1
...
26
27
28
29
30
31
32
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot August 2012