April 2012 - coreboot - mail.coreboot.org

Re: [coreboot] ASUS M2V problems
by ron minnich April 28, 2012

April 28, 2012

It's complicated and dependent on the chipset. There is no general answer to how or whether VGA will or won't work. You can thank the chipset makers for this situation :-) ron

1 0

Re: [coreboot] ASUS M2V problems
by G April 28, 2012

April 28, 2012

On Sat, Apr 28, 2012 at 1:21 PM, ali hagigat <hagigatali(a)gmail.com> wrote: > As far as I know Coreboot can not drive VGA and monitor by itself. > There is not enough code to do that and nothing is displayed on > monitor when you run Coreboot only. > > It only sets up some parameters regarding to VGA which will be used by > Linux kernel later. This seems strange to me. Besides, I've got the Coreinfo payload working when trying out Coreboot in Qemu, so obviously there's some VGA code somewhere that works at least when the Coreinfo stage has been reached, but I still get nothing when flashing Coreboot onto my bios chip. > When you use FILO as a payload, your key-presses may be detected like > ESC button though i did not test it myself but I found some keyboard > manipulating code.... > > > On Mon, Apr 23, 2012 at 5:16 PM, G <tjmadwja(a)gmail.com> wrote: >> On Mon, Apr 23, 2012 at 12:33 PM, ali hagigat <hagigatali(a)gmail.com> wrote: >>> You'd better buy a debug card and plug into the PCI slot and see what >>> numbers it will display. It has two seven segment components. >>> Besides you can disable coreboot post codes and insert your own post >>> codes to see how far the program runs. >>> I did the same for my motherboard... >> >> Thanks, but as I wrote on April 13th, I have managed to get some >> output over serial, but still nothing on VGA or any response to >> keyboard events. Details, and serial log and config file, can be >> found in my April 13th message.

1 0

Re: [coreboot] ASUS M2V problems
by ali hagigat April 28, 2012

April 28, 2012

As far as I know Coreboot can not drive VGA and monitor by itself. There is not enough code to do that and nothing is displayed on monitor when you run Coreboot only. It only sets up some parameters regarding to VGA which will be used by Linux kernel later. When you use FILO as a payload, your key-presses may be detected like ESC button though i did not test it myself but I found some keyboard manipulating code.... On Mon, Apr 23, 2012 at 5:16 PM, G <tjmadwja(a)gmail.com> wrote: > On Mon, Apr 23, 2012 at 12:33 PM, ali hagigat <hagigatali(a)gmail.com> wrote: >> You'd better buy a debug card and plug into the PCI slot and see what >> numbers it will display. It has two seven segment components. >> Besides you can disable coreboot post codes and insert your own post >> codes to see how far the program runs. >> I did the same for my motherboard... > > Thanks, but as I wrote on April 13th, I have managed to get some > output over serial, but still nothing on VGA or any response to > keyboard events. Details, and serial log and config file, can be > found in my April 13th message.

1 0

More elaborate commit messages
by Paul Menzel April 28, 2012

April 28, 2012

Dear coreboot folks, it is great to see all the patches sent, reviewed and committed to the list. Could the commit messages please be more elaborate? In my opinion it would not only help review and prevent possible breakage, it is in my opinion even more important for new contributors and later bug or regression hunting. I am well aware that it takes more time to write nice and elaborate commit messages like for commit 751508ab [1]. But it is worth it in the long term to know what the problem was, how it was fixed and how it was tested. In addition since our Wiki lacks some pages on supported boards and some areas are not that up to date, it is important to document a certain working state in the commit message. So if new boards are added, it would be great, to have more information about this board. An URL to a Web site with more information, what payload was used, what operating system was tested, what did work and what did not and how long did it take coreboot to execute. This would also make it easier for journalists and non-developers to write up articles including blog posts about new developments in the coreboot project. Thanks, Paul [1] http://review.coreboot.org/gitweb?p=coreboot.git;a=commit;h=751508ab019e061…

1 0

Patch merged into coreboot/master: 4ecbb5d acpigen: make acpigen_write_len_f() non static
by gerrit＠coreboot.org April 28, 2012

April 28, 2012

the following patch was just integrated into master: commit 4ecbb5dddaba5ddef2859958bcc6486d073f4e12 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Apr 27 21:55:05 2012 +0200 acpigen: make acpigen_write_len_f() non static since it is used in CPU specific ACPI generation code Change-Id: I2559658f43c89dc5b4dc8230dea8847d2802990c Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Sat Apr 28 09:03:40 2012, giving +2 See http://review.coreboot.org/947 for details. -gerrit

1 0

Patch merged into coreboot/master: 652dcc6 ectool: Allow build under Cygwin
by gerrit＠coreboot.org April 28, 2012

April 28, 2012

the following patch was just integrated into master: commit 652dcc6f7dcf8ca32dd1d8cd50e3845c1cf09fa3 Author: Raymond Danks <ray.danks(a)se-eng.com> Date: Fri Apr 27 08:51:02 2012 -0600 ectool: Allow build under Cygwin To build under Cygwin, ectool depends upon the package ioperm: http://openwince.sourceforge.net/ioperm/ for sys/io.h and sys/perm.h. This change causes the ectool make to correctly include and link against these headers and libraries. Change-Id: I7d54ab5110c2bb1fd21dfa48d56031f3f29cd54e Signed-off-by: Raymond Danks <ray.danks(a)se-eng.com> Build-Tested: build bot (Jenkins) at Fri Apr 27 17:28:39 2012, giving +1 See http://review.coreboot.org/941 for details. -gerrit

1 0

Patch merged into coreboot/master: 8e0e8bc Reverse Vendor ID & Device ID for map_oprom_vendev()
by gerrit＠coreboot.org April 28, 2012

April 28, 2012

the following patch was just integrated into master: commit 8e0e8bc705bcf1394c1b0e2fb2144f08fada8803 Author: Martin Roth <martin(a)se-eng.com> Date: Thu Apr 26 16:04:18 2012 -0600 Reverse Vendor ID & Device ID for map_oprom_vendev() - When calling map_oprom_vendev() the vendor ID and device ID are joined into a 32 bit value. They were reversed from the order that I would have expected - Device ID as the high 16 bits and the Vendor ID as the low 16. This patch reverses them so so that the the dword comparison in map_oprom_vendev() matches what's entered into Kconfig for vendor,device. - Change files calling map_oprom_vendev() Change-Id: I5b84db3cb1a359a7533409fde7d05fbc6ba3fcc4 Signed-off-by: Martin L Roth <martin(a)se-eng.com> Build-Tested: build bot (Jenkins) at Fri Apr 27 17:42:40 2012, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Fri Apr 27 21:58:47 2012, giving +1 See http://review.coreboot.org/938 for details. -gerrit

1 0

Patch set updated for coreboot: 4ecbb5d acpigen: make acpigen_write_len_f() non static
by Stefan Reinauer April 27, 2012

April 27, 2012

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/947 -gerrit commit 4ecbb5dddaba5ddef2859958bcc6486d073f4e12 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Apr 27 21:55:05 2012 +0200 acpigen: make acpigen_write_len_f() non static since it is used in CPU specific ACPI generation code Change-Id: I2559658f43c89dc5b4dc8230dea8847d2802990c Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/arch/x86/boot/acpigen.c | 2 +- src/arch/x86/include/arch/acpigen.h | 1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/arch/x86/boot/acpigen.c b/src/arch/x86/boot/acpigen.c index ac1dec2..34067ba 100644 --- a/src/arch/x86/boot/acpigen.c +++ b/src/arch/x86/boot/acpigen.c @@ -35,7 +35,7 @@ static char *gencurrent; char *len_stack[ACPIGEN_LENSTACK_SIZE]; int ltop = 0; -static int acpigen_write_len_f(void) +int acpigen_write_len_f(void) { ASSERT(ltop < (ACPIGEN_LENSTACK_SIZE - 1)) len_stack[ltop++] = gencurrent; diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h index 335d1bc..ae8aaf7 100644 --- a/src/arch/x86/include/arch/acpigen.h +++ b/src/arch/x86/include/arch/acpigen.h @@ -25,6 +25,7 @@ #include <stdint.h> #include <arch/acpi.h> +int acpigen_write_len_f(void); void acpigen_patch_len(int len); void acpigen_set_current(char *curr); char *acpigen_get_current(void);

1 0

Patch set updated for coreboot: 2fa5509 ChromeOS: Add missing prototype for acpi_get_vdat_info()
by Stefan Reinauer April 27, 2012

April 27, 2012

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/946 -gerrit commit 2fa5509a9d383de873b998111ffb56395072f892 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Apr 27 21:53:12 2012 +0200 ChromeOS: Add missing prototype for acpi_get_vdat_info() Change-Id: I4bd9b52cfc24a8ff73be05ee535b9e16c0d9bd79 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/arch/x86/include/arch/acpi.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index 5859d54..be62008 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -519,4 +519,8 @@ void generate_cpu_entries(void); #endif /* CONFIG_GENERATE_ACPI_TABLES */ +#if CONFIG_CHROMEOS +void acpi_get_vdat_info(void **vdat_addr, uint32_t *vdat_size); +#endif /* CONFIG_CHROMEOS */ + #endif /* __ASM_ACPI_H */

1 0

Patch set updated for coreboot: 97237d6 acpi: Add defines for functional fixed hardware
by Stefan Reinauer April 27, 2012

April 27, 2012

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/945 -gerrit commit 97237d6b3b030bb16c9acfc79aad807e6617d7ca Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Fri Apr 27 21:51:49 2012 +0200 acpi: Add defines for functional fixed hardware Change-Id: I9c5148eb315e2f478cb753d9918144a19e417379 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/arch/x86/include/arch/acpi.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index 587c484..5859d54 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -70,6 +70,12 @@ typedef struct acpi_gen_regaddr { #define ACPI_ADDRESS_SPACE_SMBUS 4 /* SMBus */ #define ACPI_ADDRESS_SPACE_PCC 0x0A /* Platform Comm. Channel */ #define ACPI_ADDRESS_SPACE_FIXED 0x7f /* Functional fixed hardware */ +#define ACPI_FFIXEDHW_VENDOR_INTEL 1 /* Intel */ +#define ACPI_FFIXEDHW_CLASS_HLT 0 /* C1 Halt */ +#define ACPI_FFIXEDHW_CLASS_IO_HLT 1 /* C1 I/O then Halt */ +#define ACPI_FFIXEDHW_CLASS_MWAIT 2 /* MWAIT Native C-state */ +#define ACPI_FFIXEDHW_FLAG_HW_COORD 1 /* Hardware Coordination bit */ +#define ACPI_FFIXEDHW_FLAG_BM_STS 2 /* BM_STS avoidance bit */ /* 0x80-0xbf: Reserved */ /* 0xc0-0xff: OEM defined */

1 0