coreboot July 2011

coreboot@coreboot.org

52 participants
244 discussions

[PATCH 0/8] SeaBIOS code to extract config parameters
by Kevin O'Connor 06 Jul '11

06 Jul '11

This patch series enables SeaBIOS to pull common config settings from CBFS (on coreboot) or fw_cfg (on QEmu). The series also converts several compile-time settings to this new dynamic system. I choose to place the file names in the "etc/" directory so that it is clear they are configuration settings. On coreboot, a user would do the following to enable a setting: /path/to/seabios/tools/encodeint.py boot-menu-wait 5500 ./build/cbfstool coreboot.rom add boot-menu-wait etc/boot-menu-wait raw ./build/cbfstool coreboot.rom print See the patch descriptions below for the six compile-time settings that are converted. -Kevin Kevin O'Connor (8): Add "romfile" code to assist with extract integer config settings. Replace CONFIG_BOOTMENU_WAIT with dynamic "etc/boot-menu-wait" file. Replace CONFIG_EXTRA_PCI_ROOTS with dynamic "etc/extra-pci-roots" file. Replace CONFIG_PS2_KEYBOARD_SPINUP with "etc/ps2-keyboard-spinup" file. Replace "CONFIG_OPTIONROMS_CHECKSUM" with "etc/optionroms-checksum" file. Replace CONFIG_S3_RESUME_VGA_INIT with "etc/s3-resume-vga-init" file. Replace CONFIG_SCREEN_AND_DEBUG with "etc/screen-and-debug" file. Add utility "tools/encodeint.py" for CBFS config file creation. src/Kconfig | 50 -------------------------------------------------- src/boot.c | 5 ++++- src/optionroms.c | 14 ++++++++++++-- src/output.c | 4 ++-- src/paravirt.c | 19 +++++++++++++++++++ src/paravirt.h | 2 ++ src/pci.c | 8 ++++---- src/ps2port.c | 6 ++++-- src/util.h | 1 + tools/encodeint.py | 21 +++++++++++++++++++++ 10 files changed, 69 insertions(+), 61 deletions(-) create mode 100755 tools/encodeint.py -- 1.7.4.4

1 0

[RFC] NULL pointers checking
by Rudolf Marek 05 Jul '11

05 Jul '11

Hi all, Here is a PoC of NULL pointer dereference checking in coreboot x86. It is surprisingly easy to implement. It uses strange expand down segments, making a data segment from 4KB-4GB (with base 0). It should catch most NULL derefence symbols. Unfortunately we access 0x500 while placing the coreboot tables. The hack in the patch just swaps the ds selector work arounding that. More advanced method would use paging and PAE, first 4MB with 4KB pages rest with 4MB pages identity mapped. We could even mark other than coreboot RAM range as "missing" allowing more fine grained tests what is where accessed. Even the segment hack above could be used to check the stack overflows, but I think we will need in IDT instead of interrupt gate a task gate and set there a exception stack, otherwise it will end very badly while CPU is trying to safe stack yet again during the exception. PS: Qemu does not implement segment limit checking, so just try on real HW. Dont forget to switch off GDB debugging otherwise you wont get human readable exception notice, on the other hand you can try to debug that ;) Thanks, Rudolf

1 0

Coreboot on the Thinkpad T61p ?
by Thom Lauret 05 Jul '11

05 Jul '11

Has anyone succeeded installing coreboot onto a Lenovo Thinkpad T61/p ? I see it has been achieved on a T60. Thank You Thom

2 1

SPI clock rate
by Andreas Galauner 05 Jul '11

05 Jul '11

Hello everybody, I recently started to discover this great project you have here. I want to play with it a bit and port it to an AMD E-350 Motherboard (Sapphire Pure Fusion Mini E-350 - what a name...) I have at home in my spare time. Now I don't think that the development work is much fun, when you have to take the SPI chip off the motherboard, program it, put it back into the board, see the code failing and repeat the whole process ;) So, I had the idea of developing a small Board which contains a USB port and an SPI flash. I first thought about emulating the SPI flash completely by an AVR, but I think the clock rates of the SPI bus are too high to do this. My new approach is a SPI flash which resides on the AVR board which can be multiplexed between the AVR to program it and the motherboard. If I want to test a new BIOS, the AVR puts the motherboard into reset, detaches the flash chip with a multiplexer from the motherboard, programs it, switches it back to the motherboard and let off the reset. Rapid BIOS development :) As an added bonus, I'm thinking about using a USB 2.0 port of an USB-capable AVR as a USB debug interface (those USB debugging cables are expensive for a poor student ;) ) and add a second USB 1.1 port with a MAX3420 for host-communication, but that's step 2. I know that I won't get the full 480MBit/s with this, but I think I can live with that. As I am currently looking for suitable parts, I need to know some basic parameters of the SPI communication. Does anybody of you know what the typical clock rates between the chipset and the flash are? Andy

4 7

New patch to review: 6b83829 libpayload: Don't declare mouse support in tinycurses
by Patrick Georgi 05 Jul '11

05 Jul '11

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/87 -gerrit commit 6b8382926be735a0c14c7ff516f0a390df4f1708 Author: Patrick Georgi <Patrick.Georgi(a)secunet.com> Date: Thu Mar 10 14:53:54 2011 +0100 libpayload: Don't declare mouse support in tinycurses Change-Id: Id1ff3d85617e3ec063ce332cf13920dfbbb7cf26 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/curses/tinycurses.c | 2 ++ payloads/libpayload/include/curses.h | 6 +++++- payloads/libpayload/include/curses.priv.h | 2 ++ 3 files changed, 9 insertions(+), 1 deletions(-) diff --git a/payloads/libpayload/curses/tinycurses.c b/payloads/libpayload/curses/tinycurses.c index fb492b6..fe6e7de 100644 --- a/payloads/libpayload/curses/tinycurses.c +++ b/payloads/libpayload/curses/tinycurses.c @@ -286,7 +286,9 @@ int endwin(void) return ERR; SP->_endwin = TRUE; +#ifdef NCURSES_MOUSE_VERSION SP->_mouse_wrap(SP); +#endif // _nc_screen_wrap(); // _nc_mvcur_wrap(); /* wrap up cursor addressing */ // return reset_shell_mode(); diff --git a/payloads/libpayload/include/curses.h b/payloads/libpayload/include/curses.h index 1859f02..0c97941 100644 --- a/payloads/libpayload/include/curses.h +++ b/payloads/libpayload/include/curses.h @@ -58,7 +58,7 @@ /* * Identify the mouse encoding version. */ -#define NCURSES_MOUSE_VERSION 1 +// #define NCURSES_MOUSE_VERSION 1 /* * Definitions to facilitate DLL's. @@ -1495,6 +1495,7 @@ extern NCURSES_EXPORT(const char *) _nc_viswibuf(const wint_t *); /* mouse interface */ +#ifdef NCURSES_MOUSE_VERSION #if NCURSES_MOUSE_VERSION > 1 #define NCURSES_MOUSE_MASK(b,m) ((m) << (((b) - 1) * 5)) #else @@ -1591,6 +1592,7 @@ extern NCURSES_EXPORT(bool) wmouse_trafo (const WINDOW*, int*, int*, bool); extern NCURSES_EXPORT(bool) mouse_trafo (int*, int*, bool); /* generated */ #define mouse_trafo(y,x,to_screen) wmouse_trafo(stdscr,y,x,to_screen) +#endif /* other non-XSI functions */ @@ -1616,7 +1618,9 @@ extern NCURSES_EXPORT(char *) _tracecchar_t2 (int, const cchar_t *); #define _tracech_t _tracechtype #define _tracech_t2 _tracechtype2 #endif +#ifdef NCURSES_MOUSE_VERSION extern NCURSES_EXPORT(char *) _tracemouse (const MEVENT *); +#endif extern NCURSES_EXPORT(void) trace (const unsigned int); /* trace masks */ diff --git a/payloads/libpayload/include/curses.priv.h b/payloads/libpayload/include/curses.priv.h index 594b4da..78b7ff3 100644 --- a/payloads/libpayload/include/curses.priv.h +++ b/payloads/libpayload/include/curses.priv.h @@ -514,6 +514,7 @@ struct screen { #define _nc_idlok SP->_nc_sp_idlok #define _nc_idcok SP->_nc_sp_idcok +#ifdef NCURSES_MOUSE_VERSION /* * These are the data that support the mouse interface. */ @@ -531,6 +532,7 @@ struct screen { NCURSES_CONST char *_mouse_xtermcap; /* string to enable/disable mouse */ MEVENT _mouse_events[EV_MAX]; /* hold the last mouse event seen */ MEVENT *_mouse_eventp; /* next free slot in event queue */ +#endif #if USE_GPM_SUPPORT bool _mouse_gpm_loaded;

1 0

New patch to review: 0cda4b8 libpayload: Provide atol(), malloc.h
by Patrick Georgi 05 Jul '11

05 Jul '11

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/86 -gerrit commit 0cda4b86f6b9aa1dd8acdd733bca92d801627717 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Fri May 27 15:31:52 2011 +0200 libpayload: Provide atol(), malloc.h Change-Id: I807ca061115146a6851eef481eb881b279fba8e1 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/include/malloc.h | 1 + payloads/libpayload/include/stdlib.h | 1 + payloads/libpayload/libc/string.c | 5 +++++ 3 files changed, 7 insertions(+), 0 deletions(-) diff --git a/payloads/libpayload/include/malloc.h b/payloads/libpayload/include/malloc.h new file mode 100644 index 0000000..c8b49f2 --- /dev/null +++ b/payloads/libpayload/include/malloc.h @@ -0,0 +1 @@ +#include <stdlib.h> diff --git a/payloads/libpayload/include/stdlib.h b/payloads/libpayload/include/stdlib.h index a106607..6fb73ad 100644 --- a/payloads/libpayload/include/stdlib.h +++ b/payloads/libpayload/include/stdlib.h @@ -120,6 +120,7 @@ void *memalign(size_t align, size_t size); */ long int strtol(const char *s, char **nptr, int base); unsigned long int strtoul(const char *s, char **nptr, int base); +long atol(const char *nptr); /** @} */ diff --git a/payloads/libpayload/libc/string.c b/payloads/libpayload/libc/string.c index 2e0a558..8c6ea99 100644 --- a/payloads/libpayload/libc/string.c +++ b/payloads/libpayload/libc/string.c @@ -473,6 +473,11 @@ long int strtol(const char *ptr, char **endptr, int base) return ret * negative; } +long atol(const char *nptr) +{ + return strtol(nptr, NULL, 10); +} + /** * Convert the initial portion of a string into an unsigned int * @param ptr A pointer to the string to convert

1 0

New patch to review: 8f68886 libpayload: Implement strlcpy
by Patrick Georgi 05 Jul '11

05 Jul '11

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/85 -gerrit commit 8f688867d3237a6aa78cb1afa4d9ab4747b49275 Author: Patrick Georgi <Patrick.Georgi(a)secunet.com> Date: Fri Mar 11 09:34:23 2011 +0100 libpayload: Implement strlcpy Change-Id: Ibd339957690afe2cded46895c3088eba87f0ffd1 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/include/string.h | 10 ++++++- payloads/libpayload/libc/Makefile.inc | 1 + payloads/libpayload/libc/strlcpy.c | 51 +++++++++++++++++++++++++++++++++ 3 files changed, 61 insertions(+), 1 deletions(-) diff --git a/payloads/libpayload/include/string.h b/payloads/libpayload/include/string.h index 88054e0..9e4f791 100644 --- a/payloads/libpayload/include/string.h +++ b/payloads/libpayload/include/string.h @@ -55,7 +55,6 @@ int strncasecmp(const char *s1, const char *s2, size_t maxlen); char *strncpy(char *d, const char *s, size_t n); char *strcpy(char *d, const char *s); char *strncat(char *d, const char *s, size_t n); -size_t strlcat(char *d, const char *s, size_t n); char *strcat(char *d, const char *s); char *strchr(const char *s, int c); char *strrchr(const char *s, int c); @@ -68,4 +67,13 @@ char* strtok(char *str, const char *delim); char* strtok_r(char *str, const char *delim, char **ptr); /** @} */ +/** + * @defgroup string OpenBSD based safe string functions + * @{ + */ +size_t strlcpy(char *d, const char *s, size_t n); +size_t strlcat(char *d, const char *s, size_t n); +/** @} */ + + #endif diff --git a/payloads/libpayload/libc/Makefile.inc b/payloads/libpayload/libc/Makefile.inc index 4ec2a02..e5c626f 100644 --- a/payloads/libpayload/libc/Makefile.inc +++ b/payloads/libpayload/libc/Makefile.inc @@ -33,6 +33,7 @@ libc-$(CONFIG_LIBC) += memory.c ctype.c ipchecksum.c lib.c libc-$(CONFIG_LIBC) += rand.c time.c exec.c libc-$(CONFIG_LIBC) += readline.c getopt_long.c sysinfo.c libc-$(CONFIG_LIBC) += args.c strings.c +libc-$(CONFIG_LIBC) += strlcpy.c # should be moved to coreboot directory libc-$(CONFIG_LAR) += lar.c diff --git a/payloads/libpayload/libc/strlcpy.c b/payloads/libpayload/libc/strlcpy.c new file mode 100644 index 0000000..d32b659 --- /dev/null +++ b/payloads/libpayload/libc/strlcpy.c @@ -0,0 +1,51 @@ +/* $OpenBSD: strlcpy.c,v 1.11 2006/05/05 15:27:38 millert Exp $ */ + +/* + * Copyright (c) 1998 Todd C. Miller <Todd.Miller(a)courtesan.com> + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear in all copies. + * + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + */ + +#include <sys/types.h> +#include <string.h> + +/* + * Copy src to string dst of size siz. At most siz-1 characters + * will be copied. Always NUL terminates (unless siz == 0). + * Returns strlen(src); if retval >= siz, truncation occurred. + */ +size_t +strlcpy(char *dst, const char *src, size_t siz) +{ + char *d = dst; + const char *s = src; + size_t n = siz; + + /* Copy as many bytes as will fit */ + if (n != 0) { + while (--n != 0) { + if ((*d++ = *s++) == '\0') + break; + } + } + + /* Not enough room in dst, add NUL and traverse rest of src */ + if (n == 0) { + if (siz != 0) + *d = '\0'; /* NUL-terminate dst */ + while (*s++) + ; + } + + return(s - src - 1); /* count does not include NUL */ +}

1 0

New patch to review: f3a72e8 libpayload: fix wborder()
by Patrick Georgi 05 Jul '11

05 Jul '11

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/84 -gerrit commit f3a72e8244185a3d9226febac68739e11bb3a350 Author: Patrick Georgi <Patrick.Georgi(a)secunet.com> Date: Tue Mar 15 12:34:04 2011 +0100 libpayload: fix wborder() wborder didn't provide default characters to draw a border. Change-Id: Ib746ed16be341598fd9fa1f1b7577606d1abd9e5 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- payloads/libpayload/curses/tinycurses.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/payloads/libpayload/curses/tinycurses.c b/payloads/libpayload/curses/tinycurses.c index 4d3e8e1..fb492b6 100644 --- a/payloads/libpayload/curses/tinycurses.c +++ b/payloads/libpayload/curses/tinycurses.c @@ -584,6 +584,15 @@ int wborder(WINDOW *win, chtype ls, chtype rs, chtype ts, chtype bs, { int x, y; + if (ls == 0) ls = ACS_VLINE; + if (rs == 0) rs = ACS_VLINE; + if (ts == 0) ts = ACS_HLINE; + if (bs == 0) bs = ACS_HLINE; + if (tl == 0) tl = ACS_ULCORNER; + if (tr == 0) tr = ACS_URCORNER; + if (bl == 0) bl = ACS_LLCORNER; + if (br == 0) br = ACS_LRCORNER; + for(y = 0; y <= win->_maxy; y++) { if (y == 0) {

1 0

[RFC][PATCH 0/2] SerialICE for coreboot.
by Tadas Slotkus 04 Jul '11

04 Jul '11

This is for testing/developing purpose, not for merging. SerialICE in coreboot would be great for developing at least CPUs cache init code. This strategy makes use of early serial functions directly from coreboot tree. This is with example for one board (copy from romstage early serial code for your board). Comments are welcome! Patches (2): SerialICE files, receive function for romcc_console, bootblock_simple example SerialICE patch src/arch/x86/SerialICE/io.h | 195 ++++++++++++++++++++++++ src/arch/x86/SerialICE/serial.c | 190 ++++++++++++++++++++++++ src/arch/x86/SerialICE/serialice.c | 272 ++++++++++++++++++++++++++++++++++ src/arch/x86/init/bootblock_simple.c | 2 + src/arch/x86/lib/romcc_console.c | 7 + 5 files changed, 666 insertions(+), 0 deletions(-) create mode 100644 src/arch/x86/SerialICE/io.h create mode 100644 src/arch/x86/SerialICE/serial.c create mode 100644 src/arch/x86/SerialICE/serialice.c

1 2

Trac reminder: list of new ticket(s)
by coreboot tracker 04 Jul '11

04 Jul '11

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot July 2011