coreboot December 2011

coreboot@coreboot.org

34 participants
174 discussions

Re: [coreboot] gerrit/jenkis missing builds.
by Patrick Georgi 21 Dec '11

21 Dec '11

Am 21.12.2011 18:55, schrieb Marc Jones: > What is a difference between Jenkis setting a -1 "unstable" vs a "red > x" in verified? "verified -1" is when any build fails "unstable" is when the builds report success but the test harness reports issues. unstable will only happen for us when messing around with abuild and the build system (such as with the patch in question). Patrick

1 0

Re: [coreboot] gerrit/jenkis missing builds.
by Patrick Georgi 21 Dec '11

21 Dec '11

Am 21.12.2011 03:28, schrieb Marc Jones: > It looks like these patches didn't get built by jenkins. Thanks for the notice. > http://review.coreboot.org/#change,487 > http://review.coreboot.org/#change,488 I triggered these manually and will have to look into what happened there originally. > http://review.coreboot.org/#change,409 This one got tested, but it was found "unstable" by Jenkins, so it did a -1 review, with no test result. Patrick

2 1

Patch merged into coreboot/master: 66ebaa9 Respect linker order
by gerrit＠coreboot.org 21 Dec '11

21 Dec '11

the following patch was just integrated into master: commit 66ebaa9f670438b7dd4efa80b65830b362729a9b Author: Christian Ruppert <idl0r(a)qasl.de> Date: Sat Dec 17 21:56:05 2011 +0100 Respect linker order Linking fails when using -Wl,--as-needed and/or esp. when forcing --as-needed through a compiler specs file. A proper compile/link command would look like: $(CC) $(CFLAGS) $(LDFLAGS) -o foo $(OBJS) $(LIBS). So the *FLAGS must be passed *before* the objects while the libraries/dependencies must be passed *after* the objects. For more details see: http://www.gentoo.org/proj/en/qa/asneeded.xml Change-Id: I5a5b05e1cab8a2d88ce56c92d9b2f991ca1ee6c0 Signed-off-by: Christian Ruppert <idl0r(a)qasl.de> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Wed Dec 21 16:26:55 2011, giving +2 See http://review.coreboot.org/494 for details. -gerrit

1 0

Patch merged into coreboot/master: cc2e8ec kbd: wait longer for self-test on keyboard reset
by gerrit＠coreboot.org 21 Dec '11

21 Dec '11

the following patch was just integrated into master: commit cc2e8ec8e1da449915789fe13cc645f23b94669c Author: Mathias Krause <mathias.krause(a)secunet.com> Date: Wed Dec 14 08:40:48 2011 +0100 kbd: wait longer for self-test on keyboard reset Some keyboards take pretty long to respond to a reset command, some even delay the ACK to the command. To make the keyboard driver more robust, increase the timeout for this special command. Also do an interface test after the self-test to ensure the keyboard is functioning properly. Another point is to reenable the keyboard *after* the scancode was set, not before. We also set the system bit when enabling the keyboard because this seems to be what older operating systems do expect. One of the problematic keyboards, which will work with this patch applied, is the DELL RT7D20. Without the patch an overly optimistic operating system, read Linux 2.4, will not recognise the keyboard because coreboot didn't fully initialize it. Change-Id: I28c8e05bdde61f71b7de084c96bc2447c1b9575e Signed-off-by: Mathias Krause <mathias.krause(a)secunet.com> Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Wed Dec 21 16:25:20 2011, giving +2 See http://review.coreboot.org/486 for details. -gerrit

1 0

Patch set updated for coreboot: 14cd7a8 Fix multipleVGA cards resource conflict on Windows
by Kerry Sheh 21 Dec '11

21 Dec '11

Kerry Sheh (shekairui(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/489 -gerrit commit 14cd7a8f8e165622cb9f537a6b6275d274e5e78e Author: Kerry Sheh <shekairui(a)gmail.com> Date: Wed Dec 21 20:05:21 2011 +0800 Fix multipleVGA cards resource conflict on Windows If multiple VGA-compatible legacy graphic cards decode the IO range 3B0-3BB, 3C0-3DF and MEM range A00000-BFFFF. Windows 7 complain a resource conflict, so only one VGA card can works at the same time. By disable the IO & MEM decode of the second vga graphic device, this patch resolved the resource conflict in windows7, multiple vga-compatible graphic cards can work together in windows7. Please reference PCI spec. section 3.10 in detail. There is a discuss in coreboot mail list before, please reference thread: "how to prevent legacy resource conflictwith multipleVGA cards" Linux using VGA Arbiter module(vgaarb) to resolve this resource conflict, Please see the following linux dmesg log, more information can be found in Linux source dir Documentation/vgaarbiter.txt. But it seems that windows don't dealwith this conflict. ~# dmesg | grep -i vgaarb [ 0.774076] vgaarb: device added: PCI:0000:00:01.0,decodes=io+mem,owns=io+mem [ 0.776065] vgaarb: device added: PCI:0000:01:00.0,decodes=io+mem,owns=none,l [ 0.780051] vgaarb: loaded [ 0.784049] vgaarb: bridge control possible 0000:01:00.0 [ 0.788050] vgaarb: bridge control possible 0000:00:01.0 For the second legacy graphic device, coreboot already disabled the IO and MEM decode in function set_vga_bridge_bits(). But it will be enabled again in function pci_set_resource(), if the second legacy vga-compatible graphic device take any IO/MEM resources. Following log printed by enable_resources() shows the problem: ...snip... PCI: 00:00.0 cmd <- 06 PCI: 00:01.0 subsystem <- 1022/1410 PCI: 00:01.0 cmd <- 07 <== The first graphic device PCI: 00:01.1 subsystem <- 1022/1410 PCI: 00:01.1 cmd <- 02 PCI: 00:02.0 bridge ctrl <- 0003 PCI: 00:02.0 cmd <- 07 ...snip... PCI: 01:00.0 cmd <- 03 <== The second graphic device PCI: 01:00.1 cmd <- 02 PCI: 02:00.0 cmd <- 02 PCI: 03:00.0 cmd <- 03 done. ...snip... Signed-off-by: Kerry Sheh <shekairui(a)gmail.com> Signed-off-by: Kerry Sheh <kerry.she(a)amd.com> Change-Id: I0de5e3761b51e2723d9c1dc0c39fff692e3a779d --- src/devices/pci_device.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/devices/pci_device.c b/src/devices/pci_device.c index 2ccb38a..8270753 100644 --- a/src/devices/pci_device.c +++ b/src/devices/pci_device.c @@ -494,6 +494,26 @@ static void pci_set_resource(struct device *dev, struct resource *resource) dev->command |= PCI_COMMAND_IO; if (resource->flags & IORESOURCE_PCI_BRIDGE) dev->command |= PCI_COMMAND_MASTER; + + /* It isn't safe to enable multiple VGA cards. + * See PCI spec section 3.10. + * The palette snoop bit will be set by the system firmware + * when it detects both a VGA device and a graphics accelerator + * device that are on separate add-in cards on the same bus or + * on the same path but on different buses. + * Either device can be set to snoop and the other will be set + * to positively respond. + */ +#if CONFIG_VGA_BRIDGE_SETUP == 1 + extern device_t vga_pri; + if (((dev->class >> 16) == PCI_BASE_CLASS_DISPLAY) && + (dev != vga_pri)) { + if (((vga_pri->class >> 8) == PCI_CLASS_DISPLAY_VGA) && + ((dev->class >> 8) == PCI_CLASS_DISPLAY_VGA)) { + dev->command &= ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY); + } + } +#endif } /* Get the base address. */

1 0

gerrit/jenkis missing builds.
by Marc Jones 21 Dec '11

21 Dec '11

It looks like these patches didn't get built by jenkins. http://review.coreboot.org/#change,487 http://review.coreboot.org/#change,488 http://review.coreboot.org/#change,409 Marc -- http://se-eng.com

1 0

Patch merged into coreboot/master: b751de8 Persimmon audio codec verb patch.
by gerrit＠coreboot.org 21 Dec '11

21 Dec '11

the following patch was just integrated into master: commit b751de894b1a7126b5182fefb9e048c5ffc45597 Author: Marc Jones <marcj303(a)gmail.com> Date: Wed Dec 14 11:24:00 2011 -0700 Persimmon audio codec verb patch. Verb data is required for the HDA audio codec in the sb800 southbridge. Verb data is not required for mainboards that use G-Series HDMI. It is also a setting the may be boards specific. This fixes issues with Windows audio on Persimmon. Change-Id: I067506871e92078d122cf79872363d8937d47e50 Signed-off-by: Marc Jones <marcj303(a)gmail.com> Build-Tested: build bot (Jenkins) at Sat Dec 17 01:10:37 2011, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Wed Dec 21 01:06:15 2011, giving +2 See http://review.coreboot.org/490 for details. -gerrit

1 0

Re: [coreboot] Patch set updated for coreboot: 6709bdd Fix multipleVGA cards resource conflict on Windows
by Marc Jones 20 Dec '11

20 Dec '11

On Mon, Dec 19, 2011 at 8:33 PM, Tom Sylla <tsylla(a)gmail.com> wrote: > The open-graphics people had this question a while back, I think I > took a look at some different platforms and BIOSes: > http://lists.duskglow.com/open-graphics/2007-August/010402.html > > Turning on the decoders for only one of each type of legacy device sounds right. Right, the bridges need to be setup with the snoop etc, but only one device can have the decode enabled. Marc -- http://se-eng.com

1 0

Re: [coreboot] Patch set updated for coreboot: 6709bdd Fix multipleVGA cards resource conflict on Windows
by Patrick Georgi 20 Dec '11

20 Dec '11

Am 19.12.2011 18:02, schrieb ron minnich: > I wonder if a better way to manage this is via a CMOS (aka NVRAM) > setting. No user visible configuration if it can be avoided, please. > I kind of hate to limit coreboot because Windows is limited. > But I'm a n00b in a sense, having just come back onto this project, so > I'm happy to be told I'm wrong :-) It sounds just wrong to have IO/MEM decoding on the _same_ areas activated for two devices. vgaarb should still work with one of them having resources disabled by default, I think. Otherwise coreboot would be the _only_ chance for vgaarb to work, as all other boot systems will support Windows even to the detriment of Linux support. Which means that vgaarb wouldn't exist, given their position towards coreboot. > Changing circumstances mean I get to work on it > again, which is nice. Yay! Patrick

3 2

Re: [coreboot] Patch set updated for coreboot: 6709bdd Fix multipleVGA cards resource conflict on Windows
by She, Kerry 19 Dec '11

19 Dec '11

-----Original Message----- From: ron minnich [mailto:rminnich@gmail.com] Sent: Tue 12/20/2011 1:02 AM To: She, Kerry Cc: Kerry Sheh; coreboot(a)coreboot.org Subject: Re: [coreboot] Patch set updated for coreboot: 6709bdd Fix multipleVGA cards resource conflict on Windows On Sun, Dec 18, 2011 at 10:01 PM, She, Kerry <Kerry.She(a)amd.com> wrote: >> Hello, Ron >> >>> I asked: >>> What do Linux or *BSD do in the same situation? Do they handle it cleanly? >> Linux VGA Arbiter module(vgaarb) will handle this explicitly. >> So dual vga card would works together, even coreboot not disable IO& MEM decoding on the second vga card. >OK, then, my concern about this patch is that you are making a >compile-time decision in coreboot to fix a problem with one operating >system (Windows) that will impact other operating systems that don't >have the problem. Yes, I agree. >I wonder if a better way to manage this is via a CMOS (aka NVRAM) >setting. I kind of hate to limit coreboot because Windows is limited. >But I'm a n00b in a sense, having just come back onto this project, so >I'm happy to be told I'm wrong :-) I think CMOS option is a better choice for this case, thanks for your advice. >ron >p.s. For those who don't know me, I've been out of coreboot for 2 >years, having been heavily involved from 1999 (when I started >LinuxBIOS) to 2009. Changing circumstances mean I get to work on it >again, which is nice. That's great, I'm glad to hear that you are back to work on coreboot again:) kerry

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot December 2011