June 2009 - coreboot - mail.coreboot.org

Re: [coreboot] Porting coreboot to Intel Atom (Silverthorne) & SCH US15W (Poulsbo) chipset
by Gaechter, Stefan June 5, 2009

June 5, 2009

hi, a view weeks ago i read about the start of a menlow port. has anybody started the port? Br, stefan On Tue, 14 Apr 2009 08:56:06 -0500, bari <bari at onelabs.com> wrote: > Mansoor wrote: >> Hi, >> >> I have a Atom Silverthorne Poulsbo based board >> (http://www.iwavesystems.com/iW-Q7.htm) I want to port coreboot on this >> platform. >> >> I would like to know if anybody has started/suceeded in porting coreboot >> to Atom, also if there is anyone interested in such a port. > > There is lots of interest in Atom support. Nobody I am aware of has > enough documentation yet. Maybe you do since you have an Atom based COM > module? http://iwavesystems.com/iW-Q7.htm > >> 1)Which version of coreboot can be used (v2 or v3) ? >> 2)Which platform (CPU,motherboard,EC) can be taken as reference ? > > The i945 is supported by v2 so an Atom + i945 board would be the > shortest path to success. > Yes, I would have to agree with Bari here. You should start with the i945 code. -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

4 3

[PATCH] flashrom: add probe timings forgotten in r569
by Carl-Daniel Hailfinger June 5, 2009

June 5, 2009

Add probe timings forgotten in r569. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-probe_timing/flashchips.c =================================================================== --- flashrom-probe_timing/flashchips.c (Revision 570) +++ flashrom-probe_timing/flashchips.c (Arbeitskopie) @@ -35,7 +35,7 @@ * Bus Type, * Total size (kB), Page size (B), * Test status, - * Probe function, Probe function timing argument, Erase function, Write function, Read function + * Probe function, Probe function timing, Erase function, Write function, Read function */ { @@ -176,6 +176,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -191,6 +192,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -206,6 +208,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -221,6 +224,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -236,6 +240,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -251,6 +256,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -266,6 +272,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -281,6 +288,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -296,6 +304,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -311,6 +320,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -326,6 +336,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL /* Incompatible Page write */, .read = spi_chip_read, @@ -341,6 +352,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -356,6 +368,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -371,6 +384,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -387,6 +401,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -402,6 +417,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = NULL /* Incompatible Page write */, .read = spi_chip_read, @@ -482,6 +498,7 @@ .page_size = 1056 /* No power of two sizes */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL /* Incompatible Page write */, .read = NULL /* Incompatible read */, @@ -497,6 +514,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -512,6 +530,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -527,6 +546,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -542,6 +562,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -557,6 +578,7 @@ .page_size = 512 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -572,6 +594,7 @@ .page_size = 528 /* No power of two sizes */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL /* Incompatible read */, @@ -587,6 +610,7 @@ .page_size = 512 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -602,6 +626,7 @@ .page_size = 1024 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -665,6 +690,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid4, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -888,6 +914,7 @@ .page_size = 64 * 1024, .tested = TEST_OK_PREW, .probe = probe_82802ab, + .probe_timing = TIMING_IGNORED, /* routine does not use probe_timing (82802ab.c) */ .erase = erase_82802ab, .write = write_82802ab, .read = read_memmapped, @@ -903,6 +930,7 @@ .page_size = 64 * 1024, .tested = TEST_OK_PREW, .probe = probe_82802ab, + .probe_timing = TIMING_IGNORED, /* routine does not use probe_timing (82802ab.c) */ .erase = erase_82802ab, .write = write_82802ab, .read = read_memmapped, @@ -918,6 +946,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -933,6 +962,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -948,6 +978,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -963,6 +994,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -978,6 +1010,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -993,6 +1026,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1008,6 +1042,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1023,6 +1058,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1038,6 +1074,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1053,6 +1090,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1068,6 +1106,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1131,6 +1170,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1146,6 +1186,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1161,6 +1202,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1176,6 +1218,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1191,6 +1234,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1206,6 +1250,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1221,6 +1266,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1236,6 +1282,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1251,6 +1298,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1266,6 +1314,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1281,6 +1330,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1360,6 +1410,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1375,6 +1426,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1390,6 +1442,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1405,6 +1458,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1420,6 +1474,7 @@ .page_size = 64*1024, .tested = TEST_OK_PR, .probe = probe_spi_rems, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1435,6 +1490,7 @@ .page_size = 64*1024, .tested = TEST_OK_PR, .probe = probe_spi_rems, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1450,6 +1506,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1881,6 +1938,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1896,6 +1954,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1911,6 +1970,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1926,6 +1986,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1941,6 +2002,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_res, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1956,6 +2018,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1971,6 +2034,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1986,6 +2050,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2001,6 +2066,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2016,6 +2082,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2367,6 +2434,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2382,6 +2450,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2397,6 +2466,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2412,6 +2482,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2651,6 +2722,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2666,6 +2738,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2681,6 +2754,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2696,6 +2770,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2711,6 +2786,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2726,6 +2802,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, -- http://www.hailfinger.org/ Index: flashrom-probe_timing/flashchips.c =================================================================== --- flashrom-probe_timing/flashchips.c (Revision 570) +++ flashrom-probe_timing/flashchips.c (Arbeitskopie) @@ -35,7 +35,7 @@ * Bus Type, * Total size (kB), Page size (B), * Test status, - * Probe function, Probe function timing argument, Erase function, Write function, Read function + * Probe function, Probe function timing, Erase function, Write function, Read function */ { @@ -176,6 +176,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -191,6 +192,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -206,6 +208,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -221,6 +224,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -236,6 +240,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -251,6 +256,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -266,6 +272,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -281,6 +288,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -296,6 +304,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -311,6 +320,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -326,6 +336,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL /* Incompatible Page write */, .read = spi_chip_read, @@ -341,6 +352,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -356,6 +368,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -371,6 +384,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -387,6 +401,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -402,6 +417,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = NULL /* Incompatible Page write */, .read = spi_chip_read, @@ -482,6 +498,7 @@ .page_size = 1056 /* No power of two sizes */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL /* Incompatible Page write */, .read = NULL /* Incompatible read */, @@ -497,6 +514,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -512,6 +530,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -527,6 +546,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -542,6 +562,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -557,6 +578,7 @@ .page_size = 512 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -572,6 +594,7 @@ .page_size = 528 /* No power of two sizes */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL /* Incompatible read */, @@ -587,6 +610,7 @@ .page_size = 512 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -602,6 +626,7 @@ .page_size = 1024 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -665,6 +690,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid4, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -888,6 +914,7 @@ .page_size = 64 * 1024, .tested = TEST_OK_PREW, .probe = probe_82802ab, + .probe_timing = TIMING_IGNORED, /* routine does not use probe_timing (82802ab.c) */ .erase = erase_82802ab, .write = write_82802ab, .read = read_memmapped, @@ -903,6 +930,7 @@ .page_size = 64 * 1024, .tested = TEST_OK_PREW, .probe = probe_82802ab, + .probe_timing = TIMING_IGNORED, /* routine does not use probe_timing (82802ab.c) */ .erase = erase_82802ab, .write = write_82802ab, .read = read_memmapped, @@ -918,6 +946,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -933,6 +962,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -948,6 +978,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -963,6 +994,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -978,6 +1010,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -993,6 +1026,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1008,6 +1042,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1023,6 +1058,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1038,6 +1074,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1053,6 +1090,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1068,6 +1106,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1131,6 +1170,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1146,6 +1186,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1161,6 +1202,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1176,6 +1218,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1191,6 +1234,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1206,6 +1250,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1221,6 +1266,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1236,6 +1282,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1251,6 +1298,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1266,6 +1314,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1281,6 +1330,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1360,6 +1410,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1375,6 +1426,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1390,6 +1442,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1405,6 +1458,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1420,6 +1474,7 @@ .page_size = 64*1024, .tested = TEST_OK_PR, .probe = probe_spi_rems, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1435,6 +1490,7 @@ .page_size = 64*1024, .tested = TEST_OK_PR, .probe = probe_spi_rems, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1450,6 +1506,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1881,6 +1938,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1896,6 +1954,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1911,6 +1970,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1926,6 +1986,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1941,6 +2002,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_res, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1956,6 +2018,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1971,6 +2034,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1986,6 +2050,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2001,6 +2066,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2016,6 +2082,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2367,6 +2434,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2382,6 +2450,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2397,6 +2466,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2412,6 +2482,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2651,6 +2722,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2666,6 +2738,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2681,6 +2754,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2696,6 +2770,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2711,6 +2786,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2726,6 +2802,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL,

2 2

[flashrom] r576 - trunk
by svn＠coreboot.org June 5, 2009

June 5, 2009

Author: hailfinger Date: 2009-06-05 15:46:17 +0200 (Fri, 05 Jun 2009) New Revision: 576 Modified: trunk/flashchips.c Log: Add probe timings forgotten in r569. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Modified: trunk/flashchips.c =================================================================== --- trunk/flashchips.c 2009-06-05 13:30:49 UTC (rev 575) +++ trunk/flashchips.c 2009-06-05 13:46:17 UTC (rev 576) @@ -35,7 +35,7 @@ * Bus Type, * Total size (kB), Page size (B), * Test status, - * Probe function, Probe function timing argument, Erase function, Write function, Read function + * Probe function, Probe function timing, Erase function, Write function, Read function */ { @@ -176,6 +176,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -191,6 +192,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -206,6 +208,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -221,6 +224,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -236,6 +240,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -251,6 +256,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -266,6 +272,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -281,6 +288,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -296,6 +304,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -311,6 +320,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -326,6 +336,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL /* Incompatible Page write */, .read = spi_chip_read, @@ -341,6 +352,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -356,6 +368,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -371,6 +384,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -387,6 +401,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -402,6 +417,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = NULL /* Incompatible Page write */, .read = spi_chip_read, @@ -482,6 +498,7 @@ .page_size = 1056 /* No power of two sizes */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL /* Incompatible Page write */, .read = NULL /* Incompatible read */, @@ -497,6 +514,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -512,6 +530,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -527,6 +546,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -542,6 +562,7 @@ .page_size = 256 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -557,6 +578,7 @@ .page_size = 512 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -572,6 +594,7 @@ .page_size = 528 /* No power of two sizes */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL /* Incompatible read */, @@ -587,6 +610,7 @@ .page_size = 512 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -602,6 +626,7 @@ .page_size = 1024 /* Size can only be determined from status register */, .tested = TEST_BAD_READ, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -665,6 +690,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid4, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -888,6 +914,7 @@ .page_size = 64 * 1024, .tested = TEST_OK_PREW, .probe = probe_82802ab, + .probe_timing = TIMING_IGNORED, /* routine does not use probe_timing (82802ab.c) */ .erase = erase_82802ab, .write = write_82802ab, .read = read_memmapped, @@ -903,6 +930,7 @@ .page_size = 64 * 1024, .tested = TEST_OK_PREW, .probe = probe_82802ab, + .probe_timing = TIMING_IGNORED, /* routine does not use probe_timing (82802ab.c) */ .erase = erase_82802ab, .write = write_82802ab, .read = read_memmapped, @@ -918,6 +946,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -933,6 +962,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -948,6 +978,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -963,6 +994,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -978,6 +1010,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -993,6 +1026,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1008,6 +1042,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1023,6 +1058,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1038,6 +1074,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1053,6 +1090,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1068,6 +1106,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1131,6 +1170,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1146,6 +1186,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1161,6 +1202,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1176,6 +1218,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1191,6 +1234,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_d8, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1206,6 +1250,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1221,6 +1266,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1236,6 +1282,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1251,6 +1298,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1266,6 +1314,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1281,6 +1330,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1360,6 +1410,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1375,6 +1426,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1390,6 +1442,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1405,6 +1458,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1420,6 +1474,7 @@ .page_size = 64*1024, .tested = TEST_OK_PR, .probe = probe_spi_rems, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1435,6 +1490,7 @@ .page_size = 64*1024, .tested = TEST_OK_PR, .probe = probe_spi_rems, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1450,6 +1506,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_60_c7, .write = spi_chip_write_1, .read = spi_chip_read, @@ -1881,6 +1938,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1896,6 +1954,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1911,6 +1970,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1926,6 +1986,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1941,6 +2002,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_res, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1956,6 +2018,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1971,6 +2034,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -1986,6 +2050,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2001,6 +2066,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2016,6 +2082,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2367,6 +2434,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2382,6 +2450,7 @@ .page_size = 256, .tested = TEST_UNTESTED, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2397,6 +2466,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2412,6 +2482,7 @@ .page_size = 256, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = spi_chip_erase_c7, .write = spi_chip_write_256, .read = spi_chip_read, @@ -2651,6 +2722,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2666,6 +2738,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2681,6 +2754,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2696,6 +2770,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2711,6 +2786,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL, @@ -2726,6 +2802,7 @@ .page_size = 256, .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, .erase = NULL, .write = NULL, .read = NULL,

1 0

Re: [coreboot] [flashrom] r573 - trunk
by Carl-Daniel Hailfinger June 5, 2009

June 5, 2009

On 05.06.2009 02:42, svn(a)coreboot.org wrote: > New Revision: 573 > > Modified: > trunk/sst49lfxxxc.c > Log: > Actually enable the protection register debug output on > SST49LF160C and similar chips if -V is supplied. > > Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> > Acked-by: Myles Watson<mylesgw(a)gmail.com> > > Modified: trunk/sst49lfxxxc.c > =================================================================== > --- trunk/sst49lfxxxc.c 2009-06-04 19:25:54 UTC (rev 572) > +++ trunk/sst49lfxxxc.c 2009-06-05 00:42:18 UTC (rev 573) > @@ -38,28 +38,37 @@ > > for (i = 0; left > 65536; i++, left -= 65536) { > - //printf("lockbits at address=0x%08lx is 0x%01x\n", (unsigned long)0xFFC00000 - size + (i * 65536) + 2, *(bios + (i * 65536) + 2) ); > + printf_debug("lockbits at address=%p is 0x%01x\n", > + (void *)(0xffc00000 - size + (i * 65536) + 2), > + chip_readb(bios + (i * 65536) + 2)); > chip_writeb(bits, bios + (i * 65536) + 2); > Sorry, I don't get it. Why do you use a base of 0xffc00000 - size for printing the address and bios for printing the contents? There's flash->virtual_memory and flash->virtual_registers. Any reason you recalculate flash->virtual_registers even though it is passed in? Regards, Carl-Daniel -- http://www.hailfinger.org/

3 4

[flashrom] r575 - trunk
by svn＠coreboot.org June 5, 2009

June 5, 2009

Author: hailfinger Date: 2009-06-05 15:30:49 +0200 (Fri, 05 Jun 2009) New Revision: 575 Modified: trunk/sst49lfxxxc.c Log: Use flash->virtual_registers for what they were meant for instead of recalculating them every time. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/sst49lfxxxc.c =================================================================== --- trunk/sst49lfxxxc.c 2009-06-05 08:47:37 UTC (rev 574) +++ trunk/sst49lfxxxc.c 2009-06-05 13:30:49 UTC (rev 575) @@ -38,38 +38,39 @@ #define STATUS_ESS (1 << 6) #define STATUS_WSMS (1 << 7) -static int write_lockbits_49lfxxxc(chipaddr bios, int size, unsigned char bits) +static int write_lockbits_49lfxxxc(struct flashchip *flash, unsigned char bits) { - int i, left = size; + chipaddr registers = flash->virtual_registers; + int i, left = flash->total_size * 1024; unsigned long address; - printf_debug("\nbios=0x%08lx\n", bios); + printf_debug("\nbios=0x%08lx\n", registers); for (i = 0; left > 65536; i++, left -= 65536) { - printf_debug("lockbits at address=%p is 0x%01x\n", - (void *)(0xffc00000 - size + (i * 65536) + 2), - chip_readb(bios + (i * 65536) + 2)); - chip_writeb(bits, bios + (i * 65536) + 2); + printf_debug("lockbits at address=0x%08lx is 0x%01x\n", + registers + (i * 65536) + 2, + chip_readb(registers + (i * 65536) + 2)); + chip_writeb(bits, registers + (i * 65536) + 2); } address = i * 65536; - printf_debug("lockbits at address=%p is 0x%01x\n", - (void *)(0xffc00000 - size + address + 2), - chip_readb(bios + address + 2)); - chip_writeb(bits, bios + address + 2); + printf_debug("lockbits at address=0x%08lx is 0x%01x\n", + registers + address + 2, + chip_readb(registers + address + 2)); + chip_writeb(bits, registers + address + 2); address += 32768; - printf_debug("lockbits at address=%p is 0x%01x\n", - (void *)(0xffc00000 - size + address + 2), - chip_readb(bios + address + 2)); - chip_writeb(bits, bios + address + 2); + printf_debug("lockbits at address=0x%08lx is 0x%01x\n", + registers + address + 2, + chip_readb(registers + address + 2)); + chip_writeb(bits, registers + address + 2); address += 8192; - printf_debug("lockbits at address=%p is 0x%01x\n", - (void *)(0xffc00000 - size + address + 2), - chip_readb(bios + address + 2)); - chip_writeb(bits, bios + address + 2); + printf_debug("lockbits at address=0x%08lx is 0x%01x\n", + registers + address + 2, + chip_readb(registers + address + 2)); + chip_writeb(bits, registers + address + 2); address += 8192; - printf_debug("lockbits at address=%p is 0x%01x\n", - (void *)(0xffc00000 - size + address + 2), - chip_readb(bios + address + 2)); - chip_writeb(bits, bios + address + 2); + printf_debug("lockbits at address=0x%08lx is 0x%01x\n", + registers + address + 2, + chip_readb(registers + address + 2)); + chip_writeb(bits, registers + address + 2); return 0; } @@ -150,11 +151,10 @@ int erase_49lfxxxc(struct flashchip *flash) { chipaddr bios = flash->virtual_memory; - chipaddr registers = flash->virtual_registers; int i; unsigned int total_size = flash->total_size * 1024; - write_lockbits_49lfxxxc(registers, total_size, 0); + write_lockbits_49lfxxxc(flash, 0); for (i = 0; i < total_size; i += flash->page_size) if (erase_sector_49lfxxxc(bios, i) != 0) return (-1); @@ -171,7 +171,7 @@ int page_size = flash->page_size; chipaddr bios = flash->virtual_memory; - write_lockbits_49lfxxxc(flash->virtual_registers, total_size, 0); + write_lockbits_49lfxxxc(flash, 0); printf("Programming page: "); for (i = 0; i < total_size / page_size; i++) { /* erase the page before programming */

1 0

Re: [coreboot] [RFC] [flashrom] "accelerated" high-level external programmer functions and serial external programmer protocol
by Urja Rannikko June 5, 2009

June 5, 2009

> What about introducing a per-programmer delay function pointer instead? > Your programmer could buffer everything (delays, writes) until the first > read, then send them as a batch. > The only problem i see here that in order for this to work properly, i would need to create the buffer on the programmer side (otherwise there could be too big delays between the packets (even if streaming a buffered store from the computer), eg. network packet loss) and i'm not sure whether the AVR's 1k SRAM would be enough to hold even the low level description of a single page load, given address + data = 4 bytes + 1 byte operation = 5*256 = 1280 bytes. ofcourse the addresses could be "compressed" (sequential), but it still doesnt sound right - even simple op+byte would be 512+ bytes. We could compress down to op + n + n bytes ... that could work. Not sure. I sent this accidentally only to carl-daniel first, sorry. -- urjaman

2 1

[v2] r4340 - in trunk/coreboot-v2/src: console devices southbridge/intel/i82801dbm
by svn＠coreboot.org June 5, 2009

June 5, 2009

Author: hailfinger Date: 2009-06-05 13:41:51 +0200 (Fri, 05 Jun 2009) New Revision: 4340 Modified: trunk/coreboot-v2/src/console/console.c trunk/coreboot-v2/src/devices/pci_ops.c trunk/coreboot-v2/src/devices/smbus_ops.c trunk/coreboot-v2/src/southbridge/intel/i82801dbm/i82801dbm_lpc.c Log: die() does never return. Annotate it as such. Any endless loop after die() can be eliminated. Dereferencing a NULL pointer is bad. die() instead. Replace endless loops with die(). Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/coreboot-v2/src/console/console.c =================================================================== --- trunk/coreboot-v2/src/console/console.c 2009-06-05 10:00:07 UTC (rev 4339) +++ trunk/coreboot-v2/src/console/console.c 2009-06-05 11:41:51 UTC (rev 4340) @@ -92,7 +92,7 @@ } /* Report a fatal error */ -void die(const char *msg) +void __attribute__((noreturn)) die(const char *msg) { printk_emerg("%s", msg); post_code(0xff); Modified: trunk/coreboot-v2/src/devices/pci_ops.c =================================================================== --- trunk/coreboot-v2/src/devices/pci_ops.c 2009-06-05 10:00:07 UTC (rev 4339) +++ trunk/coreboot-v2/src/devices/pci_ops.c 2009-06-05 11:41:51 UTC (rev 4340) @@ -30,7 +30,7 @@ struct bus *pbus; if (!dev) - printk_alert("get_pbus: dev is NULL!\n"); + die("get_pbus: dev is NULL!\n"); pbus = dev->bus; @@ -44,9 +44,8 @@ pbus = pbus->dev->bus; } if (!pbus || !pbus->dev || !pbus->dev->ops || !pbus->dev->ops->ops_pci_bus) { - printk_alert("%s Cannot find pci bus operations", dev_path(dev)); + printk_emerg("%s Cannot find pci bus operations\n", dev_path(dev)); die(""); - for(;;); } return pbus; } Modified: trunk/coreboot-v2/src/devices/smbus_ops.c =================================================================== --- trunk/coreboot-v2/src/devices/smbus_ops.c 2009-06-05 10:00:07 UTC (rev 4339) +++ trunk/coreboot-v2/src/devices/smbus_ops.c 2009-06-05 11:41:51 UTC (rev 4340) @@ -34,7 +34,6 @@ if (!pbus || !pbus->dev || !pbus->dev->ops || !pbus->dev->ops->ops_smbus_bus) { printk_alert("%s Cannot find smbus bus operations", dev_path(dev)); die(""); - for(;;); } return pbus; } Modified: trunk/coreboot-v2/src/southbridge/intel/i82801dbm/i82801dbm_lpc.c =================================================================== --- trunk/coreboot-v2/src/southbridge/intel/i82801dbm/i82801dbm_lpc.c 2009-06-05 10:00:07 UTC (rev 4339) +++ trunk/coreboot-v2/src/southbridge/intel/i82801dbm/i82801dbm_lpc.c 2009-06-05 11:41:51 UTC (rev 4340) @@ -37,12 +37,12 @@ dword=*ioapic_sbd; printk_debug("Southbridge apic id = %x\n",dword); if(dword!=(2<<24)) - for(;;); + die(""); //lyh *ioapic_sba=3; //lyh dword=*ioapic_sbd; //lyh printk_debug("Southbridge apic DT = %x\n",dword); //lyh if(dword!=1) - //lyh for(;;); + //lyh die(""); }

1 0

[patch]:Skip VC1 to fix dbm690t hanging
by Bao, Zheng June 5, 2009

June 5, 2009

After I modify the pci_ext_read_config32 and pci_ext_read_config32, the step 6a starts to play its role. Then the system hangs at HDA init. I dont know what the VC1 is. The RPR says "Optional Features (only needed if CMOS option is enabled)" in 5.10.2. Before I know what it is, I think it is better to skip it. Tested on dbm690t. Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> -------------------- Index: src/southbridge/amd/rs690/rs690_pcie.c =================================================================== --- src/southbridge/amd/rs690/rs690_pcie.c (revision 4338) +++ src/southbridge/amd/rs690/rs690_pcie.c (working copy) @@ -276,6 +276,7 @@ /* step 6a: VCI */ sb_dev = dev_find_slot(0, PCI_DEVFN(8, 0)); if (port == 8) { +#if 0 /* Clear bits 7:1 */ pci_ext_write_config32(nb_dev, sb_dev, 0x114, 0x3f << 1, 0 << 1); /* Maps Traffic Class 1-7 to VC1 */ @@ -284,7 +285,7 @@ pci_ext_write_config32(nb_dev, sb_dev, 0x120, 7 << 24, 1 << 24); /* Enables VC1 */ pci_ext_write_config32(nb_dev, sb_dev, 0x120, 1 << 31, 1 << 31); -#if 0 + do { reg16 = pci_ext_read_config32(nb_dev, sb_dev, 0x124); reg16 &= 0x2;

3 4

[v2] r4339 - trunk/coreboot-v2/src/southbridge/amd/rs690
by svn＠coreboot.org June 5, 2009

June 5, 2009

Author: zbao Date: 2009-06-05 12:00:07 +0200 (Fri, 05 Jun 2009) New Revision: 4339 Modified: trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c Log: After I modify the pci_ext_read_config32 and pci_ext_read_config32, the step 6a starts to play its role. Then the system hangs at HDA init. I dont know what the VC1 is. The RPR says "Optional Features (only needed if CMOS option is enabled)" in 5.10.2. Before I know what it is, I think it is better to skip it. Tested on dbm690t. Add comment from Rudolf, " VC is virtual channel. Its used for isochronous transfer of data to sound card. The virtual channel guarantee "on time" delivery. In other words it sets up a channel for data to sound card, which means that that arrivs in time and there will be no interuptions in audio stream. http://www.microsoft.com/whdc/connect/pci/wlp_interrupt.mspx " Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c =================================================================== --- trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c 2009-06-05 00:22:25 UTC (rev 4338) +++ trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c 2009-06-05 10:00:07 UTC (rev 4339) @@ -276,6 +276,9 @@ /* step 6a: VCI */ sb_dev = dev_find_slot(0, PCI_DEVFN(8, 0)); if (port == 8) { + /* The code below between #if and #endif causes a hang on HDA init. + * So we skip it. */ +#if 0 /* Clear bits 7:1 */ pci_ext_write_config32(nb_dev, sb_dev, 0x114, 0x3f << 1, 0 << 1); /* Maps Traffic Class 1-7 to VC1 */ @@ -284,7 +287,7 @@ pci_ext_write_config32(nb_dev, sb_dev, 0x120, 7 << 24, 1 << 24); /* Enables VC1 */ pci_ext_write_config32(nb_dev, sb_dev, 0x120, 1 << 31, 1 << 31); -#if 0 + do { reg16 = pci_ext_read_config32(nb_dev, sb_dev, 0x124); reg16 &= 0x2;

1 0

[flashrom] [patch] Some exact bustypes
by Urja Rannikko June 5, 2009

June 5, 2009

Exact bustypes for Atmel AT29C010A, AT29C020, AT29C040A, AT49BV512, AT49F002, AMIC A29040B, A49LF040A, EMST F49B002UA, EON EN29F002, Intel 28F001BX-B, 28F001BX-T, Winbond W29C020C and W29C040P. Checked from datasheets. A49LF040A is LPC, others parallel. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- patch also inlined: Index: flashchips.c =================================================================== --- flashchips.c (revision 558) +++ flashchips.c (working copy) @@ -401,7 +401,7 @@ { .vendor = "Atmel", .name = "AT29C010A", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = ATMEL_ID, .model_id = AT_29C010A, .total_size = 128, @@ -416,7 +416,7 @@ { .vendor = "Atmel", .name = "AT29C020", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = ATMEL_ID, .model_id = AT_29C020, .total_size = 256, @@ -431,7 +431,7 @@ { .vendor = "Atmel", .name = "AT29C040A", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = ATMEL_ID, .model_id = AT_29C040A, .total_size = 512, @@ -581,7 +581,7 @@ { .vendor = "Atmel", .name = "AT49BV512", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = ATMEL_ID, .model_id = AT_49BV512, .total_size = 64, @@ -596,7 +596,7 @@ { .vendor = "Atmel", .name = "AT49F002(N)", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = ATMEL_ID, .model_id = AT_49F002N, .total_size = 256, @@ -611,7 +611,7 @@ { .vendor = "Atmel", .name = "AT49F002(N)T", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = ATMEL_ID, .model_id = AT_49F002NT, .total_size = 256, @@ -671,7 +671,7 @@ { .vendor = "AMIC", .name = "A29040B", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = AMIC_ID_NOPREFIX, .model_id = AMIC_A29040B, .total_size = 512, @@ -686,7 +686,7 @@ { .vendor = "AMIC", .name = "A49LF040A", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_LPC, .manufacture_id = AMIC_ID_NOPREFIX, .model_id = AMIC_A49LF040A, .total_size = 512, @@ -701,7 +701,7 @@ { .vendor = "EMST", .name = "F49B002UA", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = EMST_ID, .model_id = EMST_F49B002UA, .total_size = 256, @@ -716,7 +716,7 @@ { .vendor = "EON", .name = "EN29F002(A)(N)B", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = EON_ID, .model_id = EN_29F002B, .total_size = 256, @@ -731,7 +731,7 @@ { .vendor = "EON", .name = "EN29F002(A)(N)T", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = EON_ID, .model_id = EN_29F002T, .total_size = 256, @@ -806,7 +806,7 @@ { .vendor = "Intel", .name = "28F001BX-B", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = INTEL_ID, .model_id = P28F001BXB, .total_size = 128, @@ -821,7 +821,7 @@ { .vendor = "Intel", .name = "28F001BX-T", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = INTEL_ID, .model_id = P28F001BXT, .total_size = 128, @@ -2336,7 +2336,7 @@ { .vendor = "Winbond", .name = "W29C020C", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = WINBOND_ID, .model_id = W_29C020C, .total_size = 256, @@ -2351,7 +2351,7 @@ { .vendor = "Winbond", .name = "W29C040P", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_PARALLEL, .manufacture_id = WINBOND_ID, .model_id = W_29C040P, .total_size = 512, -- urjaman

2 1