coreboot June 2009

coreboot@coreboot.org

84 participants
500 discussions

[v2] r4356 - trunk/util/superiotool
by svn＠coreboot.org 12 Jun '09

12 Jun '09

Author: uwe Date: 2009-06-12 16:20:27 +0200 (Fri, 12 Jun 2009) New Revision: 4356 Modified: trunk/util/superiotool/winbond.c Log: Fix typo in Winbond W83977TF register listing. Signed-off-by: Ioannis Barkas <tripl3fault(a)yahoo.com> Signed-off-by: Nikos Barkas <levelwol(a)gmail.com> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/util/superiotool/winbond.c =================================================================== --- trunk/util/superiotool/winbond.c 2009-06-11 18:27:41 UTC (rev 4355) +++ trunk/util/superiotool/winbond.c 2009-06-12 14:20:27 UTC (rev 4356) @@ -285,7 +285,7 @@ 0x01,0x01,0x01,0x01,0x01,0x01,0x01,0x00,EOT}}, {0xa, "ACPI", {0x30,0x60,0x61,0x62,0x63,0x64,0x65,0x70,0xe0,0xe1, - 0x02,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6, + 0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6, 0xf7,0xfe,0xff,EOT}, {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, NANA,MISC,RSVD,0x00,0x00,0x00,0x00,0x00,0x00,0x00,

1 0

[PATCH] flashrom: Add missing GPL headers
by Uwe Hermann 12 Jun '09

12 Jun '09

See patch. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

1 1

[flashrom] r586 - trunk
by svn＠coreboot.org 12 Jun '09

12 Jun '09

Author: uwe Date: 2009-06-12 16:05:25 +0200 (Fri, 12 Jun 2009) New Revision: 586 Modified: trunk/Makefile trunk/coreboot_tables.h Log: Add missing GPL headers to two files. Please complain in case there are errors here, but I'm pretty sure the headers are correct. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/Makefile =================================================================== --- trunk/Makefile 2009-06-12 14:02:07 UTC (rev 585) +++ trunk/Makefile 2009-06-12 14:05:25 UTC (rev 586) @@ -1,8 +1,21 @@ # -# Makefile for flashrom utility -# -# redone by Stefan Reinauer <stepan(a)openbios.org> +# This file is part of the flashrom project. # +# Copyright (C) 2005 coresystems GmbH <stepan(a)coresystems.de> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# PROGRAM = flashrom Modified: trunk/coreboot_tables.h =================================================================== --- trunk/coreboot_tables.h 2009-06-12 14:02:07 UTC (rev 585) +++ trunk/coreboot_tables.h 2009-06-12 14:05:25 UTC (rev 586) @@ -1,3 +1,24 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2002 Linux Networx + * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) + * Copyright (C) 2005-2007 coresystems GmbH + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA, 02110-1301 USA + */ + #ifndef COREBOOT_TABLES_H #define COREBOOT_TABLES_H

1 0

[flashrom] r585 - trunk
by svn＠coreboot.org 12 Jun '09

12 Jun '09

Author: hailfinger Date: 2009-06-12 16:02:07 +0200 (Fri, 12 Jun 2009) New Revision: 585 Modified: trunk/flashrom.8 trunk/flashrom.c Log: flashrom does not honor argument ordering for operations. Not only does this violate the principle of least surprise, it also caused one bug where -Ewv was specified and the flash ended up being empty. Support only one operation at a time. As a side benefit, this allows us to clean up main() quite a bit. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/flashrom.8 =================================================================== --- trunk/flashrom.8 2009-06-12 11:45:10 UTC (rev 584) +++ trunk/flashrom.8 2009-06-12 14:02:07 UTC (rev 585) @@ -2,7 +2,7 @@ .SH NAME flashrom \- detect, read, write, verify and erase flash chips .SH SYNOPSIS -.B flashrom \fR[\fB\-EVfLhR\fR] [\fB\-r\fR file] [\fB\-w\fR file] [\fB\-v\fR file] +.B flashrom \fR[\fB\-VfLhR\fR] [\fB\-E\fR|\fB\-r\fR file|\fB\-w\fR file|\fB\-v\fR file] [\fB\-c\fR chipname] [\fB\-s\fR addr] [\fB\-e\fR addr] [\fB\-m\fR [vendor:]part] [\fB\-l\fR file] [\fB\-i\fR image] [\fB\-p\fR programmer] [file] .SH DESCRIPTION @@ -25,7 +25,8 @@ flashrom 1.0. Do not use flashrom in scripts or other automated tools without checking that your flashrom version won't interpret options in a different way. .PP -If no file is specified, then all that happens +You can specify one of -E, -r, -w, -v or no operation. +If no operation is specified, then all that happens is that flash info is dumped and the flash chip is set to writable. .TP .B "\-r, \-\-read <file>" Modified: trunk/flashrom.c =================================================================== --- trunk/flashrom.c 2009-06-12 11:45:10 UTC (rev 584) +++ trunk/flashrom.c 2009-06-12 14:02:07 UTC (rev 585) @@ -471,7 +471,7 @@ void usage(const char *name) { - printf("usage: %s [-EVfLhR] [-r file] [-w file] [-v file] [-c chipname] [-s addr]\n" + printf("usage: %s [-VfLhR] [-E|-r file|-w file|-v file] [-c chipname] [-s addr]\n" " [-e addr] [-m [vendor:]part] [-l file] [-i image] [-p programmer] [file]\n\n", name); @@ -498,7 +498,8 @@ " (internal, dummy, nic3com, satasii, it87spi)\n" " -h | --help: print this help text\n" " -R | --version: print the version (release)\n" - "\nIf no file is specified, then all that happens" + "\nYou can specify one of -E, -r, -w, -v or no operation.\n" + "If no operation is specified, then all that happens" " is that flash info is dumped.\n\n"); exit(1); } @@ -520,6 +521,7 @@ int force = 0; int read_it = 0, write_it = 0, erase_it = 0, verify_it = 0; int list_supported = 0; + int operation_specified = 0; int ret = 0, i; static struct option long_options[] = { @@ -562,12 +564,27 @@ long_options, &option_index)) != EOF) { switch (opt) { case 'r': + if (++operation_specified > 1) { + fprintf(stderr, "More than one operation " + "specified. Aborting.\n"); + exit(1); + } read_it = 1; break; case 'w': + if (++operation_specified > 1) { + fprintf(stderr, "More than one operation " + "specified. Aborting.\n"); + exit(1); + } write_it = 1; break; case 'v': + if (++operation_specified > 1) { + fprintf(stderr, "More than one operation " + "specified. Aborting.\n"); + exit(1); + } verify_it = 1; break; case 'c': @@ -577,6 +594,11 @@ verbose = 1; break; case 'E': + if (++operation_specified > 1) { + fprintf(stderr, "More than one operation " + "specified. Aborting.\n"); + exit(1); + } erase_it = 1; break; case 's':

1 0

i810 Mode Register Bits shifted?
by Joseph Smith 12 Jun '09

12 Jun '09

Hello, This may be a dumb question that has already been answered but I can't seem to find the answer. Why are the Mode Register bits shifted 3 bits to the left??? I don't see anywhere in the i810 datasheet that says they need to do this? -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

1 0

[flashrom] r584 - trunk
by svn＠coreboot.org 12 Jun '09

12 Jun '09

Author: hailfinger Date: 2009-06-12 13:45:10 +0200 (Fri, 12 Jun 2009) New Revision: 584 Modified: trunk/flash.h trunk/flashchips.c Log: Add #defines for some flash chips. Add timing info to some flash chips. Signed-off-by: Mateusz Murawski <matowy(a)tlen.pl> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flash.h =================================================================== --- trunk/flash.h 2009-06-12 08:10:33 UTC (rev 583) +++ trunk/flash.h 2009-06-12 11:45:10 UTC (rev 584) @@ -385,6 +385,8 @@ #define IM_29F004T 0xAF #define INTEL_ID 0x89 /* Intel */ +#define I_82802AB 0xAD +#define I_82802AC 0xAC #define P28F001BXT 0x94 /* 28F001BX-T */ #define P28F001BXB 0x95 /* 28F001BX-B */ @@ -503,7 +505,7 @@ #define SST_29EE512 0x5D #define SST_29EE010 0x07 #define SST_29LE010 0x08 /* also SST29VE010 */ -#define SST_29EE020A 0x10 +#define SST_29EE020A 0x10 /* also SST29EE020 */ #define SST_29LE020 0x12 /* also SST29VE020 */ #define SST_29SF020 0x24 #define SST_29VF020 0x25 @@ -516,6 +518,7 @@ #define SST_39VF010 0xD5 #define SST_39VF020 0xD6 #define SST_39VF040 0xD7 +#define SST_39VF080 0xD8 #define SST_49LF040B 0x50 #define SST_49LF040 0x51 #define SST_49LF020 0x61 @@ -545,6 +548,11 @@ #define ST_M25P32 0x2016 #define ST_M25P64 0x2017 #define ST_M25P128 0x2018 +#define ST_M25PE10 0x8011 +#define ST_M25PE20 0x8012 +#define ST_M25PE40 0x8013 +#define ST_M25PE80 0x8014 +#define ST_M25PE16 0x8015 #define ST_M50FLW040A 0x08 #define ST_M50FLW040B 0x28 #define ST_M50FLW080A 0x80 @@ -592,6 +600,7 @@ #define W_39V040FA 0x34 #define W_39V040A 0x3D #define W_39V040B 0x54 +#define W_39V040C 0x50 #define W_39V080A 0xD0 #define W_39V080FA 0xD3 #define W_39V080FA_DM 0x93 Modified: trunk/flashchips.c =================================================================== --- trunk/flashchips.c 2009-06-12 08:10:33 UTC (rev 583) +++ trunk/flashchips.c 2009-06-12 11:45:10 UTC (rev 584) @@ -1083,9 +1083,9 @@ { .vendor = "Intel", .name = "82802AB", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_FWH, .manufacture_id = INTEL_ID, - .model_id = 173, + .model_id = I_82802AB, .total_size = 512, .page_size = 64 * 1024, .tested = TEST_OK_PREW, @@ -1099,9 +1099,9 @@ { .vendor = "Intel", .name = "82802AC", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_FWH, .manufacture_id = INTEL_ID, - .model_id = 172, + .model_id = I_82802AC, .total_size = 1024, .page_size = 64 * 1024, .tested = TEST_OK_PREW, @@ -1341,7 +1341,7 @@ .name = "M25PE10", .bustype = CHIP_BUSTYPE_SPI, .manufacture_id = ST_ID, - .model_id = 0x8011, + .model_id = ST_M25PE10, .total_size = 128, .page_size = 256, .tested = TEST_UNTESTED, @@ -1357,7 +1357,7 @@ .name = "M25PE20", .bustype = CHIP_BUSTYPE_SPI, .manufacture_id = ST_ID, - .model_id = 0x8012, + .model_id = ST_M25PE20, .total_size = 256, .page_size = 256, .tested = TEST_UNTESTED, @@ -1373,7 +1373,7 @@ .name = "M25PE40", .bustype = CHIP_BUSTYPE_SPI, .manufacture_id = ST_ID, - .model_id = 0x8013, + .model_id = ST_M25PE40, .total_size = 256, .page_size = 256, .tested = TEST_UNTESTED, @@ -1389,7 +1389,7 @@ .name = "M25PE80", .bustype = CHIP_BUSTYPE_SPI, .manufacture_id = ST_ID, - .model_id = 0x8014, + .model_id = ST_M25PE80, .total_size = 1024, .page_size = 256, .tested = TEST_OK_PREW, @@ -1405,7 +1405,7 @@ .name = "M25PE16", .bustype = CHIP_BUSTYPE_SPI, .manufacture_id = ST_ID, - .model_id = 0x8015, + .model_id = ST_M25PE16, .total_size = 2048, .page_size = 256, .tested = TEST_UNTESTED, @@ -1644,8 +1644,8 @@ .vendor = "SST", .name = "SST25VF040.REMS", .bustype = CHIP_BUSTYPE_SPI, - .manufacture_id = 0xbf, - .model_id = 0x44, + .manufacture_id = SST_ID, + .model_id = SST_25VF040_REMS, .total_size = 512, .page_size = 64*1024, .tested = TEST_OK_PR, @@ -1660,8 +1660,8 @@ .vendor = "SST", .name = "SST25VF040B.REMS", .bustype = CHIP_BUSTYPE_SPI, - .manufacture_id = 0xbf, - .model_id = 0x8d, + .manufacture_id = SST_ID, + .model_id = SST_25VF040B_REMS, .total_size = 512, .page_size = 64*1024, .tested = TEST_OK_PR, @@ -1714,7 +1714,7 @@ .page_size = 128, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 10, .erase = erase_chip_jedec, .write = write_jedec, .read = read_memmapped, @@ -1730,7 +1730,7 @@ .page_size = 128, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 10, .erase = erase_chip_jedec, .write = write_jedec, .read = read_memmapped, @@ -1762,7 +1762,7 @@ .page_size = 128, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 10, .erase = erase_chip_jedec, .write = write_jedec, .read = read_memmapped, @@ -1778,7 +1778,7 @@ .page_size = 4096, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -1794,7 +1794,7 @@ .page_size = 4096, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -1810,7 +1810,7 @@ .page_size = 4096, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -1826,7 +1826,7 @@ .page_size = 4096, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns*/ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -1842,7 +1842,7 @@ .page_size = 4096, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -1858,7 +1858,7 @@ .page_size = 4096, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -1874,7 +1874,7 @@ .page_size = 4096, .tested = TEST_OK_PROBE, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -1884,13 +1884,13 @@ .vendor = "SST", .name = "SST39VF080", .bustype = CHIP_BUSTYPE_NONSPI, - .manufacture_id = 0xbf, - .model_id = 0xd8, + .manufacture_id = SST_ID, + .model_id = SST_39VF080, .total_size = 1024, .page_size = 4096, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_chip_jedec, .write = write_49f002, .read = read_memmapped, @@ -2011,14 +2011,14 @@ { .vendor = "SST", .name = "SST49LF020", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_LPC, .manufacture_id = SST_ID, .model_id = SST_49LF020, .total_size = 256, .page_size = 16 * 1024, .tested = TEST_OK_PR, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_49lf040, .write = write_49lf040, .read = read_memmapped, @@ -2027,14 +2027,14 @@ { .vendor = "SST", .name = "SST49LF020A", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_LPC, .manufacture_id = SST_ID, .model_id = SST_49LF020A, .total_size = 256, .page_size = 16 * 1024, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_49lf040, .write = write_49lf040, .read = read_memmapped, @@ -2043,14 +2043,14 @@ { .vendor = "SST", .name = "SST49LF040", - .bustype = CHIP_BUSTYPE_NONSPI, + .bustype = CHIP_BUSTYPE_LPC, .manufacture_id = SST_ID, .model_id = SST_49LF040, .total_size = 512, .page_size = 4096, .tested = TEST_OK_PREW, .probe = probe_jedec, - .probe_timing = TIMING_FIXME, + .probe_timing = 1, /* 150 ns */ .erase = erase_49lf040, .write = write_49lf040, .read = read_memmapped, @@ -2765,7 +2765,7 @@ .name = "W39V040C", .bustype = CHIP_BUSTYPE_NONSPI, .manufacture_id = WINBOND_ID, - .model_id = 0x50, + .model_id = W_39V040C, .total_size = 512, .page_size = 64*1024, .tested = TEST_OK_PREW,

1 0

[flashrom] r583 - trunk
by svn＠coreboot.org 12 Jun '09

12 Jun '09

Author: hailfinger Date: 2009-06-12 10:10:33 +0200 (Fri, 12 Jun 2009) New Revision: 583 Modified: trunk/flash.h trunk/spi.c Log: Add spi_nbyte_program as generic function to the SPI layer. Signed-off-by: Paul Fox <pgf(a)laptop.org> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flash.h =================================================================== --- trunk/flash.h 2009-06-12 08:04:08 UTC (rev 582) +++ trunk/flash.h 2009-06-12 08:10:33 UTC (rev 583) @@ -757,6 +757,7 @@ uint8_t spi_read_status_register(void); int spi_disable_blockprotect(void); void spi_byte_program(int address, uint8_t byte); +int spi_nbyte_program(int address, uint8_t *bytes, int len); int spi_nbyte_read(int address, uint8_t *bytes, int len); int spi_aai_write(struct flashchip *flash, uint8_t *buf); uint32_t spi_get_valid_read_addr(void); Modified: trunk/spi.c =================================================================== --- trunk/spi.c 2009-06-12 08:04:08 UTC (rev 582) +++ trunk/spi.c 2009-06-12 08:10:33 UTC (rev 583) @@ -616,6 +616,27 @@ spi_command(sizeof(cmd), 0, cmd, NULL); } +int spi_nbyte_program(int address, uint8_t *bytes, int len) +{ + unsigned char cmd[JEDEC_BYTE_PROGRAM_OUTSIZE - 1 + 256] = { + JEDEC_BYTE_PROGRAM, + (address >> 16) & 0xff, + (address >> 8) & 0xff, + (address >> 0) & 0xff, + }; + + if (len > 256) { + printf_debug ("%s called for too long a write\n", + __FUNCTION__); + return 1; + } + + memcpy(&cmd[4], bytes, len); + + /* Send Byte-Program */ + return spi_command(4 + len, 0, cmd, NULL); +} + int spi_disable_blockprotect(void) { uint8_t status;

1 0

[flashrom] r582 - trunk
by svn＠coreboot.org 12 Jun '09

12 Jun '09

Author: hailfinger Date: 2009-06-12 10:04:08 +0200 (Fri, 12 Jun 2009) New Revision: 582 Modified: trunk/flashrom.c Log: Tell the user about the beginning and end of the write operation. Signed-off-by: Paul Fox <pgf(a)laptop.org> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flashrom.c =================================================================== --- trunk/flashrom.c 2009-06-09 18:29:30 UTC (rev 581) +++ trunk/flashrom.c 2009-06-12 08:04:08 UTC (rev 582) @@ -820,11 +820,13 @@ // //////////////////////////////////////////////////////////// if (write_it) { + printf("Writing flash chip... "); if (!flash->write) { fprintf(stderr, "Error: flashrom has no write function for this flash chip.\n"); return 1; } ret |= flash->write(flash, buf); + if (!ret) printf("COMPLETE.\n"); } if (verify_it)

1 0

build service results for r4355
by coreboot information 11 Jun '09

11 Jun '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "myles" checked in revision 4355 to the coreboot repository. This caused the following changes: Change Log: Fix s2895 failover booting. Abuild tested and boot tested on s2895 and serengeti_cheetah. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Build Log: Compilation of via:epia-m700 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4355&device=epia-m700&vend… If something broke during this checkin please be a pain in myles's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

write/verify bug
by Paul Fox 11 Jun '09

11 Jun '09

hi -- i'm working on a spi programmer based on the ft4232h USB-to-{serial/spi/jtag} converter from FTDI. i'll be sending an initial implementation to the list later this afternoon. i scratched my head for a while yesterday when my programmer was suddenly bulk-clearing the flash part, when it had been programming successfully just hours earlier. it turned out (to my relief :-) that it was an existing bug in flashrom. given the way the options are parsed, i expected to be able to run "flashrom -Ewv myfile.img" and have the chip erased, written, and verified in one pass. this doesn't currently work, and in fact, will zero the chip without telling you, and then tell you that the operation succeeded. much hilarity ensues. :-) because of the else-if at line 767, specifying -E along -w bypasses the file open and read, leaving buf[] empty. the chip will then be programmed with nulls. worse, if -v is also used, it will verify correctly. with this patch (which also makes the usage message match the actual arg parsing) the above command invocation now works correctly. (for real robustness, the verify step should probably re-read the file, in case one of the many worker routines accidentally writes to the buffer. but that's a different patch..) paul =--------------------- paul fox, pgf(a)foxharp.boston.ma.us (arlington, ma, where it's 53.4 degrees) Signed-off-by: Paul Fox <pgf(a)foxharp.boston.ma.us> Index: flashrom.c =================================================================== --- flashrom.c (revision 581) +++ flashrom.c (working copy) @@ -471,7 +471,7 @@ void usage(const char *name) { - printf("usage: %s [-EVfLhR] [-r file] [-w file] [-v file] [-c chipname] [-s addr]\n" + printf("usage: %s [-EVfLhR] [-r] [-w] [-v] [-c chipname] [-s addr]\n" " [-e addr] [-m [vendor:]part] [-l file] [-i image] [-p programmer] [file]\n\n", name); @@ -498,6 +498,7 @@ " (internal, dummy, nic3com, satasii, it87spi)\n" " -h | --help: print this help text\n" " -R | --version: print the version (release)\n" + "\nThe specified file is used by -r, -w, and -v." "\nIf no file is specified, then all that happens" " is that flash info is dumped.\n\n"); exit(1); @@ -764,7 +765,8 @@ if (erase_it) { if (erase_flash(flash)) return 1; - } else if (read_it) { + } + if (read_it) { if (read_flash(flash, filename, exclude_start_position, exclude_end_position)) return 1; } else {

1 0

← Newer
1
...
32
33
34
35
36
37
38
...
50
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot June 2009