coreboot June 2009

coreboot@coreboot.org

84 participants
500 discussions

[flashrom][PATCH] invalid local variable declaration
by stephan.guilloux＠free.fr 23 Jun '09

23 Jun '09

Hello all, To start teh day, a small patch for an invalid local variable... In C, local variable must be declared before any statment, and not, like in C++ in the middle of the function. Make good use of it. Regards, Stephan. Signed-off-by: Stephan Guilloux <stephan.guilloux(a)free.fr> diff -rc flashrom-623/physmap.c flashrom-623.new/physmap.c *** flashrom-623/physmap.c Tue Jun 23 07:28:15 2009 --- flashrom-623.new/physmap.c Tue Jun 23 09:46:01 2009 *************** *** 80,85 **** --- 80,87 ---- void *physmap(const char *descr, unsigned long phys_addr, size_t len) { + void *virt_addr; + if (len == 0) { printf_debug("Not mapping %s, zero size at 0x%08lx.\n", descr, phys_addr); *************** *** 96,102 **** descr, (unsigned long)len, phys_addr); } ! void *virt_addr = sys_physmap(phys_addr, len); if (NULL == virt_addr) { if (NULL == descr) --- 98,104 ---- descr, (unsigned long)len, phys_addr); } ! virt_addr = sys_physmap(phys_addr, len); if (NULL == virt_addr) { if (NULL == descr)

5 10

flashrom: Gigabyte GA-EP35-DS3L test report
by Alexander Gordeev 23 Jun '09

23 Jun '09

Hi all! I've tested Gigabyte GA-EP35-DS3L board (http://www.gigabyte.com.tw/Products/Motherboard/Products_Overview.aspx?Prod…) and it is supported by flashrom out of the box: flashrom v0.9.0+r544 No coreboot table found. Found chipset "Intel ICH9", enabling flash write... OK. Calibrating delay loop... OK. Found chip "Macronix MX25L8005" (1024 KB) at physical address 0xfff00000. No operations were specified. I've tested all the operations and rebooted to a new BIOS and everything is ok so far. I'll be happy to provide any additional information so please feel free to ask! -- Alexander

2 2

[PATCH] Stop build if coreboot.rom.bootblock is larger than the area allocated to the bootblock
by Patrick Georgi 23 Jun '09

23 Jun '09

Hi, attached patch fixes an oversight in cbfstool related to bootblock handling. With this patch, cbfstool reacts to a too large bootblock file by stopping with an error code. Before, it did "whatever" (besides printing a warning). Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Index: util/cbfstool/util.c =================================================================== --- util/cbfstool/util.c (revision 4328) +++ util/cbfstool/util.c (working copy) @@ -222,7 +222,8 @@ rom->header->align = htonl(align); rom->header->offset = htonl(0); - add_bootblock(rom, bootblockname); + if (add_bootblock(rom, bootblockname) == -1) + return -1; /* Write the cbfs master header address at the end of the ROM. */

3 2

[PATCH] flashrom: Clean up Makefile
by Carl-Daniel Hailfinger 23 Jun '09

23 Jun '09

The akefile rules for %.o and flashrom.o are identical. Let %.o handle flashrom.o as well. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-makefile_cleanup/Makefile =================================================================== --- flashrom-makefile_cleanup/Makefile (Revision 624) +++ flashrom-makefile_cleanup/Makefile (Arbeitskopie) @@ -70,11 +70,8 @@ FEATURE_LIBS = $(shell LANG=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-lftdi") -flashrom.o: flashrom.c .features - $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c -o $@ $< $(SVNDEF) - %.o: %.c .features - $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c $< -o $@ $(SVNDEF) + $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $< clean: rm -f $(PROGRAM) *.o -- http://www.hailfinger.org/ Index: flashrom-makefile_cleanup/Makefile =================================================================== --- flashrom-makefile_cleanup/Makefile (Revision 624) +++ flashrom-makefile_cleanup/Makefile (Arbeitskopie) @@ -70,11 +70,8 @@ FEATURE_LIBS = $(shell LANG=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-lftdi") -flashrom.o: flashrom.c .features - $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c -o $@ $< $(SVNDEF) - %.o: %.c .features - $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c $< -o $@ $(SVNDEF) + $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $< clean: rm -f $(PROGRAM) *.o

2 3

[PATCH] flashrom: Stubs for TotalPhase Cheetah SPI programmer
by Carl-Daniel Hailfinger 23 Jun '09

23 Jun '09

Add stubs for the TotalPhase Cheetah SPI programmer. The programmer code is not finished yet, but the glue code is extremely painful to carry forward especially because these areas in flash.h, flashrom.c, flashrom.8 and Makefile are touched each time someone adds another external programmer to the tree. Having the glue code in reduces conflict resolution time to zero for me. That's also the reason I committed a stubbed version of Urja's serial flasher patch. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-cheetah/flashrom.8 =================================================================== --- flashrom-cheetah/flashrom.8 (Revision 626) +++ flashrom-cheetah/flashrom.8 (Arbeitskopie) @@ -138,6 +138,8 @@ .sp .BR "* ft2232spi" " (for flash ROMs attached to a FT2232H/FT4232H based USB SPI programmer)" .sp +.BR "* cheetah" " (for flash ROMs attached to a TotalPhase Cheetah SPI programmer)" +.sp The dummy programmer has an optional parameter specifying the bus types it should support. For that you have to use the .B "flashrom -p dummy=type" Index: flashrom-cheetah/flash.h =================================================================== --- flashrom-cheetah/flash.h (Revision 626) +++ flashrom-cheetah/flash.h (Arbeitskopie) @@ -88,6 +88,7 @@ #define PROGRAMMER_IT87SPI 0x04 #define PROGRAMMER_FT2232SPI 0x05 #define PROGRAMMER_SERPROG 0x06 +#define PROGRAMMER_CHEETAH 0x07 struct programmer_entry { const char *vendor; @@ -374,6 +375,14 @@ int ft2232_spi_write1(struct flashchip *flash, uint8_t *buf); int ft2232_spi_write_256(struct flashchip *flash, uint8_t *buf); +/* cheetah.c */ +int cheetah_spi_init(void); +int cheetah_spi_shutdown(void); +int cheetah_spi_command(unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr); +int cheetah_spi_write_256(struct flashchip *flash, uint8_t *buf); +int cheetah_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len); + /* flashrom.c */ extern int verbose; #define printf_debug(x...) { if (verbose) printf(x); } @@ -409,6 +418,7 @@ SPI_CONTROLLER_VIA, SPI_CONTROLLER_WBSIO, SPI_CONTROLLER_FT2232, + SPI_CONTROLLER_CHEETAH, SPI_CONTROLLER_DUMMY, }; extern enum spi_controller spi_controller; Index: flashrom-cheetah/spi.c =================================================================== --- flashrom-cheetah/spi.c (Revision 626) +++ flashrom-cheetah/spi.c (Arbeitskopie) @@ -49,6 +49,8 @@ return wbsio_spi_command(writecnt, readcnt, writearr, readarr); case SPI_CONTROLLER_FT2232: return ft2232_spi_command(writecnt, readcnt, writearr, readarr); + case SPI_CONTROLLER_CHEETAH: + return cheetah_spi_command(writecnt, readcnt, writearr, readarr); case SPI_CONTROLLER_DUMMY: return dummy_spi_command(writecnt, readcnt, writearr, readarr); default: @@ -215,6 +217,7 @@ case SPI_CONTROLLER_SB600: case SPI_CONTROLLER_WBSIO: case SPI_CONTROLLER_FT2232: + case SPI_CONTROLLER_CHEETAH: case SPI_CONTROLLER_DUMMY: return probe_spi_rdid_generic(flash, 4); default: @@ -731,6 +734,8 @@ return wbsio_spi_read(flash, buf, start, len); case SPI_CONTROLLER_FT2232: return ft2232_spi_read(flash, buf, start, len); + case SPI_CONTROLLER_CHEETAH: + return cheetah_spi_read(flash, buf, start, len); default: printf_debug ("%s called, but no SPI chipset/strapping detected\n", @@ -781,6 +786,8 @@ return wbsio_spi_write_1(flash, buf); case SPI_CONTROLLER_FT2232: return ft2232_spi_write_256(flash, buf); + case SPI_CONTROLLER_CHEETAH: + return cheetah_spi_write_256(flash, buf); default: printf_debug ("%s called, but no SPI chipset/strapping detected\n", Index: flashrom-cheetah/Makefile =================================================================== --- flashrom-cheetah/Makefile (Revision 626) +++ flashrom-cheetah/Makefile (Arbeitskopie) @@ -50,7 +50,7 @@ flashrom.o w39v080fa.o sharplhf00l04.o w29ee011.o spi.o it87spi.o \ ichspi.o w39v040c.o sb600spi.o wbsio_spi.o m29f002.o internal.o \ dummyflasher.o pcidev.o nic3com.o satasii.o ft2232_spi.o serprog.o \ - print.o + print.o cheetah.o all: pciutils features dep $(PROGRAM) Index: flashrom-cheetah/cheetah.c =================================================================== --- flashrom-cheetah/cheetah.c (Revision 0) +++ flashrom-cheetah/cheetah.c (Revision 0) @@ -0,0 +1,65 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2009 Carl-Daniel Hailfinger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * As a special exception, you may also incorporate this code into programs + * licensed under later versions of the GNU GPL provided your changes to + * this code are made available under the same conditions as the original code. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <string.h> +#include <stdlib.h> +#include "flash.h" + + +#define CHEETAH_SPI_SUPPORT 0 + +#if CHEETAH_SPI_SUPPORT == 1 + +#else + +int cheetah_spi_shutdown(void) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_init(void) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_command(unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_write_256(struct flashchip *flash, uint8_t * buf) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +#endif Index: flashrom-cheetah/flashrom.c =================================================================== --- flashrom-cheetah/flashrom.c (Revision 626) +++ flashrom-cheetah/flashrom.c (Arbeitskopie) @@ -130,6 +130,7 @@ .chip_writen = fallback_chip_writen, .delay = internal_delay, }, + { .init = serprog_init, .shutdown = serprog_shutdown, @@ -146,6 +147,22 @@ .delay = serprog_delay, }, + { + .init = cheetah_spi_init, + .shutdown = cheetah_spi_shutdown, + .map_flash_region = dummy_map, + .unmap_flash_region = dummy_unmap, + .chip_readb = dummy_chip_readb, + .chip_readw = dummy_chip_readw, + .chip_readl = dummy_chip_readl, + .chip_readn = fallback_chip_readn, + .chip_writeb = dummy_chip_writeb, + .chip_writew = dummy_chip_writew, + .chip_writel = dummy_chip_writel, + .chip_writen = fallback_chip_writen, + .delay = internal_delay, + }, + {}, }; @@ -515,7 +532,7 @@ " -z | --list-supported-wiki: print supported devices in wiki syntax\n" " -p | --programmer <name>: specify the programmer device\n" " (internal, dummy, nic3com, satasii,\n" - " it87spi, ft2232spi, serprog)\n" + " it87spi, ft2232spi, serprog, cheetah)\n" " -h | --help: print this help text\n" " -R | --version: print the version (release)\n" "\nYou can specify one of -E, -r, -w, -v or no operation. " @@ -672,6 +689,8 @@ programmer = PROGRAMMER_SERPROG; if (optarg[7] == '=') serprog_param = strdup(optarg + 8); + } else if (strncmp(optarg, "cheetah", 7) == 0) { + programmer = PROGRAMMER_CHEETAH; } else { printf("Error: Unknown programmer.\n"); exit(1); -- http://www.hailfinger.org/ Index: flashrom-cheetah/flashrom.8 =================================================================== --- flashrom-cheetah/flashrom.8 (Revision 626) +++ flashrom-cheetah/flashrom.8 (Arbeitskopie) @@ -138,6 +138,8 @@ .sp .BR "* ft2232spi" " (for flash ROMs attached to a FT2232H/FT4232H based USB SPI programmer)" .sp +.BR "* cheetah" " (for flash ROMs attached to a TotalPhase Cheetah SPI programmer)" +.sp The dummy programmer has an optional parameter specifying the bus types it should support. For that you have to use the .B "flashrom -p dummy=type" Index: flashrom-cheetah/flash.h =================================================================== --- flashrom-cheetah/flash.h (Revision 626) +++ flashrom-cheetah/flash.h (Arbeitskopie) @@ -88,6 +88,7 @@ #define PROGRAMMER_IT87SPI 0x04 #define PROGRAMMER_FT2232SPI 0x05 #define PROGRAMMER_SERPROG 0x06 +#define PROGRAMMER_CHEETAH 0x07 struct programmer_entry { const char *vendor; @@ -374,6 +375,14 @@ int ft2232_spi_write1(struct flashchip *flash, uint8_t *buf); int ft2232_spi_write_256(struct flashchip *flash, uint8_t *buf); +/* cheetah.c */ +int cheetah_spi_init(void); +int cheetah_spi_shutdown(void); +int cheetah_spi_command(unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr); +int cheetah_spi_write_256(struct flashchip *flash, uint8_t *buf); +int cheetah_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len); + /* flashrom.c */ extern int verbose; #define printf_debug(x...) { if (verbose) printf(x); } @@ -409,6 +418,7 @@ SPI_CONTROLLER_VIA, SPI_CONTROLLER_WBSIO, SPI_CONTROLLER_FT2232, + SPI_CONTROLLER_CHEETAH, SPI_CONTROLLER_DUMMY, }; extern enum spi_controller spi_controller; Index: flashrom-cheetah/spi.c =================================================================== --- flashrom-cheetah/spi.c (Revision 626) +++ flashrom-cheetah/spi.c (Arbeitskopie) @@ -49,6 +49,8 @@ return wbsio_spi_command(writecnt, readcnt, writearr, readarr); case SPI_CONTROLLER_FT2232: return ft2232_spi_command(writecnt, readcnt, writearr, readarr); + case SPI_CONTROLLER_CHEETAH: + return cheetah_spi_command(writecnt, readcnt, writearr, readarr); case SPI_CONTROLLER_DUMMY: return dummy_spi_command(writecnt, readcnt, writearr, readarr); default: @@ -215,6 +217,7 @@ case SPI_CONTROLLER_SB600: case SPI_CONTROLLER_WBSIO: case SPI_CONTROLLER_FT2232: + case SPI_CONTROLLER_CHEETAH: case SPI_CONTROLLER_DUMMY: return probe_spi_rdid_generic(flash, 4); default: @@ -731,6 +734,8 @@ return wbsio_spi_read(flash, buf, start, len); case SPI_CONTROLLER_FT2232: return ft2232_spi_read(flash, buf, start, len); + case SPI_CONTROLLER_CHEETAH: + return cheetah_spi_read(flash, buf, start, len); default: printf_debug ("%s called, but no SPI chipset/strapping detected\n", @@ -781,6 +786,8 @@ return wbsio_spi_write_1(flash, buf); case SPI_CONTROLLER_FT2232: return ft2232_spi_write_256(flash, buf); + case SPI_CONTROLLER_CHEETAH: + return cheetah_spi_write_256(flash, buf); default: printf_debug ("%s called, but no SPI chipset/strapping detected\n", Index: flashrom-cheetah/Makefile =================================================================== --- flashrom-cheetah/Makefile (Revision 626) +++ flashrom-cheetah/Makefile (Arbeitskopie) @@ -50,7 +50,7 @@ flashrom.o w39v080fa.o sharplhf00l04.o w29ee011.o spi.o it87spi.o \ ichspi.o w39v040c.o sb600spi.o wbsio_spi.o m29f002.o internal.o \ dummyflasher.o pcidev.o nic3com.o satasii.o ft2232_spi.o serprog.o \ - print.o + print.o cheetah.o all: pciutils features dep $(PROGRAM) Index: flashrom-cheetah/cheetah.c =================================================================== --- flashrom-cheetah/cheetah.c (Revision 0) +++ flashrom-cheetah/cheetah.c (Revision 0) @@ -0,0 +1,65 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2009 Carl-Daniel Hailfinger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * As a special exception, you may also incorporate this code into programs + * licensed under later versions of the GNU GPL provided your changes to + * this code are made available under the same conditions as the original code. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <string.h> +#include <stdlib.h> +#include "flash.h" + + +#define CHEETAH_SPI_SUPPORT 0 + +#if CHEETAH_SPI_SUPPORT == 1 + +#else + +int cheetah_spi_shutdown(void) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_init(void) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_command(unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +int cheetah_spi_write_256(struct flashchip *flash, uint8_t * buf) +{ + fprintf(stderr, "Cheetah SPI support was not compiled in\n"); + exit(1); +} + +#endif Index: flashrom-cheetah/flashrom.c =================================================================== --- flashrom-cheetah/flashrom.c (Revision 626) +++ flashrom-cheetah/flashrom.c (Arbeitskopie) @@ -130,6 +130,7 @@ .chip_writen = fallback_chip_writen, .delay = internal_delay, }, + { .init = serprog_init, .shutdown = serprog_shutdown, @@ -146,6 +147,22 @@ .delay = serprog_delay, }, + { + .init = cheetah_spi_init, + .shutdown = cheetah_spi_shutdown, + .map_flash_region = dummy_map, + .unmap_flash_region = dummy_unmap, + .chip_readb = dummy_chip_readb, + .chip_readw = dummy_chip_readw, + .chip_readl = dummy_chip_readl, + .chip_readn = fallback_chip_readn, + .chip_writeb = dummy_chip_writeb, + .chip_writew = dummy_chip_writew, + .chip_writel = dummy_chip_writel, + .chip_writen = fallback_chip_writen, + .delay = internal_delay, + }, + {}, }; @@ -515,7 +532,7 @@ " -z | --list-supported-wiki: print supported devices in wiki syntax\n" " -p | --programmer <name>: specify the programmer device\n" " (internal, dummy, nic3com, satasii,\n" - " it87spi, ft2232spi, serprog)\n" + " it87spi, ft2232spi, serprog, cheetah)\n" " -h | --help: print this help text\n" " -R | --version: print the version (release)\n" "\nYou can specify one of -E, -r, -w, -v or no operation. " @@ -672,6 +689,8 @@ programmer = PROGRAMMER_SERPROG; if (optarg[7] == '=') serprog_param = strdup(optarg + 8); + } else if (strncmp(optarg, "cheetah", 7) == 0) { + programmer = PROGRAMMER_CHEETAH; } else { printf("Error: Unknown programmer.\n"); exit(1);

1 0

[flashrom] r626 - trunk
by svn＠coreboot.org 23 Jun '09

23 Jun '09

Author: hailfinger Date: 2009-06-23 13:48:37 +0200 (Tue, 23 Jun 2009) New Revision: 626 Modified: trunk/Makefile Log: The makefile rules for %.o and flashrom.o are identical. Let %.o handle flashrom.o as well. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Luc Verhaegen <libv(a)skynet.be> Modified: trunk/Makefile =================================================================== --- trunk/Makefile 2009-06-23 11:33:43 UTC (rev 625) +++ trunk/Makefile 2009-06-23 11:48:37 UTC (rev 626) @@ -71,11 +71,8 @@ FEATURE_LIBS = $(shell LANG=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-lftdi") -flashrom.o: flashrom.c .features - $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c -o $@ $< $(SVNDEF) - %.o: %.c .features - $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) -c $< -o $@ $(SVNDEF) + $(CC) $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $< clean: rm -f $(PROGRAM) *.o

1 0

[flashrom] r625 - trunk
by svn＠coreboot.org 23 Jun '09

23 Jun '09

Author: hailfinger Date: 2009-06-23 13:33:43 +0200 (Tue, 23 Jun 2009) New Revision: 625 Added: trunk/serprog.c Modified: trunk/Makefile trunk/flash.h trunk/flashrom.c Log: Initial commit of an external serial flasher protocol. Supports RS-232, USB serial converters (untested) and TCP streams. All functionality is stubbed out to allow multiplatform compile testing of the headers we use. The real serial flasher protocol driver will be committed next. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/Makefile =================================================================== --- trunk/Makefile 2009-06-23 10:44:36 UTC (rev 624) +++ trunk/Makefile 2009-06-23 11:33:43 UTC (rev 625) @@ -49,7 +49,8 @@ sst49lfxxxc.o sst_fwhub.o layout.o cbtable.o flashchips.o physmap.o \ flashrom.o w39v080fa.o sharplhf00l04.o w29ee011.o spi.o it87spi.o \ ichspi.o w39v040c.o sb600spi.o wbsio_spi.o m29f002.o internal.o \ - dummyflasher.o pcidev.o nic3com.o satasii.o ft2232_spi.o print.o + dummyflasher.o pcidev.o nic3com.o satasii.o ft2232_spi.o serprog.o \ + print.o all: pciutils features dep $(PROGRAM) Modified: trunk/flash.h =================================================================== --- trunk/flash.h 2009-06-23 10:44:36 UTC (rev 624) +++ trunk/flash.h 2009-06-23 11:33:43 UTC (rev 625) @@ -87,6 +87,7 @@ #define PROGRAMMER_SATASII 0x03 #define PROGRAMMER_IT87SPI 0x04 #define PROGRAMMER_FT2232SPI 0x05 +#define PROGRAMMER_SERPROG 0x06 struct programmer_entry { const char *vendor; @@ -585,4 +586,12 @@ int erase_stm50flw0x0x(struct flashchip *flash); int write_stm50flw0x0x(struct flashchip *flash, uint8_t *buf); +/* serprog.c */ +extern char* serprog_param; +int serprog_init(void); +int serprog_shutdown(void); +void serprog_chip_writeb(uint8_t val, chipaddr addr); +uint8_t serprog_chip_readb(const chipaddr addr); +void serprog_chip_readn(uint8_t *buf, const chipaddr addr, size_t len); +void serprog_delay(int delay); #endif /* !__FLASH_H__ */ Modified: trunk/flashrom.c =================================================================== --- trunk/flashrom.c 2009-06-23 10:44:36 UTC (rev 624) +++ trunk/flashrom.c 2009-06-23 11:33:43 UTC (rev 625) @@ -130,6 +130,21 @@ .chip_writen = fallback_chip_writen, .delay = internal_delay, }, + { + .init = serprog_init, + .shutdown = serprog_shutdown, + .map_flash_region = fallback_map, + .unmap_flash_region = fallback_unmap, + .chip_readb = serprog_chip_readb, + .chip_readw = fallback_chip_readw, + .chip_readl = fallback_chip_readl, + .chip_readn = serprog_chip_readn, + .chip_writeb = serprog_chip_writeb, + .chip_writew = fallback_chip_writew, + .chip_writel = fallback_chip_writel, + .chip_writen = fallback_chip_writen, + .delay = serprog_delay, + }, {}, }; @@ -500,7 +515,7 @@ " -z | --list-supported-wiki: print supported devices in wiki syntax\n" " -p | --programmer <name>: specify the programmer device\n" " (internal, dummy, nic3com, satasii,\n" - " it87spi, ft2232spi)\n" + " it87spi, ft2232spi, serprog)\n" " -h | --help: print this help text\n" " -R | --version: print the version (release)\n" "\nYou can specify one of -E, -r, -w, -v or no operation. " @@ -653,6 +668,10 @@ programmer = PROGRAMMER_IT87SPI; } else if (strncmp(optarg, "ft2232spi", 9) == 0) { programmer = PROGRAMMER_FT2232SPI; + } else if (strncmp(optarg, "serprog", 7) == 0) { + programmer = PROGRAMMER_SERPROG; + if (optarg[7] == '=') + serprog_param = strdup(optarg + 8); } else { printf("Error: Unknown programmer.\n"); exit(1); Added: trunk/serprog.c =================================================================== --- trunk/serprog.c (rev 0) +++ trunk/serprog.c 2009-06-23 11:33:43 UTC (rev 625) @@ -0,0 +1,80 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2009 Urja Rannikko <urjaman(a)gmail.com> + * Copyright (C) 2009 Carl-Daniel Hailfinger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <string.h> +#include <stdlib.h> +#include <ctype.h> +#include <fcntl.h> +#include <sys/types.h> +#include <sys/socket.h> +#include <arpa/inet.h> +#include <netinet/in.h> +#include <netinet/tcp.h> +#include <netdb.h> +#include <sys/stat.h> +#include <errno.h> +#include <stdio.h> +#include <unistd.h> +#include <inttypes.h> +#include <termios.h> +#include "flash.h" + +char *serprog_param = NULL; + +#define SERPROG_SUPPORT 0 +#if SERPROG_SUPPORT == 1 +#else +int serprog_init(void) +{ + fprintf(stderr, "Serial programmer support was not compiled in\n"); + exit(1); +} + +int serprog_shutdown(void) +{ + fprintf(stderr, "Serial programmer support was not compiled in\n"); + exit(1); +} + +void serprog_chip_writeb(uint8_t val, chipaddr addr) +{ + fprintf(stderr, "Serial programmer support was not compiled in\n"); + exit(1); +} + +uint8_t serprog_chip_readb(const chipaddr addr) +{ + fprintf(stderr, "Serial programmer support was not compiled in\n"); + exit(1); +} + +void serprog_chip_readn(uint8_t *buf, const chipaddr addr, size_t len) +{ + fprintf(stderr, "Serial programmer support was not compiled in\n"); + exit(1); +} + +void serprog_delay(int delay) +{ + fprintf(stderr, "Serial programmer support was not compiled in\n"); + exit(1); +} +#endif

1 0

[flashrom] r624 - trunk
by svn＠coreboot.org 23 Jun '09

23 Jun '09

Author: stepan Date: 2009-06-23 12:44:36 +0200 (Tue, 23 Jun 2009) New Revision: 624 Modified: trunk/physmap.c Log: There are some non-C99 compilers out there used to compile flashrom. This fixes compilation for them. Signed-off-by: Stephan Guilloux <stephan.guilloux(a)free.fr> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/physmap.c =================================================================== --- trunk/physmap.c 2009-06-23 00:47:26 UTC (rev 623) +++ trunk/physmap.c 2009-06-23 10:44:36 UTC (rev 624) @@ -80,6 +80,8 @@ void *physmap(const char *descr, unsigned long phys_addr, size_t len) { + void *virt_addr; + if (len == 0) { printf_debug("Not mapping %s, zero size at 0x%08lx.\n", descr, phys_addr); @@ -96,7 +98,7 @@ descr, (unsigned long)len, phys_addr); } - void *virt_addr = sys_physmap(phys_addr, len); + virt_addr = sys_physmap(phys_addr, len); if (NULL == virt_addr) { if (NULL == descr)

1 0

Re: [coreboot] coreboot for intel atom processor
by Stefan Reinauer 23 Jun '09

23 Jun '09

Anurag_Vashisth wrote: > My hardware configuration is: > 1) INTEL ATOM CPU Z510P > 2) INTEL SCH US15WP chipset > Dear Anurag, There is currently no support for this CPU/chipset combination available. Stefan -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

1 0

[LinuxTag 2009] Ideas and how to attract the audience.
by Paul Menzel 23 Jun '09

23 Jun '09

Dear everyone, LinuxTag is starting on Wednesday. There is now also a page in the coreboot wiki [1]. Please feel free to edit it and spot things Peter and I missed. But there is still a problem I have, which I already wrote to Peter. Am Dienstag, den 23.06.2009, 05:15 +0200 schrieb Peter Stuge: > Paul Menzel wrote: > > My main problem is, what the main goal of the coreboot project is > > at such a fair and if there is one, how can we reach this goal. > > > > Last year I had the impression, that most people were thinking – if > > they looked –: “Great! But it is too geeky for me and I do not > > profit enough from it to try it out or to dig deeper into it.” > > > > So how can we convince them to get into touch with it. (Try it out > > with Qemu.) … > > You make an excellent point. The goal is to show people that coreboot > exists. Some people will be potential users, maybe at businesses > making some kind of product, or interested individuals who like fast > boot times for their HTPC. Some of them may even become developers.. > And some will just find the project interesting and hang around the > mailing list. Maybe they will eventually also contribute at some > point, but at the very least they might spread the word. What are your opinions? Do you have suggestions of good ways to achieve this goal? Peter is going to bring flyers along, which serves the purpose to spread the word about coreboot quite well. What could be displayed on the monitor to catch the interest of people walking by. I just thought of, that maybe there should be a section on the flyer—I have not seen it yet— about how to contribute. And since a lot of people do not know about firmware development or C (as myself), it would be great to also list other tasks. I think, this would probably increase the chance that more people get in touch with coreboot when listing concrete issues, where they could help. (Maybe there exits a wiki page already, because Carl-Daniel often wrote to the list about how to become familiar with coreboot.) So would could “normal” people do? - Send flashrom -V to the list and test the operations on system, but only if they have a backup path. - The call from someone at the Ubuntu forum to send detailed hardware information to the list was not seen as beneficial. - Donations? - Contact/Lobbying of hardware vendors? - Art design? (Do we need a start screen or a layout for our web site?) - Payload for a tool/interface like ordinary BIOS set up tools to set certain options for coreboot during boot? Sorry for the amount of questions. Maybe a wiki page “How to contribute?” could be set up for this. I am looking forward to your ideas. I have to go, Paul [1] http://www.coreboot.org/LinuxTag_2009

3 2

← Newer
1
...
14
15
16
17
18
19
20
...
50
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot June 2009