coreboot January 2009

coreboot@coreboot.org

66 participants
320 discussions

r3918 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 16:19:43 +0100 (Mon, 26 Jan 2009) New Revision: 3918 Modified: trunk/util/flashrom/ichspi.c trunk/util/flashrom/m29f002.c Log: flashrom: Fix one dead increment and one dead assignment as found by clang. Thanks Patrick! Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/ichspi.c =================================================================== --- trunk/util/flashrom/ichspi.c 2009-01-26 06:42:02 UTC (rev 3917) +++ trunk/util/flashrom/ichspi.c 2009-01-26 15:19:43 UTC (rev 3918) @@ -289,7 +289,6 @@ uint32_t opmenu[2]; /* Program Prefix Opcodes */ - preop = 0; /* 0:7 Prefix Opcode 1 */ preop = (op->preop[0]); /* 8:16 Prefix Opcode 2 */ Modified: trunk/util/flashrom/m29f002.c =================================================================== --- trunk/util/flashrom/m29f002.c 2009-01-26 06:42:02 UTC (rev 3917) +++ trunk/util/flashrom/m29f002.c 2009-01-26 15:19:43 UTC (rev 3918) @@ -77,7 +77,7 @@ do_block(bios, buf, i++, 0x30000, 32*1024); do_block(bios, buf, i++, 0x38000, 8*1024); do_block(bios, buf, i++, 0x3a000, 8*1024); - do_block(bios, buf, i++, 0x3c000, 16*1024); + do_block(bios, buf, i, 0x3c000, 16*1024); printf("\n"); return 0;

1 0

flashrom: does write support really work for AMD-768 ?
by Pierre Bogossian 26 Jan '09

26 Jan '09

Hi, yesterday, I tried to flash a Pm49FL002 chip on my A7M266-D using flashrom (compiled from the latest snapshot). This motherboard has an AMD-768 Southbridge. Flashrom didn't report any problem during the writing. But then, when I read the content of the flash chip, it appeared that it was identical to its original content. Nothing was actually written. I also tried to erase the chip, and flashrom immediately reported an error during the verification. So it really looks like the chip is read-only, something must be missing in the code to enable writing. Pierre -- Be Yourself @ mail.com! Choose From 200+ Email Addresses Get a Free Account at www.mail.com

1 0

r3917 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 07:42:02 +0100 (Mon, 26 Jan 2009) New Revision: 3917 Added: trunk/util/flashrom/m29f002.c Modified: trunk/util/flashrom/Makefile trunk/util/flashrom/flash.h trunk/util/flashrom/flashchips.c Log: flashrom: Driver for ST M29F002T/NT/B. T/NT TEST_OK_ PROBE READ ERASE WRITE Test report from Julia. Thanks! Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Julia Longtin <juri(a)solarnetone.org> Modified: trunk/util/flashrom/Makefile =================================================================== --- trunk/util/flashrom/Makefile 2009-01-26 04:48:01 UTC (rev 3916) +++ trunk/util/flashrom/Makefile 2009-01-26 06:42:02 UTC (rev 3917) @@ -34,7 +34,7 @@ w49f002u.o 82802ab.o pm49fl00x.o sst49lf040.o en29f002a.o \ sst49lfxxxc.o sst_fwhub.o layout.o cbtable.o flashchips.o physmap.o \ flashrom.o w39v080fa.o sharplhf00l04.o w29ee011.o spi.o it87spi.o \ - ichspi.o w39v040c.o sb600spi.o wbsio_spi.o + ichspi.o w39v040c.o sb600spi.o wbsio_spi.o m29f002.o all: pciutils dep $(PROGRAM) Modified: trunk/util/flashrom/flash.h =================================================================== --- trunk/util/flashrom/flash.h 2009-01-26 04:48:01 UTC (rev 3916) +++ trunk/util/flashrom/flash.h 2009-01-26 06:42:02 UTC (rev 3917) @@ -579,6 +579,11 @@ int write_sector_jedec(volatile uint8_t *bios, uint8_t *src, volatile uint8_t *dst, unsigned int page_size); +/* m29f002.c */ +int erase_m29f002(struct flashchip *flash); +int write_m29f002t(struct flashchip *flash, uint8_t *buf); +int write_m29f002b(struct flashchip *flash, uint8_t *buf); + /* m29f400bt.c */ int probe_m29f400bt(struct flashchip *flash); int erase_m29f400bt(struct flashchip *flash); Modified: trunk/util/flashrom/flashchips.c =================================================================== --- trunk/util/flashrom/flashchips.c 2009-01-26 04:48:01 UTC (rev 3916) +++ trunk/util/flashrom/flashchips.c 2009-01-26 06:42:02 UTC (rev 3917) @@ -1641,8 +1641,8 @@ .page_size = 64 * 1024, .tested = TEST_UNTESTED, .probe = probe_jedec, - .erase = erase_chip_jedec, - .write = write_jedec, + .erase = erase_m29f002, + .write = write_m29f002b, }, { @@ -1652,10 +1652,10 @@ .model_id = ST_M29F002T, .total_size = 256, .page_size = 64 * 1024, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_jedec, - .erase = erase_chip_jedec, - .write = write_jedec, + .erase = erase_m29f002, + .write = write_m29f002t, }, { Added: trunk/util/flashrom/m29f002.c =================================================================== --- trunk/util/flashrom/m29f002.c (rev 0) +++ trunk/util/flashrom/m29f002.c 2009-01-26 06:42:02 UTC (rev 3917) @@ -0,0 +1,105 @@ +/* + * This file is part of flashrom. + * + * Copyright (C) 2009 Peter Stuge <peter(a)stuge.se> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "flash.h" + +int erase_m29f002(struct flashchip *flash) { + volatile uint8_t *bios = flash->virtual_memory; + *(volatile uint8_t *)(bios + 0x555) = 0xaa; + *(volatile uint8_t *)(bios + 0xaaa) = 0x55; + *(volatile uint8_t *)(bios + 0x555) = 0x80; + *(volatile uint8_t *)(bios + 0x555) = 0xaa; + *(volatile uint8_t *)(bios + 0xaaa) = 0x55; + *(volatile uint8_t *)(bios + 0x555) = 0x10; + myusec_delay(10); + toggle_ready_jedec(bios); + return 0; +} + +static void rewrite_block(volatile uint8_t *bios, uint8_t *src, volatile uint8_t *dst, int size) { + /* erase */ + *(volatile uint8_t *)(bios + 0x555) = 0xaa; + *(volatile uint8_t *)(bios + 0xaaa) = 0x55; + *(volatile uint8_t *)(bios + 0x555) = 0x80; + *(volatile uint8_t *)(bios + 0x555) = 0xaa; + *(volatile uint8_t *)(bios + 0xaaa) = 0x55; + *dst = 0x30; + myusec_delay(10); + toggle_ready_jedec(bios); + + /* program */ + while (size--) { + *(volatile uint8_t *)(bios + 0x555) = 0xaa; + *(volatile uint8_t *)(bios + 0xaaa) = 0x55; + *(volatile uint8_t *)(bios + 0x555) = 0xa0; + *dst = *src; + toggle_ready_jedec(dst); + dst++; + src++; + } +} + +static void do_block(volatile uint8_t *bios, uint8_t *src, int i, unsigned long start, int size) { + printf("%d at address: 0x%08lx", i, start); + rewrite_block(bios, src + start, bios + start, size); + printf("\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b"); +} + +int write_m29f002t(struct flashchip *flash, uint8_t *buf) { + int i, page_size = flash->page_size; + volatile uint8_t *bios = flash->virtual_memory; + + /* M29F002(N)T has 7 blocks. From bottom to top their sizes are: + * 64k 64k 64k 32k 8k 8k 16k + * flash->page_size is set to 64k in flashchips.c + */ + + printf("Programming block: "); + for (i = 0; i < 3; i++) + do_block(bios, buf, i, i*page_size, page_size); + do_block(bios, buf, i++, 0x30000, 32*1024); + do_block(bios, buf, i++, 0x38000, 8*1024); + do_block(bios, buf, i++, 0x3a000, 8*1024); + do_block(bios, buf, i++, 0x3c000, 16*1024); + + printf("\n"); + return 0; +} + +int write_m29f002b(struct flashchip *flash, uint8_t *buf) { + int i = 0, page_size = flash->page_size; + volatile uint8_t *bios = flash->virtual_memory; + + /* M29F002B has 7 blocks. From bottom to top their sizes are: + * 16k 8k 8k 32k 64k 64k 64k + * flash->page_size is set to 64k in flashchips.c + */ + + printf("Programming block: "); + do_block(bios, buf, i++, 0x00000, 16*1024); + do_block(bios, buf, i++, 0x04000, 8*1024); + do_block(bios, buf, i++, 0x06000, 8*1024); + do_block(bios, buf, i++, 0x08000, 32*1024); + for (; i < 7; i++) + do_block(bios, buf, i, (i-3)*page_size, page_size); + + printf("\n"); + return 0; +}

1 0

r3916 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 05:48:01 +0100 (Mon, 26 Jan 2009) New Revision: 3916 Modified: trunk/util/flashrom/flashchips.c Log: flashrom: Fix copypaste error in r3913. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/flashchips.c =================================================================== --- trunk/util/flashrom/flashchips.c 2009-01-26 04:12:58 UTC (rev 3915) +++ trunk/util/flashrom/flashchips.c 2009-01-26 04:48:01 UTC (rev 3916) @@ -1136,7 +1136,7 @@ .tested = TEST_OK_PR, .probe = probe_spi_rems, .erase = spi_chip_erase_c7, - .write = spi_chip_aai_write, + .write = spi_aai_write, .read = spi_chip_read, },

1 0

r3915 - trunk/util/msrtool
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 05:12:58 +0100 (Mon, 26 Jan 2009) New Revision: 3915 Modified: trunk/util/msrtool/cs5536.c Log: msrtool: AMD CS5536 probe implementation. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/msrtool/cs5536.c =================================================================== --- trunk/util/msrtool/cs5536.c 2009-01-26 04:10:12 UTC (rev 3914) +++ trunk/util/msrtool/cs5536.c 2009-01-26 04:12:58 UTC (rev 3915) @@ -20,8 +20,7 @@ #include "msrtool.h" int cs5536_probe(const struct targetdef *target) { - /* TODO: PCI 1022:2090 */ - return 0; + return (NULL != pci_dev_find(0x1022, 0x2090)); } const struct msrdef cs5536_msrs[] = {

1 0

r3914 - trunk/util/msrtool
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 05:10:12 +0100 (Mon, 26 Jan 2009) New Revision: 3914 Modified: trunk/util/msrtool/configure Log: msrtool: Make configure work with zsh, the default shell in Darwin. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/msrtool/configure =================================================================== --- trunk/util/msrtool/configure 2009-01-26 03:37:40 UTC (rev 3913) +++ trunk/util/msrtool/configure 2009-01-26 04:10:12 UTC (rev 3914) @@ -19,35 +19,38 @@ # # If this is left unset, try to set the version string from the highest -# revision number of the checked out files later. +# revision number of the checked out files. VERSION="" -REV="$(svnversion -c . 2>/dev/null)"; REV="${REV/*:}" +REV="`svnversion -c . 2>/dev/null | sed 's,.*:,,' 2>/dev/null`" VERSION="${VERSION:-$REV}" -function findprog() { - local WHAT FROMENV FILE +function findprog { + NPARMS=$# WHAT="${1}" shift FROMENV="${1}" shift - echo -n "searching for ${WHAT} (${*})..." 1>&2 + printf "searching for ${WHAT} (${*})..." 1>&2 test -n "${FROMENV}" && { echo " using environment: ${FROMENV}" 1>&2 echo "${FROMENV}" exit 0 } - for parm in $(seq 0 $#); do + i=2 + while test $i -lt $NPARMS; do test -z "${1}" && { shift + i=$[$i+1] continue } - FILE="$(which "${1}" 2>/dev/null)" + FILE="`which "${1}" 2>/dev/null`" test $? -eq 0 && { echo "${1}" break } shift + i=$[$i+1] done test -z "${1}" && { echo " not found!" 1>&2 @@ -59,78 +62,82 @@ exit 0 } -function trycompile() { - local WHAT OUT +function trycompile { + NPARMS=$# WHAT="${1}" shift - echo -n "finding CFLAGS for ${WHAT}... " 1>&2 + printf "finding CFLAGS for ${WHAT}... " 1>&2 OUT="${OUT}\n${CC} ${CFLAGS} -o .config.o -c .config.c" - OUT="${OUT}\n$(${CC} ${CFLAGS} -o .config.o -c .config.c 2>&1)" + OUT="${OUT}\n`echo "${CC} ${CFLAGS} -o .config.o -c .config.c"|sh 2>&1`" test $? -eq 0 && { echo " using: ${CFLAGS}" 1>&2 echo "${CFLAGS}" exit 0 } - for parm in $(seq 1 $#); do + i=1 + while test $i -lt $NPARMS; do OUT="${OUT}\n${CC} ${CFLAGS} ${1} -o .config.o -c .config.c 2>&1" - OUT="${OUT}\n$(${CC} ${CFLAGS} ${1} -o .config.o -c .config.c 2>&1)" + OUT="${OUT}\n`echo "${CC} ${CFLAGS} ${1} -o .config.o -c .config.c"|sh 2>&1`" test $? -eq 0 && { echo " using: ${CFLAGS} ${1}" 1>&2 echo "${CFLAGS} ${1}" exit 0 } shift + i=$[$i+1] done echo "failed!" 1>&2 echo 1>&2 - echo -n "The following compiler commands were executed:" 1>&2 + printf "The following compiler commands were executed:" 1>&2 echo -e "${OUT}\n" 1>&2 echo "This is a fatal error, configure is exiting!" 1>&2 echo 1>&2 echo "You can try to fix this by manually setting CFLAGS in the environment before" 1>&2 echo "running configure. E.g.:" 1>&2 - echo "CFLAGS=-I/opt/somedir/include ${0}" 1>&2 + echo "CFLAGS=-I/opt/somedir/include ./configure" 1>&2 echo 1>&2 exit 1 } -function trylink() { - local WHAT OUT +function trylink { + NPARMS=$# WHAT="${1}" shift - echo -n "finding LDFLAGS for ${WHAT}... " 1>&2 + printf "finding LDFLAGS for ${WHAT}... " 1>&2 OUT="${OUT}\n${CC} -o .config .config.o ${LDFLAGS} 2>&1" - OUT="${OUT}\n$(${CC} -o .config .config.o ${LDFLAGS} 2>&1)" + OUT="${OUT}\n`echo "${CC} -o .config .config.o ${LDFLAGS}"|sh 2>&1`" test $? -eq 0 && { echo " using: ${LDFLAGS}" 1>&2 echo "${LDFLAGS}" exit 0 } - for parm in $(seq 1 $#); do + i=1 + while test $i -lt $NPARMS; do OUT="${OUT}\n${CC} -o .config .config.o ${LDFLAGS} ${1} 2>&1" - OUT="${OUT}\n$(${CC} -o .config .config.o ${LDFLAGS} ${1} 2>&1)" + OUT="${OUT}\n`echo "${CC} -o .config .config.o ${LDFLAGS} ${1}"|sh 2>&1`" test $? -eq 0 && { echo " using: ${LDFLAGS} ${1}" 1>&2 echo "${LDFLAGS} ${1}" exit 0 } shift + i=$[$i+1] done echo "failed!" 1>&2 echo 1>&2 - echo -n "The following linker commands were executed:" 1>&2 + printf "The following linker commands were executed:" 1>&2 echo -e "${OUT}\n" 1>&2 echo "This is a fatal error, configure is exiting!" 1>&2 echo 1>&2 echo "You can try to fix this by manually setting LDFLAGS in the environment before" 1>&2 echo "running configure. E.g.:" 1>&2 - echo "LDFLAGS=-L/opt/somedir/lib ${0}" 1>&2 + echo "LDFLAGS=-L/opt/somedir/lib ./configure" 1>&2 echo 1>&2 exit 1 } -CC=$(findprog "compiler" "${CC}" gcc cc icc) || exit -INSTALL=$(findprog "install" "${INSTALL}" install ginstall) || exit +CC=`findprog "compiler" "${CC}" gcc cc icc` || exit +INSTALL=`findprog "install" "${INSTALL}" install ginstall` || exit test -n "$DEBUG" && myCFLAGS="-O2 -g" || myCFLAGS="-Os" CFLAGS="${CFLAGS} ${myCFLAGS} -Wall -Werror" @@ -142,13 +149,13 @@ { pacc = pci_alloc(); return 0; } EOF -pc_CFLAGS="$(pkg-config libpci --cflags 2>/dev/null)" -pc_LDFLAGS="$(pkg-config libpci --libs 2>/dev/null)" -CFLAGS=$(trycompile "libpci (from pciutils)" "${pc_CFLAGS}" "-I/usr/local/include") || { +pc_CFLAGS="`pkg-config libpci --cflags 2>/dev/null`" +pc_LDFLAGS="`pkg-config libpci --libs 2>/dev/null`" +CFLAGS=`trycompile "libpci (from pciutils)" "${pc_CFLAGS}" "-I/usr/local/include"` || { rm -f .config.c exit 1 } -LDFLAGS=$(trylink "libpci (from pciutils)" "${pc_LDFLAGS}" "-lpci -lz" "-L/usr/local/lib -lpci -lz") || { +LDFLAGS=`trylink "libpci (from pciutils)" "${pc_LDFLAGS}" "-lpci -lz" "-L/usr/local/lib -lpci -lz" "-framework IOKit -L/usr/local/lib -lpci -lz"` || { rm -f .config.c .config.o exit 1 } @@ -156,8 +163,6 @@ PREFIX="${PREFIX:-/usr/local}" -OS_ARCH=$(uname) - echo echo "configured using the following settings:" echo @@ -168,7 +173,7 @@ echo "INSTALL=${INSTALL}" echo "PREFIX=${PREFIX}" echo -echo -n "creating Makefile..." +printf "creating Makefile..." echo "# This file was automatically generated by configure" > Makefile sed -e "s#@VERSION@#${VERSION}#g" \ -e "s#@CC@#${CC}#g" \

1 0

r3913 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 04:37:40 +0100 (Mon, 26 Jan 2009) New Revision: 3913 Modified: trunk/util/flashrom/flash.h trunk/util/flashrom/flashchips.c trunk/util/flashrom/spi.c Log: flashrom: SST25VF040B using 0x90 identification and AAI write. SST AAI is Auto Address Increment writing, a streamed write to the flash chip where the first write command sets a starting address and following commands simply append data. Unfortunately not supported by Winbond SPI masters. >From July 2008. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/flash.h =================================================================== --- trunk/util/flashrom/flash.h 2009-01-26 03:23:50 UTC (rev 3912) +++ trunk/util/flashrom/flash.h 2009-01-26 03:37:40 UTC (rev 3913) @@ -523,6 +523,7 @@ int spi_disable_blockprotect(void); void spi_byte_program(int address, uint8_t byte); int spi_nbyte_read(int address, uint8_t *bytes, int len); +int spi_aai_write(struct flashchip *flash, uint8_t *buf); /* 82802ab.c */ int probe_82802ab(struct flashchip *flash); Modified: trunk/util/flashrom/flashchips.c =================================================================== --- trunk/util/flashrom/flashchips.c 2009-01-26 03:23:50 UTC (rev 3912) +++ trunk/util/flashrom/flashchips.c 2009-01-26 03:37:40 UTC (rev 3913) @@ -1128,6 +1128,20 @@ { .vendor = "SST", + .name = "SST25VF040B.REMS", + .manufacture_id = 0xbf, + .model_id = 0x8d, + .total_size = 512, + .page_size = 64*1024, + .tested = TEST_OK_PR, + .probe = probe_spi_rems, + .erase = spi_chip_erase_c7, + .write = spi_chip_aai_write, + .read = spi_chip_read, + }, + + { + .vendor = "SST", .name = "SST25VF080B", .manufacture_id = SST_ID, .model_id = SST_25VF080B, Modified: trunk/util/flashrom/spi.c =================================================================== --- trunk/util/flashrom/spi.c 2009-01-26 03:23:50 UTC (rev 3912) +++ trunk/util/flashrom/spi.c 2009-01-26 03:37:40 UTC (rev 3913) @@ -615,3 +615,29 @@ return 1; } + +int spi_aai_write(struct flashchip *flash, uint8_t *buf) { + uint32_t pos = 2, size = flash->total_size * 1024; + unsigned char w[6] = {0xad, 0, 0, 0, buf[0], buf[1]}; + switch (flashbus) { + case BUS_TYPE_WBSIO_SPI: + fprintf(stderr, "%s: impossible with Winbond SPI masters, degrading to byte program\n", __func__); + return spi_chip_write(flash, buf); + default: + break; + } + flash->erase(flash); + spi_write_enable(); + spi_command(6, 0, w, NULL); + while (spi_read_status_register() & JEDEC_RDSR_BIT_WIP) + myusec_delay(5); /* SST25VF040B Tbp is max 10us */ + while (pos < size) { + w[1] = buf[pos++]; + w[2] = buf[pos++]; + spi_command(3, 0, w, NULL); + while (spi_read_status_register() & JEDEC_RDSR_BIT_WIP) + myusec_delay(5); /* SST25VF040B Tbp is max 10us */ + } + spi_write_disable(); + return 0; +}

1 0

r3912 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 04:23:50 +0100 (Mon, 26 Jan 2009) New Revision: 3912 Modified: trunk/util/flashrom/spi.c Log: flashrom: Decode SST25VF040B status register, also from July 2008. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/spi.c =================================================================== --- trunk/util/flashrom/spi.c 2009-01-26 03:12:44 UTC (rev 3911) +++ trunk/util/flashrom/spi.c 2009-01-26 03:23:50 UTC (rev 3912) @@ -299,6 +299,24 @@ bpt[(status & 0x1c) >> 2]); } +void spi_prettyprint_status_register_sst25vf040b(uint8_t status) +{ + const char *bpt[] = { + "none", + "0x70000-0x7ffff", + "0x60000-0x7ffff", + "0x40000-0x7ffff", + "all blocks", "all blocks", "all blocks", "all blocks" + }; + printf_debug("Chip status register: Block Protect Write Disable " + "(BPL) is %sset\n", (status & (1 << 7)) ? "" : "not "); + printf_debug("Chip status register: Auto Address Increment Programming " + "(AAI) is %sset\n", (status & (1 << 6)) ? "" : "not "); + spi_prettyprint_status_register_common(status); + printf_debug("Resulting block protection : %s\n", + bpt[(status & 0x3c) >> 2]); +} + void spi_prettyprint_status_register(struct flashchip *flash) { uint8_t status; @@ -316,8 +334,15 @@ spi_prettyprint_status_register_st_m25p(status); break; case SST_ID: - if (flash->model_id == SST_25VF016B) + switch (flash->model_id) { + case 0x2541: spi_prettyprint_status_register_sst25vf016(status); + break; + case 0x8d: + case 0x258d: + spi_prettyprint_status_register_sst25vf040b(status); + break; + } break; } }

1 0

Re: [coreboot] r3911 - trunk/util/flashrom
by Peter Stuge 26 Jan '09

26 Jan '09

svn(a)coreboot.org wrote: > + .first_vendor = 0x1039, > + .first_device = 0x5513, > + .first_card_vendor = 0x8086, > + .first_card_device = 0xd61f, > + .second_vendor = 0x1039, > + .second_device = 0x6330, > + .second_card_vendor = 0x8086, > + .second_card_device = 0xd61f, > + .lb_vendor = NULL, > + .lb_part = NULL, > + .name = "Intel Desktop Board D201GLY", > + .enable = wbsio_check_for_spi, Carl-Daniel, please revert that layout change sooner rather than later. Thanks! //Peter

1 0

r3911 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 04:12:44 +0100 (Mon, 26 Jan 2009) New Revision: 3911 Modified: trunk/util/flashrom/board_enable.c Log: flashrom: Intel Desktop Board D201GLY Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/board_enable.c =================================================================== --- trunk/util/flashrom/board_enable.c 2009-01-26 03:08:45 UTC (rev 3910) +++ trunk/util/flashrom/board_enable.c 2009-01-26 03:12:44 UTC (rev 3911) @@ -978,6 +978,20 @@ .enable = w83627thf_gpio4_4_raise_2e, }, { + .first_vendor = 0x1039, + .first_device = 0x5513, + .first_card_vendor = 0x8086, + .first_card_device = 0xd61f, + .second_vendor = 0x1039, + .second_device = 0x6330, + .second_card_vendor = 0x8086, + .second_card_device = 0xd61f, + .lb_vendor = NULL, + .lb_part = NULL, + .name = "Intel Desktop Board D201GLY", + .enable = wbsio_check_for_spi, + }, + { .first_vendor = 0, .first_device = 0, .first_card_vendor = 0,

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2009