coreboot January 2009

coreboot@coreboot.org

66 participants
320 discussions

r3902 - trunk/payloads/libpayload/libc
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stepan Date: 2009-01-26 01:57:54 +0100 (Mon, 26 Jan 2009) New Revision: 3902 Modified: trunk/payloads/libpayload/libc/string.c Log: fix a potential null pointer reference in strdup (as found by Patrick Georgi) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/payloads/libpayload/libc/string.c =================================================================== --- trunk/payloads/libpayload/libc/string.c 2009-01-26 00:39:57 UTC (rev 3901) +++ trunk/payloads/libpayload/libc/string.c 2009-01-26 00:57:54 UTC (rev 3902) @@ -212,10 +212,10 @@ int n = strlen(s); char *p = malloc(n + 1); - if (p != NULL) + if (p != NULL) { strncpy(p, s, n); - - p[n] = 0; + p[n] = 0; + } return p; }

1 0

r3901 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 01:39:57 +0100 (Mon, 26 Jan 2009) New Revision: 3901 Modified: trunk/util/flashrom/flash.h trunk/util/flashrom/flashrom.c Log: flashrom: Change flashrom.c:map_flash_registers() from int to void. The function exit()s on failure, and no callers check the return value. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/flash.h =================================================================== --- trunk/util/flashrom/flash.h 2009-01-26 00:19:36 UTC (rev 3900) +++ trunk/util/flashrom/flash.h 2009-01-26 00:39:57 UTC (rev 3901) @@ -481,7 +481,7 @@ /* flashrom.c */ void mmap_errmsg(); -int map_flash_registers(struct flashchip *flash); +void map_flash_registers(struct flashchip *flash); /* layout.c */ int show_id(uint8_t *bios, int size, int force); Modified: trunk/util/flashrom/flashrom.c =================================================================== --- trunk/util/flashrom/flashrom.c 2009-01-26 00:19:36 UTC (rev 3900) +++ trunk/util/flashrom/flashrom.c 2009-01-26 00:39:57 UTC (rev 3901) @@ -95,7 +95,7 @@ } } -int map_flash_registers(struct flashchip *flash) +void map_flash_registers(struct flashchip *flash) { volatile uint8_t *registers; size_t size = flash->total_size * 1024; @@ -109,8 +109,6 @@ exit(1); } flash->virtual_registers = registers; - - return 0; } struct flashchip *probe_flash(struct flashchip *first_flash, int force)

1 0

r3900 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 01:19:36 +0100 (Mon, 26 Jan 2009) New Revision: 3900 Modified: trunk/util/flashrom/cbtable.c Log: flashrom: Forgot some things in r3899. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/cbtable.c =================================================================== --- trunk/util/flashrom/cbtable.c 2009-01-26 00:15:56 UTC (rev 3899) +++ trunk/util/flashrom/cbtable.c 2009-01-26 00:19:36 UTC (rev 3900) @@ -197,17 +197,17 @@ } lb_table = find_lb_table(low_1MB, 0x00000, 0x1000); if (!lb_table) - lb_table = find_lb_table(low_1MB, 0xf0000, 1024 * 1024); + lb_table = find_lb_table(low_1MB, 0xf0000, 1024*1024); if (!lb_table) { printf("No coreboot table found.\n"); return -1; } addr = ((char *)lb_table) - ((char *)low_1MB); - printf_debug("Coreboot table found at %p.\n", lb_table); + printf_debug("coreboot table found at %p.\n", lb_table); rec = (struct lb_record *)(((char *)lb_table) + lb_table->header_bytes); last = (struct lb_record *)(((char *)rec) + lb_table->table_bytes); - printf_debug("Coreboot header(%d) checksum: %04x table(%d) checksum: %04x entries: %d\n", + printf_debug("coreboot header(%d) checksum: %04x table(%d) checksum: %04x entries: %d\n", lb_table->header_bytes, lb_table->header_checksum, lb_table->table_bytes, lb_table->table_checksum, lb_table->table_entries);

1 0

r3899 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 01:15:56 +0100 (Mon, 26 Jan 2009) New Revision: 3899 Modified: trunk/util/flashrom/cbtable.c Log: flashrom: Little readability improvement in cbtable.c:coreboot_init() Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/cbtable.c =================================================================== --- trunk/util/flashrom/cbtable.c 2009-01-26 00:07:25 UTC (rev 3898) +++ trunk/util/flashrom/cbtable.c 2009-01-26 00:15:56 UTC (rev 3899) @@ -184,6 +184,7 @@ int coreboot_init(void) { uint8_t *low_1MB; + unsigned long addr; struct lb_header *lb_table; struct lb_record *rec, *last; @@ -194,26 +195,23 @@ mmap_errmsg(); exit(-2); } - lb_table = 0; + lb_table = find_lb_table(low_1MB, 0x00000, 0x1000); if (!lb_table) - lb_table = find_lb_table(low_1MB, 0x00000, 0x1000); - if (!lb_table) lb_table = find_lb_table(low_1MB, 0xf0000, 1024 * 1024); - if (lb_table) { - unsigned long addr; - addr = ((char *)lb_table) - ((char *)low_1MB); - printf_debug("Coreboot table found at %p.\n", lb_table); - rec = (struct lb_record *)(((char *)lb_table) + lb_table->header_bytes); - last = (struct lb_record *)(((char *)rec) + lb_table->table_bytes); - printf_debug("Coreboot header(%d) checksum: %04x table(%d) checksum: %04x entries: %d\n", - lb_table->header_bytes, lb_table->header_checksum, - lb_table->table_bytes, lb_table->table_checksum, - lb_table->table_entries); - search_lb_records(rec, last, addr + lb_table->header_bytes); - } else { + if (!lb_table) { printf("No coreboot table found.\n"); return -1; } + addr = ((char *)lb_table) - ((char *)low_1MB); + printf_debug("Coreboot table found at %p.\n", lb_table); + rec = (struct lb_record *)(((char *)lb_table) + lb_table->header_bytes); + last = (struct lb_record *)(((char *)rec) + lb_table->table_bytes); + printf_debug("Coreboot header(%d) checksum: %04x table(%d) checksum: %04x entries: %d\n", + lb_table->header_bytes, lb_table->header_checksum, + lb_table->table_bytes, lb_table->table_checksum, + lb_table->table_entries); + search_lb_records(rec, last, addr + lb_table->header_bytes); + return 0; }

1 0

r3898 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 01:07:25 +0100 (Mon, 26 Jan 2009) New Revision: 3898 Modified: trunk/util/flashrom/flash.h Log: flashrom: Change FreeBSD #ifdef into #if defined() Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/flash.h =================================================================== --- trunk/util/flashrom/flash.h 2009-01-25 23:59:30 UTC (rev 3897) +++ trunk/util/flashrom/flash.h 2009-01-26 00:07:25 UTC (rev 3898) @@ -30,7 +30,7 @@ #include <stdint.h> #include <stdio.h> -#ifdef __FreeBSD__ +#if defined(__FreeBSD__) #include <machine/cpufunc.h> #define off64_t off_t #define lseek64 lseek

1 0

r3897 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 00:59:30 +0100 (Mon, 26 Jan 2009) New Revision: 3897 Modified: trunk/util/flashrom/Makefile Log: flashrom: Make Makefile a bit more portable. Shell echo doesn't always know -n. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/Makefile =================================================================== --- trunk/util/flashrom/Makefile 2009-01-25 23:55:12 UTC (rev 3896) +++ trunk/util/flashrom/Makefile 2009-01-25 23:59:30 UTC (rev 3897) @@ -55,7 +55,7 @@ @$(CC) -MM *.c > .dependencies pciutils: - @echo; echo -n "Checking for pciutils and zlib... " + @echo; printf "Checking for pciutils and zlib... " @$(shell ( echo "#include <pci/pci.h>"; \ echo "struct pci_access *pacc;"; \ echo "int main(int argc, char **argv)"; \

1 0

r3896 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 00:55:12 +0100 (Mon, 26 Jan 2009) New Revision: 3896 Modified: trunk/util/flashrom/flashchips.c Log: flashrom: Add dry Am29F080B Am29LV081B SST39VF080 definitions per data sheets. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/flashchips.c =================================================================== --- trunk/util/flashrom/flashchips.c 2009-01-25 23:52:45 UTC (rev 3895) +++ trunk/util/flashrom/flashchips.c 2009-01-25 23:55:12 UTC (rev 3896) @@ -90,6 +90,19 @@ { .vendor = "AMD", + .name = "Am29F080B", + .manufacture_id = 0x01, + .model_id = 0xd5, + .total_size = 1024, + .page_size = 64 * 1024, + .tested = TEST_UNTESTED, + .probe = probe_jedec, + .erase = erase_29f040b, + .write = write_29f040b, + }, + + { + .vendor = "AMD", .name = "Am29LV040B", .manufacture_id = AMD_ID, .model_id = AM_29LV040B, @@ -102,6 +115,19 @@ }, { + .vendor = "AMD", + .name = "Am29LV081B", + .manufacture_id = 0x01, + .model_id = 0x38, + .total_size = 1024, + .page_size = 64 * 1024, + .tested = TEST_UNTESTED, + .probe = probe_29f040b, + .erase = erase_29f040b, + .write = write_29f040b, + }, + + { .vendor = "ASD", .name = "AE49F2008", .manufacture_id = ASD_ID, @@ -1272,6 +1298,19 @@ { .vendor = "SST", + .name = "SST39VF080", + .manufacture_id = 0xbf, + .model_id = 0xd8, + .total_size = 1024, + .page_size = 4096, + .tested = TEST_UNTESTED, + .probe = probe_jedec, + .erase = erase_chip_jedec, + .write = write_39sf020, + }, + + { + .vendor = "SST", .name = "SST49LF002A/B", .manufacture_id = SST_ID, .model_id = SST_49LF002A,

1 0

r3895 - trunk/util/flashrom
by svn＠coreboot.org 26 Jan '09

26 Jan '09

Author: stuge Date: 2009-01-26 00:52:45 +0100 (Mon, 26 Jan 2009) New Revision: 3895 Modified: trunk/util/flashrom/82802ab.c trunk/util/flashrom/am29f040b.c trunk/util/flashrom/en29f002a.c trunk/util/flashrom/jedec.c trunk/util/flashrom/m29f400bt.c trunk/util/flashrom/mx29f002.c trunk/util/flashrom/sharplhf00l04.c trunk/util/flashrom/spi.c trunk/util/flashrom/sst28sf040.c trunk/util/flashrom/sst49lfxxxc.c trunk/util/flashrom/stm50flw0x0x.c trunk/util/flashrom/w29ee011.c trunk/util/flashrom/w39v040c.c Log: flashrom: Beautify flash chip ID verbose printout a little, always use %02x. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/82802ab.c =================================================================== --- trunk/util/flashrom/82802ab.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/82802ab.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -69,7 +69,7 @@ myusec_delay(10); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 != flash->manufacture_id || id2 != flash->model_id) return 0; Modified: trunk/util/flashrom/am29f040b.c =================================================================== --- trunk/util/flashrom/am29f040b.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/am29f040b.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -83,7 +83,7 @@ myusec_delay(10); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 == flash->manufacture_id && id2 == flash->model_id) return 1; Modified: trunk/util/flashrom/en29f002a.c =================================================================== --- trunk/util/flashrom/en29f002a.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/en29f002a.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -49,7 +49,7 @@ *(volatile uint8_t *)(bios + 0x2AA) = 0x55; *(volatile uint8_t *)(bios + 0x555) = 0xF0; - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 == flash->manufacture_id && id2 == flash->model_id) return 1; Modified: trunk/util/flashrom/jedec.c =================================================================== --- trunk/util/flashrom/jedec.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/jedec.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -130,7 +130,7 @@ *(volatile uint8_t *)(bios + 0x5555) = 0xF0; myusec_delay(40); - printf_debug("%s: id1 0x%x, id2 0x%x", __FUNCTION__, largeid1, largeid2); + printf_debug("%s: id1 0x%02x, id2 0x%02x", __FUNCTION__, largeid1, largeid2); if (!oddparity(id1)) printf_debug(", id1 parity violation"); printf_debug("\n"); Modified: trunk/util/flashrom/m29f400bt.c =================================================================== --- trunk/util/flashrom/m29f400bt.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/m29f400bt.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -75,7 +75,7 @@ myusec_delay(10); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 == flash->manufacture_id && id2 == flash->model_id) return 1; Modified: trunk/util/flashrom/mx29f002.c =================================================================== --- trunk/util/flashrom/mx29f002.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/mx29f002.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -38,7 +38,7 @@ myusec_delay(10); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 == flash->manufacture_id && id2 == flash->model_id) return 1; Modified: trunk/util/flashrom/sharplhf00l04.c =================================================================== --- trunk/util/flashrom/sharplhf00l04.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/sharplhf00l04.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -61,7 +61,7 @@ myusec_delay(10); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 != flash->manufacture_id || id2 != flash->model_id) return 0; Modified: trunk/util/flashrom/spi.c =================================================================== --- trunk/util/flashrom/spi.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/spi.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -126,7 +126,7 @@ model_id = (readarr[1] << 8) | readarr[2]; } - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, manuf_id, + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, manuf_id, model_id); if (manuf_id == flash->manufacture_id && model_id == flash->model_id) { Modified: trunk/util/flashrom/sst28sf040.c =================================================================== --- trunk/util/flashrom/sst28sf040.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/sst28sf040.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -112,7 +112,7 @@ *bios = RESET; myusec_delay(10); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 == flash->manufacture_id && id2 == flash->model_id) return 1; Modified: trunk/util/flashrom/sst49lfxxxc.c =================================================================== --- trunk/util/flashrom/sst49lfxxxc.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/sst49lfxxxc.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -135,7 +135,7 @@ *bios = RESET; - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (!(id1 == flash->manufacture_id && id2 == flash->model_id)) return 0; Modified: trunk/util/flashrom/stm50flw0x0x.c =================================================================== --- trunk/util/flashrom/stm50flw0x0x.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/stm50flw0x0x.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -80,7 +80,7 @@ *(volatile uint8_t *)(bios + 0x5555) = 0xF0; myusec_delay(40); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, largeid1, + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, largeid1, largeid2); if (largeid1 != flash->manufacture_id || largeid2 != flash->model_id) Modified: trunk/util/flashrom/w29ee011.c =================================================================== --- trunk/util/flashrom/w29ee011.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/w29ee011.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -62,7 +62,7 @@ *(volatile uint8_t *)(bios + 0x5555) = 0xF0; myusec_delay(10); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __FUNCTION__, id1, id2); if (id1 == flash->manufacture_id && id2 == flash->model_id) return 1; Modified: trunk/util/flashrom/w39v040c.c =================================================================== --- trunk/util/flashrom/w39v040c.c 2009-01-25 20:41:51 UTC (rev 3894) +++ trunk/util/flashrom/w39v040c.c 2009-01-25 23:52:45 UTC (rev 3895) @@ -44,7 +44,7 @@ *(volatile uint8_t *)(bios + 0x5555) = 0xF0; myusec_delay(40); - printf_debug("%s: id1 0x%x, id2 0x%x", __func__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x", __func__, id1, id2); if (!oddparity(id1)) printf_debug(", id1 parity violation"); printf_debug("\n");

1 0

Speaking opportunities and CfPs
by Carl-Daniel Hailfinger 26 Jan '09

26 Jan '09

Hi, I'm pretty sure most of us occassionally stumble upon conferences and Calls for Papers where coreboot would fit pretty well. Is there any way to make sure such opportunities don't go unnoticed? Maybe a wiki page? Or should everything be sent to the list? I just found a CfP for the Virus Bulletin 2009 conference which looks like it could make coreboot known in the antivirus industry (which might lead to interesting developments). http://www.virusbtn.com/conference/vb2009/call/index Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

ADLO -> SeaBIOS
by Carl-Daniel Hailfinger 25 Jan '09

25 Jan '09

Hi, the coreboot wiki still suggests to use ADLO for booting Windows and does not mention the usability of SeaBIOS with Windows at all. I tried to add a bit of information, but since I don't have access to any coreboot machine right now, the info I can add is pretty limited. Could someone who uses SeaBIOS please do a wiki search on ADLO and Windows and mention SeaBIOS everywhere as preferred way to get Windows running? Thanks. Regards, Carl-Daniel -- http://www.hailfinger.org/

5 6

← Newer
1
...
7
8
9
10
11
12
13
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2009