coreboot April 2008

coreboot@coreboot.org

75 participants
404 discussions

Patch for ST M50FLW080A support
by Claus Gindhart 26 Apr '08

26 Apr '08

The generic jedec.c does not work for the ST M50FLW flash devices, because they need an unlock command first. For this reason, ST M50FLW support is moved to a new HW support module, because any change in jedec.c would bear the risk to cause problems with the already supported devices. It's already tested with ST M50FLW080A; the other chips of this family i dont have available, so i couldn test it. --- Mit freundlichen Grüßen / Best regards Claus Gindhart SW R&D Kontron Modular Computers phone :++49 (0)8341-803-374 mailto:claus.gindhart@kontron.com http://www.kontron.com Kontron Modular Computers GmbH Geschaeftsfuehrer / Managing Directors: Ulrich Gehrmann, Thomas Sabisch Sitz der Gesellschaft / Registered Office: Kaufbeuren, Rechtsform / Legal: GmbH Amtsgericht / Local District Court Kempten, HRB Nr. / Trade Register No. 6195 The information contained in this document is CONFIDENTIAL and property of Kontron. Any unauthorized review, use, disclosure or distribution is prohibited without express written consent of Kontron. If you are not the intended recipient, please contact the sender and destroy all copies of the original message and enclosed attachments. Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen und ist Eigentum von Kontron. Die Verwendung und Weitergabe von jeglichen Inhalten ist ohne ausdrückliche schriftliche Genehmigung von Kontron strikt untersagt. Wenn Sie diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten diese Mail und enthaltene Dokumente.

5 4

Re: [coreboot] [OT]: Thread view [Was: Re: pcidevicememoryallocationproblem]
by joe＠settoplinux.org 26 Apr '08

26 Apr '08

Original Message: ----------------- From: joe(a)settoplinux.org Date: Fri, 25 Apr 2008 12:36:03 -0400 To: c-d.hailfinger.devel.2006(a)gmx.net, coreboot(a)coreboot.org Subject: Re: [coreboot] [OT]: Thread view [Was: Re: pcidevicememoryallocationproblem] >On 25.04.2008 16:33, joe(a)settoplinux.org wrote: >>> On 25.04.2008 11:16, joe(a)settoplinux.org wrote: >>> >>>>> Dear list readers, >>>>> >>>>> >>>>> just a short question. I am using the thread view feature of Evolution. >>>>> But all the replies from Joseph are not sorted correctly and shown by >>>>> there own. >>>>> >>>>> Is somebody else experiencing this? >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> Paul >>>>> >>>>> >>>>> PS: The archive also does not thread it correctly (see [1] e. g. >>>>> [coreboot] pci device memory allocation problem ). >>>>> >>>>> >>>>> [1] http://www.coreboot.org/pipermail/coreboot/2008-April/thread.html >>>>> >>>>> >>>>> >>>> Hmm, why would it do that?? >>>> >>>> >>> Your mailer is broken. It does not create an In-Reply-To header, making >>> it impossible to determine which mail it is ansering to. >>> >>> >> AHH, more email problems :-( >> I'm using IMAP, would that make a difference? Or would this have to do with >SMTP? >> > >Neither. The mail client/webmail interface you're using is broken. The >headers look suspiciously like you're using the 1&1 webmail frontend. If >not, please tell us which e-mail program you'r using locally for these >mails. > You got it Carl-Daniel. When I am at work, and in Linux I use the "1&1 webmail frontend". When I am in windows I use Outlook with IMAP. This email came from the "1&1 webmail frontend". I need to use a web based solution at work, what are my options? Well, I am trying out mail2web, we'll see how that goes.... -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org -------------------------------------------------------------------- mail2web.com Enhanced email for the mobile individual based on Microsoft® Exchange - http://link.mail2web.com/Personal/EnhancedEmail

4 4

PS/2 keyboard/mouse not working on IT8712F (here: Asus A8N-E)
by Andy Jakobs 26 Apr '08

26 Apr '08

Dear all, >From the WIKI's Asus A8N-E Build Tutorial: "Currently PS/2 keyboards do not work, but USB keyboards do." I can confirm that PS/2 still does not work. Unfortunately I do not have a USB keyboard anymore; once I tested it did not work, too. Is this a A8N-E topic only? All other mainboards with that superio are without such a problem? The A8N-E boots with coreboot-v2 and I could reach a console over the serial port from a second computer. Is anyone investigating this behaviour? Unfortunately I do not have C programming skills yet. I promise to learn, but I assume to do research-programming a mainboard is just a much higher level. So thanks for all the good work until now and any answers to my topic! -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

4 5

Re: [coreboot] r667 - coreboot-v3/util/dtc
by Carl-Daniel Hailfinger 26 Apr '08

26 Apr '08

On 26.04.2008 14:05, svn(a)coreboot.org wrote: > Author: ward > Date: 2008-04-26 14:05:08 +0200 (Sat, 26 Apr 2008) > New Revision: 667 > > Modified: > coreboot-v3/util/dtc/livetree.c > Log: > > Fix code warning - val.type is a char, and NULL is not. > > Thanks to Carl-Daniel for spotting this one, and Segher for providing the solution right away. > > This is a trivial patch. > > Signed-off-by: Ward Vandewege <ward(a)gnu.org> > Acked-by: Ward Vandewege <ward(a)gnu.org> > Thanks for fixing this! Regards, Carl-Daniel

1 0

r667 - coreboot-v3/util/dtc
by svn＠coreboot.org 26 Apr '08

26 Apr '08

Author: ward Date: 2008-04-26 14:05:08 +0200 (Sat, 26 Apr 2008) New Revision: 667 Modified: coreboot-v3/util/dtc/livetree.c Log: Fix code warning - val.type is a char, and NULL is not. Thanks to Carl-Daniel for spotting this one, and Segher for providing the solution right away. This is a trivial patch. Signed-off-by: Ward Vandewege <ward(a)gnu.org> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: coreboot-v3/util/dtc/livetree.c =================================================================== --- coreboot-v3/util/dtc/livetree.c 2008-04-24 20:45:57 UTC (rev 666) +++ coreboot-v3/util/dtc/livetree.c 2008-04-26 12:05:08 UTC (rev 667) @@ -32,7 +32,7 @@ new->name = name; new->val = val; - if (new->val.type == NULL) { + if (new->val.type == '\0') { new->val.type = 'S'; // Default to 'scalar' type; if this is a cell or byte value, type will already be set }

1 0

r3267 build service
by coreboot information 26 Apr '08

26 Apr '08

Dear coreboot readers! This is the automated build check service of coreboot. The developer "mjones" checked in revision 3267 to the coreboot source repository and caused the following changes: Change Log: Change abuild ROM_IMAGE_SIZE to match the standard s_c_fam10 Config.lb. The FAM10 code takes up more space in the uncompressed "ROMCC" portion of coreboot. Also, It is still growing as features are added. Signed-off-by: Marc Jones <marc.jones(a)amd.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Build Log: Compilation of amd:serengeti_cheetah_fam10 has been fixed If something broke during this checkin please be a pain in mjones's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

libpayload: add gettimeofday()
by Jordan Crouse 26 Apr '08

26 Apr '08

Add a simple gettimeofday() implementation. If you find my math laughable, then please fix it. :) We don't have an OS underneath constantly correcting the time math, so this will drift away from RTC fairly quickly. Its good for small intervals of time, but if you need to figure out what time it is, use the rtc_read_clock() function (hm - mabye I should rename that localtime?) Also, add in a NVRAM function to make sure we get a stable date value. Please review and comment. -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.

2 5

[patch 0/4] Various libpayload fixes
by jordan.crouse＠amd.com 26 Apr '08

26 Apr '08

Here's a chunk of patches fixing various bugs in libpayload. -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.

5 13

r3272 - in trunk/payloads/libpayload: drivers i386 include include/arch libc
by svn＠coreboot.org 26 Apr '08

26 Apr '08

Author: jcrouse Date: 2008-04-26 01:11:02 +0200 (Sat, 26 Apr 2008) New Revision: 3272 Added: trunk/payloads/libpayload/libc/time.c Modified: trunk/payloads/libpayload/drivers/nvram.c trunk/payloads/libpayload/i386/timer.c trunk/payloads/libpayload/include/arch/rdtsc.h trunk/payloads/libpayload/include/arch/types.h trunk/payloads/libpayload/include/libpayload.h trunk/payloads/libpayload/libc/Makefile.inc Log: libpayload: Add gettimeofday() and friends Add a gettimeofday() implementation - it works pretty well, but it drifts a little bit so its not very suitable for keeping time. It works best to track changes in time over small periods of time. Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/payloads/libpayload/drivers/nvram.c =================================================================== --- trunk/payloads/libpayload/drivers/nvram.c 2008-04-25 23:10:23 UTC (rev 3271) +++ trunk/payloads/libpayload/drivers/nvram.c 2008-04-25 23:11:02 UTC (rev 3272) @@ -93,3 +93,43 @@ outb(addr, rtc_port); outb(val, rtc_port + 1); } + +/** + * Return 1 if the NVRAM is currently updating and a 0 otherwise + * @return A 1 if the NVRAM is updating and 0 otherwise + */ + +int nvram_updating(void) +{ + return (nvram_read(NVRAM_RTC_FREQ_SELECT) & NVRAM_RTC_UIP) ? 1 : 0; +} + +/** + * Get the current time and date from the RTC + * + * @param time A pointer to a broken-down time structure + */ +void rtc_read_clock(struct tm *time) +{ + memset(time, 0, sizeof(*time)); + + while(nvram_updating()); + + time->tm_mon = bcd2dec(nvram_read(NVRAM_RTC_MONTH)) - 1; + time->tm_sec = bcd2dec(nvram_read(NVRAM_RTC_SECONDS)); + time->tm_min = bcd2dec(nvram_read(NVRAM_RTC_MINUTES)); + time->tm_mday = bcd2dec(nvram_read(NVRAM_RTC_DAY)); + time->tm_hour = bcd2dec(nvram_read(NVRAM_RTC_HOURS)); + + /* Instead of finding the century register, + we just make an assumption that if the year value is + less then 80, then it is 2000+ + */ + + time->tm_year = bcd2dec(nvram_read(NVRAM_RTC_YEAR)); + + if (time->tm_year < 80) + time->tm_year += 100; +} + + Modified: trunk/payloads/libpayload/i386/timer.c =================================================================== --- trunk/payloads/libpayload/i386/timer.c 2008-04-25 23:10:23 UTC (rev 3271) +++ trunk/payloads/libpayload/i386/timer.c 2008-04-25 23:11:02 UTC (rev 3272) @@ -30,7 +30,7 @@ #include <libpayload.h> #include <arch/rdtsc.h> -static unsigned int cpu_khz; +unsigned int cpu_khz; /** * Calculate the speed of the processor for use in delays. Modified: trunk/payloads/libpayload/include/arch/rdtsc.h =================================================================== --- trunk/payloads/libpayload/include/arch/rdtsc.h 2008-04-25 23:10:23 UTC (rev 3271) +++ trunk/payloads/libpayload/include/arch/rdtsc.h 2008-04-25 23:11:02 UTC (rev 3272) @@ -30,9 +30,9 @@ #ifndef _ARCH_RDTSC_H #define _ARCH_RDTSC_H -static inline unsigned long long rdtsc(void) +static u64 rdtsc(void) { - unsigned long long val; + u64 val; __asm__ __volatile__ ("rdtsc" : "=A" (val)); return val; } Modified: trunk/payloads/libpayload/include/arch/types.h =================================================================== --- trunk/payloads/libpayload/include/arch/types.h 2008-04-25 23:10:23 UTC (rev 3271) +++ trunk/payloads/libpayload/include/arch/types.h 2008-04-25 23:11:02 UTC (rev 3272) @@ -50,6 +50,9 @@ typedef signed long long int64_t; typedef signed long long s64; +typedef long time_t; +typedef long suseconds_t; + #ifndef NULL #define NULL ((void *)0) #endif Modified: trunk/payloads/libpayload/include/libpayload.h =================================================================== --- trunk/payloads/libpayload/include/libpayload.h 2008-04-25 23:10:23 UTC (rev 3271) +++ trunk/payloads/libpayload/include/libpayload.h 2008-04-25 23:11:02 UTC (rev 3272) @@ -61,10 +61,26 @@ #define NVRAM_RTC_DAY 7 #define NVRAM_RTC_MONTH 8 #define NVRAM_RTC_YEAR 9 +#define NVRAM_RTC_FREQ_SELECT 10 +#define NVRAM_RTC_UIP 0x80 +struct tm { + int tm_sec; + int tm_min; + int tm_hour; + int tm_mday; + int tm_mon; + int tm_year; + int tm_wday; + int tm_yday; + int tm_isdst; +}; + /* drivers/nvram.c */ u8 nvram_read(u8 addr); void nvram_write(u8 val, u8 addr); +int nvram_updating(void); +void rtc_read_clock(struct tm *tm); /* drivers/keyboard.c */ void keyboard_init(void); @@ -182,6 +198,15 @@ char *strdup(const char *s); char *strstr(const char *h, const char *n); +/* libc/time.c */ + +struct timeval { + time_t tv_sec; + suseconds_t tv_usec; +}; + +int gettimeofday(struct timeval *tv, void *tz); + /* i386/coreboot.c */ int get_coreboot_info(struct sysinfo_t *info); Modified: trunk/payloads/libpayload/libc/Makefile.inc =================================================================== --- trunk/payloads/libpayload/libc/Makefile.inc 2008-04-25 23:10:23 UTC (rev 3271) +++ trunk/payloads/libpayload/libc/Makefile.inc 2008-04-25 23:11:02 UTC (rev 3272) @@ -29,4 +29,4 @@ TARGETS-y += libc/malloc.o libc/printf.o libc/console.o libc/string.o TARGETS-y += libc/memory.o libc/ctype.o libc/ipchecksum.o libc/lib.o -TARGETS-y += libc/rand.o +TARGETS-y += libc/rand.o libc/time.o Added: trunk/payloads/libpayload/libc/time.c =================================================================== --- trunk/payloads/libpayload/libc/time.c (rev 0) +++ trunk/payloads/libpayload/libc/time.c 2008-04-25 23:11:02 UTC (rev 3272) @@ -0,0 +1,128 @@ +/* + * This file is part of the libpayload project. + * + * Copyright (C) 2008 Advanced Micro Devices, Inc. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. The name of the author may not be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#include <libpayload.h> +#include <arch/rdtsc.h> + +extern u32 cpu_khz; + +static struct { + u64 ticks; + time_t secs; + suseconds_t usecs; +} clock; + +#define TICKS_PER_SEC (cpu_khz * 1000) +#define TICKS_PER_USEC (cpu_khz / 1000) + +static void update_clock(void) +{ + u64 delta = rdtsc() - clock.ticks; + int secs; + + clock.ticks += delta; + + secs = (int) (delta / TICKS_PER_SEC); + clock.secs += secs; + delta -= (secs * TICKS_PER_SEC); + clock.usecs += (int) (delta / TICKS_PER_USEC); + + if (clock.usecs > 1000000) { + clock.usecs -= 1000000; + clock.secs++; + } +} + +#ifdef CONFIG_NVRAM + +static unsigned int day_of_year(int mon, int day, int year) +{ + static u8 mdays[12] = { 31, 28, 31, 30, 31, 30, + 31, 31, 30, 31, 30, 31 }; + + int i, ret = 0; + + for(i = 0; i < mon; i++) { + ret += mdays[i]; + + if (i == 1 && (year % 4)) + ret++; + } + + return (ret + day); +} + +static void gettimeofday_init(void) +{ + int days, delta; + struct tm tm; + + rtc_read_clock(&tm); + clock.ticks = rdtsc(); + + /* Calculate the number of days in the year so far */ + days = day_of_year(tm.tm_mon, tm.tm_mday, tm.tm_year + 1900); + + delta = tm.tm_year - 70; + + days += (delta * 365); + + /* Figure leap years */ + + if (delta > 2) + days += (delta - 2) / 4; + + clock.secs = (days * 86400) + (tm.tm_hour * 3600) + + (tm.tm_min * 60) + tm.tm_sec; +} +#else +static void gettimeofday_init(void) +{ + /* Record the number of ticks */ + clock.ticks = rdtsc(); +} +#endif + +int gettimeofday(struct timeval *tv, void *tz) +{ + /* Call the gtod init when we need it - this keeps + the code from being included in the binary if we don't + need it + */ + + if (!clock.ticks) + gettimeofday_init(); + + update_clock(); + + tv->tv_sec = clock.secs; + tv->tv_usec = clock.usecs; + + return 0; +}

1 0

r3271 - trunk/payloads/libpayload/libc
by svn＠coreboot.org 26 Apr '08

26 Apr '08

Author: jcrouse Date: 2008-04-26 01:10:23 +0200 (Sat, 26 Apr 2008) New Revision: 3271 Modified: trunk/payloads/libpayload/libc/printf.c Log: libpayload: Fix a small but aggressive bug in printf() This was causing the returned counter value to be one more then it should be when printing a single character. Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: trunk/payloads/libpayload/libc/printf.c =================================================================== --- trunk/payloads/libpayload/libc/printf.c 2008-04-25 23:09:39 UTC (rev 3270) +++ trunk/payloads/libpayload/libc/printf.c 2008-04-25 23:10:23 UTC (rev 3271) @@ -156,7 +156,7 @@ ++counter; } - return ++counter; + return counter; } /**

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2008