coreboot April 2008

coreboot@coreboot.org

75 participants
404 discussions

r165 - buildrom-devel
by svn＠coreboot.org 25 Apr '08

25 Apr '08

Author: jcrouse Date: 2008-04-25 17:40:25 +0200 (Fri, 25 Apr 2008) New Revision: 165 Modified: buildrom-devel/Makefile Log: buildrom: payloads should be parsed as ELFs with compression or not Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: buildrom-devel/Makefile =================================================================== --- buildrom-devel/Makefile 2008-04-25 15:24:46 UTC (rev 164) +++ buildrom-devel/Makefile 2008-04-25 15:40:25 UTC (rev 165) @@ -71,12 +71,10 @@ # If compressing the payload in v3, parse the elf and tell lar to compress it. # Parsing the elf without compression bloats the ROM with bss zeroes. -ifeq ($(CONFIG_USE_LZMA),y) -LAR_PAYLOAD_FLAGS=-a -e -C lzma -else -LAR_PAYLOAD_FLAGS=-a -endif - + +LAR_PAYLOAD_FLAGS-y=-a -e +LAR_PAYLOAD_FLAGS-$(CONFIG_USE_LZMA) += -C lzma + ifeq ($(or $(CONFIG_VSA_LEGACY), $(CONFIG_VSA_OPENVSA)),) else OPTIONROM_TARGETS+=geodevsa @@ -84,15 +82,15 @@ rom: $(HOSTTOOLS-y) payload $(COREBOOT-y) @ cp $(CBV3_OUTPUT) $(TARGET_ROM_FILE) - @ $(STAGING_DIR)/bin/lar $(LAR_PAYLOAD_FLAGS) $(TARGET_ROM_FILE) $(CBV3_PAYLOAD_TARGET):normal/payload + @ $(STAGING_DIR)/bin/lar $(LAR_PAYLOAD_FLAGS-y) $(TARGET_ROM_FILE) $(CBV3_PAYLOAD_TARGET):normal/payload ifeq ($(CONFIG_VSA_LEGACY),y) - @ $(STAGING_DIR)/bin/lar $(LAR_PAYLOAD_FLAGS) $(TARGET_ROM_FILE) $(SOURCE_DIR)/amd_vsa_lx_1.01.bin:blob/vsa + @ $(STAGING_DIR)/bin/lar $(LAR_PAYLOAD_FLAGS-y) $(TARGET_ROM_FILE) $(SOURCE_DIR)/amd_vsa_lx_1.01.bin:blob/vsa endif ifeq ($(CONFIG_VSA_OPENVSA),y) @ echo "Adding OpenVSA: TODO FIXME - let's actually implement this?" endif @ for file in `ls $(ROM_DIR)`; do \ - $(STAGING_DIR)/bin/lar $(LAR_PAYLOAD_FLAGS) $(TARGET_ROM_FILE) $(ROM_DIR)/$$file:$$file; \ + $(STAGING_DIR)/bin/lar $(LAR_PAYLOAD_FLAGS-y) $(TARGET_ROM_FILE) $(ROM_DIR)/$$file:$$file; \ done @ $(STAGING_DIR)/bin/lar -z $(TARGET_ROM_FILE) endif

1 0

r164 - in buildrom-devel/packages: busybox coreboot-v2 coreboot-v3 coreinfo etherboot filo geodevsa gpxe grub2 kernel kexec-boot-loader kexec-tools libpayload lzma memtest mkelfimage ofw qemu tint uclibc unifdef utils wireless-tools
by svn＠coreboot.org 25 Apr '08

25 Apr '08

Author: ward Date: 2008-04-25 17:24:46 +0200 (Fri, 25 Apr 2008) New Revision: 164 Modified: buildrom-devel/packages/busybox/busybox.mk buildrom-devel/packages/coreboot-v2/coreboot.inc buildrom-devel/packages/coreboot-v3/coreboot-v3.mk buildrom-devel/packages/coreinfo/coreinfo.mk buildrom-devel/packages/etherboot/etherboot.mk buildrom-devel/packages/filo/filo.mk buildrom-devel/packages/geodevsa/geodevsa.mk buildrom-devel/packages/gpxe/gpxe.mk buildrom-devel/packages/grub2/grub2.mk buildrom-devel/packages/kernel/kernel.inc buildrom-devel/packages/kexec-boot-loader/kexec-boot-loader.mk buildrom-devel/packages/kexec-tools/kexec-tools.mk buildrom-devel/packages/libpayload/libpayload.mk buildrom-devel/packages/lzma/lzma.mk buildrom-devel/packages/memtest/memtest.mk buildrom-devel/packages/mkelfimage/mkelfimage.mk buildrom-devel/packages/ofw/ofw.mk buildrom-devel/packages/qemu/qemu.mk buildrom-devel/packages/tint/tint.mk buildrom-devel/packages/uclibc/uclibc.mk buildrom-devel/packages/unifdef/unifdef.mk buildrom-devel/packages/utils/nrv2b.mk buildrom-devel/packages/wireless-tools/wireless-tools.mk Log: There should not be any quotes in the wildcard command. This patch makes 'make clean' work again. This is a trivial patch. Signed-off-by: Ward Vandewege <ward(a)gnu.org> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: buildrom-devel/packages/busybox/busybox.mk =================================================================== --- buildrom-devel/packages/busybox/busybox.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/busybox/busybox.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -66,7 +66,7 @@ busybox-clean: @ echo "Cleaning busybox..." -ifneq ($(wildcard "$(BUSYBOX_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(BUSYBOX_SRC_DIR)/Makefile),) @ $(MAKE) -C $(BUSYBOX_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/coreboot-v2/coreboot.inc =================================================================== --- buildrom-devel/packages/coreboot-v2/coreboot.inc 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/coreboot-v2/coreboot.inc 2008-04-25 15:24:46 UTC (rev 164) @@ -109,7 +109,7 @@ generic-coreboot-clean: @ echo "Cleaning coreboot..." @ rm -f $(CBV2_PAYLOAD_TARGET) -ifneq ($(wildcard "$(CBV2_BUILD_DIR)/Makefile"),) +ifneq ($(wildcard $(CBV2_BUILD_DIR)/Makefile),) $(MAKE) -C $(CBV2_BUILD_DIR) clean > /dev/null 2>&1; endif @ rm -f $(CBV2_OUTPUT) Modified: buildrom-devel/packages/coreboot-v3/coreboot-v3.mk =================================================================== --- buildrom-devel/packages/coreboot-v3/coreboot-v3.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/coreboot-v3/coreboot-v3.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -90,7 +90,7 @@ coreboot-v3-clean: @ echo "Cleaning coreboot v3..." -ifneq ($(wildcard "$(CBV3_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(CBV3_SRC_DIR)/Makefile),) @ $(MAKE) -C $(CBV3_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/coreinfo/coreinfo.mk =================================================================== --- buildrom-devel/packages/coreinfo/coreinfo.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/coreinfo/coreinfo.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -50,7 +50,7 @@ coreinfo-clean: @ echo "Cleaning coreinfo..." -ifneq ($(wildcard "$(COREINFO_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(COREINFO_SRC_DIR)/Makefile),) @ $(MAKE) -C $(COREINFO_SRC_DIR) clean > /dev/null 2>&1 endif @ rm -f $(COREINFO_STAMP_DIR)/.installed Modified: buildrom-devel/packages/etherboot/etherboot.mk =================================================================== --- buildrom-devel/packages/etherboot/etherboot.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/etherboot/etherboot.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -57,7 +57,7 @@ etherboot-clean: @ echo "Cleaning etherboot..." -ifneq ($(wildcard "$(ETHERBOOT_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(ETHERBOOT_SRC_DIR)/Makefile),) @ $(MAKE) -C $(ETHERBOOT_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/filo/filo.mk =================================================================== --- buildrom-devel/packages/filo/filo.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/filo/filo.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -66,7 +66,7 @@ filo-clean: @ echo "Cleaning filo..." -ifneq ($(wildcard "$(FILO_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(FILO_SRC_DIR)/Makefile),) @ $(MAKE) -C $(FILO_SRC_DIR) clean > /dev/null 2>&1 endif @ rm -f $(FILO_STAMP_DIR)/.copied Modified: buildrom-devel/packages/geodevsa/geodevsa.mk =================================================================== --- buildrom-devel/packages/geodevsa/geodevsa.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/geodevsa/geodevsa.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -31,7 +31,7 @@ $(GEODE_PADDED_VSA): $(GEODE_COMPRESSED_VSA) @ cp $< $@ @ (size=`stat -c %s $<`; count=`expr $(GEODE_VSA_SIZE) - $$size`; \ - dd if=/dev/zero bs=1 count=$$count >> $@ 2> /dev/null) + @ dd if=/dev/zero bs=1 count=$$count >> $@ 2> /dev/null) geodevsa: $(VSA_BUILD_TARGET) Modified: buildrom-devel/packages/gpxe/gpxe.mk =================================================================== --- buildrom-devel/packages/gpxe/gpxe.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/gpxe/gpxe.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -66,7 +66,7 @@ gpxe-clean: @ echo "Cleaning GPXE..." -ifneq ($(wildcard "$(GPXE_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(GPXE_SRC_DIR)/Makefile),) @ $(MAKE) -C $(GPXE_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/grub2/grub2.mk =================================================================== --- buildrom-devel/packages/grub2/grub2.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/grub2/grub2.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -69,7 +69,7 @@ @ rm -f $(GRUB2_DIR)/grub2.elf @ rm -f $(GRUB2_STAMP_DIR)/.copied @ rm -f $(GRUB2_STAMP_DIR)/.installed -ifneq ($(wildcard "$(GRUB_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(GRUB_SRC_DIR)/Makefile),) @ $(MAKE) -C $(GRUB2_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/kernel/kernel.inc =================================================================== --- buildrom-devel/packages/kernel/kernel.inc 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/kernel/kernel.inc 2008-04-25 15:24:46 UTC (rev 164) @@ -88,7 +88,7 @@ generic-kernel-clean: @ echo "Cleaning kernel..." -ifneq ($(wildcard "$(KERNEL_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(KERNEL_SRC_DIR)/Makefile),) $(MAKE) -C $(KERNEL_SRC_DIR) clean > /dev/null 2>&1; endif Modified: buildrom-devel/packages/kexec-boot-loader/kexec-boot-loader.mk =================================================================== --- buildrom-devel/packages/kexec-boot-loader/kexec-boot-loader.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/kexec-boot-loader/kexec-boot-loader.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -56,7 +56,7 @@ kexec-boot-loader-clean: @ echo "Cleaning kexec-boot-loader..." -ifneq ($(wildcard "$(KBL_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(KBL_SRC_DIR)/Makefile),) @ $(MAKE) -C $(KBL_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/kexec-tools/kexec-tools.mk =================================================================== --- buildrom-devel/packages/kexec-tools/kexec-tools.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/kexec-tools/kexec-tools.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -32,7 +32,7 @@ kexec-tools: $(KEXEC_STAMP_DIR) $(INITRD_DIR)/sbin/kexec-tools kexec-tools-clean: -ifneq ($(wildcard "$(KEXEC_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(KEXEC_SRC_DIR)/Makefile),) $(MAKE) -C $(KEXEC_SRC_DIR) clean endif rm -f $(KEXEC_SRC_DIR)/.config Modified: buildrom-devel/packages/libpayload/libpayload.mk =================================================================== --- buildrom-devel/packages/libpayload/libpayload.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/libpayload/libpayload.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -65,7 +65,7 @@ libpayload-clean: @ echo "Cleaning libpayload..." -ifneq ($(wildcard "$(LIBPAYLOAD_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(LIBPAYLOAD_SRC_DIR)/Makefile),) @ $(MAKE) -C $(LIBPAYLOAD_SRC_DIR) clean > /dev/null 2>&1 endif @ rm -f $(LIBPAYLOAD_STAMP_DIR)/.installed Modified: buildrom-devel/packages/lzma/lzma.mk =================================================================== --- buildrom-devel/packages/lzma/lzma.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/lzma/lzma.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -40,7 +40,7 @@ lzma-clean: @ echo "Cleaning lzma..." -ifneq ($(wildcard "$(LZMA_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(LZMA_SRC_DIR)/Makefile),) @ $(MAKE) -C $(LZMA_SRC_DIR)/C/7zip/Compress/LZMA_Alone -f makefile.gcc clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/memtest/memtest.mk =================================================================== --- buildrom-devel/packages/memtest/memtest.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/memtest/memtest.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -47,7 +47,7 @@ memtest-clean: @ echo "Cleaning memtest..." -ifneq ($(wildcard "$(MEMTEST_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(MEMTEST_SRC_DIR)/Makefile),) @ $(MAKE) -C $(MEMTEST_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/mkelfimage/mkelfimage.mk =================================================================== --- buildrom-devel/packages/mkelfimage/mkelfimage.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/mkelfimage/mkelfimage.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -51,7 +51,7 @@ mkelfimage: $(STAGING_DIR)/sbin/mkelfImage mkelfimage-clean: -ifneq ($(wildcard "$(MKELFIMAGE_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(MKELFIMAGE_SRC_DIR)/Makefile),) $(MAKE) -C $(MKELFIMAGE_SRC_DIR) clean endif Modified: buildrom-devel/packages/ofw/ofw.mk =================================================================== --- buildrom-devel/packages/ofw/ofw.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/ofw/ofw.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -52,7 +52,7 @@ ofw-clean: @ echo "Cleaning Openfirmware..." -ifneq ($(wildcard "$(OFW_BUILD_DIR)/Makefile"),) +ifneq ($(wildcard $(OFW_BUILD_DIR)/Makefile),) @ $(MAKE) -C $(OFW_BUILD_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/qemu/qemu.mk =================================================================== --- buildrom-devel/packages/qemu/qemu.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/qemu/qemu.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -45,7 +45,7 @@ qemu: $(QEMU_STAMP_DIR) $(QEMU_LOG_DIR) $(QEMU_SRC_DIR)/i386-softmmu/qemu qemu-clean: -ifneq ($(wildcard "$(QEMU_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(QEMU_SRC_DIR)/Makefile),) $(MAKE) -C $(QEMU_SRC_DIR) clean endif Modified: buildrom-devel/packages/tint/tint.mk =================================================================== --- buildrom-devel/packages/tint/tint.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/tint/tint.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -46,7 +46,7 @@ tint-clean: @ echo "Cleaning TINT..." -ifneq ($(wildcard "$(TINT_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(TINT_SRC_DIR)/Makefile),) @ $(MAKE) -C $(TINT_SRC_DIR) clean endif @ rm -f $(TINT_STAMP_DIR)/.copied Modified: buildrom-devel/packages/uclibc/uclibc.mk =================================================================== --- buildrom-devel/packages/uclibc/uclibc.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/uclibc/uclibc.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -80,7 +80,7 @@ uclibc-clean: @ echo "Cleaning uclibc..." -ifneq ($(wildcard "$(UCLIBC_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(UCLIBC_SRC_DIR)/Makefile),) @ $(MAKE) -C $(UCLIBC_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/unifdef/unifdef.mk =================================================================== --- buildrom-devel/packages/unifdef/unifdef.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/unifdef/unifdef.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -38,7 +38,7 @@ unifdef: $(STAGING_DIR)/host/bin/unifdef unifdef-clean: -ifneq ($(wildcard "$(UNIFDEF_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(UNIFDEF_SRC_DIR)/Makefile),) @ $(MAKE) -C $(UNIFDEF_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/utils/nrv2b.mk =================================================================== --- buildrom-devel/packages/utils/nrv2b.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/utils/nrv2b.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -40,7 +40,7 @@ nrv2b-clean: @ echo "Cleaning nrv2b..." -ifneq ($(wildcard "$(NRV2B_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(NRV2B_SRC_DIR)/Makefile),) @ $(MAKE) -C $(NRV2B_SRC_DIR) clean > /dev/null 2>&1 endif Modified: buildrom-devel/packages/wireless-tools/wireless-tools.mk =================================================================== --- buildrom-devel/packages/wireless-tools/wireless-tools.mk 2008-04-24 23:51:32 UTC (rev 163) +++ buildrom-devel/packages/wireless-tools/wireless-tools.mk 2008-04-25 15:24:46 UTC (rev 164) @@ -51,7 +51,7 @@ wireless-tools-clean: @ echo "Cleaning wireless-tools..." -ifneq ($(wildcard "$(WIRELESS_SRC_DIR)/Makefile"),) +ifneq ($(wildcard $(WIRELESS_SRC_DIR)/Makefile),) @ $(MAKE) -C $(WIRELESS_SRC_DIR) realclean > /dev/null 2>&1 endif @ rm -f $(WIRELESS_SRC_DIR)/.config

1 0

Re: [coreboot] [OT]: Thread view [Was: Re: pci devicememoryallocationproblem]
by joe＠settoplinux.org 25 Apr '08

25 Apr '08

>On 25.04.2008 11:16, joe(a)settoplinux.org wrote: >>> Dear list readers, >>> >>> >>> just a short question. I am using the thread view feature of Evolution. >>> But all the replies from Joseph are not sorted correctly and shown by >>> there own. >>> >>> Is somebody else experiencing this? >>> >>> >>> Thanks, >>> >>> Paul >>> >>> >>> PS: The archive also does not thread it correctly (see [1] e. g. >>> [coreboot] pci device memory allocation problem ). >>> >>> >>> [1] http://www.coreboot.org/pipermail/coreboot/2008-April/thread.html >>> >>> >> Hmm, why would it do that?? >> > >Your mailer is broken. It does not create an In-Reply-To header, making >it impossible to determine which mail it is ansering to. > AHH, more email problems :-( I'm using IMAP, would that make a difference? Or would this have to do with SMTP? -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

4 3

Where to get a Winbond W39V040BPZ chip?
by Richard Stellingwerff 25 Apr '08

25 Apr '08

Hi, I finally got my Jetway J7F41G2E-PB board. I have identified the BIOS chip as a Winbond W39V040BPZ. Does anyone know where I can order an extra chip that I use as a backup? Also, does it have to be a Winbond W39V040BPZ or can I get an alternative? Preferably I would like to get one at a local electronics shop, but the one I went to said he didn't have it, and that it would be very difficult to get one. I find that hard to believe, though. Should I try another electronics shop, or are you guys sure I won't it there? Kind regards, Richard.

5 13

Filo console on QEMU
by Myles Watson 25 Apr '08

25 Apr '08

Anyone know what happened to the VGA output of FILO for QEMU? It used to work, the config file sets VGA_CONSOLE=1, but it only comes out the serial output. VGA is now working again (works with tint), so I'm not sure what's going on. Thanks, Myles

1 0

Re: [coreboot] [OT]: Thread view [Was: Re: pci device memoryallocationproblem]
by joe＠settoplinux.org 25 Apr '08

25 Apr '08

>Dear list readers, > > >just a short question. I am using the thread view feature of Evolution. >But all the replies from Joseph are not sorted correctly and shown by >there own. > >Is somebody else experiencing this? > > >Thanks, > >Paul > > >PS: The archive also does not thread it correctly (see [1] e. g. >[coreboot] pci device memory allocation problem ). > > >[1] http://www.coreboot.org/pipermail/coreboot/2008-April/thread.html > Hmm, why would it do that?? -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

3 2

Re: [coreboot] pci device memory allocation problem
by joe＠settoplinux.org 25 Apr '08

25 Apr '08

>> I noticed this problem, if certian devices are disabled (like onboard >> vga for example). The other enabled devices try to use 0xfec00000 for >> memory allocation, causing APIC to fail. >> You just need to add a Signed-Off-By as stated in the development >> guidelines. In the mean time I will test it and if all goes well you'll >get >> my Acked-by, and then it can be commited. >> >Oh, I see. > >Signed-off-by: Aaron Lwe <aaron.lwe(a)gmail.com> Acked-by: Joseph Smith <joe(a)settoplinux.org> Great job Aaron! Works great, attached is the bootlog with vga (device 2.0) completly disabled, and coreboot is not trying to allocate the 0xfec00000 range. commited in r3265 -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

2 1

[pathc][v2] Fam10 name string
by Marc Jones 25 Apr '08

25 Apr '08

-- Marc Jones Senior Firmware Engineer (970) 226-9684 Office mailto:Marc.Jones@amd.com http://www.amd.com/embeddedprocessors Add CPUID processor name string support for Fam10 CPUs. Signed-off-by: Marc Jones <marc.jones(a)amd.com> Index: coreboot-v2/src/cpu/amd/model_10xxx/Config.lb =================================================================== --- coreboot-v2.orig/src/cpu/amd/model_10xxx/Config.lb 2008-04-23 17:39:11.000000000 -0600 +++ coreboot-v2/src/cpu/amd/model_10xxx/Config.lb 2008-04-23 17:41:28.000000000 -0600 @@ -37,3 +37,5 @@ driver model_10xxx_init.o object update_microcode.o object apic_timer.o +object processor_name.o + Index: coreboot-v2/src/cpu/amd/model_10xxx/model_10xxx_init.c =================================================================== --- coreboot-v2.orig/src/cpu/amd/model_10xxx/model_10xxx_init.c 2008-04-23 17:39:11.000000000 -0600 +++ coreboot-v2/src/cpu/amd/model_10xxx/model_10xxx_init.c 2008-04-23 17:41:28.000000000 -0600 @@ -39,13 +39,13 @@ #include <cpu/amd/model_10xxx_msr.h> extern device_t get_node_pci(u32 nodeid, u32 fn); - +extern int init_processor_name(void); #define MCI_STATUS 0x401 -static inline msr_t rdmsr_amd(u32 index) +msr_t rdmsr_amd(u32 index) { msr_t result; __asm__ __volatile__ ( @@ -57,7 +57,7 @@ } -static inline void wrmsr_amd(u32 index, msr_t msr) +void wrmsr_amd(u32 index, msr_t msr) { __asm__ __volatile__ ( "wrmsr" @@ -99,7 +99,9 @@ /* Enable the local cpu apics */ setup_lapic(); - /* FIXME: Update CPUID name strings here */ + /* Set the processor name string */ + init_processor_name(); + #if CONFIG_LOGICAL_CPUS == 1 siblings = cpuid_ecx(0x80000008) & 0xff; Index: coreboot-v2/src/cpu/amd/model_10xxx/processor_name.c =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ coreboot-v2/src/cpu/amd/model_10xxx/processor_name.c 2008-04-23 17:41:28.000000000 -0600 @@ -0,0 +1,252 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2007 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA, 02110-1301 USA + */ + +/* + * This code sets the Processor Name String for AMD64 CPUs. + * + * Revision Guide for AMD Family 10h Processors + * Publication # 41322 Revision: 3.17 Issue Date: February 2008 + */ + +#include <console/console.h> +#include <string.h> +#include <cpu/x86/msr.h> +#include <cpu/cpu.h> + +extern void wrmsr_amd(u32 index, msr_t msr); + +/* The maximum length of CPU names is 48 bytes, including the final NULL byte. + * If you change these names your BIOS will _NOT_ pass the AMD validation and + * your mainboard will not be posted on the AMD Recommended Motherboard Website + */ + + +static inline void strcpy(char *dst, char *src) +{ + while (*src) *dst++ = *src++; +} + + +static const struct { + u8 Pg; + u8 NC; + u8 String1; + char const *value; +} String1_socket_F[] = { + {0x00, 0x01, 0x00, "Dual-Core AMD Opteron(tm) Processor 83"}, + {0x00, 0x01, 0x01, "Dual-Core AMD Opteron(tm) Processor 23"}, + {0x00, 0x03, 0x00, "Quad-Core AMD Opteron(tm) Processor 83"}, + {0x00, 0x03, 0x01, "Quad-Core AMD Opteron(tm) Processor 23"}, + {0x00, 0x03, 0x02, "Embedded AMD Opteron(tm) Processor 83"}, + {0x00, 0x03, 0x03, "Embedded AMD Opteron(tm) Processor 23"}, + {0x00, 0x03, 0x04, "Embedded AMD Opteron(tm) Processor 13"}, + {0x00, 0x03, 0x05, "AMD Phenom(tm) FX-"}, + {0x01, 0x01, 0x01, "Embedded AMD Opteron(tm) Processor"}, +}; + + +static const struct { + u8 Pg; + u8 NC; + u8 String2; + char const *value; +} String2_socket_F[] = { + {0x00, 0xFF, 0x0A, " SE"}, + {0x00, 0xFF, 0x0B, " HE"}, + {0x00, 0xFF, 0x0C, " EE"}, + {0x00, 0xFF, 0x0D, " Quad-Core Processor"}, + {0x00, 0xFF, 0x0F, ""}, + {0x01, 0x01, 0x01, "GF HE"}, +}; + + +static const struct { + u8 Pg; + u8 NC; + u8 String1; + char const *value; +} String1_socket_AM2[] = { + {0x00, 0x00, 0x00, "AMD Athlon(tm) Processor LE-"}, + {0x00, 0x00, 0x01, "AMD Sempron(tm) Processor LE-"}, + {0x00, 0x01, 0x00, "Dual-Core AMD Opteron(tm) Processor 13"}, + {0x00, 0x01, 0x01, "AMD Athlon(tm)"}, + {0x00, 0x02, 0x00, "AMD Phenom(tm)"}, + {0x00, 0x03, 0x00, "Quad-Core AMD Opteron(tm) Processor 13"}, + {0x00, 0x03, 0x01, "AMD Phenom(tm) FX-"}, + {0x00, 0x03, 0x02, "AMD Phenom(tm)"}, +}; + + +static const struct { + u8 Pg; + u8 NC; + u8 String2; + char const *value; +} String2_socket_AM2[] = { + {0x00, 0x00, 0x00, "00"}, + {0x00, 0x00, 0x01, "10"}, + {0x00, 0x00, 0x02, "20"}, + {0x00, 0x00, 0x03, "30"}, + {0x00, 0x00, 0x04, "40"}, + {0x00, 0x00, 0x05, "50"}, + {0x00, 0x00, 0x06, "60"}, + {0x00, 0x00, 0x07, "70"}, + {0x00, 0x00, 0x08, "80"}, + {0x00, 0x00, 0x09, "90"}, + {0x00, 0x01, 0x00, "00 Dual-Core Processor"}, + {0x00, 0x01, 0x01, "00e Dual-Core Processor"}, + {0x00, 0x01, 0x02, "00B Dual-Core Processor"}, + {0x00, 0x01, 0x03, "50 Dual-Core Processor"}, + {0x00, 0x01, 0x04, "50e Dual-Core Processor"}, + {0x00, 0x01, 0x05, "50B Dual-Core Processor"}, + {0x00, 0x02, 0x00, "00 Triple-Core Processor"}, + {0x00, 0x02, 0x01, "00e Triple-Core Processor"}, + {0x00, 0x02, 0x02, "00B Triple-Core Processor"}, + {0x00, 0x02, 0x03, "50 Triple-Core Processor"}, + {0x00, 0x02, 0x04, "50e Triple-Core Processor"}, + {0x00, 0x02, 0x05, "50B Triple-Core Processor"}, + {0x00, 0x03, 0x00, "00 Quad-Core Processor"}, + {0x00, 0x03, 0x01, "00e Quad-Core Processor"}, + {0x00, 0x03, 0x02, "00B Quad-Core Processor"}, + {0x00, 0x03, 0x03, "50 Quad-Core Processor"}, + {0x00, 0x03, 0x04, "50e Quad-Core Processor"}, + {0x00, 0x03, 0x05, "50B Quad-Core Processor"}, + {0x00, 0x03, 0x0A, " SE"}, + {0x00, 0x03, 0x0B, " HE"}, + {0x00, 0x03, 0x0C, " EE"}, + {0x00, 0x03, 0x0D, " Quad-Core Processor"}, + {0x00, 0xFF, 0x0F, ""}, +}; + + +char const *unknown = "AMD Processor model unknown"; +char const *sample = "AMD Engineering Sample"; +char const *thermal = "AMD Thermal Test Kit"; + + +int init_processor_name(void) +{ + /* variable names taken from fam10 revision guide for clarity */ + u32 BrandId; /* CPUID Fn8000_0001_EBX */ + u8 String1; /* BrandID[14:11] */ + u8 String2; /* BrandID[3:0] */ + u8 Model; /* BrandID[10:4] */ + u8 Pg; /* BrandID[15] */ + u8 PkgTyp; /* CPUID Fn8000_0001_EBX.*/ + u8 NC; /* CPUID Fn8000_0008[ECX].*/ + char *processor_name_string = NULL; + char program_string[48]; + u32 *p_program_string = (u32 *)program_string; + msr_t msr; + int i, j; + + + /* Find out which CPU brand it is */ + BrandId = cpuid_ebx(0x80000001); + String1 = (u8)((BrandId >> 11) & 0x0F); + String2 = (u8)((BrandId >> 0) & 0x0F); + Model = (u8)((BrandId >> 4) & 0xFF); + Pg = (u8)((BrandId >> 15) & 0x01); + PkgTyp = (u8)((BrandId >> 28) & 0x0F); + NC = (u8)(cpuid_ecx(0x80000008) & 0xFF); + + /* null the string */ + memset(program_string, 0, 48); + + if (Model > 0) { + /* String1 */ + if (PkgTyp == 0) { /* F1207 */ + for(i = 0; i < sizeof(String1_socket_F)/sizeof(String1_socket_F[0]); i++) { + if ((String1_socket_F[i].Pg == Pg) && + (String1_socket_F[i].NC == NC) && + (String1_socket_F[i].String1 == String1)) { + processor_name_string = String1_socket_F[i].value; + } + } + } else if (PkgTyp == 1) { /* AM2 */ + for(i = 0; i < sizeof(String1_socket_AM2)/sizeof(String1_socket_AM2[0]); i++) { + if ((String1_socket_AM2[i].Pg == Pg) && + (String1_socket_AM2[i].NC == NC) && + (String1_socket_AM2[i].String1 == String1)) { + processor_name_string = String1_socket_AM2[i].value; + } + } + } + + if (processor_name_string) { + strcpy(program_string, processor_name_string); + + /* Translate Model from 01-99 to ASCII and put it on the end. + * Numbers less than 10 should include a leading zero, e.g., 09.*/ + for (j = 0; j < 47; j++) { + if(program_string[j] == 0) { + program_string[j++] = (Model / 10) + '0'; + program_string[j++] = (Model % 10) + '0'; + break; + } + } + /* String 2 */ + processor_name_string = NULL; + + if (PkgTyp == 0) { /* F1207 */ + for(i = 0; i < sizeof(String2_socket_F)/sizeof(String2_socket_F[0]); i++) { + if ((String2_socket_F[i].Pg == Pg) && + (String2_socket_F[i].String2 == String2)) { + processor_name_string = String2_socket_F[i].value; + } + } + + } else if (PkgTyp == 1) { /* AM2 */ + for(i = 0; i < sizeof(String2_socket_AM2)/sizeof(String2_socket_AM2[0]); i++) { + if ((String2_socket_AM2[i].Pg == Pg) && + (String2_socket_AM2[i].NC == NC) && + (String2_socket_AM2[i].String2 == String2)) { + processor_name_string = String2_socket_AM2[i].value; + } + } + } + + if (processor_name_string) { + /* FIXME: check length but it should never happen */ + strcpy(&program_string[j], processor_name_string); + } + + } else { + processor_name_string = unknown; + strcpy(program_string, processor_name_string); + } + } else { + if (Pg) + processor_name_string = sample; + else + processor_name_string = thermal; + + } + + printk_debug("CPU model: %s\n", program_string); + + for (i = 0; i < 6; i++) { + msr.lo = p_program_string[(2 * i) + 0]; + msr.hi = p_program_string[(2 * i) + 1]; + wrmsr_amd(0xC0010030 + i, msr); + } + + return 0; +} +

4 7

Re: [coreboot] pci device memory allocation problem
by joe＠settoplinux.org 24 Apr '08

24 Apr '08

>>> I noticed this problem, if certian devices are disabled (like onboard >>> vga for example). The other enabled devices try to use 0xfec00000 for >>> memory allocation, causing APIC to fail. > >>> You just need to add a Signed-Off-By as stated in the development >>> guidelines. In the mean time I will test it and if all goes well you'll >>get >>> my Acked-by, and then it can be commited. >>> >>Oh, I see. >> >>Signed-off-by: Aaron Lwe <aaron.lwe(a)gmail.com> >Acked-by: Joseph Smith <joe(a)settoplinux.org> > >Great job Aaron! Works great, attached is the bootlog with vga (device 2.0) >completly disabled, and coreboot is not trying to allocate the 0xfec00000 >range. > > >commited in r3265 > Oops, here is the bootlog :-) -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

2 1

r3265 build service
by coreboot information 24 Apr '08

24 Apr '08

Dear coreboot readers! This is the automated build check service of coreboot. The developer "linux_junkie" checked in revision 3265 to the coreboot source repository and caused the following changes: Change Log: Fix so pci device memory allocation does not use memory base address at 0xfec00000, this is reserved for APIC. Signed-off-by: Aaron Lwe <aaron.lwe(a)gmail.com> Acked-by: Joseph Smith <joe(a)settoplinux.org> Build Log: Compilation of amd:serengeti_cheetah_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=3265&device=serengeti_chee… If something broke during this checkin please be a pain in linux_junkie's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2008