coreboot August 2007

coreboot@coreboot.org

78 participants
202 discussions

[LinuxBIOS] r477 - LinuxBIOSv3/util/lar
by svn＠openbios.org 20 Aug '07

20 Aug '07

Author: stepan Date: 2007-08-20 19:55:32 +0200 (Mon, 20 Aug 2007) New Revision: 477 Modified: LinuxBIOSv3/util/lar/lib.c Log: Fixes nocompress:-handling in lar Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/util/lar/lib.c =================================================================== --- LinuxBIOSv3/util/lar/lib.c 2007-08-20 00:48:06 UTC (rev 476) +++ LinuxBIOSv3/util/lar/lib.c 2007-08-20 17:55:32 UTC (rev 477) @@ -208,21 +208,17 @@ char *c; if (strstr(name, "nocompress:") == name) { - name += 11; + free(realname); + realname = strdup(name + 11); + } else { + realname = strdup(name); } - realname = strdup(name); - if (realname == NULL) { fprintf(stderr, "Out of memory.\n"); exit(1); } - c = strchr(realname, ':'); - - if (c != NULL) - *c = '\0'; - /* printf("... add_files %s\n", name); */ if (stat(realname, &filestat) == -1) { fprintf(stderr, "Error getting file attributes of %s\n", name);

1 0

[LinuxBIOS] [patch 0/5] LAR improvements (V2)
by jordan.crouse＠amd.com 20 Aug '07

20 Aug '07

Hey all. Following is a refresh of the LAR improvements that I posted earlier. This revision includes fixes for comments from the mailing list, bugs I discovered while integrating the code into buildROM, and last (but not least), Doxygen style comments. I know some of this code got ACKed last time I sent them out, but the messages were flying about left and right, and I figured it would just be easier to re-send them all. Also, not pictured here is the "remove-files" patch - I'll integrate it with the add-stream.patch when I commit the code, but since it just removes code, it isn't interesting to you guys. Keep an eye out for the buildROM v3 enhancements, coming soon to a mailing list near you. Following that, I have some plans for future LAR work - including the manifest stuff we discussed earlier, as well as possible replace/delete support in the LAR utility. Enjoy, Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.

7 28

[LinuxBIOS] smbus_write_byte???
by Joseph Smith 20 Aug '07

20 Aug '07

Anyone know if there is a function to write to the smbus similar to the smbus_read_byte function? Execpt write not read of course, like smbus_write_byte? Thanks - Joe

4 7

[LinuxBIOS] GSoC -- Winflashrom Last Status
by Darmawan Salihun 20 Aug '07

20 Aug '07

Hi all, The latest code from winflashrom is attached (overall code in tar.gz format) and the diff. Anyway, sorry about the diff because it's reversed, I can't get TortoiseCVS to make it not reversed. I don't know why the diff is always reversed like that. I'll be moving to command line SVN very soon to alleviate the problem. Anyway, I might be uploading an updated code in the next few hours. This is only for GSoC "compliance". The current version has no DPC support what so ever :(. I'll submit the one with DPC in the next few hours. This is merely to make sure that there is a working code submitted prior to GSoC "pencils down" time limit. Note that this version has an improved support for Winbond W39V040FA flashchip. The original support in flashrom is *not* working because it's not setting the Block Locking Register (BLR) prior to flashing. I'll add the patch to the Linux version in the next few days (I need to test it in my machine before hand even if winflashrom shows it's working flawlessly). The excerpt as follows: ---------------------------------------------------- enum { BLOCKING_REGS_PHY_RANGE = 0x80000, BLOCKING_REGS_PHY_BASE = 0xFFB80000, }; static volatile char * unprotect_39v040fa(void) { unsigned char i, byte_val; volatile char * block_regs_base; block_regs_base = (volatile char*) map_physical_addr_range( BLOCKING_REGS_PHY_BASE, BLOCKING_REGS_PHY_RANGE); if (block_regs_base == NULL) { perror("Error: Unable to map Winbond w39v040fa" "blocking registers!\n"); return NULL; } // // Unprotect the BIOS chip address range // for( i = 0; i < 8 ; i++ ) { byte_val = *(block_regs_base + 2 + i*0x10000); myusec_delay(10); byte_val &= 0xF8; // Enable full access to the chip *(block_regs_base + 2 + i*0x10000) = byte_val; myusec_delay(10); } return block_regs_base; } static void protect_39v040fa(volatile char * reg_base) { // // Protect the BIOS chip address range // unsigned char i, byte_val; volatile char * block_regs_base = reg_base; for( i = 0; i < 8 ; i++ ) { byte_val = *(block_regs_base + 2 + i*0x10000); myusec_delay(10); byte_val |= 1; // Prohibited to write in the block // where set *(block_regs_base + 2 + i*0x10000) = byte_val; myusec_delay(10); } unmap_physical_addr_range((void*) reg_base, BLOCKING_REGS_PHY_RANGE); } int write_39v040fa(struct flashchip *flash, uint8_t *buf) { int i; int total_size = flash->total_size * 1024; int page_size = flash->page_size; volatile uint8_t *bios = flash->virtual_memory; volatile char * reg_base; reg_base = unprotect_39v040fa(); erase_chip_jedec(flash); printf("Programming Page: "); for (i = 0; i < total_size / page_size; i++) { /* write to the sector */ printf("%04d at address: 0x%08x", i, i * page_size); write_sector_jedec(bios, buf + i * page_size, bios + i * page_size, page_size); printf("\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b"); fflush(stdout); } printf("\n"); if(NULL != reg_base) { protect_39v040fa(reg_base); } return (0); } --------------------------------------------------------------- That's all for now. Regards, Darmawan Salihun -------------------------------------------------------------------- -= Human knowledge belongs to the world =-

1 0

[LinuxBIOS] Fwd: ACPI memo
by ron minnich 20 Aug '07

20 Aug '07

You just have to love ACPI. Or any other binary standard, for that matter. In a simliar vein, I wonder if we'll find it almost impossible to run EFI drivers under non-EFI software ... ron ---------- Forwarded message ---------- From: Date: Aug 13, 2007 11:25 AM Subject: ACPI memo To: ron minnich <rminnich(a)gmail.com> Pretty amusing, if you haven't seen this before. :-) http://antitrust.slated.org/www.iowaconsumercase.org/011607/3000/PX03020.pdf

2 1

[LinuxBIOS] r476 - LinuxBIOSv3/util/lar
by svn＠openbios.org 20 Aug '07

20 Aug '07

Author: stepan Date: 2007-08-20 02:48:06 +0200 (Mon, 20 Aug 2007) New Revision: 476 Modified: LinuxBIOSv3/util/lar/lib.c LinuxBIOSv3/util/lar/stream.c Log: fix mkdirp_below calls like I think Peter intended them Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/util/lar/lib.c =================================================================== --- LinuxBIOSv3/util/lar/lib.c 2007-08-20 00:36:20 UTC (rev 475) +++ LinuxBIOSv3/util/lar/lib.c 2007-08-20 00:48:06 UTC (rev 476) @@ -155,12 +155,6 @@ return ret; } - -int mkdirp(const char *dirpath, mode_t mode) -{ - return mkdirp_below(".", dirpath, mode); -} - static int handle_directory(const char *name) { int n; Modified: LinuxBIOSv3/util/lar/stream.c =================================================================== --- LinuxBIOSv3/util/lar/stream.c 2007-08-20 00:36:20 UTC (rev 475) +++ LinuxBIOSv3/util/lar/stream.c 2007-08-20 00:48:06 UTC (rev 476) @@ -445,7 +445,7 @@ return -1; } - mkdirp((const char *) dirname(path), 0755); + mkdirp_below(".", (const char *) dirname(path), 0755); free(path); fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, 0644);

1 0

[LinuxBIOS] r475 - LinuxBIOSv3/arch/x86
by svn＠openbios.org 20 Aug '07

20 Aug '07

Author: stepan Date: 2007-08-20 02:36:20 +0200 (Mon, 20 Aug 2007) New Revision: 475 Modified: LinuxBIOSv3/arch/x86/Makefile Log: fix building LinuxBIOS with new lar. lar fails now if the target file already exists. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/arch/x86/Makefile =================================================================== --- LinuxBIOSv3/arch/x86/Makefile 2007-08-20 00:08:18 UTC (rev 474) +++ LinuxBIOSv3/arch/x86/Makefile 2007-08-20 00:36:20 UTC (rev 475) @@ -77,6 +77,7 @@ fi endif $(Q)printf " LAR $(subst $(shell pwd)/,,$(@))\n" + $(Q)rm -f $(obj)/linuxbios.rom $(Q)cd $(obj)/lar.tmp && ../util/lar/lar $(COMPRESSFLAG) -c \ ../linuxbios.rom \ $(LARFILES) \

1 0

[LinuxBIOS] r474 - LinuxBIOSv3/util/lar
by svn＠openbios.org 20 Aug '07

20 Aug '07

Author: stepan Date: 2007-08-20 02:08:18 +0200 (Mon, 20 Aug 2007) New Revision: 474 Modified: LinuxBIOSv3/util/lar/lar.c Log: Add another field to the filename specified for create and add operations to specify the intended pathname for the blob. Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/util/lar/lar.c =================================================================== --- LinuxBIOSv3/util/lar/lar.c 2007-08-19 23:53:16 UTC (rev 473) +++ LinuxBIOSv3/util/lar/lar.c 2007-08-20 00:08:18 UTC (rev 474) @@ -46,7 +46,7 @@ printf("\nLAR - the LinuxBIOS Archiver " VERSION "\n" COPYRIGHT "\n\n" "Usage: %s [-cxal] archive.lar [[[file1] file2] ...]\n\n", name); printf("Examples:\n"); - printf(" lar -c -s 32768 -b bootblock myrom.lar foo nocompress:bar\n"); + printf(" lar -c -s 32k -b bootblock myrom.lar foo nocompress:bar\n"); printf(" lar -a myrom.lar foo blob:baz\n"); printf(" lar -l myrom.lar\n\n"); @@ -61,7 +61,9 @@ printf(" * Pathname is the name to use in the LAR header.\n\n"); printf("Create options:\n"); - printf(" -s [size]\tSpecify the size of the archive (in bytes)\n"); + printf(" -s [size] \tSpecify the size of the archive.\n"); + printf(" \tUse a 'k' suffix to multiply the size by 1024 or\n"); + printf(" \ta 'm' suffix to multiple the size by 1024*1024.\n"); printf(" -b [bootblock]\tSpecify the bootblock blob\n"); printf(" -C [lzma|nrv2b]\tSpecify the compression method to use\n\n"); @@ -73,6 +75,29 @@ } +/* Add a human touch to the LAR size by allowing suffixes: + * XX[KkMm] where k = XX * 1024 and m or M = xx * 1024 * 1024 + */ + +static void parse_larsize(char *str) +{ + char *p = NULL; + unsigned int size = strtoul(str, &p, 0); + + if (p != NULL) { + if (*p == 'k' || *p == 'K') + size *= 1024; + else if (*p == 'm' || *p == 'M') + size *= (1024 * 1024); + else if (*p) { + fprintf(stderr, "Unknown LAR size suffix '%c'\n", *p); + exit(1); + } + } + + larsize = size; +} + int verbose(void) { return isverbose; @@ -219,7 +244,7 @@ larmode = EXTRACT; break; case 's': - larsize = strtol(optarg, (char **)NULL, 10); + parse_larsize(optarg); break; case 'b': bootblock = strdup(optarg);

1 0

[LinuxBIOS] r473 - LinuxBIOSv3/util/lar
by svn＠openbios.org 20 Aug '07

20 Aug '07

Author: stepan Date: 2007-08-20 01:53:16 +0200 (Mon, 20 Aug 2007) New Revision: 473 Modified: LinuxBIOSv3/util/lar/lar.c LinuxBIOSv3/util/lar/lib.h Log: Provide the ability to add arbitrary files to an existing LAR. Also fleshed out the "usage" screen. Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: LinuxBIOSv3/util/lar/lar.c =================================================================== --- LinuxBIOSv3/util/lar/lar.c 2007-08-19 23:37:34 UTC (rev 472) +++ LinuxBIOSv3/util/lar/lar.c 2007-08-19 23:53:16 UTC (rev 473) @@ -44,7 +44,33 @@ static void usage(char *name) { printf("\nLAR - the LinuxBIOS Archiver " VERSION "\n" COPYRIGHT "\n\n" - "Usage: %s [-cxl] archive.lar [[[file1] file2] ...]\n\n", name); + "Usage: %s [-cxal] archive.lar [[[file1] file2] ...]\n\n", name); + printf("Examples:\n"); + printf(" lar -c -s 32768 -b bootblock myrom.lar foo nocompress:bar\n"); + printf(" lar -a myrom.lar foo blob:baz\n"); + printf(" lar -l myrom.lar\n\n"); + + printf("File names:\n"); + printf(" Names specified in the create or add modes are formatted as\n"); + printf(" follows: [flags]:[filename]:[pathname].\n"); + printf(" * Flags are modifiers for the file. Valid flags:\n"); + printf(" nocompress\tDon't compress the file in the LAR\n"); + printf(" * Filename is the name of the file on disk. If no pathname\n"); + printf(" is specified, then the filename will also be the path name\n"); + printf(" used in the LAR.\n"); + printf(" * Pathname is the name to use in the LAR header.\n\n"); + + printf("Create options:\n"); + printf(" -s [size]\tSpecify the size of the archive (in bytes)\n"); + printf(" -b [bootblock]\tSpecify the bootblock blob\n"); + printf(" -C [lzma|nrv2b]\tSpecify the compression method to use\n\n"); + + printf("General options\n"); + printf(" -v\tEnable verbose mode\n"); + printf(" -V\tShow the version\n"); + printf(" -h\tShow this help\n"); + printf("\n"); + } int verbose(void) @@ -90,6 +116,27 @@ return 0; } +int add_lar(const char *archivename, struct file *files) +{ + struct lar *lar = lar_open_archive(archivename); + + if (lar == NULL) { + fprintf(stderr, "Unable to open LAR archive %s\n", archivename); + exit(1); + } + + for( ; files; files = files->next) { + if (lar_add_file(lar, files->name)) { + fprintf(stderr, "Error adding %s to the LAR.\n", files->name); + lar_close_archive(lar); + exit(1); + } + } + + lar_close_archive(lar); + return 0; +} + int list_lar(const char *archivename, struct file *files) { struct lar *lar = lar_open_archive(archivename); @@ -130,6 +177,7 @@ char *archivename = NULL; static struct option long_options[] = { + {"add", 0, 0, 'a'}, {"create", 0, 0, 'c'}, {"compress-algo", 1, 0, 'C'}, {"extract", 0, 0, 'x'}, @@ -147,9 +195,12 @@ exit(1); } - while ((opt = getopt_long(argc, argv, "cC:xls:b:vVh?", + while ((opt = getopt_long(argc, argv, "acC:xls:b:vVh?", long_options, &option_index)) != EOF) { switch (opt) { + case 'a': + larmode = ADD; + break; case 'c': larmode = CREATE; break; @@ -258,6 +309,9 @@ } switch (larmode) { + case ADD: + add_lar(archivename, get_files()); + break; case EXTRACT: extract_lar(archivename, get_files()); break; Modified: LinuxBIOSv3/util/lar/lib.h =================================================================== --- LinuxBIOSv3/util/lar/lib.h 2007-08-19 23:37:34 UTC (rev 472) +++ LinuxBIOSv3/util/lar/lib.h 2007-08-19 23:53:16 UTC (rev 473) @@ -30,6 +30,7 @@ enum { NONE, + ADD, CREATE, LIST, EXTRACT

1 0

Re: [LinuxBIOS] r471 - LinuxBIOSv3/util/lar
by Stefan Reinauer 20 Aug '07

20 Aug '07

Sorry for not testing this patch before committing it. It breaks the compression exception code. Without patch: stepan@linux:~/svn/LinuxBIOSv3> build/util/lar/lar -l build/linuxbios.rom normal/option_table (932 bytes @0x40) normal/stage2 (37404 bytes, lzma compressed to 15530 bytes @0x420) normal/initram (2221 bytes @0x4100) bootblock (16384 bytes @0x3c000) With patch: stepan@linux:~/svn/LinuxBIOSv3> build/util/lar/lar -l build/linuxbios.rom normal/option_table (932 bytes, lzma compressed to 352 bytes @0x40) normal/stage2 (37404 bytes, lzma compressed to 15526 bytes @0x1d0) normal/initram (2221 bytes, lzma compressed to 1593 bytes @0x3eb0) bootblock (16384 bytes @0x3c000) svn(a)openbios.org wrote: > Author: stepan > Date: 2007-08-20 01:33:41 +0200 (Mon, 20 Aug 2007) > New Revision: 471 > > Modified: > LinuxBIOSv3/util/lar/lib.c > Log: > Add another field to the filename specified for create and add > operations to specify the intended pathname for the blob. > > Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> > Acked-by: Stefan Reinauer <stepan(a)coresystems.de> > > > > Modified: LinuxBIOSv3/util/lar/lib.c > =================================================================== > --- LinuxBIOSv3/util/lar/lib.c 2007-08-19 23:31:58 UTC (rev 470) > +++ LinuxBIOSv3/util/lar/lib.c 2007-08-19 23:33:41 UTC (rev 471) > @@ -210,16 +210,29 @@ > { > struct stat filestat; > int ret = -1; > - const char *realname; > + char *realname; > + char *c; > > - realname = name; > if (strstr(name, "nocompress:") == name) { > - realname = name + 11; > + name += 11; > } > > + realname = strdup(name); > + > + if (realname == NULL) { > + fprintf(stderr, "Out of memory.\n"); > + exit(1); > + } > + > + c = strchr(realname, ':'); > + > + if (c != NULL) > + *c = '\0'; > + > /* printf("... add_files %s\n", name); */ > if (stat(realname, &filestat) == -1) { > fprintf(stderr, "Error getting file attributes of %s\n", name); > + free(realname); > return -1; > } > > @@ -264,6 +277,7 @@ > ret = 0; > } > > + free(realname); > return ret; > } > > > > -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
21
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot August 2007