July 2007 - coreboot - mail.coreboot.org

[LinuxBIOS] r430 - LinuxBIOSv3/util/lar
by svn＠openbios.org July 2, 2007

July 2, 2007

Author: uwe Date: 2007-07-02 22:57:45 +0200 (Mon, 02 Jul 2007) New Revision: 430 Modified: LinuxBIOSv3/util/lar/bootblock.c LinuxBIOSv3/util/lar/create.c LinuxBIOSv3/util/lar/extract.c Log: Coding style fixes via 'indent' (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: LinuxBIOSv3/util/lar/bootblock.c =================================================================== --- LinuxBIOSv3/util/lar/bootblock.c 2007-06-30 22:55:10 UTC (rev 429) +++ LinuxBIOSv3/util/lar/bootblock.c 2007-07-02 20:57:45 UTC (rev 430) @@ -48,11 +48,11 @@ */ if (bootblock_len != BOOTBLOCK_SIZE) { printf("Warning: %s does not seem to be a bootblock, " - "so ignore it\n", bootblock); - bootblock_code=NULL; - bootblock_len=0; + "so ignore it\n", bootblock); + bootblock_code = NULL; + bootblock_len = 0; // Is this an error condition? - } + } bootblock_code = malloc(bootblock_len); if (!bootblock_code) { @@ -78,13 +78,12 @@ uint32_t *size_pos; /* This cleans out the area after the reset vector */ - for(i=13; i>0; i--) + for (i = 13; i > 0; i--) bootblock_code[bootblock_len - i] = '\0'; - + /* add lar size to image */ - size_pos=(uint32_t *)(bootblock_code+bootblock_len-12); + size_pos = (uint32_t *) (bootblock_code + bootblock_len - 12); size_pos[0] = get_larsize(); return 0; } - Modified: LinuxBIOSv3/util/lar/create.c =================================================================== --- LinuxBIOSv3/util/lar/create.c 2007-06-30 22:55:10 UTC (rev 429) +++ LinuxBIOSv3/util/lar/create.c 2007-07-02 20:57:45 UTC (rev 430) @@ -36,13 +36,15 @@ extern enum compalgo algo; -void compress_impossible(char *in, u32 in_len, char *out, u32 *out_len) { +void compress_impossible(char *in, u32 in_len, char *out, u32 *out_len) +{ fprintf(stderr, "The selected compression algorithm wasn't compiled in.\n"); exit(1); } -void do_no_compress(char *in, u32 in_len, char *out, u32 *out_len) { +void do_no_compress(char *in, u32 in_len, char *out, u32 *out_len) +{ memcpy(out, in, in_len); out_len[0] = in_len; } @@ -116,7 +118,7 @@ header = (struct lar_header *)tempmem; pathname = tempmem + sizeof(struct lar_header); pathlen = snprintf(pathname, MAX_PATHLEN - 1, name) + 1; - pathlen = (pathlen + 15) & 0xfffffff0;/* Align to 16 bytes. */ + pathlen = (pathlen + 15) & 0xfffffff0; /* Align to 16 bytes. */ /* Read file into memory. */ filebuf = malloc(filelen); @@ -184,15 +186,17 @@ if (bootblock_len) { if (verbose()) - printf ("Detected bootblock of %d bytes\n", bootblock_len); + printf("Detected bootblock of %d bytes\n", + bootblock_len); bb_header_len = sizeof(struct lar_header) + - ((strlen(basename(get_bootblock()))+15) & 0xfffffff0); + ((strlen(basename(get_bootblock())) + 15) & 0xfffffff0); bb_header_len = (bb_header_len + 15) & 0xfffffff0; if (verbose()) - printf ("Required bootblock header of %d bytes\n", bb_header_len); + printf("Required bootblock header of %d bytes\n", + bb_header_len); diff -= bootblock_len; diff -= bb_header_len; @@ -239,15 +243,15 @@ struct lar_header *bb; bootblock_header = malloc(bb_header_len); - if(!bootblock_header) { + if (!bootblock_header) { fprintf(stderr, "Out of memory.\n"); exit(1); } - memset (bootblock_header, 0, bb_header_len); + memset(bootblock_header, 0, bb_header_len); /* construct header */ - bb=(struct lar_header *)bootblock_header; + bb = (struct lar_header *)bootblock_header; memcpy(bb->magic, MAGIC, 8); bb->reallen = htonl(bootblock_len); bb->len = htonl(bootblock_len); @@ -258,8 +262,8 @@ /* Write filename. we calculated the buffer size, * so no overflow danger here. */ - strcpy(bootblock_header+sizeof(struct lar_header), - basename(get_bootblock()) ); + strcpy(bootblock_header + sizeof(struct lar_header), + basename(get_bootblock())); fwrite(bootblock_header, bb_header_len, 1, archive); fwrite(bootblock_code, bootblock_len, 1, archive); Modified: LinuxBIOSv3/util/lar/extract.c =================================================================== --- LinuxBIOSv3/util/lar/extract.c 2007-06-30 22:55:10 UTC (rev 429) +++ LinuxBIOSv3/util/lar/extract.c 2007-07-02 20:57:45 UTC (rev 430) @@ -33,13 +33,15 @@ #include "lib.h" #include "lar.h" -void uncompress_impossible(char *dst, char *src, u32 len) { +void uncompress_impossible(char *dst, char *src, u32 len) +{ fprintf(stderr, "Cannot uncompress data (algorithm not compiled in).\n"); exit(1); } -void do_no_uncompress(char *dst, char *src, u32 len) { +void do_no_uncompress(char *dst, char *src, u32 len) +{ memcpy(dst, src, len); } @@ -117,7 +119,7 @@ if (pos) { pos[1] = 0; /* printf("Pathname %s\n",pathname); */ - mkdirp(pathname,0755); + mkdirp(pathname, 0755); } free(pathname); @@ -133,8 +135,7 @@ } else { char *buf = malloc(ntohl(header->reallen)); uncompress_functions[ntohl(header->compression)](buf, - walk + ntohl(header->offset), - ntohl(header->len)); + walk + ntohl(header->offset), ntohl(header->len)); fwrite(buf, ntohl(header->reallen), 1, file_to_extract); free(buf); }

1 0

[LinuxBIOS] ELF loader in v3
by Patrick Georgi July 2, 2007

July 2, 2007

Hi, I got quite far with adding decompression to lar (lzma'd data runs fine, nrv2b decompression seems to hang), but ran into issues that need discussion. Currently, two files in the lar archive are parsed directly out of rom (using the find_file function which returns a pointer to there). One of them is "option_table", a 900 byte file (which compresses to 350 or so), where I could live with it staying uncompressed in image. The other one is the payload. My current work around, is to just define a place in memory where to decode it to and then load the ELF image from there. This complicates ELF loading as now there is a risk that the raw ELF file and the ELF image overlap. (Right now, I just use an address that I know is beyond the ELF's range) I propose a new API for the ELF loader that hides this issue and ensures that decompression works fine. It would be used like this: copy_elf(&archive, "normal/payload", &entrypoint, &last_address) This function looks up "normal/payload" in the archive starting at archive, and returns success in the return value. entrypoint could then be used to jump into the image. last_address contains the last byte used by the ELF image. The rationale for returning the entrypoint and last_address is to allow further loads, so multipart payloads can be used, which provides a cleaner and simpler way to allow modular payloads. Specifically, I'd like to see this for the grub2 support I work on, as it's very trivial to just push the modules as "payload.data" into the lar archive, load it right behind the ELF image and have grub2 find its modules at _end. Regards, Patrick Georgi

8 24

[LinuxBIOS] r2731 build service
by LinuxBIOS information July 1, 2007

July 1, 2007

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "uwe" checked in revision 2731 to the LinuxBIOS source repository and caused the following changes: Change Log: Grab flashrom from the new location via svn:externals (trivial). Note that this is just a "copy" (sort of), the "real" location of the flashrom code is now svn://linuxbios.org/repos/trunk/util/flashrom. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Build Log: Compilation of arima:hdama is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2731&device=hdama&vendor=… Compilation of ibm:e325 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2731&device=e325&vendor=i… Compilation of ibm:e326 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2731&device=e326&vendor=i… Compilation of iei:juki-511p is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2731&device=juki-511p&ven… Compilation of iwill:dk8s2 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2731&device=dk8s2&vendor=… Compilation of iwill:dk8x is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2731&device=dk8x&vendor=i… If something broke during this checkin please be a pain in uwe's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

[LinuxBIOS] r2730 build service
by LinuxBIOS information July 1, 2007

July 1, 2007

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "uwe" checked in revision 2730 to the LinuxBIOS source repository and caused the following changes: Change Log: Move 'flashrom' into global util/flashrom svn directory, as it's not LinuxBIOSv2-specific (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Build Log: Compilation of arima:hdama is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2730&device=hdama&vendor=… Compilation of ibm:e325 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2730&device=e325&vendor=i… Compilation of ibm:e326 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2730&device=e326&vendor=i… Compilation of iei:juki-511p is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2730&device=juki-511p&ven… Compilation of iwill:dk8s2 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2730&device=dk8s2&vendor=… Compilation of iwill:dk8x is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2730&device=dk8x&vendor=i… If something broke during this checkin please be a pain in uwe's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

[LinuxBIOS] r2729 build service
by LinuxBIOS information July 1, 2007

July 1, 2007

Dear LinuxBIOS readers! This is the automated build check service of LinuxBIOS. The developer "" checked in revision 2729 to the LinuxBIOS source repository and caused the following changes: Change Log: Build Log: Compilation of arima:hdama is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2729&device=hdama&vendor=… Compilation of ibm:e325 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2729&device=e325&vendor=i… Compilation of ibm:e326 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2729&device=e326&vendor=i… Compilation of iei:juki-511p is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2729&device=juki-511p&ven… Compilation of iwill:dk8s2 is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2729&device=dk8s2&vendor=… Compilation of iwill:dk8x is still broken See the error log at http://qa.linuxbios.org/log_buildbrd.php?revision=2729&device=dk8x&vendor=i… If something broke during this checkin please be a pain in 's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, LinuxBIOS automatic build system

1 0

[LinuxBIOS] r2731 - trunk/LinuxBIOSv2/util
by svn＠openbios.org July 1, 2007

July 1, 2007

Author: uwe Date: 2007-07-01 21:47:31 +0200 (Sun, 01 Jul 2007) New Revision: 2731 Modified: trunk/LinuxBIOSv2/util/ Log: Grab flashrom from the new location via svn:externals (trivial). Note that this is just a "copy" (sort of), the "real" location of the flashrom code is now svn://linuxbios.org/repos/trunk/util/flashrom. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Property changes on: trunk/LinuxBIOSv2/util ___________________________________________________________________ Name: svn:externals + flashrom svn://linuxbios.org/repos/trunk/util/flashrom

1 0

[LinuxBIOS] r2730 - in trunk: LinuxBIOSv2/util util
by svn＠openbios.org July 1, 2007

July 1, 2007

Author: uwe Date: 2007-07-01 21:42:39 +0200 (Sun, 01 Jul 2007) New Revision: 2730 Added: trunk/util/flashrom/ Removed: trunk/LinuxBIOSv2/util/flashrom/ Log: Move 'flashrom' into global util/flashrom svn directory, as it's not LinuxBIOSv2-specific (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Copied: trunk/util/flashrom (from rev 2728, trunk/LinuxBIOSv2/util/flashrom)

1 0

[LinuxBIOS] r2729 - trunk
by svn＠openbios.org July 1, 2007

July 1, 2007

Author: uwe Date: 2007-07-01 21:41:04 +0200 (Sun, 01 Jul 2007) New Revision: 2729 Added: trunk/util/ Log: Add directory for various utilities which are not bound to a certain LinuxBIOS version (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de>

1 0