DSDT: New warnings after adding _OSC method

[Paul Menzel]

Dear coreboot folks,

the patches adding the _OSC method to the DSDT, like [1][2][3],
introduce the following ACPI warnings [4][5], which went unnoticed by
the reviewers, myself included.

IASL       coreboot-builds/amd_persimmon/mainboard/amd/persimmon/dsdt.ramstage.o
            CC         mainboard/amd/persimmon/get_bus_conf.ramstage.o

Intel ACPI Component Architecture
        ASL Optimizing Compiler version 20100528 [Oct 15 2010]
        Copyright (c) 2000 - 2010 Intel Corporation
        Supports ACPI Specification Revision 4.0a

dsdt.ramstage.asl  1143:    Method(_OSC,4)
        Warning  1088 -                       ^ Not all control paths return a value (_OSC)

dsdt.ramstage.asl  1143:    Method(_OSC,4)
        Warning  1081 -                       ^ Reserved method must return a value (Buffer required for _OSC)

ASL Input:  dsdt.ramstage.asl - 1724 lines, 34917 bytes, 889 keywords
        AML Output: dsdt.ramstage.aml - 10470 bytes, 409 named objects, 480 executable opcodes

Compilation complete. 0 Errors, 2 Warnings, 0 Remarks, 494 Optimizations

It should be as simple as adding the following as commented in
[1 (Mar 14 12:23 AM)] already.

} Else {
            Or(CDW1,4,CDW1)
            // Unrecognized UUID
            Return(Arg3)
        }

I am not submitting a patch, as the Sage folks are currently doing some
unification work, I do not want to interfere with.

Thanks,

Paul

[1] http://review.coreboot.org/#/c/2684/
[2] http://review.coreboot.org/#/c/2739/
[3] http://review.coreboot.org/#/c/2714/
[4] http://qa.coreboot.org/job/coreboot-gerrit/5591/testReport/(root)/board/i386...
[5] http://qa.coreboot.org/job/coreboot-gerrit/5591/testReport/(root)/board/i386...
(logs will not be archived forever, so URL might be invalid)

[Mike Loptien]

Coreboot,

I am adding a set of patches to unify the DSDT for all Family 14 boards.  This fix will be a part of that patch set.  I expect to push these patches out soon.  Thanks Paul for catching these.

Thanks,
Mike

Mike Loptien
Cell: 303-960-9236
Email: [e-mail]

----- Original Message -----
From: "Paul Menzel" 
To: [e-mail]
Cc: "Mike Loptien" 
Sent: Friday, March 29, 2013 4:52:20 AM
Subject: DSDT: New warnings after adding _OSC method

Dear coreboot folks,

the patches adding the _OSC method to the DSDT, like [1][2][3],
introduce the following ACPI warnings [4][5], which went unnoticed by
the reviewers, myself included.

IASL       coreboot-builds/amd_persimmon/mainboard/amd/persimmon/dsdt.ramstage.o
            CC         mainboard/amd/persimmon/get_bus_conf.ramstage.o

Intel ACPI Component Architecture
        ASL Optimizing Compiler version 20100528 [Oct 15 2010]
        Copyright (c) 2000 - 2010 Intel Corporation
        Supports ACPI Specification Revision 4.0a

dsdt.ramstage.asl  1143:    Method(_OSC,4)
        Warning  1088 -                       ^ Not all control paths return a value (_OSC)

dsdt.ramstage.asl  1143:    Method(_OSC,4)
        Warning  1081 -                       ^ Reserved method must return a value (Buffer required for _OSC)

ASL Input:  dsdt.ramstage.asl - 1724 lines, 34917 bytes, 889 keywords
        AML Output: dsdt.ramstage.aml - 10470 bytes, 409 named objects, 480 executable opcodes

Compilation complete. 0 Errors, 2 Warnings, 0 Remarks, 494 Optimizations

It should be as simple as adding the following as commented in
[1 (Mar 14 12:23 AM)] already.

} Else {
            Or(CDW1,4,CDW1)
            // Unrecognized UUID
            Return(Arg3)
        }

I am not submitting a patch, as the Sage folks are currently doing some
unification work, I do not want to interfere with.

Thanks,

Paul

[1] http://review.coreboot.org/#/c/2684/
[2] http://review.coreboot.org/#/c/2739/
[3] http://review.coreboot.org/#/c/2714/
[4] http://qa.coreboot.org/job/coreboot-gerrit/5591/testReport/(root)/board/i386...
[5] http://qa.coreboot.org/job/coreboot-gerrit/5591/testReport/(root)/board/i386...
(logs will not be archived forever, so URL might be invalid)

[Paul Menzel]

Dear Mike,

thanks you for your answer.

Am Donnerstag, den 04.04.2013, 17:22 -0500 schrieb Mike Loptien:
> I am adding a set of patches to unify the DSDT for all Family 14
> boards.

Please do not forget about the Intel Eagle heights board too.

commit 7bc153c6aef0f2615e3dadb274b9fed56ed15732
        Author: Mike Loptien 
        Date:   Wed Mar 13 16:28:16 2013 -0600

Eagleheights DSDT: Grant OS control through OSC

Reviewed-on: http://review.coreboot.org/2714
> This fix will be a part of that patch set.  I expect to push these
> patches out soon.  Thanks Paul for catching these.

Could you push these warning fix up earlier so they can get in as soon
as possible and the pending patch #2938 [1] can be updated and merged?
That would be great!

Thanks,

Paul

[1] http://review.coreboot.org/#/c/2938/