Dear coreboot folks,
the patches adding the _OSC method to the DSDT, like [1][2][3], introduce the following ACPI warnings [4][5], which went unnoticed by the reviewers, myself included.
IASL coreboot-builds/amd_persimmon/mainboard/amd/persimmon/dsdt.ramstage.o CC mainboard/amd/persimmon/get_bus_conf.ramstage.o
Intel ACPI Component Architecture ASL Optimizing Compiler version 20100528 [Oct 15 2010] Copyright (c) 2000 - 2010 Intel Corporation Supports ACPI Specification Revision 4.0a
dsdt.ramstage.asl 1143: Method(_OSC,4) Warning 1088 - ^ Not all control paths return a value (_OSC)
dsdt.ramstage.asl 1143: Method(_OSC,4) Warning 1081 - ^ Reserved method must return a value (Buffer required for _OSC)
ASL Input: dsdt.ramstage.asl - 1724 lines, 34917 bytes, 889 keywords AML Output: dsdt.ramstage.aml - 10470 bytes, 409 named objects, 480 executable opcodes
Compilation complete. 0 Errors, 2 Warnings, 0 Remarks, 494 Optimizations
It should be as simple as adding the following as commented in [1 (Mar 14 12:23 AM)] already.
} Else { Or(CDW1,4,CDW1) // Unrecognized UUID Return(Arg3) }
I am not submitting a patch, as the Sage folks are currently doing some unification work, I do not want to interfere with.
Thanks,
Paul
[1] http://review.coreboot.org/#/c/2684/ [2] http://review.coreboot.org/#/c/2739/ [3] http://review.coreboot.org/#/c/2714/ [4] http://qa.coreboot.org/job/coreboot-gerrit/5591/testReport/(root)/board/i386... [5] http://qa.coreboot.org/job/coreboot-gerrit/5591/testReport/(root)/board/i386... (logs will not be archived forever, so URL might be invalid)