#106: flashrom: Add -T to automatically test all flash chip operations

List overview All Threads
Download

newer

older

#113: problem

#141: flashrom: Warn the user when...

coreboot

2 Jul 2008 2 Jul '08

6:56 p.m.

#106: flashrom: Add -T to automatically test all flash chip operations ---------------------------------+------------------------------------------ Reporter: stuge | Owner: somebody Type: enhancement | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Keywords: testing | Dependencies: Patchstatus: there is no patch | ---------------------------------+------------------------------------------ Maybe require -f to actually perform the test, since it will potentially fail to restore the flash chip to it's original state.

-- Ticket URL: http://tracker.coreboot.org/trac/coreboot/ticket/106 coreboot http://www.coreboot.org/

Show replies by date

coreboot

4 Jul 4 Jul

12:04 a.m.

#106: flashrom: Add -T to automatically test all flash chip operations ----------------------------+----------------------------------------------- Reporter: stuge | Owner: somebody Type: enhancement | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: testing Dependencies: | Patchstatus: there is no patch ----------------------------+-----------------------------------------------

Comment(by hailfinger):

Good idea.

-- Ticket URL: http://tracker.coreboot.org/trac/coreboot/ticket/106#comment:1 coreboot http://www.coreboot.org/

coreboot

5 Jul 5 Jul

12:14 p.m.

Comment(by hailfinger):

For -T to work, you have to remove the mutual exclusion between -r and -w in a meaningful way. This may require a rewrite of the main loop.

-- Ticket URL: http://tracker.coreboot.org/trac/coreboot/ticket/106#comment:2 coreboot http://www.coreboot.org/

coreboot

7:31 p.m.

#106: flashrom: Add -T to automatically test all flash chip operations ----------------------------+----------------------------------------------- Reporter: stuge | Owner: somebody Type: enhancement | Status: new Priority: major | Milestone: flashrom 1.1 Component: flashrom | Version: Resolution: | Keywords: testing Dependencies: | Patchstatus: there is no patch ----------------------------+----------------------------------------------- Changes (by stepan):

* milestone: flashrom v1.0 => flashrom 1.1

-- Ticket URL: http://tracker.coreboot.org/trac/coreboot/ticket/106#comment:3 coreboot http://www.coreboot.org/

coreboot

5 Dec 5 Dec

4 a.m.

#106: flashrom: Add -T to automatically test all flash chip operations ----------------------------+----------------------------------------------- Reporter: stuge | Owner: somebody Type: enhancement | Status: closed Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: duplicate | Keywords: testing Dependencies: #103 | Patchstatus: there is no patch ----------------------------+----------------------------------------------- Changes (by stuge):

* status: new => closed * dependencies: => #103 * resolution: => duplicate * milestone: flashrom v1.1 => flashrom v1.0

Comment:

dup #103

-- Ticket URL: http://tracker.coreboot.org/trac/coreboot/ticket/106#comment:4 coreboot http://www.coreboot.org/

coreboot

11 Apr 11 Apr

4:38 p.m.

#106: flashrom: Add -T to automatically test all flash chip operations ----------------------------+----------------------------------------------- Reporter: stuge | Owner: somebody Type: enhancement | Status: reopened Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: testing Dependencies: | Patchstatus: there is no patch ----------------------------+----------------------------------------------- Changes (by stuge):

* status: closed => reopened * dependencies: #103 => * resolution: duplicate =>

Comment:

Carl-Daniel Hailfinger wrote:

...

The self-test mode has to execute:

read (and store on disk)

I think the point is that it goes to disk to allow out-of-band restoration in case writing back with flashrom fails?

I would prefer no file. I don't want to have to remove files after testing, and not having a file would encourage testing strictly with flash chips without valuable contents. I think that is a very good thing™!

There's always -r to do a manual backup first, but I like the idea of making the difficult path more labor intense, to discourage testing with critical flash chips.

...

write (old contents)

I think it has to write all 0 to the chip rather than the original contents. If the chip is blank to begin with there would be a false positive when erase or write does not work, and flashrom can't tell.

-- Ticket URL: http://tracker.coreboot.org/trac/coreboot/ticket/106#comment:5 coreboot http://www.coreboot.org/

coreboot

16 Jan 16 Jan

12:26 a.m.

#106: flashrom: Add -T to automatically test all flash chip operations ----------------------------+----------------------------------------------- Reporter: stuge | Owner: somebody Type: enhancement | Status: closed Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: duplicate | Keywords: testing Dependencies: | Patchstatus: there is no patch ----------------------------+----------------------------------------------- Changes (by hailfinger):

* status: reopened => closed * resolution: => duplicate

Comment:

Flashrom now has a partial test infrastructure (among others, it can generate test patterns for write). The rest of this ticket is indeed a dup of #103.

-- Ticket URL: http://tracker.coreboot.org/trac/coreboot/ticket/106#comment:6 coreboot http://www.coreboot.org/

5398

days inactive

5960

days old

coreboot@coreboot.org

6 comments

1 participants

tags (0)

participants (1)

coreboot