Move CK804_PCI_E_X and CK804B_PCI_E_X defines (which have been 4 by default on all boards) into Kconfig.
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net ---
Move CK804_PCI_E_X and CK804B_PCI_E_X defines (which have been 4 by default on all boards) into Kconfig.
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net ---
On Sun, Nov 21, 2010 at 08:31:55PM +0000, Jonathan A. Kollasch wrote:
-#define CK804_CHIP_REV 3
Hm, why remove CK804_CHIP_REV? I have no idea if or how that's supposed to be used etc., though. Here's a quick grep:
southbridge/nvidia/ck804/ck804_early_setup_car.c:#define CK804_CHIP_REV 3 southbridge/nvidia/ck804/ck804_early_setup.c:#define CK804_CHIP_REV 3 southbridge/nvidia/ck804/ck804_lpc.c:#define CK804_CHIP_REV 2 southbridge/nvidia/ck804/ck804_lpc.c:#if CK804_CHIP_REV==1 southbridge/nvidia/ck804/ck804_lpc.c:#if CK804_CHIP_REV == 1
Maybe we should keep the #define until we know more.
The rest of the patch looks ok.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Uwe.
On Sun, Nov 21, 2010 at 10:38:06PM +0100, Uwe Hermann wrote:
On Sun, Nov 21, 2010 at 08:31:55PM +0000, Jonathan A. Kollasch wrote:
-#define CK804_CHIP_REV 3
Hm, why remove CK804_CHIP_REV? I have no idea if or how that's supposed
Maybe we should keep the #define until we know more.
Kept.
r6109.
On Wed, Oct 27, 2010 at 08:50:19PM +0000, Jonathan A. Kollasch wrote:
Move CK804_PCI_E_X and CK804B_PCI_E_X defines (which have been 4 by default on all boards) into Kconfig.
For bookkeeping: An updated patch has been committed as r6109.
Uwe.
-
Jonathan A. Kollasch -
Uwe Hermann