[BUG] nonexisting function current_time_from

[Petr Cvek]

Enabling X86EMU_DEBUG_TIMINGS config option will cause the compilation to fail with:

In file included from src/device/oprom/yabel/debug.h:48,
                 from src/device/oprom/yabel/biosemu.c:39:
src/device/oprom/yabel/biosemu.c: In function 'biosemu':
src/device/oprom/yabel/debug.h:103:66: error: implicit declaration of function 'current_time_from' [-Werror=implicit-function-declaration]
  103 | #define DEBUG_PRINTF_CS_IP(_x...) DEBUG_PRINTF("[%08lx]%x:%x ", (current_time_from(&zero)).microseconds, M.x86.R_CS, M.x86.R_IP); DEBUG_PRINTF(_x);

It seems there isn't current_time_from() defined anywhere.

Petr Cvek

[Kyösti Mälkki]

On Sun, Sep 22, 2019 at 7:56 PM Petr Cvek  wrote:
> Enabling X86EMU_DEBUG_TIMINGS config option will cause the compilation to fail with:

Not a big surprise, see [1].
> In file included from src/device/oprom/yabel/debug.h:48,
>                  from src/device/oprom/yabel/biosemu.c:39:
> src/device/oprom/yabel/biosemu.c: In function 'biosemu':
> src/device/oprom/yabel/debug.h:103:66: error: implicit declaration of function 'current_time_from' [-Werror=implicit-function-declaration]
>   103 | #define DEBUG_PRINTF_CS_IP(_x...) DEBUG_PRINTF("[%08lx]%x:%x ", (current_time_from(&zero)).microseconds, M.x86.R_CS, M.x86.R_IP); DEBUG_PRINTF(_x);
>
> It seems there isn't current_time_from() defined anywhere.

See [2] that removed it in 2015, might be a quite clean revert to bring it back.

[1] https://review.coreboot.org/c/coreboot/+/34201
[2] https://review.coreboot.org/c/coreboot/+/8896/

Kyösti