I have tested coreboot on both the asus/p2b and asus/p2-99 and it seems to work fine. I had previously commented on the mailing list instead of these patches and then never really followed up on it.
I meant to retest and comment on the change sets on gerrit (22977 and 22965) before they got abandoned, but got around to it too late. I wasn't sure what to do about it now, I commented on one of the patches, but it doesn't seem to send out emails with an abandoned status. I should have received a copy if it did, right?
I originally only brought up that it worked since Keith Hui was working on updating Intel 440BX support. I haven't actually done anything to help with supporting coreboot though.
Branden
Hi Branden,
On 21.09.19 21:28, Branden Waldner wrote:
I meant to retest and comment on the change sets on gerrit (22977 and 22965) before they got abandoned, but got around to it too late.
looks like the code was actually accepted but somebody didn't like the commits (I somewhat agree, having a second commit, that removes everything the first did, doesn't make much sense).
If nobody resurrects these changes, can you please squash the commits? If you remove the Change-Id from the commit message, a new should be generated and you could push it to Gerrit as a new change.
Nico
On 9/21/19, Nico Huber nico.h@gmx.de wrote:
If nobody resurrects these changes, can you please squash the commits? If you remove the Change-Id from the commit message, a new should be generated and you could push it to Gerrit as a new change.
I managed to squash the commits and resubmit the change, but it needs review(ers) again and I'm not sure if it's okay to just re-add the same people as the previous commits.
I also didn't end up submitting it with a proper sign-off, so that needs to be fixed yet as well.
Branden
-
Branden Waldner -
Nico Huber