Re: [coreboot] SeaBIOS and hp dl145g3

[Kevin O'Connor]

On Wed, Apr 29, 2009 at 04:53:13PM +0200, samuel wrote:
> Hi Kevin,
>
> I have tried Seabios on my hp dl145 g3 (the patches from mondrian) and
> it works really well now
> I was able to load the vga rom and i have output on the screen.

Great!
> One single problem... It doesn't seem to find the sata controller...
>
> bootlog with coreboot and seabios:
> http://merlin.ugent.be/~samuel/dl145g3/corebootwithseabios.log

There isn't much SeaBIOS info in that log - can you recompile with
CONFIG_DEBUG_LEVEL set to 6?
> lspci -vnn : http://merlin.ugent.be/~samuel/dl145g3/info/lspci-vnn.txt
>
> and the original patch from mondrian to add support for the dl145g3 to filo:
> http://merlin.ugent.be/~samuel/dl145g3/patch/filo_dl145_sata.patch
>
> It looks rather simple but I don't see what i have to change in
> seabios to support the device.
>
> The pci id (0x104 is already in pci_ids.h of seabios) so i would think
> it should just work. Myles thought it could be related to the fact
> that his sata interface of this mainboard does not support a legacy
> IDE interface mode.
>
> You have any ideas how i could quickly add support for the hp dl145 g3
> to SeaBIOS??

The equivalent patch in SeaBIOS would look like:

--- a/src/ata.c
+++ b/src/ata.c
@@ -841,7 +845,8 @@ ata_init()
     int count=0;
     int bdf, max;
     foreachpci(bdf, max) {
-        if (pci_config_readw(bdf, PCI_CLASS_DEVICE) != PCI_CLASS_STORAGE_IDE)
+        u16 class = pci_config_readw(bdf, PCI_CLASS_DEVICE);
+        if (class != PCI_CLASS_STORAGE_IDE && class != PCI_CLASS_STORAGE_RAID)
             continue;
         if (count >= ARRAY_SIZE(ATA.channels))
             break;

-Kevin

SeaBIOS and hp dl145g3

[Arne Georg Gleditsch]

Kevin O'Connor  writes:
> > and the original patch from mondrian to add support for the dl145g3 to filo:
> > http://merlin.ugent.be/~samuel/dl145g3/patch/filo_dl145_sata.patch
> >
> > It looks rather simple but I don't see what i have to change in
> > seabios to support the device.
> >
> > The pci id (0x104 is already in pci_ids.h of seabios) so i would think
> > it should just work. Myles thought it could be related to the fact
> > that his sata interface of this mainboard does not support a legacy
> > IDE interface mode.
> >
> > You have any ideas how i could quickly add support for the hp dl145 g3
> > to SeaBIOS??
>
> The equivalent patch in SeaBIOS would look like:
>
> --- a/src/ata.c
> +++ b/src/ata.c
> @@ -841,7 +845,8 @@ ata_init()
>      int count=0;
>      int bdf, max;
>      foreachpci(bdf, max) {
>    if (pci_config_readw(bdf, PCI_CLASS_DEVICE) != PCI_CLASS_STORAGE_IDE)
>    u16 class = pci_config_readw(bdf, PCI_CLASS_DEVICE);
>    if (class != PCI_CLASS_STORAGE_IDE && class != PCI_CLASS_STORAGE_RAID)
>        continue;
>    if (count >= ARRAY_SIZE(ATA.channels))
>        break;

I ran into this same issue when porting the dl165g3 board.  I was able
to get SeaBIOS to boot from my SATA disks by applying the following:

--- a/src/ata.c
+++ b/src/ata.c
@@ -967,7 +967,8 @@ ata_init(void)
     int bdf, max;
     foreachpci(bdf, max) {
         pcicount++;
-        if (pci_config_readw(bdf, PCI_CLASS_DEVICE) != PCI_CLASS_STORAGE_IDE)
+        u16 class = pci_config_readw(bdf, PCI_CLASS_DEVICE);
+        if (class != PCI_CLASS_STORAGE_IDE && class !=  PCI_CLASS_STORAGE_RAID)
             continue;

u8 pciirq = pci_config_readb(bdf, PCI_INTERRUPT_LINE);
@@ -983,7 +984,7 @@ ata_init(void)
         }

u32 port1, port2, irq;
-        if (prog_if & 1) {
+        if ((prog_if & 1) || (class != PCI_CLASS_STORAGE_IDE)) {
             port1 = pci_config_readl(bdf, PCI_BASE_ADDRESS_0) & ~3;
             port2 = pci_config_readl(bdf, PCI_BASE_ADDRESS_1) & ~3;
             irq = pciirq;
@@ -995,7 +996,7 @@ ata_init(void)
         init_controller(count, bdf, irq, port1, port2, master);
         count++;

-        if (prog_if & 4) {
+        if ((prog_if & 4) || (class != PCI_CLASS_STORAGE_IDE)) {
             port1 = pci_config_readl(bdf, PCI_BASE_ADDRESS_2) & ~3;
             port2 = pci_config_readl(bdf, PCI_BASE_ADDRESS_3) & ~3;
             irq = pciirq;

SeaBIOS and hp dl145g3

[Stefan Reinauer]

On 5/26/10 12:18 PM, Arne Georg Gleditsch wrote:
>    u16 class = pci_config_readw(bdf, PCI_CLASS_DEVICE);
>    if (class != PCI_CLASS_STORAGE_IDE && class !=  PCI_CLASS_STORAGE_RAID)
>        continue;

What S-ATA controller is that? We have a SIL 3114 driver which sets the
class ID from RAID to IDE in coreboot. Maybe something like that would
work here, too?

Not sure which is the better approach though.

Stefan

SeaBIOS and hp dl145g3

[Arne Georg Gleditsch]

Stefan Reinauer  writes:
> What S-ATA controller is that? We have a SIL 3114 driver which sets the
> class ID from RAID to IDE in coreboot. Maybe something like that would
> work here, too?
>
> Not sure which is the better approach though.

This is the onboard BCM5785/HT1000 SATA controller.