Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1603
-gerrit
commit 52a7f986e7163b64d833afb1a68670052907263e
Author: Zheng Bao <fishbaozi(a)gmail.com>
Date: Mon Oct 22 16:39:24 2012 +0800
cbfstool: Add -mno-ms-bitfields on (mingw)
The default gcc on mingw will process the __attribute__ ((packed)) in
a different way other than non-win system.
Change-Id: Iac9f4476c922472d0b447f1c3ef60e8e13bd902f
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
util/cbfstool/Makefile.inc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc
index ad2e120..f9aef2e 100644
--- a/util/cbfstool/Makefile.inc
+++ b/util/cbfstool/Makefile.inc
@@ -15,6 +15,10 @@ cbfsobj += cbfstool.o
CBFSTOOLFLAGS=-DCOMPACT -g
+ifeq ($(shell uname -s | cut -c-7 2>/dev/null), MINGW32)
+CBFSTOOLFLAGS+=-mno-ms-bitfields
+endif
+
$(objutil)/cbfstool:
mkdir -p $@
Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1602
-gerrit
commit 6585f291def1f7cbeb2ccf42f9d6ce916f68ea24
Author: Zheng Bao <fishbaozi(a)gmail.com>
Date: Mon Oct 22 16:36:03 2012 +0800
Makefile: No need to mkdir when distclean
make distclean causes error on mingw:
-------
rm: cannot lstat `build/util': Permission denied
make: *** [distclean] Error 1
-------
Guess, When the distclean is made by multi-process, the mkdir
in the Makefile will execute when build is removed. That causes
conflicts.
Change-Id: Ia41ecc5d1db2fa9d3328c81ac1d33fa94779492d
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile
index 44fd62f..b40574b 100644
--- a/Makefile
+++ b/Makefile
@@ -101,6 +101,9 @@ ifneq ($(MAKECMDGOALS),)
ifneq ($(filter %config distclean,$(MAKECMDGOALS)),)
NOCOMPILE:=1
endif
+ifeq ($(MAKECMDGOALS), distclean)
+NOMKDIR:=1
+endif
endif
ifeq ($(NOCOMPILE),1)
Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1601
-gerrit
commit 742fc2a96ce2b55a2bb4238541c1a6ea19fefbb5
Author: Zheng Bao <fishbaozi(a)gmail.com>
Date: Mon Oct 22 16:29:37 2012 +0800
gitconfig: Create .git/hooks before copying files.
Change-Id: Id5564bf7a12b3ea9a5e60bd9522466157ace8c65
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
Makefile.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.inc b/Makefile.inc
index 1ba56b0..3f079cd 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -292,6 +292,7 @@ lint lint-stable:
rm -f $$LINTLOG
gitconfig:
+ mkdir -p .git/hooks
for hook in commit-msg pre-commit ; do \
if [ util/gitconfig/$$hook -nt .git/hooks/$$hook -o \
! -x .git/hooks/$$hook ]; then \