coreboot January 2011

coreboot@coreboot.org

65 participants
299 discussions

[commit] r6308 - trunk/util/nvramtool
by repository service 28 Jan '11

28 Jan '11

Author: oxygene Date: Fri Jan 28 08:40:08 2011 New Revision: 6308 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6308 Log: No need to add varargs magic to a simple regex wrapper. Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/util/nvramtool/input_file.c trunk/util/nvramtool/layout_file.c trunk/util/nvramtool/reg_expr.c trunk/util/nvramtool/reg_expr.h Modified: trunk/util/nvramtool/input_file.c ============================================================================== --- trunk/util/nvramtool/input_file.c Fri Jan 28 02:06:39 2011 (r6307) +++ trunk/util/nvramtool/input_file.c Fri Jan 28 08:40:08 2011 (r6308) @@ -88,8 +88,8 @@ list = NULL; p = &list; - compile_reg_exprs(REG_EXTENDED | REG_NEWLINE, 2, blank_or_comment_regex, - &blank_or_comment, assignment_regex, &assignment); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, blank_or_comment_regex, &blank_or_comment); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, assignment_regex, &assignment); /* each iteration processes one line from input file */ for (line_num = 1; get_input_file_line(f, line, LINE_BUF_SIZE) == OK; line_num++) { /* skip comments and blank lines */ @@ -142,7 +142,8 @@ p = &item->next; } - free_reg_exprs(2, &blank_or_comment, &assignment); + regfree(&blank_or_comment); + regfree(&assignment); return list; } Modified: trunk/util/nvramtool/layout_file.c ============================================================================== --- trunk/util/nvramtool/layout_file.c Fri Jan 28 02:06:39 2011 (r6307) +++ trunk/util/nvramtool/layout_file.c Fri Jan 28 08:40:08 2011 (r6308) @@ -262,14 +262,13 @@ ****************************************************************************/ static void process_layout_file(FILE * f) { - compile_reg_exprs(REG_EXTENDED | REG_NEWLINE, 7, - blank_or_comment_regex, &blank_or_comment_expr, - start_entries_regex, &start_entries_expr, - entries_line_regex, &entries_line_expr, - start_enums_regex, &start_enums_expr, - enums_line_regex, &enums_line_expr, - start_checksums_regex, &start_checksums_expr, - checksum_line_regex, &checksum_line_expr); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, blank_or_comment_regex, &blank_or_comment_expr); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, start_entries_regex, &start_entries_expr); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, entries_line_regex, &entries_line_expr); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, start_enums_regex, &start_enums_expr); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, enums_line_regex, &enums_line_expr); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, start_checksums_regex, &start_checksums_expr); + compile_reg_expr(REG_EXTENDED | REG_NEWLINE, checksum_line_regex, &checksum_line_expr); line_num = 1; skip_past_start(f); @@ -322,10 +321,13 @@ */ skip_remaining_lines(f); - free_reg_exprs(7, &blank_or_comment_expr, &start_entries_expr, - &entries_line_expr, &start_enums_expr, - &enums_line_expr, &start_checksums_expr, - &checksum_line_expr); + regfree(&blank_or_comment_expr); + regfree(&start_entries_expr); + regfree(&entries_line_expr); + regfree(&start_enums_expr); + regfree(&enums_line_expr); + regfree(&start_checksums_expr); + regfree(&checksum_line_expr); } /**************************************************************************** Modified: trunk/util/nvramtool/reg_expr.c ============================================================================== --- trunk/util/nvramtool/reg_expr.c Fri Jan 28 02:06:39 2011 (r6307) +++ trunk/util/nvramtool/reg_expr.c Fri Jan 28 08:40:08 2011 (r6308) @@ -33,50 +33,20 @@ #include "reg_expr.h" /**************************************************************************** - * compile_reg_exprs + * compile_reg_expr * - * Compile a bunch of regular expressions. + * Compile a regular expression. ****************************************************************************/ -void compile_reg_exprs(int cflags, int num_exprs, - /* const char *expr1, regex_t *reg1, */ ...) +void compile_reg_expr(int cflags, const char *expr, regex_t *reg) { static const size_t ERROR_BUF_SIZE = 256; char error_msg[ERROR_BUF_SIZE]; - va_list ap; - regex_t *reg; - const char *expr; - int i, result; + int result; - va_start(ap, num_exprs); - - for (i = 0; i < num_exprs; i++) { - expr = va_arg(ap, const char *); - reg = va_arg(ap, regex_t *); - - if ((result = regcomp(reg, expr, cflags)) != 0) { - regerror(result, reg, error_msg, ERROR_BUF_SIZE); - fprintf(stderr, "%s: %s\n", prog_name, error_msg); - exit(1); - } + if ((result = regcomp(reg, expr, cflags)) != 0) { + regerror(result, reg, error_msg, ERROR_BUF_SIZE); + fprintf(stderr, "%s: %s\n", prog_name, error_msg); + exit(1); } - - va_end(ap); } -/**************************************************************************** - * free_reg_exprs - * - * Destroy a bunch of previously compiled regular expressions. - ****************************************************************************/ -void free_reg_exprs(int num_exprs, /* regex_t *reg1, */ ...) -{ - va_list ap; - int i; - - va_start(ap, num_exprs); - - for (i = 0; i < num_exprs; i++) - regfree(va_arg(ap, regex_t *)); - - va_end(ap); -} Modified: trunk/util/nvramtool/reg_expr.h ============================================================================== --- trunk/util/nvramtool/reg_expr.h Fri Jan 28 02:06:39 2011 (r6307) +++ trunk/util/nvramtool/reg_expr.h Fri Jan 28 08:40:08 2011 (r6308) @@ -34,8 +34,6 @@ #include <regex.h> #include "common.h" -void compile_reg_exprs(int cflags, int num_exprs, - /* const char *expr1, regex_t *reg1, */ ...); -void free_reg_exprs(int num_exprs, /* regex_t *reg1, */ ...); +void compile_reg_expr(int cflags, const char *expr, regex_t *reg); #endif /* REG_EXPR_H */

1 0

[PATCH] rename CONFIG_SERIAL_POST to CONFIG_CONSOLE_POST
by Stefan Reinauer 28 Jan '11

28 Jan '11

See patch.

2 1

core boot & ehci debug
by trevor.davenport＠gmail.com 28 Jan '11

28 Jan '11

Hi, I've been trying to get coreboot to work a machine i have ( http://www.coreboot.org/pipermail/coreboot/2010-November/061987.html) but have so far have not had any luck. I've tried most board types that are similar but all result in the same scenario, flash the rom, reboot....nothing on screen. This system does not have serial port available (the closest thing on the board appears to be solder contacts labeled COMB). The southbridge is a SB700. Is the EHCI Debug Port support usuable on these (the wiki says WIP but it seems the code is there) and do you think it would help to go this route? Is there anything else you could suggest in helping me make any progress on this board? Cheers, Trevor Davenport

3 2

build service results for r6307
by repository service 28 Jan '11

28 Jan '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 6307 to the coreboot repository. This caused the following changes: Change Log: Fix Bimini build Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Build Log: Compilation of a-trend:atc-6220 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6307&device=atc-6220&vendo… Compilation of amd:bimini_fam10 has been fixed If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

build service results for r6306
by repository service 28 Jan '11

28 Jan '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 6306 to the coreboot repository. This caused the following changes: Change Log: rk886ex lacked EC_ACPI Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Build Log: Compilation of a-trend:atc-6220 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6306&device=atc-6220&vendo… Compilation of amd:bimini_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6306&device=bimini_fam10&v… Compilation of roda:rk886ex has been fixed If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[commit] r6307 - trunk/src/southbridge/amd/sb800
by repository service 28 Jan '11

28 Jan '11

Author: stepan Date: Fri Jan 28 02:06:39 2011 New Revision: 6307 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6307 Log: Fix Bimini build Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/src/southbridge/amd/sb800/sb800.h Modified: trunk/src/southbridge/amd/sb800/sb800.h ============================================================================== --- trunk/src/southbridge/amd/sb800/sb800.h Fri Jan 28 02:03:18 2011 (r6306) +++ trunk/src/southbridge/amd/sb800/sb800.h Fri Jan 28 02:06:39 2011 (r6307) @@ -40,28 +40,28 @@ #define ACPI_GPE0_BLK (SB800_ACPI_IO_BASE + 0x10) /* 8 bytes */ #define ACPI_CPU_CONTROL (SB800_ACPI_IO_BASE + 0x08) /* 6 bytes */ -extern void pm_iowrite(u8 reg, u8 value); -extern u8 pm_ioread(u8 reg); -extern void pm2_iowrite(u8 reg, u8 value); -extern u8 pm2_ioread(u8 reg); -extern void set_sm_enable_bits(device_t sm_dev, u32 reg_pos, u32 mask, u32 val); +void pm_iowrite(u8 reg, u8 value); +u8 pm_ioread(u8 reg); +void pm2_iowrite(u8 reg, u8 value); +u8 pm2_ioread(u8 reg); +void set_sm_enable_bits(device_t sm_dev, u32 reg_pos, u32 mask, u32 val); #define REV_SB800_A11 0x11 #define REV_SB800_A12 0x12 -void sb800_enable(device_t dev); #ifdef __PRE_RAM__ void sb800_lpc_port80(void); void sb800_pci_port80(void); void sb800_clk_output_48Mhz(void); -#else -/* void sb800_setup_sata_phys(struct device *dev); */ -#endif int s3_save_nvram_early(u32 dword, int size, int nvram_pos); int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos); void sb800_enable_usbdebug(unsigned int port); +#else +void sb800_enable(device_t dev); +void __attribute__((weak)) sb800_setup_sata_phys(struct device *dev); +#endif #endif /* SB800_H */

1 0

[commit] r6306 - trunk/src/mainboard/roda/rk886ex
by repository service 28 Jan '11

28 Jan '11

Author: stepan Date: Fri Jan 28 02:03:18 2011 New Revision: 6306 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6306 Log: rk886ex lacked EC_ACPI Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/src/mainboard/roda/rk886ex/Kconfig Modified: trunk/src/mainboard/roda/rk886ex/Kconfig ============================================================================== --- trunk/src/mainboard/roda/rk886ex/Kconfig Fri Jan 28 00:56:48 2011 (r6305) +++ trunk/src/mainboard/roda/rk886ex/Kconfig Fri Jan 28 02:03:18 2011 (r6306) @@ -10,6 +10,7 @@ select SOUTHBRIDGE_TI_PCI7420 select SUPERIO_SMSC_LPC47N227 select SUPERIO_RENESAS_M3885X + select EC_ACPI select BOARD_HAS_FADT select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE

1 0

build service results for r6305
by repository service 28 Jan '11

28 Jan '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 6305 to the coreboot repository. This caused the following changes: Change Log: Only add EC code if EC is selected in Kconfig Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Build Log: Compilation of amd:bimini_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6305&device=bimini_fam10&v… Compilation of iwave:iWRainbowG6 has been fixed Compilation of rca:rm4100 has been fixed Compilation of roda:rk886ex has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6305&device=rk886ex&vendor… Compilation of thomson:ip1000 has been fixed If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[commit] r6305 - trunk/src/ec
by repository service 28 Jan '11

28 Jan '11

Author: stepan Date: Fri Jan 28 00:56:48 2011 New Revision: 6305 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6305 Log: Only add EC code if EC is selected in Kconfig Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/src/ec/Makefile.inc Modified: trunk/src/ec/Makefile.inc ============================================================================== --- trunk/src/ec/Makefile.inc Thu Jan 27 12:43:03 2011 (r6304) +++ trunk/src/ec/Makefile.inc Fri Jan 28 00:56:48 2011 (r6305) @@ -1 +1 @@ -subdirs-y += acpi +subdirs-$(CONFIG_EC_ACPI) += acpi

1 0

build service results for r6304
by repository service 28 Jan '11

28 Jan '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stuge" checked in revision 6304 to the coreboot repository. This caused the following changes: Change Log: Add new ec subdir for Embedded Controllers and common ACPI EC support Adds a new src/ec subdir for embedded controllers (mostly found in laptops) and converts Getac P470 and Roda RK886EX to use the new ACPI EC instead of having their own copies of those functions. Signed-off-by: Sven Schnelle <svens(a)stackframe.org> Acked-by: Peter Stuge <peter(a)stuge.se> Build Log: Compilation of a-trend:atc-6220 has been fixed Compilation of amd:bimini_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6304&device=bimini_fam10&v… Compilation of iwave:iWRainbowG6 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6304&device=iWRainbowG6&ve… Compilation of rca:rm4100 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6304&device=rm4100&vendor=… Compilation of thomson:ip1000 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6304&device=ip1000&vendor=… If something broke during this checkin please be a pain in stuge's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2011