coreboot September 2010

coreboot@coreboot.org

58 participants
324 discussions

DUAL_VDD_BIT in cpu/amd/model_10xxx/fidvid.c
by xdrudis 29 Sep '10

29 Sep '10

Hello. I'm looking at the fidvid code while trying to make it work for more revisions and so on, and I don't understand its logic. at src/cpu/amd/model_10xxx/fidvid.c line 260 (in prep_fid_change()) it tests F3xA0[31] to tell whether it's in a dual power plane configuration. But according to BKDG : CofVidProg: COF and VID of P-states programmed. Read-only. 1=Out of cold reset, the VID and FID values of the P-state register specified by MSRC001_0071[StartupPstate] have been applied to the processor.0=Out of cold reset, the boot VID is applied to all processor power planes, the NB clock plane is set to 800 MHz (with a FID of 00h=800 MHz and a DID of 0b) and core CPU clock planes are set to 800 MHz (with a FID of 00h=1.6 GHz and a DID of 1h). This affects F3xD4[NbFidEn]. Registers containing P-state information such as FID, DID, and VID values are valid out of cold reset independent of the state of F3xA0[CofVidProg]. BIOS must transition the processor to a valid P-state out of cold reset when F3xA0[CofVidProg]=0. See 2.4.2.6 [BIOS Requirements for P-State Initializa- tion and Transitions]. Does the fact that the CPU has booted into a P-state VID or a boot VID warrant that the system is dual plane or single plane ? The name of the constant does not match any field I've found in the docs, and just 15 lines before it's setting all writeable bits in F3xA0 to 1s in a strange way (for PVI) which make me suspect this part of the code. There's a somewhat related bit in F3x1FC[31]. DualPlaneOnly. Revision B: Reserved. Revision C: Read-only. Reset: value varies by product. Spec- ifies the infrastructure that supports the processor. 0=The processor is supported by both the single- and dual-plane infrastructures. 1=The processor is only supported by the dual-plane infrastructure. See 2.4.2.7 [BIOS Configuration for Dual-plane Only Support]. Which I would understand as saying that if I find an 1 there I know I'm in double plane, and if I find an 0 I don't know anything. So, the question is: a) should I use F3xA0[31] to tell I'm in single or double plane or b) should I have a mainboard defined constant, and maybe check its value against F3x1FC[31] and give a warning if constant says single plane and F3x1FC[31]=1 , or c) is there some input to the processor I can read to tell if I'm in single or double plane without putting the info in the code ? I'm assuming b, but what do you think ? Thank you

1 0

[commit] r5880 - trunk/src/cpu/x86/name
by repository service 29 Sep '10

29 Sep '10

Author: uwe Date: Wed Sep 29 12:51:05 2010 New Revision: 5880 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5880 Log: Forgot to 'svn add' src/cpu/x86/name (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Added: trunk/src/cpu/x86/name/ trunk/src/cpu/x86/name/Makefile.inc trunk/src/cpu/x86/name/name.c Added: trunk/src/cpu/x86/name/Makefile.inc ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/src/cpu/x86/name/Makefile.inc Wed Sep 29 12:51:05 2010 (r5880) @@ -0,0 +1,21 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2010 Uwe Hermann <uwe(a)hermann-uwe.de> +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## +## You should have received a copy of the GNU General Public License +## along with this program; if not, write to the Free Software +## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +## + +obj-y += name.o + Added: trunk/src/cpu/x86/name/name.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/src/cpu/x86/name/name.c Wed Sep 29 12:51:05 2010 (r5880) @@ -0,0 +1,50 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2007-2009 coresystems GmbH + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <string.h> +#include <device/device.h> +#include <cpu/cpu.h> +#include <cpu/x86/name.h> + +void fill_processor_name(char *processor_name) +{ + struct cpuid_result regs; + char temp_processor_name[49]; + char *processor_name_start; + unsigned int *name_as_ints = (unsigned int *)temp_processor_name; + int i; + + for (i = 0; i < 3; i++) { + regs = cpuid(0x80000002 + i); + name_as_ints[i * 4 + 0] = regs.eax; + name_as_ints[i * 4 + 1] = regs.ebx; + name_as_ints[i * 4 + 2] = regs.ecx; + name_as_ints[i * 4 + 3] = regs.edx; + } + + temp_processor_name[48] = 0; + + /* Skip leading spaces. */ + processor_name_start = temp_processor_name; + while (*processor_name_start == ' ') + processor_name_start++; + + memset(processor_name, 0, 49); + strcpy(processor_name, processor_name_start); +}

1 0

build service results for r5879
by repository service 29 Sep '10

29 Sep '10

Dear coreboot readers! This is the automatic build system of coreboot. The developer "uwe" checked in revision 5879 to the coreboot repository. This caused the following changes: Change Log: Factor out fill_processor_name() and strcpy() functions. The fill_processor_name() function was duplicated in multiple model_*_init.c files, move it into a new src/cpu/x86/name directory. The strcpy() function was also duplicated multiple times, move it to <string.h> where we already have similar functions. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Build Log: Compilation of getac:p470 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=p470&vendor=ge… Compilation of ibase:mb899 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=mb899&vendor=i… Compilation of intel:d810e2cb has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=d810e2cb&vendo… Compilation of intel:d945gclf has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=d945gclf&vendo… Compilation of intel:eagleheights has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=eagleheights&v… Compilation of kontron:986lcd-m has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=986lcd-m&vendo… Compilation of rca:rm4100 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=rm4100&vendor=… Compilation of roda:rk886ex has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=rk886ex&vendor… Compilation of thomson:ip1000 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5879&device=ip1000&vendor=… If something broke during this checkin please be a pain in uwe's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[commit] r5879 - in trunk/src: cpu/amd/model_fxx cpu/intel/model_1067x cpu/intel/model_106cx cpu/intel/model_68x cpu/intel/model_6bx cpu/intel/model_6ex cpu/intel/model_6fx include include/cpu/x86
by repository service 29 Sep '10

29 Sep '10

Author: uwe Date: Wed Sep 29 11:54:16 2010 New Revision: 5879 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5879 Log: Factor out fill_processor_name() and strcpy() functions. The fill_processor_name() function was duplicated in multiple model_*_init.c files, move it into a new src/cpu/x86/name directory. The strcpy() function was also duplicated multiple times, move it to <string.h> where we already have similar functions. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Added: trunk/src/include/cpu/x86/name.h Modified: trunk/src/cpu/amd/model_fxx/processor_name.c trunk/src/cpu/intel/model_1067x/Makefile.inc trunk/src/cpu/intel/model_1067x/model_1067x_init.c trunk/src/cpu/intel/model_106cx/Makefile.inc trunk/src/cpu/intel/model_106cx/model_106cx_init.c trunk/src/cpu/intel/model_68x/Makefile.inc trunk/src/cpu/intel/model_68x/model_68x_init.c trunk/src/cpu/intel/model_6bx/Makefile.inc trunk/src/cpu/intel/model_6bx/model_6bx_init.c trunk/src/cpu/intel/model_6ex/Makefile.inc trunk/src/cpu/intel/model_6ex/model_6ex_init.c trunk/src/cpu/intel/model_6fx/Makefile.inc trunk/src/cpu/intel/model_6fx/model_6fx_init.c trunk/src/include/string.h Modified: trunk/src/cpu/amd/model_fxx/processor_name.c ============================================================================== --- trunk/src/cpu/amd/model_fxx/processor_name.c Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/amd/model_fxx/processor_name.c Wed Sep 29 11:54:16 2010 (r5879) @@ -111,12 +111,6 @@ ); } -static inline void strcpy(char *dst, const char *src) -{ - while (*src) *dst++ = *src++; -} - - int init_processor_name(void) { #if CONFIG_K8_REV_F_SUPPORT == 0 Modified: trunk/src/cpu/intel/model_1067x/Makefile.inc ============================================================================== --- trunk/src/cpu/intel/model_1067x/Makefile.inc Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_1067x/Makefile.inc Wed Sep 29 11:54:16 2010 (r5879) @@ -1 +1,3 @@ driver-y += model_1067x_init.o +subdirs-y += ../../x86/name + Modified: trunk/src/cpu/intel/model_1067x/model_1067x_init.c ============================================================================== --- trunk/src/cpu/intel/model_1067x/model_1067x_init.c Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_1067x/model_1067x_init.c Wed Sep 29 11:54:16 2010 (r5879) @@ -31,6 +31,7 @@ #include <cpu/intel/hyperthreading.h> #include <cpu/x86/cache.h> #include <cpu/x86/mtrr.h> +#include <cpu/x86/name.h> static const uint32_t microcode_updates[] = { /* Dummy terminator */ @@ -40,11 +41,6 @@ 0x0, 0x0, 0x0, 0x0, }; -static inline void strcpy(char *dst, char *src) -{ - while (*src) *dst++ = *src++; -} - static void init_timer(void) { /* Set the apic timer to no interrupts and periodic mode */ @@ -57,33 +53,6 @@ lapic_write(LAPIC_TMICT, 0xffffffff); } -static void fill_processor_name(char *processor_name) -{ - struct cpuid_result regs; - char temp_processor_name[49]; - char *processor_name_start; - unsigned int *name_as_ints = (unsigned int *)temp_processor_name; - int i; - - for (i=0; i<3; i++) { - regs = cpuid(0x80000002 + i); - name_as_ints[i*4 + 0] = regs.eax; - name_as_ints[i*4 + 1] = regs.ebx; - name_as_ints[i*4 + 2] = regs.ecx; - name_as_ints[i*4 + 3] = regs.edx; - } - - temp_processor_name[48] = 0; - - /* Skip leading spaces */ - processor_name_start = temp_processor_name; - while (*processor_name_start == ' ') - processor_name_start++; - - memset(processor_name, 0, 49); - strcpy(processor_name, processor_name_start); -} - #define IA32_FEATURE_CONTROL 0x003a #define CPUID_VMX (1 << 5) Modified: trunk/src/cpu/intel/model_106cx/Makefile.inc ============================================================================== --- trunk/src/cpu/intel/model_106cx/Makefile.inc Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_106cx/Makefile.inc Wed Sep 29 11:54:16 2010 (r5879) @@ -1,3 +1,4 @@ driver-y += model_106cx_init.o +subdirs-y += ../../x86/name cpu_incs += $(src)/cpu/intel/model_106cx/cache_as_ram.inc Modified: trunk/src/cpu/intel/model_106cx/model_106cx_init.c ============================================================================== --- trunk/src/cpu/intel/model_106cx/model_106cx_init.c Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_106cx/model_106cx_init.c Wed Sep 29 11:54:16 2010 (r5879) @@ -29,6 +29,7 @@ #include <cpu/intel/hyperthreading.h> #include <cpu/x86/cache.h> #include <cpu/x86/mtrr.h> +#include <cpu/x86/name.h> #include <usbdebug.h> static const uint32_t microcode_updates[] = { @@ -46,38 +47,6 @@ 0x0, 0x0, 0x0, 0x0, }; -static inline void strcpy(char *dst, char *src) -{ - while (*src) *dst++ = *src++; -} - -static void fill_processor_name(char *processor_name) -{ - struct cpuid_result regs; - char temp_processor_name[49]; - char *processor_name_start; - unsigned int *name_as_ints = (unsigned int *)temp_processor_name; - int i; - - for (i=0; i<3; i++) { - regs = cpuid(0x80000002 + i); - name_as_ints[i*4 + 0] = regs.eax; - name_as_ints[i*4 + 1] = regs.ebx; - name_as_ints[i*4 + 2] = regs.ecx; - name_as_ints[i*4 + 3] = regs.edx; - } - - temp_processor_name[48] = 0; - - /* Skip leading spaces */ - processor_name_start = temp_processor_name; - while (*processor_name_start == ' ') - processor_name_start++; - - memset(processor_name, 0, 49); - strcpy(processor_name, processor_name_start); -} - #define IA32_FEATURE_CONTROL 0x003a #define CPUID_VMX (1 << 5) Modified: trunk/src/cpu/intel/model_68x/Makefile.inc ============================================================================== --- trunk/src/cpu/intel/model_68x/Makefile.inc Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_68x/Makefile.inc Wed Sep 29 11:54:16 2010 (r5879) @@ -19,3 +19,5 @@ ## driver-y += model_68x_init.o +subdirs-y += ../../x86/name + Modified: trunk/src/cpu/intel/model_68x/model_68x_init.c ============================================================================== --- trunk/src/cpu/intel/model_68x/model_68x_init.c Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_68x/model_68x_init.c Wed Sep 29 11:54:16 2010 (r5879) @@ -30,6 +30,7 @@ #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> +#include <cpu/x86/name.h> #include <usbdebug.h> static const uint32_t microcode_updates[] = { @@ -58,38 +59,6 @@ 0x0, 0x0, 0x0, 0x0, }; -static inline void strcpy(char *dst, char *src) -{ - while (*src) *dst++ = *src++; -} - -static void fill_processor_name(char *processor_name) -{ - struct cpuid_result regs; - char temp_processor_name[49]; - char *processor_name_start; - unsigned int *name_as_ints = (unsigned int *)temp_processor_name; - int i; - - for (i=0; i<3; i++) { - regs = cpuid(0x80000002 + i); - name_as_ints[i*4 + 0] = regs.eax; - name_as_ints[i*4 + 1] = regs.ebx; - name_as_ints[i*4 + 2] = regs.ecx; - name_as_ints[i*4 + 3] = regs.edx; - } - - temp_processor_name[48] = 0; - - /* Skip leading spaces */ - processor_name_start = temp_processor_name; - while (*processor_name_start == ' ') - processor_name_start++; - - memset(processor_name, 0, 49); - strcpy(processor_name, processor_name_start); -} - #if CONFIG_USBDEBUG static unsigned ehci_debug_addr; #endif Modified: trunk/src/cpu/intel/model_6bx/Makefile.inc ============================================================================== --- trunk/src/cpu/intel/model_6bx/Makefile.inc Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_6bx/Makefile.inc Wed Sep 29 11:54:16 2010 (r5879) @@ -1 +1,2 @@ driver-y += model_6bx_init.o +subdirs-y += ../../x86/name Modified: trunk/src/cpu/intel/model_6bx/model_6bx_init.c ============================================================================== --- trunk/src/cpu/intel/model_6bx/model_6bx_init.c Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_6bx/model_6bx_init.c Wed Sep 29 11:54:16 2010 (r5879) @@ -30,6 +30,7 @@ #include <cpu/x86/lapic.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> +#include <cpu/x86/name.h> #include <usbdebug.h> static const uint32_t microcode_updates[] = { @@ -44,38 +45,6 @@ 0x0, 0x0, 0x0, 0x0, }; -static inline void strcpy(char *dst, char *src) -{ - while (*src) *dst++ = *src++; -} - -static void fill_processor_name(char *processor_name) -{ - struct cpuid_result regs; - char temp_processor_name[49]; - char *processor_name_start; - unsigned int *name_as_ints = (unsigned int *)temp_processor_name; - int i; - - for (i=0; i<3; i++) { - regs = cpuid(0x80000002 + i); - name_as_ints[i*4 + 0] = regs.eax; - name_as_ints[i*4 + 1] = regs.ebx; - name_as_ints[i*4 + 2] = regs.ecx; - name_as_ints[i*4 + 3] = regs.edx; - } - - temp_processor_name[48] = 0; - - /* Skip leading spaces */ - processor_name_start = temp_processor_name; - while (*processor_name_start == ' ') - processor_name_start++; - - memset(processor_name, 0, 49); - strcpy(processor_name, processor_name_start); -} - #if CONFIG_USBDEBUG static unsigned ehci_debug_addr; #endif Modified: trunk/src/cpu/intel/model_6ex/Makefile.inc ============================================================================== --- trunk/src/cpu/intel/model_6ex/Makefile.inc Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_6ex/Makefile.inc Wed Sep 29 11:54:16 2010 (r5879) @@ -1,3 +1,4 @@ driver-y += model_6ex_init.o +subdirs-y += ../../x86/name cpu_incs += $(src)/cpu/intel/model_6ex/cache_as_ram.inc Modified: trunk/src/cpu/intel/model_6ex/model_6ex_init.c ============================================================================== --- trunk/src/cpu/intel/model_6ex/model_6ex_init.c Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_6ex/model_6ex_init.c Wed Sep 29 11:54:16 2010 (r5879) @@ -31,6 +31,7 @@ #include <cpu/intel/hyperthreading.h> #include <cpu/x86/cache.h> #include <cpu/x86/mtrr.h> +#include <cpu/x86/name.h> #include <usbdebug.h> static const uint32_t microcode_updates[] = { @@ -44,38 +45,6 @@ 0x0, 0x0, 0x0, 0x0, }; -static inline void strcpy(char *dst, char *src) -{ - while (*src) *dst++ = *src++; -} - -static void fill_processor_name(char *processor_name) -{ - struct cpuid_result regs; - char temp_processor_name[49]; - char *processor_name_start; - unsigned int *name_as_ints = (unsigned int *)temp_processor_name; - int i; - - for (i=0; i<3; i++) { - regs = cpuid(0x80000002 + i); - name_as_ints[i*4 + 0] = regs.eax; - name_as_ints[i*4 + 1] = regs.ebx; - name_as_ints[i*4 + 2] = regs.ecx; - name_as_ints[i*4 + 3] = regs.edx; - } - - temp_processor_name[48] = 0; - - /* Skip leading spaces */ - processor_name_start = temp_processor_name; - while (*processor_name_start == ' ') - processor_name_start++; - - memset(processor_name, 0, 49); - strcpy(processor_name, processor_name_start); -} - #define IA32_FEATURE_CONTROL 0x003a #define CPUID_VMX (1 << 5) Modified: trunk/src/cpu/intel/model_6fx/Makefile.inc ============================================================================== --- trunk/src/cpu/intel/model_6fx/Makefile.inc Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_6fx/Makefile.inc Wed Sep 29 11:54:16 2010 (r5879) @@ -1 +1,2 @@ driver-y += model_6fx_init.o +subdirs-y += ../../x86/name Modified: trunk/src/cpu/intel/model_6fx/model_6fx_init.c ============================================================================== --- trunk/src/cpu/intel/model_6fx/model_6fx_init.c Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/cpu/intel/model_6fx/model_6fx_init.c Wed Sep 29 11:54:16 2010 (r5879) @@ -31,6 +31,7 @@ #include <cpu/intel/hyperthreading.h> #include <cpu/x86/cache.h> #include <cpu/x86/mtrr.h> +#include <cpu/x86/name.h> #include <usbdebug.h> static const uint32_t microcode_updates[] = { @@ -58,38 +59,6 @@ 0x0, 0x0, 0x0, 0x0, }; -static inline void strcpy(char *dst, char *src) -{ - while (*src) *dst++ = *src++; -} - -static void fill_processor_name(char *processor_name) -{ - struct cpuid_result regs; - char temp_processor_name[49]; - char *processor_name_start; - unsigned int *name_as_ints = (unsigned int *)temp_processor_name; - int i; - - for (i=0; i<3; i++) { - regs = cpuid(0x80000002 + i); - name_as_ints[i*4 + 0] = regs.eax; - name_as_ints[i*4 + 1] = regs.ebx; - name_as_ints[i*4 + 2] = regs.ecx; - name_as_ints[i*4 + 3] = regs.edx; - } - - temp_processor_name[48] = 0; - - /* Skip leading spaces */ - processor_name_start = temp_processor_name; - while (*processor_name_start == ' ') - processor_name_start++; - - memset(processor_name, 0, 49); - strcpy(processor_name, processor_name_start); -} - #define IA32_FEATURE_CONTROL 0x003a #define CPUID_VMX (1 << 5) Added: trunk/src/include/cpu/x86/name.h ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/src/include/cpu/x86/name.h Wed Sep 29 11:54:16 2010 (r5879) @@ -0,0 +1,26 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2010 Uwe Hermann <uwe(a)hermann-uwe.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef CPU_X86_NAME_H +#define CPU_X86_NAME_H + +void fill_processor_name(char *processor_name); + +#endif + Modified: trunk/src/include/string.h ============================================================================== --- trunk/src/include/string.h Tue Sep 28 23:11:48 2010 (r5878) +++ trunk/src/include/string.h Wed Sep 29 11:54:16 2010 (r5879) @@ -68,6 +68,12 @@ return ret; } +static inline void strcpy(char *dst, const char *src) +{ + while (*src) + *dst++ = *src++; +} + static inline int strcmp(const char *s1, const char *s2) { int r;

1 0

[PATCH] Raw payload extraction support in cbfstool
by Aurélien 29 Sep '10

29 Sep '10

Hi, If someone is interested by the feature, here's a patch to extract a raw component (other types need decoding functions, which I did not write) from a coreboot ROM. My particular use-case it that I want to embed a chunk of data (own S/N, P/N and things like that in my coreboot rom, so that this data is really tied to the hardware and survives compact flash changes, etc). It was suggested that I use DMI for this, and indeed it seems interesting, but my Alix.2 board has currently no DMI support, and the current embedding method supposes a recompilation of the rom. Hence, this method of extraction at run-time. I found that using dd on /dev/mem to extract the running rom works well, at the condition of not having STRICT_DEVMEM in the kernel, and reading the whole image in one block. On my board: # dd if=/dev/mem of=/tmp/dump.bin bs=512K count=1 skip=8191 # cbfstool /tmp/dump.bin extract boardata boarddata.bin fills boarddata.bin with the contents of the boarddata cbfs component. Of course you can use any rom image instead of the one extracted from RAM. I tried to make a patch which reads from /dev/mem directly in 2 ways: - mmap()ing /dev/mem, but it seemed that it would be too specific a modification to be accepted. - modifying the loadfile code to extensively use lseek to navigate in the file, reading it like starting at the end, and deducing the size from the CBFS header. This method works well for files, but does not for /dev/mem. So it's relatively useless. I think the problem is due to a bug/feature in /dev/mem implementation. Signed-off-by: Aurelien Guillaume <aurelien(a)iwi.me> Best regards. -- Aurélien Guillaume

4 9

FrontRunner and OLPC memory type?
by Nils 29 Sep '10

29 Sep '10

Hi all, As i finally had a little time to spend on Coreboot i was able to almost finish a patch for Coreboot to autodetect DRAM on the GX2 chipset. I still have one problem that i could use some help with. As the Lippert FrontRunner ,the OLPC btest and the OLPC rev_a seem to have onboard DRAM without SPD memory, i implemented a SPD table in romstage.c . The problem is that i could not find much info on the used ram chips. I only could find 256 MB 64 bit 111Mhz 222 MT/s DDR SDRAM for the Frontrunner board and some SDRAM parameters for the OLPC boards. I used them to guess the rest of the parameters but it would be better to use the exact parameters. So if someone could give me the type numbers for the used SDRAM chips i can search for datasheets and implement the right timing numbers. Thanks,Nils.

6 12

[PATCH] Factor out fill_processor_name() and strcpy() functions.
by Uwe Hermann 28 Sep '10

28 Sep '10

See patch. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org

4 5

[patch] use CURDIR instead of PWD in Makefile
by Jonathan A. Kollasch 28 Sep '10

28 Sep '10

As $PWD is not exported by all shells, use make-builtin $(CURDIR) instead of $(PWD). Signed-off-by: Jonathan Kollasch <jakllsch(a)kollasch.net> ---

3 2

[commit] r5878 - trunk
by repository service 28 Sep '10

28 Sep '10

Author: uwe Date: Tue Sep 28 23:11:48 2010 New Revision: 5878 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5878 Log: As $PWD is not exported by all shells, use make-builtin $(CURDIR) instead of $(PWD). Signed-off-by: Jonathan Kollasch <jakllsch(a)kollasch.net> Acked-by: Peter Stuge <peter(a)stuge.se> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Sep 28 23:02:03 2010 (r5877) +++ trunk/Makefile Tue Sep 28 23:11:48 2010 (r5878) @@ -32,7 +32,7 @@ HOSTCXX:=$(CC_real) --hostcxx endif -export top := $(PWD) +export top := $(CURDIR) export src := src export srck := $(top)/util/kconfig export obj ?= build @@ -196,7 +196,7 @@ $$(abspath $$(patsubst src/%, \ $(obj)/%, \ $$(addprefix $(dir $(1)),$$($(type)-y))))))) \ - $(eval subdirs+=$$(subst $(PWD)/,,$$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y))))) + $(eval subdirs+=$$(subst $(CURDIR)/,,$$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y))))) # For each path in $(subdirs) call includemakefiles, passing $(1) as $(3) # Repeat until subdirs is empty

1 0

[commit] r5877 - trunk
by repository service 28 Sep '10

28 Sep '10

Author: uwe Date: Tue Sep 28 23:02:03 2010 New Revision: 5877 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5877 Log: Fix small typo in root Makefile. Signed-off-by: Warren Turkal <wt(a)penguintechs.org> Acked-by: Peter Stuge <peter(a)stuge.se> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Sep 28 19:48:24 2010 (r5876) +++ trunk/Makefile Tue Sep 28 23:02:03 2010 (r5877) @@ -359,7 +359,7 @@ rm -f $(obj)/coreboot* .ccwrap clean-abuild: - rm -rf coreboot_builds + rm -rf coreboot-builds clean-cscope: rm -f cscope.out

1 0

← Newer
1
2
3
4
5
6
7
8
...
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2010