coreboot March 2010

coreboot@coreboot.org

61 participants
434 discussions

[commit] r5233 - trunk
by repository service 17 Mar '10

17 Mar '10

Author: stepan Date: Wed Mar 17 02:18:14 2010 New Revision: 5233 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5233 Log: make clean: delete failover.inc and romstage.inc, drop auto.inc (obsolete) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Wed Mar 17 02:09:58 2010 (r5232) +++ trunk/Makefile Wed Mar 17 02:18:14 2010 (r5233) @@ -318,7 +318,8 @@ rm -rf $(obj)/bootblock* $(obj)/romstage* $(obj)/location.* rm -f $(obj)/option_table.* $(obj)/crt0_includes.h $(obj)/ldscript rm -f $(obj)/mainboard/$(MAINBOARDDIR)/static.c $(obj)/mainboard/$(MAINBOARDDIR)/config.py $(obj)/mainboard/$(MAINBOARDDIR)/static.dot - rm -f $(obj)/mainboard/$(MAINBOARDDIR)/auto.inc $(obj)/mainboard/$(MAINBOARDDIR)/crt0.s $(obj)/mainboard/$(MAINBOARDDIR)/crt0.disasm + rm -f $(obj)/mainboard/$(MAINBOARDDIR)/crt0.s $(obj)/mainboard/$(MAINBOARDDIR)/crt0.disasm + rm -f $(obj)/mainboard/$(MAINBOARDDIR)/failover.inc $(obj)/mainboard/$(MAINBOARDDIR)/romstage.inc rmdir -p $(alldirs) 2>/dev/null >/dev/null || true $(MAKE) -C util/sconfig clean

1 0

build service results for r5231
by coreboot information 17 Mar '10

17 Mar '10

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 5231 to the coreboot repository. This caused the following changes: Change Log: Source all Kconfig files for IntelÂ® CPU models.. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Build Log: Compilation of dell:s1850 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5231&device=s1850&vendor=d… If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[commit] r5232 - trunk/src/arch/i386/boot
by repository service 17 Mar '10

17 Mar '10

Author: stepan Date: Wed Mar 17 02:09:58 2010 New Revision: 5232 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5232 Log: drop unused variable Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/src/arch/i386/boot/pirq_routing.c Modified: trunk/src/arch/i386/boot/pirq_routing.c ============================================================================== --- trunk/src/arch/i386/boot/pirq_routing.c Wed Mar 17 01:55:39 2010 (r5231) +++ trunk/src/arch/i386/boot/pirq_routing.c Wed Mar 17 02:09:58 2010 (r5232) @@ -107,7 +107,6 @@ unsigned char irq_slot[4]; unsigned char pirq[4] = {0, 0, 0, 0}; struct irq_routing_table *pirq_tbl; - device_t pdev; pirq_tbl = (struct irq_routing_table *)(addr); num_entries = (pirq_tbl->size - 32) / 16;

1 0

[commit] r5231 - trunk/src/cpu/intel
by repository service 17 Mar '10

17 Mar '10

Author: stepan Date: Wed Mar 17 01:55:39 2010 New Revision: 5231 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5231 Log: Source all Kconfig files for IntelÂ® CPU models.. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/src/cpu/intel/Kconfig Modified: trunk/src/cpu/intel/Kconfig ============================================================================== --- trunk/src/cpu/intel/Kconfig Wed Mar 17 01:23:34 2010 (r5230) +++ trunk/src/cpu/intel/Kconfig Wed Mar 17 01:55:39 2010 (r5231) @@ -1,12 +1,19 @@ +# CPU models +source src/cpu/intel/model_6xx/Kconfig source src/cpu/intel/model_69x/Kconfig source src/cpu/intel/model_6dx/Kconfig source src/cpu/intel/model_6ex/Kconfig source src/cpu/intel/model_6fx/Kconfig source src/cpu/intel/model_1067x/Kconfig source src/cpu/intel/model_106cx/Kconfig - -source src/cpu/intel/bga956/Kconfig +source src/cpu/intel/model_f0x/Kconfig +source src/cpu/intel/model_f1x/Kconfig +source src/cpu/intel/model_f2x/Kconfig +source src/cpu/intel/model_f3x/Kconfig +source src/cpu/intel/model_f4x/Kconfig source src/cpu/intel/ep80579/Kconfig +# Sockets/Slots +source src/cpu/intel/bga956/Kconfig source src/cpu/intel/slot_2/Kconfig source src/cpu/intel/slot_1/Kconfig source src/cpu/intel/socket_mFCPGA478/Kconfig

1 0

Ouch: romcc "x[0] |= something" patch causes another crash
by Keith Hui 17 Mar '10

17 Mar '10

Hi all, I regret to report that the romcc patch circulated earlier to fix the segfault I reported, is now causing another segfault. This also seems to be triggered by something in the 440BX code, as it didn't segfault when I compile for any mainboards that isn't 440BX. As of now I don't know what this new segfault is. I'll report back with more findings. Thanks Keith

5 15

[commit] r5230 - trunk/util/romcc
by repository service 17 Mar '10

17 Mar '10

Author: stepan Date: Wed Mar 17 01:23:34 2010 New Revision: 5230 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5230 Log: Catch non-static arrays in romcc. Not allowed. Signed-off-by: Eric W. Biederman <ebiederm(a)xmission.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/util/romcc/romcc.c Modified: trunk/util/romcc/romcc.c ============================================================================== --- trunk/util/romcc/romcc.c Wed Mar 17 00:33:29 2010 (r5229) +++ trunk/util/romcc/romcc.c Wed Mar 17 01:23:34 2010 (r5230) @@ -13473,6 +13473,10 @@ if ((type->type & TYPE_MASK) == TYPE_FUNCTION) { error(state, 0, "Function prototypes not supported"); } + if (ident && + ((type->type & TYPE_MASK) == TYPE_ARRAY) && + ((type->type & STOR_MASK) != STOR_STATIC)) + error(state, 0, "non static arrays not supported"); if (ident && ((type->type & STOR_MASK) == STOR_STATIC) && ((type->type & QUAL_CONST) == 0)) {

1 0

[commit] r5229 - in trunk: documentation src/northbridge/amd/amdfam10 src/northbridge/intel/i3100 src/northbridge/via/vx800 src/southbridge/amd/rs690 src/southbridge/amd/rs780 src/southbridge/amd/s...
by repository service 17 Mar '10

17 Mar '10

Author: stepan Date: Wed Mar 17 00:33:29 2010 New Revision: 5229 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5229 Log: pci drivers should be const. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/documentation/LinuxBIOS-AMD64.tex trunk/src/northbridge/amd/amdfam10/misc_control.c trunk/src/northbridge/amd/amdfam10/northbridge.c trunk/src/northbridge/intel/i3100/northbridge.c trunk/src/northbridge/intel/i3100/pciexp_porta.c trunk/src/northbridge/intel/i3100/pciexp_porta_ep80579.c trunk/src/northbridge/via/vx800/vx800_ide.c trunk/src/northbridge/via/vx800/vx800_lpc.c trunk/src/southbridge/amd/rs690/rs690_gfx.c trunk/src/southbridge/amd/rs690/rs690_ht.c trunk/src/southbridge/amd/rs780/rs780_gfx.c trunk/src/southbridge/amd/rs780/rs780_ht.c trunk/src/southbridge/amd/sb600/sb600_ac97.c trunk/src/southbridge/amd/sb600/sb600_hda.c trunk/src/southbridge/amd/sb600/sb600_ide.c trunk/src/southbridge/amd/sb600/sb600_lpc.c trunk/src/southbridge/amd/sb600/sb600_pci.c trunk/src/southbridge/amd/sb600/sb600_sata.c trunk/src/southbridge/amd/sb600/sb600_sm.c trunk/src/southbridge/amd/sb600/sb600_usb.c trunk/src/southbridge/amd/sb700/sb700_hda.c trunk/src/southbridge/amd/sb700/sb700_ide.c trunk/src/southbridge/amd/sb700/sb700_lpc.c trunk/src/southbridge/amd/sb700/sb700_pci.c trunk/src/southbridge/amd/sb700/sb700_sata.c trunk/src/southbridge/amd/sb700/sb700_sm.c trunk/src/southbridge/amd/sb700/sb700_usb.c trunk/src/southbridge/broadcom/bcm21000/bcm21000_pcie.c trunk/src/southbridge/intel/i3100/i3100_ehci.c trunk/src/southbridge/intel/i3100/i3100_lpc.c trunk/src/southbridge/intel/i3100/i3100_pci.c trunk/src/southbridge/intel/i3100/i3100_pciexp_portb.c trunk/src/southbridge/intel/i3100/i3100_sata.c trunk/src/southbridge/intel/i3100/i3100_smbus.c trunk/src/southbridge/intel/i3100/i3100_uhci.c Modified: trunk/documentation/LinuxBIOS-AMD64.tex ============================================================================== --- trunk/documentation/LinuxBIOS-AMD64.tex Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/documentation/LinuxBIOS-AMD64.tex Wed Mar 17 00:33:29 2010 (r5229) @@ -1204,7 +1204,7 @@ .init = lsi_scsi_init, .scan_bus = 0, }; - static struct pci_driver lsi_scsi_driver __pci_driver = { + static const struct pci_driver lsi_scsi_driver __pci_driver = { .ops = &lsi_scsi_ops, .vendor = 0xXXXX, .device = 0xXXXX, Modified: trunk/src/northbridge/amd/amdfam10/misc_control.c ============================================================================== --- trunk/src/northbridge/amd/amdfam10/misc_control.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/northbridge/amd/amdfam10/misc_control.c Wed Mar 17 00:33:29 2010 (r5229) @@ -147,7 +147,7 @@ .ops_pci = 0, }; -static struct pci_driver mcf3_driver __pci_driver = { +static const struct pci_driver mcf3_driver __pci_driver = { .ops = &mcf3_ops, .vendor = PCI_VENDOR_ID_AMD, .device = 0x1203, Modified: trunk/src/northbridge/amd/amdfam10/northbridge.c ============================================================================== --- trunk/src/northbridge/amd/amdfam10/northbridge.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/northbridge/amd/amdfam10/northbridge.c Wed Mar 17 00:33:29 2010 (r5229) @@ -633,7 +633,7 @@ }; -static struct pci_driver mcf0_driver __pci_driver = { +static const struct pci_driver mcf0_driver __pci_driver = { .ops = &northbridge_operations, .vendor = PCI_VENDOR_ID_AMD, .device = 0x1200, Modified: trunk/src/northbridge/intel/i3100/northbridge.c ============================================================================== --- trunk/src/northbridge/intel/i3100/northbridge.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/northbridge/intel/i3100/northbridge.c Wed Mar 17 00:33:29 2010 (r5229) @@ -233,7 +233,7 @@ .ops_pci = &intel_pci_ops, }; -static struct pci_driver mc_driver __pci_driver = { +static const struct pci_driver mc_driver __pci_driver = { .ops = &mc_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_MC, Modified: trunk/src/northbridge/intel/i3100/pciexp_porta.c ============================================================================== --- trunk/src/northbridge/intel/i3100/pciexp_porta.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/northbridge/intel/i3100/pciexp_porta.c Wed Mar 17 00:33:29 2010 (r5229) @@ -75,13 +75,13 @@ .ops_pci = 0, }; -static struct pci_driver pci_driver_0 __pci_driver = { +static const struct pci_driver pci_driver_0 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_PCIE_PA0, }; -static struct pci_driver pci_driver_1 __pci_driver = { +static const struct pci_driver pci_driver_1 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_PCIE_PA1, Modified: trunk/src/northbridge/intel/i3100/pciexp_porta_ep80579.c ============================================================================== --- trunk/src/northbridge/intel/i3100/pciexp_porta_ep80579.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/northbridge/intel/i3100/pciexp_porta_ep80579.c Wed Mar 17 00:33:29 2010 (r5229) @@ -99,13 +99,13 @@ .ops_pci = 0, }; -static struct pci_driver pci_driver_0 __pci_driver = { +static const struct pci_driver pci_driver_0 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_PCIE_PA0, }; -static struct pci_driver pci_driver_1 __pci_driver = { +static const struct pci_driver pci_driver_1 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_PCIE_PA1, Modified: trunk/src/northbridge/via/vx800/vx800_ide.c ============================================================================== --- trunk/src/northbridge/via/vx800/vx800_ide.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/northbridge/via/vx800/vx800_ide.c Wed Mar 17 00:33:29 2010 (r5229) @@ -261,7 +261,7 @@ .ops_pci = 0, }; -static struct pci_driver via_ide_driver __pci_driver = { +static const struct pci_driver via_ide_driver __pci_driver = { .ops = &ide_ops, .vendor = PCI_VENDOR_ID_VIA, .device = PCI_DEVICE_ID_VIA_VX855_IDE, Modified: trunk/src/northbridge/via/vx800/vx800_lpc.c ============================================================================== --- trunk/src/northbridge/via/vx800/vx800_lpc.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/northbridge/via/vx800/vx800_lpc.c Wed Mar 17 00:33:29 2010 (r5229) @@ -380,7 +380,7 @@ .scan_bus = scan_static_bus, }; -static struct pci_driver lpc_driver __pci_driver = { +static const struct pci_driver lpc_driver __pci_driver = { .ops = &vx800_lpc_ops, .vendor = PCI_VENDOR_ID_VIA, .device = PCI_DEVICE_ID_VIA_VX855_LPC, Modified: trunk/src/southbridge/amd/rs690/rs690_gfx.c ============================================================================== --- trunk/src/southbridge/amd/rs690/rs690_gfx.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/rs690/rs690_gfx.c Wed Mar 17 00:33:29 2010 (r5229) @@ -211,13 +211,13 @@ * The dev id of 690G is 791E, while the id of 690M, 690T is 791F. * We should list both of them here. * */ -static struct pci_driver pcie_driver_690t __pci_driver = { +static const struct pci_driver pcie_driver_690t __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS690MT_INT_GFX, }; -static struct pci_driver pcie_driver_690 __pci_driver = { +static const struct pci_driver pcie_driver_690 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS690_INT_GFX, Modified: trunk/src/southbridge/amd/rs690/rs690_ht.c ============================================================================== --- trunk/src/southbridge/amd/rs690/rs690_ht.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/rs690/rs690_ht.c Wed Mar 17 00:33:29 2010 (r5229) @@ -83,7 +83,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ht_driver __pci_driver = { +static const struct pci_driver ht_driver __pci_driver = { .ops = &ht_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS690_HT, Modified: trunk/src/southbridge/amd/rs780/rs780_gfx.c ============================================================================== --- trunk/src/southbridge/amd/rs780/rs780_gfx.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/rs780/rs780_gfx.c Wed Mar 17 00:33:29 2010 (r5229) @@ -791,28 +791,28 @@ /* * We should list all of them here. * */ -static struct pci_driver pcie_driver_780 __pci_driver = { +static const struct pci_driver pcie_driver_780 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS780_INT_GFX, }; -static struct pci_driver pcie_driver_780c __pci_driver = { +static const struct pci_driver pcie_driver_780c __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS780C_INT_GFX, }; -static struct pci_driver pcie_driver_780m __pci_driver = { +static const struct pci_driver pcie_driver_780m __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS780M_INT_GFX, }; -static struct pci_driver pcie_driver_780mc __pci_driver = { +static const struct pci_driver pcie_driver_780mc __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS780MC_INT_GFX, }; -static struct pci_driver pcie_driver_780e __pci_driver = { +static const struct pci_driver pcie_driver_780e __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_RS780E_INT_GFX, Modified: trunk/src/southbridge/amd/rs780/rs780_ht.c ============================================================================== --- trunk/src/southbridge/amd/rs780/rs780_ht.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/rs780/rs780_ht.c Wed Mar 17 00:33:29 2010 (r5229) @@ -83,7 +83,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ht_driver __pci_driver = { +static const struct pci_driver ht_driver __pci_driver = { .ops = &ht_ops, .vendor = PCI_VENDOR_ID_AMD, .device = PCI_DEVICE_ID_AMD_RS780_HT, Modified: trunk/src/southbridge/amd/sb600/sb600_ac97.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_ac97.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_ac97.c Wed Mar 17 00:33:29 2010 (r5229) @@ -38,7 +38,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ac97audio_driver __pci_driver = { +static const struct pci_driver ac97audio_driver __pci_driver = { .ops = &ac97audio_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_ACI, @@ -54,7 +54,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ac97modem_driver __pci_driver = { +static const struct pci_driver ac97modem_driver __pci_driver = { .ops = &ac97modem_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_MCI, Modified: trunk/src/southbridge/amd/sb600/sb600_hda.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_hda.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_hda.c Wed Mar 17 00:33:29 2010 (r5229) @@ -325,7 +325,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver hdaaudio_driver __pci_driver = { +static const struct pci_driver hdaaudio_driver __pci_driver = { .ops = &hda_audio_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_HDA, Modified: trunk/src/southbridge/amd/sb600/sb600_ide.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_ide.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_ide.c Wed Mar 17 00:33:29 2010 (r5229) @@ -68,7 +68,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ide_driver __pci_driver = { +static const struct pci_driver ide_driver __pci_driver = { .ops = &ide_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_IDE, Modified: trunk/src/southbridge/amd/sb600/sb600_lpc.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_lpc.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_lpc.c Wed Mar 17 00:33:29 2010 (r5229) @@ -228,7 +228,7 @@ /* .enable = sb600_enable, */ .ops_pci = &lops_pci, }; -static struct pci_driver lpc_driver __pci_driver = { +static const struct pci_driver lpc_driver __pci_driver = { .ops = &lpc_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_LPC, Modified: trunk/src/southbridge/amd/sb600/sb600_pci.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_pci.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_pci.c Wed Mar 17 00:33:29 2010 (r5229) @@ -135,7 +135,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver pci_driver __pci_driver = { +static const struct pci_driver pci_driver __pci_driver = { .ops = &pci_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_PCI, Modified: trunk/src/southbridge/amd/sb600/sb600_sata.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_sata.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_sata.c Wed Mar 17 00:33:29 2010 (r5229) @@ -258,7 +258,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver sata0_driver __pci_driver = { +static const struct pci_driver sata0_driver __pci_driver = { .ops = &sata_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_SATA, Modified: trunk/src/southbridge/amd/sb600/sb600_sm.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_sm.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_sm.c Wed Mar 17 00:33:29 2010 (r5229) @@ -367,7 +367,7 @@ .ops_pci = &lops_pci, .ops_smbus_bus = &lops_smbus_bus, }; -static struct pci_driver smbus_driver __pci_driver = { +static const struct pci_driver smbus_driver __pci_driver = { .ops = &smbus_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_SM, Modified: trunk/src/southbridge/amd/sb600/sb600_usb.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sb600_usb.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb600/sb600_usb.c Wed Mar 17 00:33:29 2010 (r5229) @@ -159,27 +159,27 @@ .ops_pci = &lops_pci, }; -static struct pci_driver usb_0_driver __pci_driver = { +static const struct pci_driver usb_0_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_USB_0, }; -static struct pci_driver usb_1_driver __pci_driver = { +static const struct pci_driver usb_1_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_USB_1, }; -static struct pci_driver usb_2_driver __pci_driver = { +static const struct pci_driver usb_2_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_USB_2, }; -static struct pci_driver usb_3_driver __pci_driver = { +static const struct pci_driver usb_3_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_USB_3, }; -static struct pci_driver usb_4_driver __pci_driver = { +static const struct pci_driver usb_4_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_USB_4, @@ -195,7 +195,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver usb_5_driver __pci_driver = { +static const struct pci_driver usb_5_driver __pci_driver = { .ops = &usb_ops2, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB600_USB2, Modified: trunk/src/southbridge/amd/sb700/sb700_hda.c ============================================================================== --- trunk/src/southbridge/amd/sb700/sb700_hda.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb700/sb700_hda.c Wed Mar 17 00:33:29 2010 (r5229) @@ -225,7 +225,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver hdaaudio_driver __pci_driver = { +static const struct pci_driver hdaaudio_driver __pci_driver = { .ops = &hda_audio_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_HDA, Modified: trunk/src/southbridge/amd/sb700/sb700_ide.c ============================================================================== --- trunk/src/southbridge/amd/sb700/sb700_ide.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb700/sb700_ide.c Wed Mar 17 00:33:29 2010 (r5229) @@ -76,7 +76,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ide_driver __pci_driver = { +static const struct pci_driver ide_driver __pci_driver = { .ops = &ide_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_IDE, Modified: trunk/src/southbridge/amd/sb700/sb700_lpc.c ============================================================================== --- trunk/src/southbridge/amd/sb700/sb700_lpc.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb700/sb700_lpc.c Wed Mar 17 00:33:29 2010 (r5229) @@ -240,7 +240,7 @@ .scan_bus = scan_static_bus, .ops_pci = &lops_pci, }; -static struct pci_driver lpc_driver __pci_driver = { +static const struct pci_driver lpc_driver __pci_driver = { .ops = &lpc_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_LPC, Modified: trunk/src/southbridge/amd/sb700/sb700_pci.c ============================================================================== --- trunk/src/southbridge/amd/sb700/sb700_pci.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb700/sb700_pci.c Wed Mar 17 00:33:29 2010 (r5229) @@ -121,7 +121,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver pci_driver __pci_driver = { +static const struct pci_driver pci_driver __pci_driver = { .ops = &pci_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_PCI, Modified: trunk/src/southbridge/amd/sb700/sb700_sata.c ============================================================================== --- trunk/src/southbridge/amd/sb700/sb700_sata.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb700/sb700_sata.c Wed Mar 17 00:33:29 2010 (r5229) @@ -284,7 +284,7 @@ .ops_pci = &lops_pci, }; -static struct pci_driver sata0_driver __pci_driver = { +static const struct pci_driver sata0_driver __pci_driver = { .ops = &sata_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_SATA, Modified: trunk/src/southbridge/amd/sb700/sb700_sm.c ============================================================================== --- trunk/src/southbridge/amd/sb700/sb700_sm.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb700/sb700_sm.c Wed Mar 17 00:33:29 2010 (r5229) @@ -374,7 +374,7 @@ .ops_pci = &lops_pci, .ops_smbus_bus = &lops_smbus_bus, }; -static struct pci_driver smbus_driver __pci_driver = { +static const struct pci_driver smbus_driver __pci_driver = { .ops = &smbus_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_SM, Modified: trunk/src/southbridge/amd/sb700/sb700_usb.c ============================================================================== --- trunk/src/southbridge/amd/sb700/sb700_usb.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/amd/sb700/sb700_usb.c Wed Mar 17 00:33:29 2010 (r5229) @@ -200,12 +200,12 @@ .ops_pci = &lops_pci, }; -static struct pci_driver usb_0_driver __pci_driver = { +static const struct pci_driver usb_0_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_USB_18_0, }; -static struct pci_driver usb_1_driver __pci_driver = { +static const struct pci_driver usb_1_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_USB_18_1, @@ -213,19 +213,19 @@ /* the pci id of usb ctrl 0 and 1 are the same. */ /* - * static struct pci_driver usb_3_driver __pci_driver = { + * static const struct pci_driver usb_3_driver __pci_driver = { * .ops = &usb_ops, * .vendor = PCI_VENDOR_ID_ATI, * .device = PCI_DEVICE_ID_ATI_SB700_USB_19_0, * }; - * static struct pci_driver usb_4_driver __pci_driver = { + * static const struct pci_driver usb_4_driver __pci_driver = { * .ops = &usb_ops, * .vendor = PCI_VENDOR_ID_ATI, * .device = PCI_DEVICE_ID_ATI_SB700_USB_19_1, * }; */ -static struct pci_driver usb_4_driver __pci_driver = { +static const struct pci_driver usb_4_driver __pci_driver = { .ops = &usb_ops, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_USB_20_5, @@ -240,13 +240,13 @@ .ops_pci = &lops_pci, }; -static struct pci_driver usb_5_driver __pci_driver = { +static const struct pci_driver usb_5_driver __pci_driver = { .ops = &usb_ops2, .vendor = PCI_VENDOR_ID_ATI, .device = PCI_DEVICE_ID_ATI_SB700_USB_18_2, }; /* - * static struct pci_driver usb_5_driver __pci_driver = { + * static const struct pci_driver usb_5_driver __pci_driver = { * .ops = &usb_ops2, * .vendor = PCI_VENDOR_ID_ATI, * .device = PCI_DEVICE_ID_ATI_SB700_USB_19_2, Modified: trunk/src/southbridge/broadcom/bcm21000/bcm21000_pcie.c ============================================================================== --- trunk/src/southbridge/broadcom/bcm21000/bcm21000_pcie.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/broadcom/bcm21000/bcm21000_pcie.c Wed Mar 17 00:33:29 2010 (r5229) @@ -62,19 +62,19 @@ }; -static struct pci_driver pcie_driver1 __pci_driver = { +static const struct pci_driver pcie_driver1 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_SERVERWORKS, .device = PCI_DEVICE_ID_SERVERWORKS_BCM21000_EXB0, }; -static struct pci_driver pcie_driver2 __pci_driver = { +static const struct pci_driver pcie_driver2 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_SERVERWORKS, .device = PCI_DEVICE_ID_SERVERWORKS_BCM21000_EXB1, }; -static struct pci_driver pcie_driver3 __pci_driver = { +static const struct pci_driver pcie_driver3 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_SERVERWORKS, .device = PCI_DEVICE_ID_SERVERWORKS_BCM21000_EXB2, Modified: trunk/src/southbridge/intel/i3100/i3100_ehci.c ============================================================================== --- trunk/src/southbridge/intel/i3100/i3100_ehci.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/intel/i3100/i3100_ehci.c Wed Mar 17 00:33:29 2010 (r5229) @@ -55,13 +55,13 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ehci_driver __pci_driver = { +static const struct pci_driver ehci_driver __pci_driver = { .ops = &ehci_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_EHCI, }; -static struct pci_driver ehci_driver_ep80579 __pci_driver = { +static const struct pci_driver ehci_driver_ep80579 __pci_driver = { .ops = &ehci_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_EHCI, Modified: trunk/src/southbridge/intel/i3100/i3100_lpc.c ============================================================================== --- trunk/src/southbridge/intel/i3100/i3100_lpc.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/intel/i3100/i3100_lpc.c Wed Mar 17 00:33:29 2010 (r5229) @@ -422,13 +422,13 @@ .ops_pci = &lops_pci, }; -static struct pci_driver lpc_driver __pci_driver = { +static const struct pci_driver lpc_driver __pci_driver = { .ops = &lpc_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_LPC, }; -static struct pci_driver lpc_driver_ep80579 __pci_driver = { +static const struct pci_driver lpc_driver_ep80579 __pci_driver = { .ops = &lpc_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_LPC, Modified: trunk/src/southbridge/intel/i3100/i3100_pci.c ============================================================================== --- trunk/src/southbridge/intel/i3100/i3100_pci.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/intel/i3100/i3100_pci.c Wed Mar 17 00:33:29 2010 (r5229) @@ -38,7 +38,7 @@ .ops_pci = 0, }; -static struct pci_driver pci_driver __pci_driver = { +static const struct pci_driver pci_driver __pci_driver = { .ops = &pci_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_PCI, Modified: trunk/src/southbridge/intel/i3100/i3100_pciexp_portb.c ============================================================================== --- trunk/src/southbridge/intel/i3100/i3100_pciexp_portb.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/intel/i3100/i3100_pciexp_portb.c Wed Mar 17 00:33:29 2010 (r5229) @@ -69,25 +69,25 @@ .ops_pci = 0, }; -static struct pci_driver pci_driver_0 __pci_driver = { +static const struct pci_driver pci_driver_0 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_PCIE_PB0, }; -static struct pci_driver pci_driver_1 __pci_driver = { +static const struct pci_driver pci_driver_1 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_PCIE_PB1, }; -static struct pci_driver pci_driver_2 __pci_driver = { +static const struct pci_driver pci_driver_2 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_PCIE_PB2, }; -static struct pci_driver pci_driver_3 __pci_driver = { +static const struct pci_driver pci_driver_3 __pci_driver = { .ops = &pcie_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_PCIE_PB3, Modified: trunk/src/southbridge/intel/i3100/i3100_sata.c ============================================================================== --- trunk/src/southbridge/intel/i3100/i3100_sata.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/intel/i3100/i3100_sata.c Wed Mar 17 00:33:29 2010 (r5229) @@ -120,25 +120,25 @@ .ops_pci = &lops_pci, }; -static struct pci_driver ide_driver __pci_driver = { +static const struct pci_driver ide_driver __pci_driver = { .ops = &sata_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_IDE, }; -static struct pci_driver sata_driver __pci_driver = { +static const struct pci_driver sata_driver __pci_driver = { .ops = &sata_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_AHCI, }; -static struct pci_driver ide_driver_ep80579 __pci_driver = { +static const struct pci_driver ide_driver_ep80579 __pci_driver = { .ops = &sata_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_IDE, }; -static struct pci_driver sata_driver_ep80579 __pci_driver = { +static const struct pci_driver sata_driver_ep80579 __pci_driver = { .ops = &sata_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_AHCI, Modified: trunk/src/southbridge/intel/i3100/i3100_smbus.c ============================================================================== --- trunk/src/southbridge/intel/i3100/i3100_smbus.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/intel/i3100/i3100_smbus.c Wed Mar 17 00:33:29 2010 (r5229) @@ -66,13 +66,13 @@ .ops_smbus_bus = &lops_smbus_bus, }; -static struct pci_driver smbus_driver __pci_driver = { +static const struct pci_driver smbus_driver __pci_driver = { .ops = &smbus_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_SMB, }; -static struct pci_driver smbus_driver_ep80579 __pci_driver = { +static const struct pci_driver smbus_driver_ep80579 __pci_driver = { .ops = &smbus_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_SMB, Modified: trunk/src/southbridge/intel/i3100/i3100_uhci.c ============================================================================== --- trunk/src/southbridge/intel/i3100/i3100_uhci.c Wed Mar 17 00:07:29 2010 (r5228) +++ trunk/src/southbridge/intel/i3100/i3100_uhci.c Wed Mar 17 00:33:29 2010 (r5229) @@ -49,19 +49,19 @@ .ops_pci = &lops_pci, }; -static struct pci_driver uhci_driver __pci_driver = { +static const struct pci_driver uhci_driver __pci_driver = { .ops = &uhci_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_UHCI, }; -static struct pci_driver usb2_driver __pci_driver = { +static const struct pci_driver usb2_driver __pci_driver = { .ops = &uhci_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_3100_UHCI2, }; -static struct pci_driver uhci_driver_ep80579 __pci_driver = { +static const struct pci_driver uhci_driver_ep80579 __pci_driver = { .ops = &uhci_ops, .vendor = PCI_VENDOR_ID_INTEL, .device = PCI_DEVICE_ID_INTEL_EP80579_UHCI,

1 0

[commit] r5228 - in trunk: . src/devices src/devices/oprom util/x86emu
by repository service 17 Mar '10

17 Mar '10

Author: stepan Date: Wed Mar 17 00:07:29 2010 New Revision: 5228 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5228 Log: it was reason for workaround rules already, and it's somewhat ugly: util/x86emu is the only part of coreboot that is linked into coreboot itself that lives in util/. It's not a utility and it does not really belong where it lives. ---> svn mv util/x86emu src/devices/oprom plus necessary Makefile changes to get it building again Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Peter Stuge <peter(a)stuge.se> Added: trunk/src/devices/oprom/ - copied from r5227, trunk/util/x86emu/ Deleted: trunk/util/x86emu/ Modified: trunk/Makefile trunk/src/devices/Makefile.inc Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Mar 16 20:23:17 2010 (r5227) +++ trunk/Makefile Wed Mar 17 00:07:29 2010 (r5228) @@ -96,7 +96,7 @@ PLATFORM-y += src/arch/$(ARCHDIR-y) src/cpu src/mainboard/$(MAINBOARDDIR) TARGETS-y := -BUILD-y := src/lib src/boot src/console src/devices src/southbridge src/northbridge src/superio src/drivers util/x86emu +BUILD-y := src/lib src/boot src/console src/devices src/southbridge src/northbridge src/superio src/drivers BUILD-y += util/cbfstool BUILD-$(CONFIG_ARCH_X86) += src/pc80 @@ -162,11 +162,9 @@ $(if $(strip $(3)), \ $(foreach type,$(2), \ $(eval $(type)s+= \ - $$(abspath $$(patsubst util/%, \ - $(obj)/util/%, \ - $$(patsubst src/%, \ + $$(abspath $$(patsubst src/%, \ $(obj)/%, \ - $$(addprefix $(dir $(1)),$$($(type)-y)))))))) \ + $$(addprefix $(dir $(1)),$$($(type)-y))))))) \ $(eval subdirs+=$$(subst $(PWD)/,,$$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y))))) # For each path in $(subdirs) call includemakefiles, passing $(1) as $(3) @@ -214,10 +212,6 @@ # $3 .o infix ("" ".initobj", ...) # $4 additional compiler flags de$(EMPTY)fine $(1)_$(2)_template -$(obj)/$$(1)%$(3).o: $$(1)%.$(2) $(obj)/config.h - printf " CC $$$$(subst $$$$(obj)/,,$$$$(@))\n" - $(CC) $(4) $$$$(CFLAGS) -c -o $$$$@ $$$$< - $(obj)/$$(1)%$(3).o: src/$$(1)%.$(2) $(obj)/config.h printf " CC $$$$(subst $$$$(obj)/,,$$$$(@))\n" $(CC) $(4) $$$$(CFLAGS) -c -o $$$$@ $$$$< @@ -263,7 +257,7 @@ OBJS := $(patsubst %,$(obj)/%,$(TARGETS-y)) INCLUDES := -I$(top)/src -I$(top)/src/include -I$(obj) -I$(top)/src/arch/$(ARCHDIR-y)/include -INCLUDES += -I$(top)/util/x86emu/include +INCLUDES += -I$(top)/src/devices/oprom/include INCLUDES += -include $(obj)/config.h CFLAGS = $(INCLUDES) -Os -nostdinc -pipe Modified: trunk/src/devices/Makefile.inc ============================================================================== --- trunk/src/devices/Makefile.inc Tue Mar 16 20:23:17 2010 (r5227) +++ trunk/src/devices/Makefile.inc Wed Mar 17 00:07:29 2010 (r5228) @@ -13,9 +13,9 @@ ifeq ($(CONFIG_PCI_ROM_RUN),y) obj-y += pci_rom.o -subdirs-y += ../../util/x86emu +subdirs-y += oprom else obj-$(CONFIG_VGA_ROM_RUN) += pci_rom.o -subdirs-$(CONFIG_VGA_ROM_RUN) += ../../util/x86emu +subdirs-$(CONFIG_VGA_ROM_RUN) += oprom endif

1 0

[PATCH]more buildsystem refactoring
by Patrick Georgi 16 Mar '10

16 Mar '10

Hi, attached patch changes several things in the buildsystem: - Single instance of the CC build rule in Makefile, instantiated as necessary - Remove manual static.o and option_table.o rules, they're now covered by those instances of the CC build rule - Normalize object file paths, so it can be $(obj)/option_table.o instead of $(obj)/arch/i386/../../option_table.o now - Add -pipe to compiler flags. It might be detrimental on rare scenarios (building with extremly high disk bandwidth, eg. RAM disk), but it significantly helps on win32 (which seems to cache less aggressively than most unix-alikes) - Silence stderr on hostname and domainname invocations (cosmetic fix for cygwin) - Test for -Wa,--divide functionality of the target compiler (taken from abuild). It might be possible to remove most patches in crossgcc with that. - Report build of failover.inc and romstage.inc Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de

3 3

[commit] r5227 - trunk/src/arch/i386
by repository service 16 Mar '10

16 Mar '10

Author: oxygene Date: Tue Mar 16 20:23:17 2010 New Revision: 5227 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5227 Log: Left over strip_quotes definition. Top level Makefile already provides this. Thanks Myles for catching this. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Modified: trunk/src/arch/i386/Makefile.inc Modified: trunk/src/arch/i386/Makefile.inc ============================================================================== --- trunk/src/arch/i386/Makefile.inc Tue Mar 16 20:01:32 2010 (r5226) +++ trunk/src/arch/i386/Makefile.inc Tue Mar 16 20:23:17 2010 (r5227) @@ -24,7 +24,6 @@ ifeq ($(CONFIG_BOOTSPLASH),y) COREBOOT_ROM_DEPENDENCIES+=$(CONFIG_FALLBACK_BOOTSPLASH_FILE) endif -strip_quotes = $(subst ",,$(subst \",,$(1))) $(obj)/coreboot.rom: $(obj)/coreboot.pre $(obj)/coreboot_ram $(CBFSTOOL) $(call strip_quotes,$(COREBOOT_ROM_DEPENDENCIES)) cp $(obj)/coreboot.pre $@.tmp if [ -f fallback/coreboot_apc ]; \

1 0

← Newer
1
...
28
29
30
31
32
33
34
...
44
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot March 2010