Author: zbao
Date: Tue Nov 30 03:05:17 2010
New Revision: 6133
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6133
Log:
Trivial. Reindent and dos2unix.
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Acked-by: Zheng Bao <zheng.bao(a)amd.com>
Modified:
trunk/src/southbridge/amd/rs780/rs780_gfx.c
Modified: trunk/src/southbridge/amd/rs780/rs780_gfx.c
==============================================================================
--- trunk/src/southbridge/amd/rs780/rs780_gfx.c Mon Nov 29 21:40:33 2010 (r6132)
+++ trunk/src/southbridge/amd/rs780/rs780_gfx.c Tue Nov 30 03:05:17 2010 (r6133)
@@ -361,9 +361,9 @@
/* Force allow LDT_STOP Cool'n'Quiet workaround. */
*(GpuF0MMReg + 0x655c/4) |= 1<<4;
- // disable write combining, needed for stability
- // reference bios does this only for RS780 rev A11
- // need to figure out why we need it for all revs
+ // disable write combining, needed for stability
+ // reference bios does this only for RS780 rev A11
+ // need to figure out why we need it for all revs
*(GpuF0MMReg + 0x2000/4) = 0x00000010;
*(GpuF0MMReg + 0x2408/4) = 1 << 9;
*(GpuF0MMReg + 0x2000/4) = 0x00000011;
Author: ranma
Date: Mon Nov 29 21:40:33 2010
New Revision: 6132
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6132
Log:
Tobias Diedrich wrote:
> Stefan Reinauer wrote:
> > The specified IO port is most likely wrong. As the comment mentions, the
> > SSDT is a good place for that. A preprocessor define used both in the
> > CPU init code and in the asl would solve the problem without an SSDT.
> > For some info on CPU SSDT creation on intel check out
> > src/cpu/intel/speedstep/acpi.c
>
> The IO port is ok (and I wrote the comment myself ;)):
> DEFAULT_PMBASE is 0xe400
> PCNTRL reg offset is 0x10
>
> Using the preprocessor will probably work too if iasl can do simple
> arithmetic (likely yes), I'll look into that.
BTW, my first idea was to use an acpi method that looks up pmbase in
the pci cfg space, but when I define a method like this:
Method(TEST, 2)
{
Return (Add(Arg0, Arg1))
}
I get:
|build/mainboard/asus/p2b/dsdt.ramstage.asl 9: Processor (CPU0,
|0x01, TEST(0xe400, 0x10), 0x06) {}
|Error 4096 - syntax error, unexpected PARSEOP_NAMESEG,
|expecting ')' ^
While using the builtin Add() directly works.
Signed-off-by: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de>
Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de>
Modified:
trunk/src/mainboard/asus/p2b/dsdt.asl
trunk/src/southbridge/intel/i82371eb/i82371eb.h
Modified: trunk/src/mainboard/asus/p2b/dsdt.asl
==============================================================================
--- trunk/src/mainboard/asus/p2b/dsdt.asl Mon Nov 29 12:56:39 2010 (r6131)
+++ trunk/src/mainboard/asus/p2b/dsdt.asl Mon Nov 29 21:40:33 2010 (r6132)
@@ -17,14 +17,17 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
+#include "southbridge/intel/i82371eb/i82371eb.h"
+
DefinitionBlock ("DSDT.aml", "DSDT", 2, "CORE ", "COREBOOT", 1)
{
/* Define the main processor.*/
Scope (\_PR)
{
- /* Looks like the P_CNT field can't be a method or name
- * and has to be hardcoded to 0xe410 or generated in SSDT */
- Processor (CPU0, 0x01, 0xe410, 0x06) {}
+ /* Looks like the P_CNT field can't be a name or method (except
+ * builtins like Add()) and has to be hardcoded or generated
+ * into SSDT */
+ Processor (CPU0, 0x01, Add(DEFAULT_PMBASE, PCNTRL), 0x06) {}
}
/* For now only define 2 power states:
Modified: trunk/src/southbridge/intel/i82371eb/i82371eb.h
==============================================================================
--- trunk/src/southbridge/intel/i82371eb/i82371eb.h Mon Nov 29 12:56:39 2010 (r6131)
+++ trunk/src/southbridge/intel/i82371eb/i82371eb.h Mon Nov 29 21:40:33 2010 (r6132)
@@ -23,6 +23,7 @@
#if !defined(ASSEMBLY)
#if !defined(__PRE_RAM__)
+#if !defined(__ACPI__) /* dsdt include */
#include <arch/io.h>
#include <device/device.h>
@@ -33,6 +34,7 @@
#endif
#endif
+#endif
/* If 'cond' is true this macro sets the bit(s) specified by 'bits' in the
* 'reg' variable, otherwise it clears those bits.
The patch (attached) was tested by a user on IRC who had the F71889FG. I
wrote it using documentation from Fintek's website available here:
http://www.fintek.com.tw/files/productfiles/F71889_V0.28P.pdf
This patch also seems to work for the F71889ED, which uses 0x09 and 0x09 for
chip ID bytes 1 & 2. However, I have not been able to find documentation to
verify that the two chips are identical from superiotool's perspective.
The F71889 seems popular on current generation platforms with AMD chipsets,
in case there are folks looking to try it on a presently unsupported
board...
Signed-off-by: David Hendricks <dhendrix(a)google.com>
--
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.
Author: uwe
Date: Sun Nov 28 15:24:07 2010
New Revision: 6129
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6129
Log:
devicetree.cb: Only add as many entries as there are DIMM slots.
Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de>
Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de>
Modified:
trunk/src/mainboard/asus/a8n_e/devicetree.cb
trunk/src/mainboard/gigabyte/m57sli/devicetree.cb
trunk/src/mainboard/jetway/pa78vm5/devicetree.cb
trunk/src/mainboard/kontron/kt690/devicetree.cb
trunk/src/mainboard/msi/ms7260/devicetree.cb
trunk/src/mainboard/technexion/tim5690/devicetree.cb
trunk/src/mainboard/technexion/tim8690/devicetree.cb
Modified: trunk/src/mainboard/asus/a8n_e/devicetree.cb
==============================================================================
--- trunk/src/mainboard/asus/a8n_e/devicetree.cb Sat Nov 27 15:44:19 2010 (r6128)
+++ trunk/src/mainboard/asus/a8n_e/devicetree.cb Sun Nov 28 15:24:07 2010 (r6129)
@@ -87,18 +87,6 @@
# chip drivers/generic/generic # DIMM 0-1-1
# device i2c 53 on end
# end
- # chip drivers/generic/generic # DIMM 1-0-0
- # device i2c 54 on end
- # end
- # chip drivers/generic/generic # DIMM 1-0-1
- # device i2c 55 on end
- # end
- # chip drivers/generic/generic # DIMM 1-1-0
- # device i2c 56 on end
- # end
- # chip drivers/generic/generic # DIMM 1-1-1
- # device i2c 57 on end
- # end
end
device pci 2.0 on end # USB 1.1
device pci 2.1 on end # USB 2
Modified: trunk/src/mainboard/gigabyte/m57sli/devicetree.cb
==============================================================================
--- trunk/src/mainboard/gigabyte/m57sli/devicetree.cb Sat Nov 27 15:44:19 2010 (r6128)
+++ trunk/src/mainboard/gigabyte/m57sli/devicetree.cb Sun Nov 28 15:24:07 2010 (r6129)
@@ -118,18 +118,6 @@
chip drivers/generic/generic # DIMM 0-1-1
device i2c 53 on end
end
- chip drivers/generic/generic # DIMM 1-0-0
- device i2c 54 on end
- end
- chip drivers/generic/generic # DIMM 1-0-1
- device i2c 55 on end
- end
- chip drivers/generic/generic # DIMM 1-1-0
- device i2c 56 on end
- end
- chip drivers/generic/generic # DIMM 1-1-1
- device i2c 57 on end
- end
end
device pci 2.0 on end # USB 1.1
device pci 2.1 on end # USB 2
Modified: trunk/src/mainboard/jetway/pa78vm5/devicetree.cb
==============================================================================
--- trunk/src/mainboard/jetway/pa78vm5/devicetree.cb Sat Nov 27 15:44:19 2010 (r6128)
+++ trunk/src/mainboard/jetway/pa78vm5/devicetree.cb Sun Nov 28 15:24:07 2010 (r6129)
@@ -46,12 +46,6 @@
chip drivers/generic/generic #dimm 0-0-1
device i2c 51 on end
end
- chip drivers/generic/generic #dimm 0-1-0
- device i2c 52 on end
- end
- chip drivers/generic/generic #dimm 0-1-1
- device i2c 53 on end
- end
end # SM
device pci 14.1 on end # IDE 0x439c
device pci 14.2 on end # HDA 0x4383
Modified: trunk/src/mainboard/kontron/kt690/devicetree.cb
==============================================================================
--- trunk/src/mainboard/kontron/kt690/devicetree.cb Sat Nov 27 15:44:19 2010 (r6128)
+++ trunk/src/mainboard/kontron/kt690/devicetree.cb Sun Nov 28 15:24:07 2010 (r6129)
@@ -54,12 +54,6 @@
chip drivers/generic/generic #dimm 0-0-1
device i2c 51 on end
end
- chip drivers/generic/generic #dimm 0-1-0
- device i2c 52 on end
- end
- chip drivers/generic/generic #dimm 0-1-1
- device i2c 53 on end
- end
end # SM
device pci 14.1 on end # IDE 0x438c
device pci 14.2 on end # HDA 0x4383
Modified: trunk/src/mainboard/msi/ms7260/devicetree.cb
==============================================================================
--- trunk/src/mainboard/msi/ms7260/devicetree.cb Sat Nov 27 15:44:19 2010 (r6128)
+++ trunk/src/mainboard/msi/ms7260/devicetree.cb Sun Nov 28 15:24:07 2010 (r6129)
@@ -66,19 +66,6 @@
chip drivers/generic/generic # DIMM 0-1-1
device i2c 53 on end
end
- # TODO: Needed?
- # chip drivers/generic/generic # DIMM 1-0-0
- # device i2c 54 on end
- # end
- # chip drivers/generic/generic # DIMM 1-0-1
- # device i2c 55 on end
- # end
- # chip drivers/generic/generic # DIMM 1-1-0
- # device i2c 56 on end
- # end
- # chip drivers/generic/generic # DIMM 1-1-1
- # device i2c 57 on end
- # end
end
# TODO: Check if the stuff below is correct / needed.
device pci 1.1 on # SM 1
Modified: trunk/src/mainboard/technexion/tim5690/devicetree.cb
==============================================================================
--- trunk/src/mainboard/technexion/tim5690/devicetree.cb Sat Nov 27 15:44:19 2010 (r6128)
+++ trunk/src/mainboard/technexion/tim5690/devicetree.cb Sun Nov 28 15:24:07 2010 (r6129)
@@ -51,15 +51,6 @@
chip drivers/generic/generic #dimm 0-0-0
device i2c 50 on end
end
- chip drivers/generic/generic #dimm 0-0-1
- device i2c 51 on end
- end
- chip drivers/generic/generic #dimm 0-1-0
- device i2c 52 on end
- end
- chip drivers/generic/generic #dimm 0-1-1
- device i2c 53 on end
- end
end # SM
device pci 14.1 on end # IDE 0x438c
device pci 14.2 on end # HDA 0x4383
Modified: trunk/src/mainboard/technexion/tim8690/devicetree.cb
==============================================================================
--- trunk/src/mainboard/technexion/tim8690/devicetree.cb Sat Nov 27 15:44:19 2010 (r6128)
+++ trunk/src/mainboard/technexion/tim8690/devicetree.cb Sun Nov 28 15:24:07 2010 (r6129)
@@ -54,12 +54,6 @@
chip drivers/generic/generic #dimm 0-0-1
device i2c 51 on end
end
- chip drivers/generic/generic #dimm 0-1-0
- device i2c 52 on end
- end
- chip drivers/generic/generic #dimm 0-1-1
- device i2c 53 on end
- end
end # SM
device pci 14.1 on end # IDE 0x438c
device pci 14.2 on end # HDA 0x4383
Hello,
I am in desperate need of a full (all tables) ACPI dump from somone with a
i852 or i855 chipset. You can send it to me offlist if you like. Thanks in
advance.
--
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org
We have the following definition for CC:
CC:=gcc -Wa,--divide -fno-stack-protector -Wl,--build-id=none
I wonder if any one can explain the options, --divide and --build-id.
Thank you.