coreboot October 2010

coreboot@coreboot.org

55 participants
316 discussions

Start a nNew thread

[PATCH] Make i945/raminit.c:fsbclk() return u16 rather than int
by Peter Stuge 01 Oct '10

01 Oct '10

Attached. //Peter

1 0

build service results for r5892
by repository service 01 Oct '10

01 Oct '10

Dear coreboot readers! This is the automatic build system of coreboot. The developer "uwe" checked in revision 5892 to the coreboot repository. This caused the following changes: Change Log: Add missing parenthesis (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Build Log: Compilation of amd:mahogany_fam10 has been fixed Compilation of amd:serengeti_cheetah_fam10 has been fixed Compilation of amd:tilapia_fam10 has been fixed Compilation of asus:m4a785-m has been fixed Compilation of digitallogic:adl855pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=adl855pc&vendo… Compilation of getac:p470 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=p470&vendor=ge… Compilation of gigabyte:ma785gmt has been fixed Compilation of gigabyte:ma78gm has been fixed Compilation of hp:dl165_g6_fam10 has been fixed Compilation of ibase:mb899 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=mb899&vendor=i… Compilation of iei:kino-780am2-fam10 has been fixed Compilation of intel:d810e2cb is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=d810e2cb&vendo… Compilation of intel:d945gclf is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=d945gclf&vendo… Compilation of jetway:pa78vm5 has been fixed Compilation of kontron:986lcd-m is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=986lcd-m&vendo… Compilation of lanner:em8510 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=em8510&vendor=… Compilation of msi:ms9652_fam10 has been fixed Compilation of rca:rm4100 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=rm4100&vendor=… Compilation of roda:rk886ex is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=rk886ex&vendor… Compilation of supermicro:h8dmr_fam10 has been fixed Compilation of supermicro:h8qme_fam10 has been fixed Compilation of thomson:ip1000 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=ip1000&vendor=… Compilation of tyan:s2912_fam10 has been fixed Compilation of via:vt8454c is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5892&device=vt8454c&vendor… If something broke during this checkin please be a pain in uwe's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[PATCH]Remove useless defines
by Patrick Georgi 01 Oct '10

01 Oct '10

Hi, attached patch removes a couple of defines that seem to be the result of copy&paste, without actually being used. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de>

2 1

[PATCH] Split NORTHBRIDGE_INTEL_I945 into more precise _I945GC and _I945GM
by Peter Stuge 01 Oct '10

01 Oct '10

Patrick Georgi wrote: > Am 01.10.2010 01:33, schrieb Peter Stuge: > > would it work to simply make these options be > > NORTHBRIDGE_INTEL_I945GC and _I945GM .. > Thought about it - why I didn't do that: It significantly changes > the design of that part of the code. > The change above simply moves stuff around. Patrick Georgi wrote: > > Acked-by: Peter Stuge <peter(a)stuge.se> > Thanks, r5891 > > The help texts are cleaned up, and the chipset variant setting isn't > user visible anymore (I think - tested in "make config" only) Attached is the patch to remove the separate variant setting and put the info in the NORTHBRIDGE_ option. Build tested on Getac (GM) and d945gclf (GC). //Peter

2 1

[commit] r5893 - in trunk/src: mainboard/getac/p470 mainboard/ibase/mb899 mainboard/intel/d945gclf mainboard/kontron/986lcd-m mainboard/roda/rk886ex northbridge/intel northbridge/intel/i945
by repository service 01 Oct '10

01 Oct '10

Author: oxygene Date: Fri Oct 1 11:13:18 2010 New Revision: 5893 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5893 Log: Split NORTHBRIDGE_INTEL_I945 into more precise _I945GC and _I945GM Both chipsets use the src/northbridge/intel/i945 code but that code needs to know which chipset is actually used. Having separate NORTHBRIDGE_ options allows the I945GC/I945GM choice to be removed since code can test the NORTHBRIDGE_ option directly. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Modified: trunk/src/mainboard/getac/p470/Kconfig trunk/src/mainboard/ibase/mb899/Kconfig trunk/src/mainboard/intel/d945gclf/Kconfig trunk/src/mainboard/kontron/986lcd-m/Kconfig trunk/src/mainboard/roda/rk886ex/Kconfig trunk/src/northbridge/intel/Makefile.inc trunk/src/northbridge/intel/i945/Kconfig trunk/src/northbridge/intel/i945/raminit.c Modified: trunk/src/mainboard/getac/p470/Kconfig ============================================================================== --- trunk/src/mainboard/getac/p470/Kconfig Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/mainboard/getac/p470/Kconfig Fri Oct 1 11:13:18 2010 (r5893) @@ -23,7 +23,7 @@ select ARCH_X86 select CPU_INTEL_CORE select CPU_INTEL_SOCKET_MFCPGA478 - select NORTHBRIDGE_INTEL_I945 + select NORTHBRIDGE_INTEL_I945GM select SOUTHBRIDGE_INTEL_I82801GX select SOUTHBRIDGE_TI_PCIXX12 select SUPERIO_SMSC_FDC37N972 @@ -43,7 +43,6 @@ select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK - select I945GM select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR Modified: trunk/src/mainboard/ibase/mb899/Kconfig ============================================================================== --- trunk/src/mainboard/ibase/mb899/Kconfig Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/mainboard/ibase/mb899/Kconfig Fri Oct 1 11:13:18 2010 (r5893) @@ -5,7 +5,7 @@ select ARCH_X86 select CPU_INTEL_CORE select CPU_INTEL_SOCKET_MFCPGA478 - select NORTHBRIDGE_INTEL_I945 + select NORTHBRIDGE_INTEL_I945GM select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_WINBOND_W83627EHG select BOARD_HAS_FADT @@ -20,7 +20,6 @@ select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK - select I945GM select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR Modified: trunk/src/mainboard/intel/d945gclf/Kconfig ============================================================================== --- trunk/src/mainboard/intel/d945gclf/Kconfig Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/mainboard/intel/d945gclf/Kconfig Fri Oct 1 11:13:18 2010 (r5893) @@ -22,7 +22,7 @@ def_bool y select ARCH_X86 select CPU_INTEL_SOCKET_441 - select NORTHBRIDGE_INTEL_I945 + select NORTHBRIDGE_INTEL_I945GC select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_SMSC_LPC47M15X select BOARD_HAS_FADT @@ -40,7 +40,6 @@ select BOARD_ROMSIZE_KB_512 select GFXUMA select TINY_BOOTBLOCK - select I945GC select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR Modified: trunk/src/mainboard/kontron/986lcd-m/Kconfig ============================================================================== --- trunk/src/mainboard/kontron/986lcd-m/Kconfig Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/mainboard/kontron/986lcd-m/Kconfig Fri Oct 1 11:13:18 2010 (r5893) @@ -5,7 +5,7 @@ select ARCH_X86 select CPU_INTEL_CORE select CPU_INTEL_SOCKET_MFCPGA478 - select NORTHBRIDGE_INTEL_I945 + select NORTHBRIDGE_INTEL_I945GM select SOUTHBRIDGE_INTEL_I82801GX select SUPERIO_WINBOND_W83627THG select BOARD_HAS_FADT @@ -21,7 +21,6 @@ select GFXUMA select TINY_BOOTBLOCK select CHANNEL_XOR_RANDOMIZATION - select I945GM select OVERRIDE_CLOCK_DISABLE config MAINBOARD_DIR Modified: trunk/src/mainboard/roda/rk886ex/Kconfig ============================================================================== --- trunk/src/mainboard/roda/rk886ex/Kconfig Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/mainboard/roda/rk886ex/Kconfig Fri Oct 1 11:13:18 2010 (r5893) @@ -5,7 +5,7 @@ select ARCH_X86 select CPU_INTEL_CORE select CPU_INTEL_SOCKET_MFCPGA478 - select NORTHBRIDGE_INTEL_I945 + select NORTHBRIDGE_INTEL_I945GM select SOUTHBRIDGE_INTEL_I82801GX select SOUTHBRIDGE_TI_PCI7420 select SUPERIO_SMSC_LPC47N227 @@ -19,7 +19,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select I945GM select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR Modified: trunk/src/northbridge/intel/Makefile.inc ============================================================================== --- trunk/src/northbridge/intel/Makefile.inc Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/northbridge/intel/Makefile.inc Fri Oct 1 11:13:18 2010 (r5893) @@ -7,4 +7,5 @@ subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I82810) += i82810 subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I82830) += i82830 subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I855) += i855 -subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I945) += i945 +subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I945GC) += i945 +subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I945GM) += i945 Modified: trunk/src/northbridge/intel/i945/Kconfig ============================================================================== --- trunk/src/northbridge/intel/i945/Kconfig Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/northbridge/intel/i945/Kconfig Fri Oct 1 11:13:18 2010 (r5893) @@ -17,38 +17,27 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -config NORTHBRIDGE_INTEL_I945 +config NORTHBRIDGE_INTEL_I945GC bool select HAVE_DEBUG_RAM_SETUP +config NORTHBRIDGE_INTEL_I945GM + bool + select HAVE_DEBUG_RAM_SETUP + +if NORTHBRIDGE_INTEL_I945GC || NORTHBRIDGE_INTEL_I945GM + config FALLBACK_VGA_BIOS_ID string default "8086,27a2" - depends on NORTHBRIDGE_INTEL_I945 - -choice - default I945GM - depends on NORTHBRIDGE_INTEL_I945 - help - Different i945 variants require slightly different setup. - -config I945GM - bool "i945GM (Mobile) chipset" - -config I945GC - bool "i945GC chipset" - -endchoice config CHANNEL_XOR_RANDOMIZATION bool default n - depends on NORTHBRIDGE_INTEL_I945 config OVERRIDE_CLOCK_DISABLE bool default n - depends on NORTHBRIDGE_INTEL_I945 help Usually system firmware turns off system memory clock signals to unused SO-DIMM slots to reduce EMI and power @@ -59,8 +48,9 @@ config MAXIMUM_SUPPORTED_FREQUENCY int default 0 - depends on NORTHBRIDGE_INTEL_I945 help If non-zero, this designates the maximum DDR frequency the board supports, despite what the chipset should be capable of. + +endif Modified: trunk/src/northbridge/intel/i945/raminit.c ============================================================================== --- trunk/src/northbridge/intel/i945/raminit.c Fri Oct 1 11:11:15 2010 (r5892) +++ trunk/src/northbridge/intel/i945/raminit.c Fri Oct 1 11:13:18 2010 (r5893) @@ -90,7 +90,7 @@ static int memclk(void) { int offset = 0; -#if CONFIG_I945GM +#if defined(CONFIG_NORTHBRIDGE_INTEL_I945GM) offset++; #endif switch (((MCHBAR32(CLKCFG) >> 4) & 7) - offset) { @@ -102,7 +102,7 @@ return -1; } -#if CONFIG_I945GM +#if defined(CONFIG_NORTHBRIDGE_INTEL_I945GM) static int fsbclk(void) { switch (MCHBAR32(CLKCFG) & 7) { @@ -113,8 +113,7 @@ } return -1; } -#endif -#if CONFIG_I945GC +#elif defined(CONFIG_NORTHBRIDGE_INTEL_I945GC) static int fsbclk(void) { switch (MCHBAR32(CLKCFG) & 7) { @@ -1045,7 +1044,7 @@ return nc; } -#if CONFIG_I945GM +#if defined(CONFIG_NORTHBRIDGE_INTEL_I945GM) /* Strength multiplier tables */ static const u8 dual_channel_strength_multiplier[] = { 0x44, 0x11, 0x11, 0x11, 0x44, 0x44, 0x44, 0x11, @@ -1100,8 +1099,7 @@ 0x33, 0x00, 0x00, 0x11, 0x00, 0x44, 0x33, 0x11, 0x33, 0x00, 0x11, 0x00, 0x44, 0x44, 0x33, 0x11 }; -#endif -#if CONFIG_I945GC +#elif defined(CONFIG_NORTHBRIDGE_INTEL_I945GC) static const u8 dual_channel_strength_multiplier[] = { 0x44, 0x22, 0x00, 0x00, 0x44, 0x44, 0x44, 0x22, 0x44, 0x22, 0x00, 0x00, 0x44, 0x44, 0x44, 0x22, @@ -2155,7 +2153,7 @@ /** * We add the indices according to our clocks from CLKCFG. */ -#if CONFIG_I945GM +#if defined(CONFIG_NORTHBRIDGE_INTEL_I945GM) static const u32 data_clock_crossing[] = { 0x00100401, 0x00000000, /* DDR400 FSB400 */ 0xffffffff, 0xffffffff, /* nonexistant */ @@ -2200,8 +2198,7 @@ 0xffffffff, 0xffffffff, /* nonexistant */ }; -#endif -#if CONFIG_I945GC +#elif defined(CONFIG_NORTHBRIDGE_INTEL_I945GC) /* i945 G/P */ static const u32 data_clock_crossing[] = { 0xffffffff, 0xffffffff, /* nonexistant */ @@ -2792,10 +2789,9 @@ { u8 clocks[2] = { 0, 0 }; -#if CONFIG_I945GM +#if defined(CONFIG_NORTHBRIDGE_INTEL_I945GM) #define CLOCKS_WIDTH 2 -#endif -#if CONFIG_I945GC +#elif defined(CONFIG_NORTHBRIDGE_INTEL_I945GC) #define CLOCKS_WIDTH 3 #endif if (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED)

1 0

[commit] r5892 - trunk/src/cpu/amd/car
by repository service 01 Oct '10

01 Oct '10

Author: uwe Date: Fri Oct 1 11:11:15 2010 New Revision: 5892 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5892 Log: Add missing parenthesis (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/src/cpu/amd/car/cache_as_ram.inc Modified: trunk/src/cpu/amd/car/cache_as_ram.inc ============================================================================== --- trunk/src/cpu/amd/car/cache_as_ram.inc Fri Oct 1 10:02:45 2010 (r5891) +++ trunk/src/cpu/amd/car/cache_as_ram.inc Fri Oct 1 11:11:15 2010 (r5892) @@ -139,7 +139,7 @@ movl $MSR_MCFG_BASE, %ecx rdmsr andl $(~(0xfff00000 | (0xf << 2))), %eax - orl $((CONFIG_MMCONF_BASE_ADDRESS & 0xfff00000), %eax + orl $((CONFIG_MMCONF_BASE_ADDRESS & 0xfff00000)), %eax orl $((8 << 2) | (1 << 0)), %eax andl $(~(0x0000ffff)), %edx orl $(CONFIG_MMCONF_BASE_ADDRESS >> 32), %edx

1 0

build service results for r5891
by repository service 01 Oct '10

01 Oct '10

Dear coreboot readers! This is the automatic build system of coreboot. The developer "oxygene" checked in revision 5891 to the coreboot repository. This caused the following changes: Change Log: Move several i945 config #defines from romstage.c to Kconfig. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Peter Stuge <peter(a)stuge.se> Build Log: Compilation of amd:mahogany_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=mahogany_fam10… Compilation of amd:serengeti_cheetah_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=serengeti_chee… Compilation of amd:tilapia_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=tilapia_fam10&… Compilation of asus:m4a785-m is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=m4a785-m&vendo… Compilation of digitallogic:adl855pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=adl855pc&vendo… Compilation of getac:p470 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=p470&vendor=ge… Compilation of gigabyte:ma785gmt is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=ma785gmt&vendo… Compilation of gigabyte:ma78gm is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=ma78gm&vendor=… Compilation of hp:dl165_g6_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=dl165_g6_fam10… Compilation of ibase:mb899 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=mb899&vendor=i… Compilation of iei:kino-780am2-fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=kino-780am2-fa… Compilation of intel:d810e2cb is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=d810e2cb&vendo… Compilation of intel:d945gclf has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=d945gclf&vendo… Compilation of jetway:pa78vm5 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=pa78vm5&vendor… Compilation of kontron:986lcd-m has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=986lcd-m&vendo… Compilation of lanner:em8510 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=em8510&vendor=… Compilation of msi:ms9652_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=ms9652_fam10&v… Compilation of rca:rm4100 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=rm4100&vendor=… Compilation of roda:rk886ex has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=rk886ex&vendor… Compilation of supermicro:h8dmr_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=h8dmr_fam10&ve… Compilation of supermicro:h8qme_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=h8qme_fam10&ve… Compilation of thomson:ip1000 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=ip1000&vendor=… Compilation of tyan:s2912_fam10 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=s2912_fam10&ve… Compilation of via:vt8454c is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5891&device=vt8454c&vendor… If something broke during this checkin please be a pain in oxygene's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[PATCH] Make hidden configuration flags visible (i945)
by Patrick Georgi 01 Oct '10

01 Oct '10

Hi, attached patch moves several config flags that, for historical reasons, were put in romstage.c into Kconfig. This ensures that all parts of the coreboot build on affected boards have a chance to use these flags, which will be useful when removing .c-includes in romstage.c It's also a first step towards removing yet another config system (manual #defines) from the tree. Maybe these flags could be done away with somehow, maybe they should be declared in other parts of the tree (eg. chipset). This is a first safe step, so I didn't think too much about moving them elsewhere. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de>

3 6

[commit] r5891 - in trunk/src: mainboard/getac/p470 mainboard/ibase/mb899 mainboard/intel/d945gclf mainboard/kontron/986lcd-m mainboard/roda/rk886ex northbridge/intel/i945
by repository service 01 Oct '10

01 Oct '10

Author: oxygene Date: Fri Oct 1 10:02:45 2010 New Revision: 5891 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5891 Log: Move several i945 config #defines from romstage.c to Kconfig. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/src/mainboard/getac/p470/Kconfig trunk/src/mainboard/getac/p470/romstage.c trunk/src/mainboard/ibase/mb899/Kconfig trunk/src/mainboard/ibase/mb899/romstage.c trunk/src/mainboard/intel/d945gclf/Kconfig trunk/src/mainboard/intel/d945gclf/romstage.c trunk/src/mainboard/kontron/986lcd-m/Kconfig trunk/src/mainboard/kontron/986lcd-m/romstage.c trunk/src/mainboard/roda/rk886ex/Kconfig trunk/src/mainboard/roda/rk886ex/romstage.c trunk/src/northbridge/intel/i945/Kconfig trunk/src/northbridge/intel/i945/raminit.c Modified: trunk/src/mainboard/getac/p470/Kconfig ============================================================================== --- trunk/src/mainboard/getac/p470/Kconfig Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/getac/p470/Kconfig Fri Oct 1 10:02:45 2010 (r5891) @@ -43,6 +43,8 @@ select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK + select I945GM + select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR string Modified: trunk/src/mainboard/getac/p470/romstage.c ============================================================================== --- trunk/src/mainboard/getac/p470/romstage.c Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/getac/p470/romstage.c Fri Oct 1 10:02:45 2010 (r5891) @@ -19,10 +19,6 @@ * MA 02110-1301 USA */ -/* Configuration of the i945 driver */ -#define CHIPSET_I945GM 1 -#define CHANNEL_XOR_RANDOMIZATION 1 - #include <stdint.h> #include <string.h> #include <arch/io.h> Modified: trunk/src/mainboard/ibase/mb899/Kconfig ============================================================================== --- trunk/src/mainboard/ibase/mb899/Kconfig Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/ibase/mb899/Kconfig Fri Oct 1 10:02:45 2010 (r5891) @@ -20,6 +20,8 @@ select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK + select I945GM + select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR string Modified: trunk/src/mainboard/ibase/mb899/romstage.c ============================================================================== --- trunk/src/mainboard/ibase/mb899/romstage.c Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/ibase/mb899/romstage.c Fri Oct 1 10:02:45 2010 (r5891) @@ -19,11 +19,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct. -/* Configuration of the i945 driver */ -#define CHIPSET_I945GM 1 -//#define OVERRIDE_CLOCK_DISABLE 1 -#define CHANNEL_XOR_RANDOMIZATION 1 - #include <stdint.h> #include <string.h> #include <arch/io.h> Modified: trunk/src/mainboard/intel/d945gclf/Kconfig ============================================================================== --- trunk/src/mainboard/intel/d945gclf/Kconfig Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/intel/d945gclf/Kconfig Fri Oct 1 10:02:45 2010 (r5891) @@ -40,6 +40,8 @@ select BOARD_ROMSIZE_KB_512 select GFXUMA select TINY_BOOTBLOCK + select I945GC + select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR string Modified: trunk/src/mainboard/intel/d945gclf/romstage.c ============================================================================== --- trunk/src/mainboard/intel/d945gclf/romstage.c Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/intel/d945gclf/romstage.c Fri Oct 1 10:02:45 2010 (r5891) @@ -19,10 +19,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct. -/* Configuration of the i945 driver */ -#define CHIPSET_I945GC 1 -#define CHANNEL_XOR_RANDOMIZATION 1 - #include <stdint.h> #include <string.h> #include <arch/io.h> Modified: trunk/src/mainboard/kontron/986lcd-m/Kconfig ============================================================================== --- trunk/src/mainboard/kontron/986lcd-m/Kconfig Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/kontron/986lcd-m/Kconfig Fri Oct 1 10:02:45 2010 (r5891) @@ -20,6 +20,9 @@ select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK + select CHANNEL_XOR_RANDOMIZATION + select I945GM + select OVERRIDE_CLOCK_DISABLE config MAINBOARD_DIR string Modified: trunk/src/mainboard/kontron/986lcd-m/romstage.c ============================================================================== --- trunk/src/mainboard/kontron/986lcd-m/romstage.c Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/kontron/986lcd-m/romstage.c Fri Oct 1 10:02:45 2010 (r5891) @@ -19,19 +19,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct. -/* Configuration of the i945 driver */ -#define CHIPSET_I945GM 1 -/* Usually system firmware turns off system memory clock signals to - * unused SO-DIMM slots to reduce EMI and power consumption. - * However, the Kontron 986LCD-M does not like unused clock signals to - * be disabled. If other similar mainboard occur, it would make sense - * to make this an entry in the sysinfo structure, and pre-initialize that - * structure in the mainboard's romstage.c main() function. For now a - * #define will do. - */ -#define OVERRIDE_CLOCK_DISABLE 1 -#define CHANNEL_XOR_RANDOMIZATION 1 - #include <stdint.h> #include <string.h> #include <arch/io.h> Modified: trunk/src/mainboard/roda/rk886ex/Kconfig ============================================================================== --- trunk/src/mainboard/roda/rk886ex/Kconfig Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/roda/rk886ex/Kconfig Fri Oct 1 10:02:45 2010 (r5891) @@ -19,6 +19,8 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 + select I945GM + select CHANNEL_XOR_RANDOMIZATION config MAINBOARD_DIR string @@ -56,4 +58,8 @@ hex default 0x6886 +config MAXIMUM_SUPPORTED_FREQUENCY + int + default 400 + endif # BOARD_RODA_RK886EX Modified: trunk/src/mainboard/roda/rk886ex/romstage.c ============================================================================== --- trunk/src/mainboard/roda/rk886ex/romstage.c Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/mainboard/roda/rk886ex/romstage.c Fri Oct 1 10:02:45 2010 (r5891) @@ -21,12 +21,6 @@ // __PRE_RAM__ means: use "unsigned" for device, not a struct. -/* Configuration of the i945 driver */ -#define CHIPSET_I945GM 1 -#define CHANNEL_XOR_RANDOMIZATION 1 -// Rocky freezing temperature settings: -#define MAXIMUM_SUPPORTED_FREQUENCY 400 - #include <stdint.h> #include <string.h> #include <arch/io.h> Modified: trunk/src/northbridge/intel/i945/Kconfig ============================================================================== --- trunk/src/northbridge/intel/i945/Kconfig Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/northbridge/intel/i945/Kconfig Fri Oct 1 10:02:45 2010 (r5891) @@ -26,3 +26,41 @@ default "8086,27a2" depends on NORTHBRIDGE_INTEL_I945 +choice + default I945GM + depends on NORTHBRIDGE_INTEL_I945 + help + Different i945 variants require slightly different setup. + +config I945GM + bool "i945GM (Mobile) chipset" + +config I945GC + bool "i945GC chipset" + +endchoice + +config CHANNEL_XOR_RANDOMIZATION + bool + default n + depends on NORTHBRIDGE_INTEL_I945 + +config OVERRIDE_CLOCK_DISABLE + bool + default n + depends on NORTHBRIDGE_INTEL_I945 + help + Usually system firmware turns off system memory clock + signals to unused SO-DIMM slots to reduce EMI and power + consumption. + However, some boards do not like unused clock signals to + be disabled. + +config MAXIMUM_SUPPORTED_FREQUENCY + int + default 0 + depends on NORTHBRIDGE_INTEL_I945 + help + If non-zero, this designates the maximum DDR frequency + the board supports, despite what the chipset should be + capable of. Modified: trunk/src/northbridge/intel/i945/raminit.c ============================================================================== --- trunk/src/northbridge/intel/i945/raminit.c Fri Oct 1 09:27:51 2010 (r5890) +++ trunk/src/northbridge/intel/i945/raminit.c Fri Oct 1 10:02:45 2010 (r5891) @@ -90,7 +90,7 @@ static int memclk(void) { int offset = 0; -#ifdef CHIPSET_I945GM +#if CONFIG_I945GM offset++; #endif switch (((MCHBAR32(CLKCFG) >> 4) & 7) - offset) { @@ -102,7 +102,7 @@ return -1; } -#ifdef CHIPSET_I945GM +#if CONFIG_I945GM static int fsbclk(void) { switch (MCHBAR32(CLKCFG) & 7) { @@ -114,7 +114,7 @@ return -1; } #endif -#ifdef CHIPSET_I945GC +#if CONFIG_I945GC static int fsbclk(void) { switch (MCHBAR32(CLKCFG) & 7) { @@ -131,8 +131,8 @@ { u32 reg32; -#ifdef MAXIMUM_SUPPORTED_FREQUENCY - return MAXIMUM_SUPPORTED_FREQUENCY; +#if CONFIG_MAXIMUM_SUPPORTED_FREQUENCY + return CONFIG_MAXIMUM_SUPPORTED_FREQUENCY; #endif reg32 = pci_read_config32(PCI_DEV(0, 0x00, 0), 0xe4); /* CAPID0 + 4 */ @@ -1045,7 +1045,7 @@ return nc; } -#ifdef CHIPSET_I945GM +#if CONFIG_I945GM /* Strength multiplier tables */ static const u8 dual_channel_strength_multiplier[] = { 0x44, 0x11, 0x11, 0x11, 0x44, 0x44, 0x44, 0x11, @@ -1101,7 +1101,7 @@ 0x33, 0x00, 0x11, 0x00, 0x44, 0x44, 0x33, 0x11 }; #endif -#ifdef CHIPSET_I945GC +#if CONFIG_I945GC static const u8 dual_channel_strength_multiplier[] = { 0x44, 0x22, 0x00, 0x00, 0x44, 0x44, 0x44, 0x22, 0x44, 0x22, 0x00, 0x00, 0x44, 0x44, 0x44, 0x22, @@ -2155,7 +2155,7 @@ /** * We add the indices according to our clocks from CLKCFG. */ -#ifdef CHIPSET_I945GM +#if CONFIG_I945GM static const u32 data_clock_crossing[] = { 0x00100401, 0x00000000, /* DDR400 FSB400 */ 0xffffffff, 0xffffffff, /* nonexistant */ @@ -2201,7 +2201,7 @@ }; #endif -#ifdef CHIPSET_I945GC +#if CONFIG_I945GC /* i945 G/P */ static const u32 data_clock_crossing[] = { 0xffffffff, 0xffffffff, /* nonexistant */ @@ -2420,7 +2420,7 @@ if (sysinfo->interleaved) { reg32 = MCHBAR32(DCC); -#if CHANNEL_XOR_RANDOMIZATION +#if CONFIG_CHANNEL_XOR_RANDOMIZATION reg32 &= ~(1 << 10); reg32 |= (1 << 9); #else @@ -2792,10 +2792,10 @@ { u8 clocks[2] = { 0, 0 }; -#ifdef CHIPSET_I945GM +#if CONFIG_I945GM #define CLOCKS_WIDTH 2 #endif -#ifdef CHIPSET_I945GC +#if CONFIG_I945GC #define CLOCKS_WIDTH 3 #endif if (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) @@ -2810,15 +2810,11 @@ if (sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED) clocks[1] |= ((1 << CLOCKS_WIDTH)-1) << CLOCKS_WIDTH; -#ifdef OVERRIDE_CLOCK_DISABLE +#if CONFIG_OVERRIDE_CLOCK_DISABLE /* Usually system firmware turns off system memory clock signals * to unused SO-DIMM slots to reduce EMI and power consumption. * However, the Kontron 986LCD-M does not like unused clock * signals to be disabled. - * If other similar mainboard occur, it would make sense to make - * this an entry in the sysinfo structure, and pre-initialize that - * structure in the mainboard's romstage.c main() function. - * For now an #ifdef will do. */ clocks[0] = 0xf; /* force all clock gate pairs to enable */

1 0

build service results for r5890
by repository service 01 Oct '10

01 Oct '10

Dear coreboot readers! This is the automatic build system of coreboot. The developer "uwe" checked in revision 5890 to the coreboot repository. This caused the following changes: Change Log: CAR simplifications, typos, readability improvements (trivial). - Use some more #defines instead of hard-coding values. - Merge multiple movl/orl or movl/andl lines into one where possible. - Add some TODOs in places which seem to have either an incorrect code or incorrect comment. - Fix typos: s/for/from/, s/BSC/BSP/, s/size/carsize/. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Build Log: Compilation of amd:mahogany_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=mahogany_fam10… Compilation of amd:serengeti_cheetah_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=serengeti_chee… Compilation of amd:tilapia_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=tilapia_fam10&… Compilation of asus:m4a785-m has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=m4a785-m&vendo… Compilation of digitallogic:adl855pc has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=adl855pc&vendo… Compilation of gigabyte:ma785gmt has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=ma785gmt&vendo… Compilation of gigabyte:ma78gm has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=ma78gm&vendor=… Compilation of hp:dl165_g6_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=dl165_g6_fam10… Compilation of iei:kino-780am2-fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=kino-780am2-fa… Compilation of intel:d810e2cb has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=d810e2cb&vendo… Compilation of jetway:pa78vm5 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=pa78vm5&vendor… Compilation of lanner:em8510 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=em8510&vendor=… Compilation of msi:ms9652_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=ms9652_fam10&v… Compilation of rca:rm4100 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=rm4100&vendor=… Compilation of supermicro:h8dmr_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=h8dmr_fam10&ve… Compilation of supermicro:h8qme_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=h8qme_fam10&ve… Compilation of thomson:ip1000 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=ip1000&vendor=… Compilation of tyan:s2912_fam10 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=s2912_fam10&ve… Compilation of via:vt8454c has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=5890&device=vt8454c&vendor… If something broke during this checkin please be a pain in uwe's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot October 2010