coreboot May 2009

coreboot@coreboot.org

92 participants
571 discussions

build service results for r4308
by coreboot information 26 May '09

26 May '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 4308 to the coreboot repository. This caused the following changes: Change Log: encapsule mbi initialization in write_multiboot_table, where it belongs. (very simple and trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Build Log: Compilation of embeddedplanet:ep405pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4308&device=ep405pc&vendor… Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4308&device=sandpointx3_al… Compilation of totalimpact:briq is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4308&device=briq&vendor=to… If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[PATCH] reentrant and .bss-less vsprintf
by Patrick Georgi 26 May '09

26 May '09

Hi, attached patch kills a global variable, and makes vsprintf reentrant and work without requiring .bss space. Make vsprintf reentrant. More importantly, eliminate global variable. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Index: src/console/vsprintf.c =================================================================== --- src/console/vsprintf.c (Revision 1725) +++ src/console/vsprintf.c (Arbeitskopie) @@ -15,20 +15,16 @@ -/* FIXME this global makes vsprintf non-reentrant */ - -static char *str_buf; -static void str_tx_byte(unsigned char byte) -{ - *str_buf = byte; - str_buf++; -} - int vsprintf(char * buf, const char *fmt, va_list args) { + char *str_buf; + void str_tx_byte(unsigned char byte) + { + *str_buf = byte; + str_buf++; + } + int i; str_buf = buf; i = vtxprintf(str_tx_byte, fmt, args); - /* maeder/Ispiri -- The null termination was missing a deference */ - /* and was just zeroing out the pointer instead */ *str_buf = '\0'; return i; }

5 6

build service results for r4307
by coreboot information 26 May '09

26 May '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "oxygene" checked in revision 4307 to the coreboot repository. This caused the following changes: Change Log: Make vsprintf reentrant. More importantly, eliminate global variable. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Build Log: Compilation of embeddedplanet:ep405pc has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4307&device=ep405pc&vendor… Compilation of motorola:sandpointx3_altimus_mpc7410 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4307&device=sandpointx3_al… Compilation of totalimpact:briq has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4307&device=briq&vendor=to… If something broke during this checkin please be a pain in oxygene's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[PATCH] Remove scanbuild warning in hypertransport.c
by Myles Watson 26 May '09

26 May '09

Scanbuild finds a possible null pointer dereference here: http://www.coreboot.org/~stepan/coreboot-scanbuild/kontron_986lcd-m-scanbui… There are two ways that I thought of fixing it. The first way is just to insert an if (first == NULL) return NULL; at line 53 and remove the if (first) condition. The only problem with that is that it makes the change look bigger than it is. Here's a simpler looking change. Either one is fine with me. Boot tested on s2892. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Thanks, Myles

1 0

[v2] r4309 - trunk/coreboot-v2/src/arch/i386/lib
by svn＠coreboot.org 26 May '09

26 May '09

Author: oxygene Date: 2009-05-26 16:49:59 +0200 (Tue, 26 May 2009) New Revision: 4309 Modified: trunk/coreboot-v2/src/arch/i386/lib/console_printk.c Log: Make printk_* behaviour more consistent. Without it, side effects in the arguments (eg. a pci config read, or variable increment) "vanish" with the message, and the behaviour changes. Some of these effects might be unwanted, but at least they are consistent now. To reduce the memory footprint slightly, the formatted strings are discarded. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/arch/i386/lib/console_printk.c =================================================================== --- trunk/coreboot-v2/src/arch/i386/lib/console_printk.c 2009-05-26 14:37:17 UTC (rev 4308) +++ trunk/coreboot-v2/src/arch/i386/lib/console_printk.c 2009-05-26 14:49:59 UTC (rev 4309) @@ -13,39 +13,39 @@ #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_EMERG #undef printk_emerg -#define printk_emerg(fmt, arg...) do {} while(0) +#define printk_emerg(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_ALERT #undef printk_alert -#define printk_alert(fmt, arg...) do {} while(0) +#define printk_alert(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_CRIT #undef printk_crit -#define printk_crit(fmt, arg...) do {} while(0) +#define printk_crit(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_ERR #undef printk_err -#define printk_err(fmt, arg...) do {} while(0) +#define printk_err(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_WARNING #undef printk_warning -#define printk_warning(fmt, arg...) do {} while(0) +#define printk_warning(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_NOTICE #undef printk_notice -#define printk_notice(fmt, arg...) do {} while(0) +#define printk_notice(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_INFO #undef printk_info -#define printk_info(fmt, arg...) do {} while(0) +#define printk_info(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_DEBUG #undef printk_debug -#define printk_debug(fmt, arg...) do {} while(0) +#define printk_debug(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #if MAXIMUM_CONSOLE_LOGLEVEL <= BIOS_SPEW #undef printk_spew -#define printk_spew(fmt, arg...) do {} while(0) +#define printk_spew(fmt, arg...) do_printk(BIOS_EMERG , "", ##arg) #endif #define print_emerg(STR) printk_emerg ("%s", (STR))

1 0

[v2] r4308 - trunk/coreboot-v2/src/arch/i386/boot
by svn＠coreboot.org 26 May '09

26 May '09

Author: stepan Date: 2009-05-26 16:37:17 +0200 (Tue, 26 May 2009) New Revision: 4308 Modified: trunk/coreboot-v2/src/arch/i386/boot/multiboot.c trunk/coreboot-v2/src/arch/i386/boot/tables.c Log: encapsule mbi initialization in write_multiboot_table, where it belongs. (very simple and trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/arch/i386/boot/multiboot.c =================================================================== --- trunk/coreboot-v2/src/arch/i386/boot/multiboot.c 2009-05-26 14:31:37 UTC (rev 4307) +++ trunk/coreboot-v2/src/arch/i386/boot/multiboot.c 2009-05-26 14:37:17 UTC (rev 4308) @@ -24,7 +24,7 @@ #include <console/console.h> static struct multiboot_mmap_entry *mb_mem; -struct multiboot_info *mbi; +struct multiboot_info *mbi = NULL; static struct { u64 addr; @@ -80,12 +80,17 @@ { int i; + mbi = (struct multiboot_info *)rom_table_end; + memset(mbi, 0, sizeof(*mbi)); rom_table_end += sizeof(*mbi); mbi->mmap_addr = (u32) rom_table_end; mb_mem = (struct multiboot_mmap_entry *)rom_table_end; + /* FIXME This code is broken, it does not know about high memory + * tables, nor does it reserve the coreboot table area. + */ /* reserved regions */ reserved_mem[0].addr = low_table_start; reserved_mem[0].len = ROUND(low_table_end - low_table_start, 4096); Modified: trunk/coreboot-v2/src/arch/i386/boot/tables.c =================================================================== --- trunk/coreboot-v2/src/arch/i386/boot/tables.c 2009-05-26 14:31:37 UTC (rev 4307) +++ trunk/coreboot-v2/src/arch/i386/boot/tables.c 2009-05-26 14:37:17 UTC (rev 4308) @@ -154,7 +154,6 @@ #if CONFIG_MULTIBOOT /* The Multiboot information structure */ - mbi = (struct multiboot_info *)rom_table_end; rom_table_end = write_multiboot_info( low_table_start, low_table_end, rom_table_start, rom_table_end);

1 0

[v2] r4307 - trunk/coreboot-v2/src/console
by svn＠coreboot.org 26 May '09

26 May '09

Author: oxygene Date: 2009-05-26 16:31:37 +0200 (Tue, 26 May 2009) New Revision: 4307 Modified: trunk/coreboot-v2/src/console/vsprintf.c Log: Make vsprintf reentrant. More importantly, eliminate global variable. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/coreboot-v2/src/console/vsprintf.c =================================================================== --- trunk/coreboot-v2/src/console/vsprintf.c 2009-05-26 14:07:44 UTC (rev 4306) +++ trunk/coreboot-v2/src/console/vsprintf.c 2009-05-26 14:31:37 UTC (rev 4307) @@ -13,22 +13,22 @@ int vtxprintf(void (*tx_byte)(unsigned char byte), const char *fmt, va_list args); -/* FIXME this global makes vsprintf non-reentrant */ - -static char *str_buf; -static void str_tx_byte(unsigned char byte) +int vsprintf(char * buf, const char *fmt, va_list args) { - *str_buf = byte; - str_buf++; -} + char *str_buf; -int vsprintf(char * buf, const char *fmt, va_list args) -{ + /* this function is only used by vsprint. + To keep str_buf local (for reentrancy + and to avoid .bss use, nest it */ + void str_tx_byte(unsigned char byte) + { + *str_buf = byte; + str_buf++; + } + int i; str_buf = buf; i = vtxprintf(str_tx_byte, fmt, args); - /* maeder/Ispiri -- The null termination was missing a deference */ - /* and was just zeroing out the pointer instead */ *str_buf = '\0'; return i; }

1 0

[PATCH] libpayload: lpgcc fix
by Stefan Reinauer 26 May '09

26 May '09

This is required because of the multi arch code that recently went in. Stefan -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

2 1

build service results for r4303
by coreboot information 26 May '09

26 May '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 4303 to the coreboot repository. This caused the following changes: Change Log: the i82801xx driver does not know ide{0,1}_enable in its chip.h, so comment it out in the mainboard config file. (trivial) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Build Log: Compilation of asus:mew-am has been fixed If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[PATCH] simplify table generation code
by Stefan Reinauer 26 May '09

26 May '09

See patch -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

2 2

← Newer
1
...
13
14
15
16
17
18
19
...
58
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot May 2009